Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-12-18 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/#review194102
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Dec. 15, 2017, 1:42 p.m., Endre Zoltan Kovacs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62850/
> ---
> 
> (Updated Dec. 15, 2017, 1:42 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1827
> https://issues.apache.org/jira/browse/RANGER-1827
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> created a microbenchmark for the policy evaluation engine
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  25f533476 
>   ranger-tools/pom.xml ff37fb3eb 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
> e6095cba2 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  PRE-CREATION 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  PRE-CREATION 
>   ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
>   ranger-tools/src/test/resources/testdata/performance-chart.template 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-policy-template.json 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-request-template.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62850/diff/8/
> 
> 
> Testing
> ---
> 
> A parameterized JUnit test that tests the performance of RangerPolicyEngine 
> under increasing load of number of policies and concurrent calls.
> a cross product of the input parameters are generated and fed into the test 
> method.
> 
> This microbenchmark includes a warm-up phase so that any of the JIT 
> performance optimizations happen before the measurement of the policy 
> engine's performance.
> 
> 
> File Attachments
> 
> 
> 0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-12-15 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/
---

(Updated Dec. 15, 2017, 2:42 p.m.)


Review request for ranger.


Changes
---

recut to make it jdk7 compliant


Bugs: RANGER-1827
https://issues.apache.org/jira/browse/RANGER-1827


Repository: ranger


Description
---

created a microbenchmark for the policy evaluation engine


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 
25f533476 
  ranger-tools/pom.xml ff37fb3eb 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
e6095cba2 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
 PRE-CREATION 
  
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
 PRE-CREATION 
  ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
  ranger-tools/src/test/resources/testdata/performance-chart.template 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-policy-template.json 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-request-template.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62850/diff/8/

Changes: https://reviews.apache.org/r/62850/diff/7-8/


Testing
---

A parameterized JUnit test that tests the performance of RangerPolicyEngine 
under increasing load of number of policies and concurrent calls.
a cross product of the input parameters are generated and fed into the test 
method.

This microbenchmark includes a warm-up phase so that any of the JIT performance 
optimizations happen before the measurement of the policy engine's performance.


File Attachments


0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch


Thanks,

Endre Zoltan Kovacs

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-12-07 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/#review193112
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 20, 2017, 12:08 p.m., Endre Zoltan Kovacs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62850/
> ---
> 
> (Updated Oct. 20, 2017, 12:08 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1827
> https://issues.apache.org/jira/browse/RANGER-1827
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> created a microbenchmark for the policy evaluation engine
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  25f533476 
>   ranger-tools/pom.xml ff37fb3eb 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
> e6095cba2 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  PRE-CREATION 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  PRE-CREATION 
>   ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
>   ranger-tools/src/test/resources/testdata/performance-chart.template 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-policy-template.json 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-request-template.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62850/diff/7/
> 
> 
> Testing
> ---
> 
> A parameterized JUnit test that tests the performance of RangerPolicyEngine 
> under increasing load of number of policies and concurrent calls.
> a cross product of the input parameters are generated and fed into the test 
> method.
> 
> This microbenchmark includes a warm-up phase so that any of the JIT 
> performance optimizations happen before the measurement of the policy 
> engine's performance.
> 
> 
> File Attachments
> 
> 
> 0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-20 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/
---

(Updated Oct. 20, 2017, 12:08 p.m.)


Review request for ranger.


Changes
---

added license header to html template file to fix build


Bugs: RANGER-1827
https://issues.apache.org/jira/browse/RANGER-1827


Repository: ranger


Description
---

created a microbenchmark for the policy evaluation engine


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 
25f533476 
  ranger-tools/pom.xml ff37fb3eb 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
e6095cba2 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
 PRE-CREATION 
  
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
 PRE-CREATION 
  ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
  ranger-tools/src/test/resources/testdata/performance-chart.template 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-policy-template.json 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-request-template.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62850/diff/7/

Changes: https://reviews.apache.org/r/62850/diff/6-7/


Testing
---

A parameterized JUnit test that tests the performance of RangerPolicyEngine 
under increasing load of number of policies and concurrent calls.
a cross product of the input parameters are generated and fed into the test 
method.

This microbenchmark includes a warm-up phase so that any of the JIT performance 
optimizations happen before the measurement of the policy engine's performance.


File Attachments


0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch


Thanks,

Endre Zoltan Kovacs

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-16 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/
---

(Updated Oct. 16, 2017, 8:32 a.m.)


Review request for ranger.


Changes
---

added missing runWith junit annotation


Bugs: RANGER-1827
https://issues.apache.org/jira/browse/RANGER-1827


Repository: ranger


Description
---

created a microbenchmark for the policy evaluation engine


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 
25f533476 
  ranger-tools/pom.xml ff37fb3eb 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
e6095cba2 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
 PRE-CREATION 
  
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
 PRE-CREATION 
  ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
  ranger-tools/src/test/resources/testdata/performance-chart.template 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-policy-template.json 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-request-template.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62850/diff/6/

Changes: https://reviews.apache.org/r/62850/diff/5-6/


Testing
---

A parameterized JUnit test that tests the performance of RangerPolicyEngine 
under increasing load of number of policies and concurrent calls.
a cross product of the input parameters are generated and fed into the test 
method.

This microbenchmark includes a warm-up phase so that any of the JIT performance 
optimizations happen before the measurement of the policy engine's performance.


File Attachments


0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch


Thanks,

Endre Zoltan Kovacs

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/#review187867
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 12, 2017, 8:57 p.m., Endre Zoltan Kovacs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62850/
> ---
> 
> (Updated Oct. 12, 2017, 8:57 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1827
> https://issues.apache.org/jira/browse/RANGER-1827
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> created a microbenchmark for the policy evaluation engine
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  25f533476 
>   ranger-tools/pom.xml ff37fb3eb 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
> e6095cba2 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  PRE-CREATION 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  PRE-CREATION 
>   ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
>   ranger-tools/src/test/resources/testdata/performance-chart.template 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-policy-template.json 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-request-template.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62850/diff/5/
> 
> 
> Testing
> ---
> 
> A parameterized JUnit test that tests the performance of RangerPolicyEngine 
> under increasing load of number of policies and concurrent calls.
> a cross product of the input parameters are generated and fed into the test 
> method.
> 
> This microbenchmark includes a warm-up phase so that any of the JIT 
> performance optimizations happen before the measurement of the policy 
> engine's performance.
> 
> 
> File Attachments
> 
> 
> 0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-12 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/
---

(Updated Oct. 12, 2017, 8:57 p.m.)


Review request for ranger.


Changes
---

updated markup template


Bugs: RANGER-1827
https://issues.apache.org/jira/browse/RANGER-1827


Repository: ranger


Description
---

created a microbenchmark for the policy evaluation engine


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 
25f533476 
  ranger-tools/pom.xml ff37fb3eb 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
e6095cba2 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
 PRE-CREATION 
  
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
 PRE-CREATION 
  ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
  ranger-tools/src/test/resources/testdata/performance-chart.template 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-policy-template.json 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-request-template.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62850/diff/5/

Changes: https://reviews.apache.org/r/62850/diff/4-5/


Testing
---

A parameterized JUnit test that tests the performance of RangerPolicyEngine 
under increasing load of number of policies and concurrent calls.
a cross product of the input parameters are generated and fed into the test 
method.

This microbenchmark includes a warm-up phase so that any of the JIT performance 
optimizations happen before the measurement of the policy engine's performance.


File Attachments


0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch


Thanks,

Endre Zoltan Kovacs

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-12 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/
---

(Updated Oct. 12, 2017, 8:54 p.m.)


Review request for ranger.


Changes
---

incorporated Madhan Neethiraj's suggestions also added an after class method to 
chart performance results


Bugs: RANGER-1827
https://issues.apache.org/jira/browse/RANGER-1827


Repository: ranger


Description
---

created a microbenchmark for the policy evaluation engine


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 
25f533476 
  ranger-tools/pom.xml ff37fb3eb 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
e6095cba2 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
 PRE-CREATION 
  
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
 PRE-CREATION 
  ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
  ranger-tools/src/test/resources/testdata/performance-chart.template 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-policy-template.json 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-request-template.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62850/diff/4/

Changes: https://reviews.apache.org/r/62850/diff/3-4/


Testing
---

A parameterized JUnit test that tests the performance of RangerPolicyEngine 
under increasing load of number of policies and concurrent calls.
a cross product of the input parameters are generated and fed into the test 
method.

This microbenchmark includes a warm-up phase so that any of the JIT performance 
optimizations happen before the measurement of the policy engine's performance.


File Attachments


0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch


Thanks,

Endre Zoltan Kovacs

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-10 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/#review187572
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 10, 2017, 11:51 a.m., Endre Zoltan Kovacs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62850/
> ---
> 
> (Updated Oct. 10, 2017, 11:51 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1827
> https://issues.apache.org/jira/browse/RANGER-1827
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> created a microbenchmark for the policy evaluation engine
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  25f533476 
>   ranger-tools/pom.xml ff37fb3eb 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
> e6095cba2 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  PRE-CREATION 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  PRE-CREATION 
>   ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
>   ranger-tools/src/test/resources/testdata/single-policy-template.json 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-request-template.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62850/diff/3/
> 
> 
> Testing
> ---
> 
> A parameterized JUnit test that tests the performance of RangerPolicyEngine 
> under increasing load of number of policies and concurrent calls.
> a cross product of the input parameters are generated and fed into the test 
> method.
> 
> This microbenchmark includes a warm-up phase so that any of the JIT 
> performance optimizations happen before the measurement of the policy 
> engine's performance.
> 
> 
> File Attachments
> 
> 
> 0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-10 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/#review187516
---


Ship it!




Ship It!

- Endre Zoltan Kovacs


On Oct. 10, 2017, 11:51 a.m., Endre Zoltan Kovacs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62850/
> ---
> 
> (Updated Oct. 10, 2017, 11:51 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1827
> https://issues.apache.org/jira/browse/RANGER-1827
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> created a microbenchmark for the policy evaluation engine
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  25f533476 
>   ranger-tools/pom.xml ff37fb3eb 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
> e6095cba2 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  PRE-CREATION 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  PRE-CREATION 
>   ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
>   ranger-tools/src/test/resources/testdata/single-policy-template.json 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-request-template.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62850/diff/3/
> 
> 
> Testing
> ---
> 
> A parameterized JUnit test that tests the performance of RangerPolicyEngine 
> under increasing load of number of policies and concurrent calls.
> a cross product of the input parameters are generated and fed into the test 
> method.
> 
> This microbenchmark includes a warm-up phase so that any of the JIT 
> performance optimizations happen before the measurement of the policy 
> engine's performance.
> 
> 
> File Attachments
> 
> 
> 0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-10 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/
---

(Updated Oct. 10, 2017, 11:51 a.m.)


Review request for ranger.


Changes
---

moved generated .csv under /target/ so maven build won't fail b/c of it's 
presence


Bugs: RANGER-1827
https://issues.apache.org/jira/browse/RANGER-1827


Repository: ranger


Description
---

created a microbenchmark for the policy evaluation engine


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java 
25f533476 
  ranger-tools/pom.xml ff37fb3eb 
  ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
e6095cba2 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
 PRE-CREATION 
  
ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
 PRE-CREATION 
  
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
 PRE-CREATION 
  ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
  ranger-tools/src/test/resources/testdata/single-policy-template.json 
PRE-CREATION 
  ranger-tools/src/test/resources/testdata/single-request-template.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/62850/diff/3/

Changes: https://reviews.apache.org/r/62850/diff/2-3/


Testing
---

A parameterized JUnit test that tests the performance of RangerPolicyEngine 
under increasing load of number of policies and concurrent calls.
a cross product of the input parameters are generated and fed into the test 
method.

This microbenchmark includes a warm-up phase so that any of the JIT performance 
optimizations happen before the measurement of the policy engine's performance.


File Attachments


0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch


Thanks,

Endre Zoltan Kovacs

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-10 Thread Endre Zoltan Kovacs via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/#review187514
---


Ship it!




Ship It!

- Endre Zoltan Kovacs


On Oct. 10, 2017, 11:24 a.m., Endre Zoltan Kovacs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62850/
> ---
> 
> (Updated Oct. 10, 2017, 11:24 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1827
> https://issues.apache.org/jira/browse/RANGER-1827
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> created a microbenchmark for the policy evaluation engine
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  25f533476 
>   ranger-tools/.gitignore 5ac84b1c9 
>   ranger-tools/pom.xml ff37fb3eb 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
> e6095cba2 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  PRE-CREATION 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  PRE-CREATION 
>   ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
>   ranger-tools/src/test/resources/testdata/single-policy-template.json 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-request-template.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62850/diff/2/
> 
> 
> Testing
> ---
> 
> A parameterized JUnit test that tests the performance of RangerPolicyEngine 
> under increasing load of number of policies and concurrent calls.
> a cross product of the input parameters are generated and fed into the test 
> method.
> 
> This microbenchmark includes a warm-up phase so that any of the JIT 
> performance optimizations happen before the measurement of the policy 
> engine's performance.
> 
> 
> File Attachments
> 
> 
> 0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/10/3fc881bb-c8ea-427b-a6b4-8d1236159c82__0001-RANGER-1827-microbenchmark-for-RangerPolicyEngine.patch
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>

Re: Review Request 62850: RANGER-1827: microbenchmark for policy evaluation

2017-10-09 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62850/#review187462
---


Fix it, then Ship it!





agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
Line 88 (original), 90 (patched)


May be good to include "(microsec)"



ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
Lines 62 (patched)


Please add JavaDoc to all new classes and important methods


- Alejandro Fernandez


On Oct. 9, 2017, 9:19 p.m., Endre Zoltan Kovacs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62850/
> ---
> 
> (Updated Oct. 9, 2017, 9:19 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1827
> https://issues.apache.org/jira/browse/RANGER-1827
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> created a microbenchmark for the policy evaluation engine
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
>  25f533476 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java 
> e6095cba2 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerAccessRequestDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerResourceDeserializer.java
>  PRE-CREATION 
>   
> ranger-tools/src/main/java/org/apache/ranger/policyengine/perftest/v2/RangerPolicyFactory.java
>  PRE-CREATION 
>   
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
>  PRE-CREATION 
>   ranger-tools/src/test/resources/log4j.properties 4ea9d854e 
>   ranger-tools/src/test/resources/testdata/single-policy-template.json 
> PRE-CREATION 
>   ranger-tools/src/test/resources/testdata/single-request-template.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62850/diff/1/
> 
> 
> Testing
> ---
> 
> A parameterized JUnit test that tests the performance of RangerPolicyEngine 
> under increasing load of number of policies and concurrent calls.
> a cross product of the input parameters are generated and fed into the test 
> method.
> 
> This microbenchmark includes a warm-up phase so that any of the JIT 
> performance optimizations happen before the measurement of the policy 
> engine's performance.
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>