Re: Review Request 62325: The logical of the policy details for Ranger Hive Plugin is error.

[pengjianhua]

> On 九月 14, 2017, 3:13 p.m., Velmurugan Periasamy wrote:
> > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
> > Lines 818 (patched)
> > 
> >
> > It would be better to seek a generic solution.

Ok. Very nice advice, I had fixed it. Thanks a lots.


- pengjianhua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62325/#review185411
---


On 九月 15, 2017, 11:35 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62325/
> ---
> 
> (Updated 九月 15, 2017, 11:35 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1778
> https://issues.apache.org/jira/browse/RANGER-1778
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The current logic is as following:
> 1?If policy choose “database”, the Permissions can choose "Read" and "Write"
> 2?If policy choose “url”, the Permissions can not choose "Read" and "Write"
> Above logic is error. The right logic should be as following:
> 1?If policy choose “database”, the Permissions can not choose "Read" and 
> "Write"
> 2?If policy choose “url”, the Permissions can only choose "Read" and "Write"
> 3?Control relation values between "database" and "url" when user switched 
> them.That is, we should control the linkage of the switch for "database" and 
> "url".
> Please refer to 
> https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 19798470 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
> bb649840 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 9a8d82db 
> 
> 
> Diff: https://reviews.apache.org/r/62325/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 62325: The logical of the policy details for Ranger Hive Plugin is error.

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62325/
---

(Updated 九月 15, 2017, 11:35 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1778
https://issues.apache.org/jira/browse/RANGER-1778


Repository: ranger


Description
---

The current logic is as following:
1?If policy choose “database”, the Permissions can choose "Read" and "Write"
2?If policy choose “url”, the Permissions can not choose "Read" and "Write"
Above logic is error. The right logic should be as following:
1?If policy choose “database”, the Permissions can not choose "Read" and "Write"
2?If policy choose “url”, the Permissions can only choose "Read" and "Write"
3?Control relation values between "database" and "url" when user switched 
them.That is, we should control the linkage of the switch for "database" and 
"url".
Please refer to 
https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/utils/XAUtils.js 19798470 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
bb649840 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
9a8d82db 


Diff: https://reviews.apache.org/r/62325/diff/3/

Changes: https://reviews.apache.org/r/62325/diff/2-3/


Testing
---


Thanks,

pengjianhua

Re: Review Request 62325: The logical of the policy details for Ranger Hive Plugin is error.

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62325/
---

(Updated 九月 15, 2017, 2:41 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1778
https://issues.apache.org/jira/browse/RANGER-1778


Repository: ranger


Description
---

The current logic is as following:
1?If policy choose “database”, the Permissions can choose "Read" and "Write"
2?If policy choose “url”, the Permissions can not choose "Read" and "Write"
Above logic is error. The right logic should be as following:
1?If policy choose “database”, the Permissions can not choose "Read" and "Write"
2?If policy choose “url”, the Permissions can only choose "Read" and "Write"
3?Control relation values between "database" and "url" when user switched 
them.That is, we should control the linkage of the switch for "database" and 
"url".
Please refer to 
https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
bb649840 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
9a8d82db 


Diff: https://reviews.apache.org/r/62325/diff/2/

Changes: https://reviews.apache.org/r/62325/diff/1-2/


Testing
---


Thanks,

pengjianhua

Re: Review Request 62325: The logical of the policy details for Ranger Hive Plugin is error.

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62325/#review185411
---




security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
Lines 818 (patched)


It would be better to seek a generic solution.


- Velmurugan Periasamy


On Sept. 14, 2017, 10:41 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62325/
> ---
> 
> (Updated Sept. 14, 2017, 10:41 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1778
> https://issues.apache.org/jira/browse/RANGER-1778
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The current logic is as following:
> 1?If policy choose “database”, the Permissions can choose "Read" and "Write"
> 2?If policy choose “url”, the Permissions can not choose "Read" and "Write"
> Above logic is error. The right logic should be as following:
> 1?If policy choose “database”, the Permissions can not choose "Read" and 
> "Write"
> 2?If policy choose “url”, the Permissions can only choose "Read" and "Write"
> 3?Control relation values between "database" and "url" when user switched 
> them.That is, we should control the linkage of the switch for "database" and 
> "url".
> Please refer to 
> https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
> bb649840 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 9a8d82db 
> 
> 
> Diff: https://reviews.apache.org/r/62325/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 62325: The logical of the policy details for Ranger Hive Plugin is error.

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62325/#review185397
---



Please fix it.

Applying: RANGER-1778 The logical of the policy details for Ranger Hive Plugin 
is error.
.git/rebase-apply/patch:24: space before tab in indent.
var perms = [];
.git/rebase-apply/patch:25: space before tab in indent.
var permsIds = [];
.git/rebase-apply/patch:26: space before tab in indent.
for(var i = 0;i 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62325/
> ---
> 
> (Updated Sept. 14, 2017, 10:41 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1778
> https://issues.apache.org/jira/browse/RANGER-1778
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The current logic is as following:
> 1?If policy choose “database”, the Permissions can choose "Read" and "Write"
> 2?If policy choose “url”, the Permissions can not choose "Read" and "Write"
> Above logic is error. The right logic should be as following:
> 1?If policy choose “database”, the Permissions can not choose "Read" and 
> "Write"
> 2?If policy choose “url”, the Permissions can only choose "Read" and "Write"
> 3?Control relation values between "database" and "url" when user switched 
> them.That is, we should control the linkage of the switch for "database" and 
> "url".
> Please refer to 
> https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
> bb649840 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> 9a8d82db 
> 
> 
> Diff: https://reviews.apache.org/r/62325/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Review Request 62325: The logical of the policy details for Ranger Hive Plugin is error.

[pengjianhua]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62325/
---

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1778
https://issues.apache.org/jira/browse/RANGER-1778


Repository: ranger


Description
---

The current logic is as following:
1?If policy choose “database”, the Permissions can choose "Read" and "Write"
2?If policy choose “url”, the Permissions can not choose "Read" and "Write"
Above logic is error. The right logic should be as following:
1?If policy choose “database”, the Permissions can not choose "Read" and "Write"
2?If policy choose “url”, the Permissions can only choose "Read" and "Write"
3?Control relation values between "database" and "url" when user switched 
them.That is, we should control the linkage of the switch for "database" and 
"url".
Please refer to 
https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html


Diffs
-

  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 
bb649840 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
9a8d82db 


Diff: https://reviews.apache.org/r/62325/diff/1/


Testing
---


Thanks,

pengjianhua