Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/#review201506
---


Ship it!




Ship It!

- Gautam Borad


On April 18, 2018, 2:53 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66584/
> ---
> 
> (Updated April 18, 2018, 2:53 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2021 and RANGER-2064
> https://issues.apache.org/jira/browse/RANGER-2021
> https://issues.apache.org/jira/browse/RANGER-2064
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Usersync should use cookie based authentication for subsequent 
> requests to Ranger admin.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
>  e9e356a 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  b30b051 
>   unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 
> 
> 
> Diff: https://reviews.apache.org/r/66584/diff/4/
> 
> 
> Testing
> ---
> 
> 1)Validated rangerusersync is not flooding table.
> 2)Validated if cookie is used by usersync client for subsequent requests to 
> ranger-admin.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/#review201429
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 18, 2018, 2:53 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66584/
> ---
> 
> (Updated April 18, 2018, 2:53 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2021 and RANGER-2064
> https://issues.apache.org/jira/browse/RANGER-2021
> https://issues.apache.org/jira/browse/RANGER-2064
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Usersync should use cookie based authentication for subsequent 
> requests to Ranger admin.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
>  e9e356a 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  b30b051 
>   unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 
> 
> 
> Diff: https://reviews.apache.org/r/66584/diff/4/
> 
> 
> Testing
> ---
> 
> 1)Validated rangerusersync is not flooding table.
> 2)Validated if cookie is used by usersync client for subsequent requests to 
> ranger-admin.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Nikhil P]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/
---

(Updated April 18, 2018, 8:23 p.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2021 and RANGER-2064
https://issues.apache.org/jira/browse/RANGER-2021
https://issues.apache.org/jira/browse/RANGER-2064


Repository: ranger


Description
---

Ranger Usersync should use cookie based authentication for subsequent requests 
to Ranger admin.


Diffs (updated)
-

  
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
 e9e356a 
  
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
 b30b051 
  unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 


Diff: https://reviews.apache.org/r/66584/diff/4/

Changes: https://reviews.apache.org/r/66584/diff/3-4/


Testing
---

1)Validated rangerusersync is not flooding table.
2)Validated if cookie is used by usersync client for subsequent requests to 
ranger-admin.


Thanks,

Nikhil P

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/#review201318
---




ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
Lines 237 (patched)


Does this need to be public?



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 751 (patched)


Would a debug message here be useful? Similar to line 757?



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 796 (patched)


Debug message (similar to line 802 - in non-cookie case) would be helpful.



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 1216 (patched)


This can be moved out of if check to make it common for both cookie and 
non-cookie cases.


- Velmurugan Periasamy


On April 17, 2018, 3:03 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66584/
> ---
> 
> (Updated April 17, 2018, 3:03 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2021 and RANGER-2064
> https://issues.apache.org/jira/browse/RANGER-2021
> https://issues.apache.org/jira/browse/RANGER-2064
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Usersync should use cookie based authentication for subsequent 
> requests to Ranger admin.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
>  e9e356a 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  b30b051 
>   unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 
> 
> 
> Diff: https://reviews.apache.org/r/66584/diff/3/
> 
> 
> Testing
> ---
> 
> 1)Validated rangerusersync is not flooding table.
> 2)Validated if cookie is used by usersync client for subsequent requests to 
> ranger-admin.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Nikhil P]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/
---

(Updated April 17, 2018, 8:33 p.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2021 and RANGER-2064
https://issues.apache.org/jira/browse/RANGER-2021
https://issues.apache.org/jira/browse/RANGER-2064


Repository: ranger


Description
---

Ranger Usersync should use cookie based authentication for subsequent requests 
to Ranger admin.


Diffs (updated)
-

  
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
 e9e356a 
  
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
 b30b051 
  unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 


Diff: https://reviews.apache.org/r/66584/diff/3/

Changes: https://reviews.apache.org/r/66584/diff/2-3/


Testing
---

1)Validated rangerusersync is not flooding table.
2)Validated if cookie is used by usersync client for subsequent requests to 
ranger-admin.


Thanks,

Nikhil P

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Qiang Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/#review201291
---




ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 880 (patched)


Please use the static final String variable to instead of 
ANGERADMINSESSIONID.



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 1076 (patched)


Please use the static final String variable to instead of 
ANGERADMINSESSIONID.



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 1103 (patched)


Please use the static final String variable to instead of 
ANGERADMINSESSIONID.


- Qiang Zhang


On April 16, 2018, 1:08 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66584/
> ---
> 
> (Updated April 16, 2018, 1:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2021 and RANGER-2064
> https://issues.apache.org/jira/browse/RANGER-2021
> https://issues.apache.org/jira/browse/RANGER-2064
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Usersync should use cookie based authentication for subsequent 
> requests to Ranger admin.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
>  e9e356a 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  b30b051 
>   unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 
> 
> 
> Diff: https://reviews.apache.org/r/66584/diff/2/
> 
> 
> Testing
> ---
> 
> 1)Validated rangerusersync is not flooding table.
> 2)Validated if cookie is used by usersync client for subsequent requests to 
> ranger-admin.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/#review201242
---


Ship it!




Ship It!

- Nixon Rodrigues


On April 16, 2018, 1:08 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66584/
> ---
> 
> (Updated April 16, 2018, 1:08 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2021 and RANGER-2064
> https://issues.apache.org/jira/browse/RANGER-2021
> https://issues.apache.org/jira/browse/RANGER-2064
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Usersync should use cookie based authentication for subsequent 
> requests to Ranger admin.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
>  e9e356a 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  b30b051 
>   unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 
> 
> 
> Diff: https://reviews.apache.org/r/66584/diff/2/
> 
> 
> Testing
> ---
> 
> 1)Validated rangerusersync is not flooding table.
> 2)Validated if cookie is used by usersync client for subsequent requests to 
> ranger-admin.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Nikhil P]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/
---

(Updated April 16, 2018, 6:38 p.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2021 and RANGER-2064
https://issues.apache.org/jira/browse/RANGER-2021
https://issues.apache.org/jira/browse/RANGER-2064


Repository: ranger


Description
---

Ranger Usersync should use cookie based authentication for subsequent requests 
to Ranger admin.


Diffs (updated)
-

  
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
 e9e356a 
  
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
 b30b051 
  unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 


Diff: https://reviews.apache.org/r/66584/diff/2/

Changes: https://reviews.apache.org/r/66584/diff/1-2/


Testing
---

1)Validated rangerusersync is not flooding table.
2)Validated if cookie is used by usersync client for subsequent requests to 
ranger-admin.


Thanks,

Nikhil P

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/#review201002
---




ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 97 (patched)


variable name "sessionId" can be renamed to  sessionIdCookie



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 814 (patched)


The logic in method tryUploadUserGroupAuditInfoWithCookie, 
tryUploadMUserWithCookie & tryUploadUserGroupInfoWithCookie is similiar and can 
be brought in one common method with json string and url as argument which can 
be reused in other method.

eg tryUploadEntityInfoWithCookie(JSON, URL);


- Nixon Rodrigues


On April 12, 2018, 12:50 p.m., Nikhil P wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66584/
> ---
> 
> (Updated April 12, 2018, 12:50 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2021 and RANGER-2064
> https://issues.apache.org/jira/browse/RANGER-2021
> https://issues.apache.org/jira/browse/RANGER-2064
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger Usersync should use cookie based authentication for subsequent 
> requests to Ranger admin.
> 
> 
> Diffs
> -
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
>  e9e356a 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  b30b051 
>   unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 
> 
> 
> Diff: https://reviews.apache.org/r/66584/diff/1/
> 
> 
> Testing
> ---
> 
> 1)Validated rangerusersync is not flooding table.
> 2)Validated if cookie is used by usersync client for subsequent requests to 
> ranger-admin.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>

Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

[Nikhil P]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66584/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2021 and RANGER-2064
https://issues.apache.org/jira/browse/RANGER-2021
https://issues.apache.org/jira/browse/RANGER-2064


Repository: ranger


Description
---

Ranger Usersync should use cookie based authentication for subsequent requests 
to Ranger admin.


Diffs
-

  
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
 e9e356a 
  
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
 b30b051 
  unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 


Diff: https://reviews.apache.org/r/66584/diff/1/


Testing
---

1)Validated rangerusersync is not flooding table.
2)Validated if cookie is used by usersync client for subsequent requests to 
ranger-admin.


Thanks,

Nikhil P