Re: Review Request 71542: RANGER-2510: Support for Incremental tag updates to improve performance

2019-09-30 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71542/#review217998
---


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 30, 2019, 10 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71542/
> ---
> 
> (Updated Sept. 30, 2019, 10 p.m.)
> 
> 
> Review request for ranger, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-2510
> https://issues.apache.org/jira/browse/RANGER-2510
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, every change to any tag/service-resource/service-resource->tag 
> mapping causes complete rebuilding of portions of policy-engine that map 
> accessed resource to their tags. There are several disadvantages:
> 1. Compute time for rebuilding
> 2. Large traffic from ranger-admin to each of the plugins
> 3. Large load on JVM memory system because of frequent complete rebuilding of 
> portions of policy-engine.
> 
> It will be more optimal to communicate only the changes to tags and apply 
> them to existing policy-engine.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  306388534 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 
> 7055391d1 
>   
> security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java
>  9f6f024bb 
>   security-admin/src/main/java/org/apache/ranger/db/XXTagChangeLogDao.java 
> ef65e9a6b 
>   
> security-admin/src/main/java/org/apache/ranger/entity/XXPolicyChangeLog.java 
> df87f70a5 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTagChangeLog.java 
> c3eb14414 
>   security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
> c33841dfd 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java
>  d4350b68e 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 9714fa91b 
>   
> security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java
>  160a53c50 
> 
> 
> Diff: https://reviews.apache.org/r/71542/diff/2/
> 
> 
> Testing
> ---
> 
> Developed unit tests to verify that incremental policy and tag work as 
> expected.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>



[jira] [Updated] (RANGER-2597) Allow auditor role user to access the get API's in public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Attachment: RANGER-2597.patch

> Allow auditor role user to access the get API's in public API
> -
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
> Attachments: RANGER-2597.patch
>
>
> Allow auditor role user to access the get API's in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to access the services and polices details in public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Summary: Allow auditor role user to access the services and polices details 
in public API  (was: Allow auditor role user to access the get API's in public 
API)

> Allow auditor role user to access the services and polices details in public 
> API
> 
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
> Attachments: RANGER-2597.patch
>
>
> Allow auditor role user to access the get API's in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (RANGER-2597) Allow auditor role user to access the get API's in public API

2019-09-30 Thread Fatima Amjad Khan (Jira)
Fatima Amjad Khan created RANGER-2597:
-

 Summary: Allow auditor role user to access the get API's in public 
API
 Key: RANGER-2597
 URL: https://issues.apache.org/jira/browse/RANGER-2597
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Fatima Amjad Khan
Assignee: Fatima Amjad Khan


Allow auditor role user to access the get API's in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to access the services and policy details in public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Summary: Allow auditor role user to access the services and policy details 
in public API  (was: Allow auditor role user to access the services and polices 
details in public API)

> Allow auditor role user to access the services and policy details in public 
> API
> ---
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
> Attachments: RANGER-2597.patch
>
>
> Allow auditor role user to access the get API's in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to get details of Services and Policies in public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Description: Allow auditor role user to get details of Services and 
Policies in public API  (was: Allow auditor role user to access the get API's 
in public API)

> Allow auditor role user to get details of  Services and Policies in public API
> --
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
>
> Allow auditor role user to get details of Services and Policies in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to get details of Services and Policies in public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Summary: Allow auditor role user to get details of  Services and Policies 
in public API  (was: Allow auditor role user to access the services and policy 
details in public API)

> Allow auditor role user to get details of  Services and Policies in public API
> --
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
>
> Allow auditor role user to access the get API's in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to get details of Services and Policies from public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Summary: Allow auditor role user to get details of  Services and Policies 
from public API  (was: Allow auditor role user to get details of  Services and 
Policies in public API)

> Allow auditor role user to get details of  Services and Policies from public 
> API
> 
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
>
> Allow auditor role user to get details of Services and Policies in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to get details of Services and Policies from public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Description: Allow auditor role user to get details of services and 
policies from public API  (was: Allow auditor role user to get details of 
Services and Policies in public API)

> Allow auditor role user to get details of  Services and Policies from public 
> API
> 
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
>
> Allow auditor role user to get details of services and policies from public 
> API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to get details of Services and Policies in public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Attachment: (was: RANGER-2597.patch)

> Allow auditor role user to get details of  Services and Policies in public API
> --
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
>
> Allow auditor role user to access the get API's in public API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2597) Allow auditor role user to get details of services and policies from public API

2019-09-30 Thread Fatima Amjad Khan (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fatima Amjad Khan updated RANGER-2597:
--
Summary: Allow auditor role user to get details of  services and policies 
from public API  (was: Allow auditor role user to get details of  Services and 
Policies from public API)

> Allow auditor role user to get details of  services and policies from public 
> API
> 
>
> Key: RANGER-2597
> URL: https://issues.apache.org/jira/browse/RANGER-2597
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Fatima Amjad Khan
>Assignee: Fatima Amjad Khan
>Priority: Major
>
> Allow auditor role user to get details of services and policies from public 
> API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 71542: RANGER-2510: Support for Incremental tag updates to improve performance

2019-09-30 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71542/
---

(Updated Sept. 30, 2019, 10 p.m.)


Review request for ranger, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Changes
---

Addressed review comments


Bugs: RANGER-2510
https://issues.apache.org/jira/browse/RANGER-2510


Repository: ranger


Description
---

Currently, every change to any tag/service-resource/service-resource->tag 
mapping causes complete rebuilding of portions of policy-engine that map 
accessed resource to their tags. There are several disadvantages:
1. Compute time for rebuilding
2. Large traffic from ranger-admin to each of the plugins
3. Large load on JVM memory system because of frequent complete rebuilding of 
portions of policy-engine.

It will be more optimal to communicate only the changes to tags and apply them 
to existing policy-engine.


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
 306388534 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 
7055391d1 
  
security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java 
9f6f024bb 
  security-admin/src/main/java/org/apache/ranger/db/XXTagChangeLogDao.java 
ef65e9a6b 
  security-admin/src/main/java/org/apache/ranger/entity/XXPolicyChangeLog.java 
df87f70a5 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagChangeLog.java 
c3eb14414 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
c33841dfd 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java 
d4350b68e 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 9714fa91b 
  
security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java
 160a53c50 


Diff: https://reviews.apache.org/r/71542/diff/2/

Changes: https://reviews.apache.org/r/71542/diff/1-2/


Testing
---

Developed unit tests to verify that incremental policy and tag work as expected.


Thanks,

Abhay Kulkarni



[jira] [Commented] (RANGER-2534) Official logo for Apache Ranger

2019-09-30 Thread Velmurugan Periasamy (Jira)


[ 
https://issues.apache.org/jira/browse/RANGER-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941212#comment-16941212
 ] 

Velmurugan Periasamy commented on RANGER-2534:
--

I have updated the docs with the new logo - 
https://gitbox.apache.org/repos/asf?p=ranger.git;a=commit;h=e5b7838f490d6d526974bf2c6cd24917d2209693

> Official logo for Apache Ranger
> ---
>
> Key: RANGER-2534
> URL: https://issues.apache.org/jira/browse/RANGER-2534
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Nitin Galave
>Assignee: Nitin Galave
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: 0001-RANGER-2534.patch, 0002-RANGER-2534.patch, 
> Apache_Ranger.png, favicon_icon.ico, landing_Page.png, loginPage_1.png, 
> ranger_logo.png, ranger_policy_table.png, user_group_listing_table.png
>
>
> Coming up with few suggestions to finalise Logo for Ranger. And also changed 
> ranger admin UI colour. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2510) Support for Incremental tag updates to improve performance

2019-09-30 Thread Velmurugan Periasamy (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-2510:
-
Fix Version/s: (was: master)

> Support for Incremental tag updates to improve performance
> --
>
> Key: RANGER-2510
> URL: https://issues.apache.org/jira/browse/RANGER-2510
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: 2.1.0
>
>
> Currently, every change to any tag/service-resource/service-resource->tag 
> mapping causes complete rebuilding of portions of policy-engine that map 
> accessed resource to their tags. There are several disadvantages:
> 1. Compute time for rebuilding
> 2. Large traffic from ranger-admin to each of the plugins
> 3. Large load on JVM memory system because of frequent complete rebuilding of 
> portions of policy-engine.
> It will be more optimal to communicate only the changes to tags and apply 
> them to existing policy-engine.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RANGER-2510) Support for Incremental tag updates to improve performance

2019-09-30 Thread Velmurugan Periasamy (Jira)


 [ 
https://issues.apache.org/jira/browse/RANGER-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Velmurugan Periasamy updated RANGER-2510:
-
Fix Version/s: 2.1.0

> Support for Incremental tag updates to improve performance
> --
>
> Key: RANGER-2510
> URL: https://issues.apache.org/jira/browse/RANGER-2510
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Abhay Kulkarni
>Assignee: Abhay Kulkarni
>Priority: Major
> Fix For: master, 2.1.0
>
>
> Currently, every change to any tag/service-resource/service-resource->tag 
> mapping causes complete rebuilding of portions of policy-engine that map 
> accessed resource to their tags. There are several disadvantages:
> 1. Compute time for rebuilding
> 2. Large traffic from ranger-admin to each of the plugins
> 3. Large load on JVM memory system because of frequent complete rebuilding of 
> portions of policy-engine.
> It will be more optimal to communicate only the changes to tags and apply 
> them to existing policy-engine.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)