Re: [VOTE] Apache Ratis Thirdparty incubating Release 0.3.0 rc0

2019-11-03 Thread Ankit Singhal
+1
-- Rat check -Ok
-- Verified signature and checksums
-- Build from source - Ok



On Fri, Nov 1, 2019 at 9:49 PM Jitendra Pandey  wrote:

> +1 (binding)
> Looks good to me. Validated signatures.
>
> On Fri, Nov 1, 2019 at 2:38 PM Josh Elser  wrote:
>
> > +1 (binding)
> >
> > The RC looks good to me. Great work, Mukul!
> >
> > On 10/30/19 11:00 PM, Mukul Kumar Singh wrote:
> > > Hi Apache Ratis PPMC,
> > >
> > > I am calling a vote for Apache Ratis Thirdparty incubating Release
> 0.3.0
> > > rc0
> > > This is after the discuss thread for Ratis Thirdparty release. The
> > > discuss thread can be
> > > foundhttps://
> >
> lists.apache.org/thread.html/3b830e7a4a4fce09cb924e4e18225f3970b277efcc860dcd8e81ba4b@%3Cdev.ratis.apache.org%3E
> > >
> > >
> > >
> > > The git tag to be voted upon:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis-thirdparty.git;a=tag;h=refs/tags/ratis-thirdparty-0.3.0
> > >
> > >
> > > The git commit hash:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis-thirdparty.git;a=commit;h=b49a8f78ecd23dc45e3eab0b858085d0bb91cec0
> > >
> > >
> > > The source and binary tarballs can be found at:
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/ratis/thirdparty/0.3.0/rc0/
> > >
> > >
> > > The fingerprint of key to sign release artifacts:
> > > A3DE 0E76 321F 176A 4E84  67A8 E01D 75D7 B364 4C48
> > >
> > > Release artifacts are signed with one of the keys available at:
> > > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS
> > >
> > > This vote will remain open for at least 72 hours.
> > > Please vote on releasing this RC.  Thank you in advance.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > Starting with my +1(binding).
> > >
> > > Regards,
> > > Mukul Kumar Singh
> > >
> > >
> >
>


Re: [VOTE] Apache Ratis incubating Release 0.4.0 rc3

2019-08-19 Thread Ankit Singhal
+1(non-binding)

-- Built from the source - SUCCESS
-- Hashes and Signatures - OK
-- Ran unit tests - Passed
-- Ran rat check on the source - SUCCESS
-- Licenses and Notices - Ok

Regards,
Ankit Singhal

On Mon, Aug 19, 2019 at 9:38 AM Jitendra Pandey
 wrote:

> +1 (binding)
>
> Validates signature,
> Downloaded and built the source.
> Ran filestore loadgen example.
>
>
>
>
>
> On Mon, Aug 19, 2019 at 4:13 AM Mukul Kumar Singh <
> mksingh.apa...@gmail.com>
> wrote:
>
> > Hi Apache Ratis PPMC,
> >
> > I am calling a vote for Apache Ratis incubating Release 0.4.0 rc3.
> > This vote is after fixing issuesRATIS-658  in the rc2 vote.
> >
> > This is with respect to the discuss mailthread  <
> >
> https://lists.apache.org/thread.html/781fb6db8fe3327683f96b880496cf4b297f8666a2fab85c413c6f4b@%3Cdev.ratis.apache.org%3E
> > >.
> >
> > The git tag to be voted upon:
> >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=tag;h=refs/tags/0.4.0-rc3
> > <
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=shortlog;h=refs/tags/0.4.0-rc2
> > >
> >
> > The git commit hash:
> >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h=f401c7a3d21ba2ce6fc735891ae9e22ea5628c8d
> > <
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h=2739b4e42399b6a47f79c7b4bc7b23ca77702896
> > >
> >
> > The source and binary tarballs can be found at:
> > http://people.apache.org/~msingh/0.4.0-rc3/  <
> > http://people.apache.org/~msingh/0.4.0-rc2/>
> >
> > The fingerprint of key to sign release artifacts:
> > 45B0 13F6 29C6 89CC 6EE3 77B0 8D43 C3D9 A8F1 02BD
> >
> > Release artifacts are signed with one of the keys available at:
> > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS  <
> > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS>
> >
> > This vote will remain open for at least 72 hours.
> > Please vote on releasing this RC.  Thank you in advance.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Starting with my +1.
> > Built Ozone from source and was able to run the examples.
> >
> > Regards,
> > Mukul Kumar Singh
> >
> >
>


Re: [VOTE] Apache Ratis incubating Release 0.4.0 rc1

2019-08-01 Thread Ankit Singhal
+1

-- Built from the source - OK
-- Hashes and Signatures[5]  - OK
-- Ran unit tests - All passed
-- Ran rat check on the source - OK

Some comments:-
* NOTICE[1] assembled in a binary tar doesn't include a NOTICE[2] from the
project.
* NOTICE[1] doesn't look exhaustive (eg:- No mention of Junit dependency
"Eclipse Public License 1.0") under Could also use a supplemental
model[4] for dependencies which have incomplete information about their
NOTICE/LICENSE
* same with LICENSE[3], for eg:- no mention of "Eclipse Public License - v
1.0"[4]

[1]
http://people.apache.org/~msingh/0.4.0-rc1/apache-ratis-incubating-0.4.0-rc1-bin.tar.gz
[2] https://github.com/apache/incubator-ratis/blob/master/NOTICE
[3]
http://people.apache.org/~msingh/0.4.0-rc1/apache-ratis-incubating-0.4.0-rc1-bin.tar.gz
[4]
https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html
[5] https://dist.apache.org/repos/dist/release/incubator/ratis/KEYS

Regards,
Ankit Singhal

On Thu, Aug 1, 2019 at 11:02 AM Uma gangumalla  wrote:

> +1 (binding)
>
> built from source
> LICENCE and NOTICE files looks good.
> Sig and hashes are fine
>
> Few test timeouts[1] came in my 'mvn clean install'. Probably that's only
> to me as others might already ran tests and +1ed. ( Should not be a blocker
> I guess, if they are passing with others env)
>
> Regards,
> Uma
>
> [1]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR]
>
> TestRaftSnapshotWithGrpc>RaftSnapshotBaseTest.testBasicInstallSnapshot:220->RaftSnapshotBaseTest.assertLeaderContent:78
> [ERROR]
>
> TestRaftReconfigurationWithNetty>RaftReconfigurationBaseTest.testReconfTwice:140->RaftReconfigurationBaseTest.runTestReconfTwice:192->RaftReconfigurationBaseTest.lambda$runTestReconfTwice$5:200
> s3: ConfigurationManager, init=-1: [s0:0.0.0.0:50941, s1:0.0.0.0:45664,
> s2:
> 0.0.0.0:49625], old=null, confs={
>   0 -> 0: [s0:0.0.0.0:50941, s1:0.0.0.0:45664, s2:0.0.0.0:49625], old=null
>   41 -> 41: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s0:0.0.0.0:50941, s1:
> 0.0.0.0:45664, s2:0.0.0.0:49625], old=[s0:0.0.0.0:50941, s1:0.0.0.0:45664,
> s2:0.0.0.0:49625]
>   43 -> 43: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s0:0.0.0.0:50941, s1:
> 0.0.0.0:45664, s2:0.0.0.0:49625], old=null
>   45 -> 45: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625],
> old=[s3:
> 0.0.0.0:45637, s4:0.0.0.0:50873, s0:0.0.0.0:50941, s1:0.0.0.0:45664, s2:
> 0.0.0.0:49625]
>   47 -> 47: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625],
> old=null
>   49 -> 49: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625],
> old=null
>   50 -> 50: [s3:0.0.0.0:45637, s4:0.0.0.0:50873, s2:0.0.0.0:49625],
> old=null
> } expected:<7> but was:<8>
> [ERROR]
>
> TestRaftSnapshotWithNetty>RaftSnapshotBaseTest.testRestartPeer:146->RaftSnapshotBaseTest.assertLeaderContent:78
> [ERROR]
>
> TestRaftLogMetrics.testFlushMetric:78->runTestFlushMetric:93->assertFlushCount:110
> expected:<5> but was:<4>
> [ERROR]
>
> TestRaftSnapshotWithSimulatedRpc>RaftSnapshotBaseTest.testBasicInstallSnapshot:220->RaftSnapshotBaseTest.assertLeaderContent:78
> [ERROR] Errors:
> [ERROR]
>
> TestRaftReconfigurationWithGrpc>RaftReconfigurationBaseTest.testReconfTimeout:207->RaftReconfigurationBaseTest.runTestReconfTimeout:217
> » NullPointer
> [ERROR]
>
> TestRequestLimitAsyncWithGrpc>RequestLimitAsyncBaseTest.testWriteElementLimit:65->RequestLimitAsyncBaseTest.runTestWriteElementLimit:119->BaseTest.getWithDefaultTimeout:168
> » Timeout
> [ERROR]
>
> TestRaftStateMachineExceptionWithNetty>RaftStateMachineExceptionTests.testRetryOnExceptionDuringReplication:177
> » NullPointer
> [ERROR]
>
> TestRaftStateMachineExceptionWithSimulatedRpc>RaftStateMachineExceptionTests.testRetryOnExceptionDuringReplication:177
> » NullPointer
> [INFO]
> [ERROR] Tests run: 241, Failures: 5, Errors: 4, Skipped: 4
>
> On Mon, Jul 29, 2019 at 2:59 AM Mukul Kumar Singh <
> mksingh.apa...@gmail.com>
> wrote:
>
> > Hi Apache Ratis PPMC,
> >
> > I am calling a vote for Apache Ratis incubating Release 0.4.0 rc1.
> > This vote is after fixing issues RATIS-642 & RATIS-621 in the rc0 vote.
> >
> > This is with respect to the discuss mailthread  <
> >
> https://lists.apache.org/thread.html/781fb6db8fe3327683f96b880496cf4b297f8666a2fab85c413c6f4b@%3Cdev.ratis.apache.org%3E
> > >.
> >
> > The git tag to be voted upon:
> >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=shortlog;h=refs/tags/0.4.0-rc1
> >
> > The git commit hash:
> >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=

Re: [DISCUSS] Apache Ratis 0.4.0 release

2019-07-01 Thread Ankit Singhal
can we wait for these two pull request to be merged(they are almost near to
review completion):-
https://github.com/apache/incubator-ratis/pull/25
https://github.com/apache/incubator-ratis/pull/26



On Mon, Jul 1, 2019 at 10:27 AM anu engineer  wrote:

> +1, Thanks for the quick response.
>
> --Anu
>
>
> On Mon, Jul 1, 2019 at 10:17 AM Arpit Agarwal
> 
> wrote:
>
> > +1 for starting the 0.4.0 release. We’ve had numerous useful bug-fixes
> and
> > improvements since the last release.
> >
> > Has anyone volunteered to be the RM?
> >
> >
> > > On Jul 1, 2019, at 10:15 AM, Mukul Kumar Singh <
> mksingh.apa...@gmail.com>
> > wrote:
> > >
> > > Hi,
> > >
> > > It has been a while since our last Ratis release.
> > > We have around 50 commits after our latest 0.3.0 release.
> > >
> > > How about we start the process for a new Ratis release (0.4.0).
> > > We can create a new 0.4.0 branch and change trunk to 0.5.0.
> > >
> > > Thanks,
> > > Mukul
> >
> >
>