[GitHub] incubator-rocketmq pull request #85: [ROCKETMQ-158]Remove logback dependency...

[Jaskey]

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111524822
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common.utils;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.URL;
+import org.slf4j.ILoggerFactory;
+import org.slf4j.LoggerFactory;
+
+public class LogUtils {
+
+/**
+ * config logback dymatically from provided file path, otherwise try 
to config from resource file
+ * @param logConfigFilePath specified logback configuration file path
+ * @param logbackResourceFile specified logback configuration resource 
file, which will only be respected when logConfigFilePath is null
+ * @param iLoggerFactory
+ * @throws ClassNotFoundException
+ * @throws InstantiationException
+ * @throws IllegalAccessException
+ * @throws NoSuchMethodException
+ * @throws InvocationTargetException
+ */
+public static void configLogback(String logConfigFilePath, String 
logbackResourceFile, ILoggerFactory iLoggerFactory) throws 
ClassNotFoundException, InstantiationException, IllegalAccessException, 
NoSuchMethodException, InvocationTargetException {
+Class joranConfigurator;
+Class context = Class.forName("ch.qos.logback.core.Context");
+Object joranConfiguratoroObj;
+joranConfigurator = 
Class.forName("ch.qos.logback.classic.joran.JoranConfigurator");
+joranConfiguratoroObj = joranConfigurator.newInstance();
+Method setContext = 
joranConfiguratoroObj.getClass().getMethod("setContext", context);
+setContext.invoke(joranConfiguratoroObj, iLoggerFactory);
+if (null == logConfigFilePath) {
+if (logbackResourceFile != null) {
+URL url = 
LogUtils.class.getClassLoader().getResource(logbackResourceFile);
+Method doConfigure = 
joranConfiguratoroObj.getClass().getMethod("doConfigure", URL.class);
+doConfigure.invoke(joranConfiguratoroObj, url);
+}
+} else {
+Method doConfigure = 
joranConfiguratoroObj.getClass().getMethod("doConfigure", String.class);
+doConfigure.invoke(joranConfiguratoroObj, logConfigFilePath);
+}
+}
+
+/**
+ * config log4j dymatically from provided file path, otherwise try to 
config from resource file. Notice that the log4j configuration file should be 
in xml format
--- End diff --

Fixed, thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[lizhanhui]

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524663
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

This is why I make these changes thorough PR process instead of regarding 
them trivial and merging directly.

We can discuss to figure out an acceptable way.

You may also notice that I do not change configuration name spelling issues 
yet and I am expecting opinions too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Import Maintain...

[Harsha]

Hi,
  If the goal is to move the project more quickly, adding
  maintainers will only hinder the progress not help move faster as
  it's another layer of getting a patch committed. Since RocketMQ is
  still in the incubation stage, IMO too soon to introduce
  maintainers. Once the project matures into a bigger community,
  maintainers might help.
  Since the goal is to move the project quicker I think the goal
  should provide guidance in promoting the current contributors to
  committers so that they can help handle the PR volume.

Thanks,
Harsha

On Thu, Apr 13, 2017, at 07:24 PM, yukon wrote:
> Hi Bruce,
> 
> > Is the RocketMQ code base currently divided up with certain people
> working only in certain areas?
> 
> Not only, but most of committers have their focus areas.
> 
> We don't want to divide the code base totally for certain people, IMO,
> global collaboration with a certain focus may be a better efficient way.
> 
> Regards,
> 
> yukon
> 
> 
> 
> 
> 
> On Thu, Apr 13, 2017 at 10:09 PM, Bruce Snyder 
> wrote:
> 
> > Hi yukon,
> >
> > I haven't heard of this concept at the ASF before, so I guess it's
> > something that only a few projects are using. It seems kinda heavy-handed,
> > but maybe this is just my perspective in not having worked on the RocketMQ
> > code base. Is the RocketMQ code base currently divided up with certain
> > people working only in certain areas?
> >
> > Bruce
> >
> > On Thu, Apr 13, 2017 at 2:12 AM, yukon  wrote:
> >
> > > Hi all,
> > >
> > > We have noticed that there are some problems in our PR review process, as
> > > Justin mentioned in the IPMC board report, the slow PR processing speed
> > > will drain contributors' positive energy for continuous contribution,
> > which
> > > will impede healthy development of Apache RocketMQ community.
> > >
> > > So we want to import the maintainer mechanism for Apache RocketMQ to
> > > promote the development of community efficiently, but I am not sure
> > whether
> > > it's ok for a incubator project, please mentors let me know If there are
> > > any problems.
> > >
> > > Since there are many Apache projects have maintainers[1][2], with some
> > > major responsibilities for the code base, and we want to try out this
> > > mechanism for a certain time. Each major component has 2~3 maintainers,
> > who
> > > are responsible for the following:
> > >
> > > 1. Providing timely feedback on JIRA issues, bug reports, wishes, and so
> > > on.
> > > 2. Review code contributions(PRs) as promptly as possible, also
> > coordinate
> > > other committers to help review.
> > > 3. Merge PRs after review stage.
> > >
> > > Any advice is welcome.
> > >
> > > [1]. http://mesos.apache.org/documentation/latest/committers/
> > > [2]. https://cwiki.apache.org/confluence/display/KAFKA/Maintainers
> > >
> > > Regards,
> > > yukon
> > >
> >
> >
> >
> > --
> > perl -e 'print
> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E >
> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > Blog: http://bsnyder.org/ 
> > Twitter: http://twitter.com/brucesnyder
> >

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[Jaskey]

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111524324
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

So in the next version, we must announce that they may face the compatible 
problem when they use  in the older version.

Before they update, they must know about this and know how to fix them , 
and then upgrade.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[lizhanhui]

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111522507
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

1) This project is still at incubation stage, if we do not correct things 
now, we may never ever get the chance to fix them afterwards.
2) Transaction related feature is not currently implemented, IMO, we may 
fix this interface before it's widely used.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[Jaskey]

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211864
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java
 ---
@@ -18,6 +18,6 @@
 
 import org.apache.rocketmq.common.message.Message;
 
-public interface LocalTransactionExecuter {
-public LocalTransactionState executeLocalTransactionBranch(final 
Message msg, final Object arg);
+public interface LocalTransactionExecutor {
--- End diff --

We can't just rename a public interface, since the user who updates will 
find it not able to compile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[Jaskey]

Github user Jaskey commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111211195
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/consumer/listener/ConsumeReturnType.java
 ---
@@ -33,7 +33,7 @@
 /**
  * consume return null
  */
-RETURNNULL,
+RETURN_NULL,
--- End diff --

This is in an enum in client, we should be cautions for this since the user 
may has been using it.

Maybe we can comment in the java doc and explain that we will rename it in 
latter version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11083278/badge)](https://coveralls.io/builds/11083278)

Coverage increased (+0.0007%) to 34.626% when pulling 
**7e07b87f7124d21c69c5d61169a2c466714239eb on lizhanhui:ROCKETMQ-174** into 
**7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  

[![Coverage 
Status](https://coveralls.io/builds/11083278/badge)](https://coveralls.io/builds/11083278)

Coverage increased (+0.0007%) to 34.626% when pulling 
**7e07b87f7124d21c69c5d61169a2c466714239eb on lizhanhui:ROCKETMQ-174** into 
**7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/82
  
Will look into this PR today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Import Maintain...

[yukon]

Hi Bruce,

> Is the RocketMQ code base currently divided up with certain people
working only in certain areas?

Not only, but most of committers have their focus areas.

We don't want to divide the code base totally for certain people, IMO,
global collaboration with a certain focus may be a better efficient way.

Regards,

yukon





On Thu, Apr 13, 2017 at 10:09 PM, Bruce Snyder 
wrote:

> Hi yukon,
>
> I haven't heard of this concept at the ASF before, so I guess it's
> something that only a few projects are using. It seems kinda heavy-handed,
> but maybe this is just my perspective in not having worked on the RocketMQ
> code base. Is the RocketMQ code base currently divided up with certain
> people working only in certain areas?
>
> Bruce
>
> On Thu, Apr 13, 2017 at 2:12 AM, yukon  wrote:
>
> > Hi all,
> >
> > We have noticed that there are some problems in our PR review process, as
> > Justin mentioned in the IPMC board report, the slow PR processing speed
> > will drain contributors' positive energy for continuous contribution,
> which
> > will impede healthy development of Apache RocketMQ community.
> >
> > So we want to import the maintainer mechanism for Apache RocketMQ to
> > promote the development of community efficiently, but I am not sure
> whether
> > it's ok for a incubator project, please mentors let me know If there are
> > any problems.
> >
> > Since there are many Apache projects have maintainers[1][2], with some
> > major responsibilities for the code base, and we want to try out this
> > mechanism for a certain time. Each major component has 2~3 maintainers,
> who
> > are responsible for the following:
> >
> > 1. Providing timely feedback on JIRA issues, bug reports, wishes, and so
> > on.
> > 2. Review code contributions(PRs) as promptly as possible, also
> coordinate
> > other committers to help review.
> > 3. Merge PRs after review stage.
> >
> > Any advice is welcome.
> >
> > [1]. http://mesos.apache.org/documentation/latest/committers/
> > [2]. https://cwiki.apache.org/confluence/display/KAFKA/Maintainers
> >
> > Regards,
> > yukon
> >
>
>
>
> --
> perl -e 'print
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ 
> Twitter: http://twitter.com/brucesnyder
>

Podling Press Kit

[johndament]

Dear Podling,

As you may be aware, the Incubator has recently selected a new logo.  In 
conjunction with this new logo, Sally has prepared material to help podlings 
incorporate incubator branding into their logos.

Please review the Press Kit for Podlings page at 
http://incubator.apache.org/guides/press-kit.html .  If you have any questions, 
please follow up on general AT incubator or press AT apache.

John

Re: [DISCUSS] Import Maintainer Mechanism for Apache RocketMQ

[Bruce Snyder]

Hi yukon,

I haven't heard of this concept at the ASF before, so I guess it's
something that only a few projects are using. It seems kinda heavy-handed,
but maybe this is just my perspective in not having worked on the RocketMQ
code base. Is the RocketMQ code base currently divided up with certain
people working only in certain areas?

Bruce

On Thu, Apr 13, 2017 at 2:12 AM, yukon  wrote:

> Hi all,
>
> We have noticed that there are some problems in our PR review process, as
> Justin mentioned in the IPMC board report, the slow PR processing speed
> will drain contributors' positive energy for continuous contribution, which
> will impede healthy development of Apache RocketMQ community.
>
> So we want to import the maintainer mechanism for Apache RocketMQ to
> promote the development of community efficiently, but I am not sure whether
> it's ok for a incubator project, please mentors let me know If there are
> any problems.
>
> Since there are many Apache projects have maintainers[1][2], with some
> major responsibilities for the code base, and we want to try out this
> mechanism for a certain time. Each major component has 2~3 maintainers, who
> are responsible for the following:
>
> 1. Providing timely feedback on JIRA issues, bug reports, wishes, and so
> on.
> 2. Review code contributions(PRs) as promptly as possible, also coordinate
> other committers to help review.
> 3. Merge PRs after review stage.
>
> Any advice is welcome.
>
> [1]. http://mesos.apache.org/documentation/latest/committers/
> [2]. https://cwiki.apache.org/confluence/display/KAFKA/Maintainers
>
> Regards,
> yukon
>



-- 
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E
Twitter: http://twitter.com/brucesnyder

Re: [DISCUSS] Import Maintainer Mechanism for Apache RocketMQ

[Von Gosling]

+1

I remembered storm pmc member xinwang has raised the similar problem. IMO, we 
can learn from Apache other project’s best practice. Maintainer’s introduction 
is a good choise for RocketMQ's Issue, codebase and other community affairs. 
Consider this is a good start, We could polish this mechanism continuously :-)

> 在 2017年4月13日，16:12，yukon  写道：
> 
> Hi all,
> 
> We have noticed that there are some problems in our PR review process, as
> Justin mentioned in the IPMC board report, the slow PR processing speed
> will drain contributors' positive energy for continuous contribution, which
> will impede healthy development of Apache RocketMQ community.
> 
> So we want to import the maintainer mechanism for Apache RocketMQ to
> promote the development of community efficiently, but I am not sure whether
> it's ok for a incubator project, please mentors let me know If there are
> any problems.
> 
> Since there are many Apache projects have maintainers[1][2], with some
> major responsibilities for the code base, and we want to try out this
> mechanism for a certain time. Each major component has 2~3 maintainers, who
> are responsible for the following:
> 
> 1. Providing timely feedback on JIRA issues, bug reports, wishes, and so on.
> 2. Review code contributions(PRs) as promptly as possible, also coordinate
> other committers to help review.
> 3. Merge PRs after review stage.
> 
> Any advice is welcome.
> 
> [1]. http://mesos.apache.org/documentation/latest/committers/
> [2]. https://cwiki.apache.org/confluence/display/KAFKA/Maintainers
> 
> Regards,
> yukon

[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors

[zhouxinyu]

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  
The JIRA issue is here: https://issues.apache.org/jira/browse/ROCKETMQ-174
And I have added a time tracker for this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

[vesense]

Github user vesense commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/87
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[lizhanhui]

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111319070
  
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
 
  If the change is non-trivial please include some unit tests that 
cover the new functionality.
  If you are introducing a completely new feature or API it is a good 
idea to start a wiki and get consensus on the basic design first.
- It is our job to follow up on patches in a timely fashion. Nag us if 
we aren't doing our job (sometimes we drop things).
+ It is our job to follow up on patches in a timely fashion. Nag us if 
we arn't doing our job timely enough (sometimes we may miss things).
--- End diff --

Yes, aren't is right. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #90: [ROCKETMQ-172]log improvement for rocketmq cli...

[vesense]

Github user vesense commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/90
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors

[vesense]

Github user vesense commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  
Overall looks good to me. Nice job!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[vesense]

Github user vesense commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111317677
  
--- Diff: CONTRIBUTING.md ---
@@ -11,7 +11,7 @@ To submit a change for inclusion, please do the following:
 
  If the change is non-trivial please include some unit tests that 
cover the new functionality.
  If you are introducing a completely new feature or API it is a good 
idea to start a wiki and get consensus on the basic design first.
- It is our job to follow up on patches in a timely fashion. Nag us if 
we aren't doing our job (sometimes we drop things).
+ It is our job to follow up on patches in a timely fashion. Nag us if 
we arn't doing our job timely enough (sometimes we may miss things).
--- End diff --

arn't -> aren't ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #77: [ROCKETMQ-140]Guard MQVesion methods.

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/77
  
Sorry to response for this PR. It seems good ~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/87
  
@shroman @lizhanhui Could you help us to review this long-time delayed PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---