[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

2017-08-11 Thread shroman
Github user shroman commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132808594
  
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -59,7 +59,7 @@
 public static final String WS_DOMAIN_NAME = 
System.getProperty("rocketmq.namesrv.domain", DEFAULT_NAMESRV_ADDR_LOOKUP);
 public static final String WS_DOMAIN_SUBGROUP = 
System.getProperty("rocketmq.namesrv.domain.subgroup", "nsaddr");
 //// http://jmenv.tbsite.net:8080/rocketmq/nsaddr
-//public static final String WS_ADDR = "http://; + WS_DOMAIN_NAME + 
":8080/rocketmq/" + WS_DOMAIN_SUBGROUP;
+public static final String WS_ADDR = "http://; + WS_DOMAIN_NAME + 
":8080/rocketmq/" + WS_DOMAIN_SUBGROUP;
--- End diff --

Is it legal to bring `WS_ADDR`? It was commented out for a reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Passed: apache/incubator-rocketmq#738 (develop - f091203)

2017-08-11 Thread Travis CI
Build Update for apache/incubator-rocketmq
-

Build: #738
Status: Passed

Duration: 23 minutes and 47 seconds
Commit: f091203 (develop)
Author: yukon
Message: Remove preceded whitespace check from checkstyle

View the changeset: 
https://github.com/apache/incubator-rocketmq/compare/97aa813eb89c...f091203a9d4a

View the full build log and details: 
https://travis-ci.org/apache/incubator-rocketmq/builds/263506475?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications



Passed: apache/incubator-rocketmq#740 (develop - 332df78)

2017-08-11 Thread Travis CI
Build Update for apache/incubator-rocketmq
-

Build: #740
Status: Passed

Duration: 22 minutes and 46 seconds
Commit: 332df78 (develop)
Author: yukon
Message: [ROCKETMQ-261] Use write lock when destroy IndexService

View the changeset: 
https://github.com/apache/incubator-rocketmq/compare/f613c3b7dfef...332df78e2bb6

View the full build log and details: 
https://travis-ci.org/apache/incubator-rocketmq/builds/263515792?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications



Errored: apache/incubator-rocketmq#736 (develop - 97aa813)

2017-08-11 Thread Travis CI
Build Update for apache/incubator-rocketmq
-

Build: #736
Status: Errored

Duration: 2 minutes and 30 seconds
Commit: 97aa813 (develop)
Author: yukon
Message: Reformat code globally second time

View the changeset: 
https://github.com/apache/incubator-rocketmq/compare/ffad6566b8ae...97aa813eb89c

View the full build log and details: 
https://travis-ci.org/apache/incubator-rocketmq/builds/263481018?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications



[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/103
  

[![Coverage 
Status](https://coveralls.io/builds/12794894/badge)](https://coveralls.io/builds/12794894)

Coverage increased (+7.8%) to 38.816% when pulling 
**dea7f85d6bcd55e941aa8831128e901e2db2f1e0 on StyleTang:master** into 
**fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #103: [ROCKETMQ-198]add LanguageCode for GO and PHP

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/103
  

[![Coverage 
Status](https://coveralls.io/builds/12794894/badge)](https://coveralls.io/builds/12794894)

Coverage increased (+7.8%) to 38.816% when pulling 
**dea7f85d6bcd55e941aa8831128e901e2db2f1e0 on StyleTang:master** into 
**fa85abcdf6ee46e56403ddf86828a38683103fd0 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

2017-08-11 Thread StyleTang
Github user StyleTang closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

2017-08-11 Thread StyleTang
Github user StyleTang closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #103: [ROCKETMQ-198]add LanguageCode for GO ...

2017-08-11 Thread StyleTang
GitHub user StyleTang reopened a pull request:

https://github.com/apache/incubator-rocketmq/pull/103

[ROCKETMQ-198]add LanguageCode for GO and PHP

https://issues.apache.org/jira/browse/ROCKETMQ-198
LanguageCode without GO. The language can only use OTHER

![go-client-consumer-detail](https://raw.githubusercontent.com/StyleTang/self-test/master/pic/go-client-consumer-detail-new.png)
[Go-Client's 
implement](https://github.com/apache/incubator-rocketmq-externals/pull/22)
[Go-Client's 
design](https://github.com/apache/incubator-rocketmq-externals/pull/19)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/StyleTang/incubator-rocketmq master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #103


commit dea7f85d6bcd55e941aa8831128e901e2db2f1e0
Author: tangjie 
Date:   2017-05-13T02:38:11Z

add LanguageCode for GO and PHP




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Errored: apache/incubator-rocketmq#729 (develop - aa1c757)

2017-08-11 Thread Travis CI
Build Update for apache/incubator-rocketmq
-

Build: #729
Status: Errored

Duration: 31 minutes and 12 seconds
Commit: aa1c757 (develop)
Author: lindzh
Message: [ROCKETMQ-254]Fix logger appender unit tests which cost too long

Author: lindzh 

Closes #141 from lindzh/logger_appender_test.

View the changeset: 
https://github.com/apache/incubator-rocketmq/compare/bcc65e5471d9...aa1c75774eb3

View the full build log and details: 
https://travis-ci.org/apache/incubator-rocketmq/builds/263391481?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications



Passed: apache/incubator-rocketmq#732 (develop - 38bbb14)

2017-08-11 Thread Travis CI
Build Update for apache/incubator-rocketmq
-

Build: #732
Status: Passed

Duration: 20 minutes and 2 seconds
Commit: 38bbb14 (develop)
Author: yukon
Message: [ROCKETMQ-263]Sets a small timeout value for unit tests in 
OpenMessaging module

View the changeset: 
https://github.com/apache/incubator-rocketmq/compare/aa1c75774eb3...38bbb1417bcd

View the full build log and details: 
https://travis-ci.org/apache/incubator-rocketmq/builds/263426629?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications



[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-11 Thread vongosling
Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/134
  
@Ritabrata-TW I found so many code format in your PR, could you import our 
code style file as instruction, 
http://rocketmq.incubator.apache.org/docs/code-guidelines/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #145: [ROCKETMQ-264]Fix unit test cost too long and...

2017-08-11 Thread vongosling
Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/145
  
How long it would take in your computer ? @Jaskey @vsair, please double 
check this optimized ut.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #134: [ROCKETMQ-44] Duplicated Codes in DefaultMess...

2017-08-11 Thread Ritabrata-TW
Github user Ritabrata-TW commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/134
  
@vongosling @zhouxinyu Anything else that I need to do on this? Otherwise, 
can you please have a look and merge it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #145: [ROCKETMQ-264]Fix unit test cost too long and...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/145
  

[![Coverage 
Status](https://coveralls.io/builds/12792890/badge)](https://coveralls.io/builds/12792890)

Coverage decreased (-0.2%) to 38.742% when pulling 
**c818e364fe910821913ffcc83414c1b77241a374 on lindzh:fix_test_exeception** into 
**ccc2235ae9509f101971915ba0521109a82894b0 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #145: [ROCKETMQ-264]Fix unit test cost too long and...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/145
  

[![Coverage 
Status](https://coveralls.io/builds/12792667/badge)](https://coveralls.io/builds/12792667)

Coverage decreased (-0.1%) to 38.925% when pulling 
**91a3ec9d2b2e3fa2942c6c45f28b4ccd8ee71041 on lindzh:fix_test_exeception** into 
**aa1c75774eb33fca9a1c3f036249b6c5b86ef0f5 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #145: [ROCKETMQ-264]Fix unit test cost too long and...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/145
  

[![Coverage 
Status](https://coveralls.io/builds/12792667/badge)](https://coveralls.io/builds/12792667)

Coverage decreased (-0.1%) to 38.925% when pulling 
**91a3ec9d2b2e3fa2942c6c45f28b4ccd8ee71041 on lindzh:fix_test_exeception** into 
**aa1c75774eb33fca9a1c3f036249b6c5b86ef0f5 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #145: [ROCKETMQ-264] Fix unit test cost too ...

2017-08-11 Thread lindzh
GitHub user lindzh opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/145

[ROCKETMQ-264] Fix unit test cost too long and exception in unit test

When run mvn test , it cost too much time and some times there is exception 
in unit test and the test result is pass

JIRA ticket https://issues.apache.org/jira/browse/ROCKETMQ-264

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lindzh/incubator-rocketmq fix_test_exeception

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #145


commit bcc65e5471d9821e0edb90f6f637e3034ed1da44
Author: lindzh 
Date:   2017-08-11T06:36:53Z

[ROCKETMQ-231]Wrong Pull result sizebugfix

Author: lindzh 

Closes #126 from lindzh/fix_consumer_pull_msg_size.

commit aa1c75774eb33fca9a1c3f036249b6c5b86ef0f5
Author: lindzh 
Date:   2017-08-11T07:40:24Z

[ROCKETMQ-254]Fix logger appender unit tests which cost too long

Author: lindzh 

Closes #141 from lindzh/logger_appender_test.

commit 1ae0693693da4a147f1bb3c122833f548c376b09
Author: lindzh 
Date:   2017-08-11T07:55:24Z

Merge branch 'develop' of github.com:apache/incubator-rocketmq into develop

commit 91a3ec9d2b2e3fa2942c6c45f28b4ccd8ee71041
Author: lindzh 
Date:   2017-08-11T09:30:07Z

Fix unit test,delete invalid test and make test cost less time




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/129
  

[![Coverage 
Status](https://coveralls.io/builds/12791570/badge)](https://coveralls.io/builds/12791570)

Coverage increased (+0.6%) to 39.648% when pulling 
**8302bb878afb37c199fbfa6659b2cc7f0168e43a on 
lindzh:fix_query_message_by_time** into 
**aa1c75774eb33fca9a1c3f036249b6c5b86ef0f5 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/129
  

[![Coverage 
Status](https://coveralls.io/builds/12791570/badge)](https://coveralls.io/builds/12791570)

Coverage increased (+0.6%) to 39.648% when pulling 
**8302bb878afb37c199fbfa6659b2cc7f0168e43a on 
lindzh:fix_query_message_by_time** into 
**aa1c75774eb33fca9a1c3f036249b6c5b86ef0f5 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #141: [ROCKETMQ-254] fix logger appender uni...

2017-08-11 Thread lindzh
Github user lindzh closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

2017-08-11 Thread lollipopjin
Github user lollipopjin commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  
Thanks @lindzh. I have merged it, please close this pr :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #129: [ROCKETMQ-239]fix query message by time and f...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/129
  

[![Coverage 
Status](https://coveralls.io/builds/12791061/badge)](https://coveralls.io/builds/12791061)

Coverage increased (+0.6%) to 39.711% when pulling 
**d1f2b9d6bcd7324774a0cc75ee577a1726ff9505 on 
lindzh:fix_query_message_by_time** into 
**d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12790961/badge)](https://coveralls.io/builds/12790961)

Coverage decreased (-0.6%) to 38.989% when pulling 
**0afab06e67404871cbd52f904c70c1a2a9e80876 on lindzh:logger_appender_test** 
into **bcc65e5471d9821e0edb90f6f637e3034ed1da44 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12790961/badge)](https://coveralls.io/builds/12790961)

Coverage decreased (-0.6%) to 38.989% when pulling 
**0afab06e67404871cbd52f904c70c1a2a9e80876 on lindzh:logger_appender_test** 
into **bcc65e5471d9821e0edb90f6f637e3034ed1da44 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #141: [ROCKETMQ-254] fix logger appender unit test ...

2017-08-11 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12790961/badge)](https://coveralls.io/builds/12790961)

Coverage decreased (-0.6%) to 38.989% when pulling 
**0afab06e67404871cbd52f904c70c1a2a9e80876 on lindzh:logger_appender_test** 
into **bcc65e5471d9821e0edb90f6f637e3034ed1da44 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #126: [ROCKETMQ-231] fix pull consumer pull ...

2017-08-11 Thread lindzh
Github user lindzh closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/126


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #126: [ROCKETMQ-231] fix pull consumer pull result ...

2017-08-11 Thread vongosling
Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/126
  
Thanks @lindzh, i have merged it. Please close this PR :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #144: [ROCKETMQ-257] name server address and...

2017-08-11 Thread qqeasonchen
Github user qqeasonchen commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132623736
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ---
@@ -225,10 +225,13 @@ public void start() throws MQClientException {
 switch (this.serviceState) {
 case CREATE_JUST:
 this.serviceState = ServiceState.START_FAILED;
-// If not specified,looking address from name server
-if (null == this.clientConfig.getNamesrvAddr()) {
+// name server address and web server address should 
be specified at least one
+if (null == this.clientConfig.getNamesrvAddr() && 
MixAll.getWSAddr().equals(MixAll.WS_ADDR)) {
+throw new MQClientException("name server address 
and web server address should be specified at least one.", null);
--- End diff --

default wsaddr is not reachable, he need to set his own address


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq pull request #126: [ROCKETMQ-231] fix pull consumer pull ...

2017-08-11 Thread lindzh
Github user lindzh commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/126#discussion_r132622123
  
--- Diff: 
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -45,19 +47,22 @@ public void init() throws Exception {
 BornHost = new 
InetSocketAddress(InetAddress.getByName("127.0.0.1"), 0);
 }
 
+public MessageStore buildMessageStore() throws Exception {
+MessageStoreConfig messageStoreConfig = new MessageStoreConfig();
+messageStoreConfig.setMapedFileSizeCommitLog(1024 * 1024 * 10);
+messageStoreConfig.setMapedFileSizeConsumeQueue(1024 * 1024 * 10);
+messageStoreConfig.setMaxHashSlotNum(1);
+messageStoreConfig.setMaxIndexNum(100 * 100);
+messageStoreConfig.setFlushDiskType(FlushDiskType.ASYNC_FLUSH);
+return new DefaultMessageStore(messageStoreConfig, new 
BrokerStatsManager("simpleTest"), new MyMessageArrivingListener(), new 
BrokerConfig());
--- End diff --

Indeed this is a must after testing,and this bug has been fix in PR 
https://github.com/apache/incubator-rocketmq/pull/141 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---