Build failed in Jenkins: royale-asjs_MXTests #1166

[Apache Royale CI Server]

See 


--
[...truncated 1003.29 KB...]
[mxmlc] scanning for overrides: ObjectUtil
[mxmlc] scanning for overrides: SolidBorderUtil
[mxmlc] scanning for overrides: StringTrimmer
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: Timer
[mxmlc] scanning for overrides: UIUtils
[mxmlc] scanning for overrides: Effect
[mxmlc] scanning for overrides: Transition
[mxmlc] scanning for overrides: IFill
[mxmlc] scanning for overrides: SolidColor
[mxmlc] scanning for overrides: IExternalizable
[mxmlc] scanning for overrides: Proxy
[mxmlc] scanning for overrides: CursorBookmark
[mxmlc] scanning for overrides: ICollectionView
[mxmlc] scanning for overrides: IList
[mxmlc] scanning for overrides: IViewCursor
[mxmlc] scanning for overrides: ListCollectionView
[mxmlc] scanning for overrides: ListCollectionViewCursor
[mxmlc] scanning for overrides: ListCollectionViewBookmark
[mxmlc] scanning for overrides: ArrayCollection
[mxmlc] scanning for overrides: ArrayList
[mxmlc] scanning for overrides: XMLListCollection
[mxmlc] scanning for overrides: CanvasLayout
[mxmlc] scanning for overrides: Flex
[mxmlc] scanning for overrides: BoxDirection
[mxmlc] scanning for overrides: HBox
[mxmlc] scanning for overrides: PanelTitleBar
[mxmlc] scanning for overrides: DataGridColumn
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ISelectable
[mxmlc] scanning for overrides: CheckBox
[mxmlc] scanning for overrides: IFocusManagerComponent
[mxmlc] scanning for overrides: ComboBase
[mxmlc] scanning for overrides: ComboBox
[mxmlc] scanning for overrides: ScrollControlBase
[mxmlc] scanning for overrides: ListBase
[mxmlc] scanning for overrides: DataGrid
[mxmlc] scanning for overrides: DateField
[mxmlc] scanning for overrides: Label
[mxmlc] scanning for overrides: List
[mxmlc] scanning for overrides: MenuBar
[mxmlc] scanning for overrides: NumericStepper
[mxmlc] scanning for overrides: RadioButton
[mxmlc] scanning for overrides: RadioButtonGroup
[mxmlc] scanning for overrides: TextArea
[mxmlc] scanning for overrides: ITextInput
[mxmlc] scanning for overrides: TextInput
[mxmlc] scanning for overrides: ITextFieldFactory
[mxmlc] scanning for overrides: Singleton
[mxmlc] scanning for overrides: ItemClickEvent
[mxmlc] scanning for overrides: ListEvent
[mxmlc] scanning for overrides: MenuEvent
[mxmlc] scanning for overrides: MouseEvent
[mxmlc] scanning for overrides: PropertyChangeEventKind
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: IFocusManagerComplexComponent
[mxmlc] scanning for overrides: IFocusManagerGroup
[mxmlc] scanning for overrides: IResourceBundle
[mxmlc] scanning for overrides: ResourceManagerImpl
[mxmlc] scanning for overrides: ResourceModuleInfo
[mxmlc] scanning for overrides: ResourceEventDispatcher
[mxmlc] scanning for overrides: ResourceBundleProxy
[mxmlc] scanning for overrides: GroupBase
[mxmlc] scanning for overrides: SkinnableComponent
[mxmlc] scanning for overrides: ButtonBase
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ErrorArray
[mxmlc] scanning for overrides: RunCodeEvent
[mxmlc] scanning for overrides: PasswordInputBead
[mxmlc] scanning for overrides: ITileLayout
[mxmlc] scanning for overrides: TileLayout
[mxmlc] scanning for overrides: LocaleUtils
[mxmlc] scanning for overrides: StringPadder
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: IStroke
[mxmlc] scanning for overrides: CursorError
[mxmlc] scanning for overrides: SortError
[mxmlc] scanning for overrides: ISort
[mxmlc] scanning for overrides: Sort
[mxmlc] scanning for overrides: IXMLNotifiable
[mxmlc] scanning for overrides: XMLListAdapter
[mxmlc] scanning for overrides: FlexChildInfo
[mxmlc] scanning for overrides: BaseListData
[mxmlc] scanning for overrides: IFactory
[mxmlc] scanning for overrides: IUITextField
[mxmlc] scanning for overrides: UITextField
[mxmlc] scanning for overrides: CollectionEvent
[mxmlc] scanning for overrides: CollectionEventKind
[mxmlc] scanning for overrides: LocaleSorter
[mxmlc] scanning for overrides: LocaleID
[mxmlc] scanning for overrides: LocaleRegistry
[mxmlc] scanning for overrides: ResourceBundle
[mxmlc] scanning for overrides: ArrayUtil
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: DataGroup
[mxmlc] scanning for overrides: LayoutBase
[mxmlc] scanning for overrides: BasicLayout

Build failed in Jenkins: royale-asjs_MXTests #1165

[Apache Royale CI Server]

See 


Changes:

[joshtynjala] RoyaleUnit: RunNotifierTests

[joshtynjala] RoyaleUnit: fix event listener removal on MetadataRunner timer

[joshtynjala] RoyaleUnit: Started implementing async tests

--
[...truncated 1003.12 KB...]
[mxmlc] scanning for overrides: ObjectUtil
[mxmlc] scanning for overrides: SolidBorderUtil
[mxmlc] scanning for overrides: StringTrimmer
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: Timer
[mxmlc] scanning for overrides: UIUtils
[mxmlc] scanning for overrides: Effect
[mxmlc] scanning for overrides: Transition
[mxmlc] scanning for overrides: IFill
[mxmlc] scanning for overrides: SolidColor
[mxmlc] scanning for overrides: IExternalizable
[mxmlc] scanning for overrides: Proxy
[mxmlc] scanning for overrides: CursorBookmark
[mxmlc] scanning for overrides: ICollectionView
[mxmlc] scanning for overrides: IList
[mxmlc] scanning for overrides: IViewCursor
[mxmlc] scanning for overrides: ListCollectionView
[mxmlc] scanning for overrides: ListCollectionViewCursor
[mxmlc] scanning for overrides: ListCollectionViewBookmark
[mxmlc] scanning for overrides: ArrayCollection
[mxmlc] scanning for overrides: ArrayList
[mxmlc] scanning for overrides: XMLListCollection
[mxmlc] scanning for overrides: CanvasLayout
[mxmlc] scanning for overrides: Flex
[mxmlc] scanning for overrides: BoxDirection
[mxmlc] scanning for overrides: HBox
[mxmlc] scanning for overrides: PanelTitleBar
[mxmlc] scanning for overrides: DataGridColumn
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ISelectable
[mxmlc] scanning for overrides: CheckBox
[mxmlc] scanning for overrides: IFocusManagerComponent
[mxmlc] scanning for overrides: ComboBase
[mxmlc] scanning for overrides: ComboBox
[mxmlc] scanning for overrides: ScrollControlBase
[mxmlc] scanning for overrides: ListBase
[mxmlc] scanning for overrides: DataGrid
[mxmlc] scanning for overrides: DateField
[mxmlc] scanning for overrides: Label
[mxmlc] scanning for overrides: List
[mxmlc] scanning for overrides: MenuBar
[mxmlc] scanning for overrides: NumericStepper
[mxmlc] scanning for overrides: RadioButton
[mxmlc] scanning for overrides: RadioButtonGroup
[mxmlc] scanning for overrides: TextArea
[mxmlc] scanning for overrides: ITextInput
[mxmlc] scanning for overrides: TextInput
[mxmlc] scanning for overrides: ITextFieldFactory
[mxmlc] scanning for overrides: Singleton
[mxmlc] scanning for overrides: ItemClickEvent
[mxmlc] scanning for overrides: ListEvent
[mxmlc] scanning for overrides: MenuEvent
[mxmlc] scanning for overrides: MouseEvent
[mxmlc] scanning for overrides: PropertyChangeEventKind
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: IFocusManagerComplexComponent
[mxmlc] scanning for overrides: IFocusManagerGroup
[mxmlc] scanning for overrides: IResourceBundle
[mxmlc] scanning for overrides: ResourceManagerImpl
[mxmlc] scanning for overrides: ResourceModuleInfo
[mxmlc] scanning for overrides: ResourceEventDispatcher
[mxmlc] scanning for overrides: ResourceBundleProxy
[mxmlc] scanning for overrides: GroupBase
[mxmlc] scanning for overrides: SkinnableComponent
[mxmlc] scanning for overrides: ButtonBase
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ErrorArray
[mxmlc] scanning for overrides: RunCodeEvent
[mxmlc] scanning for overrides: PasswordInputBead
[mxmlc] scanning for overrides: ITileLayout
[mxmlc] scanning for overrides: TileLayout
[mxmlc] scanning for overrides: LocaleUtils
[mxmlc] scanning for overrides: StringPadder
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: IStroke
[mxmlc] scanning for overrides: CursorError
[mxmlc] scanning for overrides: SortError
[mxmlc] scanning for overrides: ISort
[mxmlc] scanning for overrides: Sort
[mxmlc] scanning for overrides: IXMLNotifiable
[mxmlc] scanning for overrides: XMLListAdapter
[mxmlc] scanning for overrides: FlexChildInfo
[mxmlc] scanning for overrides: BaseListData
[mxmlc] scanning for overrides: IFactory
[mxmlc] scanning for overrides: IUITextField
[mxmlc] scanning for overrides: UITextField
[mxmlc] scanning for overrides: CollectionEvent
[mxmlc] scanning for overrides: CollectionEventKind
[mxmlc] scanning for overrides: LocaleSorter
[mxmlc] scanning for overrides: LocaleID
[mxmlc] scanning for overrides: LocaleRegistry
[mxmlc] scanning for overrides: ResourceBundle
[mxmlc] scanning for overrides: ArrayUtil
[mxmlc] scanning for 

Jenkins build is back to normal : royale-asjs #2714

[Apache Royale CI Server]

See 

New RoyaleUnit commits on develop should not go into release/0.9.6

[Josh Tynjala]

I'm starting to add support for asynchronous tests to RoyaleUnit in the
develop branch. It's still a work in progress, and things may be unstable.
Please do not cherry pick any of these RoyaleUnit commits into release/
0.9.6. Thanks!

--
Josh Tynjala
Bowler Hat LLC 

Build failed in Jenkins: royale-asjs #2713

[Apache Royale CI Server]

See 


Changes:

[joshtynjala] RoyaleUnit: RunNotifierTests

[joshtynjala] RoyaleUnit: fix event listener removal on MetadataRunner timer

--
[...truncated 1.82 MB...]
clean:
 [echo] swc-date is 09/18/19 21:18 +
   [delete] Deleting: 


check-for-tests:

clean-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Cross-compiling IconsJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=09/18/19 21:18 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 31277 bytes written to 
C:\jenkins\workspace\royale-asjs\frameworks\js\projects\IconsJS\target\IconsJS.swc
 in 1.499 seconds
 [java] COMPCJSCRoyale
 [java] 3.2493427 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [copy] Copying 1 file to 


main:

copy-swc:
 [copy] Copying 1 file to 


check-for-tests:

test:

main:

test:

RoyaleUnitTest:
 [echo] swc-date is 09/18/19 21:18 +

check-for-tests:

check-compiler-home:

check-transpiler-home:

check-compiler:

test:

clean:

compile:
 [echo] Compiling FlexUnitRoyaleApplication.swf
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] playerglobal.version: 11.7
Trying to override old definition of task compc
Trying to override old definition of task mxmlc
[mxmlc] MXMLJSC
[mxmlc] -debug
[mxmlc] -compiler.targets=SWF
[mxmlc] +playerglobal.version=11.7
[mxmlc] +env.PLAYERGLOBAL_HOME=C:\adobe\flash
[mxmlc] 
+royalelib=
[mxmlc] 
-output=
[mxmlc] --
[mxmlc] 

[mxmlc] Loading configuration: 

[mxmlc] Loading configuration: 

[mxmlc] 
[mxmlc] scanning for overrides: IFlexInfo
[mxmlc] scanning for overrides: ApplicationBase
[mxmlc] scanning for overrides: IEventDispatcher
[mxmlc] scanning for overrides: IInitialViewApplication
[mxmlc] scanning for overrides: IParent
[mxmlc] scanning for overrides: IPopUpHost
[mxmlc] scanning for overrides: IPopUpHostParent
[mxmlc] scanning for overrides: IRenderedObject
[mxmlc] scanning for overrides: IStrand
[mxmlc] scanning for overrides: Application
[mxmlc] scanning for overrides: FlexUnitRoyaleApplication
[mxmlc] scanning for overrides: RoyaleUnitSuite
[mxmlc] scanning for overrides: IStatesObject
[mxmlc] scanning for overrides: IChild
[mxmlc] scanning 

Build failed in Jenkins: royale-asjs #2712

[Apache Royale CI Server]

See 


Changes:

[joshtynjala] RoyaleUnit: tests for BeforeClass and AfterClass scope

[joshtynjala] RoyaleUnit: started implementing MetadataRunner architecture 
change to

--
[...truncated 1.33 MB...]
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=09/18/19 20:10 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 28227 bytes written to 
C:\jenkins\workspace\royale-asjs\frameworks\js\projects\BindingJS\target\BindingJS.swc
 in 1.798 seconds
 [java] COMPCJSCRoyale
 [java] 3.7755752 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [copy] Copying 1 file to 


main:

copy-swc:
 [copy] Copying 1 file to 


check-for-tests:

test:

main:

Reflection:
 [echo] swc-date is 09/18/19 20:10 +

clean:
 [echo] swc-date is 09/18/19 20:10 +

check-for-tests:

clean-tests:

clean:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Compiling libs/Reflection.swc
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] ROYALE_COMPILER_HOME: 

 [java] args:
 [java] 
+royalelib=
 [java] +playerglobal.version=11.7
 [java] +env.AIR_HOME=C:\adobe\air\4.0\AdobeAIRSDK
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=09/18/19 20:10 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-js-load-config=
 [java] 
-js-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] 
 [java] 32302 bytes written to 
C:\jenkins\workspace\royale-asjs\frameworks\projects\Reflection\target\Reflection.swc
 in 2.012 seconds
 [java] COMPCJSCRoyale
 [java] 4.3138358 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 

compile-js:
 [echo] swc-date is 09/18/19 20:10 +
   [delete] Deleting: 


clean:
 [echo] swc-date is 09/18/19 20:10 +
   [delete] Deleting: 

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Greg Dove]

Responses also inline.
Beyond this reply, I'm going to dip out and let others contribute their
ideas for a bit... because I really need to focus on other things for now.
If I go silent that is why.

On Thu, Sep 19, 2019 at 7:14 AM Alex Harui  wrote:

> Responses inline.
>
> On 9/18/19, 11:53 AM, "Greg Dove"  wrote:
>
> Alex, the idea was to make the js output itself support the options,
> without any need to manipulate any files at all.
> Why would you not want to use goog defines?
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fclosure-compiler%2Fwiki%2FAnnotating-JavaScript-for-the-Closure-Compiler%23define-type-descriptiondata=02%7C01%7Caharui%40adobe.com%7C05e47962202a40946eac08d73c697d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637044296118065315sdata=6RqR1nhJBOv9u0nAwGst325wXtHwWuKozGPZncE2FY0%3Dreserved=0
>
> It seems like the easiest way and it leverages the strength of GCC.
>
> if (JSBuild.includeReflection) {
> regular reflection data
> }
>
> I haven’t spent a lot of time thinking about this, but I don't see how a
> flag like JSBUild.includeReflection will drop reflection data for framework
> classes unless we specify only certain classes as "framework classes" and
> thus give only them that flag.
>

A single flag wouldn't. But with some careful planning a set of bit flags
could be used to achieve reasonable selectability I think. Not something
for most users, I agree. TBH I don't think most people will care about this
level of detail for reflection, but I can see people definitely wanting to
exclude it if they never use it in their app, and I'm sure some might want
to really tune it at a granular level. Perhaps there is simply and on and
off switch and the codeflow approach you mentioned can be introduced later
for people who want the real stuff.

>
> redefining that JSBuild.includeReflection goog define to be false at
> the
> application build stage (which is for illustrative purposes here
> only,  and
> would be true by default), eliminates it from all classes (that have
> had it
> included in the js output) in the release build, just like how
> goog.DEBUG
> works now.
>
> Having alternate swcs sounds complicated to me. It's different, but in
> some
> ways conceptually similar to monkey patching I guess (which works
> also).
> But it seems less desirable than being able to get everything you need
> from
> the one swc.
>
> OT: For the public vars stuff, that is not an issue for AMF
> serialization.
> Reflection classes do support the public var renaming and AMF works
> fine
> with the minimized names. I think the general issue with public vars is
> that people can use regular dynamic access in actionscript, and that
> should
> work by default rather than be another hurdle. But of course it should
> also
> be able to be switched back to how it is now.
>
> public vars is not OT.  It is the subject of this thread.  I'm curious as
> to how AMF supports the minified names.  When an object comes in from the
> server with a "name" property, how do you know it is now called "aa"?
>
> Good call.
The Variabledefinition and AccessorDefinition classes both have getValue
and setValue on-demand getter/setter creation. Support for public vars uses
a single function that serves as a getter/setter internally which supports
the renamed value in terms of getting/setting. Because all this is created
on demand it does not add any overhead at startup, but it works like it
should when it is needed via reflection. It's battle tested, works for AMF
and Crux and I also use it in the manual-tests unit testing setup to run
the same tests across debug and release builds. So to answer your
question... it doesn't know or care what the renamed name is, the
reflection class will map to it via its own gettter/setter approach.


> The ideas for the  granular stuff are interesting, but I think we need
> to
> go with things that are achievable in the near future, unless you
> realistically think the code-flow stuff is something you can work on.
> I don't think it's for me, but I believe I can do the stuff I already
> mentioned. And I don't expect the approaches would be mutually
> exclusive in
> terms of evolving things in the future.
>
> My point is to be careful as to how much time we make folks spend trying
> to understand our compiler options when we might want to do more
> intelligent things instead.  Having metadata or an interface drive the
> output of public var is not complex like code-flow analysis and might avoid
> folks having to learn some of these options or implement more options.  Or
> we might try inspecting GCC's string table to know what strings are being
> used and prevent renaming based on that table.  Code-flow is hard, but GCC
> is using it and we might be able to leverage theirs.
>
> We already have all these compiler options, and I agree they 

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Alex Harui]

Responses inline.

On 9/18/19, 11:53 AM, "Greg Dove"  wrote:

Alex, the idea was to make the js output itself support the options,
without any need to manipulate any files at all.
Why would you not want to use goog defines?

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgoogle%2Fclosure-compiler%2Fwiki%2FAnnotating-JavaScript-for-the-Closure-Compiler%23define-type-descriptiondata=02%7C01%7Caharui%40adobe.com%7C05e47962202a40946eac08d73c697d85%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637044296118065315sdata=6RqR1nhJBOv9u0nAwGst325wXtHwWuKozGPZncE2FY0%3Dreserved=0

It seems like the easiest way and it leverages the strength of GCC.

if (JSBuild.includeReflection) {
regular reflection data
}

I haven’t spent a lot of time thinking about this, but I don't see how a flag 
like JSBUild.includeReflection will drop reflection data for framework classes 
unless we specify only certain classes as "framework classes" and thus give 
only them that flag.

redefining that JSBuild.includeReflection goog define to be false at the
application build stage (which is for illustrative purposes here only,  and
would be true by default), eliminates it from all classes (that have had it
included in the js output) in the release build, just like how goog.DEBUG
works now.

Having alternate swcs sounds complicated to me. It's different, but in some
ways conceptually similar to monkey patching I guess (which works also).
But it seems less desirable than being able to get everything you need from
the one swc.

OT: For the public vars stuff, that is not an issue for AMF serialization.
Reflection classes do support the public var renaming and AMF works fine
with the minimized names. I think the general issue with public vars is
that people can use regular dynamic access in actionscript, and that should
work by default rather than be another hurdle. But of course it should also
be able to be switched back to how it is now.

public vars is not OT.  It is the subject of this thread.  I'm curious as to 
how AMF supports the minified names.  When an object comes in from the server 
with a "name" property, how do you know it is now called "aa"?

The ideas for the  granular stuff are interesting, but I think we need to
go with things that are achievable in the near future, unless you
realistically think the code-flow stuff is something you can work on.
I don't think it's for me, but I believe I can do the stuff I already
mentioned. And I don't expect the approaches would be mutually exclusive in
terms of evolving things in the future.

My point is to be careful as to how much time we make folks spend trying to 
understand our compiler options when we might want to do more intelligent 
things instead.  Having metadata or an interface drive the output of public var 
is not complex like code-flow analysis and might avoid folks having to learn 
some of these options or implement more options.  Or we might try inspecting 
GCC's string table to know what strings are being used and prevent renaming 
based on that table.  Code-flow is hard, but GCC is using it and we might be 
able to leverage theirs.

My 2 cents,
-Alex 

Re: [DISCUSS] Release Apache Royale 0.9.6 RC1

[Alex Harui]

I think the issue is that ApproveRoyale.xml isn't set up to generate the swf 
swcs, but there must be some configuration that causes Binding to look for the 
swf swc.

I want to finish up getting the js-only build to work.  I'll get to this 
eventually, but other volunteers are welcome to beat me to it.

-Alex


On 9/18/19, 9:18 AM, "Josh Tynjala"  wrote:

Maven with -X:


https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fffq08data=02%7C01%7Caharui%40adobe.com%7C72d74643fad746577a9b08d73c53debb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637044203223742173sdata=g84ishVQLjVuOjJxy4hWq0hh%2FsVE3RBM8xhNn0TjuuU%3Dreserved=0

--
Josh Tynjala
Bowler Hat LLC 



On Wed, Sep 18, 2019 at 8:44 AM Piotr Zarzycki 
wrote:

> Thanks Josh. In logs there isn't any url from which you are downloading
> artifacts. It means probably you are using cached one. One option is to
> remove cached artifacts and run build, the second is run build with -X.
> It doesn't have to be full build - it's the matter of see what actually
> maven do.
>
> śr., 18 wrz 2019 o 16:40 Josh Tynjala 
> napisał(a):
>
> > Here's the console output from the Maven section of the build:
> >
> > 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fcczyedata=02%7C01%7Caharui%40adobe.com%7C72d74643fad746577a9b08d73c53debb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637044203223742173sdata=BmZyv3CDpufH424Poxn1lHl28%2Btmj884ykly6At93ZM%3Dreserved=0
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 

> >
> >
> > On Tue, Sep 17, 2019 at 10:20 PM Alex Harui 
> > wrote:
> >
> > > I assume that wasn't the whole log.  I think we want to see the part
> > where
> > > it builds Core, we only see the last bit of Core.  Core looks like it
> > > thought it was in js-only config and didn't build a swf swc and/or
> > Binding
> > > thinks it is building swf swcs and is looking for Core's swf swc.
> > >
> > > FWIW, I am having a bunch of other build issues related to js-only for
> > Ant
> > > for the ASDoc example.  It worked in the past because I still had
> > > PLAYERGLOBAL_HOME set in the environment, but when I took that away a
> > bunch
> > > of new things cropped up.  Could be a  day or two of work.  We could
> > still
> > > approve the release and folks who want js-only will have to not build
> > ASDoc.
> > >
> > > -Alex
> > >
> > > On 9/17/19, 8:59 PM, "Piotr Zarzycki" 
> > wrote:
> > >
> > > Hi Josh,
> > >
> > > Do you have in your Maven config setup link to Maven artifacts?
> Cause
> > > error
> > > is saying that it was attempt of downloading them from Snapshot.
> > > However
> > > Core build successfully, so I'm a bit confused.
> > >
> > > Thanks,
> > > Piotr
> > >
> > > On Tue, Sep 17, 2019, 11:47 PM Josh Tynjala <
> > joshtynj...@bowlerhat.dev
> > > >
> > > wrote:
> > >
> > > > Unfortunately, I'm seeing that the Maven part of ApproveRoyale 
is
> > > failing
> > > > too. Here's the end of my console output:
> > > >
> > > >
> > >
> >
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2F83mivdata=02%7C01%7Caharui%40adobe.com%7C72d74643fad746577a9b08d73c53debb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637044203223742173sdata=0NrDCGs2G%2FabQxQt7MUec9McNtTb7%2FOr0PJxmovyNJg%3Dreserved=0
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC <
> > >
> >
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.devdata=02%7C01%7Caharui%40adobe.com%7C72d74643fad746577a9b08d73c53debb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637044203223742173sdata=U9ZubvSVobxtf%2BSNw9lBo%2FdA7I7%2B7rzN5JOQMJSCi%2FY%3Dreserved=0
> > > >
> > > >
> > > >
> > > > On Tue, Sep 17, 2019 at 2:22 PM Josh Tynjala <
> > > joshtynj...@bowlerhat.dev>
> > > > wrote:
> > > >
> > > > > Getting the following error when running the ApproveRoyale ant
> > > script...
> > > > >
> > > > > Error: unable to open
> > > > >
> > > 

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Greg Dove]

Alex, the idea was to make the js output itself support the options,
without any need to manipulate any files at all.
Why would you not want to use goog defines?
https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#define-type-description

It seems like the easiest way and it leverages the strength of GCC.

if (JSBuild.includeReflection) {
regular reflection data
}

redefining that JSBuild.includeReflection goog define to be false at the
application build stage (which is for illustrative purposes here only,  and
would be true by default), eliminates it from all classes (that have had it
included in the js output) in the release build, just like how goog.DEBUG
works now.

Having alternate swcs sounds complicated to me. It's different, but in some
ways conceptually similar to monkey patching I guess (which works also).
But it seems less desirable than being able to get everything you need from
the one swc.

OT: For the public vars stuff, that is not an issue for AMF serialization.
Reflection classes do support the public var renaming and AMF works fine
with the minimized names. I think the general issue with public vars is
that people can use regular dynamic access in actionscript, and that should
work by default rather than be another hurdle. But of course it should also
be able to be switched back to how it is now.

The ideas for the  granular stuff are interesting, but I think we need to
go with things that are achievable in the near future, unless you
realistically think the code-flow stuff is something you can work on.
I don't think it's for me, but I believe I can do the stuff I already
mentioned. And I don't expect the approaches would be mutually exclusive in
terms of evolving things in the future.

Whatever the menu 'buckets' are can be debated, but they would simply be
sets of granular settings that people don't have to try to understand if
they don't want to.



On Thu, Sep 19, 2019 at 5:24 AM Alex Harui  wrote:

> I probably won't object to folks trying out different config options, but
> the 3 buckets Harbs proposed didn't make any sense to me.  I would want to
> turn them all on, and not be sure what the trade-offs are.
>
> IMO, modifying the JS from SWCs after compilation is "easy" in the sense
> that it is all regular expressions in text and JS allows for it (at least
> so far).  The compiler already has options to skip linking certain
> classes.  That syntax can be extended to skip or modify some of the JS for
> a class.  Also, the GoogDepsWriter reads just about every file already so
> doing more automated text manipulation is also "easy".
>
> Also note that code-flow-analysis is also possible and may allow us to
> automatically/intelligently modify/remove code someday, so some of these
> options may be interim solutions.  For example, it might be possible to
> know which classes are being passed into Reflection and thus toss the
> reflection data from all of the other classes.
>
> I haven't tried this, but I've also considered that instead of compile
> options that you can link in alternate SWCs with alternate code, or that
> will overwrite the prototype at runtime to alter how things behave.
>
> Also, regarding public vars specifically, it may be that we use metadata
> to generate different code for vars.  We already do that with [Bindable].
>  It may be that if a class isn't a UI class and has [ClassAlias] or
> implements IExternalizable that we convert all vars to getter/setter (or do
> something else to prevent renaming) and that will the right default.  Or
> invent some new metadata to signal different var output.
>
> In summary, large bucket options can be confusing, granular options can be
> painful, but we might be able to use code-flow or other hints and get it
> right more often than we do now.
>
> My 2 cents,
> -Alex
>
>
>
> On 9/18/19, 9:45 AM, "Greg Dove"  wrote:
>
> I think it could be as simple as having something like a class (eg.
> JSBuild) with a bunch of static goog @defines. These could be used to
> delimit sections of output that provide things like reflection, default
> initialized, vector runtime checking etc. In a sense it is not much
> different to how you might think of as3 compile flag stuff. But perhaps
> there are ways to use some bitwise flag sets that evaluate to compile
> time
> constants (for GCC) to achieve some of the granular/selective content
> discrimination like I described with the hypothetical reflection
> optimization example. E.g framework vs non-framework/ UI vs. non-UI. I
> realise that all sounds complicated, which is why simple combos would
> be
> good for most people as Harbs mentioned.
>
> On Thu, 19 Sep 2019, 02:15 Harbs,  wrote:
>
> > Absolutely. Now we just need to figure out how… ;-)
> >
> > > On Sep 18, 2019, at 5:10 PM, Josh Tynjala <
> joshtynj...@bowlerhat.dev>
> > wrote:
> > >
> > >> I think the main thing we are 

Build failed in Jenkins: royale-asjs_MXTests #1164

[Apache Royale CI Server]

See 


Changes:

[joshtynjala] RoyaleUnit: tests for BeforeClass and AfterClass scope

[joshtynjala] RoyaleUnit: started implementing MetadataRunner architecture 
change to

--
[...truncated 133.97 KB...]
 [echo] Cross-compiling BindingJS.swc
 [echo] ROYALE_COMPILER_HOME: 

[mkdir] Created dir: 

 [java] args:
 [java] 
+royalelib=
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=09/18/19 18:51 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] Loading configuration: 

 [java] 
 [java] 28227 bytes written to 
C:\jenkins\workspace\royale-asjs_MXTests\frameworks\js\projects\BindingJS\target\BindingJS.swc
 in 1.773 seconds
 [java] COMPCJSCRoyale
 [java] 3.7855187 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 
 [copy] Copying 1 file to 


main:

copy-swc:
 [copy] Copying 1 file to 


check-for-tests:

test:

main:

Reflection:
 [echo] swc-date is 09/18/19 18:51 +

clean:
 [echo] swc-date is 09/18/19 18:51 +

check-for-tests:

clean-tests:

clean:

check-compiler-home:

check-transpiler-home:

check-compiler:

compile:
 [echo] Compiling libs/Reflection.swc
 [echo] ROYALE_HOME: 

 [echo] ROYALE_SWF_COMPILER_HOME: 

 [echo] ROYALE_COMPILER_HOME: 

 [java] args:
 [java] 
+royalelib=
 [java] +playerglobal.version=11.7
 [java] +env.AIR_HOME=C:\adobe\air\4.0\AdobeAIRSDK
 [java] -compiler.strict-xml=true
 [java] -compiler.targets=SWF,JSRoyale
 [java] -metadata.date=09/18/19 18:51 +
 [java] -metadata.dateFormat=MM/dd/yy HH:mm Z
 [java] -swf-debugfile-alias=/org/apache/royale/0.9.6
 [java] 
-output=
 [java] 
-load-config=
 [java] 
-js-load-config=
 [java] 
-js-load-config+=
 [java] target:SWF
 [java] target:JSRoyale
 [java] COMPC
 [java] Loading configuration: 

 [java] 
 [java] 32302 bytes written to 
C:\jenkins\workspace\royale-asjs_MXTests\frameworks\projects\Reflection\target\Reflection.swc
 in 2.031 seconds
 [java] COMPCJSCRoyale
 [java] 4.2530448 seconds
 [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 -Xms384m -Xmx1g 

compile-js:
 [echo] swc-date is 09/18/19 18:51 +
   [delete] Deleting: 

Jenkins build is back to normal : royale-asjs_jsonly #3560

[Apache Royale CI Server]

See 

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Alex Harui]

I probably won't object to folks trying out different config options, but the 3 
buckets Harbs proposed didn't make any sense to me.  I would want to turn them 
all on, and not be sure what the trade-offs are.

IMO, modifying the JS from SWCs after compilation is "easy" in the sense that 
it is all regular expressions in text and JS allows for it (at least so far).  
The compiler already has options to skip linking certain classes.  That syntax 
can be extended to skip or modify some of the JS for a class.  Also, the 
GoogDepsWriter reads just about every file already so doing more automated text 
manipulation is also "easy".

Also note that code-flow-analysis is also possible and may allow us to 
automatically/intelligently modify/remove code someday, so some of these 
options may be interim solutions.  For example, it might be possible to know 
which classes are being passed into Reflection and thus toss the reflection 
data from all of the other classes.

I haven't tried this, but I've also considered that instead of compile options 
that you can link in alternate SWCs with alternate code, or that will overwrite 
the prototype at runtime to alter how things behave.

Also, regarding public vars specifically, it may be that we use metadata to 
generate different code for vars.  We already do that with [Bindable].   It may 
be that if a class isn't a UI class and has [ClassAlias] or implements 
IExternalizable that we convert all vars to getter/setter (or do something else 
to prevent renaming) and that will the right default.  Or invent some new 
metadata to signal different var output.

In summary, large bucket options can be confusing, granular options can be 
painful, but we might be able to use code-flow or other hints and get it right 
more often than we do now.

My 2 cents,
-Alex



On 9/18/19, 9:45 AM, "Greg Dove"  wrote:

I think it could be as simple as having something like a class (eg.
JSBuild) with a bunch of static goog @defines. These could be used to
delimit sections of output that provide things like reflection, default
initialized, vector runtime checking etc. In a sense it is not much
different to how you might think of as3 compile flag stuff. But perhaps
there are ways to use some bitwise flag sets that evaluate to compile time
constants (for GCC) to achieve some of the granular/selective content
discrimination like I described with the hypothetical reflection
optimization example. E.g framework vs non-framework/ UI vs. non-UI. I
realise that all sounds complicated, which is why simple combos would be
good for most people as Harbs mentioned.

On Thu, 19 Sep 2019, 02:15 Harbs,  wrote:

> Absolutely. Now we just need to figure out how… ;-)
>
> > On Sep 18, 2019, at 5:10 PM, Josh Tynjala 
> wrote:
> >
> >> I think the main thing we are missing (from my perspective) is to avoid
> > the need to recompile the swcs to swap things in and out.
> >
> > I think that being able to switch things off and on without recompiling
> > SWCs would be awesome. Without that control, we will continue to 
struggle
> > with differing opinions on how it should work.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 

> >
> >
> > On Wed, Sep 18, 2019 at 12:31 AM Greg Dove  wrote:
> >
> >> I agree 100% Harbs. And I think that is not difficult to achieve.
> >>
> >> The decisions and collaborative effort need to take place in the
> planning
> >> side of things to figure out the reasonable set of granular things to
> >> support. Perhaps we can do that once the 'dust has settled' after 0.9.6
> is
> >> out. Then your 3 sets (or whatever is decided to be the menu) could
> simply
> >> be defined as a collection of settings for those, with people free to
> tune
> >> things at a more granular level if they wanted.
> >> I might want to, for example, be able to strip out reflection data from
> UI
> >> based Framework classes but keep it for all other framework stuff, and
> all
> >> my own custom UI components, (perhaps that sounds weird, but I can
> think of
> >> this as being useful in a real-world scenario with Crux). Whether that
> >> level or control is reasonable for us to support is probably
> questionable.
> >> But I think it is *possible*. This is the same type of granular
> switching I
> >> was trying to explain for switching off Vector runtime checking in
> recent
> >> months, but I did not get a sense that anyone clearly understood what I
> was
> >> trying to convey at the time (my impression only).

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Greg Dove]

I think it could be as simple as having something like a class (eg.
JSBuild) with a bunch of static goog @defines. These could be used to
delimit sections of output that provide things like reflection, default
initialized, vector runtime checking etc. In a sense it is not much
different to how you might think of as3 compile flag stuff. But perhaps
there are ways to use some bitwise flag sets that evaluate to compile time
constants (for GCC) to achieve some of the granular/selective content
discrimination like I described with the hypothetical reflection
optimization example. E.g framework vs non-framework/ UI vs. non-UI. I
realise that all sounds complicated, which is why simple combos would be
good for most people as Harbs mentioned.

On Thu, 19 Sep 2019, 02:15 Harbs,  wrote:

> Absolutely. Now we just need to figure out how… ;-)
>
> > On Sep 18, 2019, at 5:10 PM, Josh Tynjala 
> wrote:
> >
> >> I think the main thing we are missing (from my perspective) is to avoid
> > the need to recompile the swcs to swap things in and out.
> >
> > I think that being able to switch things off and on without recompiling
> > SWCs would be awesome. Without that control, we will continue to struggle
> > with differing opinions on how it should work.
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 
> >
> >
> > On Wed, Sep 18, 2019 at 12:31 AM Greg Dove  wrote:
> >
> >> I agree 100% Harbs. And I think that is not difficult to achieve.
> >>
> >> The decisions and collaborative effort need to take place in the
> planning
> >> side of things to figure out the reasonable set of granular things to
> >> support. Perhaps we can do that once the 'dust has settled' after 0.9.6
> is
> >> out. Then your 3 sets (or whatever is decided to be the menu) could
> simply
> >> be defined as a collection of settings for those, with people free to
> tune
> >> things at a more granular level if they wanted.
> >> I might want to, for example, be able to strip out reflection data from
> UI
> >> based Framework classes but keep it for all other framework stuff, and
> all
> >> my own custom UI components, (perhaps that sounds weird, but I can
> think of
> >> this as being useful in a real-world scenario with Crux). Whether that
> >> level or control is reasonable for us to support is probably
> questionable.
> >> But I think it is *possible*. This is the same type of granular
> switching I
> >> was trying to explain for switching off Vector runtime checking in
> recent
> >> months, but I did not get a sense that anyone clearly understood what I
> was
> >> trying to convey at the time (my impression only).
> >>
> >> I think the main thing we are missing (from my perspective) is to avoid
> the
> >> need to recompile the swcs to swap things in and out.
> >> Anyway, I will stop talking about this, I just wanted to highlight the
> fact
> >> that I believe we can technically meet most people's needs, whatever
> they
> >> are, but that I also think the general need is best served by matching
> as3
> >> behavior by default, as Josh has proposed for public vars.
> >>
> >>
> >>
> >> On Tue, Sep 17, 2019 at 10:28 PM Harbs  wrote:
> >>
> >>> Rather than having to specify a whole slew of compiler options, I’d
> like
> >>> to see 2 or 3 compiler configurations that would set the defaults on a
> >>> group of options to get the best default behavior for a use case.
> >>> Maybe something like this:
> >>>
> >>> js-config=compatible (for maximum, compatibility with Flash behavior)
> >>> js-config=optimized (for minimum code size)
> >>> js-config=safe (for best type safety but not necessarily Flash
> >> compatible)
> >>>
> >>> Obviously, you could override the defaults on any one of these, but I
> >> hope
> >>> we could give predefined sets of defaults which cover the vast majority
> >> of
> >>> use cases out of the box.
> >>>
> >>> It’s hard learning all the compiler options, but being able to specify
> a
> >>> few sets of defaults seems reasonable.
> >>>
> >>> Harbs
> >>>
>  On Sep 17, 2019, at 11:02 AM, Greg Dove  wrote:
> 
>  I personally would use a non-default setting to keep things as they
> are
>  right now, but I agree with Josh in that as it is, I don't think it's
> a
>  good hurdle to present to new users, or people in general that simply
> >>> want
>  things to 'work' out of the box, based on what they should reasonably
>  expect to work. The language layer is the foundation for building
>  everything else. People have serious doubts when things don't work
> >> right
> >>> at
>  that level. I have had to reassure people about this recently (XML -
> >>> still
>  working on it - soon!).
> 
>  We have only touched the surface of what we could do with GCC for
> >> tuning
>  the output. There are ways to have all the default stuff in there but
>  selectively remove it from release builds without having to recompile
>  library code, for example. So I think it is possible that we 

Re: Release vote/discuss reply-to address

[Carlos Rovira]

Hi Josh,

yes, Piotr and I talk a bit about gmail doing strange things. I finally
could send messages to DISCUSS and to VOTE thread. But maybe the problem is
the configuration done in the process. Maybe is just a matter of make a
send to dev list and separate the two sendings, and remove that "
apacheroyal...@gmail.com" account since seems is not necessary.

El mar., 17 sept. 2019 a las 22:54, Josh Tynjala ()
escribió:

> Hmm... looking at the headers in Gmail seems to indicate that reply-to is
> actually set to the dev list. I wonder why Gmail is ignoring it...
>
> One thing that I see is that reply-to is showing up in the UI like this:
>
> reply-to: dev@royale.apache.org, dev@royale.apache.org
>
> Maybe Gmail is getting confused because it is set twice.
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Tue, Sep 17, 2019 at 1:42 PM Josh Tynjala 
> wrote:
>
> > I just realized that several replies that I sent to the 0.9.6 discuss
> > thread were lost because I was unexpectedly replying to
> > apacheroyal...@gmail.com.
> >
> > When the server sends out vote/discuss threads, is it possible to set the
> > reply-to address to dev@royale.apache.org?
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 
> >
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Re: [DISCUSS] Release Apache Royale 0.9.6 RC1

[Josh Tynjala]

Maven with -X:

https://paste.apache.org/ffq08

--
Josh Tynjala
Bowler Hat LLC 


On Wed, Sep 18, 2019 at 8:44 AM Piotr Zarzycki 
wrote:

> Thanks Josh. In logs there isn't any url from which you are downloading
> artifacts. It means probably you are using cached one. One option is to
> remove cached artifacts and run build, the second is run build with -X.
> It doesn't have to be full build - it's the matter of see what actually
> maven do.
>
> śr., 18 wrz 2019 o 16:40 Josh Tynjala 
> napisał(a):
>
> > Here's the console output from the Maven section of the build:
> >
> > https://paste.apache.org/cczye
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 
> >
> >
> > On Tue, Sep 17, 2019 at 10:20 PM Alex Harui 
> > wrote:
> >
> > > I assume that wasn't the whole log.  I think we want to see the part
> > where
> > > it builds Core, we only see the last bit of Core.  Core looks like it
> > > thought it was in js-only config and didn't build a swf swc and/or
> > Binding
> > > thinks it is building swf swcs and is looking for Core's swf swc.
> > >
> > > FWIW, I am having a bunch of other build issues related to js-only for
> > Ant
> > > for the ASDoc example.  It worked in the past because I still had
> > > PLAYERGLOBAL_HOME set in the environment, but when I took that away a
> > bunch
> > > of new things cropped up.  Could be a  day or two of work.  We could
> > still
> > > approve the release and folks who want js-only will have to not build
> > ASDoc.
> > >
> > > -Alex
> > >
> > > On 9/17/19, 8:59 PM, "Piotr Zarzycki" 
> > wrote:
> > >
> > > Hi Josh,
> > >
> > > Do you have in your Maven config setup link to Maven artifacts?
> Cause
> > > error
> > > is saying that it was attempt of downloading them from Snapshot.
> > > However
> > > Core build successfully, so I'm a bit confused.
> > >
> > > Thanks,
> > > Piotr
> > >
> > > On Tue, Sep 17, 2019, 11:47 PM Josh Tynjala <
> > joshtynj...@bowlerhat.dev
> > > >
> > > wrote:
> > >
> > > > Unfortunately, I'm seeing that the Maven part of ApproveRoyale is
> > > failing
> > > > too. Here's the end of my console output:
> > > >
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2F83mivdata=02%7C01%7Caharui%40adobe.com%7C5418ae5d4cb94b454ab208d73beca2c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043759850631985sdata=j%2FYDlKQ7Tx54p2PJfg2tEoGg2I5Mi19BMB5fFcZcKy4%3Dreserved=0
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC <
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.devdata=02%7C01%7Caharui%40adobe.com%7C5418ae5d4cb94b454ab208d73beca2c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043759850631985sdata=%2BTdmGXZr5uiQaJ36dU8QeOQLGIpR8adX5ktk8%2FRo8ME%3Dreserved=0
> > > >
> > > >
> > > >
> > > > On Tue, Sep 17, 2019 at 2:22 PM Josh Tynjala <
> > > joshtynj...@bowlerhat.dev>
> > > > wrote:
> > > >
> > > > > Getting the following error when running the ApproveRoyale ant
> > > script...
> > > > >
> > > > > Error: unable to open
> > > > >
> > > >
> > >
> >
> '/Users/joshtynjala/Desktop/royale/apache-royale-0.9.6-src/royale-asjs/examples/royale/CreditCardValidatorExample/src/main/royale/App.mxml'.
> > > > >
> > > > > Seems to be caused by this line in build.xml from
> > > > > CreditCardValidatorExample:
> > > > >
> > > > > 
> > > > >
> > > > > There is no App.mxml, but there is a
> > > CreditCardValidatorExample.mxml, so
> > > > I
> > > > > think that the value is supposed to be
> > "CreditCardValidatorExample"
> > > > instead:
> > > > >
> > > > > 
> > > > >
> > > > > I just pushed a commit to develop to fix that for the next
> > release.
> > > > >
> > > > > I will locally adjust ApproveRoyale to skip the examples and
> > > finish the
> > > > > rest of the approval process. Assuming that everything else
> > > completes
> > > > > successfully, a broken example build script is not enough to
> > > prevent me
> > > > > from approving this release candidate.
> > > > >
> > > > > --
> > > > > Josh Tynjala
> > > > > Bowler Hat LLC <
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.devdata=02%7C01%7Caharui%40adobe.com%7C5418ae5d4cb94b454ab208d73beca2c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043759850631985sdata=%2BTdmGXZr5uiQaJ36dU8QeOQLGIpR8adX5ktk8%2FRo8ME%3Dreserved=0
> > > >
> > > > >
> > > > >
> > > > > On Tue, Sep 17, 2019 at 6:43 AM Apache Royale CI Server <
> > > > > apacheroyal...@gmail.com> wrote:
> > > > >
> > > > >> This is the discussion thread.
> > > > >>
> > > > >> Thanks,
> > > > >> Piotr
> > > > >
> > > > >
> > > >
> > >
> > >
> > >
> >
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> 

Re: [DISCUSS] Release Apache Royale 0.9.6 RC1

[Piotr Zarzycki]

Thanks Josh. In logs there isn't any url from which you are downloading
artifacts. It means probably you are using cached one. One option is to
remove cached artifacts and run build, the second is run build with -X.
It doesn't have to be full build - it's the matter of see what actually
maven do.

śr., 18 wrz 2019 o 16:40 Josh Tynjala 
napisał(a):

> Here's the console output from the Maven section of the build:
>
> https://paste.apache.org/cczye
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Tue, Sep 17, 2019 at 10:20 PM Alex Harui 
> wrote:
>
> > I assume that wasn't the whole log.  I think we want to see the part
> where
> > it builds Core, we only see the last bit of Core.  Core looks like it
> > thought it was in js-only config and didn't build a swf swc and/or
> Binding
> > thinks it is building swf swcs and is looking for Core's swf swc.
> >
> > FWIW, I am having a bunch of other build issues related to js-only for
> Ant
> > for the ASDoc example.  It worked in the past because I still had
> > PLAYERGLOBAL_HOME set in the environment, but when I took that away a
> bunch
> > of new things cropped up.  Could be a  day or two of work.  We could
> still
> > approve the release and folks who want js-only will have to not build
> ASDoc.
> >
> > -Alex
> >
> > On 9/17/19, 8:59 PM, "Piotr Zarzycki" 
> wrote:
> >
> > Hi Josh,
> >
> > Do you have in your Maven config setup link to Maven artifacts? Cause
> > error
> > is saying that it was attempt of downloading them from Snapshot.
> > However
> > Core build successfully, so I'm a bit confused.
> >
> > Thanks,
> > Piotr
> >
> > On Tue, Sep 17, 2019, 11:47 PM Josh Tynjala <
> joshtynj...@bowlerhat.dev
> > >
> > wrote:
> >
> > > Unfortunately, I'm seeing that the Maven part of ApproveRoyale is
> > failing
> > > too. Here's the end of my console output:
> > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2F83mivdata=02%7C01%7Caharui%40adobe.com%7C5418ae5d4cb94b454ab208d73beca2c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043759850631985sdata=j%2FYDlKQ7Tx54p2PJfg2tEoGg2I5Mi19BMB5fFcZcKy4%3Dreserved=0
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC <
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.devdata=02%7C01%7Caharui%40adobe.com%7C5418ae5d4cb94b454ab208d73beca2c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043759850631985sdata=%2BTdmGXZr5uiQaJ36dU8QeOQLGIpR8adX5ktk8%2FRo8ME%3Dreserved=0
> > >
> > >
> > >
> > > On Tue, Sep 17, 2019 at 2:22 PM Josh Tynjala <
> > joshtynj...@bowlerhat.dev>
> > > wrote:
> > >
> > > > Getting the following error when running the ApproveRoyale ant
> > script...
> > > >
> > > > Error: unable to open
> > > >
> > >
> >
> '/Users/joshtynjala/Desktop/royale/apache-royale-0.9.6-src/royale-asjs/examples/royale/CreditCardValidatorExample/src/main/royale/App.mxml'.
> > > >
> > > > Seems to be caused by this line in build.xml from
> > > > CreditCardValidatorExample:
> > > >
> > > > 
> > > >
> > > > There is no App.mxml, but there is a
> > CreditCardValidatorExample.mxml, so
> > > I
> > > > think that the value is supposed to be
> "CreditCardValidatorExample"
> > > instead:
> > > >
> > > > 
> > > >
> > > > I just pushed a commit to develop to fix that for the next
> release.
> > > >
> > > > I will locally adjust ApproveRoyale to skip the examples and
> > finish the
> > > > rest of the approval process. Assuming that everything else
> > completes
> > > > successfully, a broken example build script is not enough to
> > prevent me
> > > > from approving this release candidate.
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC <
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.devdata=02%7C01%7Caharui%40adobe.com%7C5418ae5d4cb94b454ab208d73beca2c4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043759850631985sdata=%2BTdmGXZr5uiQaJ36dU8QeOQLGIpR8adX5ktk8%2FRo8ME%3Dreserved=0
> > >
> > > >
> > > >
> > > > On Tue, Sep 17, 2019 at 6:43 AM Apache Royale CI Server <
> > > > apacheroyal...@gmail.com> wrote:
> > > >
> > > >> This is the discussion thread.
> > > >>
> > > >> Thanks,
> > > >> Piotr
> > > >
> > > >
> > >
> >
> >
> >
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

Release Step 013 Succeeded

[Apache Royale CI Server]

>From the royale-asjs repo
1. Run ant -f releasesteps.xml Release_Step_013 -Drelease.version=0.9.6 
-Droyale.swc-date="9/18/19 9:06 -0800" -Dplayerglobal.version=11.7 
-Dflat.donot.ask=true -Drc=2 -DskipTests=true
This will download the artifacts then unzip and compile the source artifact.
2. Validate that the compiled artifacts match the downloaded artifacts.
3. If they do, then run ant -f releasesteps.xml Release_Step_013_Sign 
-Drelease.version=0.9.6
This will PGP sign the source and convenience binary packages
4. Then run ant -f releasesteps.xml Release_Step_013_Upload 
-Drelease.version=0.9.6 -Drc=2
This will upload the signed artifacts to dist.apache.org.

Release Step 012 Succeeded

[Apache Royale CI Server]

Folder 0.9.6 already exists.  Continue to next step

Re: Discuss of release steps preparation

[Alex Harui]

Because it means it is possible that the wrong version got into 
build.properties.

-Alex

On 9/17/19, 11:20 AM, "Piotr Zarzycki"  wrote:

Alex,

I will fix those issues once we make current release. Both of them are not
a blockers in my opinion.

How issue in release steps script can influence sources ?

Thanks,
Piotr


On Tue, Sep 17, 2019, 7:29 PM Alex Harui  wrote:

> If you had to do that, how do you know the RC is still valid?  Sounds like
> there is a version number that isn't right in the source package.  One
> reason to have scripts is to detect things that are not right.  Yes there
> might be bugs in the scripts, but if you didn't have to do this before, it
> should imply that something changes in the source package.
>
> Please fix issues like the signing of RoyaleUnit.  Otherwise, who's job is
> it to fix it?  I could, but then we're back to the same problem of nobody
> else knowing how to fix the scripts.
>
> -Alex
>
> On 9/17/19, 3:58 AM, "Piotr Zarzycki"  wrote:
>
> Another small issue which I discovered is that I had to specify in 
Step
> 13 -Drelease.version=0.9.6 -Dreleaseversion=0.9.6 - With dot and
> without
> dot, cause script failed on compiler cloning.
>
> Thanks,
> Piotr
>
> wt., 17 wrz 2019 o 10:47 Piotr Zarzycki 
> napisał(a):
>
> > Hi Guys,
> >
> > I'm in a process of uploading Maven artifacts and after upload I got
> > following problem [1]. I will sign those artifacts manually, but
> this is
> > something what should be fixed in the script for the next release.
> >
> > [1]
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fibb.co%2Fzh0r5nndata=02%7C01%7Caharui%40adobe.com%7C96aeb34e43f6444c115e08d73b9bb69a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043412327312711sdata=KZBSiLSu4DJ%2B4yaF4WQ741ONuNLWCkvtxf3L%2BD6oH9s%3Dreserved=0
> >
> > Thanks,
> > Piotr
> >
> > niedz., 15 wrz 2019 o 08:18 Alex Harui 
> > napisał(a):
> >
> >> Glad you are getting back to normal.  Please review what is in the
> >> release branch before the RC so we can fix things before Piotr
> spends a lot
> >> of time creating the RC.
> >>
> >>
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Frelease%2F0.9.6%2FRELEASE_NOTES.mddata=02%7C01%7Caharui%40adobe.com%7C96aeb34e43f6444c115e08d73b9bb69a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043412327312711sdata=lojSY1ZAF5g9RasDMbC3QsEmJaDd%2F7FqOktwD65%2BO1U%3Dreserved=0
> >>
> >>
> 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fblob%2Frelease%2F0.9.6%2Freleasemgr%2FRELEASE_NOTESdata=02%7C01%7Caharui%40adobe.com%7C96aeb34e43f6444c115e08d73b9bb69a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043412327322700sdata=ZAzrNMNMRojJz39DLXM9zLTTz4JxSlAl028fQTmlCGo%3Dreserved=0
> >>
> >> Because of the way we package, the releasemgr/RELEASE_NOTES is the
> >> top-level release notes in the source package because the package
> contains
> >> all 3 repos and the releasemgr files are copied to the top.  The
> .MD file
> >> is for GitHub visitors to the repo.
> >>
> >> Thanks,
> >> -Alex
> >>
> >> On 9/14/19, 11:06 AM, "Andrew Wetmore"  wrote:
> >>
> >> We have power and internet again, at last. I guess I should
> wait to
> >> review
> >> texts until the next version of the release candidate.
> >>
> >> On Sat, Sep 14, 2019 at 3:01 PM Piotr Zarzycki <
> >> piotrzarzyck...@gmail.com>
> >> wrote:
> >>
> >> > Hi Carlos,
> >> >
> >> > I see you did commit to 0.9.6 branch, so we are good unless
> there is
> >> > something left in develop which should I pick. I will review
> all of
> >> that on
> >> > Monday.
> >> >
> >> > Thanks,
> >> > Piotr
> >> >
> >> > On Sat, Sep 14, 2019, 5:26 PM Carlos Rovira <
> >> carlosrov...@apache.org>
> >> > wrote:
> >> >
> >> > > Hi Piotr,
> >> > >
> >> > > seems there was a little confusion here and Greg and I did
> the
> >> changes in
> >> > > the release version of RELEASE_NOTES.
> >> > > Hope you can merge both in your process. I followed my
> changes
> >> since
> >> > > December to try to bring all relevant things done.
> >> > > Thanks
> >> > >
> >> > > El sáb., 14 sept. 

Re: [DISCUSS] Release Apache Royale 0.9.6 RC1

[Piotr Zarzycki]

Hi Josh,

The question is how Maven know if won't setup in settings link to staging
to use proper version of compiler and sdk. How Maven taking from staging
artefacts if you won't tell to him?

I have tried build sources using in settings [1] - I didn't try without it.

[1] https://paste.apache.org/q8zfn

Thanks,
Piotr

śr., 18 wrz 2019 o 16:14 Josh Tynjala 
napisał(a):

> I don't know enough about Maven to answer your question, Piotr. All I can
> say is that I have successfully run the ApproveRoyale script for previous
> releases, and I don't think that I have changed any kind of global Maven
> settings on this machine since then.
>
> I can run it again and share the entire log, if that will help anyone,
> though.
>
> --
> Josh Tynjala
> Bowler Hat LLC 
>
>
> On Tue, Sep 17, 2019 at 8:59 PM Piotr Zarzycki 
> wrote:
>
> > Hi Josh,
> >
> > Do you have in your Maven config setup link to Maven artifacts? Cause
> error
> > is saying that it was attempt of downloading them from Snapshot. However
> > Core build successfully, so I'm a bit confused.
> >
> > Thanks,
> > Piotr
> >
> > On Tue, Sep 17, 2019, 11:47 PM Josh Tynjala 
> > wrote:
> >
> > > Unfortunately, I'm seeing that the Maven part of ApproveRoyale is
> failing
> > > too. Here's the end of my console output:
> > >
> > > https://paste.apache.org/83miv
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC 
> > >
> > >
> > > On Tue, Sep 17, 2019 at 2:22 PM Josh Tynjala <
> joshtynj...@bowlerhat.dev>
> > > wrote:
> > >
> > > > Getting the following error when running the ApproveRoyale ant
> > script...
> > > >
> > > > Error: unable to open
> > > >
> > >
> >
> '/Users/joshtynjala/Desktop/royale/apache-royale-0.9.6-src/royale-asjs/examples/royale/CreditCardValidatorExample/src/main/royale/App.mxml'.
> > > >
> > > > Seems to be caused by this line in build.xml from
> > > > CreditCardValidatorExample:
> > > >
> > > > 
> > > >
> > > > There is no App.mxml, but there is a CreditCardValidatorExample.mxml,
> > so
> > > I
> > > > think that the value is supposed to be "CreditCardValidatorExample"
> > > instead:
> > > >
> > > > 
> > > >
> > > > I just pushed a commit to develop to fix that for the next release.
> > > >
> > > > I will locally adjust ApproveRoyale to skip the examples and finish
> the
> > > > rest of the approval process. Assuming that everything else completes
> > > > successfully, a broken example build script is not enough to prevent
> me
> > > > from approving this release candidate.
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC 
> > > >
> > > >
> > > > On Tue, Sep 17, 2019 at 6:43 AM Apache Royale CI Server <
> > > > apacheroyal...@gmail.com> wrote:
> > > >
> > > >> This is the discussion thread.
> > > >>
> > > >> Thanks,
> > > >> Piotr
> > > >
> > > >
> > >
> >
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*

Re: [royale-asjs] branch release/0.9.6 updated: Fix releasessteps script

[Alex Harui]

Changing releaseversion to release.version should not be necessary and might 
break something else.  Can you reproduce the failure?  What is the console log? 
 How did it not pick up the releaseversion from build.properties?

-Alex

On 9/17/19, 10:53 PM, "pio...@apache.org"  wrote:

This is an automated email from the ASF dual-hosted git repository.

piotrz pushed a commit to branch release/0.9.6
in repository 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.gitdata=02%7C01%7Caharui%40adobe.com%7C780e787968ef41434f6708d73bfc78e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043827860542212sdata=qQC5eeDfhB2Rz%2BdGfyJohLsFJuz%2BdkFCb8WPcrwW5PI%3Dreserved=0


The following commit(s) were added to refs/heads/release/0.9.6 by this push:
 new 84c2e85  Fix releasessteps script
84c2e85 is described below

commit 84c2e855c5a316ad21ff3a8ac6ac0cde826eecf0
Author: Piotr Zarzycki 
AuthorDate: Wed Sep 18 07:47:03 2019 +0200

Fix releasessteps script

- Add RoyaleUnit to swcs list and sign target
- Fix property release.version
---
 releasesteps.xml | 43 +++
 1 file changed, 23 insertions(+), 20 deletions(-)

diff --git a/releasesteps.xml b/releasesteps.xml
index 01d0061..5c3edf1 100644
--- a/releasesteps.xml
+++ b/releasesteps.xml
@@ -219,7 +219,7 @@
 
 
-
+
 
 
 
@@ -501,6 +501,9 @@
 
 
 
+   
+
+
 
 
 
@@ -880,7 +883,7 @@
 
 
 
-
+
 
 
 
@@ -891,21 +894,21 @@
 
 
 
-
+
 https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-compiler.gitdata=02%7C01%7Caharui%40adobe.com%7C780e787968ef41434f6708d73bfc78e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043827860542212sdata=Qvy8HglyeoGWo6fV45tu7%2FBURYBHpRgWnx%2F4Mk33ZCo%3Dreserved=0;
 />
 
 
 
 
 
-
+
 https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-typedefs.gitdata=02%7C01%7Caharui%40adobe.com%7C780e787968ef41434f6708d73bfc78e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043827860542212sdata=8jWPOp%2FH%2FKQr9u4ynBRMnXklSST2yaqUCTazqrc7vlA%3Dreserved=0;
 />
 
 
 
 
 
-
+
 https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs.gitdata=02%7C01%7Caharui%40adobe.com%7C780e787968ef41434f6708d73bfc78e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637043827860542212sdata=ZqgQ7OSyVeZ4kP84bS16LwO93mWJbv%2Fh22VOsJImUfA%3Dreserved=0;
 />
 
 
@@ -916,7 +919,7 @@
 
 
 
-
+
 
 
 
@@ -948,14 +951,14 @@
 
 
 
-releaseversion: ${releaseversion}
+release.version: ${release.version}
 copy src-zip file to a separate folder
 
-
+
 
-
+
 running reproducible build plugin on 
${artifactfolder}/artifacts/srczip
 
 
@@ -967,10 +970,10 @@
 
 
 
-
+
 
-
+
 
 
 
@@ -980,16 +983,16 @@
 
 
 
-
-
+
+
 
 
-
-
+
+
 
 
-
-
+
+
 
 
 

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Harbs]

Absolutely. Now we just need to figure out how… ;-)

> On Sep 18, 2019, at 5:10 PM, Josh Tynjala  wrote:
> 
>> I think the main thing we are missing (from my perspective) is to avoid
> the need to recompile the swcs to swap things in and out.
> 
> I think that being able to switch things off and on without recompiling
> SWCs would be awesome. Without that control, we will continue to struggle
> with differing opinions on how it should work.
> 
> --
> Josh Tynjala
> Bowler Hat LLC 
> 
> 
> On Wed, Sep 18, 2019 at 12:31 AM Greg Dove  wrote:
> 
>> I agree 100% Harbs. And I think that is not difficult to achieve.
>> 
>> The decisions and collaborative effort need to take place in the planning
>> side of things to figure out the reasonable set of granular things to
>> support. Perhaps we can do that once the 'dust has settled' after 0.9.6 is
>> out. Then your 3 sets (or whatever is decided to be the menu) could simply
>> be defined as a collection of settings for those, with people free to tune
>> things at a more granular level if they wanted.
>> I might want to, for example, be able to strip out reflection data from UI
>> based Framework classes but keep it for all other framework stuff, and all
>> my own custom UI components, (perhaps that sounds weird, but I can think of
>> this as being useful in a real-world scenario with Crux). Whether that
>> level or control is reasonable for us to support is probably questionable.
>> But I think it is *possible*. This is the same type of granular switching I
>> was trying to explain for switching off Vector runtime checking in recent
>> months, but I did not get a sense that anyone clearly understood what I was
>> trying to convey at the time (my impression only).
>> 
>> I think the main thing we are missing (from my perspective) is to avoid the
>> need to recompile the swcs to swap things in and out.
>> Anyway, I will stop talking about this, I just wanted to highlight the fact
>> that I believe we can technically meet most people's needs, whatever they
>> are, but that I also think the general need is best served by matching as3
>> behavior by default, as Josh has proposed for public vars.
>> 
>> 
>> 
>> On Tue, Sep 17, 2019 at 10:28 PM Harbs  wrote:
>> 
>>> Rather than having to specify a whole slew of compiler options, I’d like
>>> to see 2 or 3 compiler configurations that would set the defaults on a
>>> group of options to get the best default behavior for a use case.
>>> Maybe something like this:
>>> 
>>> js-config=compatible (for maximum, compatibility with Flash behavior)
>>> js-config=optimized (for minimum code size)
>>> js-config=safe (for best type safety but not necessarily Flash
>> compatible)
>>> 
>>> Obviously, you could override the defaults on any one of these, but I
>> hope
>>> we could give predefined sets of defaults which cover the vast majority
>> of
>>> use cases out of the box.
>>> 
>>> It’s hard learning all the compiler options, but being able to specify a
>>> few sets of defaults seems reasonable.
>>> 
>>> Harbs
>>> 
 On Sep 17, 2019, at 11:02 AM, Greg Dove  wrote:
 
 I personally would use a non-default setting to keep things as they are
 right now, but I agree with Josh in that as it is, I don't think it's a
 good hurdle to present to new users, or people in general that simply
>>> want
 things to 'work' out of the box, based on what they should reasonably
 expect to work. The language layer is the foundation for building
 everything else. People have serious doubts when things don't work
>> right
>>> at
 that level. I have had to reassure people about this recently (XML -
>>> still
 working on it - soon!).
 
 We have only touched the surface of what we could do with GCC for
>> tuning
 the output. There are ways to have all the default stuff in there but
 selectively remove it from release builds without having to recompile
 library code, for example. So I think it is possible that we could
>>> provide
 flexible solutions that match whatever we consider people want.
 But in terms of defaults, is it not obvious that it we should be guided
>>> by
 actionscript 3 language itself and the reference implementation we
>>> already
 have? We can't always match things, but I think the onus is on us to
>> get
>>> as
 close as we can by default.
 
 
 On Tue, Sep 17, 2019 at 5:59 PM Alex Harui 
>>> wrote:
 
> Some folks want us to get smarter and not automatically export all
>>> public
> methods and getter/setters.  There are a lot of just-in-case strings
>> in
> Royale apps.  That's not good.  So better control over things even
>> after
> compiling without being painful to use is the goal.
> 
> My 2 cents,
> -Alex
> 
> On 9/16/19, 12:39 PM, "Josh Tynjala" 
>>> wrote:
> 
>   I was thinking about this some more, and is there anything else
>>> that's
>   public that also we allow to be 

Re: [DISCUSS] Release Apache Royale 0.9.6 RC1

[Josh Tynjala]

I don't know enough about Maven to answer your question, Piotr. All I can
say is that I have successfully run the ApproveRoyale script for previous
releases, and I don't think that I have changed any kind of global Maven
settings on this machine since then.

I can run it again and share the entire log, if that will help anyone,
though.

--
Josh Tynjala
Bowler Hat LLC 


On Tue, Sep 17, 2019 at 8:59 PM Piotr Zarzycki 
wrote:

> Hi Josh,
>
> Do you have in your Maven config setup link to Maven artifacts? Cause error
> is saying that it was attempt of downloading them from Snapshot. However
> Core build successfully, so I'm a bit confused.
>
> Thanks,
> Piotr
>
> On Tue, Sep 17, 2019, 11:47 PM Josh Tynjala 
> wrote:
>
> > Unfortunately, I'm seeing that the Maven part of ApproveRoyale is failing
> > too. Here's the end of my console output:
> >
> > https://paste.apache.org/83miv
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC 
> >
> >
> > On Tue, Sep 17, 2019 at 2:22 PM Josh Tynjala 
> > wrote:
> >
> > > Getting the following error when running the ApproveRoyale ant
> script...
> > >
> > > Error: unable to open
> > >
> >
> '/Users/joshtynjala/Desktop/royale/apache-royale-0.9.6-src/royale-asjs/examples/royale/CreditCardValidatorExample/src/main/royale/App.mxml'.
> > >
> > > Seems to be caused by this line in build.xml from
> > > CreditCardValidatorExample:
> > >
> > > 
> > >
> > > There is no App.mxml, but there is a CreditCardValidatorExample.mxml,
> so
> > I
> > > think that the value is supposed to be "CreditCardValidatorExample"
> > instead:
> > >
> > > 
> > >
> > > I just pushed a commit to develop to fix that for the next release.
> > >
> > > I will locally adjust ApproveRoyale to skip the examples and finish the
> > > rest of the approval process. Assuming that everything else completes
> > > successfully, a broken example build script is not enough to prevent me
> > > from approving this release candidate.
> > >
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC 
> > >
> > >
> > > On Tue, Sep 17, 2019 at 6:43 AM Apache Royale CI Server <
> > > apacheroyal...@gmail.com> wrote:
> > >
> > >> This is the discussion thread.
> > >>
> > >> Thanks,
> > >> Piotr
> > >
> > >
> >
>

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Josh Tynjala]

> I think the main thing we are missing (from my perspective) is to avoid
the need to recompile the swcs to swap things in and out.

I think that being able to switch things off and on without recompiling
SWCs would be awesome. Without that control, we will continue to struggle
with differing opinions on how it should work.

--
Josh Tynjala
Bowler Hat LLC 


On Wed, Sep 18, 2019 at 12:31 AM Greg Dove  wrote:

> I agree 100% Harbs. And I think that is not difficult to achieve.
>
> The decisions and collaborative effort need to take place in the planning
> side of things to figure out the reasonable set of granular things to
> support. Perhaps we can do that once the 'dust has settled' after 0.9.6 is
> out. Then your 3 sets (or whatever is decided to be the menu) could simply
> be defined as a collection of settings for those, with people free to tune
> things at a more granular level if they wanted.
> I might want to, for example, be able to strip out reflection data from UI
> based Framework classes but keep it for all other framework stuff, and all
> my own custom UI components, (perhaps that sounds weird, but I can think of
> this as being useful in a real-world scenario with Crux). Whether that
> level or control is reasonable for us to support is probably questionable.
> But I think it is *possible*. This is the same type of granular switching I
> was trying to explain for switching off Vector runtime checking in recent
> months, but I did not get a sense that anyone clearly understood what I was
> trying to convey at the time (my impression only).
>
> I think the main thing we are missing (from my perspective) is to avoid the
> need to recompile the swcs to swap things in and out.
> Anyway, I will stop talking about this, I just wanted to highlight the fact
> that I believe we can technically meet most people's needs, whatever they
> are, but that I also think the general need is best served by matching as3
> behavior by default, as Josh has proposed for public vars.
>
>
>
> On Tue, Sep 17, 2019 at 10:28 PM Harbs  wrote:
>
> > Rather than having to specify a whole slew of compiler options, I’d like
> > to see 2 or 3 compiler configurations that would set the defaults on a
> > group of options to get the best default behavior for a use case.
> > Maybe something like this:
> >
> > js-config=compatible (for maximum, compatibility with Flash behavior)
> > js-config=optimized (for minimum code size)
> > js-config=safe (for best type safety but not necessarily Flash
> compatible)
> >
> > Obviously, you could override the defaults on any one of these, but I
> hope
> > we could give predefined sets of defaults which cover the vast majority
> of
> > use cases out of the box.
> >
> > It’s hard learning all the compiler options, but being able to specify a
> > few sets of defaults seems reasonable.
> >
> > Harbs
> >
> > > On Sep 17, 2019, at 11:02 AM, Greg Dove  wrote:
> > >
> > > I personally would use a non-default setting to keep things as they are
> > > right now, but I agree with Josh in that as it is, I don't think it's a
> > > good hurdle to present to new users, or people in general that simply
> > want
> > > things to 'work' out of the box, based on what they should reasonably
> > > expect to work. The language layer is the foundation for building
> > > everything else. People have serious doubts when things don't work
> right
> > at
> > > that level. I have had to reassure people about this recently (XML -
> > still
> > > working on it - soon!).
> > >
> > > We have only touched the surface of what we could do with GCC for
> tuning
> > > the output. There are ways to have all the default stuff in there but
> > > selectively remove it from release builds without having to recompile
> > > library code, for example. So I think it is possible that we could
> > provide
> > > flexible solutions that match whatever we consider people want.
> > > But in terms of defaults, is it not obvious that it we should be guided
> > by
> > > actionscript 3 language itself and the reference implementation we
> > already
> > > have? We can't always match things, but I think the onus is on us to
> get
> > as
> > > close as we can by default.
> > >
> > >
> > > On Tue, Sep 17, 2019 at 5:59 PM Alex Harui 
> > wrote:
> > >
> > >> Some folks want us to get smarter and not automatically export all
> > public
> > >> methods and getter/setters.  There are a lot of just-in-case strings
> in
> > >> Royale apps.  That's not good.  So better control over things even
> after
> > >> compiling without being painful to use is the goal.
> > >>
> > >> My 2 cents,
> > >> -Alex
> > >>
> > >> On 9/16/19, 12:39 PM, "Josh Tynjala" 
> > wrote:
> > >>
> > >>I was thinking about this some more, and is there anything else
> > that's
> > >>public that also we allow to be renamed? I'm not aware of anything,
> > but
> > >>maybe I've missed something. If it's true, it seems inconsistent to
> > >> allow
> > >>public 

Build failed in Jenkins: royale-asjs_jsonly #3559

[Apache Royale CI Server]

See 


--
[...truncated 274.64 KB...]
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

check-dependency:
 [echo] checking for C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler/lib/external//lzma-sdk.jar

download-dependency:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

echo-project-jar:
   [delete] Deleting: C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources\project.properties
 [echo] ${INFO_DOWNLOADING_FILE_FROM}
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

download-apache-license:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

download-other-license:
  [get] Getting: https://www.7-zip.org/sdk.html
  [get] To: C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\lib\external\lzma-sdk-LICENSE.html
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

double-check-file:
 [echo] ${env.ROYALE_DOWNLOAD_CACHE}
 [echo] Need file: ${still_no_file}

get-from-cache-if-needed:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

fail-if-not-found:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

download-dependency-jar:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

check-cache:

download-jar:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

get-if-not-cached:
  [get] Getting: 
https://repo1.maven.org/maven2/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar
  [get] To: C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\lib\external\lzma-sdk.jar
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

double-check-file:
 [echo] ${env.ROYALE_DOWNLOAD_CACHE}
 [echo] Need file: ${still_no_file}

get-from-cache-if-needed:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

fail-if-not-found:
 [echo] basedir is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler\src\main\resources
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler
 [echo] ROYALE_COMPILER_HOME is C:\Program Files 
(x86)\Jenkins\workspace\royale-compiler\compiler

check-sum:
 [echo] basedir is C:\Program Files 

Release Step 011 Succeeded

[Apache Royale CI Server]

>From the royale-asjs repo:
1. Run ant -f releasesteps.xml Release_Step_011 -Drelease.version=0.9.6 
-DskipTests=true
This will download the artifacts then unzip and compile the source artifact.
2. Validate that the compiled artifacts match the downloaded artifacts.
3. If they do, then run ant -f releasesteps.xml Release_Step_011_Sign 
-Drelease.version=0.9.6
This will PGP sign the source ZIP and compiled JARs
4. Then run ant -f releasesteps.xml Release_Step_011_Upload 
-Drelease.version=0.9.6
This will upload the signed artifacts to Maven Release Staging.  Verify that 
the compiler and typedefs artifacts are there along with the asjs artifacts, 
then hit the close to close the staging repo. (https://repository.apache.org)

Release Step 010 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_010 and run the following commands:
git push
git push origin org.apache.royale.framework-0.9.6-rc2

You will need your Apache/Github username and 2FA token.

Release Step 009 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_009 and run the following commands:
git push

You will need your Apache/Github username and 2FA token.

Release Step 008 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_008 and run the following commands:
git push
git checkout release/0.9.6
git push -u origin release/0.9.6

You will need your Apache/Github username and 2FA token.

Release Step 007 Succeeded

[Apache Royale CI Server]

>From the royale-typedefs repo:
1. Run ant -f releasesteps.xml Release_Step_007 -Drelease.version=0.9.6 
-DskipTests=true
This will download the artifacts then unzip and compile the source artifact.
2. Validate that the compiled artifacts match the downloaded artifacts.
3. If they do, then run ant -f releasesteps.xml Release_Step_007_Sign 
-Drelease.version=0.9.6
This will PGP sign the source ZIP and compiled JARs
4. Then run ant -f releasesteps.xml Release_Step_007_Upload 
-Drelease.version=0.9.6
This will upload the signed artifacts to Maven Release Staging.  Do not "Close" 
the staging repository until the other repos have been added.

Release Step 006 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_006 and run the following commands:
git push
git push origin org.apache.royale.typedefs-0.9.6-rc2

You will need your Apache/Github username and 2FA token.

Release Step 005 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_005 and run the following commands:
git push

You will need your Apache/Github username and 2FA token.

Release Step 004 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_004 and run the following commands:
git push
git checkout release/0.9.6
git push -u origin release/0.9.6

You will need your Apache/Github username and 2FA token.

Release Step 003 Succeeded

[Apache Royale CI Server]

>From the royale-compiler repo:
1. If you are releasing the utils jars (compiler-jburg-types and 
compiler-build-tools) - you have set in previous step for mentioned projects 
version ex. 1.1.0 not snapshot, Run:
  ant -f releasesteps.xml Release_Step_003 -Dutils=true -Drelease.version=0.9.6 
-DskipTests=true
Otherwise, Run:
 ant -f releasesteps.xml Release_Step_003 -Drelease.version=0.9.6
This will download the artifacts then unzip and compile the source artifact.
2. Validate that the compiled artifacts match the downloaded artifacts.
3. If they do, then run ant -f releasesteps.xml Release_Step_003_Sign 
-Drelease.version=0.9.6
This will PGP sign the source ZIP and compiled JARs
4. Then run ant -f releasesteps.xml Release_Step_003_Upload 
-Drelease.version=0.9.6
This will upload the signed artifacts to Maven Release Staging.  Do not "Close" 
the staging repository until the other repos have been added.

Release Step 002a Succeeded

[Apache Royale CI Server]

Continue on to Release Step 003

Release Step 002 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_002 and run the following commands:
git push
git push origin org.apache.royale.compiler-0.9.6-rc2

You will need your Apache/Github username and 2FA token.

Royale_Release_Step_002 - Build # 43 - Failure!

[Apache Royale CI Server]

Royale_Release_Step_002 - Build # 43 - Failure:

Check console output at 
http://apacheroyaleci.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_002/43/
 to view the results.

Release Step 001a Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_001a_If_Utils and run the following 
commands:
git push

You will need your Apache/Github username and 2FA token.

Release Step 003 Succeeded

[Apache Royale CI Server]

>From the royale-compiler repo:
1. If you are releasing the utils jars (compiler-jburg-types and 
compiler-build-tools) - you have set in previous step for mentioned projects 
version ex. 1.1.0 not snapshot, Run:
  ant -f releasesteps.xml Release_Step_003 -Dutils=true -Drelease.version=0.9.6 
-DskipTests=true
Otherwise, Run:
 ant -f releasesteps.xml Release_Step_003 -Drelease.version=0.9.6
This will download the artifacts then unzip and compile the source artifact.
2. Validate that the compiled artifacts match the downloaded artifacts.
3. If they do, then run ant -f releasesteps.xml Release_Step_003_Sign 
-Drelease.version=0.9.6
This will PGP sign the source ZIP and compiled JARs
4. Then run ant -f releasesteps.xml Release_Step_003_Upload 
-Drelease.version=0.9.6
This will upload the signed artifacts to Maven Release Staging.  Do not "Close" 
the staging repository until the other repos have been added.

Release Step 002a Succeeded

[Apache Royale CI Server]

Continue on to Release Step 003

Release Step 002 Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_002 and run the following commands:
git push
git push origin org.apache.royale.compiler-0.9.6-rc2

You will need your Apache/Github username and 2FA token.

Release Step 001a Succeeded

[Apache Royale CI Server]

Log in to the server, open a command prompt, change directory to 
C:\jenkins\workspace\Royale_Release_Step_001a_If_Utils and run the following 
commands:
git push

You will need your Apache/Github username and 2FA token.

Re: Could @nocollapse be a solution to the -warn-public-vars issue?

[Greg Dove]

I agree 100% Harbs. And I think that is not difficult to achieve.

The decisions and collaborative effort need to take place in the planning
side of things to figure out the reasonable set of granular things to
support. Perhaps we can do that once the 'dust has settled' after 0.9.6 is
out. Then your 3 sets (or whatever is decided to be the menu) could simply
be defined as a collection of settings for those, with people free to tune
things at a more granular level if they wanted.
I might want to, for example, be able to strip out reflection data from UI
based Framework classes but keep it for all other framework stuff, and all
my own custom UI components, (perhaps that sounds weird, but I can think of
this as being useful in a real-world scenario with Crux). Whether that
level or control is reasonable for us to support is probably questionable.
But I think it is *possible*. This is the same type of granular switching I
was trying to explain for switching off Vector runtime checking in recent
months, but I did not get a sense that anyone clearly understood what I was
trying to convey at the time (my impression only).

I think the main thing we are missing (from my perspective) is to avoid the
need to recompile the swcs to swap things in and out.
Anyway, I will stop talking about this, I just wanted to highlight the fact
that I believe we can technically meet most people's needs, whatever they
are, but that I also think the general need is best served by matching as3
behavior by default, as Josh has proposed for public vars.



On Tue, Sep 17, 2019 at 10:28 PM Harbs  wrote:

> Rather than having to specify a whole slew of compiler options, I’d like
> to see 2 or 3 compiler configurations that would set the defaults on a
> group of options to get the best default behavior for a use case.
> Maybe something like this:
>
> js-config=compatible (for maximum, compatibility with Flash behavior)
> js-config=optimized (for minimum code size)
> js-config=safe (for best type safety but not necessarily Flash compatible)
>
> Obviously, you could override the defaults on any one of these, but I hope
> we could give predefined sets of defaults which cover the vast majority of
> use cases out of the box.
>
> It’s hard learning all the compiler options, but being able to specify a
> few sets of defaults seems reasonable.
>
> Harbs
>
> > On Sep 17, 2019, at 11:02 AM, Greg Dove  wrote:
> >
> > I personally would use a non-default setting to keep things as they are
> > right now, but I agree with Josh in that as it is, I don't think it's a
> > good hurdle to present to new users, or people in general that simply
> want
> > things to 'work' out of the box, based on what they should reasonably
> > expect to work. The language layer is the foundation for building
> > everything else. People have serious doubts when things don't work right
> at
> > that level. I have had to reassure people about this recently (XML -
> still
> > working on it - soon!).
> >
> > We have only touched the surface of what we could do with GCC for tuning
> > the output. There are ways to have all the default stuff in there but
> > selectively remove it from release builds without having to recompile
> > library code, for example. So I think it is possible that we could
> provide
> > flexible solutions that match whatever we consider people want.
> > But in terms of defaults, is it not obvious that it we should be guided
> by
> > actionscript 3 language itself and the reference implementation we
> already
> > have? We can't always match things, but I think the onus is on us to get
> as
> > close as we can by default.
> >
> >
> > On Tue, Sep 17, 2019 at 5:59 PM Alex Harui 
> wrote:
> >
> >> Some folks want us to get smarter and not automatically export all
> public
> >> methods and getter/setters.  There are a lot of just-in-case strings in
> >> Royale apps.  That's not good.  So better control over things even after
> >> compiling without being painful to use is the goal.
> >>
> >> My 2 cents,
> >> -Alex
> >>
> >> On 9/16/19, 12:39 PM, "Josh Tynjala" 
> wrote:
> >>
> >>I was thinking about this some more, and is there anything else
> that's
> >>public that also we allow to be renamed? I'm not aware of anything,
> but
> >>maybe I've missed something. If it's true, it seems inconsistent to
> >> allow
> >>public variables to be the one exception that should be renamed. If
> >> public
> >>methods, properties, and other things can't be renamed, public
> >> variables
> >>shouldn't be either.
> >>
> >>Looking into the configuration classes, I see that we have the
> >>export-public-symbols compiler option. That seems like it's the one
> >> that is
> >>meant to control whether public things should be renamed or not. It's
> >> true
> >>by default. I have no issue with public variables being renamed when
> >> it's
> >>false. Again, that would be consistent with how the compiler handles
> >> other
> >>public things.
> 

Build failed in Jenkins: royale-asjs_MXTests #1163

[Apache Royale CI Server]

See 


--
[...truncated 1000.72 KB...]
[mxmlc] scanning for overrides: ObjectUtil
[mxmlc] scanning for overrides: SolidBorderUtil
[mxmlc] scanning for overrides: StringTrimmer
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: Timer
[mxmlc] scanning for overrides: UIUtils
[mxmlc] scanning for overrides: Effect
[mxmlc] scanning for overrides: Transition
[mxmlc] scanning for overrides: IFill
[mxmlc] scanning for overrides: SolidColor
[mxmlc] scanning for overrides: IExternalizable
[mxmlc] scanning for overrides: Proxy
[mxmlc] scanning for overrides: CursorBookmark
[mxmlc] scanning for overrides: ICollectionView
[mxmlc] scanning for overrides: IList
[mxmlc] scanning for overrides: IViewCursor
[mxmlc] scanning for overrides: ListCollectionView
[mxmlc] scanning for overrides: ListCollectionViewCursor
[mxmlc] scanning for overrides: ListCollectionViewBookmark
[mxmlc] scanning for overrides: ArrayCollection
[mxmlc] scanning for overrides: ArrayList
[mxmlc] scanning for overrides: XMLListCollection
[mxmlc] scanning for overrides: CanvasLayout
[mxmlc] scanning for overrides: Flex
[mxmlc] scanning for overrides: BoxDirection
[mxmlc] scanning for overrides: HBox
[mxmlc] scanning for overrides: PanelTitleBar
[mxmlc] scanning for overrides: DataGridColumn
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ISelectable
[mxmlc] scanning for overrides: CheckBox
[mxmlc] scanning for overrides: IFocusManagerComponent
[mxmlc] scanning for overrides: ComboBase
[mxmlc] scanning for overrides: ComboBox
[mxmlc] scanning for overrides: ScrollControlBase
[mxmlc] scanning for overrides: ListBase
[mxmlc] scanning for overrides: DataGrid
[mxmlc] scanning for overrides: DateField
[mxmlc] scanning for overrides: Label
[mxmlc] scanning for overrides: List
[mxmlc] scanning for overrides: MenuBar
[mxmlc] scanning for overrides: NumericStepper
[mxmlc] scanning for overrides: RadioButton
[mxmlc] scanning for overrides: RadioButtonGroup
[mxmlc] scanning for overrides: TextArea
[mxmlc] scanning for overrides: ITextInput
[mxmlc] scanning for overrides: TextInput
[mxmlc] scanning for overrides: ITextFieldFactory
[mxmlc] scanning for overrides: Singleton
[mxmlc] scanning for overrides: ItemClickEvent
[mxmlc] scanning for overrides: ListEvent
[mxmlc] scanning for overrides: MenuEvent
[mxmlc] scanning for overrides: MouseEvent
[mxmlc] scanning for overrides: PropertyChangeEventKind
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: Matrix
[mxmlc] scanning for overrides: IFocusManagerComplexComponent
[mxmlc] scanning for overrides: IFocusManagerGroup
[mxmlc] scanning for overrides: IResourceBundle
[mxmlc] scanning for overrides: ResourceManagerImpl
[mxmlc] scanning for overrides: ResourceModuleInfo
[mxmlc] scanning for overrides: ResourceEventDispatcher
[mxmlc] scanning for overrides: ResourceBundleProxy
[mxmlc] scanning for overrides: GroupBase
[mxmlc] scanning for overrides: SkinnableComponent
[mxmlc] scanning for overrides: ButtonBase
[mxmlc] scanning for overrides: Button
[mxmlc] scanning for overrides: ErrorArray
[mxmlc] scanning for overrides: RunCodeEvent
[mxmlc] scanning for overrides: PasswordInputBead
[mxmlc] scanning for overrides: ITileLayout
[mxmlc] scanning for overrides: TileLayout
[mxmlc] scanning for overrides: LocaleUtils
[mxmlc] scanning for overrides: StringPadder
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: IStroke
[mxmlc] scanning for overrides: CursorError
[mxmlc] scanning for overrides: SortError
[mxmlc] scanning for overrides: ISort
[mxmlc] scanning for overrides: Sort
[mxmlc] scanning for overrides: IXMLNotifiable
[mxmlc] scanning for overrides: XMLListAdapter
[mxmlc] scanning for overrides: FlexChildInfo
[mxmlc] scanning for overrides: BaseListData
[mxmlc] scanning for overrides: IFactory
[mxmlc] scanning for overrides: IUITextField
[mxmlc] scanning for overrides: UITextField
[mxmlc] scanning for overrides: CollectionEvent
[mxmlc] scanning for overrides: CollectionEventKind
[mxmlc] scanning for overrides: LocaleSorter
[mxmlc] scanning for overrides: LocaleID
[mxmlc] scanning for overrides: LocaleRegistry
[mxmlc] scanning for overrides: ResourceBundle
[mxmlc] scanning for overrides: ArrayUtil
[mxmlc] scanning for overrides: StringUtil
[mxmlc] scanning for overrides: UIDUtil
[mxmlc] scanning for overrides: DataGroup
[mxmlc] scanning for overrides: LayoutBase
[mxmlc] scanning for overrides: BasicLayout