Review Request 68753: SENTRY-2407: SentrySchemaInfo and SQL scripts do not have the new 2.2.0 version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68753/ --- Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Bugs: sentry-2407 https://issues.apache.org/jira/browse/sentry-2407 Repository: sentry Description --- increase schema version from 2.1.0 to 2.2.0 Diffs - sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.1.0-to-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.1.0-to-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.1.0-to-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.1.0-to-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.1.0-to-2.2.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 081f575 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby a2cc2b6 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql a2cc2b6 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle a2cc2b6 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres a2cc2b6 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java f710253 Diff: https://reviews.apache.org/r/68753/diff/1/ Testing --- Thanks, Na Li
Re: Review Request 68716: SENTRY-2403: Incorrect naming in RollingFileWithoutDeleteAppender
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68716/#review208706 --- Ship it! Ship It! - Sergio Pena On Sept. 14, 2018, 1:22 p.m., Peter Somogyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68716/ > --- > > (Updated Sept. 14, 2018, 1:22 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-2403 > https://issues.apache.org/jira/browse/SENTRY-2403 > > > Repository: sentry > > > Description > --- > > RollingFileWithoutDeleteAppender incorrectly append timestamp to logfiles > without removing previous one. > > > Diffs > - > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java > fd133f34f > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java > ca9062bca > > > Diff: https://reviews.apache.org/r/68716/diff/1/ > > > Testing > --- > > Modified TestRollingFileWithoutDeleteAppender to check the pattern correctly. > > > Thanks, > > Peter Somogyi > >
