Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69076/#review212296
---




sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
Lines 107 (patched)


Can you make configurarble? It might be helpfull.
 What do you say?



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
Lines 279 (patched)


I dont't a value is printing partition-id. Instead we should be looging 
partion name. Yes, it will be big. Information that we are trying to log will 
be any way high regardless.



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
Lines 299-300 (patched)


Change "Fetch partition objects for" to "Fetching partitions for ". This 
comment applies to tabletask and dbtask as well.



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
Lines 319 (patched)


Printing partitionId doesn't tell you anything. Looking at the ID you can 
not derive the parition that has null storage descriptot. You should print 
partition name.



sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
Lines 555 (patched)


This doesn't look correct because results might be still getting appended 
by the tasks.(PartitionTask/TableTask/DbTask)

You should instead print the number of objects for which paths are already 
fetched. Number of objects here include database and tables.

You can use fullSnapshot.size(). This will give the total number of 
databases and tables fetches fetched so far.

This is good enough.


- kalyan kumar kalvagadda


On Jan. 24, 2019, 6:24 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69076/
> ---
> 
> (Updated Jan. 24, 2019, 6:24 p.m.)
> 
> 
> Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and 
> Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> When sentry is fetching snapshot from HMS, it should log periodically on 
> where it stands in the snapshot process. This will help person debugging it 
> and help him understand the progress.
> 
>  
> 
> This is important as this process could take magnitude of minutes when the 
> HMS data is huge.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>  534bb51c1 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java
>  4ff3dc91a 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  4baeb6725 
> 
> 
> Diff: https://reviews.apache.org/r/69076/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Re: Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

[Arjun Mishra via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69832/
---

(Updated Jan. 24, 2019, 9:35 p.m.)


Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, and Na Li.


Changes
---

Post feebdack


Bugs: SENTRY-2488
https://issues.apache.org/jira/browse/SENTRY-2488


Repository: sentry


Description
---

We are not consistent with behavior in SentryHiveMetaStoreHook (not used 
anymore) which would cache privileges when authorizing show databases or show 
tables command. This needs to be added back


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 9de47b338 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
 63d8d1c09 


Diff: https://reviews.apache.org/r/69832/diff/2/

Changes: https://reviews.apache.org/r/69832/diff/1-2/


Testing
---


Thanks,

Arjun Mishra

Re: Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69832/#review212289
---


Fix it, then Ship it!




Fix it and ship it.


sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
Lines 248-250 (original), 247-256 (patched)


Add comments to new API explaining what it does.



sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
Line 831 (original), 831 (patched)


This need not be a public API. Instead you could use no modifier limititng 
it to the package.


- kalyan kumar kalvagadda


On Jan. 24, 2019, 6:23 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69832/
> ---
> 
> (Updated Jan. 24, 2019, 6:23 p.m.)
> 
> 
> Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: SENTRY-2488
> https://issues.apache.org/jira/browse/SENTRY-2488
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> We are not consistent with behavior in SentryHiveMetaStoreHook (not used 
> anymore) which would cache privileges when authorizing show databases or show 
> tables command. This needs to be added back
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
>  9de47b338 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
>  63d8d1c09 
> 
> 
> Diff: https://reviews.apache.org/r/69832/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Sentry-jdk-1.8 - Build # 198 - Fixed

[Apache Jenkins Server]

The Apache Jenkins build system has built Sentry-jdk-1.8 (build #198)

Status: Fixed

Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/198/ to 
view the results.

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

[kalyan kumar kalvagadda via Review Board]

> On Sept. 4, 2018, 6:32 p.m., Arjun Mishra wrote:
> > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
> > Lines 74 (patched)
> > 
> >
> > This condition should be after getUpdatesFrom methods for path and perm 
> > are called. That is where state SENDING_FULL_UPDATES is set. 
> > 
> > Also this should be an OR for Path Updates or Perm updates. We are 
> > checking for sending full update state as opposed to the inital HDFS ACL 
> > sync
> 
> kalyan kumar kalvagadda wrote:
> This logic is hit when the client sends a request after sentry server 
> sent the full update for perms and paths.
> 
> Arjun Mishra wrote:
> Ok got it. So it is logged on the cosecutive call. I still see a problem 
> though. I think its not fair to say PathUpdate and PermUpdate will be set to 
> SENDING_FULL_UPDATES at the same time. Your logic is assuming that current 
> path and perm update state is SENDING_FULL_UPDATES  but it can be the case 
> that PathUpdate is still at FETCHING_FULL_UPDATES, while PermUpdate state 
> (which usually occurs faster) has completed sending full updates and is now 
> at SENDING_DELTA_UPDATE. That means when PathUpdate completes sending full 
> update, this condition will not be true 
> (SentryStateBank.isEnabled(PathUpdaterState.COMPONENT, 
> PermUpdaterState.SENDING_FULL_UPDATES) && 
> SentryStateBank.isEnabled(PathUpdaterState.COMPONENT, 
> PermUpdaterState.SENDING_FULL_UPDATES))
> 
> Arjun Mishra wrote:
> I think instead of verifying if HDFS ACL sync is complete, we can only 
> log if Path Full Update has been sent, and Perm Full Update has been sent.
> 
> Arjun Mishra wrote:
> The corrent logic should actually be if both Path and Perm update state 
> is at SENDING_DELTA_UPDATES. That is a garuntee that full updates have 
> already been sent, since deltaas are requested only after full updates were 
> sent

Here is the logic makes sure that thar both PathUpdaterState and 
PermUpdaterState are in SENDING_FULL_UPDATES and there was a request from 
Namenode asking for path and perm sequences what which are greater than the 
sequence numbers that were served.

If we change the logic as you suggested it could take longer as there need not 
be updates after a full update was sent.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68622/#review208319
---


On Jan. 24, 2019, 6:38 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68622/
> ---
> 
> (Updated Jan. 24, 2019, 6:38 p.m.)
> 
> 
> Review request for sentry and Arjun Mishra.
> 
> 
> Bugs: SENTRY-2287
> https://issues.apache.org/jira/browse/SENTRY-2287
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Currently there is no way to confirm that HDFS ACL synchronization is 
> complete when snapshot is initiated. We need to identify that and log in 
> console and log file as well.
> 
> 
> Diffs
> -
> 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
>  08b16a4df3ea9126f21248365d6096fcdb83f21e 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java
>  81c614a345c122e067ec0a19b8f75766390b2ad4 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java
>  3532ef33dde8b119ab095861381fa52fa5520f4c 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java
>  8d6713acd61f99940f72c4985098dfeabb9fc832 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
>  443434127b14fadaeb27717ad2370dcdc10ca70c 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
>  0cd405b54ee2b4bf788dffb1ac606362614f6efe 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PathUpdaterState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PermUpdaterState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
>  2afe919c31b0c5f495d54c6448593abad38eddc2 
> 
> 
> Diff: https://reviews.apache.org/r/68622/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

[kalyan kumar kalvagadda via Review Board]

> On Sept. 5, 2018, 8:27 p.m., Na Li wrote:
> > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
> > Lines 74 (patched)
> > 
> >
> > we should seperate the logic for path update from perm update. They can 
> > be independent.

They need not be because sentry namenode plugin requets for both paths and 
permissions in a single request and sentry responds back with pahs and 
permissions in the same response back.


> On Sept. 5, 2018, 8:27 p.m., Na Li wrote:
> > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
> > Lines 75 (patched)
> > 
> >
> > this line is the same as line 74. Why do you duplicate it?

There was a typo. Good find.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68622/#review208371
---


On Jan. 24, 2019, 6:38 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68622/
> ---
> 
> (Updated Jan. 24, 2019, 6:38 p.m.)
> 
> 
> Review request for sentry and Arjun Mishra.
> 
> 
> Bugs: SENTRY-2287
> https://issues.apache.org/jira/browse/SENTRY-2287
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Currently there is no way to confirm that HDFS ACL synchronization is 
> complete when snapshot is initiated. We need to identify that and log in 
> console and log file as well.
> 
> 
> Diffs
> -
> 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
>  08b16a4df3ea9126f21248365d6096fcdb83f21e 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java
>  81c614a345c122e067ec0a19b8f75766390b2ad4 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java
>  3532ef33dde8b119ab095861381fa52fa5520f4c 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java
>  8d6713acd61f99940f72c4985098dfeabb9fc832 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
>  443434127b14fadaeb27717ad2370dcdc10ca70c 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
>  0cd405b54ee2b4bf788dffb1ac606362614f6efe 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PathUpdaterState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PermUpdaterState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
>  2afe919c31b0c5f495d54c6448593abad38eddc2 
> 
> 
> Diff: https://reviews.apache.org/r/68622/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68622/
---

(Updated Jan. 24, 2019, 6:38 p.m.)


Review request for sentry and Arjun Mishra.


Changes
---

addressed review comments.


Bugs: SENTRY-2287
https://issues.apache.org/jira/browse/SENTRY-2287


Repository: sentry


Description
---

Currently there is no way to confirm that HDFS ACL synchronization is complete 
when snapshot is initiated. We need to identify that and log in console and log 
file as well.


Diffs (updated)
-

  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
 08b16a4df3ea9126f21248365d6096fcdb83f21e 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java
 81c614a345c122e067ec0a19b8f75766390b2ad4 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java
 3532ef33dde8b119ab095861381fa52fa5520f4c 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java
 8d6713acd61f99940f72c4985098dfeabb9fc832 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
 443434127b14fadaeb27717ad2370dcdc10ca70c 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
 0cd405b54ee2b4bf788dffb1ac606362614f6efe 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PathUpdaterState.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PermUpdaterState.java
 PRE-CREATION 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
 2afe919c31b0c5f495d54c6448593abad38eddc2 


Diff: https://reviews.apache.org/r/68622/diff/2/

Changes: https://reviews.apache.org/r/68622/diff/1-2/


Testing
---


Thanks,

kalyan kumar kalvagadda

Re: Review Request 68622: SENTRY-2287: Find a way to report that HDFS ACL synchronization is complete.

[kalyan kumar kalvagadda via Review Board]

- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68622/#review208319
---


On Jan. 24, 2019, 6:38 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68622/
> ---
> 
> (Updated Jan. 24, 2019, 6:38 p.m.)
> 
> 
> Review request for sentry and Arjun Mishra.
> 
> 
> Bugs: SENTRY-2287
> https://issues.apache.org/jira/browse/SENTRY-2287
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Currently there is no way to confirm that HDFS ACL synchronization is 
> complete when snapshot is initiated. We need to identify that and log in 
> console and log file as well.
> 
> 
> Diffs
> -
> 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
>  08b16a4df3ea9126f21248365d6096fcdb83f21e 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java
>  81c614a345c122e067ec0a19b8f75766390b2ad4 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java
>  3532ef33dde8b119ab095861381fa52fa5520f4c 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java
>  8d6713acd61f99940f72c4985098dfeabb9fc832 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
>  443434127b14fadaeb27717ad2370dcdc10ca70c 
>   
> sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
>  0cd405b54ee2b4bf788dffb1ac606362614f6efe 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PathUpdaterState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PermUpdaterState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
>  2afe919c31b0c5f495d54c6448593abad38eddc2 
> 
> 
> Diff: https://reviews.apache.org/r/68622/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

[Arjun Mishra via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69832/
---

Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, and Na Li.


Bugs: SENTRY-2488
https://issues.apache.org/jira/browse/SENTRY-2488


Repository: sentry


Description
---

We are not consistent with behavior in SentryHiveMetaStoreHook (not used 
anymore) which would cache privileges when authorizing show databases or show 
tables command. This needs to be added back


Diffs
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 9de47b338 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
 63d8d1c09 


Diff: https://reviews.apache.org/r/69832/diff/1/


Testing
---


Thanks,

Arjun Mishra

Re: Review Request 69702: SENTRY-2483: Implement HMS PreReadEvent support in MetastoreAuthzBinding

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69702/
---

(Updated Jan. 24, 2019, 4:15 p.m.)


Review request for sentry, Arjun Mishra and kalyan kumar kalvagadda.


Bugs: sentry-2483
https://issues.apache.org/jira/browse/sentry-2483


Repository: sentry


Description
---

Add READ_DATABASE and READ_TABLE events support to provide read authorization 
to HMS.

This is based on changed made by Sergio at https://reviews.apache.org/r/69620/, 
and add code to fix unstable e2e tests


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java
 328d2b5 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/HiveSimpleConnectionFactory.java
 31e58fd 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
 0d62941 
  sentry-tests/sentry-tests-hive/pom.xml 74777bb 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
 47f7466 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java
 e504a8a 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
 8bf486e 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
 7d41348 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java
 3c28fd0 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
 f8f304f 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java
 9fa42f2 


Diff: https://reviews.apache.org/r/69702/diff/4/

Changes: https://reviews.apache.org/r/69702/diff/3-4/


Testing
---

add new e2e tests for READ_DATABASE and READ_TABLE at HMS


Thanks,

Na Li