Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200827 --- Ship it! Ship It! - Na Li On April 10, 2018, 2:16 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66360/ > --- > > (Updated April 10, 2018, 2:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio > Pena. > > > Bugs: SENTRY-2192 > https://issues.apache.org/jira/browse/SENTRY-2192 > > > Repository: sentry > > > Description > --- > > With the current thrift options used, @Generated annotation adds date which > kind of updates all the thrift generated files when --thriftif option used. > > When someone makes some changes to any of the thrift definitions and tries to > generate the source all the auto generated files get updated. > > This can be avoided by suppressing date in the @generated annotation. > > > Diffs > - > > sentry-hdfs/sentry-hdfs-common/pom.xml > 5c6c96c46ee384ba5981611333741fde3bd59e10 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java > 726337c39283304166f13999b5e9f8a82f5219b4 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java > b61d5b6041228b6aa530c53c97f1c910d46e6943 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java > f837e47ca9eec88ca4209ab0cdbe5da70d840acb > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java > bf10bf0fcc42d1af8f2789259bfb638918b3eede > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java > 4bed8d675d2aaac2567e15ad4b41e5daaa8940aa > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java > b37c8bea2e076f51121262d7113e8d1f76fa0464 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java > 2ce52a7a0453c4f8725909ca3604fa18f4d94c99 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java > 3d90816bcaf3f592f7a9fbd9a8293f312b71e1da > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java > ed2f6fa19bf5b0552454dbfbde24d25e02340643 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java > e5bd36d5f1f6eb362584bcce386d7cd39bc43d23 > sentry-provider/sentry-provider-db/pom.xml > 4751549bcc40d60ca8f5400dd371761bc6fbf2d5 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java > cb75cf2680fbb924502d95c43eaa876e29a1f799 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java > a97571d14464dd012b5ab5f8c2d929c9d81213b5 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java > 159f61ac80fd626a338ec0aa1a1e8a17e0505097 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java > 1578bea61d095cf27b32da987c17f38a9c09a1e4 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java > c74773c37e0708b13b35c40a7c3a07a1a811508a > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java > a9c89e5d93c7fc59afa16f8d5411d62ff83fb70b > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java > 9bf736cf39bcf62e9cdd8ac4b5b1f01f0f51be6d > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java > a03c2aa1d0e6ca273961a49ca165a1e95d4d0b58 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeResponse.java > 96436c0613b864c7374f97027865cd652117992b >
Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/ --- (Updated April 10, 2018, 2:16 p.m.) Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio Pena. Changes --- Updated new patch which has changed to pom file avoiding the date added to the thrift files that are generated. Changes in the rest of the thrift generated files is just date. Date is removed from all of them. Bugs: SENTRY-2192 https://issues.apache.org/jira/browse/SENTRY-2192 Repository: sentry Description --- With the current thrift options used, @Generated annotation adds date which kind of updates all the thrift generated files when --thriftif option used. When someone makes some changes to any of the thrift definitions and tries to generate the source all the auto generated files get updated. This can be avoided by suppressing date in the @generated annotation. Diffs (updated) - sentry-hdfs/sentry-hdfs-common/pom.xml 5c6c96c46ee384ba5981611333741fde3bd59e10 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java 726337c39283304166f13999b5e9f8a82f5219b4 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java b61d5b6041228b6aa530c53c97f1c910d46e6943 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java f837e47ca9eec88ca4209ab0cdbe5da70d840acb sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java bf10bf0fcc42d1af8f2789259bfb638918b3eede sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java 4bed8d675d2aaac2567e15ad4b41e5daaa8940aa sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java b37c8bea2e076f51121262d7113e8d1f76fa0464 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java 2ce52a7a0453c4f8725909ca3604fa18f4d94c99 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java 3d90816bcaf3f592f7a9fbd9a8293f312b71e1da sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java ed2f6fa19bf5b0552454dbfbde24d25e02340643 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java e5bd36d5f1f6eb362584bcce386d7cd39bc43d23 sentry-provider/sentry-provider-db/pom.xml 4751549bcc40d60ca8f5400dd371761bc6fbf2d5 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java cb75cf2680fbb924502d95c43eaa876e29a1f799 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java a97571d14464dd012b5ab5f8c2d929c9d81213b5 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java 159f61ac80fd626a338ec0aa1a1e8a17e0505097 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java 1578bea61d095cf27b32da987c17f38a9c09a1e4 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java c74773c37e0708b13b35c40a7c3a07a1a811508a sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java a9c89e5d93c7fc59afa16f8d5411d62ff83fb70b sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java 9bf736cf39bcf62e9cdd8ac4b5b1f01f0f51be6d sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java a03c2aa1d0e6ca273961a49ca165a1e95d4d0b58 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeResponse.java 96436c0613b864c7374f97027865cd652117992b sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAuthorizable.java b6cfe5d334e7ddb47c94e4c456d44691be509bf6
Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200209 --- It would be great if you can find out why some files the variable names are changed. - Na Li On March 29, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66360/ > --- > > (Updated March 29, 2018, 1:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio > Pena. > > > Bugs: SENTRY-2192 > https://issues.apache.org/jira/browse/SENTRY-2192 > > > Repository: sentry > > > Description > --- > > With the current thrift options used, @Generated annotation adds date which > kind of updates all the thrift generated files when --thriftif option used. > > When someone makes some changes to any of the thrift definitions and tries to > generate the source all the auto generated files get updated. > > This can be avoided by suppressing date in the @generated annotation. > > > Diffs > - > > sentry-hdfs/sentry-hdfs-common/pom.xml > 5c6c96c46ee384ba5981611333741fde3bd59e10 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java > ac1fa6af17239e23557614e7149c7cc911e28e12 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java > 62fd0bb2426db427241a5f805c9e250b306b4947 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java > 68aec801ae7f38f8cbbe8549f5d9df79b609b114 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java > 8d3297ffe6f2de4dc3dc82f82a70b5ad2a235911 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java > 210d2191c38603d4a951a590eee85c8fccdde124 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java > df5b7b10656102c6471885cfea73b0ed8dd67dd7 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java > 9fd3924f138696707df4ab1bb5c994005b9bd1f4 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java > e8c09322ac6f8b8210bc4dd8869ad3b0353b63d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java > 0472f33ec49652ef402bcb332321fb2803b923d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java > 1a502080896b2b85e9bf6ae4780b4a2db35473f7 > sentry-provider/sentry-provider-db/pom.xml > 4751549bcc40d60ca8f5400dd371761bc6fbf2d5 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java > ae4db6a06c72a93e62bc5a3c2a17776bcb7d > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java > 0b62dae0588859bceea54b8f4b49689561a7a4f9 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java > 29e5baf8d3ecd67ae655f513eaba5a1a2bc14b9a > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java > 42293b7bbda879d87f69721cfc3f4fd533055ae2 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java > a3a660cc9d53411588c5a681b84a75a35ebc3f96 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java > 49cfe4b0057721839c442353b6441013d5d6438c > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java > 6890337d6262500283086abf54e19ff1450796f8 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java > 91793fee0f3a96a2fdec0cfecac325c65c08c999 > >
Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift
> On March 29, 2018, 5:29 p.m., Steve Moist wrote: > > Tested this out with some by adding the thrift apis I wrote (new endpoints > > and objects). It generates only the necessary files and changes in most > > cases. When adding new endpoints and objects it shifts things around in > > the a common generated file. This is fine but might make reviews a little > > annoying. > > > > Look at the maven plugin in the code I submitted for the associated ticket. > > It's cleaner than the custom mvn build stuff that exists now, see if that > > can be replaced. > > kalyan kumar kalvagadda wrote: > Steve, > > Can you provide more details on the maven plug-in you are talking about. See the diff/review for SENTRY-2188 It contains that in the pom. - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200202 --- On March 29, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66360/ > --- > > (Updated March 29, 2018, 1:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio > Pena. > > > Bugs: SENTRY-2192 > https://issues.apache.org/jira/browse/SENTRY-2192 > > > Repository: sentry > > > Description > --- > > With the current thrift options used, @Generated annotation adds date which > kind of updates all the thrift generated files when --thriftif option used. > > When someone makes some changes to any of the thrift definitions and tries to > generate the source all the auto generated files get updated. > > This can be avoided by suppressing date in the @generated annotation. > > > Diffs > - > > sentry-hdfs/sentry-hdfs-common/pom.xml > 5c6c96c46ee384ba5981611333741fde3bd59e10 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java > ac1fa6af17239e23557614e7149c7cc911e28e12 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java > 62fd0bb2426db427241a5f805c9e250b306b4947 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java > 68aec801ae7f38f8cbbe8549f5d9df79b609b114 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java > 8d3297ffe6f2de4dc3dc82f82a70b5ad2a235911 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java > 210d2191c38603d4a951a590eee85c8fccdde124 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java > df5b7b10656102c6471885cfea73b0ed8dd67dd7 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java > 9fd3924f138696707df4ab1bb5c994005b9bd1f4 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java > e8c09322ac6f8b8210bc4dd8869ad3b0353b63d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java > 0472f33ec49652ef402bcb332321fb2803b923d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java > 1a502080896b2b85e9bf6ae4780b4a2db35473f7 > sentry-provider/sentry-provider-db/pom.xml > 4751549bcc40d60ca8f5400dd371761bc6fbf2d5 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java > ae4db6a06c72a93e62bc5a3c2a17776bcb7d > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java > 0b62dae0588859bceea54b8f4b49689561a7a4f9 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java > 29e5baf8d3ecd67ae655f513eaba5a1a2bc14b9a > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java > 42293b7bbda879d87f69721cfc3f4fd533055ae2 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java > a3a660cc9d53411588c5a681b84a75a35ebc3f96 > >
Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift
> On March 29, 2018, 5:29 p.m., Steve Moist wrote: > > Tested this out with some by adding the thrift apis I wrote (new endpoints > > and objects). It generates only the necessary files and changes in most > > cases. When adding new endpoints and objects it shifts things around in > > the a common generated file. This is fine but might make reviews a little > > annoying. > > > > Look at the maven plugin in the code I submitted for the associated ticket. > > It's cleaner than the custom mvn build stuff that exists now, see if that > > can be replaced. Steve, Can you provide more details on the maven plug-in you are talking about. - kalyan kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200202 --- On March 29, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66360/ > --- > > (Updated March 29, 2018, 1:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio > Pena. > > > Bugs: SENTRY-2192 > https://issues.apache.org/jira/browse/SENTRY-2192 > > > Repository: sentry > > > Description > --- > > With the current thrift options used, @Generated annotation adds date which > kind of updates all the thrift generated files when --thriftif option used. > > When someone makes some changes to any of the thrift definitions and tries to > generate the source all the auto generated files get updated. > > This can be avoided by suppressing date in the @generated annotation. > > > Diffs > - > > sentry-hdfs/sentry-hdfs-common/pom.xml > 5c6c96c46ee384ba5981611333741fde3bd59e10 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java > ac1fa6af17239e23557614e7149c7cc911e28e12 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java > 62fd0bb2426db427241a5f805c9e250b306b4947 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java > 68aec801ae7f38f8cbbe8549f5d9df79b609b114 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java > 8d3297ffe6f2de4dc3dc82f82a70b5ad2a235911 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java > 210d2191c38603d4a951a590eee85c8fccdde124 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java > df5b7b10656102c6471885cfea73b0ed8dd67dd7 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java > 9fd3924f138696707df4ab1bb5c994005b9bd1f4 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java > e8c09322ac6f8b8210bc4dd8869ad3b0353b63d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java > 0472f33ec49652ef402bcb332321fb2803b923d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java > 1a502080896b2b85e9bf6ae4780b4a2db35473f7 > sentry-provider/sentry-provider-db/pom.xml > 4751549bcc40d60ca8f5400dd371761bc6fbf2d5 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java > ae4db6a06c72a93e62bc5a3c2a17776bcb7d > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java > 0b62dae0588859bceea54b8f4b49689561a7a4f9 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java > 29e5baf8d3ecd67ae655f513eaba5a1a2bc14b9a > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java > 42293b7bbda879d87f69721cfc3f4fd533055ae2 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java > a3a660cc9d53411588c5a681b84a75a35ebc3f96 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java > 49cfe4b0057721839c442353b6441013d5d6438c >
Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200202 --- Tested this out with some by adding the thrift apis I wrote (new endpoints and objects). It generates only the necessary files and changes in most cases. When adding new endpoints and objects it shifts things around in the a common generated file. This is fine but might make reviews a little annoying. Look at the maven plugin in the code I submitted for the associated ticket. It's cleaner than the custom mvn build stuff that exists now, see if that can be replaced. - Steve Moist On March 29, 2018, 1:16 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66360/ > --- > > (Updated March 29, 2018, 1:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio > Pena. > > > Bugs: SENTRY-2192 > https://issues.apache.org/jira/browse/SENTRY-2192 > > > Repository: sentry > > > Description > --- > > With the current thrift options used, @Generated annotation adds date which > kind of updates all the thrift generated files when --thriftif option used. > > When someone makes some changes to any of the thrift definitions and tries to > generate the source all the auto generated files get updated. > > This can be avoided by suppressing date in the @generated annotation. > > > Diffs > - > > sentry-hdfs/sentry-hdfs-common/pom.xml > 5c6c96c46ee384ba5981611333741fde3bd59e10 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java > ac1fa6af17239e23557614e7149c7cc911e28e12 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java > 62fd0bb2426db427241a5f805c9e250b306b4947 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java > 68aec801ae7f38f8cbbe8549f5d9df79b609b114 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java > 8d3297ffe6f2de4dc3dc82f82a70b5ad2a235911 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java > 210d2191c38603d4a951a590eee85c8fccdde124 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java > df5b7b10656102c6471885cfea73b0ed8dd67dd7 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java > 9fd3924f138696707df4ab1bb5c994005b9bd1f4 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java > e8c09322ac6f8b8210bc4dd8869ad3b0353b63d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java > 0472f33ec49652ef402bcb332321fb2803b923d9 > > sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java > 1a502080896b2b85e9bf6ae4780b4a2db35473f7 > sentry-provider/sentry-provider-db/pom.xml > 4751549bcc40d60ca8f5400dd371761bc6fbf2d5 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java > ae4db6a06c72a93e62bc5a3c2a17776bcb7d > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java > 0b62dae0588859bceea54b8f4b49689561a7a4f9 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java > 29e5baf8d3ecd67ae655f513eaba5a1a2bc14b9a > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java > 42293b7bbda879d87f69721cfc3f4fd533055ae2 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java > a3a660cc9d53411588c5a681b84a75a35ebc3f96 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java > 49cfe4b0057721839c442353b6441013d5d6438c > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java >
Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/ --- Review request for sentry, Alexander Kolbasov, Na Li, Steve Moist, and Sergio Pena. Bugs: SENTRY-2192 https://issues.apache.org/jira/browse/SENTRY-2192 Repository: sentry Description --- With the current thrift options used, @Generated annotation adds date which kind of updates all the thrift generated files when --thriftif option used. When someone makes some changes to any of the thrift definitions and tries to generate the source all the auto generated files get updated. This can be avoided by suppressing date in the @generated annotation. Diffs - sentry-hdfs/sentry-hdfs-common/pom.xml 5c6c96c46ee384ba5981611333741fde3bd59e10 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java ac1fa6af17239e23557614e7149c7cc911e28e12 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateRequest.java 62fd0bb2426db427241a5f805c9e250b306b4947 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java 68aec801ae7f38f8cbbe8549f5d9df79b609b114 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java 8d3297ffe6f2de4dc3dc82f82a70b5ad2a235911 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java 210d2191c38603d4a951a590eee85c8fccdde124 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java df5b7b10656102c6471885cfea73b0ed8dd67dd7 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java 9fd3924f138696707df4ab1bb5c994005b9bd1f4 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java e8c09322ac6f8b8210bc4dd8869ad3b0353b63d9 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java 0472f33ec49652ef402bcb332321fb2803b923d9 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java 1a502080896b2b85e9bf6ae4780b4a2db35473f7 sentry-provider/sentry-provider-db/pom.xml 4751549bcc40d60ca8f5400dd371761bc6fbf2d5 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java ae4db6a06c72a93e62bc5a3c2a17776bcb7d sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsRequest.java 0b62dae0588859bceea54b8f4b49689561a7a4f9 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleAddGroupsResponse.java 29e5baf8d3ecd67ae655f513eaba5a1a2bc14b9a sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java 42293b7bbda879d87f69721cfc3f4fd533055ae2 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleDeleteGroupsResponse.java a3a660cc9d53411588c5a681b84a75a35ebc3f96 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 49cfe4b0057721839c442353b6441013d5d6438c sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleGrantPrivilegeResponse.java 6890337d6262500283086abf54e19ff1450796f8 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 91793fee0f3a96a2fdec0cfecac325c65c08c999 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAlterSentryRoleRevokePrivilegeResponse.java bd7127bac0d9b03b6fef690c11fbb924029017d1 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TAuthorizable.java 6ab06f70dabcdf20140e2c1fdd3801886c4e924a sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleRequest.java 786c6437bd41d4a16013eade8b1c52e8943f92b9 sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TCreateSentryRoleResponse.java
