Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review202131 --- Ship it! Ship It! - kalyan kumar kalvagadda On April 27, 2018, 3:13 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 27, 2018, 3:13 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > ca20a39 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > 70acb89 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > eb175bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > e6dbf91 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > 989301b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > aca05bc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > a3c87bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > cce5c7c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > 169cd4d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > 986389b > > > Diff: https://reviews.apache.org/r/66764/diff/4/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
> On April 27, 2018, 3:51 p.m., kalyan kumar kalvagadda wrote: > > Lina, This index might not be needed for every database. we need it for > > Oracle database for sure. > > > > For example, mysql creates an index automaticallym when a cloumn is added > > as a foreign key. Adding a duplicate indexes is un-cecessary over head. 1)The test shows that after defining foreign key, MySql does automatically added the key fro the foreign key. KEY `AUTHZ_PATH_FK` (`AUTHZ_OBJ_ID`), 2)2) After adding index for the foreign key explicitly, the automatically created key is removed. So there is no more than one index on the same foreign key. KEY `AUTHZ_PATH_FK_IDX` (`AUTHZ_OBJ_ID`), More details in https://issues.apache.org/jira/browse/SENTRY-2210?focusedCommentId=16456708=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16456708 - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review202069 --- On April 27, 2018, 3:13 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 27, 2018, 3:13 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > ca20a39 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > 70acb89 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > eb175bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > e6dbf91 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > 989301b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > aca05bc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > a3c87bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > cce5c7c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > 169cd4d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > 986389b > > > Diff: https://reviews.apache.org/r/66764/diff/4/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review202069 --- Lina, This index might not be needed for every database. we need it for Oracle database for sure. For example, mysql creates an index automaticallym when a cloumn is added as a foreign key. Adding a duplicate indexes is un-cecessary over head. - kalyan kumar kalvagadda On April 27, 2018, 3:13 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 27, 2018, 3:13 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > ca20a39 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > 70acb89 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > eb175bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > e6dbf91 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > 989301b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > aca05bc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > a3c87bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > cce5c7c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > 169cd4d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > 986389b > > > Diff: https://reviews.apache.org/r/66764/diff/4/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review202067 --- Ship it! Ship It! - Sergio Pena On April 27, 2018, 3:13 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 27, 2018, 3:13 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > ca20a39 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > 70acb89 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > eb175bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > e6dbf91 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > 989301b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > aca05bc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > a3c87bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > cce5c7c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > 169cd4d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > 986389b > > > Diff: https://reviews.apache.org/r/66764/diff/4/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
> On April 23, 2018, 9:59 p.m., kalyan kumar kalvagadda wrote: > > You need to update the new version in SentryStoreSchemaInfo.java.Please > > make this change ans run the upgrade/install tests to make sure thay are > > fine. it is done - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201778 --- On April 27, 2018, 3:13 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 27, 2018, 3:13 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > ca20a39 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > 70acb89 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > eb175bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > e6dbf91 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > 989301b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > aca05bc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > a3c87bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > cce5c7c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > 169cd4d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > 986389b > > > Diff: https://reviews.apache.org/r/66764/diff/4/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? > > Na Li wrote: > Sergio, I don't want to take the trouble to fix the 2.1.0 versions. > However, 2.0 is already released, any schema change on top of that has to > mark it as for version 2.1.0. Is that correct? > > Sergio Pena wrote: > It's correct, but it would be easier to identify what changes for > indexing are made here. If someone wants to backport this change, there will > be conflicts because most of the changes are not ncessary except the index > changes. the version change is in sentry-2213. It is committed. This only only deals with adding index - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201960 --- On April 27, 2018, 3:13 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 27, 2018, 3:13 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > ca20a39 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > 70acb89 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > eb175bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > e6dbf91 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > 989301b > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > aca05bc > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > a3c87bd > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > cce5c7c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > 169cd4d > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > 986389b > > > Diff: https://reviews.apache.org/r/66764/diff/4/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- (Updated April 27, 2018, 3:13 p.m.) Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Repository: sentry Description --- add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH Diffs (updated) - sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql ca20a39 sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql 70acb89 sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql eb175bd sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql e6dbf91 sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql 989301b sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql aca05bc sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql a3c87bd sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql cce5c7c sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql 169cd4d sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql 986389b Diff: https://reviews.apache.org/r/66764/diff/4/ Changes: https://reviews.apache.org/r/66764/diff/3-4/ Testing --- run mysql script to verify it works on mysql SentrySchemaTool upgrade/install tests Thanks, Na Li
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? > > Na Li wrote: > Sergio, I don't want to take the trouble to fix the 2.1.0 versions. > However, 2.0 is already released, any schema change on top of that has to > mark it as for version 2.1.0. Is that correct? It's correct, but it would be easier to identify what changes for indexing are made here. If someone wants to backport this change, there will be conflicts because most of the changes are not ncessary except the index changes. - Sergio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201960 --- On April 23, 2018, 10:56 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 23, 2018, 10:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > f1a5b10 > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 > 5ae9349 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle > 770e1b5 > > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres > 770e1b5 > > > Diff: https://reviews.apache.org/r/66764/diff/3/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? Sergio, I don't want to take the trouble to fix the 2.1.0 versions. However, 2.0 is already released, any schema change on top of that has to mark it as for version 2.1.0. Is that correct? - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201960 --- On April 23, 2018, 10:56 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 23, 2018, 10:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > f1a5b10 > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 > 5ae9349 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle > 770e1b5 > > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres > 770e1b5 > > > Diff: https://reviews.apache.org/r/66764/diff/3/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201960 --- Lina, would it be better to create another patch to fix the 2.1.0 versions? So we can have this patch to add the index only instead of several new files, what do you think? - Sergio Pena On April 23, 2018, 10:56 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 23, 2018, 10:56 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > f1a5b10 > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 > 5ae9349 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle > 770e1b5 > > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres > 770e1b5 > > > Diff: https://reviews.apache.org/r/66764/diff/3/ > > > Testing > --- > > run mysql script to verify it works on mysql > SentrySchemaTool upgrade/install tests > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- (Updated April 23, 2018, 10:56 p.m.) Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Repository: sentry Description --- add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH Diffs - sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java f1a5b10 sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 5ae9349 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres 770e1b5 Diff: https://reviews.apache.org/r/66764/diff/3/ Testing (updated) --- run mysql script to verify it works on mysql SentrySchemaTool upgrade/install tests Thanks, Na Li
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- (Updated April 23, 2018, 10:03 p.m.) Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Repository: sentry Description --- add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH Diffs (updated) - sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java f1a5b10 sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 5ae9349 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres 770e1b5 Diff: https://reviews.apache.org/r/66764/diff/3/ Changes: https://reviews.apache.org/r/66764/diff/2-3/ Testing --- run mysql script to verify it works on mysql Thanks, Na Li
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201778 --- You need to update the new version in SentryStoreSchemaInfo.java.Please make this change ans run the upgrade/install tests to make sure thay are fine. - kalyan kumar kalvagadda On April 23, 2018, 9:11 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 23, 2018, 9:11 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 > 5ae9349 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle > 770e1b5 > > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres > 770e1b5 > > > Diff: https://reviews.apache.org/r/66764/diff/2/ > > > Testing > --- > > run mysql script to verify it works on mysql > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- (Updated April 23, 2018, 9:11 p.m.) Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Repository: sentry Description --- add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH Diffs - sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 5ae9349 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres 770e1b5 Diff: https://reviews.apache.org/r/66764/diff/2/ Testing (updated) --- run mysql script to verify it works on mysql Thanks, Na Li
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- (Updated April 23, 2018, 9:10 p.m.) Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Repository: sentry Description --- add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH Diffs (updated) - sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 5ae9349 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres 770e1b5 Diff: https://reviews.apache.org/r/66764/diff/2/ Changes: https://reviews.apache.org/r/66764/diff/1-2/ Testing --- Thanks, Na Li
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
> On April 23, 2018, 8:46 p.m., Arjun Mishra wrote: > > Ship It! Do we have any tests to show improvement in both select and insert type queries? - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201764 --- On April 23, 2018, 8:16 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 23, 2018, 8:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 > 5ae9349 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle > 770e1b5 > > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres > 770e1b5 > > > Diff: https://reviews.apache.org/r/66764/diff/1/ > > > Testing > --- > > > Thanks, > > Na Li > >
Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review201764 --- Ship it! Ship It! - Arjun Mishra On April 23, 2018, 8:16 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66764/ > --- > > (Updated April 23, 2018, 8:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar > kalvagadda, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH > > > Diffs > - > > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 > 5ae9349 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql > 770e1b5 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle > 770e1b5 > > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres > 770e1b5 > > > Diff: https://reviews.apache.org/r/66764/diff/1/ > > > Testing > --- > > > Thanks, > > Na Li > >
Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena. Repository: sentry Description --- add index for the foreign key AUTHZ_OBJ_ID on table AUTHZ_PATH Diffs - sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.derby.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.mysql.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.oracle.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/010-SENTRY-2210.postgres.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-2.0.0-to-2.1.0.sql PRE-CREATION sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 5ae9349 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle 770e1b5 sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres 770e1b5 Diff: https://reviews.apache.org/r/66764/diff/1/ Testing --- Thanks, Na Li
