[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179941587 ## File path: metrics/metrics-core/src/main/java/com/netflix/spectator/api/patterns/ThreadPoolMonitorPublishModelFactory.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.netflix.spectator.api.patterns; Review comment: yes ThreadPoolMonitor.TASK_COUNT and so on, is package visible This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179932881
##
File path:
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestClientPool.java
##
@@ -17,43 +17,16 @@
package org.apache.servicecomb.serviceregistry.client.http;
-import org.apache.servicecomb.serviceregistry.config.ServiceRegistryConfig;
import org.junit.Test;
-import io.vertx.core.http.HttpVersion;
-import mockit.Mock;
-import mockit.MockUp;
-
public class TestClientPool {
@Test
public void testHttpClientPool() {
-new MockUp() {
- @Mock
- public HttpVersion getHttpVersion() {
-return HttpVersion.HTTP_2;
- }
-
- @Mock
- public boolean isSsl() {
-return true;
- }
-};
HttpClientPool.INSTANCE.create();
Review comment:
done
add new test cases for it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179932884
##
File path:
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestDefaultRegistryInitializer.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.metrics.core;
+
+import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
+import org.hamcrest.Matchers;
+import org.junit.Assert;
+import org.junit.Test;
+
+import com.google.common.eventbus.EventBus;
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.ManualClock;
+import com.netflix.spectator.api.SpectatorUtils;
+import com.netflix.spectator.servo.ServoRegistry;
+
+public class TestDefaultRegistryInitializer {
+ CompositeRegistry globalRegistry =
SpectatorUtils.createCompositeRegistry(new ManualClock());
+
+ DefaultRegistryInitializer registryInitializer = new
DefaultRegistryInitializer();
+
+ @Test
+ public void init() {
+registryInitializer.init(globalRegistry, new EventBus(), new
MetricsBootstrapConfig());
+
+Assert.assertEquals(-10, registryInitializer.getOrder());
+Assert.assertThat(registryInitializer.getRegistry(),
Matchers.instanceOf(ServoRegistry.class));
+
+registryInitializer.uninit();
Review comment:
doen
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179768362
##
File path:
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestDefaultRegistryInitializer.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.metrics.core;
+
+import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
+import org.hamcrest.Matchers;
+import org.junit.Assert;
+import org.junit.Test;
+
+import com.google.common.eventbus.EventBus;
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.ManualClock;
+import com.netflix.spectator.api.SpectatorUtils;
+import com.netflix.spectator.servo.ServoRegistry;
+
+public class TestDefaultRegistryInitializer {
+ CompositeRegistry globalRegistry =
SpectatorUtils.createCompositeRegistry(new ManualClock());
+
+ DefaultRegistryInitializer registryInitializer = new
DefaultRegistryInitializer();
+
+ @Test
+ public void init() {
+registryInitializer.init(globalRegistry, new EventBus(), new
MetricsBootstrapConfig());
+
+Assert.assertEquals(-10, registryInitializer.getOrder());
+Assert.assertThat(registryInitializer.getRegistry(),
Matchers.instanceOf(ServoRegistry.class));
+
+registryInitializer.uninit();
Review comment:
just want to test init at start
when add uninit funcation, forgot add test case for it, i will add new
verification.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179767736
##
File path:
service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestClientPool.java
##
@@ -17,43 +17,16 @@
package org.apache.servicecomb.serviceregistry.client.http;
-import org.apache.servicecomb.serviceregistry.config.ServiceRegistryConfig;
import org.junit.Test;
-import io.vertx.core.http.HttpVersion;
-import mockit.Mock;
-import mockit.MockUp;
-
public class TestClientPool {
@Test
public void testHttpClientPool() {
-new MockUp() {
- @Mock
- public HttpVersion getHttpVersion() {
-return HttpVersion.HTTP_2;
- }
-
- @Mock
- public boolean isSsl() {
-return true;
- }
-};
HttpClientPool.INSTANCE.create();
Review comment:
oh, yes.
i only confirmed with author and deleted useless code, did not realize this
is not a effective test case
and the next case have the same problem.
i will confirmed with author again.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179764368 ## File path: metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestAnMonitorManager.java ## @@ -41,7 +41,7 @@ private static MetricsLoader currentWindowMetricsLoader; - private static MetricsLoader nextWindowMetricsLoader; + // private static MetricsLoader nextWindowMetricsLoader; Review comment: cause random UT failed. this class, and related classes will be deleted in the next PR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
