[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

[Julian Sedding (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292890#comment-16292890
 ] 

Julian Sedding commented on SLING-7313:
---

Thanks [~kwin] for looking onto this. I haven't had time to test it yet. My 
solution would have looked very similar to yours, I decided to omit the 
try/catch and allow it to throw a {{RuntimeException}} (which should not happen 
anyways, I assume?).

> ResourceResolverImpl#refresh should also refresh the internal 
> resourceTyperesourceResolver
> --
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.32
>Reporter: Julian Sedding
>Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see 
> attachment) and traced them back to a long-lived service {{ResourceResolver}} 
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to 
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}} 
> call is not propagated to the internal {{resourceTypeResourceResolver}} used 
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think 
> we should also refresh the internal {{resourceTypeResourceResolver}} used by 
> {{ResourceResolverImpl}} when RR is refreshed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[feature model] Format of text section - repoinit and others

[Robert Munteanu]

Hi,

While working some more with the feature model I realized that text
sections can not contain newlines - this is a limitation of JSON.

This makes it very hard to work with repoinit sections. I end up with
(literally) 10k characters on a single line. Diffs are going to be
interesting with such formats :-)

I think it would help adoption a lot if we have a more friendly format
for text entries.

One option would be to have lines stored as an array, e.g.

  "repoinit:TEXT|false": [
"create path (sling:Folder) /libs",
"create path (sling:Folder) /apps",
"create path (sling:Folder) /tmp"
  ]

Not that nice, but it keeps the file self-contained.

Another option would be to keep a secondary text file around and 
introduce a new field type, file:

  "repoinit:FILE": "./repoinit.txt"

This has the disadvantage of no longer having the configuration be
self-contained, but on the other hand it's a text file, which the
repoinit format was built for.

The third option - for the sake of being complete - is to have a
structured JSON format for repoint, but IMO that's overkill. Something
like:

  "repoinit": {
"paths": [
"/libs (sling:Folder)",
"/apps (sling:Folder)",
"/tmp (sling:Folder)"
]
   }

Thoughts? I think the feature model approach is great, but we need to
improve on the usability of text sections.

Thanks,

Robert

Search for specific resource types

[Konrad Windszus]

Hi,
is there a simple way to search with Sling Resource API for resources which 
have a certain resource type "a" or a resource type derived from "a".
The resource type inheritance in Sling is a pretty powerful concept. I am 
wondering how to properly support that when searching for content which is 
either of resource type a directly or a derived resource type.

I cannot really think of a JCR SQL2 or XPath expression which would also cover 
derived resource types (without knowing them in advance).
Thanks for any pointers,
Konrad

[jira] [Commented] (SLING-7296) Add documentation for all environment variables being support by Apache Sling Server Setup Tools

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292697#comment-16292697
 ] 

Konrad Windszus commented on SLING-7296:


A nice list which can probably be used as basis can be found in 
http://labs.6dglobal.com/blog/2013-06-05/creating-integration-tests-apache-sling/.

> Add documentation for all environment variables being support by Apache Sling 
> Server Setup Tools
> 
>
> Key: SLING-7296
> URL: https://issues.apache.org/jira/browse/SLING-7296
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Apache Sling Server Setup Tools 1.0.1
>Reporter: Konrad Windszus
>
> Currently there is no documentation about the Server Setup Tools. The page at 
> https://sling.apache.org/documentation/development/sling-testing-tools.html#integration-tests-example
>  is heavily outdated and only contains some references to the now deprecated 
> testing.tools. That page should be updated and a table with all supported 
> environment variables should be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292641#comment-16292641
 ] 

Konrad Windszus commented on SLING-7297:


Thanks, can you add the fix-version?

> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[Andrei Dulvac (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292636#comment-16292636
 ] 

Andrei Dulvac commented on SLING-7297:
--

I had a look and merged the PR. Thanks. 

> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292633#comment-16292633
 ] 

ASF GitHub Bot commented on SLING-7297:
---

dulvac closed pull request #3: SLING-7297 add methods to wait for a component 
to be registered and a
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/3
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292631#comment-16292631
 ] 

ASF GitHub Bot commented on SLING-7297:
---

dulvac commented on issue #3: SLING-7297 add methods to wait for a component to 
be registered and a
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/3#issuecomment-352022933
 
 
   Looks great. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[Andrei Dulvac (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292600#comment-16292600
 ] 

Andrei Dulvac commented on SLING-7297:
--

@kwin, I'll do that later today. Thanks! 

> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-7297:
--

Assignee: (was: Konrad Windszus)

> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292403#comment-16292403
 ] 

Konrad Windszus commented on SLING-7297:


[~andrei.dulvac] Can you have a look at the attached PR?

> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7297:
---
Affects Version/s: (was: Apache Sling Testing Clients 1.1.4)
   Apache Sling Testing Clients 1.1.12

> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.12
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7297) OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7297:
---
Description: 
Sometimes in an IT you need to wait for a specific OSGi component or service to 
be available (i.e. active). Just waiting for the bundle is not necessarily 
enough, as the contained services/components might not yet have been started. 
Therefore having the following additional two methods would be beneficial: 
# {{waitComponentRegistered(String componentName, long, long}} to wait until 
the component with given name is active and 
# {{waitServiceRegistered(String Type, String bundleSymbolicName, long, long)}} 
to wait until a service of the given type is available. If the 
bundleSymbolicName is not null it should also check that this service is being 
registered from the given bundle.

The following ReST calls against the Apache Felix WebConsole can be used to 
check for that.
{{/system/console/components/.json}} returns metadata about a 
specific component. All services are listed via 
{{/system/console/services.json}}. This can be used to extract information 
about a specific service.

Unfortunately there is not yet the possibility to extract services by type 
(FELIX-5761).

See also the related discussion at: 
https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html

  was:
Sometimes in an IT you need to wait for a specific OSGi component or service to 
be available (i.e. active). Just waiting for the bundle is not necessarily 
enough, as the contained services/components might not yet have been started. 
Therefore having the following additional two methods would be beneficial: 
# {{waitComponentActive(String componentName, long, long}} to wait until the 
component with given name is active and 
# {{waitServiceAvailable(String serviceType, String bundleSymbolicName, long, 
long)}} to wait until a service of the given type is available. If the 
bundleSymbolicName is not null it should also check that this service is being 
registered from the given bundle.

The following ReST calls against the Apache Felix WebConsole can be used to 
check for that.
{{/system/console/components/.json}} returns metadata about a 
specific component. All services are listed via 
{{/system/console/services.json}}. This can be used to extract information 
about a specific service.

See also the related discussion at: 
https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html


> OSGiConsoleClient: Add methods to wait for OSGi components and OSGi services
> 
>
> Key: SLING-7297
> URL: https://issues.apache.org/jira/browse/SLING-7297
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 1.1.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>
> Sometimes in an IT you need to wait for a specific OSGi component or service 
> to be available (i.e. active). Just waiting for the bundle is not necessarily 
> enough, as the contained services/components might not yet have been started. 
> Therefore having the following additional two methods would be beneficial: 
> # {{waitComponentRegistered(String componentName, long, long}} to wait until 
> the component with given name is active and 
> # {{waitServiceRegistered(String Type, String bundleSymbolicName, long, 
> long)}} to wait until a service of the given type is available. If the 
> bundleSymbolicName is not null it should also check that this service is 
> being registered from the given bundle.
> The following ReST calls against the Apache Felix WebConsole can be used to 
> check for that.
> {{/system/console/components/.json}} returns metadata about a 
> specific component. All services are listed via 
> {{/system/console/services.json}}. This can be used to extract information 
> about a specific service.
> Unfortunately there is not yet the possibility to extract services by type 
> (FELIX-5761).
> See also the related discussion at: 
> https://mail.osgi.org/pipermail/osgi-dev/2017-December/006638.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7314) Dry run not working

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7314:
--

Assignee: Nicolas Peltier

> Dry run not working
> ---
>
> Key: SLING-7314
> URL: https://issues.apache.org/jira/browse/SLING-7314
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Honwai Wong
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> I worked with [~npeltier] to define a pipe to perform content migration, see 
> below for an example of this pipe:
> {code}
> def plumber = getService("org.apache.sling.pipes.Plumber");
> plumber.newPipe(resourceResolver)
> .echo('/content/foo/bar').name('startPath')
> .mv('${path.startPath.replace("/bar", "/xyz")}')
> .parent().name('parentContent')
> .mkdir('${path.parentContent}/bar').with('nodeType', 
> 'nt:unstructured').name('targetResource')
> .write('sling:resourceType', 'test/components/somecomponent')
> .echo('${path.parentContent}/xyz')
> .mv('${path.targetResource}/xyz')
> .runWith("dryRun", "true");
> {code}
> However, the {{dryRun}} argument is not taken into account, the changes are 
> actually persisted in the repository.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] kwin commented on a change in pull request #1: SLING-7299 do not always attach built artifact

[GitBox]

kwin commented on a change in pull request #1: SLING-7299 do not always attach 
built artifact
URL: 
https://github.com/apache/sling-slingstart-maven-plugin/pull/1#discussion_r157144904
 
 

 ##
 File path: src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java
 ##
 @@ -51,6 +52,13 @@
  */
 @Parameter(defaultValue="false")
 protected boolean createWebapp;
+
+/**
+ * If set to {@code true} does not attach the generated artifact to Maven.
 
 Review comment:
   Good catch, fixed with 
https://github.com/apache/sling-slingstart-maven-plugin/commit/d6203e5aaadc1ad10bc11625bf7f8f1d92299da3.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] raducotescu commented on a change in pull request #1: SLING-7299 do not always attach built artifact

[GitBox]

raducotescu commented on a change in pull request #1: SLING-7299 do not always 
attach built artifact
URL: 
https://github.com/apache/sling-slingstart-maven-plugin/pull/1#discussion_r157144422
 
 

 ##
 File path: src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java
 ##
 @@ -51,6 +52,13 @@
  */
 @Parameter(defaultValue="false")
 protected boolean createWebapp;
+
+/**
+ * If set to {@code true} does not attach the generated artifact to Maven.
 
 Review comment:
   I think you need to change the JavaDoc here with `{@code false}`, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7299) slingstart-maven-plugin: Do not always attach artifact in goal "package"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292190#comment-16292190
 ] 

ASF GitHub Bot commented on SLING-7299:
---

raducotescu commented on a change in pull request #1: SLING-7299 do not always 
attach built artifact
URL: 
https://github.com/apache/sling-slingstart-maven-plugin/pull/1#discussion_r157144422
 
 

 ##
 File path: src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java
 ##
 @@ -51,6 +52,13 @@
  */
 @Parameter(defaultValue="false")
 protected boolean createWebapp;
+
+/**
+ * If set to {@code true} does not attach the generated artifact to Maven.
 
 Review comment:
   I think you need to change the JavaDoc here with `{@code false}`, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> slingstart-maven-plugin: Do not always attach artifact in goal "package"
> 
>
> Key: SLING-7299
> URL: https://issues.apache.org/jira/browse/SLING-7299
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Slingstart Maven Plugin 1.7.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Slingstart Maven Plugin 1.7.12
>
>
> In case the packaging is not {{slingstart}} that generated artifact is still 
> attached to the project (and therefore potentially also deployed via mvn 
> deploy) 
> (https://github.com/apache/sling-slingstart-maven-plugin/blob/master/src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java#L95).
>  This is not desired in case the model is only used for running a local IT 
> against the server being generated from the model. Therefore there should be 
> an additional parameter which prevents the artifact from being attached.
> Since the attached artifact is currently also used from goal {{start}} 
> (https://github.com/apache/sling-slingstart-maven-plugin/blob/master/src/main/java/org/apache/sling/maven/slingstart/run/StartMojo.java#L396)
>  there must be another way introduced to detect slingstart artifacts which 
> have been generated through the same maven build by a previous step.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Authentication Service 1.4.2

[Radu Cotescu]

+1

On Fri, 15 Dec 2017 at 08:14 Antonio Sanso  wrote:

> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Authentication Service 1.4.2

[Robert Munteanu]

On Fri, 2017-12-15 at 07:13 +, Antonio Sanso wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part