Re: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6 and Apache Sling Query version 4.0.2

[Jason E Bailey]

I have two keys in the asc file. I need to open a ticket with infra to figure 
out how to remove the shorter one. I'm assuming that's the problem.


- Jason

Re: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6 and Apache Sling Query version 4.0.2

[Daniel Klco]

Hm, I'm getting GPG errors...


  CHECK SIGNATURES AND
DIGESTS

/tmp/sling-staging/1897/org/apache/sling/index.html.tmp
gpg:  
md5 : 
sha1 : 
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/index.html.tmp
gpg:  
md5 : 
sha1 : 
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/maven-metadata.xml
gpg:  
md5 : GOOD (a7706a7ee9d876d2976f09e1123b8e38)
sha1 : GOOD (2d2809a468153b50241a7f6a7ca6ff778eddc4e8)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/4.0.2/org.apache.sling.query-4.0.2.jar
gpg:  BAD
md5 : GOOD (dbf90e3cc8126a0f3d2eb130750e7679)
sha1 : GOOD (0801831664d3cdb6f8b9bdcd6c33ff6121407c6b)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/4.0.2/org.apache.sling.query-4.0.2-source-release.zip
gpg:  BAD
md5 : GOOD (1912ba15ed14460bf36cadaa3479a83a)
sha1 : GOOD (ab4f6fa29e343ebe7cc06ef8a2ce396db8db513b)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/4.0.2/index.html.tmp
gpg:  
md5 : 
sha1 : 
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/4.0.2/org.apache.sling.query-4.0.2.pom
gpg:  BAD
md5 : GOOD (6340e9ba5a72a2d0be69a4cc4894fe84)
sha1 : GOOD (a3d72fde160150f0851384e78612bf0e3c29a6e9)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/4.0.2/org.apache.sling.query-4.0.2-sources.jar
gpg:  BAD
md5 : GOOD (4b2b9b8271b17ba1569aebe155e71148)
sha1 : GOOD (87af5dbb7ffac9a77be636c3500bb8fa7d73a531)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.query/4.0.2/org.apache.sling.query-4.0.2-javadoc.jar
gpg:  BAD
md5 : GOOD (72a03851ed3905aa9a16cfbbfc09f4b9)
sha1 : GOOD (d5f0df25da04558bd12be4e35e418027d399a1d5)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/index.html.tmp
gpg:  
md5 : 
sha1 : 
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/maven-metadata.xml
gpg:  
md5 : GOOD (4f5dceaa2143378ffa3d5ac4b6f960b8)
sha1 : GOOD (379bddfb27a6f484e50adc59580515eb9f10f242)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/1.2.6/org.apache.sling.jcr.contentparser-1.2.6-source-release.zip
gpg:  BAD
md5 : GOOD (f7710e1cc9226fcd8e89bae8ceffc0be)
sha1 : GOOD (c7fca8fcea6270f3978ef73e949b77f7ab880532)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/1.2.6/org.apache.sling.jcr.contentparser-1.2.6.pom
gpg:  BAD
md5 : GOOD (8622e1fd6354bfe1329b85c4647903db)
sha1 : GOOD (75e6332dd48f4f1a60277d91d269dec801de7cee)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/1.2.6/org.apache.sling.jcr.contentparser-1.2.6-sources.jar
gpg:  BAD
md5 : GOOD (8be56140dee0a39ada2cc986529cdb7c)
sha1 : GOOD (89c5baf0774e8ae9a1e0d233528b5313a3bea585)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/1.2.6/org.apache.sling.jcr.contentparser-1.2.6-javadoc.jar
gpg:  BAD
md5 : GOOD (8d7f8da5789431b1dacc3aff3b5f39ca)
sha1 : GOOD (33e02c0e0955185c7c3c5fa59cbbdf0208d20f6c)
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/1.2.6/index.html.tmp
gpg:  
md5 : 
sha1 : 
/tmp/sling-staging/1897/org/apache/sling/org.apache.sling.jcr.contentparser/1.2.6/org.apache.sling.jcr.contentparser-1.2.6.jar
gpg:  BAD
md5 : GOOD (54eb0fe6df701cb9f7a5973a56984720)
sha1 : GOOD (a9a241ee413b578b214d212e552826b2afb7d512)


Anyone else having issues? not sure if it's something about my setup. I
just re-imported the sling keys from
https://people.apache.org/keys/group/sling.asc and still got the same issue.

Regards,
Dan

On Thu, May 3, 2018 at 7:25 AM, Radu Cotescu  wrote:

> +1 (only checked signatures)
>
> > On 2 May 2018, at 17:30, Jason E Bailey  wrote:
> >
> > Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
>
>

Re: [DISCUSSION] Make Sling shiny - Basic CMS

[Daniel Klco]

I've been refining the Sling CMS example over the last couple months.
Recently, I switched it over to use CA Configs rather than the /etc based
configurations, made some minor UI tweaks and drastically improved
reordering sibling resources.

I also added some more reference components (RTE, lists, rss, sitemap,
containers, column control, image block, etc:
https://github.com/apache/sling-whiteboard/tree/master/cms/reference/src/main/resources/jcr_root/apps/reference/components/general)
and added a default configuration, so you can immediately start using the
tool to create something like sling.apache.org. You can see how easy it is
to get started with your first page here:

https://www.danklco.com/images/Sling-CMS.gif

And speaking of which, I re-wrote my personal site to run on Sling CMS.
It's running on a very underpowered Google Computer Engine F1-Micro
instance, so please be nice to it. I suspect it would run pretty well on a
g1-small or equivalent server, but I have not had a chance to validate.

You can find the code for my site application here:

https://github.com/klcodanr/danklco.com-site/tree/sling-cms

Right now Sling CMS is using a number of unreleased dependencies, so the
easiest route to check it out is to download the JAR from the Apache
Snapshots Repo:

https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.cms.builder/1.0.0-SNAPSHOT/org.apache.sling.cms.builder-1.0.0-20180503.214823-11.jar

I'm thinking that I'd like to get this moved into the Sling Samples repo or
potentially a separate repo shortly. The only one additional thing I'd like
to figure out is getting a HTML5 rewriting pipeline. Is anyone aware of a
HTML5 Rewriting pipeline implementation? It seems like the default one is
HTML4.

Regards,
Dan

On Fri, Mar 2, 2018 at 4:33 PM, Daniel Klco  wrote:

>
>
> On Fri, Mar 2, 2018 at 7:26 AM, Ioan Eugen Stan 
> wrote:
>
>> Hi,
>>
>> > Yep, indeed. Currently I'm working on building out some reference
>> > components like search, lists, column controls, text editors, etc.
>> That would be awesome. We would like to use such components in our setup
>> and we might help with some development and maintenance along the way.
>> That would take some time dough.
>>
>
> Yep. I've made some of these, but it's still pretty basic and some are a
> bit clunky.
>
>
>>
>> IMO we should be able to make the artifacts available as part of a
>> release process.
>>
>
> Absolutely. I'm thinking that these could be a standalone related project
> so it can be versioned separately from the CMS as a whole.
>
>
>> Is this part of the apache project or a you private project. I'm asking
>> because I would like to do some work in that direction (release as often
>> as possible).
>>
>
> It's in the Sling Whiteboard:
> https://github.com/apache/sling-whiteboard/tree/master/cms
>
>
>> >> - is there any relationship between sling-cms and Composum? It seems to
>> >> me like both projects are heading in a similar direction and a
>> >> colaboration might be beneficial. Composum provides Composum assests,
>> >> Composum Pages, etc. That functionality could be reused.
>> >>
>> > Not at the moment, I did add in Compsum for the package and node
>> explorer
>> > capabilities, but I didn't realize Compsum Pages and Assets were so far
>> > along.
>> >
>> Have you had time to check them out? Can Sling CMS use those compnents?
>> Will they be used instead of internal/custom ones?
>>
>
>  I've looked through the documentation for Composum Pages / Assets. It
> looks like they have taken a different approach, but the assets in
> particular is really nice. I'll try to download it soon and check it out.
>
>

[jira] [Resolved] (SLING-7649) Sling Pages Do Not Display Full Height in Firefox

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7649.
-
   Resolution: Fixed
 Assignee: Dan Klco
Fix Version/s: (was: Launchpad Content 2.0.14)
   Starter Content 1.0.0

Resolved by updating:

 

Starter Startup: 
[https://github.com/apache/sling-org-apache-sling-starter-startup/commit/f389a9d883ddb22a00c7d9d4d4132f15d77e]

Starter Content:

[https://github.com/apache/sling-org-apache-sling-starter-content/commit/49da64fe6d91e10465e35c08eea73dc64f06371c]

 

> Sling Pages Do Not Display Full Height in Firefox
> -
>
> Key: SLING-7649
> URL: https://issues.apache.org/jira/browse/SLING-7649
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Launchpad Content 2.0.12, Starter Startup 1.0.4
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: Starter Content 1.0.0, Starter Startup 1.0.6
>
> Attachments: Screen Shot 2018-05-03 at 3.45.30 PM.png
>
>
> The Login, Loading and other screens do not display at full height when using 
> Firefox due to the Style sheet not setting the height to 100%.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7649) Sling Pages Do Not Display Full Height in Firefox

[Dan Klco (JIRA)]

Dan Klco created SLING-7649:
---

 Summary: Sling Pages Do Not Display Full Height in Firefox
 Key: SLING-7649
 URL: https://issues.apache.org/jira/browse/SLING-7649
 Project: Sling
  Issue Type: Bug
Affects Versions: Starter Startup 1.0.4, Launchpad Content 2.0.12
Reporter: Dan Klco
 Fix For: Starter Startup 1.0.6, Launchpad Content 2.0.14
 Attachments: Screen Shot 2018-05-03 at 3.45.30 PM.png

The Login, Loading and other screens do not display at full height when using 
Firefox due to the Style sheet not setting the height to 100%.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7648) Sling Post Servlet Throws NullPointerException On :order Last

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7648.
-
Resolution: Fixed

Resolved in 
https://github.com/apache/sling-org-apache-sling-servlets-post/commit/c719cfb122e9d2bcd54e16e0d95b3f5e278dee9a

> Sling Post Servlet Throws NullPointerException On :order Last
> -
>
> Key: SLING-7648
> URL: https://issues.apache.org/jira/browse/SLING-7648
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Servlets Post 2.3.24
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Servlets Post 2.3.26
>
> Attachments: nullpointer.log
>
>
> When using the SlingPostServlet to reorder a resource to the last position 
> (either by the "last" string or index) among it's siblings the request throws 
> a NullPointerException when the JSONResponse attempts to build the response. 
> This seems to be due to an unexpected null argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7648) Sling Post Servlet Throws NullPointerException On :order Last

[Dan Klco (JIRA)]

Dan Klco created SLING-7648:
---

 Summary: Sling Post Servlet Throws NullPointerException On :order 
Last
 Key: SLING-7648
 URL: https://issues.apache.org/jira/browse/SLING-7648
 Project: Sling
  Issue Type: Improvement
Affects Versions: Servlets Post 2.3.24
Reporter: Dan Klco
 Fix For: Servlets Post 2.3.26
 Attachments: nullpointer.log

When using the SlingPostServlet to reorder a resource to the last position 
(either by the "last" string or index) among it's siblings the request throws a 
NullPointerException when the JSONResponse attempts to build the response. This 
seems to be due to an unexpected null argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7648) Sling Post Servlet Throws NullPointerException On :order Last

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco reassigned SLING-7648:
---

Assignee: Dan Klco

> Sling Post Servlet Throws NullPointerException On :order Last
> -
>
> Key: SLING-7648
> URL: https://issues.apache.org/jira/browse/SLING-7648
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Servlets Post 2.3.24
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Servlets Post 2.3.26
>
> Attachments: nullpointer.log
>
>
> When using the SlingPostServlet to reorder a resource to the last position 
> (either by the "last" string or index) among it's siblings the request throws 
> a NullPointerException when the JSONResponse attempts to build the response. 
> This seems to be due to an unexpected null argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] stefanseifert commented on issue #2: Fix OSGi package export version

[GitBox]

stefanseifert commented on issue #2: Fix OSGi package export version
URL: 
https://github.com/apache/sling-org-apache-sling-query/pull/2#issuecomment-386365705
 
 
   the way it was before the PR the version from the package-info files got 
ignored, because of the explicit declaration of the maven bundle plugin:
   ```
   
 
   
!*,org.apache.sling.query,org.apache.sling.query.api
 
   
   ```
   
   if we want to keep this notation we would need to add the package version to 
the export package statement here. but using package-info files is far more 
intuitive and used in most of the other sling modules. so it thought it's good 
to keep the practise if hiding the private package by the convention of adding 
"impl" or "internal" to the package name and let the maven bundle plugin do the 
rest (which is the usual pattern in the other sling modules - at least when 
they are not converted to the bnd-maven-plugin).
   
   anyway for a developer it's also helpful to see clearly from the package 
name if it's private or public class.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] trekawek commented on issue #2: Fix OSGi package export version

[GitBox]

trekawek commented on issue #2: Fix OSGi package export version
URL: 
https://github.com/apache/sling-org-apache-sling-query/pull/2#issuecomment-386364435
 
 
   @stefanseifert - thanks for looking into this!
   
   I understand that the manual exports are redundant, as the bundle plugin is 
able to export all the packages with `package-info.java` automatically. Manual 
export also breaks the package versioning, right?
   
   Could you explain why it's also required to move the other classes into the 
`impl` package? Is it treated in some special way as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] trekawek commented on issue #2: Fix OSGi package export version

[GitBox]

trekawek commented on issue #2: Fix OSGi package export version
URL: 
https://github.com/apache/sling-org-apache-sling-query/pull/2#issuecomment-386364435
 
 
   @stefanseifert - thanks for looking into this!
   
   I understand that the manual exports are reduntant, as the bundle plugin is 
able to export all the packages with `package-info.java` automatically.
   
   Could you explain why it's also required to move the other classes into the 
`impl` package? Is it treated in some special way as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] trekawek commented on issue #2: Fix OSGi package export version

[GitBox]

trekawek commented on issue #2: Fix OSGi package export version
URL: 
https://github.com/apache/sling-org-apache-sling-query/pull/2#issuecomment-386364435
 
 
   @stefanseifert - thanks for looking into this!
   
   I understand that the manual exports are redundant, as the bundle plugin is 
able to export all the packages with `package-info.java` automatically.
   
   Could you explain why it's also required to move the other classes into the 
`impl` package? Is it treated in some special way as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7621) Regex path matching in Sling Dynamic Include

[Marek Krokosinski (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462750#comment-16462750
 ] 

Marek Krokosinski commented on SLING-7621:
--

That's great to hear that. 

Thanks for the fixes, and about the whitespaces, sorry, I couldn't find the 
proper formatting rules.

Do you know when it will be available on some maven repository as released 
version? I see that the fix version was set to 3.0.2.

> Regex path matching in Sling Dynamic Include
> 
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example 
> of such external content are AEM Experience Fragments or Content Fragments, 
> or Zen Garden Snippets.
>  Sometimes such 3rd party content can be categorized into two categories:
>  * not included by SDI - content which should not be included separately (for 
> example when content requires page context)
>  * included by SDI - content which is static, so it can be cached because it 
> does not change often (header, footer), or because it changes once per week 
> and we don't want to invalidate whole cache.
> Example content structure:
>  * /content/my-site/my-micro-site/en_gl/content/fragments/
>  * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British 
> market, German market etc.), and we would want to include that 3rd party 
> content using SDI, we would have to provide one Sling Dynamic Include 
> configuration per market.
>  As you may know, one site can have 100 or more markets, it means at least 
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the 
> path.
>  Currently SDI checks if requested resource path starts from the configured 
> path. 
>  Instead of simple check with startsWith, SDI should support regular 
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path 
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for 
> Configuration and ConfigurationWhiteboard classes.
>  
> Pull request: 
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7636) Some login ITs fail

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462711#comment-16462711
 ] 

Bertrand Delacretaz commented on SLING-7636:


https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/3750eb05dc038544ba155d91de8991114077ac0c
 fixes {{PostToRootTest}} - the POST behavior has slightly changed though, will 
discuss on the dev list.

> Some login ITs fail
> ---
>
> Key: SLING-7636
> URL: https://issues.apache.org/jira/browse/SLING-7636
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Reporter: Robert Munteanu
>Priority: Major
>  Labels: sling-IT
>
> Some for the Login ITs fail
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLoginErrorTest.testGetDefaultLoginPage
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.AnonymousAccessTest.testAnonymousContent
> The common root cause seems to be not finding resources where expected:
> * Expected 20x or 30x status, got 404
> * http://localhost:41000/system/sling/login expected:<200> but was:<404>
> * Expected status 200 for 
> http://localhost:41000/AnonymousAccessTest/1525143663600/test_text_1525143663.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-6783) Updates for Commons HTML

[Jason E Bailey (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462390#comment-16462390
 ] 

Jason E Bailey edited comment on SLING-6783 at 5/3/18 4:17 PM:
---

[EDIT] I don't see any additional reason to support any other Parser properties 
at this time unless there was an ask. I'd rather focus on HTML compliance.


was (Author: jebailey):
We should either support them or at least document what is and isn't supported 
from a features perspective. At this point I would just say documentation, I'm 
much more interested in finding a way to make this html5 compliant then 
features that no one has yet asked for.

> Updates for Commons HTML
> 
>
> Key: SLING-6783
> URL: https://issues.apache.org/jira/browse/SLING-6783
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Jason E Bailey
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: Commons HTML 1.0.2
>
> Attachments: sling.patch
>
>
> Following updates:
> Updated tagsoup lib to 1.2.1 which has the following modifications
> * DOCTYPE is now recognized even in lower case.
> * We make sure to buffer the reader, eliminating a long-standing bug that 
> would crash on certain inputs, such as & followed by CR+LF.
> * The HTML scanner's table is precompiled at run time for efficiency, causing 
> a 4x speedup on large input documents.
> * ]] within a CDATA section no longer causes input to be discarded.
> * Remove bogus newline after printing children of the root element.
> * Allow the noscript element anywhere, the same as the script element.
> * Updated to the 2011 edition of the W3C character entity list.
> Additionally:
> Updated license with new home page for tagsoup
> Updated annotations to OSGi annotations
> Added the ability to specify additional features/properties for the parser
> Documented available settings
> Javadoc fixed
> Prepared for different parsers by renaming HtmlParserImpl and adding 
> component properties
> Configuration improved



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7636) Some login ITs fail

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462674#comment-16462674
 ] 

Bertrand Delacretaz commented on SLING-7636:


{{AnonymousAccessTest}} is fixed now, SLING-7647 has more details. 

On my box the following IT failures are left:

{code}
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.007 s 
<<< FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostToRootTest
[ERROR] Tests run: 7, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 0.474 s 
<<< FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UserPrivilegesInfoTest
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.004 s 
<<< FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLoginErrorTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.003 s 
<<< FAILURE! - in 
org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest
{code}

> Some login ITs fail
> ---
>
> Key: SLING-7636
> URL: https://issues.apache.org/jira/browse/SLING-7636
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Reporter: Robert Munteanu
>Priority: Major
>  Labels: sling-IT
>
> Some for the Login ITs fail
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLoginErrorTest.testGetDefaultLoginPage
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.AnonymousAccessTest.testAnonymousContent
> The common root cause seems to be not finding resources where expected:
> * Expected 20x or 30x status, got 404
> * http://localhost:41000/system/sling/login expected:<200> but was:<404>
> * Expected status 200 for 
> http://localhost:41000/AnonymousAccessTest/1525143663600/test_text_1525143663.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: SLING-6130 changes (anonymous read access under /content only) break ITs (was: Failing Launchpad ITs)

[Bertrand Delacretaz]

On Thu, May 3, 2018 at 5:27 PM, Radu Cotescu  wrote:
> ...adapting the tests to perform authentication is the cleanest way...

In general I agree, but some tests are about anonymous access, on purpose.

In the meantime I'm having trouble running those under /content as
there's a default resource resolver mapping on that, that gets in the
way.

I'll probably create (via repoinit in the launchpad-testing module) an
/ANON_CAN_READ path for such tests, that everyone can read but does
not have such a mapping.

-Bertrand

Re: SLING-6130 changes (anonymous read access under /content only) break ITs (was: Failing Launchpad ITs)

[Radu Cotescu]

Hi,

Came a bit late to the party, but adapting the tests to perform authentication 
is the cleanest way. I had to do the same thing for SLING-7615 [2], where 400+ 
tests were failing on Sling Starter 11-SNAPSHOT.

Cheers,
Radu

> On 3 May 2018, at 15:23, Bertrand Delacretaz  wrote:
> 
> We might change those tests to operate under /content, or relax the
> SLING-6130 restrictions for testing...the former is probably cleaner.

[2] - https://issues.apache.org/jira/browse/SLING-7615 

[jira] [Resolved] (SLING-7647) Anonymous access to content stopped working

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-7647.

Resolution: Fixed
  Assignee: Bertrand Delacretaz

As briefly discussed on list, and based on some simple changes that I did for 
the affected tests, it seems like running tests under {{/content}} is the 
cleanest way to fix this. Marking this ticket fixed accordingly.

> Anonymous access to content stopped working
> ---
>
> Key: SLING-7647
> URL: https://issues.apache.org/jira/browse/SLING-7647
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
> Attachments: sling10-get-request.txt, trunk-get-request.txt
>
>
> Looking at SLING-7636 and especially the {{AnonymousAccessTest}} shows that 
> anonymous access stopped working. The following scenario works with the 
> sling10 jar but not with the current trunk:
> {code}
> curl -u admin:admin -Ftitle=test http://localhost:8080/tmp/test1234
> curl -u admin:admin http://localhost:8080/tmp/test1234.json
> curl http://localhost:8080/tmp/test1234.tidy.json
> {code}
> With sling10 the last request gets content, while with the current trunk it 
> gets a 404.
> I'll attach the logs of that last request on both versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: SLING-6130 changes (anonymous read access under /content only) break ITs (was: Failing Launchpad ITs)

[Bertrand Delacretaz]

On Thu, May 3, 2018 at 3:43 PM, Oliver Lietz  wrote:
> ... +1 for adjusting tests to operate under /content...

Yes, thinking about it it's only a handful of tests, I'm on it already.

> ...btw, any dev in London at Summit?...

Not me unfortunately.

-Bertrand

[jira] [Commented] (SLING-7552) SlingPostServlet error handling still insufficient

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462481#comment-16462481
 ] 

Robert Munteanu commented on SLING-7552:


[~asanso] / [~justinedelson] - any thoughts on the patch proposed by Jörg?

> SlingPostServlet error handling still insufficient
> --
>
> Key: SLING-7552
> URL: https://issues.apache.org/jira/browse/SLING-7552
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.24
>Reporter: Jörg Hoh
>Priority: Major
>  Labels: patch
> Attachments: SLING-7552-patch.diff
>
>
> At the moment the default errorhandling of Sling [1] cannot be used for 
> errors caused and handled by the SlingPostServlet itself. It will always 
> return its own custom output without the chance of customizing it. Although 
> Antonio and Justing worked in SLING-2156 to improve this situation, it still 
> requires extra work (implementing a PostResponseWithErrorHandling). It would 
> be better if the output could be customized by the "standard error handling".
>  
> How to reproduce:
>  * create an error handling script in 
> /apps/sling/servlet/errorhandler/default.jsp which creates some random output.
>  * Validate this script config by doing a request which causes some exception 
> (do not use the SlingPostServlet here)
>  * Do a POST to the Sling instance which results in an exception (e.g. due to 
> insufficient permissions.
>  * The output of the second call is completely determined by the 
> SlingPostServlet, the default error handling does not kick in.
> Proposed solution:
> * The SlingPostServlet should not swallow the exception and handle it by 
> itself, but rather re-throw it, so the standard error handling is triggered.
>  
> [1] http://sling.apache.org/documentation/the-sling-engine/errorhandling.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: SLING-6130 changes (anonymous read access under /content only) break ITs (was: Failing Launchpad ITs)

[Oliver Lietz]

On Thursday 03 May 2018 15:23:43 Bertrand Delacretaz wrote:
> Hi,

Hi,

> On Wed, May 2, 2018 at 1:51 PM, Robert Munteanu  wrote:
> > There are some tests listed at [1] which capture the remaining work...
> 
> As discussed in SLING-7647 it looks like at least some of those
> failures are due to SLING-6130, which allows anonymous read access
> only under /content by default.
> 
> How should we handle that?
> 
> We might change those tests to operate under /content, or relax the
> SLING-6130 restrictions for testing...the former is probably cleaner.

+1 for adjusting tests to operate under /content

Will have a look when back from Adobe Summit – btw, any dev in London at 
Summit?

O.

> -Bertrand
> 
> > [1]: https://issues.apache.org/jira/issues/?jql=labels%20%3D%20sling-IT
> > %20and%20resolution%20is%20empty%20and%20(created%20%3E%3D%20%20%20%272
> > 018%2F05%2F02%27%20and%20created%20%3C%20%20%20%272018%2F05%2F03%27%20)

[jira] [Commented] (SLING-7637) PropertyRenderingTest fails

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462454#comment-16462454
 ] 

Bertrand Delacretaz commented on SLING-7637:


Thanks to Robert's hint that SLING-6130 is causing this, I have now properly 
fixed the test by creating the test nodes under {{/content}} where anonymous 
access is allowed.

> PropertyRenderingTest fails
> ---
>
> Key: SLING-7637
> URL: https://issues.apache.org/jira/browse/SLING-7637
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
>
> org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest.testMultiValuedTextNoExt
>  fails with 
> {{http://localhost:41000/PropertyRenderingTest/1525143696194/this_is_a_test_15251/multiText
>  expected:<403> but was:<404>}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

SLING-6130 changes (anonymous read access under /content only) break ITs (was: Failing Launchpad ITs)

[Bertrand Delacretaz]

Hi,

On Wed, May 2, 2018 at 1:51 PM, Robert Munteanu  wrote:
> There are some tests listed at [1] which capture the remaining work...

As discussed in SLING-7647 it looks like at least some of those
failures are due to SLING-6130, which allows anonymous read access
only under /content by default.

How should we handle that?

We might change those tests to operate under /content, or relax the
SLING-6130 restrictions for testing...the former is probably cleaner.

-Bertrand

> [1]: https://issues.apache.org/jira/issues/?jql=labels%20%3D%20sling-IT
> %20and%20resolution%20is%20empty%20and%20(created%20%3E%3D%20%20%20%272
> 018%2F05%2F02%27%20and%20created%20%3C%20%20%20%272018%2F05%2F03%27%20)

[jira] [Commented] (SLING-6130) Restrict access for principal everyone and move configuration to repoinit

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462431#comment-16462431
 ] 

Bertrand Delacretaz commented on SLING-6130:


Note that this causes trouble for our integration tests, as discussed in 
SLING-7647 - I'll discuss on our dev list how to handle that.

> Restrict access for principal everyone and move configuration to repoinit
> -
>
> Key: SLING-6130
> URL: https://issues.apache.org/jira/browse/SLING-6130
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR, Karaf, Launchpad, Oak
>Affects Versions: JCR Oak Server 1.1.0
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>  Labels: Sling-11-ReleaseNotes, security
> Fix For: JCR Oak Server 1.1.4, Karaf Integration Tests 0.2.0, 
> Karaf Configs 0.2.0, Karaf Launchpad Integration Tests (Oak Tar) 0.0.2, 
> Starter 11
>
> Attachments: error.log
>
>
> Currently {{everyone}} can {{read}} from {{/}} (configured in 
> {{OakSlingRepositoryManager}}).
> Access for {{everyone}} should be restricted:
> * {{read}} should be restricted to {{/content}}
> * configuration of principals and ACLs should be done with _repoinit_
> # -Change path from {{/}} to {{/content}} in {{OakSlingRepositoryManager}}- 
> (/) (-[r1764259|https://svn.apache.org/r1764259]-)
> # Fix modules (samples) relying on _unrestricted_ {{read}} access
> # Move configuration of ACLs to _repoinit_ (/)
> discussion on 
> [dev@|https://lists.apache.org/thread.html/36908ed62ac93c63cad594a897f8abceb93f08da5bcea30dbce98e58@%3Cdev.sling.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7647) Anonymous access to content stopped working

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462430#comment-16462430
 ] 

Bertrand Delacretaz commented on SLING-7647:


bq. Maybe this is due to SLING-6130 ?

Of course...I did vaguely remember that something changed in that area ;-)

Let's discuss on list, if we want to change the tests to run under /content or 
change the SLING-6130 settings for testing.

> Anonymous access to content stopped working
> ---
>
> Key: SLING-7647
> URL: https://issues.apache.org/jira/browse/SLING-7647
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
> Attachments: sling10-get-request.txt, trunk-get-request.txt
>
>
> Looking at SLING-7636 and especially the {{AnonymousAccessTest}} shows that 
> anonymous access stopped working. The following scenario works with the 
> sling10 jar but not with the current trunk:
> {code}
> curl -u admin:admin -Ftitle=test http://localhost:8080/tmp/test1234
> curl -u admin:admin http://localhost:8080/tmp/test1234.json
> curl http://localhost:8080/tmp/test1234.tidy.json
> {code}
> With sling10 the last request gets content, while with the current trunk it 
> gets a 404.
> I'll attach the logs of that last request on both versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7647) Anonymous access to content stopped working

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462425#comment-16462425
 ] 

Bertrand Delacretaz commented on SLING-7647:


The failing (trunk) log has

{code}
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule 
Login: Credentials 'javax.jcr.GuestCredentials@6938bd73' obtained from callback
...
org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory 
createResource: No JCR Item exists at path '/tmp/test1234'
{code}

Which seems to indicate that it's Oak which is rejecting access to the 
{{/tmp/test1234}} node for the {{GuestCredentials}} user. 

At the same point, the sling10 log says {{Found JCR Node Resource at path 
'/tmp/test1234'}}.

> Anonymous access to content stopped working
> ---
>
> Key: SLING-7647
> URL: https://issues.apache.org/jira/browse/SLING-7647
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
> Attachments: sling10-get-request.txt, trunk-get-request.txt
>
>
> Looking at SLING-7636 and especially the {{AnonymousAccessTest}} shows that 
> anonymous access stopped working. The following scenario works with the 
> sling10 jar but not with the current trunk:
> {code}
> curl -u admin:admin -Ftitle=test http://localhost:8080/tmp/test1234
> curl -u admin:admin http://localhost:8080/tmp/test1234.json
> curl http://localhost:8080/tmp/test1234.tidy.json
> {code}
> With sling10 the last request gets content, while with the current trunk it 
> gets a 404.
> I'll attach the logs of that last request on both versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7647) Anonymous access to content stopped working

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-7647:
---
Attachment: trunk-get-request.txt
sling10-get-request.txt

> Anonymous access to content stopped working
> ---
>
> Key: SLING-7647
> URL: https://issues.apache.org/jira/browse/SLING-7647
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
> Attachments: sling10-get-request.txt, trunk-get-request.txt
>
>
> Looking at SLING-7636 and especially the {{AnonymousAccessTest}} shows that 
> anonymous access stopped working. The following scenario works with the 
> sling10 jar but not with the current trunk:
> {code}
> curl -u admin:admin -Ftitle=test http://localhost:8080/tmp/test1234
> curl -u admin:admin http://localhost:8080/tmp/test1234.json
> curl http://localhost:8080/tmp/test1234.tidy.json
> {code}
> With sling10 the last request gets content, while with the current trunk it 
> gets a 404.
> I'll attach the logs of that last request on both versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7647) Anonymous access to content stopped working

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462411#comment-16462411
 ] 

Robert Munteanu commented on SLING-7647:


Maybe this is due to SLING-6130 ?

> Anonymous access to content stopped working
> ---
>
> Key: SLING-7647
> URL: https://issues.apache.org/jira/browse/SLING-7647
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
>
> Looking at SLING-7636 and especially the {{AnonymousAccessTest}} shows that 
> anonymous access stopped working. The following scenario works with the 
> sling10 jar but not with the current trunk:
> {code}
> curl -u admin:admin -Ftitle=test http://localhost:8080/tmp/test1234
> curl -u admin:admin http://localhost:8080/tmp/test1234.json
> curl http://localhost:8080/tmp/test1234.tidy.json
> {code}
> With sling10 the last request gets content, while with the current trunk it 
> gets a 404.
> I'll attach the logs of that last request on both versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7647) Anonymous access to content stopped working

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462398#comment-16462398
 ] 

Bertrand Delacretaz commented on SLING-7647:


We should revisit the SLING-7637 "fixes" once this issue is clarified.

> Anonymous access to content stopped working
> ---
>
> Key: SLING-7647
> URL: https://issues.apache.org/jira/browse/SLING-7647
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
>
> Looking at SLING-7636 and especially the {{AnonymousAccessTest}} shows that 
> anonymous access stopped working. The following scenario works with the 
> sling10 jar but not with the current trunk:
> {code}
> curl -u admin:admin -Ftitle=test http://localhost:8080/tmp/test1234
> curl -u admin:admin http://localhost:8080/tmp/test1234.json
> curl http://localhost:8080/tmp/test1234.tidy.json
> {code}
> With sling10 the last request gets content, while with the current trunk it 
> gets a 404.
> I'll attach the logs of that last request on both versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7636) Some login ITs fail

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462395#comment-16462395
 ] 

Bertrand Delacretaz commented on SLING-7636:


It looks like SLING-7647 might be the root cause of at least some of these 
failures.

> Some login ITs fail
> ---
>
> Key: SLING-7636
> URL: https://issues.apache.org/jira/browse/SLING-7636
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Reporter: Robert Munteanu
>Priority: Major
>  Labels: sling-IT
>
> Some for the Login ITs fail
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLoginErrorTest.testGetDefaultLoginPage
> * 
> org.apache.sling.launchpad.webapp.integrationtest.login.AnonymousAccessTest.testAnonymousContent
> The common root cause seems to be not finding resources where expected:
> * Expected 20x or 30x status, got 404
> * http://localhost:41000/system/sling/login expected:<200> but was:<404>
> * Expected status 200 for 
> http://localhost:41000/AnonymousAccessTest/1525143663600/test_text_1525143663.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7637) PropertyRenderingTest fails

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462397#comment-16462397
 ] 

Bertrand Delacretaz commented on SLING-7637:


It looks like SLING-7647 might have caused this, we should try to undo this 
change once that one is fixed.

> PropertyRenderingTest fails
> ---
>
> Key: SLING-7637
> URL: https://issues.apache.org/jira/browse/SLING-7637
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
>
> org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest.testMultiValuedTextNoExt
>  fails with 
> {{http://localhost:41000/PropertyRenderingTest/1525143696194/this_is_a_test_15251/multiText
>  expected:<403> but was:<404>}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7647) Anonymous access to content stopped working

[Bertrand Delacretaz (JIRA)]

Bertrand Delacretaz created SLING-7647:
--

 Summary: Anonymous access to content stopped working
 Key: SLING-7647
 URL: https://issues.apache.org/jira/browse/SLING-7647
 Project: Sling
  Issue Type: Bug
  Components: Authentication
Reporter: Bertrand Delacretaz


Looking at SLING-7636 and especially the {{AnonymousAccessTest}} shows that 
anonymous access stopped working. The following scenario works with the sling10 
jar but not with the current trunk:

{code}
curl -u admin:admin -Ftitle=test http://localhost:8080/tmp/test1234
curl -u admin:admin http://localhost:8080/tmp/test1234.json
curl http://localhost:8080/tmp/test1234.tidy.json
{code}

With sling10 the last request gets content, while with the current trunk it 
gets a 404.

I'll attach the logs of that last request on both versions.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-6783) Updates for Commons HTML

[Jason E Bailey (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462390#comment-16462390
 ] 

Jason E Bailey commented on SLING-6783:
---

We should either support them or at least document what is and isn't supported 
from a features perspective. At this point I would just say documentation, I'm 
much more interested in finding a way to make this html5 compliant then 
features that no one has yet asked for.

> Updates for Commons HTML
> 
>
> Key: SLING-6783
> URL: https://issues.apache.org/jira/browse/SLING-6783
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Jason E Bailey
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: Commons HTML 1.0.2
>
> Attachments: sling.patch
>
>
> Following updates:
> Updated tagsoup lib to 1.2.1 which has the following modifications
> * DOCTYPE is now recognized even in lower case.
> * We make sure to buffer the reader, eliminating a long-standing bug that 
> would crash on certain inputs, such as & followed by CR+LF.
> * The HTML scanner's table is precompiled at run time for efficiency, causing 
> a 4x speedup on large input documents.
> * ]] within a CDATA section no longer causes input to be discarded.
> * Remove bogus newline after printing children of the root element.
> * Allow the noscript element anywhere, the same as the script element.
> * Updated to the 2011 edition of the W3C character entity list.
> Additionally:
> Updated license with new home page for tagsoup
> Updated annotations to OSGi annotations
> Added the ability to specify additional features/properties for the parser
> Documented available settings
> Javadoc fixed
> Prepared for different parsers by renaming HtmlParserImpl and adding 
> component properties
> Configuration improved



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7637) PropertyRenderingTest fails

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-7637.

Resolution: Fixed
  Assignee: Bertrand Delacretaz

I have fixed the test with this commit:

https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/2001e979f756eba37aa71e6c6db850987e8e33ed

But I'm not sure what caused it to fail. The root cause is that HttpClient gets 
a redirect if the URL ends with /multiText without a trailing / and the GET 
request that follows the redirect doesn't include credentials (see requests 
dump below).

The change might be that Sling previously didn't send a redirect, or that it 
didn't require credentials before. Or maybe that the httpclient version changed 
and behaves differently.

Requests/responses:

{code}
##
T 127.0.0.1:57426 -> 127.0.0.1:8080 [AP]
  GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText HTTP
  /1.1..Authorization: Basic YWRtaW46YWRtaW4=..User-Agent: Jakarta Commons-Htt
  pClient/3.1..Host: localhost:8080   
##
T 127.0.0.1:8080 -> 127.0.0.1:57426 [AP]
  HTTP/1.1 302 Found..Date: Thu, 03 May 2018 11:54:40 GMT..X-Content-Type-Opti
  ons: nosniff..X-Frame-Options: SAMEORIGIN..FILTER_COUNTER_SLING: 1..FILTER_C
  OUNTER_NOPROP: 1..Location: http://localhost:8080/PropertyRenderingTest/1525
  348448317/this_is_a_test_15253/multiText/..Content-Length: 0
##
T 127.0.0.1:57426 -> 127.0.0.1:8080 [AP]
  GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText/ HTT
  P/1.1..User-Agent: Jakarta Commons-HttpClient/3.1..Host: localhost:8080 
##
{code}

The second GET does not include the {{Authorization}} header.

> PropertyRenderingTest fails
> ---
>
> Key: SLING-7637
> URL: https://issues.apache.org/jira/browse/SLING-7637
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Labels: sling-IT
>
> org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest.testMultiValuedTextNoExt
>  fails with 
> {{http://localhost:41000/PropertyRenderingTest/1525143696194/this_is_a_test_15251/multiText
>  expected:<403> but was:<404>}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Query version 4.0.2

[Jason E Bailey]

Thanks Stefan, I actually don't use Sling Query that much, I was working 
through it to understand it when I made my changes. So I've tagged Tomek to 
take a look.

- Jason

On Thu, May 3, 2018, at 3:21 AM, Stefan Seifert wrote:
> >It would also be good to fix the versioning to not rely on the
> >project's version for the next release
> >
> >[WARNING] org.apache.sling.query: Excessive version increase; detected
> >4.0.2, suggested 4.0.0
> >[WARNING] org.apache.sling.query: Version has been increased but
> >analysis detected no changes; detected 4.0.2, suggested 4.0.0
> >[WARNING] org.apache.sling.query.api: Excessive version increase;
> >detected 4.0.2, suggested 4.0.0
> >[WARNING] org.apache.sling.query.api: Version has been increased but
> >analysis detected no changes; detected 4.0.2, suggested 4.0.0
> 
> i've created a PR for this:
> https://github.com/apache/sling-org-apache-sling-query/pull/2
> 
> @jason: can you test this PR that sling query is still working as 
> expected? i checked only the compliation and unit tests.
> 
> stefan
> 

[GitHub] JEBailey commented on issue #2: Fix OSGi package export version

[GitBox]

JEBailey commented on issue #2: Fix OSGi package export version
URL: 
https://github.com/apache/sling-org-apache-sling-query/pull/2#issuecomment-386272096
 
 
   @trekawek and @npeltier could you look at this? I believe you both would be 
better judges of impact then I am.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6 and Apache Sling Query version 4.0.2

[Radu Cotescu]

+1 (only checked signatures)

> On 2 May 2018, at 17:30, Jason E Bailey  wrote:
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...

Re: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6 and Apache Sling Query version 4.0.2

[Robert Munteanu]

On Wed, 2018-05-02 at 11:30 -0400, Jason E Bailey wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

[jira] [Resolved] (SLING-7621) Regex path matching in Sling Dynamic Include

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-7621.

Resolution: Fixed

Thank you for your contribution! I have merged your pull request and made a few 
minor changes after that, please cross-check.

There were lots of extra whitespace changes in your diffs, in general if you 
can avoid that it's better, for the clarify of the diffs. But sometimes our 
source code is inconsistent in terms of white space so that's not always easy - 
no big deal and thank you again.

> Regex path matching in Sling Dynamic Include
> 
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example 
> of such external content are AEM Experience Fragments or Content Fragments, 
> or Zen Garden Snippets.
>  Sometimes such 3rd party content can be categorized into two categories:
>  * not included by SDI - content which should not be included separately (for 
> example when content requires page context)
>  * included by SDI - content which is static, so it can be cached because it 
> does not change often (header, footer), or because it changes once per week 
> and we don't want to invalidate whole cache.
> Example content structure:
>  * /content/my-site/my-micro-site/en_gl/content/fragments/
>  * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British 
> market, German market etc.), and we would want to include that 3rd party 
> content using SDI, we would have to provide one Sling Dynamic Include 
> configuration per market.
>  As you may know, one site can have 100 or more markets, it means at least 
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the 
> path.
>  Currently SDI checks if requested resource path starts from the configured 
> path. 
>  Instead of simple check with startsWith, SDI should support regular 
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path 
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for 
> Configuration and ConfigurationWhiteboard classes.
>  
> Pull request: 
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7621) Regex path matching in Sling Dynamic Include

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz reassigned SLING-7621:
--

Assignee: Bertrand Delacretaz

> Regex path matching in Sling Dynamic Include
> 
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example 
> of such external content are AEM Experience Fragments or Content Fragments, 
> or Zen Garden Snippets.
>  Sometimes such 3rd party content can be categorized into two categories:
>  * not included by SDI - content which should not be included separately (for 
> example when content requires page context)
>  * included by SDI - content which is static, so it can be cached because it 
> does not change often (header, footer), or because it changes once per week 
> and we don't want to invalidate whole cache.
> Example content structure:
>  * /content/my-site/my-micro-site/en_gl/content/fragments/
>  * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British 
> market, German market etc.), and we would want to include that 3rd party 
> content using SDI, we would have to provide one Sling Dynamic Include 
> configuration per market.
>  As you may know, one site can have 100 or more markets, it means at least 
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the 
> path.
>  Currently SDI checks if requested resource path starts from the configured 
> path. 
>  Instead of simple check with startsWith, SDI should support regular 
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path 
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for 
> Configuration and ConfigurationWhiteboard classes.
>  
> Pull request: 
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7621) Regex path matching in Sling Dynamic Include

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-7621:
---
Fix Version/s: Dynamic Include 3.0.2

> Regex path matching in Sling Dynamic Include
> 
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example 
> of such external content are AEM Experience Fragments or Content Fragments, 
> or Zen Garden Snippets.
>  Sometimes such 3rd party content can be categorized into two categories:
>  * not included by SDI - content which should not be included separately (for 
> example when content requires page context)
>  * included by SDI - content which is static, so it can be cached because it 
> does not change often (header, footer), or because it changes once per week 
> and we don't want to invalidate whole cache.
> Example content structure:
>  * /content/my-site/my-micro-site/en_gl/content/fragments/
>  * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British 
> market, German market etc.), and we would want to include that 3rd party 
> content using SDI, we would have to provide one Sling Dynamic Include 
> configuration per market.
>  As you may know, one site can have 100 or more markets, it means at least 
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the 
> path.
>  Currently SDI checks if requested resource path starts from the configured 
> path. 
>  Instead of simple check with startsWith, SDI should support regular 
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path 
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for 
> Configuration and ConfigurationWhiteboard classes.
>  
> Pull request: 
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] bdelacretaz closed pull request #3: Regex path matching in Sling Dynamic Include

[GitBox]

bdelacretaz closed pull request #3: Regex path matching in Sling Dynamic Include
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 39a3415..1752828 100644
--- a/README.md
+++ b/README.md
@@ -30,8 +30,7 @@ Add following dependency to your project:
 Filter is delivered as a standard OSGi bundle. SDI is configured via the 
configuration factory called *SDI Configuration*. Following properties are 
available:
 
 * **Enabled** - enable SDI
-* **Base path** - given SDI configuration will be enabled only for this
-  path
+* **Base path** - This SDI configuration will work only for paths matching 
this value. If value starts with "^" sign, regex matching will be performed. 
Otherwise it will check for path prefix.'
 * **Resource types** - which components should be replaced with tags
 * **Include type** - type of include tag (Apache SSI, ESI or Javascript)
 * **Add comment** - adds debug comment: `` to every replaced component
diff --git a/pom.xml b/pom.xml
index c132b9b..6743856 100644
--- a/pom.xml
+++ b/pom.xml
@@ -29,7 +29,7 @@
 
 
 org.apache.sling.dynamic-include
-3.0.1-SNAPSHOT
+3.1.0-SNAPSHOT
 bundle
 
 Apache Sling Dynamic Include
@@ -136,6 +136,19 @@
 2.4
 provided
 
+
+
+junit
+junit
+4.12
+test
+
+
+org.mockito
+mockito-core
+2.18.3
+test
+
 
 
 
diff --git a/src/main/java/org/apache/sling/dynamicinclude/Configuration.java 
b/src/main/java/org/apache/sling/dynamicinclude/Configuration.java
index 4d3a2c7..2aedebe 100755
--- a/src/main/java/org/apache/sling/dynamicinclude/Configuration.java
+++ b/src/main/java/org/apache/sling/dynamicinclude/Configuration.java
@@ -22,7 +22,7 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
-
+import java.util.regex.Pattern;
 import org.apache.commons.lang.ArrayUtils;
 import org.apache.commons.lang.StringUtils;
 import org.apache.felix.scr.annotations.Activate;
@@ -34,8 +34,13 @@
 import org.apache.felix.scr.annotations.Service;
 import org.apache.sling.api.SlingHttpServletRequest;
 import org.apache.sling.commons.osgi.PropertiesUtil;
+import org.apache.sling.dynamicinclude.pathmatcher.PathMatcher;
+import org.apache.sling.dynamicinclude.pathmatcher.PrefixPathMatcher;
+import org.apache.sling.dynamicinclude.pathmatcher.RegexPathMatcher;
 import org.osgi.framework.Constants;
 import org.osgi.service.component.ComponentContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Include filter configuration.
@@ -43,143 +48,158 @@
 @Component(metatype = true, configurationFactory = true, label = "Apache Sling 
Dynamic Include - Configuration", immediate = true, policy = 
ConfigurationPolicy.REQUIRE)
 @Service(Configuration.class)
 @Properties({
-@Property(name = Constants.SERVICE_VENDOR, value = "The Apache 
Software Foundation"),
-@Property(name = Configuration.PROPERTY_FILTER_ENABLED, boolValue = 
Configuration.DEFAULT_FILTER_ENABLED, label = "Enabled", description = "Check 
to enable the filter"),
-@Property(name = Configuration.PROPERTY_FILTER_PATH, value = 
Configuration.DEFAULT_FILTER_PATH, label = "Base path", description = "This SDI 
configuration will work only for this path"),
-@Property(name = Configuration.PROPERTY_FILTER_RESOURCE_TYPES, 
cardinality = Integer.MAX_VALUE, label = "Resource types", description = 
"Filter will replace components with selected resource types"),
-@Property(name = Configuration.PROPERTY_INCLUDE_TYPE, value = 
Configuration.DEFAULT_INCLUDE_TYPE, label = "Include type", description = "Type 
of generated include tags", options = {
-@PropertyOption(name = "SSI", value = "Apache SSI"), 
@PropertyOption(name = "ESI", value = "ESI"),
-@PropertyOption(name = "JSI", value = "Javascript") }),
-@Property(name = Configuration.PROPERTY_ADD_COMMENT, boolValue = 
Configuration.DEFAULT_ADD_COMMENT, label = "Add comment", description = "Add 
comment to included components"),
-@Property(name = Configuration.PROPERTY_FILTER_SELECTOR, value = 
Configuration.DEFAULT_FILTER_SELECTOR, label = "Filter selector", description = 
"Selector used to mark included resources"),
-@Property(name = Configuration.PROPERTY_COMPONENT_TTL, label = 
"Component TTL", description = "\"Time to live\" cache header for rendered 
component (in seconds)"),
-@Property(name = Configuration.PROPERTY_REQUIRED_HEADER, value = 
Configuration.DEFAULT_REQUIRED_HEADER, label = "Required header", description 

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[Bertrand Delacretaz]

Hi David,

On Thu, May 3, 2018 at 10:11 AM, David Bosschaert
 wrote:
> ...I'm not sure I like the idea of renaming sling-org-apache-sling-feature to
> sling-org-apache-sling-feature-docs as that repository also contains the
> API classes, so it's not just a docs repo

Ah ok, sorry I missed that.

> ...I wasn't aware of the http://sling.apache.org/repolist.html page, but it
> seems that the sling-org-apache-sling-feature is simply missing from that
> page. Do you know how I could add it? It *is* currently already listed in
> the default.xml of the aggregator...

Yeah, it's missing there due to the rules used to extract the group
name in the website template script that Radu pointed to, [1]

If that repository name was sling-org-apache-sling-feature-api for
example it would be in the feature group - but that's no big deal.

My point was that IMO all "feature" repositories should point to the
permanent URL that has the general documentation for the feature model
- so maybe just add a link from all "feature" READMEs to
https://github.com/apache/sling-org-apache-sling-feature if that's
where you intend those docs to be, or to a new page under
http://sling.apache.org/documentation/bundles.html which can act as
the entry point.

Hope this clarifies what I mean ;-)

-Bertrand

[1] 
https://github.com/apache/sling-aggregator/blob/master/collect-sling-repos.groovy

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[Radu Cotescu]

Hi David,

This [1] is the script that generates the Sling modules’ grouping. Robert and 
Bertrand might be able to help if you don’t want to update the script yourself.

Cheers,
Radu

[1] - 
https://github.com/apache/sling-aggregator/blob/master/collect-sling-repos.groovy
 


> On 3 May 2018, at 10:26, David Bosschaert  wrote:
> 
> BTW I see that org-apache-sling-feature is part of the  SET> section, but it's missing from the  group...

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[David Bosschaert]

On 3 May 2018 at 09:11, David Bosschaert  wrote:

> Hi Bertrand,
>
> I'm not sure I like the idea of renaming sling-org-apache-sling-feature to
> sling-org-apache-sling-feature-docs as that repository also contains the
> API classes, so it's not just a docs repo.
>
> I wasn't aware of the http://sling.apache.org/repolist.html page, but it
> seems that the sling-org-apache-sling-feature is simply missing from that
> page. Do you know how I could add it? It *is* currently already listed in
> the default.xml of the aggregator...
>
> Best regards,
>
> David
>
>
BTW I see that org-apache-sling-feature is part of the  section, but it's missing from the  group...

David

Re: [GSOC2018] Project Idea : Provide an OpenID Connect Authentication Handler

[Robert Munteanu]

On Thu, 2018-05-03 at 13:34 +0530, Hasini Witharana wrote:
> Hi Robert,
> 
> My username is "hasinidilanka" for Confluence account and I have sent
> a
> pull request[1] for OpenID Connect Handler.
> 
> [1] - https://github.com/apache/sling-whiteboard/pull/13

Nice :-) Bertrand already merged it, so you got your first commit
pushed to the Sling whiteboard.

I've created https://cwiki.apache.org/confluence/display/SLING/GSOC+201
8+-+Provide+an+OpenID+Connect+Authentication+Handler and granted you
editing rights, please confirm that it works as expected.

Robert

> 
> Thank You.
> 
> 
> On Wed, May 2, 2018 at 4:55 PM, Robert Munteanu 
> wrote:
> 
> > On Sun, 2018-04-29 at 01:05 +0530, Hasini Witharana wrote:
> > > Hi Robert,
> > > 
> > > I have done some changes to the estimated schedule and end
> > > deliverables
> > > sections, in the  proposal[1]. Please review and give your
> > > comments.
> > > 
> > > [1] -
> > > https://docs.google.com/document/d/1ki_mv_ngtMFsP2cqZkVfZfAYLAYle
> > > 6M5S
> > > rs0WsgHXEs/edit?usp=sharing
> > 
> > Looks good overall. I would suggest moving the next iteration on
> > the
> > Apache Sling Wiki at https://cwiki.apache.org/confluence/display/SL
> > ING/
> >  - please send me your username and I'll grant you the necessary
> > rights.
> > 
> > Also for the next iteration it would be good to understand what
> > kind of
> > testing you had in mind ( unit tests based on Mocks, integration
> > testing based on 'live' servers, etc ).
> > 
> > Robert
> > 
> > > 
> > > Thank you.
> > > 
> > > On Fri, Apr 27, 2018 at 4:54 PM, Robert Munteanu  > > org>
> > > wrote:
> > > 
> > > > Hi Hasini,
> > > > 
> > > > On Fri, 2018-04-27 at 00:37 +0530, Hasini Witharana wrote:
> > > > > Hi all,
> > > > > 
> > > > > In OpenID Connect flow there are three main parties.
> > > > > 
> > > > >1. End-User - Resource owner
> > > > >2. OpenID Connect Provider - Authorization Server that is
> > > > > capable
> > > > > of
> > > > >authenticating the End-User and providing claims to a
> > > > > Relying
> > > > > Party about
> > > > >the Authentication event and the End-User
> > > > >3. Relying Party - A client requiring End-User
> > > > > Authentication
> > > > > and
> > > > > Claims
> > > > >from an OpenID Connect Provider.
> > > > > 
> > > > > When considering the OIDC flow, does sling act as an OpenID
> > > > > Connect
> > > > > provider or a relying party?
> > > > 
> > > > 
> > > > Sling IMO should act as a relying party.
> > > > 
> > > > Robert
> > > > 
> > > 
> > > 
> > > 
> > 
> > 
> 
> 

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[David Bosschaert]

Hi Bertrand,

I'm not sure I like the idea of renaming sling-org-apache-sling-feature to
sling-org-apache-sling-feature-docs as that repository also contains the
API classes, so it's not just a docs repo.

I wasn't aware of the http://sling.apache.org/repolist.html page, but it
seems that the sling-org-apache-sling-feature is simply missing from that
page. Do you know how I could add it? It *is* currently already listed in
the default.xml of the aggregator...

Best regards,

David

On 3 May 2018 at 09:07, Bertrand Delacretaz  wrote:

> On Wed, May 2, 2018 at 3:30 PM, Bertrand Delacretaz
>  wrote:
> > ...Should those README point to
> > https://github.com/apache/sling-org-apache-sling-feature as the source
> > of documentation?...
>
> ...and, thinking about it, if that's the case it would be good to
> rename that repository to sling-org-apache-sling-feature-docs, which
> would also cause it to appear in the feature group at
> http://sling.apache.org/repolist.html
>
> -Bertrand
>

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[Bertrand Delacretaz]

On Wed, May 2, 2018 at 3:30 PM, Bertrand Delacretaz
 wrote:
> ...Should those README point to
> https://github.com/apache/sling-org-apache-sling-feature as the source
> of documentation?...

...and, thinking about it, if that's the case it would be good to
rename that repository to sling-org-apache-sling-feature-docs, which
would also cause it to appear in the feature group at
http://sling.apache.org/repolist.html

-Bertrand

[GitHub] bdelacretaz closed pull request #13: Initial commit of an OpenID Connect Handler.

[GitBox]

bdelacretaz closed pull request #13: Initial commit of an OpenID Connect 
Handler.
URL: https://github.com/apache/sling-whiteboard/pull/13
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/oidc-handler/README.md b/oidc-handler/README.md
new file mode 100644
index 000..c6c4f11
--- /dev/null
+++ b/oidc-handler/README.md
@@ -0,0 +1,5 @@
+# Apache Sling OpenID Connect Handler
+
+This module is part of the [Apache Sling](https://sling.apache.org) project.
+
+This project is about creating an OpenID Connect Relying Party implementation 
for Apache Sling.
\ No newline at end of file
diff --git a/oidc-handler/pom.xml b/oidc-handler/pom.xml
new file mode 100644
index 000..1ea2181
--- /dev/null
+++ b/oidc-handler/pom.xml
@@ -0,0 +1,11 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+4.0.0
+org.apache.sling
+org.apache.sling.oidchandler
+1.0-SNAPSHOT
+
+
\ No newline at end of file


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [GSOC2018] Project Idea : Provide an OpenID Connect Authentication Handler

[Hasini Witharana]

Hi Robert,

My username is "hasinidilanka" for Confluence account and I have sent a
pull request[1] for OpenID Connect Handler.

[1] - https://github.com/apache/sling-whiteboard/pull/13

Thank You.


On Wed, May 2, 2018 at 4:55 PM, Robert Munteanu  wrote:

> On Sun, 2018-04-29 at 01:05 +0530, Hasini Witharana wrote:
> > Hi Robert,
> >
> > I have done some changes to the estimated schedule and end
> > deliverables
> > sections, in the  proposal[1]. Please review and give your comments.
> >
> > [1] -
> > https://docs.google.com/document/d/1ki_mv_ngtMFsP2cqZkVfZfAYLAYle6M5S
> > rs0WsgHXEs/edit?usp=sharing
>
> Looks good overall. I would suggest moving the next iteration on the
> Apache Sling Wiki at https://cwiki.apache.org/confluence/display/SLING/
>  - please send me your username and I'll grant you the necessary
> rights.
>
> Also for the next iteration it would be good to understand what kind of
> testing you had in mind ( unit tests based on Mocks, integration
> testing based on 'live' servers, etc ).
>
> Robert
>
> >
> > Thank you.
> >
> > On Fri, Apr 27, 2018 at 4:54 PM, Robert Munteanu 
> > wrote:
> >
> > > Hi Hasini,
> > >
> > > On Fri, 2018-04-27 at 00:37 +0530, Hasini Witharana wrote:
> > > > Hi all,
> > > >
> > > > In OpenID Connect flow there are three main parties.
> > > >
> > > >1. End-User - Resource owner
> > > >2. OpenID Connect Provider - Authorization Server that is
> > > > capable
> > > > of
> > > >authenticating the End-User and providing claims to a Relying
> > > > Party about
> > > >the Authentication event and the End-User
> > > >3. Relying Party - A client requiring End-User Authentication
> > > > and
> > > > Claims
> > > >from an OpenID Connect Provider.
> > > >
> > > > When considering the OIDC flow, does sling act as an OpenID
> > > > Connect
> > > > provider or a relying party?
> > >
> > >
> > > Sling IMO should act as a relying party.
> > >
> > > Robert
> > >
> >
> >
> >
>
>


-- 
*Hasini Witharana*
Undergraduate | Department of Computer Science and Engineering
University of Moratuwa
Linkedin 

[GitHub] hasinidilanka commented on issue #13: Initial commit of an OpenID Connect Handler.

[GitBox]

hasinidilanka commented on issue #13: Initial commit of an OpenID Connect 
Handler.
URL: https://github.com/apache/sling-whiteboard/pull/13#issuecomment-386218924
 
 
   @rombert 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hasinidilanka opened a new pull request #13: Initial commit of an OpenID Connect Handler.

[GitBox]

hasinidilanka opened a new pull request #13: Initial commit of an OpenID 
Connect Handler.
URL: https://github.com/apache/sling-whiteboard/pull/13
 
 
   This pull request contains a working space to work in OpenID Connect handler 
for Apache Sling. The folder contains pom.xml and a README.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-7646) Sling Parent: Update to Sling Maven Plugin 2.3.6

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-7646.
---
Resolution: Fixed

added snapshot dependency to 2.3.5-SNAPSHOT so we do not forget to include it 
in the next parent release.
https://github.com/apache/sling-parent/commit/ddebcf7cae668cdd8ffd02a15fd3ff2558c3d573

> Sling Parent: Update to Sling Maven Plugin 2.3.6
> 
>
> Key: SLING-7646
> URL: https://issues.apache.org/jira/browse/SLING-7646
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Affects Versions: Parent 33
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Parent 34
>
>
> update to maven-sling-plugin 2.3.6 due to SLING-7644



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7646) Sling Parent: Update to Sling Maven Plugin 2.3.6

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-7646:
-

 Summary: Sling Parent: Update to Sling Maven Plugin 2.3.6
 Key: SLING-7646
 URL: https://issues.apache.org/jira/browse/SLING-7646
 Project: Sling
  Issue Type: Improvement
  Components: General
Affects Versions: Parent 33
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Parent 34


update to maven-sling-plugin 2.3.6 due to SLING-7644



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

RE: [Discussion] Date handling inconsistencies - resend

[Stefan Seifert]

maybe this would be a sensible first step - although it would be fine to have 
it by default to ISO-8601 in the future for new applications.

stefan

>-Original Message-
>From: Jason E Bailey [mailto:j...@apache.org]
>Sent: Monday, April 23, 2018 8:37 PM
>To: dev@sling.apache.org
>Subject: Re: [Discussion] Date handling inconsistencies - resend
>
>For the JSON rendering, would a service configuration to enable ISO8601
>date support be sufficient initially?
>
>
>- Jason
>
>On Mon, Apr 23, 2018, at 12:58 PM, Jason E Bailey wrote:
>> I'll just come out and say that someone, somewhere, will have something
>> break because of this. Because they wrote something that is very
>> specific to a particular use case.
>>
>> From a loading of content perspective, the two changes I made keep the
>> same instance in time, they just correctly store the offset that was
>> provided. If someone has written a test or some code that manipulated
>> that date based on the belief that no offset was recorded, that may be
>> impacted. I feel this is an edge case enough that I'm good with the
>> changes.
>>
>> There are two areas that are sensitive enough that I'm not going to
>> directly commit without conversation.
>>
>> One is POST handler, where the only format that handles the offset
>> correctly is the ISO-8601 format. Although I don't expect  the content
>> loaders to be problematic, this fix would be larger then what I can get
>> to for a while.
>>
>> The other is the default JSON rendering for the GET request. There is no
>> specification in our documents and no tests that check to see how the
>> Date string is supposed to be generated. There is no JSON specification
>> for a Date. The XML version of the data is using ISO-8601. So my
>> assumption on the original development of this is that the JSON was
>> being generated in a way that would be easily consumable by browsers at
>> the time. However the format used is now deprecated. Everyone is moving
>> to the ISO-8601 format or, at the very least, their interpretation of
>> the spec.
>>
>> That one is potentially the biggest problem, because it's the one that's
>> most likely to break something.  Potential issues would be something
>> like downstream UI components. It's hard for me to say and I would have
>> to do some testing.
>>
>>
>> - Jason
>>
>

RE: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6 and Apache Sling Query version 4.0.2

[Stefan Seifert]

+1

RE: [VOTE] Release Apache Sling Query version 4.0.2

[Stefan Seifert]

>It would also be good to fix the versioning to not rely on the
>project's version for the next release
>
>[WARNING] org.apache.sling.query: Excessive version increase; detected
>4.0.2, suggested 4.0.0
>[WARNING] org.apache.sling.query: Version has been increased but
>analysis detected no changes; detected 4.0.2, suggested 4.0.0
>[WARNING] org.apache.sling.query.api: Excessive version increase;
>detected 4.0.2, suggested 4.0.0
>[WARNING] org.apache.sling.query.api: Version has been increased but
>analysis detected no changes; detected 4.0.2, suggested 4.0.0

i've created a PR for this:
https://github.com/apache/sling-org-apache-sling-query/pull/2

@jason: can you test this PR that sling query is still working as expected? i 
checked only the compliation and unit tests.

stefan

[GitHub] stefanseifert opened a new pull request #2: Fix OSGi package export version

[GitBox]

stefanseifert opened a new pull request #2: Fix OSGi package export version
URL: https://github.com/apache/sling-org-apache-sling-query/pull/2
 
 
OSGi version from package-info got ignored, updating them with each new 
bundle release
   add "impl" to all internal package, and remove explicit bundle export 
package instruction from pom


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-7645) Maven Sling Plugin: Update to latest fsresource

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-7645.
---
Resolution: Fixed

fixed: 
https://github.com/apache/sling-maven-sling-plugin/commit/c58cbfd2620097deb47f057a0bdb505bb9d28379

> Maven Sling Plugin: Update to latest fsresource
> ---
>
> Key: SLING-7645
> URL: https://issues.apache.org/jira/browse/SLING-7645
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Maven Sling Plugin 2.3.4
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Maven Sling Plugin 2.3.6
>
>
> the "fsmount" goal can automatically deploy the fsresource bundle.
> we should update the references version to the latest available.
> that is currently: 2.1.14.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7644) Maven-Sling-Plugin requires Java 8

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-7644.
---
Resolution: Fixed

fixed: 
https://github.com/apache/sling-maven-sling-plugin/commit/5032ce9f2a62a2f7804c946ab3ef6efd9b222964

> Maven-Sling-Plugin requires Java 8
> --
>
> Key: SLING-7644
> URL: https://issues.apache.org/jira/browse/SLING-7644
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.3.4
>Reporter: Carsten Ziegeler
>Assignee: Stefan Seifert
>Priority: Blocker
> Fix For: Maven Sling Plugin 2.3.6
>
>
> When using the maven sling plugin 2.3.4 with Java 7, the following error 
> occurs:
> [ERROR] Failed to execute goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata 
> (generate-adapter-metadata) on project org.apache.sling.resourceresolver: 
> Execution generate-adapter-metadata of goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata failed: 
> An API incompatibility was encountered while executing 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata: 
> java.lang.UnsupportedClassVersionError: javax/json/JsonException : 
> Unsupported major.minor version 52.0
> [ERROR] -
> [ERROR] realm =    plugin>org.apache.sling:maven-sling-plugin:2.3.4
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/Users/cziegeler/.m2/repository/org/apache/sling/maven-sling-plugin/2.3.4/maven-sling-plugin-2.3.4.jar
> [
> Reverting to version 2.3.2 fixes the problem



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7645) Maven Sling Plugin: Update to latest fsresource

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-7645:
-

 Summary: Maven Sling Plugin: Update to latest fsresource
 Key: SLING-7645
 URL: https://issues.apache.org/jira/browse/SLING-7645
 Project: Sling
  Issue Type: Improvement
  Components: Tooling
Affects Versions: Maven Sling Plugin 2.3.4
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Maven Sling Plugin 2.3.6


the "fsmount" goal can automatically deploy the fsresource bundle.
we should update the references version to the latest available.

that is currently: 2.1.14.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7644) Maven-Sling-Plugin requires Java 8

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-7644:
-

Assignee: Stefan Seifert

then i think it's the best way to switch back to java 7 for now.

> Maven-Sling-Plugin requires Java 8
> --
>
> Key: SLING-7644
> URL: https://issues.apache.org/jira/browse/SLING-7644
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.3.4
>Reporter: Carsten Ziegeler
>Assignee: Stefan Seifert
>Priority: Blocker
> Fix For: Maven Sling Plugin 2.3.6
>
>
> When using the maven sling plugin 2.3.4 with Java 7, the following error 
> occurs:
> [ERROR] Failed to execute goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata 
> (generate-adapter-metadata) on project org.apache.sling.resourceresolver: 
> Execution generate-adapter-metadata of goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata failed: 
> An API incompatibility was encountered while executing 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata: 
> java.lang.UnsupportedClassVersionError: javax/json/JsonException : 
> Unsupported major.minor version 52.0
> [ERROR] -
> [ERROR] realm =    plugin>org.apache.sling:maven-sling-plugin:2.3.4
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/Users/cziegeler/.m2/repository/org/apache/sling/maven-sling-plugin/2.3.4/maven-sling-plugin-2.3.4.jar
> [
> Reverting to version 2.3.2 fixes the problem



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7644) Maven-Sling-Plugin requires Java 8

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461997#comment-16461997
 ] 

Carsten Ziegeler commented on SLING-7644:
-

As version 2.3.4 is mentioned in our parent pom, it's impossible to build our 
java 7 based modules with Java 7. 
So we have two options, either move back to 2.3.2 for our parent pom and 
declare that the maven sling plugin requires Java 8

or

fix this Java 8 dependency in 2.3.6 and change our parent pom to 2.3.6

But the way it is atm does not make that much sense.

> Maven-Sling-Plugin requires Java 8
> --
>
> Key: SLING-7644
> URL: https://issues.apache.org/jira/browse/SLING-7644
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.3.4
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: Maven Sling Plugin 2.3.6
>
>
> When using the maven sling plugin 2.3.4 with Java 7, the following error 
> occurs:
> [ERROR] Failed to execute goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata 
> (generate-adapter-metadata) on project org.apache.sling.resourceresolver: 
> Execution generate-adapter-metadata of goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata failed: 
> An API incompatibility was encountered while executing 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata: 
> java.lang.UnsupportedClassVersionError: javax/json/JsonException : 
> Unsupported major.minor version 52.0
> [ERROR] -
> [ERROR] realm =    plugin>org.apache.sling:maven-sling-plugin:2.3.4
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/Users/cziegeler/.m2/repository/org/apache/sling/maven-sling-plugin/2.3.4/maven-sling-plugin-2.3.4.jar
> [
> Reverting to version 2.3.2 fixes the problem



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7644) Maven-Sling-Plugin requires Java 8

[Stefan Seifert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461992#comment-16461992
 ] 

Stefan Seifert commented on SLING-7644:
---

ah, the reason is this commit:
https://github.com/apache/sling-maven-sling-plugin/commit/9579510a3c3efde58319fc25749836c18c4e9644

which references
http://repo1.maven.org/maven2/org/apache/geronimo/specs/geronimo-json_1.1_spec/1.0/geronimo-json_1.1_spec-1.0.pom
http://repo1.maven.org/maven2/org/apache/geronimo/genesis/genesis-java8-flava/2.3/genesis-java8-flava-2.3.pom

which compiles to java 8. strange why this spec requires java 8. we may 
downgrade to json spec 1.0, i assume the code has no direct dependencies to the 
API updates.

on the other hand: what speaks against just declaring the java 8 dependency for 
the maven-sling-plugin - who wants to run it with java 7? it's only required in 
the development environment.

> Maven-Sling-Plugin requires Java 8
> --
>
> Key: SLING-7644
> URL: https://issues.apache.org/jira/browse/SLING-7644
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven Sling Plugin 2.3.4
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: Maven Sling Plugin 2.3.6
>
>
> When using the maven sling plugin 2.3.4 with Java 7, the following error 
> occurs:
> [ERROR] Failed to execute goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata 
> (generate-adapter-metadata) on project org.apache.sling.resourceresolver: 
> Execution generate-adapter-metadata of goal 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata failed: 
> An API incompatibility was encountered while executing 
> org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata: 
> java.lang.UnsupportedClassVersionError: javax/json/JsonException : 
> Unsupported major.minor version 52.0
> [ERROR] -
> [ERROR] realm =    plugin>org.apache.sling:maven-sling-plugin:2.3.4
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/Users/cziegeler/.m2/repository/org/apache/sling/maven-sling-plugin/2.3.4/maven-sling-plugin-2.3.4.jar
> [
> Reverting to version 2.3.2 fixes the problem



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-3524) ResourceResolver.clone(null) should not share the same JCR session

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3524.
-
Resolution: Fixed

[~Csaba Varga] Thanks for the patches, I've applied them

In addition I increased the version of the spi package as a new constant has 
been added

> ResourceResolver.clone(null) should not share the same JCR session
> --
>
> Key: SLING-3524
> URL: https://issues.apache.org/jira/browse/SLING-3524
> Project: Sling
>  Issue Type: Improvement
>  Components: API, JCR, ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: API 2.18.2, JCR Resource 3.0.10, Resource Resolver 1.6.2
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> {{ResourceResolver.clone()}} will reuse the same JCR session in case it was 
> created by passing an existing session using 
> {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of 
> the resource resolver to pass into a new, separate thread, and use 
> {{ResourceResolver.clone(null)}}, you will actually share the session, but 
> this is not obvious. The problem is that a JCR session cannot be shared 
> across threads.
> The javadocs of clone() say "the same credential data is used as was used to 
> create this instance".
> There are a few problems with this:
> - seeing the session object itself as "credential data" is unintuitive
> - in my code, I have no idea what the original credential data was, so I 
> don't know what kind of credential data it was to make the right decision
> - since sharing a JCR session is to be avoided at all times, the resource 
> resolver should prevent one from this
> A solution would be if a plain {{ResourceResolver.clone(null)}} would return 
> a session that impersonated itself, abstracting this from the resource 
> resolver user. Additionally, it might be worth looking that clone always 
> returns a new session, unless specifically stated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)