[jira] [Created] (SLING-8001) CMS - Core - Add Insights API
Dan Klco created SLING-8001: --- Summary: CMS - Core - Add Insights API Key: SLING-8001 URL: https://issues.apache.org/jira/browse/SLING-8001 Project: Sling Issue Type: New Feature Affects Versions: App CMS 0.10.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 0.10.2 It would be a nice feature to have a library for executing content insights. This could include things such as SEO checks, readability analysis, autotagging, etc. The API should allow for pluggable insight providers and the ability to configure insights at the site level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-7429) Improve basename handling
[
https://issues.apache.org/jira/browse/SLING-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644001#comment-16644001
]
Konrad Windszus edited comment on SLING-7429 at 10/9/18 7:43 PM:
-
There are already two methods within {{ResourceBundleProvider}}
([https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/ResourceBundleProvider.java])
# {{ResourceBundle getResourceBundle(Locale locale);}} and
# {{ResourceBundle getResourceBundle(String baseName, Locale locale);}}
The 2nd one states in the javadoc
{code:java}
* @param baseName The base name for the resource bundle. If this is
*null, the same resource bundle will be
*returned as when calling the
*{@link #getResourceBundle(Locale)} method.
{code}
So in fact in the javadoc there is not even a reference to the empty string.
Even in the code I don't find any reference (at least any longer). It seems
that this commit
[https://github.com/apache/sling-org-apache-sling-i18n/commit/14fd345666afccdf990a625a5517b57571213c99#diff-4a73b3fae7dd1d27c037456858d5e603]
slightly changed the semantics anyway. Prior to this commit it was rather
# {{null}} and {{""}} behave the same, afterwards
# passing {{""}} selects messages of mix:language nodes which have
sling:basename properties with the empty value.
Unfortunately there doesn't seem to be a good IT validating the empty string
semantics for the base name.
Let me first come up with an IT validating my assumptions based on code
inspection.
was (Author: kwin):
There are already two methods within {{ResourceBundleProvider}}
(https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/ResourceBundleProvider.java)
# {{ResourceBundle getResourceBundle(Locale locale);}} and
# {{ResourceBundle getResourceBundle(String baseName, Locale locale);}}
The 2nd one states in the javadoc
{code}
* @param baseName The base name for the resource bundle. If this is
*null, the same resource bundle will be
*returned as when calling the
*{@link #getResourceBundle(Locale)} method.
{code}
So in fact in the javadoc there is not even a reference to the empty string.
Even in the code I don't find any reference (at least any longer). It seems
that this commit
https://github.com/apache/sling-org-apache-sling-i18n/commit/14fd345666afccdf990a625a5517b57571213c99#diff-4a73b3fae7dd1d27c037456858d5e603
slightly changed the semantics anyway. Prior to this commit it was rather
# {{null}} and {{""}} behave the same, afterwards
# selects messages of mix:language nodes which have sling:basename properties
with the empty value.
Unfortunately there doesn't seem to be a good IT validating the empty string
semantics for the base name.
Let me first come up with an IT validating my assumptions based on code
inspection.
> Improve basename handling
> -
>
> Key: SLING-7429
> URL: https://issues.apache.org/jira/browse/SLING-7429
> Project: Sling
> Issue Type: Improvement
> Components: i18n
>Affects Versions: i18n 2.5.12
>Reporter: Konrad Windszus
>Priority: Major
>
> Right now the basename handling according to
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names
> is as follows
> {quote}
> The base name argument can take one three values:
> # {{null}}, selects messages of mix:language nodes ignoring the existence or
> absence of sling:basename properties
> # Empty String, selects messages of mix:language nodes which have
> sling:basename properties, ignoring the actual values
> # Any other Value, selects messages of mix:language nodes whose
> sling:basename properties has any value which matches the base name string
> {quote}
> I think it should somehow be also possible for a client to explicitly select
> a resource bundle which is not having the {{sling:basename}} property set.
> This was originally triggered from
> https://issues.apache.org/jira/browse/SLING-7421?focusedCommentId=16335686=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335686.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7429) Improve basename handling
[
https://issues.apache.org/jira/browse/SLING-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644001#comment-16644001
]
Konrad Windszus commented on SLING-7429:
There are already two methods within {{ResourceBundleProvider}}
(https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/ResourceBundleProvider.java)
# {{ResourceBundle getResourceBundle(Locale locale);}} and
# {{ResourceBundle getResourceBundle(String baseName, Locale locale);}}
The 2nd one states in the javadoc
{code}
* @param baseName The base name for the resource bundle. If this is
*null, the same resource bundle will be
*returned as when calling the
*{@link #getResourceBundle(Locale)} method.
{code}
So in fact in the javadoc there is not even a reference to the empty string.
Even in the code I don't find any reference (at least any longer). It seems
that this commit
https://github.com/apache/sling-org-apache-sling-i18n/commit/14fd345666afccdf990a625a5517b57571213c99#diff-4a73b3fae7dd1d27c037456858d5e603
slightly changed the semantics anyway. Prior to this commit it was rather
# {null} and {""} behave the same, afterwards
# selects messages of mix:language nodes which have sling:basename properties
with the empty value.
Unfortunately there doesn't seem to be a good IT validating the empty string
semantics for the base name.
Let me first come up with an IT validating my assumptions based on code
inspection.
> Improve basename handling
> -
>
> Key: SLING-7429
> URL: https://issues.apache.org/jira/browse/SLING-7429
> Project: Sling
> Issue Type: Improvement
> Components: i18n
>Affects Versions: i18n 2.5.12
>Reporter: Konrad Windszus
>Priority: Major
>
> Right now the basename handling according to
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names
> is as follows
> {quote}
> The base name argument can take one three values:
> # {{null}}, selects messages of mix:language nodes ignoring the existence or
> absence of sling:basename properties
> # Empty String, selects messages of mix:language nodes which have
> sling:basename properties, ignoring the actual values
> # Any other Value, selects messages of mix:language nodes whose
> sling:basename properties has any value which matches the base name string
> {quote}
> I think it should somehow be also possible for a client to explicitly select
> a resource bundle which is not having the {{sling:basename}} property set.
> This was originally triggered from
> https://issues.apache.org/jira/browse/SLING-7421?focusedCommentId=16335686=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335686.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-7429) Improve basename handling
[
https://issues.apache.org/jira/browse/SLING-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644001#comment-16644001
]
Konrad Windszus edited comment on SLING-7429 at 10/9/18 7:43 PM:
-
There are already two methods within {{ResourceBundleProvider}}
(https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/ResourceBundleProvider.java)
# {{ResourceBundle getResourceBundle(Locale locale);}} and
# {{ResourceBundle getResourceBundle(String baseName, Locale locale);}}
The 2nd one states in the javadoc
{code}
* @param baseName The base name for the resource bundle. If this is
*null, the same resource bundle will be
*returned as when calling the
*{@link #getResourceBundle(Locale)} method.
{code}
So in fact in the javadoc there is not even a reference to the empty string.
Even in the code I don't find any reference (at least any longer). It seems
that this commit
https://github.com/apache/sling-org-apache-sling-i18n/commit/14fd345666afccdf990a625a5517b57571213c99#diff-4a73b3fae7dd1d27c037456858d5e603
slightly changed the semantics anyway. Prior to this commit it was rather
# {{null}} and {{""}} behave the same, afterwards
# selects messages of mix:language nodes which have sling:basename properties
with the empty value.
Unfortunately there doesn't seem to be a good IT validating the empty string
semantics for the base name.
Let me first come up with an IT validating my assumptions based on code
inspection.
was (Author: kwin):
There are already two methods within {{ResourceBundleProvider}}
(https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/ResourceBundleProvider.java)
# {{ResourceBundle getResourceBundle(Locale locale);}} and
# {{ResourceBundle getResourceBundle(String baseName, Locale locale);}}
The 2nd one states in the javadoc
{code}
* @param baseName The base name for the resource bundle. If this is
*null, the same resource bundle will be
*returned as when calling the
*{@link #getResourceBundle(Locale)} method.
{code}
So in fact in the javadoc there is not even a reference to the empty string.
Even in the code I don't find any reference (at least any longer). It seems
that this commit
https://github.com/apache/sling-org-apache-sling-i18n/commit/14fd345666afccdf990a625a5517b57571213c99#diff-4a73b3fae7dd1d27c037456858d5e603
slightly changed the semantics anyway. Prior to this commit it was rather
# {null} and {""} behave the same, afterwards
# selects messages of mix:language nodes which have sling:basename properties
with the empty value.
Unfortunately there doesn't seem to be a good IT validating the empty string
semantics for the base name.
Let me first come up with an IT validating my assumptions based on code
inspection.
> Improve basename handling
> -
>
> Key: SLING-7429
> URL: https://issues.apache.org/jira/browse/SLING-7429
> Project: Sling
> Issue Type: Improvement
> Components: i18n
>Affects Versions: i18n 2.5.12
>Reporter: Konrad Windszus
>Priority: Major
>
> Right now the basename handling according to
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names
> is as follows
> {quote}
> The base name argument can take one three values:
> # {{null}}, selects messages of mix:language nodes ignoring the existence or
> absence of sling:basename properties
> # Empty String, selects messages of mix:language nodes which have
> sling:basename properties, ignoring the actual values
> # Any other Value, selects messages of mix:language nodes whose
> sling:basename properties has any value which matches the base name string
> {quote}
> I think it should somehow be also possible for a client to explicitly select
> a resource bundle which is not having the {{sling:basename}} property set.
> This was originally triggered from
> https://issues.apache.org/jira/browse/SLING-7421?focusedCommentId=16335686=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335686.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7991) Make packages part of last execution plan if no start-order is defined
[ https://issues.apache.org/jira/browse/SLING-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Süß updated SLING-7991: --- Description: SLING-7871 introduces a mechanism that installs content-packages in one or more execution plans for a deterministic, layer-able install sequence (consumer adding a subsequent layer of installables via additional features guaranteed to be processed later). As by default the start-order is set to 0 by default a feature may not define a position earlier than the ones without start-order. As the installation sequence may be crucial due to the hierarchical dependencies packages without start-order defined should rather be installed as last which only mandates setting a start-order on the lower layers while not setting a start-order on leaf packages won't do any harm. Additionally, a mechanism to bake a start-order defined in feature properties during the merge process would be beneficial. Any who's start-order would need to be set to a specific value would need to declare the feature property "default.content.startorder" was: SLING-7871 introduces a mechanism that installs content-packages in one or more execution plans for a deterministic, layer-able install sequence (consumer adding a subsequent layer of installables via additional features guaranteed to be processed later). As by default the start-order is set to 0 by default a feature may not define a position earlier then the ones without start-order. As the installation sequence may be crucial due to the hierarchical dependencies packages without start-order defined should rather be installed as last which only mandates setting a start-order on the lower layers while not setting a start-order on leaf packages won't do any harm. Additionally a mechanism to bake a start-order defined in feature properties during the merge process would be beneficial. Any who's start-order would need to be set to a specific value would need to declare the feature property "default.content.startorder" > Make packages part of last execution plan if no start-order is defined > -- > > Key: SLING-7991 > URL: https://issues.apache.org/jira/browse/SLING-7991 > Project: Sling > Issue Type: Improvement > Components: Installer >Reporter: Dominik Süß >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > SLING-7871 introduces a mechanism that installs content-packages in one or > more execution plans for a deterministic, layer-able install sequence > (consumer adding a subsequent layer of installables via additional features > guaranteed to be processed later). > As by default the start-order is set to 0 by default a feature may not define > a position earlier than the ones without start-order. > As the installation sequence may be crucial due to the hierarchical > dependencies packages without start-order defined should rather be installed > as last which only mandates setting a start-order on the lower layers while > not setting a start-order on leaf packages won't do any harm. > Additionally, a mechanism to bake a start-order defined in feature properties > during the merge process would be beneficial. Any who's start-order would > need to be set to a specific value would need to declare the feature property > "default.content.startorder" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7991) Make packages part of last execution plan if no start-order is defined
[ https://issues.apache.org/jira/browse/SLING-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Süß updated SLING-7991: --- Description: SLING-7871 introduces a mechanism that installs content-packages in one or more execution plans for a deterministic, layer-able install sequence (consumer adding a subsequent layer of installables via additional features guaranteed to be processed later). As by default the start-order is set to 0 by default a feature may not define a position earlier then the ones without start-order. As the installation sequence may be crucial due to the hierarchical dependencies packages without start-order defined should rather be installed as last which only mandates setting a start-order on the lower layers while not setting a start-order on leaf packages won't do any harm. Additionally a mechanism to bake a start-order defined in feature properties during the merge process would be beneficial. Any who's start-order would need to be set to a specific value would need to declare the feature property "default.content.startorder" was: SLING-7871 introduces a mechanism that installs content-packages in one or more execution plans for a deterministic, layer-able install sequence (consumer adding a subsequent layer of installables via additional features guaranteed to be processed later). As by default the start-order is set to 0 by default a feature may not define a position earlier then the ones without start-order. As the installation sequence may be crucial due to the hierarchical dependencies packages without start-order defined should rather be installed as last which only mandates setting a start-order on the lower layers while not setting a start-order on leaf packages won't do any harm. > Make packages part of last execution plan if no start-order is defined > -- > > Key: SLING-7991 > URL: https://issues.apache.org/jira/browse/SLING-7991 > Project: Sling > Issue Type: Improvement > Components: Installer >Reporter: Dominik Süß >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > SLING-7871 introduces a mechanism that installs content-packages in one or > more execution plans for a deterministic, layer-able install sequence > (consumer adding a subsequent layer of installables via additional features > guaranteed to be processed later). > As by default the start-order is set to 0 by default a feature may not define > a position earlier then the ones without start-order. > As the installation sequence may be crucial due to the hierarchical > dependencies packages without start-order defined should rather be installed > as last which only mandates setting a start-order on the lower layers while > not setting a start-order on leaf packages won't do any harm. > Additionally a mechanism to bake a start-order defined in feature properties > during the merge process would be beneficial. Any who's start-order would > need to be set to a specific value would need to declare the feature property > "default.content.startorder" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7991) Make packages part of last execution plan if no start-order is defined
[ https://issues.apache.org/jira/browse/SLING-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Süß updated SLING-7991: --- Description: SLING-7871 introduces a mechanism that installs content-packages in one or more execution plans for a deterministic, layer-able install sequence (consumer adding a subsequent layer of installables via additional features guaranteed to be processed later). As by default the start-order is set to 0 by default a feature may not define a position earlier than the ones without start-order. As the installation sequence may be crucial due to the hierarchical dependencies packages without start-order defined should rather be installed last which only mandates setting a start-order on the lower layers while not setting a start-order on leaf packages won't do any harm. Additionally, a mechanism to bake a start-order defined in feature properties during the merge process would be beneficial. Any who's start-order would need to be set to a specific value would need to declare the feature property "default.content.startorder" was: SLING-7871 introduces a mechanism that installs content-packages in one or more execution plans for a deterministic, layer-able install sequence (consumer adding a subsequent layer of installables via additional features guaranteed to be processed later). As by default the start-order is set to 0 by default a feature may not define a position earlier than the ones without start-order. As the installation sequence may be crucial due to the hierarchical dependencies packages without start-order defined should rather be installed as last which only mandates setting a start-order on the lower layers while not setting a start-order on leaf packages won't do any harm. Additionally, a mechanism to bake a start-order defined in feature properties during the merge process would be beneficial. Any who's start-order would need to be set to a specific value would need to declare the feature property "default.content.startorder" > Make packages part of last execution plan if no start-order is defined > -- > > Key: SLING-7991 > URL: https://issues.apache.org/jira/browse/SLING-7991 > Project: Sling > Issue Type: Improvement > Components: Installer >Reporter: Dominik Süß >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > SLING-7871 introduces a mechanism that installs content-packages in one or > more execution plans for a deterministic, layer-able install sequence > (consumer adding a subsequent layer of installables via additional features > guaranteed to be processed later). > As by default the start-order is set to 0 by default a feature may not define > a position earlier than the ones without start-order. > As the installation sequence may be crucial due to the hierarchical > dependencies packages without start-order defined should rather be installed > last which only mandates setting a start-order on the lower layers while not > setting a start-order on leaf packages won't do any harm. > Additionally, a mechanism to bake a start-order defined in feature properties > during the merge process would be beneficial. Any who's start-order would > need to be set to a specific value would need to declare the feature property > "default.content.startorder" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8000) CMS - Convert modal dialog pages to a modal base
Jason E Bailey created SLING-8000: - Summary: CMS - Convert modal dialog pages to a modal base Key: SLING-8000 URL: https://issues.apache.org/jira/browse/SLING-8000 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: App CMS 0.10.2 currently the request for dialogs is returning the full page with a subsection to be pulled out for the modal dialog. create a new base page of modal and convert the pages to be a subtype of this page type where appropriate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Sling Type System: started a wiki page for concepts, ideas, motivation
On Tue, Oct 9, 2018, at 8:46 AM, Bertrand Delacretaz wrote: > Not sure what you mean by "apply other resourceTypes", do you mean by > changing the sling:resourceType property? > Specifically, in the RequestDispatcherOptions which is used by the sling:include taglib, you can force an overwrite of a resourceType to something else. Which is amazingly useful, but I wanted to point that out specifically, since I'm not changing the property. I'm changing what is used in the resourceType resolution.
[jira] [Commented] (SLING-7429) Improve basename handling
[
https://issues.apache.org/jira/browse/SLING-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643699#comment-16643699
]
Alexander Klimetschek commented on SLING-7429:
--
I would be very careful here risking any backwards incompatibility - even if at
first sight 2. sounds like a feature that has no real purpose. You never know
what folks might be doing and often just accidentally relying on such a
behaviour.
IIUC, you are proposing to turn this around and on empty string select all
dictionaries with no basename set or set to an empty string. What would be the
use case for that? (I read the link but it just talks about the IT tests)
If this is really needed, I would prefer if we come up with a new way that does
not break BC. For example, define a new string name that we can be sure is not
used, for example „__sling_basename_all_unset“ or something like that. If we
don’t want to change the Java API and introduce another method parameter...
> Improve basename handling
> -
>
> Key: SLING-7429
> URL: https://issues.apache.org/jira/browse/SLING-7429
> Project: Sling
> Issue Type: Improvement
> Components: i18n
>Affects Versions: i18n 2.5.12
>Reporter: Konrad Windszus
>Priority: Major
>
> Right now the basename handling according to
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names
> is as follows
> {quote}
> The base name argument can take one three values:
> # {{null}}, selects messages of mix:language nodes ignoring the existence or
> absence of sling:basename properties
> # Empty String, selects messages of mix:language nodes which have
> sling:basename properties, ignoring the actual values
> # Any other Value, selects messages of mix:language nodes whose
> sling:basename properties has any value which matches the base name string
> {quote}
> I think it should somehow be also possible for a client to explicitly select
> a resource bundle which is not having the {{sling:basename}} property set.
> This was originally triggered from
> https://issues.apache.org/jira/browse/SLING-7421?focusedCommentId=16335686=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335686.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin
Joey Smith created SLING-7999: - Summary: Add a `length` property to the AbstractRepeatPlugin Key: SLING-7999 URL: https://issues.apache.org/jira/browse/SLING-7999 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting HTL Java Compiler 1.0.26-1.4.0 Reporter: Joey Smith I have created a PR to add a length property to AbstractRepeatPlugin; this is primarily intended to allow users to do things like "Item of " when using a data-sly-list; the count/index property could already be used to derive the X, but it seemed there was no simple way to access the Y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
[
https://issues.apache.org/jira/browse/SLING-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643398#comment-16643398
]
ASF GitHub Bot commented on SLING-7998:
---
raducotescu commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't
report in which file it encountered an error when the location information is
available
URL:
https://github.com/apache/sling-org-apache-sling-feature-io/pull/5#issuecomment-428184698
Thanks a lot, guys!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The FeatureJSONReader doesn't report in which file it encountered an error
> when the location information is available
> -
>
> Key: SLING-7998
> URL: https://issues.apache.org/jira/browse/SLING-7998
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Radu Cotescu
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.1.4
>
>
> If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then
> the reader doesn't report in which file it encountered an error when the
> location information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] raducotescu commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
raducotescu commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/5#issuecomment-428184698 Thanks a lot, guys! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (SLING-7997) Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
[ https://issues.apache.org/jira/browse/SLING-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved SLING-7997. - Resolution: Fixed > Make the AnalyseFeaturesMojo been able to include/exclude Features to be > analyzed > - > > Key: SLING-7997 > URL: https://issues.apache.org/jira/browse/SLING-7997 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Currently, all Feature files are blindly analyzed, there is no way to skip a > Feature files set via the typical include/exclude Mojo pattern. > PR is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
[
https://issues.apache.org/jira/browse/SLING-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved SLING-7998.
-
Resolution: Fixed
Thanks for the fix [~radu.cotescu]!
> The FeatureJSONReader doesn't report in which file it encountered an error
> when the location information is available
> -
>
> Key: SLING-7998
> URL: https://issues.apache.org/jira/browse/SLING-7998
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Radu Cotescu
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.1.4
>
>
> If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then
> the reader doesn't report in which file it encountered an error when the
> location information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] bosschaert commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
bosschaert commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/5#issuecomment-428179516 Thanks for the pull request @raducotescu - it's merged! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
[
https://issues.apache.org/jira/browse/SLING-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643295#comment-16643295
]
ASF GitHub Bot commented on SLING-7998:
---
bosschaert commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't
report in which file it encountered an error when the location information is
available
URL:
https://github.com/apache/sling-org-apache-sling-feature-io/pull/5#issuecomment-428179516
Thanks for the pull request @raducotescu - it's merged!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The FeatureJSONReader doesn't report in which file it encountered an error
> when the location information is available
> -
>
> Key: SLING-7998
> URL: https://issues.apache.org/jira/browse/SLING-7998
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Radu Cotescu
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.1.4
>
>
> If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then
> the reader doesn't report in which file it encountered an error when the
> location information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] bosschaert closed pull request #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
bosschaert closed pull request #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
[
https://issues.apache.org/jira/browse/SLING-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643294#comment-16643294
]
ASF GitHub Bot commented on SLING-7998:
---
bosschaert closed pull request #5: SLING-7998 - The FeatureJSONReader doesn't
report in which file it encountered an error when the location information is
available
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The FeatureJSONReader doesn't report in which file it encountered an error
> when the location information is available
> -
>
> Key: SLING-7998
> URL: https://issues.apache.org/jira/browse/SLING-7998
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Radu Cotescu
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.1.4
>
>
> If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then
> the reader doesn't report in which file it encountered an error when the
> location information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Sling Type System: started a wiki page for concepts, ideas, motivation
Hi Jason, On Wed, Oct 3, 2018 at 2:44 PM Jason E Bailey wrote: > ...A resource can have a sling:resourceType which defines the process which > processes the resource. That is the default process, however > you can apply other resourceTypes to that resource so it's processed > differently based on your need Not sure what you mean by "apply other resourceTypes", do you mean by changing the sling:resourceType property? Then ok, you can do that now and as you say the scripts and servlets wired to the new resource type will do their best to handle it. > ...By assigning types to the resourceType you can define required/optional > fields and the types of actions that can occur on that resource... Yes that's the idea. > > This will then give you the ability to do the following > 1. generate meta data about the resource for use with a UI > 2. potentially used as a field validation if someone attempts to create a > resource type without the proper fields > 3. Will generate an error if they use something like sling:include to > override the default resourceType and the new resourceType requires > properties that the resource doesn't have Yes, sounds reasonable! -Bertrand
[jira] [Commented] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
[
https://issues.apache.org/jira/browse/SLING-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643232#comment-16643232
]
ASF GitHub Bot commented on SLING-7998:
---
simonetripodi commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't
report in which file it encountered an error when the location information is
available
URL:
https://github.com/apache/sling-org-apache-sling-feature-io/pull/5#issuecomment-428168705
LGTM!!! 磊
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The FeatureJSONReader doesn't report in which file it encountered an error
> when the location information is available
> -
>
> Key: SLING-7998
> URL: https://issues.apache.org/jira/browse/SLING-7998
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Radu Cotescu
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.1.4
>
>
> If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then
> the reader doesn't report in which file it encountered an error when the
> location information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
simonetripodi commented on issue #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/5#issuecomment-428168705 LGTM!!! 磊 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
[
https://issues.apache.org/jira/browse/SLING-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643224#comment-16643224
]
ASF GitHub Bot commented on SLING-7998:
---
raducotescu opened a new pull request #5: SLING-7998 - The FeatureJSONReader
doesn't report in which file it encountered an error when the location
information is available
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/5
* handle `javax.json.stream.JsonParsingException`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The FeatureJSONReader doesn't report in which file it encountered an error
> when the location information is available
> -
>
> Key: SLING-7998
> URL: https://issues.apache.org/jira/browse/SLING-7998
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Radu Cotescu
>Priority: Major
> Fix For: Feature Model IO 0.1.4
>
>
> If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then
> the reader doesn't report in which file it encountered an error when the
> location information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
[
https://issues.apache.org/jira/browse/SLING-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu reassigned SLING-7998:
---
Assignee: David Bosschaert
> The FeatureJSONReader doesn't report in which file it encountered an error
> when the location information is available
> -
>
> Key: SLING-7998
> URL: https://issues.apache.org/jira/browse/SLING-7998
> Project: Sling
> Issue Type: Bug
> Components: Feature Model
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Radu Cotescu
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.1.4
>
>
> If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then
> the reader doesn't report in which file it encountered an error when the
> location information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] raducotescu opened a new pull request #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
raducotescu opened a new pull request #5: SLING-7998 - The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/5 * handle `javax.json.stream.JsonParsingException` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7997) Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
[ https://issues.apache.org/jira/browse/SLING-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643220#comment-16643220 ] ASF GitHub Bot commented on SLING-7997: --- simonetripodi commented on issue #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6#issuecomment-428165126 My pleasure, it is super easy implementing new features when in a friendly environment! Thanks to you for the quick review! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make the AnalyseFeaturesMojo been able to include/exclude Features to be > analyzed > - > > Key: SLING-7997 > URL: https://issues.apache.org/jira/browse/SLING-7997 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Currently, all Feature files are blindly analyzed, there is no way to skip a > Feature files set via the typical include/exclude Mojo pattern. > PR is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] simonetripodi commented on issue #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
simonetripodi commented on issue #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6#issuecomment-428165126 My pleasure, it is super easy implementing new features when in a friendly environment! Thanks to you for the quick review! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bosschaert commented on issue #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
bosschaert commented on issue #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6#issuecomment-428164582 Thanks for the super quick implementation @simonetripodi ! It's merged :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7997) Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
[ https://issues.apache.org/jira/browse/SLING-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643219#comment-16643219 ] ASF GitHub Bot commented on SLING-7997: --- bosschaert commented on issue #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6#issuecomment-428164582 Thanks for the super quick implementation @simonetripodi ! It's merged :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make the AnalyseFeaturesMojo been able to include/exclude Features to be > analyzed > - > > Key: SLING-7997 > URL: https://issues.apache.org/jira/browse/SLING-7997 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Currently, all Feature files are blindly analyzed, there is no way to skip a > Feature files set via the typical include/exclude Mojo pattern. > PR is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7997) Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
[ https://issues.apache.org/jira/browse/SLING-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643217#comment-16643217 ] ASF GitHub Bot commented on SLING-7997: --- bosschaert closed pull request #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make the AnalyseFeaturesMojo been able to include/exclude Features to be > analyzed > - > > Key: SLING-7997 > URL: https://issues.apache.org/jira/browse/SLING-7997 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Currently, all Feature files are blindly analyzed, there is no way to skip a > Feature files set via the typical include/exclude Mojo pattern. > PR is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7998) The FeatureJSONReader doesn't report in which file it encountered an error when the location information is available
Radu Cotescu created SLING-7998:
---
Summary: The FeatureJSONReader doesn't report in which file it
encountered an error when the location information is available
Key: SLING-7998
URL: https://issues.apache.org/jira/browse/SLING-7998
Project: Sling
Issue Type: Bug
Components: Feature Model
Affects Versions: Feature Model IO 0.1.2
Reporter: Radu Cotescu
Fix For: Feature Model IO 0.1.4
If a JSON file is invalid and is passed to the {{FeatureJSONReader}}, then the
reader doesn't report in which file it encountered an error when the location
information is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] bosschaert closed pull request #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
bosschaert closed pull request #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (SLING-7996) Don't ignore feature Analyzer thrown error in the Mojo
[
https://issues.apache.org/jira/browse/SLING-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved SLING-7996.
-
Resolution: Fixed
> Don't ignore feature Analyzer thrown error in the Mojo
> --
>
> Key: SLING-7996
> URL: https://issues.apache.org/jira/browse/SLING-7996
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> It happens that Analyzer Tasks, such as the {{bundle-content}} for example,
> don't report the detected error in the {{AnalyserTaskContext}} but rather,
> for unrelated reasons, an exception is thrown.
> That exception is actually ignored by the Mojo, which is limited to reporting
> that an error occurred, while it is crucial for users understanding what's
> the reason behind any possible failure.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7996) Don't ignore feature Analyzer thrown error in the Mojo
[
https://issues.apache.org/jira/browse/SLING-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643170#comment-16643170
]
ASF GitHub Bot commented on SLING-7996:
---
simonetripodi commented on issue #5: SLING-7996 - Don't ignore feature Analyzer
thrown error in the Mojo
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/5#issuecomment-428159973
thanks to you! :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't ignore feature Analyzer thrown error in the Mojo
> --
>
> Key: SLING-7996
> URL: https://issues.apache.org/jira/browse/SLING-7996
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> It happens that Analyzer Tasks, such as the {{bundle-content}} for example,
> don't report the detected error in the {{AnalyserTaskContext}} but rather,
> for unrelated reasons, an exception is thrown.
> That exception is actually ignored by the Mojo, which is limited to reporting
> that an error occurred, while it is crucial for users understanding what's
> the reason behind any possible failure.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] simonetripodi commented on issue #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo
simonetripodi commented on issue #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/5#issuecomment-428159973 thanks to you! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7997) Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
[ https://issues.apache.org/jira/browse/SLING-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643165#comment-16643165 ] ASF GitHub Bot commented on SLING-7997: --- simonetripodi opened a new pull request #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6 initial implementation of include/exclude pattern for Features to be analyzed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make the AnalyseFeaturesMojo been able to include/exclude Features to be > analyzed > - > > Key: SLING-7997 > URL: https://issues.apache.org/jira/browse/SLING-7997 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Currently, all Feature files are blindly analyzed, there is no way to skip a > Feature files set via the typical include/exclude Mojo pattern. > PR is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] simonetripodi opened a new pull request #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
simonetripodi opened a new pull request #6: SLING-7997 - Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/6 initial implementation of include/exclude pattern for Features to be analyzed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SLING-7997) Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed
[ https://issues.apache.org/jira/browse/SLING-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-7997: -- Summary: Make the AnalyseFeaturesMojo been able to include/exclude Features to be analyzed (was: Make the AnalyseFeaturesMojo been able to include/exclude Features to be eanalyzed) > Make the AnalyseFeaturesMojo been able to include/exclude Features to be > analyzed > - > > Key: SLING-7997 > URL: https://issues.apache.org/jira/browse/SLING-7997 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Currently, all Feature files are blindly analyzed, there is no way to skip a > Feature files set via the typical include/exclude Mojo pattern. > PR is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7996) Don't ignore feature Analyzer thrown error in the Mojo
[
https://issues.apache.org/jira/browse/SLING-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643129#comment-16643129
]
ASF GitHub Bot commented on SLING-7996:
---
bosschaert commented on issue #5: SLING-7996 - Don't ignore feature Analyzer
thrown error in the Mojo
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/5#issuecomment-428152723
Thanks @simonetripodi !
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't ignore feature Analyzer thrown error in the Mojo
> --
>
> Key: SLING-7996
> URL: https://issues.apache.org/jira/browse/SLING-7996
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> It happens that Analyzer Tasks, such as the {{bundle-content}} for example,
> don't report the detected error in the {{AnalyserTaskContext}} but rather,
> for unrelated reasons, an exception is thrown.
> That exception is actually ignored by the Mojo, which is limited to reporting
> that an error occurred, while it is crucial for users understanding what's
> the reason behind any possible failure.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7996) Don't ignore feature Analyzer thrown error in the Mojo
[
https://issues.apache.org/jira/browse/SLING-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643128#comment-16643128
]
ASF GitHub Bot commented on SLING-7996:
---
bosschaert closed pull request #5: SLING-7996 - Don't ignore feature Analyzer
thrown error in the Mojo
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't ignore feature Analyzer thrown error in the Mojo
> --
>
> Key: SLING-7996
> URL: https://issues.apache.org/jira/browse/SLING-7996
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> It happens that Analyzer Tasks, such as the {{bundle-content}} for example,
> don't report the detected error in the {{AnalyserTaskContext}} but rather,
> for unrelated reasons, an exception is thrown.
> That exception is actually ignored by the Mojo, which is limited to reporting
> that an error occurred, while it is crucial for users understanding what's
> the reason behind any possible failure.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7990) Define an initial version of the Feature Model JSON Shema
[ https://issues.apache.org/jira/browse/SLING-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643127#comment-16643127 ] David Bosschaert commented on SLING-7990: - Hi [~simone.tripodi], yes maybe something like this. For example have a test in the build system that executes schema validator on some feature files to check that they pass (or fail if expected) the validation. > Define an initial version of the Feature Model JSON Shema > - > > Key: SLING-7990 > URL: https://issues.apache.org/jira/browse/SLING-7990 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 0.1.2 >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > Fix For: Feature Model 0.1.4 > > > As discussed in dev@ ML, there are multiple advantage of adopting such schema: > * to have a formal and standard way to describe the Feature data structure > in JSON model; > > * to provide an easy way to assist users on editing Feature json files in > the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; > * to separate the input validation - it can be delegated by the Feature > Analyzer - and the parser phases (which should just take care of transforming > the JSON data to the Feature model) > PS is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bosschaert commented on issue #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo
bosschaert commented on issue #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/5#issuecomment-428152723 Thanks @simonetripodi ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bosschaert closed pull request #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo
bosschaert closed pull request #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-7997) Make the AnalyseFeaturesMojo been able to include/exclude Features to be eanalyzed
Simone Tripodi created SLING-7997: - Summary: Make the AnalyseFeaturesMojo been able to include/exclude Features to be eanalyzed Key: SLING-7997 URL: https://issues.apache.org/jira/browse/SLING-7997 Project: Sling Issue Type: Improvement Components: Feature Model, Maven Plugins and Archetypes Reporter: Simone Tripodi Assignee: David Bosschaert Currently, all Feature files are blindly analyzed, there is no way to skip a Feature files set via the typical include/exclude Mojo pattern. PR is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7429) Improve basename handling
[
https://issues.apache.org/jira/browse/SLING-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643099#comment-16643099
]
Konrad Windszus commented on SLING-7429:
I propose to change 2. to
{quote}Empty String, selects messages of mix:language nodes which have no
sling:basename property or one with an empty value{quote}
I think this is way more in line what the user expects. This is a potentially
backward-incompatible change though, but I don't can come up with a use case
where you are actually interested in dictionaries having arbitrary (but
explicitly set) basenames.
[~alexander.klimetschek] Since you contributed a lot to i18n in the past, WDYT
about this?
> Improve basename handling
> -
>
> Key: SLING-7429
> URL: https://issues.apache.org/jira/browse/SLING-7429
> Project: Sling
> Issue Type: Improvement
> Components: i18n
>Affects Versions: i18n 2.5.12
>Reporter: Konrad Windszus
>Priority: Major
>
> Right now the basename handling according to
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html#resourcebundle-with-base-names
> is as follows
> {quote}
> The base name argument can take one three values:
> # {{null}}, selects messages of mix:language nodes ignoring the existence or
> absence of sling:basename properties
> # Empty String, selects messages of mix:language nodes which have
> sling:basename properties, ignoring the actual values
> # Any other Value, selects messages of mix:language nodes whose
> sling:basename properties has any value which matches the base name string
> {quote}
> I think it should somehow be also possible for a client to explicitly select
> a resource bundle which is not having the {{sling:basename}} property set.
> This was originally triggered from
> https://issues.apache.org/jira/browse/SLING-7421?focusedCommentId=16335686=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335686.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7756) Improve logging for Job retries
[
https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643082#comment-16643082
]
Konrad Windszus commented on SLING-7756:
[~indra2gurjar]
Sorry for the late answer, but I think the log level is actually fine for the
retry (i.e. for case [1]) but should be definitely enriched so that it is
clearer that a retry has been issued.
For the case [0] I think we should switch to a WARN at least and include there
information about number of retries as well.
> Improve logging for Job retries
> ---
>
> Key: SLING-7756
> URL: https://issues.apache.org/jira/browse/SLING-7756
> Project: Sling
> Issue Type: Improvement
> Components: Event
>Affects Versions: Event 4.2.10
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently a {{JobConsumer}} returning {{JobResult.FAILED}} is usually retried
> (https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html).
> Unfortunately this is not exposed in the logs, so in case a JobConsumer logs
> an error before returning {{JobResult.FAILED}} the job is silently retried
> without any particular log message. I think each failed job should lead to a
> WARN in the log (in case the job is retried) with the attempt number and
> outstanding attempts in the log message. In case a job is not retried, an
> ERROR should be emitted to the log for every failed job.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7995) [pipes] Manifold pipe not registered in PlumberServlet
[ https://issues.apache.org/jira/browse/SLING-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Popescu resolved SLING-7995. --- Resolution: Fixed PR: https://github.com/apache/sling-org-apache-sling-pipes/pull/8 > [pipes] Manifold pipe not registered in PlumberServlet > -- > > Key: SLING-7995 > URL: https://issues.apache.org/jira/browse/SLING-7995 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 3.0.2 >Reporter: Stefan Popescu >Priority: Major > Fix For: pipes 3.1.0 > > > Can't start a root Manifold pipe via http, as the type is not registered with > PlumberServlet. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] simonetripodi opened a new pull request #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo
simonetripodi opened a new pull request #5: SLING-7996 - Don't ignore feature Analyzer thrown error in the Mojo URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/5 detected exception is not ignored This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7996) Don't ignore feature Analyzer thrown error in the Mojo
[
https://issues.apache.org/jira/browse/SLING-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643080#comment-16643080
]
ASF GitHub Bot commented on SLING-7996:
---
simonetripodi opened a new pull request #5: SLING-7996 - Don't ignore feature
Analyzer thrown error in the Mojo
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/5
detected exception is not ignored
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't ignore feature Analyzer thrown error in the Mojo
> --
>
> Key: SLING-7996
> URL: https://issues.apache.org/jira/browse/SLING-7996
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Major
>
> It happens that Analyzer Tasks, such as the {{bundle-content}} for example,
> don't report the detected error in the {{AnalyserTaskContext}} but rather,
> for unrelated reasons, an exception is thrown.
> That exception is actually ignored by the Mojo, which is limited to reporting
> that an error occurred, while it is crucial for users understanding what's
> the reason behind any possible failure.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7996) Don't ignore feature Analyzer thrown error in the Mojo
Simone Tripodi created SLING-7996:
-
Summary: Don't ignore feature Analyzer thrown error in the Mojo
Key: SLING-7996
URL: https://issues.apache.org/jira/browse/SLING-7996
Project: Sling
Issue Type: Improvement
Components: Feature Model, Maven Plugins and Archetypes
Reporter: Simone Tripodi
Assignee: David Bosschaert
It happens that Analyzer Tasks, such as the {{bundle-content}} for example,
don't report the detected error in the {{AnalyserTaskContext}} but rather, for
unrelated reasons, an exception is thrown.
That exception is actually ignored by the Mojo, which is limited to reporting
that an error occurred, while it is crucial for users understanding what's the
reason behind any possible failure.
PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7995) [pipes] Manifold pipe not registered in PlumberServlet
[ https://issues.apache.org/jira/browse/SLING-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Popescu updated SLING-7995: -- Summary: [pipes] Manifold pipe not registered in PlumberServlet (was: [pipes] Maniofold pipe not registered in PlumberServlet) > [pipes] Manifold pipe not registered in PlumberServlet > -- > > Key: SLING-7995 > URL: https://issues.apache.org/jira/browse/SLING-7995 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 3.0.2 >Reporter: Stefan Popescu >Priority: Major > Fix For: pipes 3.1.0 > > > Can't start a root Manifold pipe via http, as the type is not registered with > PlumberServlet. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7995) [pipes] Maniofold pipe not registered in PlumberServlet
Stefan Popescu created SLING-7995: - Summary: [pipes] Maniofold pipe not registered in PlumberServlet Key: SLING-7995 URL: https://issues.apache.org/jira/browse/SLING-7995 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: pipes 3.0.2 Reporter: Stefan Popescu Fix For: pipes 3.1.0 Can't start a root Manifold pipe via http, as the type is not registered with PlumberServlet. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7992) make package pipe folding its filters
[
https://issues.apache.org/jira/browse/SLING-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-7992:
---
Fix Version/s: pipes 3.1.0
> make package pipe folding its filters
> -
>
> Key: SLING-7992
> URL: https://issues.apache.org/jira/browse/SLING-7992
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.1.0
>
>
> packaging resources about to change is pretty handy, but filters are not
> meant to be used for each single resource to save.
> Would be nice to have something like {{maxFilters}} and {{reductionDepth}}
> that transforms at best following set, with {{maxFilters=1}} and
> {{reductionDepth=3}}
> - /content/foo/bar/1
> - /content/foo/bar/2
> in
> - /content/foo/bar
> if not possible to satisfy the constraints, it just does nothing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7993) create some karate tests for pipes http api integration tests
[ https://issues.apache.org/jira/browse/SLING-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7993: --- Fix Version/s: pipes 3.1.0 > create some karate tests for pipes http api integration tests > - > > Key: SLING-7993 > URL: https://issues.apache.org/jira/browse/SLING-7993 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 3.0.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 3.1.0 > > > would be nice to have clear and "documenting" karate tests of pipes http API -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7994) add skipExecution flag to pipes
[ https://issues.apache.org/jira/browse/SLING-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7994: --- Fix Version/s: pipes 3.1.0 > add skipExecution flag to pipes > --- > > Key: SLING-7994 > URL: https://issues.apache.org/jira/browse/SLING-7994 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 3.0.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 3.1.0 > > > add a skipExecution flag to pipe, and the superpipe's behaviour to ignore > execution of a subpipe with that flag set -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7994) add skipExecution flag to pipes
Nicolas Peltier created SLING-7994: -- Summary: add skipExecution flag to pipes Key: SLING-7994 URL: https://issues.apache.org/jira/browse/SLING-7994 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 3.0.2 Reporter: Nicolas Peltier add a skipExecution flag to pipe, and the superpipe's behaviour to ignore execution of a subpipe with that flag set -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7990) Define an initial version of the Feature Model JSON Shema
[ https://issues.apache.org/jira/browse/SLING-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643056#comment-16643056 ] Simone Tripodi commented on SLING-7990: --- Hi [~bosschaert] thanks a lot for merging my PR, very appreciated! I fear I didn't get the question - do you mean a way to check that the schema keeps evolving with the model implementation and that doesn't get easily lost/outdated? > Define an initial version of the Feature Model JSON Shema > - > > Key: SLING-7990 > URL: https://issues.apache.org/jira/browse/SLING-7990 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 0.1.2 >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > Fix For: Feature Model 0.1.4 > > > As discussed in dev@ ML, there are multiple advantage of adopting such schema: > * to have a formal and standard way to describe the Feature data structure > in JSON model; > > * to provide an easy way to assist users on editing Feature json files in > the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; > * to separate the input validation - it can be delegated by the Feature > Analyzer - and the parser phases (which should just take care of transforming > the JSON data to the Feature model) > PS is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7990) Define an initial version of the Feature Model JSON Shema
[ https://issues.apache.org/jira/browse/SLING-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643054#comment-16643054 ] ASF GitHub Bot commented on SLING-7990: --- simonetripodi commented on issue #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema URL: https://github.com/apache/sling-org-apache-sling-feature/pull/6#issuecomment-428127771 a-w-e-s-o-m-e, thanks! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Define an initial version of the Feature Model JSON Shema > - > > Key: SLING-7990 > URL: https://issues.apache.org/jira/browse/SLING-7990 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 0.1.2 >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > Fix For: Feature Model 0.1.4 > > > As discussed in dev@ ML, there are multiple advantage of adopting such schema: > * to have a formal and standard way to describe the Feature data structure > in JSON model; > > * to provide an easy way to assist users on editing Feature json files in > the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; > * to separate the input validation - it can be delegated by the Feature > Analyzer - and the parser phases (which should just take care of transforming > the JSON data to the Feature model) > PS is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] simonetripodi commented on issue #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema
simonetripodi commented on issue #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema URL: https://github.com/apache/sling-org-apache-sling-feature/pull/6#issuecomment-428127771 a-w-e-s-o-m-e, thanks! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-7993) create some karate tests for pipes http api integration tests
Nicolas Peltier created SLING-7993: -- Summary: create some karate tests for pipes http api integration tests Key: SLING-7993 URL: https://issues.apache.org/jira/browse/SLING-7993 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 3.0.2 Reporter: Nicolas Peltier would be nice to have clear and "documenting" karate tests of pipes http API -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7992) make package pipe folding its filters
[
https://issues.apache.org/jira/browse/SLING-7992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-7992:
---
Summary: make package pipe folding its filters (was: make pipes more handy
for backups)
> make package pipe folding its filters
> -
>
> Key: SLING-7992
> URL: https://issues.apache.org/jira/browse/SLING-7992
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
>
> packaging resources about to change is pretty handy, but filters are not
> meant to be used for each single resource to save.
> Would be nice to have something like {{maxFilters}} and {{reductionDepth}}
> that transforms at best following set, with {{maxFilters=1}} and
> {{reductionDepth=3}}
> - /content/foo/bar/1
> - /content/foo/bar/2
> in
> - /content/foo/bar
> if not possible to satisfy the constraints, it just does nothing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7992) make pipes more handy for backups
Nicolas Peltier created SLING-7992:
--
Summary: make pipes more handy for backups
Key: SLING-7992
URL: https://issues.apache.org/jira/browse/SLING-7992
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: pipes 3.0.2
Reporter: Nicolas Peltier
packaging resources about to change is pretty handy, but filters are not meant
to be used for each single resource to save.
Would be nice to have something like {{maxFilters}} and {{reductionDepth}}
that transforms at best following set, with {{maxFilters=1}} and
{{reductionDepth=3}}
- /content/foo/bar/1
- /content/foo/bar/2
in
- /content/foo/bar
if not possible to satisfy the constraints, it just does nothing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7990) Define an initial version of the Feature Model JSON Shema
[ https://issues.apache.org/jira/browse/SLING-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643029#comment-16643029 ] David Bosschaert commented on SLING-7990: - Hi [~simone.tripodi] thanks for the pull request. Would it also be possible to have some sort of automated use of the schema as part of the maven build/test to ensure that it doesn't get out of sync? > Define an initial version of the Feature Model JSON Shema > - > > Key: SLING-7990 > URL: https://issues.apache.org/jira/browse/SLING-7990 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 0.1.2 >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > Fix For: Feature Model 0.1.4 > > > As discussed in dev@ ML, there are multiple advantage of adopting such schema: > * to have a formal and standard way to describe the Feature data structure > in JSON model; > > * to provide an easy way to assist users on editing Feature json files in > the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; > * to separate the input validation - it can be delegated by the Feature > Analyzer - and the parser phases (which should just take care of transforming > the JSON data to the Feature model) > PS is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7990) Define an initial version of the Feature Model JSON Shema
[ https://issues.apache.org/jira/browse/SLING-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643019#comment-16643019 ] ASF GitHub Bot commented on SLING-7990: --- bosschaert closed pull request #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema URL: https://github.com/apache/sling-org-apache-sling-feature/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Define an initial version of the Feature Model JSON Shema > - > > Key: SLING-7990 > URL: https://issues.apache.org/jira/browse/SLING-7990 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 0.1.2 >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > Fix For: Feature Model 0.1.4 > > > As discussed in dev@ ML, there are multiple advantage of adopting such schema: > * to have a formal and standard way to describe the Feature data structure > in JSON model; > > * to provide an easy way to assist users on editing Feature json files in > the right way inside IDEs, as shown in Eclipse[3] and IntelliJ[4]; > * to separate the input validation - it can be delegated by the Feature > Analyzer - and the parser phases (which should just take care of transforming > the JSON data to the Feature model) > PS is coming -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bosschaert closed pull request #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema
bosschaert closed pull request #6: SLING-7990 - Define an initial version of the Feature Model JSON Shema URL: https://github.com/apache/sling-org-apache-sling-feature/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642992#comment-16642992 ] ASF GitHub Bot commented on SLING-7988: --- simonetripodi commented on issue #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#issuecomment-428114272 Priceless @bosschaert , thanks for taking care of it! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642994#comment-16642994 ] ASF GitHub Bot commented on SLING-7988: --- simonetripodi commented on issue #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4#issuecomment-428114479 My pleasure @bosschaert , I am always glad to cooperate and positively contribute :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] simonetripodi commented on issue #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
simonetripodi commented on issue #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#issuecomment-428114272 Priceless @bosschaert , thanks for taking care of it! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] simonetripodi commented on issue #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
simonetripodi commented on issue #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4#issuecomment-428114479 My pleasure @bosschaert , I am always glad to cooperate and positively contribute :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642983#comment-16642983 ] ASF GitHub Bot commented on SLING-7988: --- bosschaert commented on issue #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4#issuecomment-428111775 Thanks @simonetripodi your pull request is merged! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved SLING-7988. - Resolution: Fixed > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bosschaert commented on issue #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
bosschaert commented on issue #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4#issuecomment-428111775 Thanks @simonetripodi your pull request is merged! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bosschaert closed pull request #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
bosschaert closed pull request #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642982#comment-16642982 ] ASF GitHub Bot commented on SLING-7988: --- bosschaert closed pull request #4: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642977#comment-16642977 ] ASF GitHub Bot commented on SLING-7988: --- bosschaert commented on issue #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#issuecomment-428110278 Thanks @simonetripodi your pull request is merged! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bosschaert commented on issue #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
bosschaert commented on issue #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5#issuecomment-428110278 Thanks @simonetripodi your pull request is merged! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-7988) Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
[ https://issues.apache.org/jira/browse/SLING-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642976#comment-16642976 ] ASF GitHub Bot commented on SLING-7988: --- bosschaert closed pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks > in the Maven plugin > - > > Key: SLING-7988 > URL: https://issues.apache.org/jira/browse/SLING-7988 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Simone Tripodi >Assignee: David Bosschaert >Priority: Major > > Current Maven Feature Plugin Analyze MOJO executes all tasks in the > classpath, it should be possible to select them via the typical > include/exclude plugin configuration pattern. > A first initial modification is needed in the Analyzer component, I am going > to submit a PR about it - once applied, the Maven plugin can be modified in > order to select tasks to perform during the analysis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bosschaert closed pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin
bosschaert closed pull request #5: SLING-7988 - Allow Analyzer include/exclude tasks by id, in order to enable specific Tasks in the Maven plugin URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DominikSuess commented on issue #18: SLING-7991 - setting order to Integer.MAX_VALUE for processing last i…
DominikSuess commented on issue #18: SLING-7991 - setting order to Integer.MAX_VALUE for processing last i… URL: https://github.com/apache/sling-whiteboard/pull/18#issuecomment-428086840 Mistake on merging - accidental delete of 3rd changes - reopened correctly rebased. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (SLING-7991) Make packages part of last execution plan if no start-order is defined
[ https://issues.apache.org/jira/browse/SLING-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642891#comment-16642891 ] Dominik Süß edited comment on SLING-7991 at 10/9/18 7:18 AM: - https://github.com/apache/sling-whiteboard/pull/19 for patch was (Author: dsuess): https://github.com/apache/sling-whiteboard/pull/18 for patch > Make packages part of last execution plan if no start-order is defined > -- > > Key: SLING-7991 > URL: https://issues.apache.org/jira/browse/SLING-7991 > Project: Sling > Issue Type: Improvement > Components: Installer >Reporter: Dominik Süß >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > SLING-7871 introduces a mechanism that installs content-packages in one or > more execution plans for a deterministic, layer-able install sequence > (consumer adding a subsequent layer of installables via additional features > guaranteed to be processed later). > As by default the start-order is set to 0 by default a feature may not define > a position earlier then the ones without start-order. > As the installation sequence may be crucial due to the hierarchical > dependencies packages without start-order defined should rather be installed > as last which only mandates setting a start-order on the lower layers while > not setting a start-order on leaf packages won't do any harm. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] DominikSuess opened a new pull request #19: SLING-7991 - setting order to Integer.MAX_VALUE for processing last i…
DominikSuess opened a new pull request #19: SLING-7991 - setting order to Integer.MAX_VALUE for processing last i… URL: https://github.com/apache/sling-whiteboard/pull/19 …f start-order is not set. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DominikSuess closed pull request #18: SLING-7991 - setting order to Integer.MAX_VALUE for processing last i…
DominikSuess closed pull request #18: SLING-7991 - setting order to
Integer.MAX_VALUE for processing last i…
URL: https://github.com/apache/sling-whiteboard/pull/18
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitmodules b/.gitmodules
index c366639..e69de29 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,4 +0,0 @@
-[submodule "scripting-resolver/sling-org-apache-sling-scripting-sightly"]
- path = scripting-resolver/sling-org-apache-sling-scripting-sightly
- url =
https://github.com/apache/sling-org-apache-sling-scripting-sightly.git
- branch = experimental-scripting-resolver
diff --git
a/featuremodel/feature-content-extension/src/main/java/org/apache/sling/feature/extension/content/ContentHandler.java
b/featuremodel/feature-content-extension/src/main/java/org/apache/sling/feature/extension/content/ContentHandler.java
index e19ba12..8a84ddb 100644
---
a/featuremodel/feature-content-extension/src/main/java/org/apache/sling/feature/extension/content/ContentHandler.java
+++
b/featuremodel/feature-content-extension/src/main/java/org/apache/sling/feature/extension/content/ContentHandler.java
@@ -95,7 +95,14 @@ public boolean handle(Extension extension,
LauncherPrepareContext prepareContext
&&
extension.getName().equals(FeatureConstants.EXTENSION_NAME_CONTENT_PACKAGES)) {
MultiValueMap orderedArtifacts = MultiValueMap.decorate(new
LinkedHashMap>());
for (final Artifact a : extension.getArtifacts()) {
-orderedArtifacts.put(Integer.valueOf(a.getStartOrder()), a);
+int order;
+// content-packages without explicit start-order to be
installed last
+if (a.getMetadata().get(Artifact.KEY_START_ORDER) != null) {
+order = Integer.valueOf(a.getStartOrder());
+} else {
+order = Integer.MAX_VALUE;
+}
+orderedArtifacts.put(order, a);
}
List executionPlans = new ArrayList();
for (Object key : orderedArtifacts.keySet()) {
diff --git a/scripting-resolver/sling-org-apache-sling-scripting-sightly
b/scripting-resolver/sling-org-apache-sling-scripting-sightly
deleted file mode 16
index 81312ca..000
--- a/scripting-resolver/sling-org-apache-sling-scripting-sightly
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 81312cae81b0ebf2b78f0a78e13e11a276435e94
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (SLING-7991) Make packages part of last execution plan if no start-order is defined
[ https://issues.apache.org/jira/browse/SLING-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642891#comment-16642891 ] Dominik Süß commented on SLING-7991: https://github.com/apache/sling-whiteboard/pull/18 for patch > Make packages part of last execution plan if no start-order is defined > -- > > Key: SLING-7991 > URL: https://issues.apache.org/jira/browse/SLING-7991 > Project: Sling > Issue Type: Improvement > Components: Installer >Reporter: Dominik Süß >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > SLING-7871 introduces a mechanism that installs content-packages in one or > more execution plans for a deterministic, layer-able install sequence > (consumer adding a subsequent layer of installables via additional features > guaranteed to be processed later). > As by default the start-order is set to 0 by default a feature may not define > a position earlier then the ones without start-order. > As the installation sequence may be crucial due to the hierarchical > dependencies packages without start-order defined should rather be installed > as last which only mandates setting a start-order on the lower layers while > not setting a start-order on leaf packages won't do any harm. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] DominikSuess opened a new pull request #18: SLING-7991 - setting order to Integer.MAX_VALUE for processing last i…
DominikSuess opened a new pull request #18: SLING-7991 - setting order to Integer.MAX_VALUE for processing last i… URL: https://github.com/apache/sling-whiteboard/pull/18 …f start-order is not set. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-7991) Make packages part of last execution plan if no start-order is defined
Dominik Süß created SLING-7991: -- Summary: Make packages part of last execution plan if no start-order is defined Key: SLING-7991 URL: https://issues.apache.org/jira/browse/SLING-7991 Project: Sling Issue Type: Improvement Components: Installer Reporter: Dominik Süß SLING-7871 introduces a mechanism that installs content-packages in one or more execution plans for a deterministic, layer-able install sequence (consumer adding a subsequent layer of installables via additional features guaranteed to be processed later). As by default the start-order is set to 0 by default a feature may not define a position earlier then the ones without start-order. As the installation sequence may be crucial due to the hierarchical dependencies packages without start-order defined should rather be installed as last which only mandates setting a start-order on the lower layers while not setting a start-order on leaf packages won't do any harm. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
