[jira] [Created] (SLING-9068) Add more context to ParseException
Angela Schreiber created SLING-9068:
---
Summary: Add more context to ParseException
Key: SLING-9068
URL: https://issues.apache.org/jira/browse/SLING-9068
Project: Sling
Issue Type: Improvement
Components: Repoinit
Reporter: Angela Schreiber
today the repo init grammar doesn't come with dedicated exception handing and
thus the parser will fail with messages that can make it hard to spot actual
problem... specially in a lengthy repo-init as it is present with Adobe AEM.
Example:
{code}
org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
at line 115, column 46.
Was expecting:
")" ...
at
org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:3095)
[org.apache.sling.repoinit.parser:1.3.2]
{code}
if i am not mistaken this should be doable be adding explicit exceptions to the
grammar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes
cziegeler commented on a change in pull request #49: Replacement PR for #41
with a clean set of changes
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r378670520
##
File path:
src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
##
@@ -62,9 +113,6 @@
@Override
public void execute() throws MojoExecutionException, MojoFailureException {
-if (includeArtifactClassifier == null) {
Review comment:
If you allow "null", you need to handle it below in line 123
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes
cziegeler commented on a change in pull request #49: Replacement PR for #41
with a clean set of changes
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r378670321
##
File path:
src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
##
@@ -119,4 +186,61 @@ private void includeArtifact(final Feature f, final
String extensionName, final
}
container.add(art);
}
+
+private void installFMDescriptor(File file, Feature feature) {
+Collection artifacts =
Collections.synchronizedCollection(new ArrayList<>());
+if(file.exists() && file.canRead()) {
+getLog().debug("FM File to be installed: " +
file.getAbsolutePath());
+// Need to create a new Artifact Handler for the different
extension and an Artifact to not
+// change the module artifact
+DefaultArtifactHandler fmArtifactHandler = new
DefaultArtifactHandler("slingosgifeature");
+ArtifactId artifactId = feature.getId();
+DefaultArtifact fmArtifact = new DefaultArtifact(
+artifactId.getGroupId(), artifactId.getArtifactId(),
artifactId.getVersion(),
+null, "slingosgifeature", artifactId.getClassifier(),
fmArtifactHandler
+);
+fmArtifact.setFile(file);
+artifacts.add(fmArtifact);
+project.addAttachedArtifact(fmArtifact);
+} else {
+getLog().error("Could not find FM Descriptor File: " + file);
+}
+}
+
+private void addDependencies(Feature feature) {
+// Add Dependencies if configured so
+for(String includeDependencyScope: includeDependenciesWithScope) {
+List dependencies = project.getDependencies();
+getLog().info("Project Dependencies: " + dependencies);
+for(Dependency dependency: dependencies) {
+if(includeDependencyScope.equals(dependency.getScope())) {
+getLog().info("Include Artifact: " + dependencies);
+ArtifactId id = new ArtifactId(
+dependency.getGroupId(), dependency.getArtifactId(),
dependency.getVersion(), dependency.getClassifier(), dependency.getType()
+);
+Artifact artifact = new Artifact(id);
+if(bundlesStartOrder >= 0) {
+artifact.setStartOrder(bundlesStartOrder);
+}
+feature.getBundles().add(artifact);
+}
+}
+}
+}
+
+private void includeFeatures(Map selection, Feature
feature) {
Review comment:
This inclusion looks strange - why do we only pick extensions and framework
properties? Why not bundles, configurations?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes
cziegeler commented on a change in pull request #49: Replacement PR for #41
with a clean set of changes
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r378670202
##
File path:
src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
##
@@ -90,12 +138,29 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
ProjectHelper.getFeatures(this.project).put(key, found);
ProjectHelper.getAssembledFeatures(this.project).put(key, found);
}
+getLog().debug("Found Feature: " + found + ", artifact: " + art);
includeArtifact(found, includeArtifactExtension, art);
+getLog().debug("Feature Key: " + key + ", feature from key: " +
ProjectHelper.getAssembledFeatures(this.project).get(key));
includeArtifact(ProjectHelper.getAssembledFeatures(this.project).get(key),
includeArtifactExtension,
art.copy(art.getId()));
+
+addDependencies(found);
+
+// Obtain any features from Source folder and add any Extensions to
the target feature
+final FeatureSelectionConfig featureSelectionConfig = new
FeatureSelectionConfig();
+featureSelectionConfig.setFilesInclude("**/*.json" );
+if(file != null) {
+featureSelectionConfig.setFilesExclude("**/" + file.getName());
+}
+final Map selection =
this.getSelectedFeatures(featureSelectionConfig);
+
+includeFeatures(selection, found);
+
+// Write the Feature into its file and install it
if (file != null) {
try ( final Writer writer = new FileWriter(file)) {
FeatureJSONWriter.write(writer, found);
+installFMDescriptor(file, found);
Review comment:
Attaching of the artifact should not be part of this mojo - the feature is
added to the project artifacts and therefore the AttachFeaturesMojo will attach
it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
RE: [VOTE] Release Apache Sling Content Distribution API 0.4.0, Content Distribution Core 0.4.2, Content Distribution Journal Core 0.1.8
+1
[jira] [Commented] (SLING-9067) Fix build errors with Java 11
[ https://issues.apache.org/jira/browse/SLING-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035496#comment-17035496 ] Carsten Ziegeler commented on SLING-9067: - Fixed in rev 6b95010 The IndexOutOfBoundsException in RepPolicyEntryHandler was caused by a wrong stack handling for nested XML elements. For some reason, this does not cause an exception in Java 8, but does in >= Java 11. I fixed the stack handling. The XML output errors were caused by two problems: indenting of XML in a transformer is set to indent by "0" spaces in Java 8, but to "4" spaces in Java >= 11. This results in different output. As the RepPolicyEntryHandlerTest tests test for an exact output which was not considering indention at all, this failed. I changed the code to always use "4" spaces and adjusted the test accordingly > Fix build errors with Java 11 > - > > Key: SLING-9067 > URL: https://issues.apache.org/jira/browse/SLING-9067 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.10 > > > When building with Java 11, three test errors occur, one > IndexOutOfBoundsException and two XML output format related errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9067) Fix build errors with Java 11
[ https://issues.apache.org/jira/browse/SLING-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-9067: Description: When building with Java 11, three test errors occur in RepPolicyEntryHandlerTest, one IndexOutOfBoundsException and two XML output format related errors (was: When building with Java 11, three test errors occur, one IndexOutOfBoundsException and two XML output format related errors) > Fix build errors with Java 11 > - > > Key: SLING-9067 > URL: https://issues.apache.org/jira/browse/SLING-9067 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.10 > > > When building with Java 11, three test errors occur in > RepPolicyEntryHandlerTest, one IndexOutOfBoundsException and two XML output > format related errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9067) Fix build errors with Java 11
[ https://issues.apache.org/jira/browse/SLING-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9067. - Resolution: Fixed > Fix build errors with Java 11 > - > > Key: SLING-9067 > URL: https://issues.apache.org/jira/browse/SLING-9067 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.8 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.10 > > > When building with Java 11, three test errors occur in > RepPolicyEntryHandlerTest, one IndexOutOfBoundsException and two XML output > format related errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9067) Fix build errors with Java 11
Carsten Ziegeler created SLING-9067: --- Summary: Fix build errors with Java 11 Key: SLING-9067 URL: https://issues.apache.org/jira/browse/SLING-9067 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Content-Package to Feature Model Converter 1.0.8 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Content-Package to Feature Model Converter 1.0.10 When building with Java 11, three test errors occur, one IndexOutOfBoundsException and two XML output format related errors -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Content Distribution API 0.4.0, Content Distribution Core 0.4.2, Content Distribution Journal Core 0.1.8
+1 (non-binding) - Andy > On Feb 12, 2020, at 5:15 AM, Timothee Maret wrote: > > Hi, > > This vote covers three releases: > > 1. Content Distribution API 0.4.0 > > We solved 3 issues: > https://issues.apache.org/jira/projects/SLING/versions/12341697 > > 2. Content Distribution Core 0.4.2 > > We solved 10 issues: > https://issues.apache.org/jira/projects/SLING/versions/12345400 > and moved outstanding issues: > https://issues.apache.org/jira/projects/SLING/versions/12346959 > > 3. Content Distribution Journal Core 0.1.8 > > We solved 18 issues: > https://issues.apache.org/jira/projects/SLING/versions/12346586 > and moved one outstanding issue: > https://issues.apache.org/jira/projects/SLING/versions/12346963 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2198/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2198 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.
[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler merged pull request #27: SLING-9066 - separating collecting of affected entries from updating …
cziegeler merged pull request #27: SLING-9066 - separating collecting of affected entries from updating … URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SLING-9065) Incorrect error handling for content distribution if binary is not present in blob store
[ https://issues.apache.org/jira/browse/SLING-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035435#comment-17035435 ] Timothee Maret commented on SLING-9065: --- This issue and SLING-9052 seem to share the same symptom, not considering a failure as an failed attempt. > Incorrect error handling for content distribution if binary is not present in > blob store > > > Key: SLING-9065 > URL: https://issues.apache.org/jira/browse/SLING-9065 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Affects Versions: Content Distribution Journal Core 0.1.6 >Reporter: Christian Schneider >Priority: Major > > We did a content distribution and the publisher used a different blob store. > So the reference to the binary could not be resolved. > We get a stack trace like below but the ui just shows the queue as running > with 0 retries. So it seems the error is not handled correctly. > [https://gist.github.com/cschneider/c663fa7912b4e643c9d761aa8b70906f] -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Security 1.1.18
+1 On Tue, Feb 11, 2020 at 10:54 AM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy Schaefer > > > On Feb 11, 2020, at 2:15 AM, Robert Munteanu wrote: > > > > Hi, > > > > We solved 3 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12344172 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2196/ > > > > You can use this UNIX script to download the release and verify the > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2196 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards, > > Robert Munteanu > >
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.8
+1 On Tue, Feb 11, 2020 at 2:26 PM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy Schaefer > > > On Feb 11, 2020, at 8:44 AM, dav...@apache.org wrote: > > > > Hi all, > > > > I would like to call the release of the Feature Model API Regions Runtime > > Fragment 1.0.8 > > > > We fixed the following issue: > > https://issues.apache.org/jira/projects/SLING/versions/12346854 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2197 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2197 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Best regards, > > > > David > >
Re: [VOTE] Release Apache Sling Content Distribution API 0.4.0, Content Distribution Core 0.4.2, Content Distribution Journal Core 0.1.8
+1 On Wed, Feb 12, 2020 at 8:15 AM Timothee Maret wrote: > Hi, > > This vote covers three releases: > > 1. Content Distribution API 0.4.0 > > We solved 3 issues: > https://issues.apache.org/jira/projects/SLING/versions/12341697 > > 2. Content Distribution Core 0.4.2 > > We solved 10 issues: > https://issues.apache.org/jira/projects/SLING/versions/12345400 > and moved outstanding issues: > https://issues.apache.org/jira/projects/SLING/versions/12346959 > > 3. Content Distribution Journal Core 0.1.8 > > We solved 18 issues: > https://issues.apache.org/jira/projects/SLING/versions/12346586 > and moved one outstanding issue: > https://issues.apache.org/jira/projects/SLING/versions/12346963 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2198/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2198 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #27: SLING-9066 - separating collecting of affected entries from updating …
kwin commented on a change in pull request #27: SLING-9066 - separating
collecting of affected entries from updating …
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/27#discussion_r378271839
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java
##
@@ -198,14 +200,18 @@ public File getEntry(String path) {
}
public void updateDependencies(Map>
mutableContentsIds) {
+Map> matches = new HashMap<>();
for (Dependency dependency : dependencies) {
Review comment:
why not using
https://docs.oracle.com/javase/8/docs/api/java/util/Iterator.html#remove--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #27: SLING-9066 - separating collecting of affected entries from updating …
kwin commented on a change in pull request #27: SLING-9066 - separating
collecting of affected entries from updating …
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/27#discussion_r378271839
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java
##
@@ -198,14 +200,18 @@ public File getEntry(String path) {
}
public void updateDependencies(Map>
mutableContentsIds) {
+Map> matches = new HashMap<>();
for (Dependency dependency : dependencies) {
Review comment:
why not using
https://docs.oracle.com/javase/8/docs/api/java/util/Iterator.html#remove--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on issue #27: SLING-9066 - separating collecting of affected entries from updating …
sonarcloud[bot] commented on issue #27: SLING-9066 - separating collecting of affected entries from updating … URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/27#issuecomment-585214958 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=27=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=27=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=27=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=27=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=27=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess opened a new pull request #27: SLING-9066 - separating collecting of affected entries from updating …
DominikSuess opened a new pull request #27: SLING-9066 - separating collecting of affected entries from updating … URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/27 …of collection to prevent ConcurrentModificationException This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-9066) Dependency updates can lead to ConcurrentModificationException
Dominik Süß created SLING-9066: -- Summary: Dependency updates can lead to ConcurrentModificationException Key: SLING-9066 URL: https://issues.apache.org/jira/browse/SLING-9066 Project: Sling Issue Type: Bug Components: Content-Package to Feature Model Converter Affects Versions: Content-Package to Feature Model Converter 1.0.8 Reporter: Dominik Süß The adjustments of dependencies as introduced with SLING-8649 currently iterate over the dependencies while modifying the collection which can lead to a ConcurrentModificationException. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #582 is FIXED
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/582/ for details. No further emails will be sent until the status of the build is changed.
[VOTE] Release Apache Sling Content Distribution API 0.4.0, Content Distribution Core 0.4.2, Content Distribution Journal Core 0.1.8
Hi, This vote covers three releases: 1. Content Distribution API 0.4.0 We solved 3 issues: https://issues.apache.org/jira/projects/SLING/versions/12341697 2. Content Distribution Core 0.4.2 We solved 10 issues: https://issues.apache.org/jira/projects/SLING/versions/12345400 and moved outstanding issues: https://issues.apache.org/jira/projects/SLING/versions/12346959 3. Content Distribution Journal Core 0.1.8 We solved 18 issues: https://issues.apache.org/jira/projects/SLING/versions/12346586 and moved one outstanding issue: https://issues.apache.org/jira/projects/SLING/versions/12346963 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2198/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2198 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Created] (SLING-9065) Incorrect error handling for content distribution if binary is not present in blob store
Christian Schneider created SLING-9065: -- Summary: Incorrect error handling for content distribution if binary is not present in blob store Key: SLING-9065 URL: https://issues.apache.org/jira/browse/SLING-9065 Project: Sling Issue Type: Bug Components: Content Distribution Affects Versions: Content Distribution Journal Core 0.1.6 Reporter: Christian Schneider We did a content distribution and the publisher used a different blob store. So the reference to the binary could not be resolved. We get a stack trace like below but the ui just shows the queue as running with 0 retries. So it seems the error is not handled correctly. [https://gist.github.com/cschneider/c663fa7912b4e643c9d761aa8b70906f] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9064) Javadoc use self-closing elements and invalid characters
[
https://issues.apache.org/jira/browse/SLING-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-9064.
---
Resolution: Fixed
> Javadoc use self-closing elements and invalid characters
>
>
> Key: SLING-9064
> URL: https://issues.apache.org/jira/browse/SLING-9064
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution API 0.4.0
>
>
> The Javadoc contains invalid characters like {{>}} and self closing elements
> like {{}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9064) Javadoc use self-closing elements and invalid characters
[
https://issues.apache.org/jira/browse/SLING-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035322#comment-17035322
]
Timothee Maret commented on SLING-9064:
---
Done in
[4870792678effd78902b3908e3e0465841e345b1|https://github.com/apache/sling-org-apache-sling-distribution-api/commit/4870792678effd78902b3908e3e0465841e345b1]
> Javadoc use self-closing elements and invalid characters
>
>
> Key: SLING-9064
> URL: https://issues.apache.org/jira/browse/SLING-9064
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution API 0.4.0
>
>
> The Javadoc contains invalid characters like {{>}} and self closing elements
> like {{}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9064) Javadoc use self-closing elements and invalid characters
Timothee Maret created SLING-9064:
-
Summary: Javadoc use self-closing elements and invalid characters
Key: SLING-9064
URL: https://issues.apache.org/jira/browse/SLING-9064
Project: Sling
Issue Type: Bug
Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
Fix For: Content Distribution API 0.4.0
The Javadoc contains invalid characters like {{>}} and self closing elements
like {{}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9017) ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
[
https://issues.apache.org/jira/browse/SLING-9017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-9017:
--
Fix Version/s: Content Distribution Core 0.4.4
> ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
> --
>
> Key: SLING-9017
> URL: https://issues.apache.org/jira/browse/SLING-9017
> Project: Sling
> Issue Type: Bug
>Reporter: Ashish Chopra
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, {{ErrorQueueDispatchingStrategy}} [0] interface dictates that the
> {{.add}} [1] method supplies the {{DistributionQueueProvider}} [1] to it.
> For {{ForwardDistributionAgentFactory}} (and perhaps other Agent-factories as
> well), this {{DistributionQueueProvider}} is further used to {{.getQueue}} by
> a name [2].
> As the discussion in SLING-8854 concluded, it was found acceptable [3] for
> {{DistributionQueue}} impls and {{DistributionQueueProvider}} impls to share
> state - concordantly, there needs to be a way for Agent-Factories to dictate
> which _specific_ queue-providers they want {{ErrorQueueDispatchingStrategy}}
> to use.
> One approach to make that happen would be to enhance
> {{ErrorQueueDispatchingStrategy}} with another CTOR to accept a
> {{DistributionQueueProvider}} argument. The impl of {{.add}} can then treat
> the supplied {{DistributionQueueProvider}} at the time of API invocation as a
> 'hint' and ignore it if the {{ErrorQueueDispatchingStrategy}} already has one
> of its own.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java#L56
> [2]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L187
> [3]
> https://issues.apache.org/jira/browse/SLING-8854?focusedCommentId=16982396=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16982396
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9017) ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
[
https://issues.apache.org/jira/browse/SLING-9017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-9017:
--
Component/s: Content Distribution
> ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
> --
>
> Key: SLING-9017
> URL: https://issues.apache.org/jira/browse/SLING-9017
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Ashish Chopra
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, {{ErrorQueueDispatchingStrategy}} [0] interface dictates that the
> {{.add}} [1] method supplies the {{DistributionQueueProvider}} [1] to it.
> For {{ForwardDistributionAgentFactory}} (and perhaps other Agent-factories as
> well), this {{DistributionQueueProvider}} is further used to {{.getQueue}} by
> a name [2].
> As the discussion in SLING-8854 concluded, it was found acceptable [3] for
> {{DistributionQueue}} impls and {{DistributionQueueProvider}} impls to share
> state - concordantly, there needs to be a way for Agent-Factories to dictate
> which _specific_ queue-providers they want {{ErrorQueueDispatchingStrategy}}
> to use.
> One approach to make that happen would be to enhance
> {{ErrorQueueDispatchingStrategy}} with another CTOR to accept a
> {{DistributionQueueProvider}} argument. The impl of {{.add}} can then treat
> the supplied {{DistributionQueueProvider}} at the time of API invocation as a
> 'hint' and ignore it if the {{ErrorQueueDispatchingStrategy}} already has one
> of its own.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java#L56
> [2]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L187
> [3]
> https://issues.apache.org/jira/browse/SLING-8854?focusedCommentId=16982396=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16982396
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9046) Provide analyser that checks bundles for embedded bundles
[ https://issues.apache.org/jira/browse/SLING-9046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-9046. --- Fix Version/s: (was: Feature Model Analyser 1.2.6) Resolution: Won't Fix I'm marking this as won't fix since I think it cannot be reliably detected. [~radu] please reopen if you disagree. > Provide analyser that checks bundles for embedded bundles > - > > Key: SLING-9046 > URL: https://issues.apache.org/jira/browse/SLING-9046 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Radu Cotescu >Priority: Major > > When using the feature model, a bundle should not embed other bundles. The > feature launcher and the framework should manage bundle lifecycles, not > bundles. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8965) Avoid committing for each skipped package
[ https://issues.apache.org/jira/browse/SLING-8965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-8965. Resolution: Fixed Seems I solved this problem in a different sling issue. > Avoid committing for each skipped package > -- > > Key: SLING-8965 > URL: https://issues.apache.org/jira/browse/SLING-8965 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.1.8 > > > With the SLING-8908 change, we ensure that all package messages (even skipped > ones) are marked as processed. By design, we mark processed package by > committing to the local repository. Committing to the repository is not cheap > and we should minimise it. For setups that generate a lot of skipped packages > such as A) multiple farms support with multiple consumer agents or B) > multi-region deployments with varying latencies, the amount of commits will > increase even more. > To reduce the commits, we should either redo SLING-8908 such that skipped > offsets are kept in memory or simply only commit skipped packages as > aggregates (e.g. 1 commits for 10 skipped packages). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8965) Avoid committing for each skipped package
[ https://issues.apache.org/jira/browse/SLING-8965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-8965: --- Fix Version/s: Content Distribution Journal Core 0.1.8 > Avoid committing for each skipped package > -- > > Key: SLING-8965 > URL: https://issues.apache.org/jira/browse/SLING-8965 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.1.8 > > > With the SLING-8908 change, we ensure that all package messages (even skipped > ones) are marked as processed. By design, we mark processed package by > committing to the local repository. Committing to the repository is not cheap > and we should minimise it. For setups that generate a lot of skipped packages > such as A) multiple farms support with multiple consumer agents or B) > multi-region deployments with varying latencies, the amount of commits will > increase even more. > To reduce the commits, we should either redo SLING-8908 such that skipped > offsets are kept in memory or simply only commit skipped packages as > aggregates (e.g. 1 commits for 10 skipped packages). -- This message was sent by Atlassian Jira (v8.3.4#803005)
