[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on pull request #46: SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrictions
rombert commented on pull request #46: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46#issuecomment-853613164 Thanks for the PR @henrykuijpers ! I'll not merge it immediately as @kwin has some concerns on whether this is the right thing to do. If we end up going this way, we will need the branch to be rebased as it has conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10038) review and resolve code quality warnings and issues reported by sonar
[ https://issues.apache.org/jira/browse/SLING-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10038. - Resolution: Fixed Marking this as resolved Currently sonar reports 16 issues of which 3 are warnings about removing deprecated code at some point and the other 13 are all warnings about reducing cognitive complexity which can maybe be considered later. 16 Issues 0 Bugs 0 Vulnerabilities 0 Security Hotspots 16 Code Smells > review and resolve code quality warnings and issues reported by sonar > - > > Key: SLING-10038 > URL: https://issues.apache.org/jira/browse/SLING-10038 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Minor > Fix For: JCR Jackrabbit Access Manager 3.0.10 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently sonar reports 89 Issues in the project: > 1 Bug > 4 Vulnerabilities > 84 Code Smells -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10452) adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce post request
[
https://issues.apache.org/jira/browse/SLING-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman resolved SLING-10452.
-
Resolution: Fixed
Merged PR at:
[{{fb71bfb}}|https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-accessmanager/commit/fb71bfb95d89a1ff6981e4eaeb824ec28965e2a5]
> adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce
> post request
>
>
> Key: SLING-10452
> URL: https://issues.apache.org/jira/browse/SLING-10452
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.0.10
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When the modifyAce/deleteAce servlets receive an illegal or invalid :redirect
> parameter it should return a status code of
> [422|https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422] instead of
> 200 because the request was not fully successful.
> Currently, the illegal :redirect parameter value is detected and a warning is
> logged. The request continues to be processed without the redirect
> occurring. The client has no indication that something went wrong without
> reviewing the server logs.
> For example:
> Illegal redirect
> {code:java}
> curl -F principalId=myuser -F privilege@jcr:read=granted -F
> :redirect=https://sling.apache.org
> http://localhost:8080/test/node.modifyAce.html
> {code}
> invalid redirect
> {code:java}
> curl -F principalId=myuser -F privilege@jcr:read=granted -F
> :redirect=https:// http://localhost:8080/test/node.modifyAce.html{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10454) CMS Reference - Crypto Configuration Fails due to Content Configuration
[ https://issues.apache.org/jira/browse/SLING-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10454. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/d46582b62024c11c24104677a94e4cfded7867c1 > CMS Reference - Crypto Configuration Fails due to Content Configuration > --- > > Key: SLING-10454 > URL: https://issues.apache.org/jira/browse/SLING-10454 > Project: Sling > Issue Type: Bug > Components: App CMS Reference >Affects Versions: App CMS 1.0.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.0.4 > > > When attempting to create a "default" Commons Crypto configuration via the > Sling Feature Model, the Feature Model configuration will be overridden by > the default settings provided in the Reference app. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-jackrabbit-accessmanager] enapps-enorman merged pull request #4: SLING-10452 adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce post reque
enapps-enorman merged pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-accessmanager/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-10454) CMS Reference - Crypto Configuration Fails due to Content Configuration
Dan Klco created SLING-10454: Summary: CMS Reference - Crypto Configuration Fails due to Content Configuration Key: SLING-10454 URL: https://issues.apache.org/jira/browse/SLING-10454 Project: Sling Issue Type: Bug Components: App CMS Reference Affects Versions: App CMS 1.0.2 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.0.4 When attempting to create a "default" Commons Crypto configuration via the Sling Feature Model, the Feature Model configuration will be overridden by the default settings provided in the Reference app. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10453) Update to Sling Bundle Parent 41
[ https://issues.apache.org/jira/browse/SLING-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10453. -- Resolution: Done > Update to Sling Bundle Parent 41 > > > Key: SLING-10453 > URL: https://issues.apache.org/jira/browse/SLING-10453 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Scripting Java 2.1.8 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10453) Update to Sling Bundle Parent 41
Oliver Lietz created SLING-10453: Summary: Update to Sling Bundle Parent 41 Key: SLING-10453 URL: https://issues.apache.org/jira/browse/SLING-10453 Project: Sling Issue Type: Task Components: Scripting Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Scripting Java 2.1.8 -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Scripting Java 2.1.6
Hi Stefan, I think we should take the time to make the bundle buildable with Java 11 and above. I’ll try to create an issue for it tomorrow. Thanks, Radu On Wed, 2 Jun 2021 at 19:55, Stefan Seifert wrote: > oh, your're right - build runs fine with java 8. > maybe we should add a maven enforcer rule to make sure the build is > failing in java > 8 with an appropriate message. > > here is my +1 on this release. > > stefan > > >-Original Message- > >From: Stefan Seifert > >Sent: Wednesday, June 2, 2021 7:01 PM > >To: dev@sling.apache.org > >Subject: RE: [VOTE] Release Apache Sling Scripting Java 2.1.6 > > > >i'm not able to run the unit tests locally (tested on windows and in a > unix > >VM) - i always get the same error as on Jenkins: > >https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache- > >sling-scripting-java/job/master/52/console > > > >[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun- > >plugin:1.8:run (set-bundle-required-execution-environment) on project > >org.apache.sling.scripting.java: An Ant BuildException has occured: Unable > >to create javax script engine for javascript > >[ERROR] around Ant part ...
Re: [VOTE] Release Apache Sling Scripting Java 2.1.6
+1 regards, Karl On Wednesday, June 2, 2021, Stefan Seifert wrote: > oh, your're right - build runs fine with java 8. > maybe we should add a maven enforcer rule to make sure the build is > failing in java > 8 with an appropriate message. > > here is my +1 on this release. > > stefan > > >-Original Message- > >From: Stefan Seifert > >Sent: Wednesday, June 2, 2021 7:01 PM > >To: dev@sling.apache.org > >Subject: RE: [VOTE] Release Apache Sling Scripting Java 2.1.6 > > > >i'm not able to run the unit tests locally (tested on windows and in a > unix > >VM) - i always get the same error as on Jenkins: > >https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache- > >sling-scripting-java/job/master/52/console > > > >[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun- > >plugin:1.8:run (set-bundle-required-execution-environment) on project > >org.apache.sling.scripting.java: An Ant BuildException has occured: > Unable > >to create javax script engine for javascript > >[ERROR] around Ant part ...
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #86: SLING-10450 ContentPackage2FeatureModelConverter now implements
sonarcloud[bot] commented on pull request #86: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/86#issuecomment-853276405 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&metric=new_coverage&view=list) [50.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=86&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin opened a new pull request #86: SLING-10450 ContentPackage2FeatureModelConverter now implements
kwin opened a new pull request #86: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/86 Closeable makes it possible to use with try..with..resources cleanup usage from CP2FMCLauncher -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-10450) ContentPackage2FeatureModelConverter.java should implement Closeable
[
https://issues.apache.org/jira/browse/SLING-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-10450:
---
Assignee: Konrad Windszus
> ContentPackage2FeatureModelConverter.java should implement Closeable
>
>
> Key: SLING-10450
> URL: https://issues.apache.org/jira/browse/SLING-10450
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> Forgetting to call {{cleanup}} on the
> {{ContentPackage2FeatureModelConverter}} leads to big dangling temp folders.
> To allow semantic code checks detect such failures, the class should
> implement {{Closeable}} and call {{cleanup}} in its {{close}} method.
> Look at [https://github.com/adobe/aemanalyser-maven-plugin/issues/76] for a
> concrete issue caused by this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-jackrabbit-accessmanager] sonarcloud[bot] commented on pull request #4: SLING-10452 adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce pos
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-accessmanager/pull/4#issuecomment-853266759 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&metric=new_coverage&view=list) [92.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-jackrabbit-accessmanager&pullRequest=4&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #46: SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrict
sonarcloud[bot] removed a comment on pull request #46: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46#issuecomment-853227172 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [94.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #46: SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrictions
sonarcloud[bot] commented on pull request #46: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46#issuecomment-853265748 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [94.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] Release Apache Sling Scripting Java 2.1.6
oh, your're right - build runs fine with java 8. maybe we should add a maven enforcer rule to make sure the build is failing in java > 8 with an appropriate message. here is my +1 on this release. stefan >-Original Message- >From: Stefan Seifert >Sent: Wednesday, June 2, 2021 7:01 PM >To: dev@sling.apache.org >Subject: RE: [VOTE] Release Apache Sling Scripting Java 2.1.6 > >i'm not able to run the unit tests locally (tested on windows and in a unix >VM) - i always get the same error as on Jenkins: >https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache- >sling-scripting-java/job/master/52/console > >[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun- >plugin:1.8:run (set-bundle-required-execution-environment) on project >org.apache.sling.scripting.java: An Ant BuildException has occured: Unable >to create javax script engine for javascript >[ERROR] around Ant part ...
[GitHub] [sling-org-apache-sling-jcr-jackrabbit-accessmanager] enapps-enorman opened a new pull request #4: SLING-10452 adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce post
enapps-enorman opened a new pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-accessmanager/pull/4 When the modifyAce/deleteAce servlets receive an illegal or invalid :redirect parameter it should return a status code of 422 instead of 200 because the request was not fully successful. Currently, the illegal :redirect parameter value is detected and a warning is logged. The request continues to be processed without the redirect occurring. The client has no indication that something went wrong without reviewing the server logs. For example: Illegal redirect curl -F principalId=myuser -F privilege@jcr:read=granted -F :redirect=https://sling.apache.org http://localhost:8080/test/node.modifyAce.html invalid redirect curl -F principalId=myuser -F privilege@jcr:read=granted -F :redirect=https:// http://localhost:8080/test/node.modifyAce.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Scripting Java 2.1.6
Hi Stefan, You need to run this on Java 8, unfortunately. Cheers, Radu > On 2 Jun 2021, at 19:01, Stefan Seifert > wrote: > > i'm not able to run the unit tests locally (tested on windows and in a unix > VM) - i always get the same error as on Jenkins: > https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-scripting-java/job/master/52/console > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-antrun-plugin:1.8:run > (set-bundle-required-execution-environment) on project > org.apache.sling.scripting.java: An Ant BuildException has occured: Unable to > create javax script engine for javascript > [ERROR] around Ant part ...
[jira] [Updated] (SLING-10452) adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce post request
[
https://issues.apache.org/jira/browse/SLING-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman updated SLING-10452:
Description:
When the modifyAce/deleteAce servlets receive an illegal or invalid :redirect
parameter it should return a status code of
[422|https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422] instead of
200 because the request was not fully successful.
Currently, the illegal :redirect parameter value is detected and a warning is
logged. The request continues to be processed without the redirect occurring.
The client has no indication that something went wrong without reviewing the
server logs.
For example:
Illegal redirect
{code:java}
curl -F principalId=myuser -F privilege@jcr:read=granted -F
:redirect=https://sling.apache.org
http://localhost:8080/test/node.modifyAce.html
{code}
invalid redirect
{code:java}
curl -F principalId=myuser -F privilege@jcr:read=granted -F :redirect=https://
http://localhost:8080/test/node.modifyAce.html{code}
was:
When the modifyAce/deleteAce servlets receive an illegal or invalid :redirect
parameter it should return a status code of
[422|https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422] instead of
200 because the request was not fully successful.
Currently, the illegal :redirect parameter value is detected and a warning is
logged. The request continues to be processed without the redirect occurring.
The client has no indication that something went wrong without reviewing the
server logs.
For example:
Illegal redirect
{{}}
{code:java}
curl -F principalId=myuser -F privilege@jcr:read=granted -F
:redirect=https://sling.apache.org
http://localhost:8080/test/node.modifyAce.html
{code}
invalid redirect
{{}}
{code:java}
curl -F principalId=myuser -F privilege@jcr:read=granted -F :redirect=https://
http://localhost:8080/test/node.modifyAce.html{code}
{{}}
{{}}
> adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce
> post request
>
>
> Key: SLING-10452
> URL: https://issues.apache.org/jira/browse/SLING-10452
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.0.10
>
>
> When the modifyAce/deleteAce servlets receive an illegal or invalid :redirect
> parameter it should return a status code of
> [422|https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422] instead of
> 200 because the request was not fully successful.
> Currently, the illegal :redirect parameter value is detected and a warning is
> logged. The request continues to be processed without the redirect
> occurring. The client has no indication that something went wrong without
> reviewing the server logs.
> For example:
> Illegal redirect
> {code:java}
> curl -F principalId=myuser -F privilege@jcr:read=granted -F
> :redirect=https://sling.apache.org
> http://localhost:8080/test/node.modifyAce.html
> {code}
> invalid redirect
> {code:java}
> curl -F principalId=myuser -F privilege@jcr:read=granted -F
> :redirect=https:// http://localhost:8080/test/node.modifyAce.html{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10452) adjust HTTP status code for invalid :redirect value for modifyAce/deleteAce post request
Eric Norman created SLING-10452:
---
Summary: adjust HTTP status code for invalid :redirect value for
modifyAce/deleteAce post request
Key: SLING-10452
URL: https://issues.apache.org/jira/browse/SLING-10452
Project: Sling
Issue Type: Improvement
Reporter: Eric Norman
Assignee: Eric Norman
Fix For: JCR Jackrabbit Access Manager 3.0.10
When the modifyAce/deleteAce servlets receive an illegal or invalid :redirect
parameter it should return a status code of
[422|https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422] instead of
200 because the request was not fully successful.
Currently, the illegal :redirect parameter value is detected and a warning is
logged. The request continues to be processed without the redirect occurring.
The client has no indication that something went wrong without reviewing the
server logs.
For example:
Illegal redirect
{{}}
{code:java}
curl -F principalId=myuser -F privilege@jcr:read=granted -F
:redirect=https://sling.apache.org
http://localhost:8080/test/node.modifyAce.html
{code}
invalid redirect
{{}}
{code:java}
curl -F principalId=myuser -F privilege@jcr:read=granted -F :redirect=https://
http://localhost:8080/test/node.modifyAce.html{code}
{{}}
{{}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10441) make discovery independent from scheduler thread pools
[
https://issues.apache.org/jira/browse/SLING-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355874#comment-17355874
]
Stefan Egli commented on SLING-10441:
-
bq. (actually just realized the check is only in one of the two changes - I'll
update that)
scratch that - the other case is for connectors where it's not always the
scheduler invoking the task - besides one warning is enough (it will show up
regularly anyway, upon every topology change)
> make discovery independent from scheduler thread pools
> --
>
> Key: SLING-10441
> URL: https://issues.apache.org/jira/browse/SLING-10441
> Project: Sling
> Issue Type: Task
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20, Discovery Impl 1.2.12,
> Discovery Base 2.0.8, Discovery Oak 1.2.30
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently discovery uses the commons.scheduler for a few but mission critical
> cases. Since the commons.scheduler doesn't guarantee timely execution - eg
> when the corresponding thread pool is full - discovery should become
> independent of commons.scheduler.
> The easiest solution is to spawn {{new Thread}} in those few cases. This
> shouldn't be problematic since these activities are not happening on a high
> frequency and are only short-lived.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10441) make discovery independent from scheduler thread pools
[
https://issues.apache.org/jira/browse/SLING-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355869#comment-17355869
]
Stefan Egli commented on SLING-10441:
-
{quote}If we end up using a dedicated thread pool {quote}
That's what I have done now in those PRs yes, a dedicated pool. And a check in
case the wrong pool is used (actually just realized the check is only in one of
the two changes - I'll update that).
Will do some more (integration) testing but wanted to post the PRs already now.
> make discovery independent from scheduler thread pools
> --
>
> Key: SLING-10441
> URL: https://issues.apache.org/jira/browse/SLING-10441
> Project: Sling
> Issue Type: Task
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20, Discovery Impl 1.2.12,
> Discovery Base 2.0.8, Discovery Oak 1.2.30
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently discovery uses the commons.scheduler for a few but mission critical
> cases. Since the commons.scheduler doesn't guarantee timely execution - eg
> when the corresponding thread pool is full - discovery should become
> independent of commons.scheduler.
> The easiest solution is to spawn {{new Thread}} in those few cases. This
> shouldn't be problematic since these activities are not happening on a high
> frequency and are only short-lived.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10441) make discovery independent from scheduler thread pools
[
https://issues.apache.org/jira/browse/SLING-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355868#comment-17355868
]
Stefan Egli commented on SLING-10441:
-
Created 2 PRs that depend on each other (via SNAPSHOT dependency) :
* https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/2
* https://github.com/apache/sling-org-apache-sling-discovery-base/pull/4
The discovery.oak bundle might not need to be updated (but has changes pending
as well, so I'd do a release anyway)
> make discovery independent from scheduler thread pools
> --
>
> Key: SLING-10441
> URL: https://issues.apache.org/jira/browse/SLING-10441
> Project: Sling
> Issue Type: Task
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20, Discovery Impl 1.2.12,
> Discovery Base 2.0.8, Discovery Oak 1.2.30
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently discovery uses the commons.scheduler for a few but mission critical
> cases. Since the commons.scheduler doesn't guarantee timely execution - eg
> when the corresponding thread pool is full - discovery should become
> independent of commons.scheduler.
> The easiest solution is to spawn {{new Thread}} in those few cases. This
> shouldn't be problematic since these activities are not happening on a high
> frequency and are only short-lived.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #46: SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrict
sonarcloud[bot] removed a comment on pull request #46: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46#issuecomment-853214408 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [94.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #46: SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrictions
sonarcloud[bot] commented on pull request #46: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46#issuecomment-853227172 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [94.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli commented on pull request #4: SLING-10441 : use dedicated 'discovery' thread pool for scheduler ins…
stefan-egli commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/4#issuecomment-853226433 > Note that this is part 1/3 as all 3 discovery.commons/.base/.oak need to be updated it's actually only 2 parts, discovery.commons and .base. The discovery.oak bundle can be updated independently (or later) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-commons] stefan-egli commented on pull request #2: SLING-10441 : use dedicated 'discovery' thread pool for scheduler ins…
stefan-egli commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/2#issuecomment-853226383 > Note that this is part 1/3 as all 3 discovery.commons/.base/.oak need to be updated it's actually only 2 parts, discovery.commons and .base. The discovery.oak bundle can be updated independently (or later) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] Release Apache Sling Scripting Java 2.1.6
i'm not able to run the unit tests locally (tested on windows and in a unix VM) - i always get the same error as on Jenkins: https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-scripting-java/job/master/52/console [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (set-bundle-required-execution-environment) on project org.apache.sling.scripting.java: An Ant BuildException has occured: Unable to create javax script engine for javascript [ERROR] around Ant part ...
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #46: SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrictions
sonarcloud[bot] commented on pull request #46: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46#issuecomment-853214408 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [94.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=46&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355862#comment-17355862 ] Henry Kuijpers commented on SLING-10447: Proposed PR here: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46 > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > Time Spent: 10m > Remaining Estimate: 0h > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
RE: [VOTE] Release Apache Sling Engine 2.7.6, JCR Base 3.1.8, and Content-Package to Feature Model Converter 1.1.4
+1
RE: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.8
+1
RE: [VOTE] Release Apache Sling Parent and Bundle Parent 43
+1
[GitHub] [sling-org-apache-sling-resourceresolver] henrykuijpers opened a new pull request #46: SLING-10447 Improve the querys that are used to load vanity paths, by specifying path restrictions
henrykuijpers opened a new pull request #46: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli opened a new pull request #4: SLING-10441 : use dedicated 'discovery' thread pool for scheduler ins…
stefan-egli opened a new pull request #4: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/4 …tead of relying on availability on default thread pool Note that this is part 2/3 as all 3 discovery.commons/.base/.oak need to be updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Engine 2.7.6, JCR Base 3.1.8, and Content-Package to Feature Model Converter 1.1.4
+1 > On 2 Jun 2021, at 16:29, Karl Pauls wrote: > > Please vote to approve these releases: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ...
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.8
+1 > On 2 Jun 2021, at 12:13, dav...@apache.org wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Don't release, because ...
[jira] [Commented] (SLING-8738) Trigger an error during build if an API uses a private reference in its public methods' signatures
[
https://issues.apache.org/jira/browse/SLING-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355847#comment-17355847
]
Radu Cotescu commented on SLING-8738:
-
Thanks for handling this and sorry for not seeing your question earlier!
> Trigger an error during build if an API uses a private reference in its
> public methods' signatures
> --
>
> Key: SLING-8738
> URL: https://issues.apache.org/jira/browse/SLING-8738
> Project: Sling
> Issue Type: Improvement
> Components: General
>Reporter: Radu Cotescu
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Bundle Parent 43
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Following the discussion from https://github.com/bndtools/bnd/issues/3444, we
> should add the provided {{-fixupmessages}} instruction to our bundle parent
> pom, in order to make sure that APIs that we export cannot reference private
> references in their public method signatures.
> This is more of a precaution, rather than a fix for a Sling issue.
> Projects using the bundle parent pom can override the bnd instruction
> locally, if needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10451) ContentPackage2FeatureModel leaves empty "slingfeature" folders in the java tmp directory
[
https://issues.apache.org/jira/browse/SLING-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10451:
Issue Type: Bug (was: Improvement)
> ContentPackage2FeatureModel leaves empty "slingfeature" folders in the java
> tmp directory
> -
>
> Key: SLING-10451
> URL: https://issues.apache.org/jira/browse/SLING-10451
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> With every run of cp2fm empty folders starting with prefix {{slingfeature}}
> and followed by a random number are left in the java tmp folder. Those should
> be properly cleaned up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10451) ContentPackage2FeatureModel leaves empty "slingfeature" folders in the java tmp directory
Konrad Windszus created SLING-10451:
---
Summary: ContentPackage2FeatureModel leaves empty "slingfeature"
folders in the java tmp directory
Key: SLING-10451
URL: https://issues.apache.org/jira/browse/SLING-10451
Project: Sling
Issue Type: Improvement
Components: Content-Package to Feature Model Converter
Reporter: Konrad Windszus
Fix For: Content-Package to Feature Model Converter 1.1.6
With every run of cp2fm empty folders starting with prefix {{slingfeature}} and
followed by a random number are left in the java tmp folder. Those should be
properly cleaned up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10450) ContentPackage2FeatureModelConverter.java should implement Closeable
[
https://issues.apache.org/jira/browse/SLING-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10450:
Fix Version/s: (was: Content-Package to Feature Model Converter 1.1.4)
Content-Package to Feature Model Converter 1.1.6
> ContentPackage2FeatureModelConverter.java should implement Closeable
>
>
> Key: SLING-10450
> URL: https://issues.apache.org/jira/browse/SLING-10450
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> Forgetting to call {{cleanup}} on the
> {{ContentPackage2FeatureModelConverter}} leads to big dangling temp folders.
> To allow semantic code checks detect such failures, the class should
> implement {{Closeable}} and call {{cleanup}} in its {{close}} method.
> Look at [https://github.com/adobe/aemanalyser-maven-plugin/issues/76] for a
> concrete issue caused by this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10450) ContentPackage2FeatureModelConverter.java should implement Closeable
Konrad Windszus created SLING-10450:
---
Summary: ContentPackage2FeatureModelConverter.java should
implement Closeable
Key: SLING-10450
URL: https://issues.apache.org/jira/browse/SLING-10450
Project: Sling
Issue Type: Improvement
Components: Content-Package to Feature Model Converter
Reporter: Konrad Windszus
Fix For: Content-Package to Feature Model Converter 1.1.4
Forgetting to call {{cleanup}} on the {{ContentPackage2FeatureModelConverter}}
leads to big dangling temp folders. To allow semantic code checks detect such
failures, the class should implement {{Closeable}} and call {{cleanup}} in its
{{close}} method.
Look at [https://github.com/adobe/aemanalyser-maven-plugin/issues/76] for a
concrete issue caused by this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[VOTE] Release Apache Sling Scripting Java 2.1.6
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12338861 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2464/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2464 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Radu Cotescu
[jira] [Commented] (SLING-10448) The Java Script Engine is not made available any more
[ https://issues.apache.org/jira/browse/SLING-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355838#comment-17355838 ] Oliver Lietz commented on SLING-10448: -- FreeMarker script engine (et al.) [is configurable and keeps it in sync|https://github.com/apache/sling-org-apache-sling-scripting-freemarker/blob/master/src/main/java/org/apache/sling/scripting/freemarker/internal/FreemarkerScriptEngineFactory.java#L110]. > The Java Script Engine is not made available any more > - > > Key: SLING-10448 > URL: https://issues.apache.org/jira/browse/SLING-10448 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Java 2.1.2 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Java 2.1.6 > > > Starting with SLING-10155, it seems that the Java Script Engine, provided by > the Apache Sling Scripting Java Support bundle, is not made available to the > platform any more. > This happens because the implementation of the Java Script Engine Factory > doesn't correctly return the short names under which the script engine is > made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7561) Java Script Handler should fall back to 'auto' JVM source and target if requested version is not supported
[ https://issues.apache.org/jira/browse/SLING-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-7561: Fix Version/s: (was: Scripting Java 2.1.6) Scripting Java 2.1.8 > Java Script Handler should fall back to 'auto' JVM source and target if > requested version is not supported > -- > > Key: SLING-7561 > URL: https://issues.apache.org/jira/browse/SLING-7561 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Robert Munteanu >Priority: Major > Fix For: Scripting Java 2.1.8 > > > If the Java Script Handler is configured to use an unsupported or unknown > Java version, it should fall back to 'auto', preventing old settings from > breaking after changing to a different Java version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10449) Repoinit: create path doesn't allow for providing required properties
Bertrand Delacretaz created SLING-10449:
---
Summary: Repoinit: create path doesn't allow for providing
required properties
Key: SLING-10449
URL: https://issues.apache.org/jira/browse/SLING-10449
Project: Sling
Issue Type: Improvement
Components: Repoinit
Affects Versions: Repoinit Parser 1.6.8, Repoinit JCR 1.1.34
Reporter: Bertrand Delacretaz
As an example, adding this to a feature file of the Sling Starter
{code:java}
create path (oak:QueryIndexDefinition) /oak:index/someDefinition
{code}
Causes startup to fail as that nodetype has at least one required property:
{code:java}
OakConstraint0021:
/oak:index/contentFragmentProperty[[oak:QueryIndexDefinition]]:
Mandatory property type not found in a new node
{code}
We might introduce a "with properties" option to "create path" using the same
syntax as "set properties".
I don't need this right now so won't give priority to this ticket.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10448) The Java Script Engine is not made available any more
[ https://issues.apache.org/jira/browse/SLING-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355834#comment-17355834 ] Radu Cotescu commented on SLING-10448: -- Brought back the properties in [commit cb8e364|https://github.com/apache/sling-org-apache-sling-scripting-java/commit/cb8e364]. > The Java Script Engine is not made available any more > - > > Key: SLING-10448 > URL: https://issues.apache.org/jira/browse/SLING-10448 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Java 2.1.2 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Java Support 2.1.4 > > > Starting with SLING-10155, it seems that the Java Script Engine, provided by > the Apache Sling Scripting Java Support bundle, is not made available to the > platform any more. > This happens because the implementation of the Java Script Engine Factory > doesn't correctly return the short names under which the script engine is > made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10448) The Java Script Engine is not made available any more
[ https://issues.apache.org/jira/browse/SLING-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355832#comment-17355832 ] Radu Cotescu commented on SLING-10448: -- Saw it right now and I'll re-add the registration properties. But other than filtering, they serve no other purpose. > The Java Script Engine is not made available any more > - > > Key: SLING-10448 > URL: https://issues.apache.org/jira/browse/SLING-10448 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Java 2.1.2 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Java Support 2.1.4 > > > Starting with SLING-10155, it seems that the Java Script Engine, provided by > the Apache Sling Scripting Java Support bundle, is not made available to the > platform any more. > This happens because the implementation of the Java Script Engine Factory > doesn't correctly return the short names under which the script engine is > made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10448) The Java Script Engine is not made available any more
[ https://issues.apache.org/jira/browse/SLING-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355829#comment-17355829 ] Oliver Lietz commented on SLING-10448: -- This [change|https://github.com/apache/sling-org-apache-sling-scripting-java/commit/4abea89#diff-060eb53d0a7e4c7f1779d81228da83d4f387f9b402eeb9ad4181d659b18fda67L68] will break the filtering on component properties. > The Java Script Engine is not made available any more > - > > Key: SLING-10448 > URL: https://issues.apache.org/jira/browse/SLING-10448 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Java 2.1.2 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Java Support 2.1.4 > > > Starting with SLING-10155, it seems that the Java Script Engine, provided by > the Apache Sling Scripting Java Support bundle, is not made available to the > platform any more. > This happens because the implementation of the Java Script Engine Factory > doesn't correctly return the short names under which the script engine is > made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository
[
https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli resolved SLING-10204.
-
Resolution: Fixed
marking fixed. The SNAPSHOT dependency will be resolved at release time
(currently the build fails if the SNAPSHOT isn't freshly built)
> Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated
> repository
>
>
> Key: SLING-10204
> URL: https://issues.apache.org/jira/browse/SLING-10204
> Project: Sling
> Issue Type: Task
> Components: Discovery
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: Discovery Oak 1.2.32
>
> Attachments: SLING-10204-2.git.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The following exception has been witnessed during resource resolver factory
> unregistration:
> {noformat}
> java.lang.IllegalArgumentException: Can't create child on a synthetic root
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.create(ResourceResolverImpl.java:979)
> [org.apache.sling.resourceresolver:1.7.2]
> ...
> at
> org.apache.sling.api.resource.ResourceUtil.getOrCreateResource(ResourceUtil.java:571)
> [org.apache.sling.api:2.22.0]
> at
> org.apache.sling.discovery.commons.providers.util.ResourceHelper.getOrCreateResource(ResourceHelper.java:45)
> [org.apache.sling.discovery.commons:1.0.20]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:492)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:406)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:421)
> [org.apache.sling.discovery.oak:1.2.30]
> at jdk.internal.reflect.GeneratedMethodAccessor65.invoke(Unknown
> Source){noformat}
> Under normal circumstances osgi should not invoke any of the
> updatedPropertyProvider/unbindPropertyProvider methods after the
> resourceResolverFactory is deactivated - but it has been seen nevertheless.
> What can be done in OakDiscoveryService is to tolerate this and not issue a
> log.warn instead of throwing an uncaught IllegalArgumentException.
> Edit: more cases with the same root cause:
> {noformat}
> java.lang.Exception: Could not adapt resourceResolver to session:
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl@3e685b17
> at
> org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteDescriptor.getDescriptorFrom(DiscoveryLiteDescriptor.java:54)
> [org.apache.sling.discovery.commons:1.0.20]
> at
> org.apache.sling.discovery.oak.cluster.OakClusterViewService.getLocalClusterView(OakClusterViewService.java:113)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.base.commons.BaseDiscoveryService.getTopology(BaseDiscoveryService.java:77)
> [org.apache.sling.discovery.base:2.0.8]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.checkForTopologyChange(OakDiscoveryService.java:660)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.pinger.OakViewChecker.discoveryLiteCheck(OakViewChecker.java:217)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.pinger.OakViewChecker.access$000(OakViewChecker.java:62)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.pinger.OakViewChecker$1.run(OakViewChecker.java:193)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.safelyRun(PeriodicBackgroundJob.java:86)
> [org.apache.sling.discovery.base:2.0.8]
> at
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.run(PeriodicBackgroundJob.java:77)
> [org.apache.sling.discovery.base:2.0.8]
> at java.base/java.lang.Thread.run(Thread.java:834)
> {noformat}
> {noformat}
> java.lang.Exception: Could not adapt resourceResolver to session:
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl@215bf7ef
> at
> org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteDescriptor.getDescriptorFrom(DiscoveryLiteDescriptor.java:54)
> [org.apache.sling.discovery.commons:1.0.20]
> at
> org.apache.sling.discovery.oak.TopologyWebConsolePlugin.updateDiscoveryLiteHistory(TopologyWebConsolePlugin.java:778)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.TopologyWebConsolePlugin.handleTopologyEvent(TopologyWebConsolePlugin.java:728)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sli
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli merged pull request #3: SLING-10204 : fixed getLocalClusterView
stefan-egli merged pull request #3: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli merged pull request #3: SLING-10204 : testing support improved : getRepository and shutdownRepository added
stefan-egli merged pull request #3: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-10239) SetProperty doesn't cover all JCR property types
[
https://issues.apache.org/jira/browse/SLING-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10239:
Description:
the set of types with repo-init is limited to _String, Long, Double, Date,
Boolean_ i.e. doesn't cover all types defined in JCR (see
[https://docs.adobe.com/content/docs/en/spec/jsr170/javadocs/jcr-2.0/javax/jcr/PropertyType.html]
for example)
for those \{{PropertyDefinition}}s that have a required type defined,
conversion from string usually works (if the string is well defined), however
for residual property definitions it will not be possible to set properties of
types that are not covered by repo init.
was:
the set of types with repo-init is limited to _String, Long, Double, Date,
Boolean_ i.e. doesn't cover all types defined in JCR.
for those {{PropertyDefinition}}s that have a required type defined, conversion
from string usually works (if the string is well defined), however for residual
property definitions it will not be possible to set properties of types that
are not covered by repo init.
> SetProperty doesn't cover all JCR property types
>
>
> Key: SLING-10239
> URL: https://issues.apache.org/jira/browse/SLING-10239
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Minor
>
> the set of types with repo-init is limited to _String, Long, Double, Date,
> Boolean_ i.e. doesn't cover all types defined in JCR (see
> [https://docs.adobe.com/content/docs/en/spec/jsr170/javadocs/jcr-2.0/javax/jcr/PropertyType.html]
> for example)
> for those \{{PropertyDefinition}}s that have a required type defined,
> conversion from string usually works (if the string is well defined), however
> for residual property definitions it will not be possible to set properties
> of types that are not covered by repo init.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-discovery-commons] stefan-egli opened a new pull request #2: SLING-10441 : use dedicated 'discovery' thread pool for scheduler ins…
stefan-egli opened a new pull request #2: URL: https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/2 …tead of relying on availability on default thread pool Note that this is part 1/3 as all 3 discovery.commons/.base/.oak need to be updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10349) Repoinit: Nodetype definitions not working
[ https://issues.apache.org/jira/browse/SLING-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355824#comment-17355824 ] Bertrand Delacretaz commented on SLING-10349: - [~-achim], is this still an issue or did you find a solution? > Repoinit: Nodetype definitions not working > --- > > Key: SLING-10349 > URL: https://issues.apache.org/jira/browse/SLING-10349 > Project: Sling > Issue Type: Bug > Components: Repoinit >Reporter: Achim Koch >Assignee: Bertrand Delacretaz >Priority: Minor > > Tried to register nodetypes and namespaces like so: > register namespace ( yyy ) http://yyy.com/jcr/nt/1.0 > register nodetypes > <<=== > << http://yyy.com/jcr/nt/1.0'> > << [yyy:Foobar] > nt:unstructured > ===>> > The whole repoinit script was ignored, then. (I created a "marker" with > createuser that also was not executed). > I saw no apparent error in the logfile. > The namespace did register, when I removed the whole "register nodetypes" > block. > Btw. the documentation could be more explicit that (if) "<< > http://yyy.com/jcr/nt/1.0'>" already creates a namespace (or if that is > required to reference an existing one in the scope of the CND block) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository
[
https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355819#comment-17355819
]
Stefan Egli commented on SLING-10204:
-
PRs created:
* discovery.base :
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/3
* discovery.oak :
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/3
Note that with the above discovery.oak has a SNAPSHOT dependency on
discovery.base - so this won't build correctly until discovery.base is newly
released (taking care of that asap)
> Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated
> repository
>
>
> Key: SLING-10204
> URL: https://issues.apache.org/jira/browse/SLING-10204
> Project: Sling
> Issue Type: Task
> Components: Discovery
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: Discovery Oak 1.2.32
>
> Attachments: SLING-10204-2.git.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The following exception has been witnessed during resource resolver factory
> unregistration:
> {noformat}
> java.lang.IllegalArgumentException: Can't create child on a synthetic root
> at
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.create(ResourceResolverImpl.java:979)
> [org.apache.sling.resourceresolver:1.7.2]
> ...
> at
> org.apache.sling.api.resource.ResourceUtil.getOrCreateResource(ResourceUtil.java:571)
> [org.apache.sling.api:2.22.0]
> at
> org.apache.sling.discovery.commons.providers.util.ResourceHelper.getOrCreateResource(ResourceHelper.java:45)
> [org.apache.sling.discovery.commons:1.0.20]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:492)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:406)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:421)
> [org.apache.sling.discovery.oak:1.2.30]
> at jdk.internal.reflect.GeneratedMethodAccessor65.invoke(Unknown
> Source){noformat}
> Under normal circumstances osgi should not invoke any of the
> updatedPropertyProvider/unbindPropertyProvider methods after the
> resourceResolverFactory is deactivated - but it has been seen nevertheless.
> What can be done in OakDiscoveryService is to tolerate this and not issue a
> log.warn instead of throwing an uncaught IllegalArgumentException.
> Edit: more cases with the same root cause:
> {noformat}
> java.lang.Exception: Could not adapt resourceResolver to session:
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl@3e685b17
> at
> org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteDescriptor.getDescriptorFrom(DiscoveryLiteDescriptor.java:54)
> [org.apache.sling.discovery.commons:1.0.20]
> at
> org.apache.sling.discovery.oak.cluster.OakClusterViewService.getLocalClusterView(OakClusterViewService.java:113)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.base.commons.BaseDiscoveryService.getTopology(BaseDiscoveryService.java:77)
> [org.apache.sling.discovery.base:2.0.8]
> at
> org.apache.sling.discovery.oak.OakDiscoveryService.checkForTopologyChange(OakDiscoveryService.java:660)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.pinger.OakViewChecker.discoveryLiteCheck(OakViewChecker.java:217)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.pinger.OakViewChecker.access$000(OakViewChecker.java:62)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.oak.pinger.OakViewChecker$1.run(OakViewChecker.java:193)
> [org.apache.sling.discovery.oak:1.2.30]
> at
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.safelyRun(PeriodicBackgroundJob.java:86)
> [org.apache.sling.discovery.base:2.0.8]
> at
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.run(PeriodicBackgroundJob.java:77)
> [org.apache.sling.discovery.base:2.0.8]
> at java.base/java.lang.Thread.run(Thread.java:834)
> {noformat}
> {noformat}
> java.lang.Exception: Could not adapt resourceResolver to session:
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl@215bf7ef
> at
> org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteDescriptor.getDescriptorFrom(DiscoveryLiteDescriptor.java:54)
> [org.apache.sling.discovery.commons:1.0.20]
> at
> org.apache.sling.discovery.oak.TopologyWebConsolePlugin.updateDiscoveryLiteHistory
[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli opened a new pull request #3: SLING-10204 : fixed getLocalClusterView
stefan-egli opened a new pull request #3: URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/3 Note that this PR depends on discovery.base SNAPSHOT which contains https://github.com/apache/sling-org-apache-sling-discovery-base/pull/3 (to be cleaned up at release time) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli opened a new pull request #3: SLING-10204 : testing support improved : getRepository and shutdownRepository added
stefan-egli opened a new pull request #3: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10448) The Java Script Engine is not made available any more
[ https://issues.apache.org/jira/browse/SLING-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-10448. -- Resolution: Fixed Fixed in [commit 4abea89|https://github.com/apache/sling-org-apache-sling-scripting-java/commit/4abea89]. > The Java Script Engine is not made available any more > - > > Key: SLING-10448 > URL: https://issues.apache.org/jira/browse/SLING-10448 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Java 2.1.2 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Java 2.1.4 > > > Starting with SLING-10155, it seems that the Java Script Engine, provided by > the Apache Sling Scripting Java Support bundle, is not made available to the > platform any more. > This happens because the implementation of the Java Script Engine Factory > doesn't correctly return the short names under which the script engine is > made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10448) The Java Script Engine is not made available any more
[ https://issues.apache.org/jira/browse/SLING-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-10448: - Summary: The Java Script Engine is not made available any more (was: The Java Script Engine is not being made available any more) > The Java Script Engine is not made available any more > - > > Key: SLING-10448 > URL: https://issues.apache.org/jira/browse/SLING-10448 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Java 2.1.2 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Java 2.1.4 > > > Starting with SLING-10155, it seems that the Java Script Engine, provided by > the Apache Sling Scripting Java Support bundle, is not made available to the > platform any more. > This happens because the implementation of the Java Script Engine Factory > doesn't correctly return the short names under which the script engine is > made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10448) The Java Script Engine is not being made available any more
Radu Cotescu created SLING-10448: Summary: The Java Script Engine is not being made available any more Key: SLING-10448 URL: https://issues.apache.org/jira/browse/SLING-10448 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting Java 2.1.2 Reporter: Radu Cotescu Fix For: Scripting Java 2.1.4 Starting with SLING-10155, it seems that the Java Script Engine, provided by the Apache Sling Scripting Java Support bundle, is not made available to the platform any more. This happens because the implementation of the Java Script Engine Factory doesn't correctly return the short names under which the script engine is made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10448) The Java Script Engine is not being made available any more
[ https://issues.apache.org/jira/browse/SLING-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-10448: Assignee: Radu Cotescu > The Java Script Engine is not being made available any more > --- > > Key: SLING-10448 > URL: https://issues.apache.org/jira/browse/SLING-10448 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Java 2.1.2 >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Scripting Java 2.1.4 > > > Starting with SLING-10155, it seems that the Java Script Engine, provided by > the Apache Sling Scripting Java Support bundle, is not made available to the > platform any more. > This happens because the implementation of the Java Script Engine Factory > doesn't correctly return the short names under which the script engine is > made available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Engine 2.7.6, JCR Base 3.1.8, and Content-Package to Feature Model Converter 1.1.4
+1 David On Wed, 2 Jun 2021 at 15:29, Karl Pauls wrote: > I would like to call a vote on the following releases, > > Apache Sling Engine 2.7.6 > > We solved 2 issue: > https://issues.apache.org/jira/projects/SLING/versions/12349731 > > Apache Sling JCR Base 3.1.8, > > We solved 2 issue: > https://issues.apache.org/jira/projects/SLING/versions/12348826 > > Apache Sling Content-Package to Feature Model Converter 1.1.4 > > We solved 2 issue: > https://issues.apache.org/jira/projects/SLING/versions/12350219 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2462/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2462 /tmp/sling-staging > > Please vote to approve these releases: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ... >
[VOTE] Release Apache Sling Engine 2.7.6, JCR Base 3.1.8, and Content-Package to Feature Model Converter 1.1.4
I would like to call a vote on the following releases, Apache Sling Engine 2.7.6 We solved 2 issue: https://issues.apache.org/jira/projects/SLING/versions/12349731 Apache Sling JCR Base 3.1.8, We solved 2 issue: https://issues.apache.org/jira/projects/SLING/versions/12348826 Apache Sling Content-Package to Feature Model Converter 1.1.4 We solved 2 issue: https://issues.apache.org/jira/projects/SLING/versions/12350219 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2462/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2462 /tmp/sling-staging Please vote to approve these releases: [ ] +1 Approve the releases [ ] 0 Don't care [ ] -1 Don't release, because ...
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355766#comment-17355766 ] Bertrand Delacretaz commented on SLING-10447: - bq. ...this is more for the distribution to fix (either Sling Starter or AEM) as the index is provided by them. I agree with that and I think it also means that making the startup query more selective is required anyway, as there's no way to guarantee that these more selective indexes will be configured. > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10353) ClusterSyncServiceChain can leak a background thread
[
https://issues.apache.org/jira/browse/SLING-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli resolved SLING-10353.
-
Fix Version/s: Discovery Commons 1.0.24
Resolution: Fixed
* fixed in [this
PR|https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/1
> ClusterSyncServiceChain can leak a background thread
>
>
> Key: SLING-10353
> URL: https://issues.apache.org/jira/browse/SLING-10353
> Project: Sling
> Issue Type: Bug
> Components: Discovery
>Affects Versions: Discovery Commons 1.0.20
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Discovery Commons 1.0.24
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Invoking a {{ClusterSyncService.sync()}} should ensure that if a background
> thread is running, it gets terminated. In the case of a chain of sync
> services implemented by {{ClusterSyncServiceChain}} there is a race-condition
> which can leak a background thread running unintentionally.
> The order of events is eg:
> * setup: ClusterSyncServiceChain is configured with a chain of a
> OakBacklogClusterSyncService followed by a SyncTokenService
> * ViewStateManagerImpl.handleNewViewNonDelayed can be called consecutively,
> as it is protected by a lock. Let's assume on first invocation it starts a
> sync process by invoking the ClusterSyncServiceChain.sync()
> * the ClusterSyncServiceChain.sync() will first invoke the
> OakBacklogClusterSyncService.sync()
> * let's assume there is a backlog (ie a recovery hasn't finished yet) with a
> particular instance in the cluster - so OakBacklogClusterSyncService.sync()
> will spawn a background thread that checks for that backlog every 2 seconds
> (handled by AbstractServiceWithBackgroundCheck.BackgroundCheckRunnable.run()).
> * the OakBacklogClusterSyncService background check determines that the
> backlog is gone and that it can proceed. It will do so by continuing in the
> ClusterSyncServiceChain - ie it will invoke the SyncTokenService.sync() -
> that in turn invokes syncToken() - which invokes startBackgroundThread. At
> this point, let's assume, the check() returns false - ie there are sync
> tokens it needs to wait for. Hence it will start a new background Thread for
> the SyncTokenService.
> * let's now assume, at some later point
> ViewStateManagerImpl.handleNewViewNonDelayed is again invoked. So it will
> again call ClusterSyncServiceChain.sync(). Now it is the responsibility of
> ClusterSyncServiceChain.sync() to cancel any currently running background
> thread - but the first element in the chain (the
> OakBacklogClusterSyncService) doesn't actually have any background thread
> anymore - it has already "handed over" to the SyncTokenService - so the
> OakBacklogClusterSyncService.cancelPreviousBackgroundCheck() will not have
> anything to cancel. Hence it goes ahead and follows the sync() chain process
> - which is first checking for backlog (that has cleared now, as we assumed),
> and then the sync token (which is not complete, as we assumed). So it will
> now create a *second* background thread.
> The above resulting in 2 SyncTokenService background threads.
> This can have a few consequences:
> * a behaviour was noticed, whereby {{SyncTokenService.storeMySyncToken}}
> keeps being invoked with toggling values, eg first it stores {{627}}, then
> {{628}}, then again {{627}}, then {{628}} etc. The following is an example of
> the generated data in DocumentNodeStore as a result ( excerpt from the
> {{"_id" : "4:/var/discovery/oak/syncTokens"}} document ) :
> {noformat}
> "" : {
> "r179378d10da-0-4" : "\"627\"",
> "r179378d14ce-0-4" : "\"628\"",
> "r179378d18bc-0-4" : "\"627\"",
> "r179378d1ca1-0-4" : "\"628\"",
> "r179378d209c-0-4" : "\"627\"",
> "r179378d2477-0-4" : "\"628\"",
> "r179378d287f-0-4" : "\"627\"",
> "r179378d2c4b-0-4" : "\"628\"",
> "r179378d3068-0-4" : "\"627\"",
> "r179378d3421-0-4" : "\"628\""
> },
> {noformat}
> This eventually should clear out - but it can lead to
> ** unnecessary lengthening the sync procedure as other cluster nodes will
> potentially have to wait longer
> ** confusion when reading such log files
> * it can also result in conflict exceptions if the two threads want to update
> simultaneously:
> {noformat}
> 04.05.2021 13:22:27.741 *ERROR* [Discovery-AsyncEventSender]
> org.apache.sling.discovery.commons.providers.spi.base.SyncTokenService
> storeMySyncToken: got PersistenceException while storing my syncToken:
> org.apache.sling.api.resource.PersistenceException: Unable to commit changes
> to session.
> org.apache.sling.api.re
[GitHub] [sling-org-apache-sling-discovery-commons] stefan-egli merged pull request #1: SLING-10353 : ClusterSyncServiceChain can leak a background thread
stefan-egli merged pull request #1: URL: https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355735#comment-17355735 ] Konrad Windszus commented on SLING-10447: - bq. I don't think we should recommend this kind of exclusion and should instead make better queries. We should maybe involve someone more familiar with queries, but I don't see a good reason for queries within version storage. As I said before, placing the path constraint in the query makes it execute more slowly. In any case having a dedicated index for the use cases of Sling itself (which for sure is everything outside version storage) makes IMHO a lot of sense. In any case this is more for the distribution to fix (either Sling Starter or AEM) as the index is provided by them. > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355730#comment-17355730 ] Robert Munteanu commented on SLING-10447: - [~Henry Kuijpers] - I am not aware of an option of resource change events in a way that you need ( / but not /jcr:system ). But we should treat optimisation in a different issue. > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[
https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355727#comment-17355727
]
Robert Munteanu commented on SLING-10447:
-
[~kwin] - that actually looks scary to me :-) In case someone actually wants to
look in jcr:system for vanity paths for _whatever_ reason they will not be
found. Looking in the query docs I see noted that
{quote}Use excludedPaths, includedPaths with caution - When paths are excluded
or included then query engine is not aware of that. If wrong paths get excluded
then its possible that nodes which should have been part of query result get
excluded as they are not indexed. So only exclude those paths which do not have
node matching given nodeType or nodes which are known to be not part of any
query result{quote}.
I don't think we should recommend this kind of exclusion and should instead
make better queries.
> sling:vanityPath are being searched during startup in the entire repository,
> including version storage
> --
>
> Key: SLING-10447
> URL: https://issues.apache.org/jira/browse/SLING-10447
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.6
>Reporter: Henry Kuijpers
>Priority: Major
> Fix For: Resource Resolver 1.7.8
>
>
> We have a lot of pages on our production author instance. We also have a lot
> of pages that use sling:vanityPath. Everytime a page is replicated, a new
> version is created.
> We have roughly 168.000 pages in our instance. In the /content node, there
> are approx. 4500 pages with vanity URLs. In the version storage, however,
> there are 120.000+ entries that have a sling:vanityPath defined.
> When starting up Apache Sling, the Resource Resolver fetches all the existing
> sling:vanityPath entries, which it fails to do, because of the large amount
> of sling:vanityPath in the version storage.
> In the code, I specifically see checks (when processing the query results)
> about the version storage. However, this should have been put inside the
> query as a filter, in order to avoid fetching such a large amount of query
> result nodes:
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158
> I propose to update the query with a "not isdescendantnode"-check, to make
> sure we do not return any content from the version storage and thus make the
> default query limits of 100.000 nodes work again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355701#comment-17355701 ] Henry Kuijpers commented on SLING-10447: Yes, i can provide a PR. There are 2 way the vanity paths are fetched: once at startup, which uses a query. I can update that query with the "not version storage"-path restriction. The other one is a ResourceChangeListener that listens for changed in the observation paths that are configured: in the case of AEM, that is /. For that one, there is still a filter needed to exclude /jcr:system. Or is there a way to configure a ResourceChangeListener to exclude certain paths? I could not find anything for that. > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355697#comment-17355697 ] Konrad Windszus edited comment on SLING-10447 at 6/2/21, 1:05 PM: -- Look at https://jackrabbit.apache.org/oak/docs/query/lucene.html#include-exclude bq. Note that excludedPaths and includedPaths does not affect the index selection logic for a query i.e. if a query has any path restriction specified then that would not be checked against the excludedPaths and includedPaths. So the answer to your question is yes (given that the index with the path restriction is selected for the query based on its score) was (Author: kwin): Look at https://jackrabbit.apache.org/oak/docs/query/lucene.html#include-exclude bq. Note that excludedPaths and includedPaths does not affect the index selection logic for a query i.e. if a query has any path restriction specified then that would not be checked against the excludedPaths and includedPaths. So the answer to your question is yes. > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355697#comment-17355697 ] Konrad Windszus commented on SLING-10447: - Look at https://jackrabbit.apache.org/oak/docs/query/lucene.html#include-exclude bq. Note that excludedPaths and includedPaths does not affect the index selection logic for a query i.e. if a query has any path restriction specified then that would not be checked against the excludedPaths and includedPaths. So the answer to your question is yes. > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-discovery-commons] stefan-egli opened a new pull request #1: SLING-10353 : ClusterSyncServiceChain can leak a background thread
stefan-egli opened a new pull request #1: URL: https://github.com/apache/sling-org-apache-sling-discovery-commons/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[
https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355693#comment-17355693
]
Robert Munteanu commented on SLING-10447:
-
TBH I am not sure how that works [~kwin]. Does this mean that if an index for
{{sling:vanityPath}} is restricted to {{/content}} and I run a query over the
whole repository it would only return results for {{/content}}, even if it I
have vanity paths defined in {{/libs}}?
> sling:vanityPath are being searched during startup in the entire repository,
> including version storage
> --
>
> Key: SLING-10447
> URL: https://issues.apache.org/jira/browse/SLING-10447
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.6
>Reporter: Henry Kuijpers
>Priority: Major
> Fix For: Resource Resolver 1.7.8
>
>
> We have a lot of pages on our production author instance. We also have a lot
> of pages that use sling:vanityPath. Everytime a page is replicated, a new
> version is created.
> We have roughly 168.000 pages in our instance. In the /content node, there
> are approx. 4500 pages with vanity URLs. In the version storage, however,
> there are 120.000+ entries that have a sling:vanityPath defined.
> When starting up Apache Sling, the Resource Resolver fetches all the existing
> sling:vanityPath entries, which it fails to do, because of the large amount
> of sling:vanityPath in the version storage.
> In the code, I specifically see checks (when processing the query results)
> about the version storage. However, this should have been put inside the
> query as a filter, in order to avoid fetching such a large amount of query
> result nodes:
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158
> I propose to update the query with a "not isdescendantnode"-check, to make
> sure we do not return any content from the version storage and thus make the
> default query limits of 100.000 nodes work again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[
https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355689#comment-17355689
]
Konrad Windszus commented on SLING-10447:
-
Yes, I meant the index for the {{sling:vanityPath}} not {{sling:alias}}. But
IMHO both indices could leverage the same path restriction.
> sling:vanityPath are being searched during startup in the entire repository,
> including version storage
> --
>
> Key: SLING-10447
> URL: https://issues.apache.org/jira/browse/SLING-10447
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.6
>Reporter: Henry Kuijpers
>Priority: Major
> Fix For: Resource Resolver 1.7.8
>
>
> We have a lot of pages on our production author instance. We also have a lot
> of pages that use sling:vanityPath. Everytime a page is replicated, a new
> version is created.
> We have roughly 168.000 pages in our instance. In the /content node, there
> are approx. 4500 pages with vanity URLs. In the version storage, however,
> there are 120.000+ entries that have a sling:vanityPath defined.
> When starting up Apache Sling, the Resource Resolver fetches all the existing
> sling:vanityPath entries, which it fails to do, because of the large amount
> of sling:vanityPath in the version storage.
> In the code, I specifically see checks (when processing the query results)
> about the version storage. However, this should have been put inside the
> query as a filter, in order to avoid fetching such a large amount of query
> result nodes:
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158
> I propose to update the query with a "not isdescendantnode"-check, to make
> sure we do not return any content from the version storage and thus make the
> default query limits of 100.000 nodes work again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355678#comment-17355678 ] Robert Munteanu commented on SLING-10447: - [~kwin] - did you mean vanity paths in your comment? > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355676#comment-17355676 ] Konrad Windszus commented on SLING-10447: - As I don't see a reason why sling:alias should be indexed at all in the version storage I would not index there. Then the query does not have to do (costly) path checks. > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355674#comment-17355674 ] Robert Munteanu commented on SLING-10447: - That's a great idea for an improvement [~Henry Kuijpers]. Would you have the time to provide a pull request? I think this can be a simplified version of the changes submitted for SLING-9535 (minus the configurable paths). > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
[ https://issues.apache.org/jira/browse/SLING-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10447: Fix Version/s: Resource Resolver 1.7.8 > sling:vanityPath are being searched during startup in the entire repository, > including version storage > -- > > Key: SLING-10447 > URL: https://issues.apache.org/jira/browse/SLING-10447 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.7.6 >Reporter: Henry Kuijpers >Priority: Major > Fix For: Resource Resolver 1.7.8 > > > We have a lot of pages on our production author instance. We also have a lot > of pages that use sling:vanityPath. Everytime a page is replicated, a new > version is created. > We have roughly 168.000 pages in our instance. In the /content node, there > are approx. 4500 pages with vanity URLs. In the version storage, however, > there are 120.000+ entries that have a sling:vanityPath defined. > When starting up Apache Sling, the Resource Resolver fetches all the existing > sling:vanityPath entries, which it fails to do, because of the large amount > of sling:vanityPath in the version storage. > In the code, I specifically see checks (when processing the query results) > about the version storage. However, this should have been put inside the > query as a filter, in order to avoid fetching such a large amount of query > result nodes: > https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 > I propose to update the query with a "not isdescendantnode"-check, to make > sure we do not return any content from the version storage and thus make the > default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10447) sling:vanityPath are being searched during startup in the entire repository, including version storage
Henry Kuijpers created SLING-10447: -- Summary: sling:vanityPath are being searched during startup in the entire repository, including version storage Key: SLING-10447 URL: https://issues.apache.org/jira/browse/SLING-10447 Project: Sling Issue Type: Bug Components: ResourceResolver Affects Versions: Resource Resolver 1.7.6 Reporter: Henry Kuijpers We have a lot of pages on our production author instance. We also have a lot of pages that use sling:vanityPath. Everytime a page is replicated, a new version is created. We have roughly 168.000 pages in our instance. In the /content node, there are approx. 4500 pages with vanity URLs. In the version storage, however, there are 120.000+ entries that have a sling:vanityPath defined. When starting up Apache Sling, the Resource Resolver fetches all the existing sling:vanityPath entries, which it fails to do, because of the large amount of sling:vanityPath in the version storage. In the code, I specifically see checks (when processing the query results) about the version storage. However, this should have been put inside the query as a filter, in order to avoid fetching such a large amount of query result nodes: https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/4406b8fed0fedb48202fc6472fb552c36aa06e35/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1158 I propose to update the query with a "not isdescendantnode"-check, to make sure we do not return any content from the version storage and thus make the default query limits of 100.000 nodes work again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #508 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/508/ for details. No further emails will be sent until the status of the build is changed.
[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #507 is BROKEN
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/507/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
[...truncated 19 lines...]
Checking out Revision 0ae97fc92104c131bc42b1a6993316652447e004 (master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 0ae97fc92104c131bc42b1a6993316652447e004 # timeout=10
Commit message: "SLING-9839 execute Sonar with Java11 (#6)"
> git rev-list --no-walk 0ae97fc92104c131bc42b1a6993316652447e004 # timeout=10
[Pipeline] Start of Pipeline
[Pipeline] node
Running on H22 in
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master
[Pipeline] {
[Pipeline] timeout
Timeout set to expire after 30 min without activity
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Init)
[Pipeline] checkout
The recommended git tool is: NONE
using credential sling-github-token
Fetching changes from the remote Git repository
> git rev-parse --is-inside-work-tree # timeout=10
> git config remote.origin.url
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git #
> timeout=10
Fetching without tags
Checking out Revision e68051d95a23f4112e2c6c81c4175a018394c10b (master)
Fetching upstream changes from
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> git --version # timeout=10
> git --version # 'git version 2.17.1'
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress --
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> +refs/heads/master:refs/remotes/origin/master # timeout=10
> git config core.sparsecheckout # timeout=10
> git checkout -f e68051d95a23f4112e2c6c81c4175a018394c10b # timeout=10
Commit message: "mvn clean launcher folder"
> git rev-list --no-walk e68051d95a23f4112e2c6c81c4175a018394c10b # timeout=10
[Pipeline] sh
+ git clean -fdx
Removing target/
[Pipeline] sh
+ git config remote.origin.url
[Pipeline] fileExists
[Pipeline] readJSON
[Pipeline] echo
Jenkins overrides: [rebuildFrequency:@daily, sonarQubeEnabled:false, jdks:[8,
11, 15], archivePatterns:[**/logs/*.log],
emailRecipients:[dev@sling.apache.org],
upstreamProjects:[../sling-org-apache-sling-starter/master]]
[Pipeline] echo
Final job config: [jdks:[8, 11, 15],
upstreamProjects:[../sling-org-apache-sling-starter/master],
archivePatterns:[**/logs/*.log], mavenGoal:, additionalMavenParams:,
rebuildFrequency:@daily, enabled:true, emailRecipients:[dev@sling.apache.org],
sonarQubeEnabled:false, sonarQubeUseAdditionalMavenParams:true,
sonarQubeAdditionalParams:, repoName:sling-org-apache-sling-launchpad-testing]
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Configure Job)
[Pipeline] properties
[Pipeline] }
[Pipeline] // stage
[Pipeline] readMavenPom
[Pipeline] stage
[Pipeline] { (Build (Java 8, deploy))
[Pipeline] withMaven
[withMaven] Options:
[org.jenkinsci.plugins.pipeline.maven.publishers.GeneratedArtifactsPublisher[disabled=false],
JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false],
org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='false',
healthy='', unHealthy='', thresholdLimit='low'],
org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=false,
scopes=[compile, provided, runtime], versions={snapshot:true, release:false}]]
[withMaven] Available options:
[withMaven] using JDK installation jdk_1.8_latest
[withMaven] using Maven installation 'maven_3_latest'
[Pipeline] {
[Pipeline] sh
+ mvn -U clean deploy -Pci
- withMaven Wrapper script -
Picked up JAVA_TOOL_OPTIONS:
-Dmaven.ext.class.path="/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaveneb181e42/pipeline-maven-spy.jar"
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaveneb181e42"
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_281, vendor: Oracle Corporation, runtime:
/usr/local/asfpackages/java/oraclejdk-1.8.0-281/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-58-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaveneb181e42/maven-spy-20210602-111726-6973263755527927451971.log.tmp
...
[INFO] Scanning for projects...
[INFO]
[INFO] < org.apache.sling:org.apache.sling.launchpad.testing >-
[INFO] Building Apache Sling Launch
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.8
+1 David On Wed, 2 Jun 2021 at 11:48, Karl Pauls wrote: > +1 > > regards, > > Karl > > On Wed, Jun 2, 2021 at 12:14 PM wrote: > > > > Hi all, > > > > I'd like to call the release on the Feature Model API Regions Runtime > > Fragment version 1.1.8 > > > > We solved the following issues: > > https://issues.apache.org/jira/projects/SLING/versions/12348592 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2461 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2461 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Best regards, > > > > David > > > > -- > Karl Pauls > karlpa...@gmail.com >
Re: June 2021 board report draft
On Wed, 2021-06-02 at 12:13 +0200, Bertrand Delacretaz wrote: > Hi Robert, > > Thanks for the report, looks good to me except a typo: > > On Tue, Jun 1, 2021 at 5:36 PM Robert Munteanu > wrote: > > The community is in good health. We have seen an moderate increase of > > activity... > > s/an moderate/a moderate/ Thanks, Bertrand! Good to know someone is actually looking over these, this was neither a brown M&M [1] nor a duck [2] :-) Robert [1]: https://hiltmon.com/blog/2015/10/14/brown-mms/ [2]: https://blog.codinghorror.com/new-programming-jargon/#5
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.8
+1 regards, Karl On Wed, Jun 2, 2021 at 12:14 PM wrote: > > Hi all, > > I'd like to call the release on the Feature Model API Regions Runtime > Fragment version 1.1.8 > > We solved the following issues: > https://issues.apache.org/jira/projects/SLING/versions/12348592 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2461 > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2461 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Best regards, > > David -- Karl Pauls karlpa...@gmail.com
[jira] [Closed] (SLING-10425) JSON Convertion of streams can throw an NPE
[
https://issues.apache.org/jira/browse/SLING-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls closed SLING-10425.
--
> JSON Convertion of streams can throw an NPE
> ---
>
> Key: SLING-10425
> URL: https://issues.apache.org/jira/browse/SLING-10425
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Get 2.1.44
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The getLength() call for streams has been changed in
> https://issues.apache.org/jira/browse/SLING-9726 to do a valueMap.get(key,
> Long.class) - that can cause an NPE if there is no value for the key.
> Looks like this:
> {noformat}
> org.apache.sling.servlets.get.impl.helpers.JsonRenderer Error in
> JsonRendererServlet: {}
> java.lang.NullPointerException: null
> at
> org.apache.sling.servlets.get.impl.util.JsonObjectCreator.getLength(JsonObjectCreator.java:245)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.util.JsonObjectCreator.createProperty(JsonObjectCreator.java:221)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.util.JsonObjectCreator.create(JsonObjectCreator.java:95)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.util.ResourceTraversor.adapt(ResourceTraversor.java:139)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.util.ResourceTraversor.addChildren(ResourceTraversor.java:152)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.util.ResourceTraversor.addChildren(ResourceTraversor.java:152)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.util.ResourceTraversor.addChildren(ResourceTraversor.java:152)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.util.ResourceTraversor.getJSONObject(ResourceTraversor.java:143)
> [org.apache.sling.servlets.get:2.1.42]
> at
> org.apache.sling.servlets.get.impl.helpers.JsonRenderer.render(JsonRenderer.java:119)
> [org.apache.sling.servlets.get:2.1.42]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Release Apache Sling Parent and Bundle Parent 43
On Wed, 2021-06-02 at 11:38 +0200, Konrad Windszus wrote: > Please vote to approve this release: +1 Note that this is not a drop-in release, probably due to the OSGi dependency updates. After updating the sling engine bundle fails compilation with [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler- plugin:3.8.1:testCompile (default-testCompile) on project org.apache.sling.engine: Compilation failure [ERROR] /home/robert/sources/apache/sling/org-apache-sling- engine/src/test/java/org/apache/sling/engine/impl/filter/AbstractFilter Test.java:[47,71] is not abstract and does not override abstract method getProperties() in org.osgi.framework.ServiceReference But that's probably easily fixable. Thanks, Robert signature.asc Description: This is a digitally signed message part
Re: Release Apache Sling Parent and Bundle Parent 43
+1 David On Wed, 2 Jun 2021 at 10:38, Konrad Windszus wrote: > Hi, > > We solved some issues in this release: > > Parent 43: https://issues.apache.org/jira/projects/SLING/versions/12350215 > Bundle Parent 43: > https://issues.apache.org/jira/projects/SLING/versions/12350216 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2460/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2460 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote > is open for at least 72 hours.
[jira] [Commented] (SLING-10445) Helper for HTTP access in Pax Exam tests
[
https://issues.apache.org/jira/browse/SLING-10445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355629#comment-17355629
]
Bertrand Delacretaz commented on SLING-10445:
-
We might question whether we need this considering that the
[PaxExamServer|https://github.com/apache/sling-org-apache-sling-testing-paxexam/blob/master/src/test/java/org/apache/sling/testing/paxexam/it/tests/SlingOptionsPaxExamServerIT.java]
rule allows for running HTTP tests against OSGi services.
I think both can be useful, the {{PaxExamServer}} rule is good for HTTP-only
tests whereas this new helper would allow "hybrid" tests which combine
in-OSGi-framework and HTTP tests.
> Helper for HTTP access in Pax Exam tests
>
>
> Key: SLING-10445
> URL: https://issues.apache.org/jira/browse/SLING-10445
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Affects Versions: Testing PaxExam 3.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> Eric Norman has written utilities in the
> [jackrabbit-accessmanager/AccessManagerClientTestSupport|https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-accessmanager/blob/master/src/test/java/org/apache/sling/jcr/jackrabbit/accessmanager/it/AccessManagerClientTestSupport.java]
> class that I think would fit well as helpers in the testing-paxeam module.
> This can help us move more tests away from the big
> {{launchpad-integration-tests}} module, closer to the code that they test, as
> done in SLING-10437
> I don't have time to implement this right now, so consider this ticket as a
> reminder to myself to do it later in my Copious Free Time. Or if someone
> wants to go ahead feel free to reassign this ticket to yourself.
> A suggested usage scenario is getting a configured {{HttpClient}} starting
> with a {{BundleContext}}. To test it, it should allow for simplifying that
> {{AccessManagerClientTestSupport}} class by removing all the {{HttpClient}}
> setup code and making that reusable in the new helper.
> To simplify the {{Credentials}} handling, as we are often reusing the same
> ones, the {{HttpClient}} might store several named {{Credentials}} and
> include a {{useCredentials}} method which sets one of them as the default for
> the next requests.
> The client configuration is mostly in the {{before}} method of that class,
> with {{getBaseServerUri}} computing the server URL from the OSGi configs.
> The {{jackrabbit-usermanager}} module has a similar {{ClientTestSupport}}
> class that would also benefit from the same refactorings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.8
Hi all, I'd like to call the release on the Feature Model API Regions Runtime Fragment version 1.1.8 We solved the following issues: https://issues.apache.org/jira/projects/SLING/versions/12348592 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2461 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2461 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Best regards, David
Re: June 2021 board report draft
Hi Robert, Thanks for the report, looks good to me except a typo: On Tue, Jun 1, 2021 at 5:36 PM Robert Munteanu wrote: > The community is in good health. We have seen an moderate increase of > activity... s/an moderate/a moderate/ -Bertrand (nitpicking, really ;-)
Re: [RESULT][VOTE] Release Apache Sling Servlets Get 2.1.44
Time to call the vote on the Apache Sling Servlets Get 2.1.44 release. * +1 votes from Carsten Ziegeler, Stefan Seifert, David Bosschaert, and Karl Pauls. * No other votes. The vote is successful. I will make the artifacts available as soon as possible.
Re: [VOTE] Release Apache Sling Servlets Get 2.1.44
+1 regards, Karl On Thu, May 27, 2021 at 1:57 PM wrote: > > +1 > > David > > On Thu, 27 May 2021 at 12:15, Stefan Seifert > wrote: > > > +1 > > -- Karl Pauls karlpa...@gmail.com
[jira] [Commented] (SLING-10436) Move jackrabbit-accessmanager integration tests
[ https://issues.apache.org/jira/browse/SLING-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355623#comment-17355623 ] Bertrand Delacretaz commented on SLING-10436: - And the same for health checks, SLING-10446 > Move jackrabbit-accessmanager integration tests > --- > > Key: SLING-10436 > URL: https://issues.apache.org/jira/browse/SLING-10436 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit Access Manager 3.0.10 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Move the integration tests from > org-apache-sling-launchpad-integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/accessManager/* > to paxexam integration tests within the > org-apache-sling-jcr-jackrabbit-accessmanager project. > This makes the tests closer to the code being tested and allows those tests > to participate in the code coverage calculations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10437) Move jackrabbit-usermanager integration tests
[ https://issues.apache.org/jira/browse/SLING-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355622#comment-17355622 ] Bertrand Delacretaz commented on SLING-10437: - And the same for health checks, SLING-10446 > Move jackrabbit-usermanager integration tests > - > > Key: SLING-10437 > URL: https://issues.apache.org/jira/browse/SLING-10437 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR Jackrabbit User Manager 2.2.14 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Move the integration tests from > org-apache-sling-launchpad-integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/userManager/* > to paxexam integration tests within the > org-apache-sling-jcr-jackrabbit-usermanager project. > This makes the tests closer to the code being tested and allows those tests > to participate in the code coverage calculations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10446) Helper for health checks in pax exam tests
Bertrand Delacretaz created SLING-10446:
---
Summary: Helper for health checks in pax exam tests
Key: SLING-10446
URL: https://issues.apache.org/jira/browse/SLING-10446
Project: Sling
Issue Type: Improvement
Components: Testing
Affects Versions: Testing PaxExam 3.1.0
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
Similar to SLING-10445, I'm assigning this to myself hoping to work on it
later, but if someone beats me to it feel free to re-assign.
Based on Eric Norman's code in the
[jackrabbit-accessmanager/AccessManagerClientTestSupport|https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-accessmanager/blob/master/src/test/java/org/apache/sling/jcr/jackrabbit/accessmanager/it/AccessManagerClientTestSupport.java]
class that I think it would be useful to create a helper for setting up and
verifying health checks in pax exam tests. It's a useful way of checking for
system readiness in a precise way.
Maybe something like this
{code}
// when setting up pax Options
HealthCheckPaxOptions
.withFrameworkStartLevel(5)
.withService("org.apache.sling.jcr.api.SlingRepository")
.withService("javax.script.ScriptEngineManager")
.withBundlesStarted()
.withBundlesContentLoaded()
.getOptions()
// and then execute the health checks with
HealthChecksAggregator(HealthCheckExecutor)..isOk(String ...
tagsWhichDefaultToTheConfiguredOnes)
// or wait a maximum time for ok
HealthChecksAggregator(HealthCheckExecutor).waitForOk(Duration, String ...
tagsWhichDefaultToTheConfiguredOnes)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10401) Ease usage of cp2fm as library
[
https://issues.apache.org/jira/browse/SLING-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls reassigned SLING-10401:
--
Assignee: Konrad Windszus
> Ease usage of cp2fm as library
> --
>
> Key: SLING-10401
> URL: https://issues.apache.org/jira/browse/SLING-10401
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.4
>
>
> Currently all dependencies are marked as {{provided}} although cp2fm is never
> executed in some sort of container but either used standalone or used as
> library e.g. from Maven plugins. For the latter a scope of {{compile}} is
> much better, as that way dependencies are transitive. Otherwise every
> consumer has to redefine all used dependencies (very error prone). Compare
> with https://github.com/adobe/aemanalyser-maven-plugin/issues/58.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #83: SLING-10401 change scope to 'compile' to not hide dependencies for
karlpauls merged pull request #83: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
