[jira] [Commented] (SLING-10528) Reject large packages

[Christian Schneider (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367864#comment-17367864
 ] 

Christian Schneider commented on SLING-10528:
-

How about rejecting the package on creation instead. This will give immediate 
feedback to the user that it does not work and we do not need to block.

> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.
> With this approach, we can ensure that Oak always return when importing a 
> package and we can fail fast for larger packages. Journal distribution will 
> also handle the errors nicely and allow to remove the blocking item from the 
> usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10535) sling.java.version used incorrectly for o.c.m.signature artifactId

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367663#comment-17367663
 ] 

Oliver Lietz commented on SLING-10535:
--

[~kwin], We should move the plugin completely to profile {{jdk8-or-lower}}. 
WDYT?

> sling.java.version used incorrectly for o.c.m.signature artifactId
> --
>
> Key: SLING-10535
> URL: https://issues.apache.org/jira/browse/SLING-10535
> Project: Sling
>  Issue Type: Bug
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Parent 44
>
>
> The value of the {{sling.java.version}} property should comply with the 
> following pattern: {{^(8|9|1[0-9])$}}.
> {{java18}} is the only valid value for {{artifactId}}:
> {noformat}
> 
> org.codehaus.mojo
> animal-sniffer-maven-plugin
> 1.20
> 
> 
> org.codehaus.mojo.signature
> 
> java1${sling.java.version}
> 1.0
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10535) sling.java.version used incorrectly for o.c.m.signature artifactId

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10535:


 Summary: sling.java.version used incorrectly for o.c.m.signature 
artifactId
 Key: SLING-10535
 URL: https://issues.apache.org/jira/browse/SLING-10535
 Project: Sling
  Issue Type: Bug
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Parent 44


The value of the {{sling.java.version}} property should comply with the 
following pattern: {{^(8|9|1[0-9])$}}.

{{java18}} is the only valid value for {{artifactId}}:

{noformat}

org.codehaus.mojo
animal-sniffer-maven-plugin
1.20


org.codehaus.mojo.signature
java1${sling.java.version}
1.0



{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10528) Reject large packages

[Timothee Maret (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367661#comment-17367661
 ] 

Timothee Maret commented on SLING-10528:


Opened 
[PR#75|https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/75]
 that limits packages to 5MB. In my test environments, it takes around 1 minute 
to import 5MB binary-less package worth of assets. 

Packages larger than 5MB will fail upon import and will be handled via the 
standard procedures, either blocking the queue or moving it in a quarantine 
queue.

> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.
> With this approach, we can ensure that Oak always return when importing a 
> package and we can fail fast for larger packages. Journal distribution will 
> also handle the errors nicely and allow to remove the blocking item from the 
> usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10529) Remove MDC constructs

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-10529.

Resolution: Fixed

Merged PR #74

> Remove MDC constructs
> -
>
> Key: SLING-10529
> URL: https://issues.apache.org/jira/browse/SLING-10529
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Minor
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> BookKeeper sets up MDC which are not used. We should remove them and rely on 
> consistent logging instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10527) Log imported instead of importing package

[Timothee Maret (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367635#comment-17367635
 ] 

Timothee Maret commented on SLING-10527:


Merged PR #73

> Log imported instead of importing package
> -
>
> Key: SLING-10527
> URL: https://issues.apache.org/jira/browse/SLING-10527
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Currently the package import is logged at INFO level before processing the 
> package
> {code}
> log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
> {code}
> This makes it difficult to figure out if there was an error with the import 
> because one has to seek further logs to see if the package import failed or 
> (worst) no log if the package was imported successfully. We should ensure 
> that a single log statement is logged upon import, either the import 
> succeeded or failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10527) Log imported instead of importing package

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-10527.

Resolution: Fixed

> Log imported instead of importing package
> -
>
> Key: SLING-10527
> URL: https://issues.apache.org/jira/browse/SLING-10527
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Currently the package import is logged at INFO level before processing the 
> package
> {code}
> log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
> {code}
> This makes it difficult to figure out if there was an error with the import 
> because one has to seek further logs to see if the package import failed or 
> (worst) no log if the package was imported successfully. We should ensure 
> that a single log statement is logged upon import, either the import 
> succeeded or failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Wrong tag in Scripting Core POM - issue in Sling CLI?

[Radu Cotescu]

Hi Olli,

> On 22 Jun 2021, at 13:21, Oliver Lietz  wrote:
> 
> Hi *,
> 
> The git tag is org.apache.sling.scripting.core-2.3.0 instead of HEAD (will 
> fix 
> it).
> 
> https://github.com/apache/sling-org-apache-sling-scripting-core/commit/
> 703a4409d65a0f882dec5e5103bd241c8915c71c#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8
> 
> Was it caused by Sling CLI?

Definitely not - the tool doesn’t touch the Git repos at all. I have no idea 
what caused it though…

Thanks,
Radu

RE: [VOTE] Release Apache Sling JUnit Core 1.1.4

[Stefan Seifert]

+1

RE: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.2.2

[Stefan Seifert]

+1

[jira] [Reopened] (SLING-10533) The @connection directive cannot be used with interfaces

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reopened SLING-10533:
--

> The @connection directive cannot be used with interfaces
> 
>
> Key: SLING-10533
> URL: https://issues.apache.org/jira/browse/SLING-10533
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> The {{\@connection}} directive cannot currently use interfaces in its {{for}} 
> argument, since the current implementation expect the type to be an 
> {{ObjectTypeDefinition}}. In practice, this can be just a {{TypeDefinition}}, 
> since only its name is required to generate the Relay types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10533) The @connection directive cannot be used with interfaces

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-10533.
--
Resolution: Fixed

Fixed in [commit 
078bfb4|https://github.com/apache/sling-org-apache-sling-graphql-core/commit/078bfb4].

> The @connection directive cannot be used with interfaces
> 
>
> Key: SLING-10533
> URL: https://issues.apache.org/jira/browse/SLING-10533
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> The {{\@connection}} directive cannot currently use interfaces in its {{for}} 
> argument, since the current implementation expect the type to be an 
> {{ObjectTypeDefinition}}. In practice, this can be just a {{TypeDefinition}}, 
> since only its name is required to generate the Relay types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-10503:


Assignee: Bertrand Delacretaz

> DefaultQueryExecutor should not log the full Schema Definition on error
> ---
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Denis Moret
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]
> _Update: as discussed below we have removed the schema from the logs, as it 
> can be quite big. And added the selectors to log messages, which together 
> with the Resource path allow the schema to be recreated if needed_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10534) NullPointerException on stopping of bundles

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10534.
--
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/3e22411765bec909b005fa21155d107347e47ed7

> NullPointerException on stopping of bundles
> ---
>
> Key: SLING-10534
> URL: https://issues.apache.org/jira/browse/SLING-10534
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 3.0.22
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: JCR Resource 3.0.24
>
>
> If a bundle is stopping, a race condition might occur for example if a 
> service user for that bundle is tried to get a resource resolver:
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.jcr.resource.internal.helper.jcr.JcrProviderStateFactory.createProviderState(JcrProviderStateFactory.java:100)
>  [org.apache.sling.jcr.resource:3.0.22]
>   at 
> org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.authenticate(JcrResourceProvider.java:303)
>  [org.apache.sling.jcr.resource:3.0.22]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10534) NullPointerException on stopping of bundles

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-10534:


 Summary: NullPointerException on stopping of bundles
 Key: SLING-10534
 URL: https://issues.apache.org/jira/browse/SLING-10534
 Project: Sling
  Issue Type: Bug
  Components: JCR
Affects Versions: JCR Resource 3.0.22
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 3.0.24


If a bundle is stopping, a race condition might occur for example if a service 
user for that bundle is tried to get a resource resolver:
java.lang.NullPointerException: null
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrProviderStateFactory.createProviderState(JcrProviderStateFactory.java:100)
 [org.apache.sling.jcr.resource:3.0.22]
at 
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.authenticate(JcrResourceProvider.java:303)
 [org.apache.sling.jcr.resource:3.0.22]




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Update managed dependencies from Core R6 to Core R7

[Konrad Windszus]

Yes, sounds reasonable.
Konrad

> On 22. Jun 2021, at 17:18, Oliver Lietz  wrote:
> 
> On Tuesday, 25 May 2021 21:01:51 CEST Konrad Windszus wrote:
>> Hi,
> 
> Hi,
> 
>> Is everyone fine when the upcoming parent release is dropping support for
>> Core R6 by upgrading the relevant managed dependencies to Core R7
>> (https://issues.apache.org/jira/browse/SLING-10408
>> ).
> 
> So all releases with Bundle Parent 43 are no drop-in releases (do not work on 
> R6).
> 
> This means we should at least increase the minor version, right?
> 
> O.
> 
>> Konrad
> 
> 
> 
> 

[jira] [Resolved] (SLING-10501) The analyser scanner should pass the artifact url to the resource builder

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10501.
--
Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/0919856abc41ff10ff1809a7494e0ad50447dc46

> The analyser scanner should pass the artifact url to the resource builder
> -
>
> Key: SLING-10501
> URL: https://issues.apache.org/jira/browse/SLING-10501
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.26
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.28
>
>
> When the scanner is parsing artifacts it uses the ResourceBuilder from Felix 
> but doesn't give it the url of the artifact. That makes it so that if the 
> artifact can not be parsed (e.g. because it has invalid metadata) an 
> exception is thrown that doesn't give any indication of the artifact that 
> caused it. 
> Looks like this:
> {noformat}
> org.osgi.framework.BundleException: Unable to build resource for null: 
> Duplicate import: foo
> {noformat}
> The scanner should pass the artifact url at [0] to the Resourcebuilder so 
> that the exception contains the artifact id.
> [0] 
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/89d5544fbc86adf6b5a99f7a2cb96055dcb3b3d1/src/main/java/org/apache/sling/feature/scanner/impl/BundleDescriptorImpl.java#L227



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10501) The analyser scanner should pass the artifact url to the resource builder

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-10501:


Assignee: Carsten Ziegeler

> The analyser scanner should pass the artifact url to the resource builder
> -
>
> Key: SLING-10501
> URL: https://issues.apache.org/jira/browse/SLING-10501
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.26
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.28
>
>
> When the scanner is parsing artifacts it uses the ResourceBuilder from Felix 
> but doesn't give it the url of the artifact. That makes it so that if the 
> artifact can not be parsed (e.g. because it has invalid metadata) an 
> exception is thrown that doesn't give any indication of the artifact that 
> caused it. 
> Looks like this:
> {noformat}
> org.osgi.framework.BundleException: Unable to build resource for null: 
> Duplicate import: foo
> {noformat}
> The scanner should pass the artifact url at [0] to the Resourcebuilder so 
> that the exception contains the artifact id.
> [0] 
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/89d5544fbc86adf6b5a99f7a2cb96055dcb3b3d1/src/main/java/org/apache/sling/feature/scanner/impl/BundleDescriptorImpl.java#L227



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10533) The @connection directive cannot be used with interfaces

[Radu Cotescu (Jira)]

Radu Cotescu created SLING-10533:


 Summary: The @connection directive cannot be used with interfaces
 Key: SLING-10533
 URL: https://issues.apache.org/jira/browse/SLING-10533
 Project: Sling
  Issue Type: Bug
  Components: GraphQL
Affects Versions: GraphQL Core 0.0.10
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: GraphQL Core 0.0.12


The {{\@connection}} directive cannot currently use interfaces in its {{for}} 
argument, since the current implementation expect the type to be an 
{{ObjectTypeDefinition}}. In practice, this can be just a {{TypeDefinition}}, 
since only its name is required to generate the Relay types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10512) Analysers should not fail if no scanner is found

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10512.
--
Resolution: Fixed

Removed throwing the exception in 
https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/e4fe2a6e2eb871d5518a2c17b6617a7422b83d6c

> Analysers should not fail if no scanner is found
> 
>
> Key: SLING-10512
> URL: https://issues.apache.org/jira/browse/SLING-10512
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.26
>Reporter: Natalia Angulo Herrera
>Assignee: Carsten Ziegeler
>Priority: Major
>  Labels: Scanner
>
> Change analysers to not fail if no scanner is found 
> [https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/a5fe8cb8b73f226c32819fc0dd5c7c253a4f141d/src/main/java/org/apache/sling/feature/scanner/Scanner.java#L188]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10512) Analysers should not fail if no scanner is found

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-10512:
-
Fix Version/s: Feature Model Analyser 1.3.28

> Analysers should not fail if no scanner is found
> 
>
> Key: SLING-10512
> URL: https://issues.apache.org/jira/browse/SLING-10512
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.26
>Reporter: Natalia Angulo Herrera
>Assignee: Carsten Ziegeler
>Priority: Major
>  Labels: Scanner
> Fix For: Feature Model Analyser 1.3.28
>
>
> Change analysers to not fail if no scanner is found 
> [https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/a5fe8cb8b73f226c32819fc0dd5c7c253a4f141d/src/main/java/org/apache/sling/feature/scanner/Scanner.java#L188]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10512) Analysers should not fail if no scanner is found

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-10512:


Assignee: Carsten Ziegeler

> Analysers should not fail if no scanner is found
> 
>
> Key: SLING-10512
> URL: https://issues.apache.org/jira/browse/SLING-10512
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.26
>Reporter: Natalia Angulo Herrera
>Assignee: Carsten Ziegeler
>Priority: Major
>  Labels: Scanner
>
> Change analysers to not fail if no scanner is found 
> [https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/a5fe8cb8b73f226c32819fc0dd5c7c253a4f141d/src/main/java/org/apache/sling/feature/scanner/Scanner.java#L188]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10511) Remove the ApiRegionsExtensionScanner

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10511.
--
Resolution: Fixed

Removed in 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/commit/1522845adbf6968428aded2c614e7d96831c4933

> Remove the ApiRegionsExtensionScanner
> -
>
> Key: SLING-10511
> URL: https://issues.apache.org/jira/browse/SLING-10511
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.0
>Reporter: Natalia Angulo Herrera
>Assignee: Carsten Ziegeler
>Priority: Major
>  Labels: Scanner
> Fix For: Feature Model API Regions Extension 1.3.2
>
>
> The api regions extension scanner shouldn't handle the content package 
> extension. We plan to remove it and don't fail if no extension is used to see 
> if the current content package extension issue that we are experiencing is 
> solved.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10511) Remove the ApiRegionsExtensionScanner

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-10511:


Assignee: Carsten Ziegeler

> Remove the ApiRegionsExtensionScanner
> -
>
> Key: SLING-10511
> URL: https://issues.apache.org/jira/browse/SLING-10511
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.0
>Reporter: Natalia Angulo Herrera
>Assignee: Carsten Ziegeler
>Priority: Major
>  Labels: Scanner
> Fix For: Feature Model API Regions Extension 1.3.2
>
>
> The api regions extension scanner shouldn't handle the content package 
> extension. We plan to remove it and don't fail if no extension is used to see 
> if the current content package extension issue that we are experiencing is 
> solved.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

[Denis Moret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Denis Moret resolved SLING-10503.
-
Resolution: Fixed

> DefaultQueryExecutor should not log the full Schema Definition on error
> ---
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Denis Moret
>Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]
> _Update: as discussed below we have removed the schema from the logs, as it 
> can be quite big. And added the selectors to log messages, which together 
> with the Resource path allow the schema to be recreated if needed_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

[Denis Moret (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367492#comment-17367492
 ] 

Denis Moret commented on SLING-10503:
-

Thanks, looks good to me. 

> DefaultQueryExecutor should not log the full Schema Definition on error
> ---
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Denis Moret
>Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]
> _Update: as discussed below we have removed the schema from the logs, as it 
> can be quite big. And added the selectors to log messages, which together 
> with the Resource path allow the schema to be recreated if needed_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10511) Remove the ApiRegionsExtensionScanner

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-10511:
-
Fix Version/s: (was: Feature Model API Regions Runtime Fragment 1.1.10)
   Feature Model API Regions Extension 1.3.2

> Remove the ApiRegionsExtensionScanner
> -
>
> Key: SLING-10511
> URL: https://issues.apache.org/jira/browse/SLING-10511
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.0
>Reporter: Natalia Angulo Herrera
>Priority: Major
>  Labels: Scanner
> Fix For: Feature Model API Regions Extension 1.3.2
>
>
> The api regions extension scanner shouldn't handle the content package 
> extension. We plan to remove it and don't fail if no extension is used to see 
> if the current content package extension issue that we are experiencing is 
> solved.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10511) Remove the ApiRegionsExtensionScanner

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-10511:
-
Fix Version/s: Feature Model API Regions Runtime Fragment 1.1.10

> Remove the ApiRegionsExtensionScanner
> -
>
> Key: SLING-10511
> URL: https://issues.apache.org/jira/browse/SLING-10511
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.0
>Reporter: Natalia Angulo Herrera
>Priority: Major
>  Labels: Scanner
> Fix For: Feature Model API Regions Runtime Fragment 1.1.10
>
>
> The api regions extension scanner shouldn't handle the content package 
> extension. We plan to remove it and don't fail if no extension is used to see 
> if the current content package extension issue that we are experiencing is 
> solved.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10530) Validation mode is not respected for internal configurations

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10530.
--
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/commit/385ced4c30d174979fb16dde0c33a3db5f7dc577

> Validation mode is not respected for internal configurations
> 
>
> Key: SLING-10530
> URL: https://issues.apache.org/jira/browse/SLING-10530
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.3.2
>
>
> When internal configurations are listed just by name, then the validation 
> mode is not respected



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz closed pull request #24: SLING-10503: upon error the schema definition in logged only if the DEBUG log level is enabled

[GitBox]

bdelacretaz closed pull request #24:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/24


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #24: SLING-10503: upon error the schema definition in logged only if the DEBUG log level is enabled

[GitBox]

bdelacretaz commented on pull request #24:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/24#issuecomment-866104705


   Thank you for this contribution! I have incorporated your changes as part of 
a larger commit that includes new logging tests that were missing, 
https://github.com/apache/sling-org-apache-sling-graphql-core/commit/d430d47df5b190107d413f31ef19052aacab4d98


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367479#comment-17367479
 ] 

Bertrand Delacretaz commented on SLING-10503:
-

Thank you for this! I have incorporated your PR#24 changes in commit 
[d430d47|https://github.com/apache/sling-org-apache-sling-graphql-core/commit/d430d47df5b190107d413f31ef19052aacab4d98]
 (with credits) along with new tests that validate the log messages.

Please cross-check, and if ok you can mark this ticket resolved.

> DefaultQueryExecutor should not log the full Schema Definition on error
> ---
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Denis Moret
>Priority: Major
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

[Bertrand Delacretaz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-10503:

Description: 
If an exception is caught during a query execution, the full schema definition 
is logged. If the schema is large or if the error is repeating, it might induce 
a large quantity of logs.

I would suggest to log the schema definition on DEBUG log level only.

[https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]

_Update: as discussed below we have removed the schema from the logs, as it can 
be quite big. And added the selectors to log messages, which together with the 
Resource path allow the schema to be recreated if needed_

  was:
If an exception is caught during a query execution, the full schema definition 
is logged. If the schema is large or if the error is repeating, it might induce 
a large quantity of logs.

I would suggest to log the schema definition on DEBUG log level only.

[https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]


> DefaultQueryExecutor should not log the full Schema Definition on error
> ---
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Denis Moret
>Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]
> _Update: as discussed below we have removed the schema from the logs, as it 
> can be quite big. And added the selectors to log messages, which together 
> with the Resource path allow the schema to be recreated if needed_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

[Bertrand Delacretaz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-10503:

Fix Version/s: GraphQL Core 0.0.12

> DefaultQueryExecutor should not log the full Schema Definition on error
> ---
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Denis Moret
>Priority: Major
> Fix For: GraphQL Core 0.0.12
>
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10532) Enable code coverage with JaCoCo

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10532.
--
Resolution: Done

> Enable code coverage with JaCoCo
> 
>
> Key: SLING-10532
> URL: https://issues.apache.org/jira/browse/SLING-10532
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Presence 1.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10531) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10531.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10531
> URL: https://issues.apache.org/jira/browse/SLING-10531
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Presence 1.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10532) Enable code coverage with JaCoCo

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10532:


 Summary: Enable code coverage with JaCoCo
 Key: SLING-10532
 URL: https://issues.apache.org/jira/browse/SLING-10532
 Project: Sling
  Issue Type: Task
  Components: JCR, Oak
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: JCR Presence 1.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10531) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10531:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10531
 URL: https://issues.apache.org/jira/browse/SLING-10531
 Project: Sling
  Issue Type: Task
  Components: JCR, Oak
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: JCR Presence 1.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10530) Validation mode is not respected for internal configurations

[Carsten Ziegeler (Jira)]

Carsten Ziegeler created SLING-10530:


 Summary: Validation mode is not respected for internal 
configurations
 Key: SLING-10530
 URL: https://issues.apache.org/jira/browse/SLING-10530
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model API Regions Extension 1.3.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Feature Model API Regions Extension 1.3.2


When internal configurations are listed just by name, then the validation mode 
is not respected



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Update managed dependencies from Core R6 to Core R7

[Oliver Lietz]

On Tuesday, 25 May 2021 21:01:51 CEST Konrad Windszus wrote:
> Hi,

Hi,

> Is everyone fine when the upcoming parent release is dropping support for
> Core R6 by upgrading the relevant managed dependencies to Core R7
> (https://issues.apache.org/jira/browse/SLING-10408
> ).

So all releases with Bundle Parent 43 are no drop-in releases (do not work on 
R6).

This means we should at least increase the minor version, right?

O.

> Konrad

[jira] [Commented] (SLING-10488) Also use path for LocalStore node name

[Timothee Maret (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367443#comment-17367443
 ] 

Timothee Maret commented on SLING-10488:


[~cschneider] is this fixed ?

> Also use path for LocalStore node name
> --
>
> Key: SLING-10488
> URL: https://issues.apache.org/jira/browse/SLING-10488
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.16
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Sometimes we use the same server hostname on different clusters. We can use 
> the path of the serverUri to distinguish these.
> This change adds the path to the LocalStore node name so offsets are stored 
> uniquely.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10528) Reject large packages

[Timothee Maret (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367442#comment-17367442
 ] 

Timothee Maret commented on SLING-10528:


bq. if we can simple put a useful limit into the code or if we need a 
configuration.

We can hardcode the threshold and add the configuration later. The threshold is 
not expected to be configured that much because we are serialising in 
binary-less mode. It'd have been different with full binaries.

> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.
> With this approach, we can ensure that Oak always return when importing a 
> package and we can fail fast for larger packages. Journal distribution will 
> also handle the errors nicely and allow to remove the blocking item from the 
> usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10528) Reject large packages

[Christian Schneider (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367421#comment-17367421
 ] 

Christian Schneider commented on SLING-10528:
-

Make sense to reject such packages. Ideally we already reject to create such 
packages. 

So question is mainly if we can simple put a useful limit into the code or if 
we need a configuration.

> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.
> With this approach, we can ensure that Oak always return when importing a 
> package and we can fail fast for larger packages. Journal distribution will 
> also handle the errors nicely and allow to remove the blocking item from the 
> usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

[Bertrand Delacretaz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-10503:

Summary: DefaultQueryExecutor should not log the full Schema Definition on 
error  (was: DefaultQueyExecutor should not log the full Schema Definition on 
error)

> DefaultQueryExecutor should not log the full Schema Definition on error
> ---
>
> Key: SLING-10503
> URL: https://issues.apache.org/jira/browse/SLING-10503
> Project: Sling
>  Issue Type: Improvement
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.10
>Reporter: Denis Moret
>Priority: Major
>
> If an exception is caught during a query execution, the full schema 
> definition is logged. If the schema is large or if the error is repeating, it 
> might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10528) Reject large packages

[Timothee Maret (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367352#comment-17367352
 ] 

Timothee Maret commented on SLING-10528:


Thanks [~kwin]! Indeed, we could leverage auto save threshold but as you 
pointed out we'd loose atomic commits. In addition we have seen use cases where 
the threshold was not enforced due to missing dependencies. This latter issue 
may be fixed eventually.

> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.
> With this approach, we can ensure that Oak always return when importing a 
> package and we can fail fast for larger packages. Journal distribution will 
> also handle the errors nicely and allow to remove the blocking item from the 
> usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10528) Reject large packages

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367343#comment-17367343
 ] 

Konrad Windszus commented on SLING-10528:
-

Usually the {{session.save()}} takes long when the transient session space is 
very big. To prevent that from happening you can leverage 
https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/ImportOptions.html#setAutoSaveThreshold(int)
 which allows to trigger intermediate saves after a certain number of nodes has 
been imported. The only drawback is that rollback is not that easy in that case.

> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.
> With this approach, we can ensure that Oak always return when importing a 
> package and we can fail fast for larger packages. Journal distribution will 
> also handle the errors nicely and allow to remove the blocking item from the 
> usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10529) Remove MDC constructs

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-10529:
---
Priority: Minor  (was: Major)

> Remove MDC constructs
> -
>
> Key: SLING-10529
> URL: https://issues.apache.org/jira/browse/SLING-10529
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Minor
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> BookKeeper sets up MDC which are not used. We should remove them and rely on 
> consistent logging instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10529) Remove MDC constructs

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-10529:
---
Description: BookKeeper sets up MDC which are not used. We should remove 
them and rely on consistent logging instead.  (was: Journal distribution 
serialise content packages in binary less mode only. When doing "deep" 
distribution, the package can still become so large that the importing side 
can't ingest it. When this happens, Apache Oak does a session save that never 
seem to return and can easily take 8 hours to terminate.

I suggest to detect those large packages, based on the package size and simply 
reject packages above a  configurable limit size. The limit should take in 
consideration the mean import throughput for a single Oak session on cloud 
segment tar and should keep the save operation below, say 15 minutes.

With this approach, we can ensure that Oak always return when importing a 
package and we can fail fast for larger packages. Journal distribution will 
also handle the errors nicely and allow to remove the blocking item from the 
usual set of tools. )

> Remove MDC constructs
> -
>
> Key: SLING-10529
> URL: https://issues.apache.org/jira/browse/SLING-10529
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> BookKeeper sets up MDC which are not used. We should remove them and rely on 
> consistent logging instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10529) Remove MDC constructs

[Timothee Maret (Jira)]

Timothee Maret created SLING-10529:
--

 Summary: Remove MDC constructs
 Key: SLING-10529
 URL: https://issues.apache.org/jira/browse/SLING-10529
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
 Fix For: Content Distribution Journal Core 0.1.18


Journal distribution serialise content packages in binary less mode only. When 
doing "deep" distribution, the package can still become so large that the 
importing side can't ingest it. When this happens, Apache Oak does a session 
save that never seem to return and can easily take 8 hours to terminate.

I suggest to detect those large packages, based on the package size and simply 
reject packages above a  configurable limit size. The limit should take in 
consideration the mean import throughput for a single Oak session on cloud 
segment tar and should keep the save operation below, say 15 minutes.

With this approach, we can ensure that Oak always return when importing a 
package and we can fail fast for larger packages. Journal distribution will 
also handle the errors nicely and allow to remove the blocking item from the 
usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10528) Reject large packages

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-10528:
---
Description: 
Journal distribution serialise content packages in binary less mode only. When 
doing "deep" distribution, the package can still become so large that the 
importing side can't ingest it. When this happens, Apache Oak does a session 
save that never seem to return and can easily take 8 hours to terminate.

I suggest to detect those large packages, based on the package size and simply 
reject packages above a  configurable limit size. The limit should take in 
consideration the mean import throughput for a single Oak session on cloud 
segment tar and should keep the save operation below, say 15 minutes.

With this approach, we can ensure that Oak always return when importing a 
package and we can fail fast for larger packages. Journal distribution will 
also handle the errors nicely and allow to remove the blocking item from the 
usual set of tools. 

  was:
Journal distribution serialise content packages in binary less mode only. When 
doing "deep" distribution, the package can still become so large that the 
importing side can't ingest it. When this happens, Apache Oak does a session 
save that never seem to return and can easily take 8 hours to terminate.

I suggest to detect those large packages, based on the package size and simply 
reject packages above a  configurable limit size. The limit should take in 
consideration the mean import throughput for a single Oak session on cloud 
segment tar and should keep the save operation below, say 15 minutes.


> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.
> With this approach, we can ensure that Oak always return when importing a 
> package and we can fail fast for larger packages. Journal distribution will 
> also handle the errors nicely and allow to remove the blocking item from the 
> usual set of tools. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10528) Reject large packages

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-10528:
---
Description: 
Journal distribution serialise content packages in binary less mode only. When 
doing "deep" distribution, the package can still become so large that the 
importing side can't ingest it. When this happens, Apache Oak does a session 
save that never seem to return and can easily take 8 hours to terminate.

I suggest to detect those large packages, based on the package size and simply 
reject packages above a  configurable limit size. The limit should take in 
consideration the mean import throughput for a single Oak session on cloud 
segment tar and should keep the save operation below, say 15 minutes.

  was:
Currently the package import is logged at INFO level before processing the 
package
{code}
log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
{code}

This makes it difficult to figure out if there was an error with the import 
because one has to seek further logs to see if the package import failed or 
(worst) no log if the package was imported successfully. We should ensure that 
a single log statement is logged upon import, either the import succeeded or 
failed.


> Reject large packages
> -
>
> Key: SLING-10528
> URL: https://issues.apache.org/jira/browse/SLING-10528
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Journal distribution serialise content packages in binary less mode only. 
> When doing "deep" distribution, the package can still become so large that 
> the importing side can't ingest it. When this happens, Apache Oak does a 
> session save that never seem to return and can easily take 8 hours to 
> terminate.
> I suggest to detect those large packages, based on the package size and 
> simply reject packages above a  configurable limit size. The limit should 
> take in consideration the mean import throughput for a single Oak session on 
> cloud segment tar and should keep the save operation below, say 15 minutes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10528) Reject large packages

[Timothee Maret (Jira)]

Timothee Maret created SLING-10528:
--

 Summary: Reject large packages
 Key: SLING-10528
 URL: https://issues.apache.org/jira/browse/SLING-10528
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
 Fix For: Content Distribution Journal Core 0.1.18


Currently the package import is logged at INFO level before processing the 
package
{code}
log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
{code}

This makes it difficult to figure out if there was an error with the import 
because one has to seek further logs to see if the package import failed or 
(worst) no log if the package was imported successfully. We should ensure that 
a single log statement is logged upon import, either the import succeeded or 
failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10527) Log imported instead of importing package

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret reassigned SLING-10527:
--

Assignee: Timothee Maret

> Log imported instead of importing package
> -
>
> Key: SLING-10527
> URL: https://issues.apache.org/jira/browse/SLING-10527
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Currently the package import is logged at INFO level before processing the 
> package
> {code}
> log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
> {code}
> This makes it difficult to figure out if there was an error with the import 
> because one has to seek further logs to see if the package import failed or 
> (worst) no log if the package was imported successfully. We should ensure 
> that a single log statement is logged upon import, either the import 
> succeeded or failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10527) Log imported instead of importing package

[Timothee Maret (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367278#comment-17367278
 ] 

Timothee Maret commented on SLING-10527:


https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/73

> Log imported instead of importing package
> -
>
> Key: SLING-10527
> URL: https://issues.apache.org/jira/browse/SLING-10527
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Currently the package import is logged at INFO level before processing the 
> package
> {code}
> log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
> {code}
> This makes it difficult to figure out if there was an error with the import 
> because one has to seek further logs to see if the package import failed or 
> (worst) no log if the package was imported successfully. We should ensure 
> that a single log statement is logged upon import, either the import 
> succeeded or failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Issue Comment Deleted] (SLING-10527) Log imported instead of importing package

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-10527:
---
Comment: was deleted

(was: 
https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/73)

> Log imported instead of importing package
> -
>
> Key: SLING-10527
> URL: https://issues.apache.org/jira/browse/SLING-10527
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Currently the package import is logged at INFO level before processing the 
> package
> {code}
> log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
> {code}
> This makes it difficult to figure out if there was an error with the import 
> because one has to seek further logs to see if the package import failed or 
> (worst) no log if the package was imported successfully. We should ensure 
> that a single log statement is logged upon import, either the import 
> succeeded or failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10527) Log imported instead of importing package

[Timothee Maret (Jira)]

Timothee Maret created SLING-10527:
--

 Summary: Log imported instead of importing package
 Key: SLING-10527
 URL: https://issues.apache.org/jira/browse/SLING-10527
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Reporter: Timothee Maret
 Fix For: Content Distribution Journal Core 0.1.18


Currently the package import is logged at INFO level before processing the 
package
{code}
log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
{code}

This makes it difficult to figure out if there was an error with the import 
because one has to seek further logs to see if the package import failed or 
(worst) no log if the package was imported successfully. We should ensure that 
a single log statement is logged upon import, either the import succeeded or 
failed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10525) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10525.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10525
> URL: https://issues.apache.org/jira/browse/SLING-10525
> Project: Sling
>  Issue Type: Task
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Resource Presence 0.0.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10526) Enable code coverage with JaCoCo

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10526.
--
Resolution: Done

> Enable code coverage with JaCoCo
> 
>
> Key: SLING-10526
> URL: https://issues.apache.org/jira/browse/SLING-10526
> Project: Sling
>  Issue Type: Task
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Resource Presence 0.0.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10526) Enable code coverage with JaCoCo

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10526:


 Summary: Enable code coverage with JaCoCo
 Key: SLING-10526
 URL: https://issues.apache.org/jira/browse/SLING-10526
 Project: Sling
  Issue Type: Task
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Resource Presence 0.0.4






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10525) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10525:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10525
 URL: https://issues.apache.org/jira/browse/SLING-10525
 Project: Sling
  Issue Type: Task
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Resource Presence 0.0.4






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10522) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10522.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10522
> URL: https://issues.apache.org/jira/browse/SLING-10522
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Thymeleaf 2.0.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10514) Update to Felix framework 7.0.1

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-10514.

Resolution: Fixed

Done in https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/10

> Update to Felix framework 7.0.1
> ---
>
> Key: SLING-10514
> URL: https://issues.apache.org/jira/browse/SLING-10514
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.7.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Launchpad Base 2.7.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Now that Felix framework 7.0.1 is released we should update the launchpad 
> base.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-launchpad-base] karlpauls merged pull request #10: SLING-10514: update to felix framework 7.0.1

[GitBox]

karlpauls merged pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/10


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10513) Merging artifact extensions will not preserve the feature origin of the first feature

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-10513.

Resolution: Fixed

Done in https://github.com/apache/sling-org-apache-sling-feature/pull/27

> Merging artifact extensions will not preserve the feature origin of the first 
> feature
> -
>
> Key: SLING-10513
> URL: https://issues.apache.org/jira/browse/SLING-10513
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.22
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model 1.2.24
>
>
> When merging two features, the default merge for the artifact extensions 
> (like e.g. the content-packages extension) will not preserve the origin of 
> the first feature because it will just take the extension as is. Only the 
> second feature will get the feature origin when it is merged into the first 
> one. 
> We should fix this by making sure the feature origin is written even for the 
> first feature (the best way is probably to just merge the first feature with 
> an empty extension just like the second one will be merged).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature] karlpauls merged pull request #27: SLING-10513: merge extensions even if there is no target to merge wit…

[GitBox]

karlpauls merged pull request #27:
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/27


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10524) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10524.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10524
> URL: https://issues.apache.org/jira/browse/SLING-10524
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Core 2.3.8
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Wrong tag in Scripting Core POM - issue in Sling CLI?

[Oliver Lietz]

Hi *,

The git tag is org.apache.sling.scripting.core-2.3.0 instead of HEAD (will fix 
it).

https://github.com/apache/sling-org-apache-sling-scripting-core/commit/
703a4409d65a0f882dec5e5103bd241c8915c71c#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8

Was it caused by Sling CLI?

Regards,
O.

[jira] [Resolved] (SLING-10523) Update Commons Testing to 2.1.2

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10523.
--
Resolution: Done

> Update Commons Testing to 2.1.2
> ---
>
> Key: SLING-10523
> URL: https://issues.apache.org/jira/browse/SLING-10523
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Core 2.3.8
>
>
> Outdated dependency is causing issues:
> {noformat}
> [INFO] +- org.apache.sling:org.apache.sling.commons.testing:jar:2.0.6:test
> [INFO] |  +- org.apache.sling:org.apache.sling.jcr.api:jar:2.0.6:test
> [INFO] |  +- javax.jcr:jcr:jar:2.0:provided
> [INFO] |  +- org.apache.jackrabbit:jackrabbit-api:jar:2.1.1:test
> [INFO] |  +- org.apache.jackrabbit:jackrabbit-jcr-commons:jar:2.1.1:test
> [INFO] |  +- org.apache.jackrabbit:jackrabbit-core:jar:2.1.1:test
> [INFO] |  |  +- concurrent:concurrent:jar:1.3.4:test
> [INFO] |  |  +- commons-dbcp:commons-dbcp:jar:1.2.2:test
> [INFO] |  |  |  \- commons-pool:commons-pool:jar:1.3:test
> [INFO] |  |  +- org.apache.jackrabbit:jackrabbit-spi-commons:jar:2.1.1:test
> [INFO] |  |  +- org.apache.jackrabbit:jackrabbit-spi:jar:2.1.1:test
> [INFO] |  |  +- org.apache.tika:tika-parsers:jar:0.6:test
> [INFO] |  |  |  +- org.apache.tika:tika-core:jar:0.6:test
> [INFO] |  |  |  +- org.apache.commons:commons-compress:jar:1.0:test
> [INFO] |  |  |  +- org.apache.poi:poi:jar:3.6:test
> [INFO] |  |  |  +- org.apache.poi:poi-scratchpad:jar:3.6:test
> [INFO] |  |  |  +- org.apache.poi:poi-ooxml:jar:3.6:test
> [INFO] |  |  |  |  +- org.apache.poi:poi-ooxml-schemas:jar:3.6:test
> [INFO] |  |  |  |  |  \- org.apache.xmlbeans:xmlbeans:jar:2.3.0:test
> [INFO] |  |  |  |  \- dom4j:dom4j:jar:1.6.1:test
> [INFO] |  |  |  | \- xml-apis:xml-apis:jar:1.0.b2:test
> [INFO] |  |  |  +- 
> org.apache.geronimo.specs:geronimo-stax-api_1.0_spec:jar:1.0.1:test
> [INFO] |  |  |  +- org.ccil.cowan.tagsoup:tagsoup:jar:1.2:test
> [INFO] |  |  |  +- asm:asm:jar:3.1:test
> [INFO] |  |  |  +- log4j:log4j:jar:1.2.14:test
> [INFO] |  |  |  \- com.drewnoakes:metadata-extractor:jar:2.4.0-beta-1:test
> [INFO] |  |  +- org.apache.pdfbox:pdfbox:jar:1.0.0:test
> [INFO] |  |  |  +- org.apache.pdfbox:fontbox:jar:1.0.0:test
> [INFO] |  |  |  \- org.apache.pdfbox:jempbox:jar:1.0.0:test
> [INFO] |  |  +- org.slf4j:jcl-over-slf4j:jar:1.5.8:test
> [INFO] |  |  +- org.apache.lucene:lucene-core:jar:2.4.1:test
> [INFO] |  |  \- org.apache.derby:derby:jar:10.5.3.0_1:test
> [INFO] |  +- org.apache.sling:org.apache.sling.adapter:jar:2.0.4:test
> [INFO] |  +- rhino:js:jar:1.6R6:test
> [INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:test
> [INFO] |  \- org.jmock:jmock-junit4:jar:2.5.1:test
> [INFO] | +- org.jmock:jmock:jar:2.5.1:test
> [INFO] | |  \- org.hamcrest:hamcrest-library:jar:1.1:test
> [INFO] | \- junit:junit-dep:jar:4.4:test
> {noformat}
> {noformat}
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 20 source files to 
> /[...]/org.apache.sling.scripting.core/target/test-classes
> [INFO] -
> [ERROR] COMPILATION ERROR : 
> [INFO] -
> [ERROR] 
> /[...]/org.apache.sling.scripting.core/src/test/java/org/apache/sling/scripting/core/it/SLING_10147IT.java:[102,61]
>  cannot find symbol
>   symbol:   method getMethodName()
>   location: variable description of type org.junit.runner.Description
> [ERROR] 
> /[...]/org.apache.sling.scripting.core/src/test/java/org/apache/sling/scripting/core/it/SLING_10147IT.java:[110,60]
>  cannot find symbol
>   symbol:   method getMethodName()
>   location: variable description of type org.junit.runner.Description
> [INFO] 2 errors 
> [INFO] -
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10524) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10524:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10524
 URL: https://issues.apache.org/jira/browse/SLING-10524
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Core 2.3.8






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10523) Update Commons Testing to 2.1.2

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10523:


 Summary: Update Commons Testing to 2.1.2
 Key: SLING-10523
 URL: https://issues.apache.org/jira/browse/SLING-10523
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Core 2.3.8


Outdated dependency is causing issues:
{noformat}
[INFO] +- org.apache.sling:org.apache.sling.commons.testing:jar:2.0.6:test
[INFO] |  +- org.apache.sling:org.apache.sling.jcr.api:jar:2.0.6:test
[INFO] |  +- javax.jcr:jcr:jar:2.0:provided
[INFO] |  +- org.apache.jackrabbit:jackrabbit-api:jar:2.1.1:test
[INFO] |  +- org.apache.jackrabbit:jackrabbit-jcr-commons:jar:2.1.1:test
[INFO] |  +- org.apache.jackrabbit:jackrabbit-core:jar:2.1.1:test
[INFO] |  |  +- concurrent:concurrent:jar:1.3.4:test
[INFO] |  |  +- commons-dbcp:commons-dbcp:jar:1.2.2:test
[INFO] |  |  |  \- commons-pool:commons-pool:jar:1.3:test
[INFO] |  |  +- org.apache.jackrabbit:jackrabbit-spi-commons:jar:2.1.1:test
[INFO] |  |  +- org.apache.jackrabbit:jackrabbit-spi:jar:2.1.1:test
[INFO] |  |  +- org.apache.tika:tika-parsers:jar:0.6:test
[INFO] |  |  |  +- org.apache.tika:tika-core:jar:0.6:test
[INFO] |  |  |  +- org.apache.commons:commons-compress:jar:1.0:test
[INFO] |  |  |  +- org.apache.poi:poi:jar:3.6:test
[INFO] |  |  |  +- org.apache.poi:poi-scratchpad:jar:3.6:test
[INFO] |  |  |  +- org.apache.poi:poi-ooxml:jar:3.6:test
[INFO] |  |  |  |  +- org.apache.poi:poi-ooxml-schemas:jar:3.6:test
[INFO] |  |  |  |  |  \- org.apache.xmlbeans:xmlbeans:jar:2.3.0:test
[INFO] |  |  |  |  \- dom4j:dom4j:jar:1.6.1:test
[INFO] |  |  |  | \- xml-apis:xml-apis:jar:1.0.b2:test
[INFO] |  |  |  +- 
org.apache.geronimo.specs:geronimo-stax-api_1.0_spec:jar:1.0.1:test
[INFO] |  |  |  +- org.ccil.cowan.tagsoup:tagsoup:jar:1.2:test
[INFO] |  |  |  +- asm:asm:jar:3.1:test
[INFO] |  |  |  +- log4j:log4j:jar:1.2.14:test
[INFO] |  |  |  \- com.drewnoakes:metadata-extractor:jar:2.4.0-beta-1:test
[INFO] |  |  +- org.apache.pdfbox:pdfbox:jar:1.0.0:test
[INFO] |  |  |  +- org.apache.pdfbox:fontbox:jar:1.0.0:test
[INFO] |  |  |  \- org.apache.pdfbox:jempbox:jar:1.0.0:test
[INFO] |  |  +- org.slf4j:jcl-over-slf4j:jar:1.5.8:test
[INFO] |  |  +- org.apache.lucene:lucene-core:jar:2.4.1:test
[INFO] |  |  \- org.apache.derby:derby:jar:10.5.3.0_1:test
[INFO] |  +- org.apache.sling:org.apache.sling.adapter:jar:2.0.4:test
[INFO] |  +- rhino:js:jar:1.6R6:test
[INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:test
[INFO] |  \- org.jmock:jmock-junit4:jar:2.5.1:test
[INFO] | +- org.jmock:jmock:jar:2.5.1:test
[INFO] | |  \- org.hamcrest:hamcrest-library:jar:1.1:test
[INFO] | \- junit:junit-dep:jar:4.4:test
{noformat}
{noformat}
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 20 source files to 
/[...]/org.apache.sling.scripting.core/target/test-classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/[...]/org.apache.sling.scripting.core/src/test/java/org/apache/sling/scripting/core/it/SLING_10147IT.java:[102,61]
 cannot find symbol
  symbol:   method getMethodName()
  location: variable description of type org.junit.runner.Description
[ERROR] 
/[...]/org.apache.sling.scripting.core/src/test/java/org/apache/sling/scripting/core/it/SLING_10147IT.java:[110,60]
 cannot find symbol
  symbol:   method getMethodName()
  location: variable description of type org.junit.runner.Description
[INFO] 2 errors 
[INFO] -
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] jsedding commented on a change in pull request #25: SLING-10502 - lazy loading helpers

[GitBox]

jsedding commented on a change in pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#discussion_r656099353



##
File path: 
src/main/java/org/apache/sling/graphql/helpers/layzloading/LazyLoadingField.java
##
@@ -0,0 +1,44 @@
+/*~~
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements.  See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership.  The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License.  You may obtain a copy of the License at
+ ~
+ ~   http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied.  See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ 
~*/
+
+package org.apache.sling.graphql.helpers.layzloading;
+
+import java.util.function.Supplier;
+
+/** Helper for a single lazy-loading value */
+public class LazyLoadingField {
+private Supplier supplier;
+private T value;
+
+public LazyLoadingField(Supplier supplier) {
+this.supplier = supplier;
+}
+
+public T get() {
+if(value == null) {

Review comment:
   AFAIK double-checked locking requires the checked field to be volatile. 
Why not make supplier volatile, use that one exclusively for checking and get 
support for "null" values as well? Granted, your current code looks like it can 
support null values, but in case of a null value, it will always enter the 
synchronized block even when the computation was already performed. 

##
File path: 
src/main/java/org/apache/sling/graphql/helpers/layzloading/LazyLoadingMap.java
##
@@ -0,0 +1,177 @@
+/*~~
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements.  See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership.  The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License.  You may obtain a copy of the License at
+ ~
+ ~   http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied.  See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ 
~*/
+
+package org.apache.sling.graphql.helpers.layzloading;
+
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+import java.util.function.Supplier;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class LazyLoadingMap extends HashMap {
+
+private final Logger log = LoggerFactory.getLogger(getClass());
+private final Map> suppliers = new HashMap<>();
+private int suppliersCallCount;
+
+/** Calls computeAll - should be avoided if possible */
+@Override
+public boolean equals(Object o) {
+if(!(o instanceof LazyLoadingMap)) {
+return false;
+}
+final LazyLoadingMap other = (LazyLoadingMap)o;
+
+// Equality seems complicated to compute without this
+computeAll();
+return super.equals(other);
+}
+
+@Override
+public int hashCode() {
+return super.hashCode() + suppliers.hashCode();
+}
+
+/** Adds a Supplier that provides a lazy loaded value.
+ *  Removes existing value with the same key if it exists.
+ */
+public Supplier put(K key, Supplier supplier) {
+if(super.containsKey(key)) {
+synchronized(this) {
+super.remove(key);
+return suppliers.put(key, supplier);
+}
+} else {
+return suppliers.put(key, supplier);
+}
+}
+
+@Override
+public T get(Object key) {
+return lazyCompute(key);
+}
+
+@SuppressWarnings("unchecked")
+private T lazyCompute(Object key) {
+if(key == null) {
+return null;
+}
+T value = super.get(key);

Review comment:
   Consider whether `Map#comuteIfAbsent()` would make the code more concise 
here.

##
Fil

[jira] [Resolved] (SLING-10521) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10521.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10521
> URL: https://issues.apache.org/jira/browse/SLING-10521
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Groovy 1.2.2
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #25: SLING-10502 - lazy loading helpers

[GitBox]

sonarcloud[bot] removed a comment on pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-865798018


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
 [97.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10521) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10521:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10521
 URL: https://issues.apache.org/jira/browse/SLING-10521
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Groovy 1.2.2






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10520) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10520:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10520
 URL: https://issues.apache.org/jira/browse/SLING-10520
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting FreeMarker 1.0.6






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #25: SLING-10502 - lazy loading helpers

[GitBox]

sonarcloud[bot] commented on pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-865856572


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
 [97.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10520) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10520.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10520
> URL: https://issues.apache.org/jira/browse/SLING-10520
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting FreeMarker 1.0.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10522) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10522:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10522
 URL: https://issues.apache.org/jira/browse/SLING-10522
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Thymeleaf 2.0.4






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10519) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10519.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10519
> URL: https://issues.apache.org/jira/browse/SLING-10519
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Clam 1.1.2
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10519) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10519:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10519
 URL: https://issues.apache.org/jira/browse/SLING-10519
 Project: Sling
  Issue Type: Task
  Components: JCR, Oak
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Clam 1.1.2






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10518) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10518.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10518
> URL: https://issues.apache.org/jira/browse/SLING-10518
> Project: Sling
>  Issue Type: Task
>  Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Messaging Mail 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10518) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10518:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10518
 URL: https://issues.apache.org/jira/browse/SLING-10518
 Project: Sling
  Issue Type: Task
  Components: Commons
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Commons Messaging Mail 2.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10517) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10517.
--
Resolution: Done

> Update to Sling Bundle Parent 43
> 
>
> Key: SLING-10517
> URL: https://issues.apache.org/jira/browse/SLING-10517
> Project: Sling
>  Issue Type: Task
>  Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Clam 2.0.2
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10517) Update to Sling Bundle Parent 43

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10517:


 Summary: Update to Sling Bundle Parent 43
 Key: SLING-10517
 URL: https://issues.apache.org/jira/browse/SLING-10517
 Project: Sling
  Issue Type: Task
  Components: Commons
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Commons Clam 2.0.2






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #25: SLING-10502 - lazy loading helpers

[GitBox]

sonarcloud[bot] commented on pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-865798018


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
 [97.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #25: SLING-10502 - lazy loading helpers

[GitBox]

sonarcloud[bot] removed a comment on pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-865204722


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
 [97.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10516) Update Sling Commons Crypto to 1.1.0

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-10516:
-
Summary: Update Sling Commons Crypto to 1.1.0  (was: Update Commons Crypto 
to 1.1.0)

> Update Sling Commons Crypto to 1.1.0
> 
>
> Key: SLING-10516
> URL: https://issues.apache.org/jira/browse/SLING-10516
> Project: Sling
>  Issue Type: Task
>  Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons Messaging Mail 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10516) Update Commons Crypto to 1.1.0

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10516:


 Summary: Update Commons Crypto to 1.1.0
 Key: SLING-10516
 URL: https://issues.apache.org/jira/browse/SLING-10516
 Project: Sling
  Issue Type: Task
  Components: Commons
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Commons Messaging Mail 2.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10506) Document inappropriate Sonar rules

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10506:

Description: 
* {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
* {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
* {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
* {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
* {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
* {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
* {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
* {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)

  was:
* {{java:S100}}
* {{java:S112}}
* {{java:S1117}}
* {{java:S1149}}
* {{java:S1989}}
* {{java:S2226}}
* {{java:S3077}}
* {{java:S6212}}


> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367128#comment-17367128
 ] 

Oliver Lietz commented on SLING-10506:
--

[~kwin], I'm not yet aware how to quickly look up rules without a running 
SonarQube instance. The rules (e.g. 
[java-checks|https://github.com/SonarSource/sonar-java/tree/master/java-checks/src/main/resources/org/sonar/l10n/java/rules/java])
 are generated from Jira [RSPEC|https://jira.sonarsource.com/browse/RSPEC].

> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}}
> * {{java:S112}}
> * {{java:S1117}}
> * {{java:S1149}}
> * {{java:S1989}}
> * {{java:S2226}}
> * {{java:S3077}}
> * {{java:S6212}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-servlets-resolver] bdelacretaz commented on a change in pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis

[GitBox]

bdelacretaz commented on a change in pull request #17:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#discussion_r655207027



##
File path: 
src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
 }
 
 public void testSearchPath1Element() {
-String root0 = "/apps";
-resourceResolver.setSearchPath(root0);
+String root0 = "/apps/";
+resourceResolverOptions.setSearchPaths(new String[] {
+root0
+});
 
 final Resource r = request.getResource();
 LocationIterator li = getLocationIterator(r.getResourceType(),
 r.getResourceSuperType());
 
 // 1. /apps/foo/bar
 assertTrue(li.hasNext());
-assertEquals(root0 + "/" + resourceTypePath, li.next());
+assertEquals(root0 + resourceTypePath, li.next());

Review comment:
   I'm curious. why does this slash need to go away in all tests?

##
File path: 
src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
 }
 
 public void testSearchPath1Element() {
-String root0 = "/apps";
-resourceResolver.setSearchPath(root0);
+String root0 = "/apps/";
+resourceResolverOptions.setSearchPaths(new String[] {
+root0
+});
 
 final Resource r = request.getResource();
 LocationIterator li = getLocationIterator(r.getResourceType(),
 r.getResourceSuperType());
 
 // 1. /apps/foo/bar
 assertTrue(li.hasNext());
-assertEquals(root0 + "/" + resourceTypePath, li.next());
+assertEquals(root0 + resourceTypePath, li.next());

Review comment:
   Ok, thank you for clarifying!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #24: Upon error the schema definition in logged only if the DEBUG log level is enabled

[GitBox]

sonarcloud[bot] commented on pull request #24:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/24#issuecomment-864899590






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-auth-core] enapps-enorman merged pull request #11: SLING-10166 Fix issues reported by sonar

[GitBox]

enapps-enorman merged pull request #11:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/11


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #25: SLING-10502 - lazy loading helpers

[GitBox]

sonarcloud[bot] commented on pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-865191175






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #24: SLING-10503: upon error the schema definition in logged only if the DEBUG log level is enabled

[GitBox]

bdelacretaz commented on a change in pull request #24:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/24#discussion_r655270342



##
File path: 
src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java
##
@@ -219,16 +219,25 @@ public ValidationResult validate(@NotNull String query, 
@NotNull Map

[GitHub] [sling-org-apache-sling-scripting-spi] enapps-enorman merged pull request #1: SLING-10504 resolve code quality warnings and issues reported by sonar

[GitBox]

enapps-enorman merged pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-scripting-spi/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #24: SLING-10503: upon error the schema definition in logged only if the DEBUG log level is enabled

[GitBox]

sonarcloud[bot] removed a comment on pull request #24:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/24#issuecomment-864899590






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-resolver] enapps-enorman commented on a change in pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis

[GitBox]

enapps-enorman commented on a change in pull request #17:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#discussion_r655495030



##
File path: 
src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
 }
 
 public void testSearchPath1Element() {
-String root0 = "/apps";
-resourceResolver.setSearchPath(root0);
+String root0 = "/apps/";
+resourceResolverOptions.setSearchPaths(new String[] {
+root0
+});
 
 final Resource r = request.getResource();
 LocationIterator li = getLocationIterator(r.getResourceType(),
 r.getResourceSuperType());
 
 // 1. /apps/foo/bar
 assertTrue(li.hasNext());
-assertEquals(root0 + "/" + resourceTypePath, li.next());
+assertEquals(root0 + resourceTypePath, li.next());

Review comment:
   This was compensating for the search root paths (root0/root1) already 
having a trailing slash so adding another slash doubles up the slashes and 
makes the test fail.
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] commented on pull request #27: SLING-10513: merge extensions even if there is no target to merge wit…

[GitBox]

sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature/pull/27#issuecomment-865337969


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature&pullRequest=27&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature&pullRequest=27&metric=new_coverage&view=list)
 [92.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature&pullRequest=27&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature&pullRequest=27&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature&pullRequest=27&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #25: SLING-10502 - lazy loading helpers

[GitBox]

sonarcloud[bot] removed a comment on pull request #25:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-865191175


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
 [97.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core&pullRequest=25&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org