Re: [VOTE] Release Apache Sling JUnit Core 1.1.4
It looks like TestsManagerImpl is detecting some inner classes as test classes at [1] which is causing the check to fail and throw the exception. 1. https://github.com/apache/sling-org-apache-sling-junit-core/blob/05eeeb42319eace3d8d7d111a9b60ef2b467b2e5/src/main/java/org/apache/sling/junit/impl/TestsManagerImpl.java#L110 On Wed, Jun 23, 2021 at 3:26 PM Eric Norman wrote: > Just a bit more information: > > I captured the stacktrace of the failure described in my last reply as: > > [ERROR] Exception while processing request to > /system/sling/junit/org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest/testResolveRemovedResourceAlias.junit_result > javax.servlet.ServletException: java.lang.IllegalStateException: A test > method name is only supported for a single test class > at > org.apache.sling.junit.impl.servlet.ServletProcessor.doPost(ServletProcessor.java:145) > at > org.apache.sling.junit.impl.servlet.JUnitServlet.doPost(JUnitServlet.java:110) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:652) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:733) > at > org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:123) > at > org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86) > at > org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:250) > at > org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142) > at > org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81) > at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131) > at > org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142) > at > org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81) > at > org.apache.felix.http.base.internal.dispatch.Dispatcher$1.doFilter(Dispatcher.java:146) > at > org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$2.doFilter(WhiteboardManager.java:1002) > at > org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:97) > at > org.apache.felix.http.base.internal.handler.PreprocessorHandler.handle(PreprocessorHandler.java:137) > at > org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$2.doFilter(WhiteboardManager.java:1008) > at > org.apache.felix.http.base.internal.whiteboard.WhiteboardManager.invokePreprocessors(WhiteboardManager.java:1012) > at > org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:91) > at > org.apache.felix.http.base.internal.dispatch.DispatcherServlet.service(DispatcherServlet.java:49) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:733) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:550) > at > org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) > at > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624) > at > org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) > at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1435) > at > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) > at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501) > at > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594) > at > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) > at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1350) > at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) > at > org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:191) > at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) > at org.eclipse.jetty.server.Server.handle(Server.java:516) > at > org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:388) > at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:633) > at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380) > at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277) > at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) > at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105) > at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104) > at > org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338) > at >
Re: [VOTE] Release Apache Sling JUnit Core 1.1.4
Just a bit more information: I captured the stacktrace of the failure described in my last reply as: [ERROR] Exception while processing request to /system/sling/junit/org.apache.sling.launchpad.webapp.integrationtest.resourceresolver.ResourceResolverGeneralTest/testResolveRemovedResourceAlias.junit_result javax.servlet.ServletException: java.lang.IllegalStateException: A test method name is only supported for a single test class at org.apache.sling.junit.impl.servlet.ServletProcessor.doPost(ServletProcessor.java:145) at org.apache.sling.junit.impl.servlet.JUnitServlet.doPost(JUnitServlet.java:110) at javax.servlet.http.HttpServlet.service(HttpServlet.java:652) at javax.servlet.http.HttpServlet.service(HttpServlet.java:733) at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:123) at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86) at org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:250) at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142) at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81) at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131) at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:142) at org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81) at org.apache.felix.http.base.internal.dispatch.Dispatcher$1.doFilter(Dispatcher.java:146) at org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$2.doFilter(WhiteboardManager.java:1002) at org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:97) at org.apache.felix.http.base.internal.handler.PreprocessorHandler.handle(PreprocessorHandler.java:137) at org.apache.felix.http.base.internal.whiteboard.WhiteboardManager$2.doFilter(WhiteboardManager.java:1008) at org.apache.felix.http.base.internal.whiteboard.WhiteboardManager.invokePreprocessors(WhiteboardManager.java:1012) at org.apache.felix.http.base.internal.dispatch.Dispatcher.dispatch(Dispatcher.java:91) at org.apache.felix.http.base.internal.dispatch.DispatcherServlet.service(DispatcherServlet.java:49) at javax.servlet.http.HttpServlet.service(HttpServlet.java:733) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:550) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1435) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1350) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:191) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at org.eclipse.jetty.server.Server.handle(Server.java:516) at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:388) at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:633) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277) at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105) at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131) at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:383) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:882) at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1036) at
Re: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.2.2
+1 On Mon, Jun 21, 2021 at 9:06 AM Eric Norman wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12349570 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2481/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2481 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
Re: [VOTE] Release Apache Sling JUnit Core 1.1.4
Hi, -1 for me. I don't know much about this bundle, but I have some concerns with this release (and the 1.1.2 version as well) since they don't appear to work when integrated into the org.apache.sling.launchpad.testing project. My testing indicates that org.apache.sling.junit.core version 1.0.30 is the last version that works with the org.apache.sling.launchpad.testing project. Specifically, I updated the src/main/features/model.json in org.apache.sling.launchpad.testing to use this version. When running the build to verify, the ResourceResolverGeneralTest test runs for a long time before reporting either a "java.io.IOException: Got status code 500" or "java.net.SocketTimeoutException: Read timed out" for each test. And there appear to be other failures as well. I did a quick search of the sling projects on github and I don't see any of the sling projects that are using any 1.1.x version of org.apache.sling.junit.core. If you are able to share, may I ask what you have been using to smoke test that the functionality is working? Regards, Eric On Mon, Jun 21, 2021 at 5:45 AM Julian Sedding wrote: > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12350085 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2480/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2480 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Julian >
[GitHub] [sling-org-apache-sling-distribution-core] Buuhuu closed pull request #6: SLING-7364: optionally omit package metadata header
Buuhuu closed pull request #6: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10536) Remove obsolete support for Java less than 8
[ https://issues.apache.org/jira/browse/SLING-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368408#comment-17368408 ] Oliver Lietz commented on SLING-10536: -- Thanks, [~kwin]! I did the test build with a wrong project 臘. > Remove obsolete support for Java less than 8 > > > Key: SLING-10536 > URL: https://issues.apache.org/jira/browse/SLING-10536 > Project: Sling > Issue Type: Task >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Parent 44 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10496) Prevent warning about non-existing profile "ci"
[
https://issues.apache.org/jira/browse/SLING-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10496:
Fix Version/s: (was: Parent 44)
Starter 12
> Prevent warning about non-existing profile "ci"
> ---
>
> Key: SLING-10496
> URL: https://issues.apache.org/jira/browse/SLING-10496
> Project: Sling
> Issue Type: Improvement
> Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>
> Most builds with Jenkins emit the following warning
> {code}
> [WARNING] The requested profile "ci" could not be activated because it does
> not exist.
> {code}
> This is especially important for the Maven 4
> (https://issues.apache.org/jira/browse/MNG-7051) as that will break by
> default if the profile is not found.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10496) Prevent warning about non-existing profile "ci"
[
https://issues.apache.org/jira/browse/SLING-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-10496.
-
Resolution: Fixed
> Prevent warning about non-existing profile "ci"
> ---
>
> Key: SLING-10496
> URL: https://issues.apache.org/jira/browse/SLING-10496
> Project: Sling
> Issue Type: Improvement
> Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>
> Most builds with Jenkins emit the following warning
> {code}
> [WARNING] The requested profile "ci" could not be activated because it does
> not exist.
> {code}
> This is especially important for the Maven 4
> (https://issues.apache.org/jira/browse/MNG-7051) as that will break by
> default if the profile is not found.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10496) Prevent warning about non-existing profile "ci"
[
https://issues.apache.org/jira/browse/SLING-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368314#comment-17368314
]
Konrad Windszus commented on SLING-10496:
-
I implemented option 2 in
https://github.com/apache/sling-tooling-jenkins/commit/8b339ce775e95e6c96781223b38f55b18145bbbc
and
https://github.com/apache/sling-org-apache-sling-starter/commit/3325782d542d9ba5e462160df1f9e94937266045.
> Prevent warning about non-existing profile "ci"
> ---
>
> Key: SLING-10496
> URL: https://issues.apache.org/jira/browse/SLING-10496
> Project: Sling
> Issue Type: Improvement
> Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 44
>
>
> Most builds with Jenkins emit the following warning
> {code}
> [WARNING] The requested profile "ci" could not be activated because it does
> not exist.
> {code}
> This is especially important for the Maven 4
> (https://issues.apache.org/jira/browse/MNG-7051) as that will break by
> default if the profile is not found.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368290#comment-17368290
]
Konrad Windszus edited comment on SLING-10506 at 6/23/21, 3:42 PM:
---
IMHO new quality profiles for Sonarcloud.io need to be created by
Administrators (i.e. through INFRA). However I see this has been done for other
projects e.g.
https://sonarcloud.io/organizations/apache/quality_profiles/show?language=java=incubator-daffodil.
Once we have a custom profile we need to somehow connect this for all Sling
projects, which is not that easy, as IMHO there is no API access provided for
that, am I right [~rombert]?
Overriding the profile per execution is no longer supported:
https://jira.sonarsource.com/browse/SONAR-5370
was (Author: kwin):
IMHO new quality profiles for Sonarcloud.io need to be created by
Administrators (i.e. through INFRA). However I see this has been done for other
projects e.g.
https://sonarcloud.io/organizations/apache/quality_profiles/show?language=java=incubator-daffodil.
Once we have a custom profile we need to somehow connect this for all Sling
projects, which is not that easy, as IMHO there is no API access provided for
that, am I right [~rombert]?
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368290#comment-17368290
]
Konrad Windszus commented on SLING-10506:
-
IMHO new quality profiles need to be created by Administrators (i.e. through
INFRA). However I see this has been done for other projects e.g.
https://sonarcloud.io/organizations/apache/quality_profiles/show?language=java=incubator-daffodil.
Once we have a custom profile we need to somehow connect this for all Sling
projects, which is not that easy, as IMHO there is no API access provided for
that, am I right [~rombert]?
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368290#comment-17368290
]
Konrad Windszus edited comment on SLING-10506 at 6/23/21, 3:40 PM:
---
IMHO new quality profiles for Sonarcloud.io need to be created by
Administrators (i.e. through INFRA). However I see this has been done for other
projects e.g.
https://sonarcloud.io/organizations/apache/quality_profiles/show?language=java=incubator-daffodil.
Once we have a custom profile we need to somehow connect this for all Sling
projects, which is not that easy, as IMHO there is no API access provided for
that, am I right [~rombert]?
was (Author: kwin):
IMHO new quality profiles need to be created by Administrators (i.e. through
INFRA). However I see this has been done for other projects e.g.
https://sonarcloud.io/organizations/apache/quality_profiles/show?language=java=incubator-daffodil.
Once we have a custom profile we need to somehow connect this for all Sling
projects, which is not that easy, as IMHO there is no API access provided for
that, am I right [~rombert]?
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-10536) Remove obsolete support for Java less than 8
[
https://issues.apache.org/jira/browse/SLING-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368276#comment-17368276
]
Konrad Windszus edited comment on SLING-10536 at 6/23/21, 3:26 PM:
---
The commit
https://github.com/apache/sling-parent/commit/c8013c278c88ba4359cd05c61f8cbebb3d238b27#diff-cdd1d5342082436be6496d81b3130b151156bf1e884e71b528827a58ffa3c200
breaks compilation with Java 8 as the profile activation syntax is wrong. It
must be {{1.8}} instead of {{8}} for JDK8
(http://maven.apache.org/enforcer/enforcer-rules/versionRanges.html).
Fixed in
https://github.com/apache/sling-parent/commit/c0697b6146f0868171293321d367534d492834e2.
was (Author: kwin):
The commit
https://github.com/apache/sling-parent/commit/c8013c278c88ba4359cd05c61f8cbebb3d238b27#diff-cdd1d5342082436be6496d81b3130b151156bf1e884e71b528827a58ffa3c200
breaks compilation with Java 8 as the profile activation syntax is wrong. It
must be {{1.8}} instead of {{8}} for JDK8
(http://maven.apache.org/enforcer/enforcer-rules/versionRanges.html).
> Remove obsolete support for Java less than 8
>
>
> Key: SLING-10536
> URL: https://issues.apache.org/jira/browse/SLING-10536
> Project: Sling
> Issue Type: Task
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Parent 44
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10536) Remove obsolete support for Java less than 8
[ https://issues.apache.org/jira/browse/SLING-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10536. - Resolution: Fixed > Remove obsolete support for Java less than 8 > > > Key: SLING-10536 > URL: https://issues.apache.org/jira/browse/SLING-10536 > Project: Sling > Issue Type: Task >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Parent 44 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10536) Remove obsolete support for Java less than 8
[
https://issues.apache.org/jira/browse/SLING-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368276#comment-17368276
]
Konrad Windszus commented on SLING-10536:
-
The commit
https://github.com/apache/sling-parent/commit/c8013c278c88ba4359cd05c61f8cbebb3d238b27#diff-cdd1d5342082436be6496d81b3130b151156bf1e884e71b528827a58ffa3c200
breaks compilation with Java 8 as the profile activation syntax is wrong. It
must be {{1.8}} instead of {{8}} for JDK8
(http://maven.apache.org/enforcer/enforcer-rules/versionRanges.html).
> Remove obsolete support for Java less than 8
>
>
> Key: SLING-10536
> URL: https://issues.apache.org/jira/browse/SLING-10536
> Project: Sling
> Issue Type: Task
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Parent 44
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (SLING-10536) Remove obsolete support for Java less than 8
[ https://issues.apache.org/jira/browse/SLING-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reopened SLING-10536: - > Remove obsolete support for Java less than 8 > > > Key: SLING-10536 > URL: https://issues.apache.org/jira/browse/SLING-10536 > Project: Sling > Issue Type: Task >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Parent 44 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10537) @Service annotation for Jupiter should explicitly allow for optional and mandatory service injection
[
https://issues.apache.org/jira/browse/SLING-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding updated SLING-10537:
---
Fix Version/s: JUnit Core 1.1.6
> @Service annotation for Jupiter should explicitly allow for optional and
> mandatory service injection
>
>
> Key: SLING-10537
> URL: https://issues.apache.org/jira/browse/SLING-10537
> Project: Sling
> Issue Type: Improvement
> Components: JUnit Core, Testing
>Affects Versions: JUnit Core 1.1.4
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: JUnit Core 1.1.6
>
>
> The @Service annotation for Jupiter is currently mandatory for unary service
> injection and optional for multiple service injection. It should be possible
> to specify that a unary service is optional, leading to {{null}} being
> injected. It should also be possible to specify mandatory multiple service
> injection, leading to "at least one" semantics. This should fail parameter
> injection if no suitable service is available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10537) @Service annotation for Jupiter should explicitly allow for optional and mandatory service injection
[
https://issues.apache.org/jira/browse/SLING-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding resolved SLING-10537.
Resolution: Fixed
Implemented in [commit
9200524|https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-junit-core.git;a=commit;h=9200524516e3c66289a9fac8ff5f4a5ec5b09afb].
> @Service annotation for Jupiter should explicitly allow for optional and
> mandatory service injection
>
>
> Key: SLING-10537
> URL: https://issues.apache.org/jira/browse/SLING-10537
> Project: Sling
> Issue Type: Improvement
> Components: JUnit Core, Testing
>Affects Versions: JUnit Core 1.1.4
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
>
> The @Service annotation for Jupiter is currently mandatory for unary service
> injection and optional for multiple service injection. It should be possible
> to specify that a unary service is optional, leading to {{null}} being
> injected. It should also be possible to specify mandatory multiple service
> injection, leading to "at least one" semantics. This should fail parameter
> injection if no suitable service is available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10537) @Service annotation for Jupiter should explicitly allow for optional and mandatory service injection
Julian Sedding created SLING-10537:
--
Summary: @Service annotation for Jupiter should explicitly allow
for optional and mandatory service injection
Key: SLING-10537
URL: https://issues.apache.org/jira/browse/SLING-10537
Project: Sling
Issue Type: Improvement
Components: JUnit Core, Testing
Affects Versions: JUnit Core 1.1.4
Reporter: Julian Sedding
Assignee: Julian Sedding
The @Service annotation for Jupiter is currently mandatory for unary service
injection and optional for multiple service injection. It should be possible to
specify that a unary service is optional, leading to {{null}} being injected.
It should also be possible to specify mandatory multiple service injection,
leading to "at least one" semantics. This should fail parameter injection if no
suitable service is available.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10527) Log imported instead of importing package
[
https://issues.apache.org/jira/browse/SLING-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368085#comment-17368085
]
Christian Schneider commented on SLING-10527:
-
It makes a lot of sense to log when the package was imported. It is as well
important though to also log when we start to import a package.
>From that information I was able to see which package was stuck for a customer
>and which offset in the topic the package was at.
What do you think about also logging the "Importing.. " message at info level?
> Log imported instead of importing package
> -
>
> Key: SLING-10527
> URL: https://issues.apache.org/jira/browse/SLING-10527
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> Currently the package import is logged at INFO level before processing the
> package
> {code}
> log.info("Importing distribution package {} at offset={}", pkgMsg, offset);
> {code}
> This makes it difficult to figure out if there was an error with the import
> because one has to seek further logs to see if the package import failed or
> (worst) no log if the package was imported successfully. We should ensure
> that a single log statement is logged upon import, either the import
> succeeded or failed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10528) Reject large packages
[ https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368083#comment-17368083 ] Christian Schneider commented on SLING-10528: - Looks great .. thx. > Reject large packages > - > > Key: SLING-10528 > URL: https://issues.apache.org/jira/browse/SLING-10528 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Journal distribution serialise content packages in binary less mode only. > When doing "deep" distribution, the package can still become so large that > the importing side can't ingest it. When this happens, Apache Oak does a > session save that never seem to return and can easily take 8 hours to > terminate. > I suggest to detect those large packages, based on the package size and > simply reject packages above a configurable limit size. The limit should > take in consideration the mean import throughput for a single Oak session on > cloud segment tar and should keep the save operation below, say 15 minutes. > With this approach, we can ensure that Oak always return when importing a > package and we can fail fast for larger packages. Journal distribution will > also handle the errors nicely and allow to remove the blocking item from the > usual set of tools. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #126 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/126/ for details. No further emails will be sent until the status of the build is changed.
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #25: SLING-10502 - lazy loading helpers
sonarcloud[bot] commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-866753756 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [98.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #25: SLING-10502 - lazy loading helpers
sonarcloud[bot] removed a comment on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-866701204 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [98.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-8669) Maven warnings due to missing parent projects or POMs
[
https://issues.apache.org/jira/browse/SLING-8669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-8669.
-
Fix Version/s: Testing PaxExam 4.0.0
Resolution: Not A Bug
Most probably fixed by JAXB/REST Assured update in SLING-9687 or a Parent
update.
> Maven warnings due to missing parent projects or POMs
> -
>
> Key: SLING-8669
> URL: https://issues.apache.org/jira/browse/SLING-8669
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: Testing PaxExam 3.1.0
>Reporter: Robert Munteanu
>Assignee: Oliver Lietz
>Priority: Minor
> Fix For: Testing PaxExam 4.0.0
>
>
> When building Clam 1.1.0 I get some Maven warnings. Probably harmless, but
> can't be 100% sure.
> {noformat}[INFO] ---< org.apache.sling:org.apache.sling.clam
> >---
> [INFO] Building Apache Sling Clam 1.1.0
> [1/2]
> [INFO] [ jar
> ]-
> [WARNING] The POM for com.sun.xml.bind:jaxb-osgi:jar:2.2.10 is invalid,
> transitive dependencies (if any) will not be available, enable debug logging
> for more details
> [INFO]
> [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @
> org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @
> org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-property-values) @
> org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java-version) @
> org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (ban-maven-scr-plugin) @
> org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (ban-felix-scr-annotations)
> @ org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (ban-maven-bundle-plugin) @
> org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (ban-maven-sling-plugin) @
> org.apache.sling.clam ---
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) @ org.apache.sling.clam ---
> [WARNING] Failed to build parent project for
> com.sun.xml.bind.mvn:jaxb-bundles:pom:2.2.10
> [WARNING] Failed to build parent project for
> com.sun.xml.bind.mvn:jaxb-osgi:pom:2.2.10
> [WARNING] Failed to build parent project for
> com.sun.xml.bind:jaxb-osgi:jar:2.2.10
> [WARNING] Invalid POM for com.sun.xml.bind:jaxb-osgi:jar:2.2.10, transitive
> dependencies (if any) will not be available, enable debug logging for more
> details
> [INFO]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10528) Reject large packages
[ https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-10528. Resolution: Fixed Squashed and merged PR #75 > Reject large packages > - > > Key: SLING-10528 > URL: https://issues.apache.org/jira/browse/SLING-10528 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Journal distribution serialise content packages in binary less mode only. > When doing "deep" distribution, the package can still become so large that > the importing side can't ingest it. When this happens, Apache Oak does a > session save that never seem to return and can easily take 8 hours to > terminate. > I suggest to detect those large packages, based on the package size and > simply reject packages above a configurable limit size. The limit should > take in consideration the mean import throughput for a single Oak session on > cloud segment tar and should keep the save operation below, say 15 minutes. > With this approach, we can ensure that Oak always return when importing a > package and we can fail fast for larger packages. Journal distribution will > also handle the errors nicely and allow to remove the blocking item from the > usual set of tools. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #25: SLING-10502 - lazy loading helpers
sonarcloud[bot] removed a comment on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-866683490 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [98.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #25: SLING-10502 - lazy loading helpers
sonarcloud[bot] commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-866701204 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [98.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-9996) Update Thymeleaf to 3.0.12
[ https://issues.apache.org/jira/browse/SLING-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9996. - Resolution: Done > Update Thymeleaf to 3.0.12 > -- > > Key: SLING-9996 > URL: https://issues.apache.org/jira/browse/SLING-9996 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Scripting Thymeleaf 2.1.0 > > > https://www.thymeleaf.org/releasenotes.html#thymeleaf-3.0.12 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (SLING-10112) Distribution Queue can not be reliably cleared due to race condition processing delete messages
[ https://issues.apache.org/jira/browse/SLING-10112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reopened SLING-10112: > Distribution Queue can not be reliably cleared due to race condition > processing delete messages > --- > > Key: SLING-10112 > URL: https://issues.apache.org/jira/browse/SLING-10112 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Replication queue can not be reliable cleared due to race condition with > processing the 'delete' messages. > If the first message is stuck during processing, the 'clear queue' signal > might never have effect on the subscriber. > A restart of the process does not help as the same situation might occur. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10112) Distribution Queue can not be reliably cleared due to race condition processing delete messages
[ https://issues.apache.org/jira/browse/SLING-10112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368001#comment-17368001 ] Timothee Maret commented on SLING-10112: This approach has a flaw with cloud deployments that treat Sling instances as a cattle. In those deployments, each instances starts with a new slingId. Commands are sent to a specific subscriber agent identified by subSlingId and subAgentName. As a result, the command is not being picked up when the instance is replaced. We should revert this change given that SLING-10528 avoids the condition that required this change. > Distribution Queue can not be reliably cleared due to race condition > processing delete messages > --- > > Key: SLING-10112 > URL: https://issues.apache.org/jira/browse/SLING-10112 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Replication queue can not be reliable cleared due to race condition with > processing the 'delete' messages. > If the first message is stuck during processing, the 'clear queue' signal > might never have effect on the subscriber. > A restart of the process does not help as the same situation might occur. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10528) Reject large packages
[ https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368000#comment-17368000 ] Timothee Maret commented on SLING-10528: The mechanism of rejecting packages by size supersedes SLING-10112. > Reject large packages > - > > Key: SLING-10528 > URL: https://issues.apache.org/jira/browse/SLING-10528 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Journal distribution serialise content packages in binary less mode only. > When doing "deep" distribution, the package can still become so large that > the importing side can't ingest it. When this happens, Apache Oak does a > session save that never seem to return and can easily take 8 hours to > terminate. > I suggest to detect those large packages, based on the package size and > simply reject packages above a configurable limit size. The limit should > take in consideration the mean import throughput for a single Oak session on > cloud segment tar and should keep the save operation below, say 15 minutes. > With this approach, we can ensure that Oak always return when importing a > package and we can fail fast for larger packages. Journal distribution will > also handle the errors nicely and allow to remove the blocking item from the > usual set of tools. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10528) Reject large packages
[ https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367994#comment-17367994 ] Timothee Maret commented on SLING-10528: Updated the PR with package length assertions on the distribution publisher side. > Reject large packages > - > > Key: SLING-10528 > URL: https://issues.apache.org/jira/browse/SLING-10528 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Journal distribution serialise content packages in binary less mode only. > When doing "deep" distribution, the package can still become so large that > the importing side can't ingest it. When this happens, Apache Oak does a > session save that never seem to return and can easily take 8 hours to > terminate. > I suggest to detect those large packages, based on the package size and > simply reject packages above a configurable limit size. The limit should > take in consideration the mean import throughput for a single Oak session on > cloud segment tar and should keep the save operation below, say 15 minutes. > With this approach, we can ensure that Oak always return when importing a > package and we can fail fast for larger packages. Journal distribution will > also handle the errors nicely and allow to remove the blocking item from the > usual set of tools. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10528) Reject large packages
[ https://issues.apache.org/jira/browse/SLING-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367993#comment-17367993 ] Timothee Maret commented on SLING-10528: [~cschneider] good point. I thought of handling the case in the subscriber as it would also catch packages already produced. Given that the journal removes messages after 7 days, we can realistically ignore that case. > Reject large packages > - > > Key: SLING-10528 > URL: https://issues.apache.org/jira/browse/SLING-10528 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Journal distribution serialise content packages in binary less mode only. > When doing "deep" distribution, the package can still become so large that > the importing side can't ingest it. When this happens, Apache Oak does a > session save that never seem to return and can easily take 8 hours to > terminate. > I suggest to detect those large packages, based on the package size and > simply reject packages above a configurable limit size. The limit should > take in consideration the mean import throughput for a single Oak session on > cloud segment tar and should keep the save operation below, say 15 minutes. > With this approach, we can ensure that Oak always return when importing a > package and we can fail fast for larger packages. Journal distribution will > also handle the errors nicely and allow to remove the blocking item from the > usual set of tools. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #25: SLING-10502 - lazy loading helpers
sonarcloud[bot] removed a comment on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-865856572 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [97.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #25: SLING-10502 - lazy loading helpers
sonarcloud[bot] commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-866683490 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=25=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [98.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=25=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #25: SLING-10502 - lazy loading helpers
bdelacretaz commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/25#issuecomment-866680040 Thank you for the detailed review, all good suggestions! Of course, HashMap not being synchronized it doesn't make sense to make the `LazyLoadingMap` thread safe, I have removed all synchronization in that class. I think I have implemented all other suggestions, please cross-check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10535) sling.java.version used incorrectly for o.c.m.signature artifactId
[
https://issues.apache.org/jira/browse/SLING-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-10535.
--
Resolution: Done
[0dd9b1d|https://github.com/apache/sling-parent/commit/0dd9b1db22cd63e4a1c830381ac876a08c353c74]
> sling.java.version used incorrectly for o.c.m.signature artifactId
> --
>
> Key: SLING-10535
> URL: https://issues.apache.org/jira/browse/SLING-10535
> Project: Sling
> Issue Type: Bug
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Parent 44
>
>
> The value of the {{sling.java.version}} property should comply with the
> following pattern: {{^(8|9|1[0-9])$}}.
> {{java18}} is the only valid value for {{artifactId}}:
> {noformat}
>
> org.codehaus.mojo
> animal-sniffer-maven-plugin
> 1.20
>
>
> org.codehaus.mojo.signature
>
> java1${sling.java.version}
> 1.0
>
>
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10536) Remove obsolete support for Java less than 8
[ https://issues.apache.org/jira/browse/SLING-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-10536. -- Resolution: Done [c8013c2|https://github.com/apache/sling-parent/commit/c8013c278c88ba4359cd05c61f8cbebb3d238b27] > Remove obsolete support for Java less than 8 > > > Key: SLING-10536 > URL: https://issues.apache.org/jira/browse/SLING-10536 > Project: Sling > Issue Type: Task >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Parent 44 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10536) Remove obsolete support for Java less than 8
Oliver Lietz created SLING-10536: Summary: Remove obsolete support for Java less than 8 Key: SLING-10536 URL: https://issues.apache.org/jira/browse/SLING-10536 Project: Sling Issue Type: Task Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Parent 44 -- This message was sent by Atlassian Jira (v8.3.4#803005)
