[RESULT] [VOTE] Release Apache Sling Content Distribution Journal Messages 0.3.0 and Content Distribution Core 0.4.6

[Timothee Maret]

Hi,

The vote has passed with the following result :

+1 (binding): Carsten, Robert, Timothee, David

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #95: SLING-10579: fix package types in emitter events

[GitBox]

sonarcloud[bot] commented on pull request #95:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/95#issuecomment-872416363


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&metric=new_coverage&view=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=95&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls opened a new pull request #95: SLING-10579: fix package types in emitter events

[GitBox]

karlpauls opened a new pull request #95:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/95


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10579) Review PackageEvents emitter for content package converter

[Karl Pauls (Jira)]

Karl Pauls created SLING-10579:
--

 Summary: Review PackageEvents emitter for content package converter
 Key: SLING-10579
 URL: https://issues.apache.org/jira/browse/SLING-10579
 Project: Sling
  Issue Type: Improvement
  Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.4
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Content-Package to Feature Model Converter 1.1.6


The converter emitts events for the converted packages - however, it doesn't 
take into account that the package type might change after the packages got 
converted. It should use the real package types when they are converted. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10578) Review initial content creation for content package output of converter

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-10578.

Resolution: Fixed

> Review initial content creation for content package output of converter
> ---
>
> Key: SLING-10578
> URL: https://issues.apache.org/jira/browse/SLING-10578
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.4
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> The converter uses a slightly different path when processing content packages 
> created for sling initial content. That can be problematic as they need to be 
> in the recollecting phase as well and messing with the main package assembler 
> seems a little unclean.
> We should see if we could handle it in the main path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #94: SLING-10578: Review initial content creation for content package outp…

[GitBox]

karlpauls merged pull request #94:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/94


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Engine 2.7.8

[Eric Norman]

+1

On Wed, Jun 30, 2021 at 4:26 AM Karl Pauls  wrote:

> We solved 1 issue in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12350349
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2488
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2488 /tmp/sling-staging
>
> Please vote to approve these releases:
>
>   [ ] +1 Approve the releases
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] cziegeler commented on pull request #16: Add new enforce-on and since attributes for osgi configurations

[GitBox]

cziegeler commented on pull request #16:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/16#issuecomment-872374181


   @angulito Thanks for your patch. It looks very good. I think there is a 
minor issue: not all configuration validation errors/warns are generated inside 
ConfigurationValidator. Some of them are generated from the FeatureValidator - 
however FeatureValidator uses ConfigurationValidator.setResult. I think if you 
move the postfix logic to that method, you will catch all places and ensure 
that all warnings and errors have the postfix. Similar with 
PropertyValidator.setResult which might be called from ConfigurationValidator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10577) Include enforce-on and since info for osgi configuration validations

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-10577:
-
Fix Version/s: Feature Model API Regions Extension 1.3.6

> Include enforce-on and since info for osgi configuration validations
> 
>
> Key: SLING-10577
> URL: https://issues.apache.org/jira/browse/SLING-10577
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.4
>Reporter: Natalia Angulo Herrera
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.3.6
>
>
> We would like to add a couple of new attributes to our osgi configurations:
>  * enforce-on: string pointing where the osgi configuration validation will 
> be enforced
>  * since: string pointing where the osgi configuration validation has been 
> added
> When adding both attributes, all the configuration validation reports will 
> contain the postfix "Since : . Enforced on : "



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10577) Include enforce-on and since info for osgi configuration validations

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-10577:


Assignee: Carsten Ziegeler

> Include enforce-on and since info for osgi configuration validations
> 
>
> Key: SLING-10577
> URL: https://issues.apache.org/jira/browse/SLING-10577
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.4
>Reporter: Natalia Angulo Herrera
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.3.6
>
>
> We would like to add a couple of new attributes to our osgi configurations:
>  * enforce-on: string pointing where the osgi configuration validation will 
> be enforced
>  * since: string pointing where the osgi configuration validation has been 
> added
> When adding both attributes, all the configuration validation reports will 
> contain the postfix "Since : . Enforced on : "



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10577) Include enforce-on and since info for osgi configuration validations

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-10577:
-
Component/s: (was: Validation)
 (was: API)
 Feature Model

> Include enforce-on and since info for osgi configuration validations
> 
>
> Key: SLING-10577
> URL: https://issues.apache.org/jira/browse/SLING-10577
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.3.4
>Reporter: Natalia Angulo Herrera
>Priority: Major
>
> We would like to add a couple of new attributes to our osgi configurations:
>  * enforce-on: string pointing where the osgi configuration validation will 
> be enforced
>  * since: string pointing where the osgi configuration validation has been 
> added
> When adding both attributes, all the configuration validation reports will 
> contain the postfix "Since : . Enforced on : "



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.4

[Cris Rockwell]

Ok. In that case, I think I can prepare release 0.2.6 for a vote. Unless, 
there’s something else?


> On Jul 1, 2021, at 11:10 AM, Robert Munteanu  wrote:
> 
> Hi Cris,
> 
> If parallel versions don't cause any problems I would suggest that we
> keep metrics-core 4 as a bundle, allowing deployers to update to new
> versions if needed.
> 
> Thanks,
> Robert
> 
> On Thu, 2021-07-01 at 10:27 -0400, Cris Rockwell wrote:
>> Hi Robert 
>> 
>> OpenSAML has Metrics 4.1.18 as a dependency [1]. 
>> Sling uses metrics-core 3.2.6 which was released in 2017. 
>> Since then, only v4 has active development according to the releases
>> in Central [3].
>> 
>> So I think Sling should probably update to the newer version if
>> possible. 
>> Until then the SAML bundle could either embed metrics-core v4.1.18+
>> or it could require parallel versions. 
>> Which is better in your opinion?
>> 
>> Cris
>> 
>> [1]
>> https://git.shibboleth.net/view/?p=java-parent-project.git;a=blob;f=pom.xml;h=d87758e21f1cf63222959a9ca7631585128f8573;hb=HEAD
>> [2]
>> https://github.com/apache/sling-org-apache-sling-starter/blob/96b8df17cd09f7b72ba6794f25d75a524f7e1215/src/main/features/base.json
>> [3]
>> https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-core
>> 
>> 
>>> On Jul 1, 2021, at 9:05 AM, Robert Munteanu 
>>> wrote:
>>> 
>>> On Tue, 2021-06-29 at 18:48 -0400, Cris Rockwell wrote:
 Hi Robert
 
> Why are there version ranges used in the pom?
 I was using Maven bracket notation for version ranges that I had
 actually tested. But I see it’s not needed, and removed the
 bracket
 range on the versions. Now it builds without downloading any
 SNAPSHOTS.
 
 
> checker-qual-2.11.1.jar
> error_prone_annotations-2.3.4.jar 
> failureaccess-1.0.1.jar
 
 These are dependencies of Google Guava, which is also an embedded
 dependency. If I didn't embed Guava, the deps above wouldn’t be
 needed.
 Sling comes with Guava v15. But OpenSAML libraries currently
 require
 30.1.1-jre. Having a recent version of Guava installed as a
 bundle
 could help a lot. But having both versions as bundles doesn’t
 seem to
 work. I am getting the error below...
>>> 
>>> As Julian mentioned, embedding Guava is the only safe solution
>>> right
>>> now. And thank you for looking into the additional dependencies and
>>> making sure they can be used as OSGi bundles, this will make
>>> deployments simpler.
>>> 
 
 Import-Package: com.codahale.metrics; version="[4.1, 5)",
 com.google.common.base; version="[30.1, 31)",
 com.google.common.collect; version="[30.1, 31)",
 com.google.common.escape; version="[30.1, 31)",
 com.google.common.io  
 >;
 version="[30.1, 31)", com.google.common.net 
 >; 
 version="[30.1, 31)",
 
> metrics-core-4.1.9.jar
 
 Upgrading metrics-core past v3 causes a lot of problems with many
 Sling bundles. I counted ~40 bundles that went from Active to
 Installed state. But when installed with parallel versions  (v3
 and
 v4) everything seems fine.
>>> 
 
>>> Is the metrics bundle something you're consuming or required by a
>>> dependency? Ideally we would be working with whatever is supported
>>> by
>>> the current Sling Starter / commons.metrics bundle.
>>> 
>>> Thanks,
>>> Robert

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #94: SLING-10578: Review initial content creation for content package outp…

[GitBox]

sonarcloud[bot] removed a comment on pull request #94:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/94#issuecomment-872328396


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
 [73.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #94: SLING-10578: Review initial content creation for content package outp…

[GitBox]

sonarcloud[bot] commented on pull request #94:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/94#issuecomment-872342203


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
 [73.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #94: SLING-10578: Review initial content creation for content package outp…

[GitBox]

sonarcloud[bot] commented on pull request #94:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/94#issuecomment-872328396


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
 [73.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #94: SLING-10578: Review initial content creation for content package outp…

[GitBox]

sonarcloud[bot] removed a comment on pull request #94:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/94#issuecomment-872278286


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
 [63.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.4

[Robert Munteanu]

Hi Cris,

If parallel versions don't cause any problems I would suggest that we
keep metrics-core 4 as a bundle, allowing deployers to update to new
versions if needed.

Thanks,
Robert

On Thu, 2021-07-01 at 10:27 -0400, Cris Rockwell wrote:
> Hi Robert 
> 
> OpenSAML has Metrics 4.1.18 as a dependency [1]. 
> Sling uses metrics-core 3.2.6 which was released in 2017. 
> Since then, only v4 has active development according to the releases
> in Central [3].
> 
> So I think Sling should probably update to the newer version if
> possible. 
> Until then the SAML bundle could either embed metrics-core v4.1.18+
> or it could require parallel versions. 
> Which is better in your opinion?
> 
> Cris
> 
> [1]
> https://git.shibboleth.net/view/?p=java-parent-project.git;a=blob;f=pom.xml;h=d87758e21f1cf63222959a9ca7631585128f8573;hb=HEAD
> [2]
> https://github.com/apache/sling-org-apache-sling-starter/blob/96b8df17cd09f7b72ba6794f25d75a524f7e1215/src/main/features/base.json
> [3]
> https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-core
> 
> 
> > On Jul 1, 2021, at 9:05 AM, Robert Munteanu 
> > wrote:
> > 
> > On Tue, 2021-06-29 at 18:48 -0400, Cris Rockwell wrote:
> > > Hi Robert
> > > 
> > > > Why are there version ranges used in the pom?
> > > I was using Maven bracket notation for version ranges that I had
> > > actually tested. But I see it’s not needed, and removed the
> > > bracket
> > > range on the versions. Now it builds without downloading any
> > > SNAPSHOTS.
> > > 
> > > 
> > > > checker-qual-2.11.1.jar
> > > > error_prone_annotations-2.3.4.jar 
> > > > failureaccess-1.0.1.jar
> > > 
> > > These are dependencies of Google Guava, which is also an embedded
> > > dependency. If I didn't embed Guava, the deps above wouldn’t be
> > > needed.
> > > Sling comes with Guava v15. But OpenSAML libraries currently
> > > require
> > > 30.1.1-jre. Having a recent version of Guava installed as a
> > > bundle
> > > could help a lot. But having both versions as bundles doesn’t
> > > seem to
> > > work. I am getting the error below...
> > 
> > As Julian mentioned, embedding Guava is the only safe solution
> > right
> > now. And thank you for looking into the additional dependencies and
> > making sure they can be used as OSGi bundles, this will make
> > deployments simpler.
> > 
> > > 
> > > Import-Package: com.codahale.metrics; version="[4.1, 5)",
> > > com.google.common.base; version="[30.1, 31)",
> > > com.google.common.collect; version="[30.1, 31)",
> > > com.google.common.escape; version="[30.1, 31)",
> > > com.google.common.io ;
> > > version="[30.1, 31)", com.google.common.net
> > > ; version="[30.1, 31)",
> > > 
> > > > metrics-core-4.1.9.jar
> > > 
> > > Upgrading metrics-core past v3 causes a lot of problems with many
> > > Sling bundles. I counted ~40 bundles that went from Active to
> > > Installed state. But when installed with parallel versions  (v3
> > > and
> > > v4) everything seems fine.
> > 
> > > 
> > Is the metrics bundle something you're consuming or required by a
> > dependency? Ideally we would be working with whatever is supported
> > by
> > the current Sling Starter / commons.metrics bundle.
> > 
> > Thanks,
> > Robert
> 

Re: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.4

[Cris Rockwell]

Hi Robert 

OpenSAML has Metrics 4.1.18 as a dependency [1]. 
Sling uses metrics-core 3.2.6 which was released in 2017. 
Since then, only v4 has active development according to the releases in Central 
[3].

So I think Sling should probably update to the newer version if possible. 
Until then the SAML bundle could either embed metrics-core v4.1.18+ or it could 
require parallel versions. 
Which is better in your opinion?

Cris

[1] 
https://git.shibboleth.net/view/?p=java-parent-project.git;a=blob;f=pom.xml;h=d87758e21f1cf63222959a9ca7631585128f8573;hb=HEAD
[2] 
https://github.com/apache/sling-org-apache-sling-starter/blob/96b8df17cd09f7b72ba6794f25d75a524f7e1215/src/main/features/base.json
[3] https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-core


> On Jul 1, 2021, at 9:05 AM, Robert Munteanu  wrote:
> 
> On Tue, 2021-06-29 at 18:48 -0400, Cris Rockwell wrote:
>> Hi Robert
>> 
>>> Why are there version ranges used in the pom?
>> I was using Maven bracket notation for version ranges that I had
>> actually tested. But I see it’s not needed, and removed the bracket
>> range on the versions. Now it builds without downloading any SNAPSHOTS.
>> 
>> 
>>> checker-qual-2.11.1.jar
>>> error_prone_annotations-2.3.4.jar 
>>> failureaccess-1.0.1.jar
>> 
>> These are dependencies of Google Guava, which is also an embedded
>> dependency. If I didn't embed Guava, the deps above wouldn’t be needed.
>> Sling comes with Guava v15. But OpenSAML libraries currently require
>> 30.1.1-jre. Having a recent version of Guava installed as a bundle
>> could help a lot. But having both versions as bundles doesn’t seem to
>> work. I am getting the error below...
> 
> As Julian mentioned, embedding Guava is the only safe solution right
> now. And thank you for looking into the additional dependencies and
> making sure they can be used as OSGi bundles, this will make
> deployments simpler.
> 
>> 
>> Import-Package: com.codahale.metrics; version="[4.1, 5)",
>> com.google.common.base; version="[30.1, 31)",
>> com.google.common.collect; version="[30.1, 31)",
>> com.google.common.escape; version="[30.1, 31)", com.google.common.io 
>> ;
>> version="[30.1, 31)", com.google.common.net ; 
>> version="[30.1, 31)",
>> 
>>> metrics-core-4.1.9.jar
>> 
>> Upgrading metrics-core past v3 causes a lot of problems with many
>> Sling bundles. I counted ~40 bundles that went from Active to
>> Installed state. But when installed with parallel versions  (v3 and
>> v4) everything seems fine.
> 
>> 
> Is the metrics bundle something you're consuming or required by a
> dependency? Ideally we would be working with whatever is supported by
> the current Sling Starter / commons.metrics bundle.
> 
> Thanks,
> Robert

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #94: SLING-10578: Review initial content creation for content package outp…

[GitBox]

sonarcloud[bot] commented on pull request #94:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/94#issuecomment-872278286


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
 [63.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=94&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls opened a new pull request #94: SLING-10578: Review initial content creation for content package outp…

[GitBox]

karlpauls opened a new pull request #94:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/94


   …ut of converter


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10578) Review initial content creation for content package output of converter

[Karl Pauls (Jira)]

Karl Pauls created SLING-10578:
--

 Summary: Review initial content creation for content package 
output of converter
 Key: SLING-10578
 URL: https://issues.apache.org/jira/browse/SLING-10578
 Project: Sling
  Issue Type: Improvement
  Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.4
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Content-Package to Feature Model Converter 1.1.6


The converter uses a slightly different path when processing content packages 
created for sling initial content. That can be problematic as they need to be 
in the recollecting phase as well and messing with the main package assembler 
seems a little unclean.

We should see if we could handle it in the main path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] angulito opened a new pull request #16: Add new enforce-on and since attributes for osgi configurations

[GitBox]

angulito opened a new pull request #16:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/16


   SLING-10577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10577) Include enforce-on and since info for osgi configuration validations

[Natalia Angulo Herrera (Jira)]

Natalia Angulo Herrera created SLING-10577:
--

 Summary: Include enforce-on and since info for osgi configuration 
validations
 Key: SLING-10577
 URL: https://issues.apache.org/jira/browse/SLING-10577
 Project: Sling
  Issue Type: Improvement
  Components: API, Validation
Affects Versions: Feature Model API Regions Extension 1.3.4
Reporter: Natalia Angulo Herrera


We would like to add a couple of new attributes to our osgi configurations:
 * enforce-on: string pointing where the osgi configuration validation will be 
enforced
 * since: string pointing where the osgi configuration validation has been added

When adding both attributes, all the configuration validation reports will 
contain the postfix "Since : . Enforced on : "



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling SAML2 Service Provider 0.2.4

[Robert Munteanu]

On Tue, 2021-06-29 at 18:48 -0400, Cris Rockwell wrote:
> Hi Robert
> 
> > Why are there version ranges used in the pom?
> I was using Maven bracket notation for version ranges that I had
> actually tested. But I see it’s not needed, and removed the bracket
> range on the versions. Now it builds without downloading any SNAPSHOTS.
> 
> 
> > checker-qual-2.11.1.jar
> > error_prone_annotations-2.3.4.jar 
> > failureaccess-1.0.1.jar
> 
> These are dependencies of Google Guava, which is also an embedded
> dependency. If I didn't embed Guava, the deps above wouldn’t be needed.
> Sling comes with Guava v15. But OpenSAML libraries currently require
> 30.1.1-jre. Having a recent version of Guava installed as a bundle
> could help a lot. But having both versions as bundles doesn’t seem to
> work. I am getting the error below...

As Julian mentioned, embedding Guava is the only safe solution right
now. And thank you for looking into the additional dependencies and
making sure they can be used as OSGi bundles, this will make
deployments simpler.

> 
> Import-Package: com.codahale.metrics; version="[4.1, 5)",
> com.google.common.base; version="[30.1, 31)",
> com.google.common.collect; version="[30.1, 31)",
> com.google.common.escape; version="[30.1, 31)", com.google.common.io;
> version="[30.1, 31)", com.google.common.net; version="[30.1, 31)",
> 
> > metrics-core-4.1.9.jar
> 
> Upgrading metrics-core past v3 causes a lot of problems with many
> Sling bundles. I counted ~40 bundles that went from Active to
> Installed state. But when installed with parallel versions  (v3 and
> v4) everything seems fine.

> 
Is the metrics bundle something you're consuming or required by a
dependency? Ideally we would be working with whatever is supported by
the current Sling Starter / commons.metrics bundle.

Thanks,
Robert

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.3.0 and Content Distribution Core 0.4.6

[davidb]

+1

David

On Thu, 1 Jul 2021 at 13:34, Timothee Maret  wrote:

> +1
>
> Le mar. 29 juin 2021 à 22:50, Timothee Maret  a écrit :
>
> > Hi,
> >
> > This vote covers 2 bundles
> >
> > 1. Content Distribution Journal Messages 0.3.0
> >
> > We solved 3 issue in this release:
> >
> > https://issues.apache.org/jira/projects/SLING/versions/12349663
> >
> > There are no outstanding issues.
> >
> > 2. Content Distribution Core 0.4.6
> >
> > We solved 13 issues in this release:
> >
> > https://issues.apache.org/jira/projects/SLING/versions/12349628
> >
> > There are still some outstanding issues:
> >
> > https://issues.apache.org/jira/projects/SLING/versions/12349660
> >
> >
> > Staging repository:
> >
> >
> > https://repository.apache.org/content/repositories/orgapachesling-2487/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2487 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
>

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.3.0 and Content Distribution Core 0.4.6

[Timothee Maret]

+1

Le mar. 29 juin 2021 à 22:50, Timothee Maret  a écrit :

> Hi,
>
> This vote covers 2 bundles
>
> 1. Content Distribution Journal Messages 0.3.0
>
> We solved 3 issue in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12349663
>
> There are no outstanding issues.
>
> 2. Content Distribution Core 0.4.6
>
> We solved 13 issues in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12349628
>
> There are still some outstanding issues:
>
> https://issues.apache.org/jira/projects/SLING/versions/12349660
>
>
> Staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapachesling-2487/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2487 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>

[jira] [Commented] (SLING-10575) Bundles without feature-origin result in empty bundle to feature mapping

[Carsten Ziegeler (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372588#comment-17372588
 ] 

Carsten Ziegeler commented on SLING-10575:
--

Fixed in apiregions with
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/commit/66a745b5e4385fb74d6999a9eabae4d1d32195e5
added a test

Adjusted the installer part in
https://github.com/apache/sling-org-apache-sling-installer-factory-feature/commit/026d66c67f9a5fa92103331d4656b03534c2e58a

> Bundles without feature-origin result in empty bundle to feature mapping
> 
>
> Key: SLING-10575
> URL: https://issues.apache.org/jira/browse/SLING-10575
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Installer Factory Feature Model 0.5.0
>Reporter: Dirk Rudolph
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.6.0, Feature Model API 
> Regions Extension 1.3.6
>
>
> When installing a feature archive of a feature similar to the following
> {code:json}
> {
>   "id":"com.exmaple:my-feature-pkg:slingosgifeature:tiera:12345-SNAPSHOT",
>   "bundles":[
> {
>   "id":"com.example:my-bundle:1.2.3-SNAPSHOT",
>   "start-order":"20"
> }
>   ],
>   "api-regions:JSON|false":[
> {
>   "name":"global",
>   "exports":[
> "com.example.my"
>   ]
> }
>   ]
> } {code}
> A bundle to feature mapping like 
> {code}
> com.example:my-bundle:1.2.3-SNAPSHOT=
> {code}
> will be created in the feature's 
> {{org.apache.sling.feature.apiregions.factory}} configuration. This is 
> because the bundle does not specify any feature-origin(s).
> For those cases the feature it self should be the origin of the bundle. The 
> current version of the api regions runtime will otherwise not find the 
> feature a bundle belongs to and so may not be able to resolve the api regions 
> the bundle belongs to. 
> An example where that can happen is the usage of the 
> slingfeature-maven-plugin without using the aggregation feature. When just 
> building far from a hand-crafted feature model the feature-origin may not be 
> set on the api-region(s).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10575) Bundles without feature-origin result in empty bundle to feature mapping

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10575.
--
Resolution: Fixed

> Bundles without feature-origin result in empty bundle to feature mapping
> 
>
> Key: SLING-10575
> URL: https://issues.apache.org/jira/browse/SLING-10575
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Installer Factory Feature Model 0.5.0
>Reporter: Dirk Rudolph
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.6.0, Feature Model API 
> Regions Extension 1.3.6
>
>
> When installing a feature archive of a feature similar to the following
> {code:json}
> {
>   "id":"com.exmaple:my-feature-pkg:slingosgifeature:tiera:12345-SNAPSHOT",
>   "bundles":[
> {
>   "id":"com.example:my-bundle:1.2.3-SNAPSHOT",
>   "start-order":"20"
> }
>   ],
>   "api-regions:JSON|false":[
> {
>   "name":"global",
>   "exports":[
> "com.example.my"
>   ]
> }
>   ]
> } {code}
> A bundle to feature mapping like 
> {code}
> com.example:my-bundle:1.2.3-SNAPSHOT=
> {code}
> will be created in the feature's 
> {{org.apache.sling.feature.apiregions.factory}} configuration. This is 
> because the bundle does not specify any feature-origin(s).
> For those cases the feature it self should be the origin of the bundle. The 
> current version of the api regions runtime will otherwise not find the 
> feature a bundle belongs to and so may not be able to resolve the api regions 
> the bundle belongs to. 
> An example where that can happen is the usage of the 
> slingfeature-maven-plugin without using the aggregation feature. When just 
> building far from a hand-crafted feature model the feature-origin may not be 
> set on the api-region(s).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10575) Bundles without feature-origin result in empty bundle to feature mapping

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-10575:
-
Fix Version/s: Feature Model API Regions Extension 1.3.6

> Bundles without feature-origin result in empty bundle to feature mapping
> 
>
> Key: SLING-10575
> URL: https://issues.apache.org/jira/browse/SLING-10575
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Installer Factory Feature Model 0.5.0
>Reporter: Dirk Rudolph
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.6.0, Feature Model API 
> Regions Extension 1.3.6
>
>
> When installing a feature archive of a feature similar to the following
> {code:json}
> {
>   "id":"com.exmaple:my-feature-pkg:slingosgifeature:tiera:12345-SNAPSHOT",
>   "bundles":[
> {
>   "id":"com.example:my-bundle:1.2.3-SNAPSHOT",
>   "start-order":"20"
> }
>   ],
>   "api-regions:JSON|false":[
> {
>   "name":"global",
>   "exports":[
> "com.example.my"
>   ]
> }
>   ]
> } {code}
> A bundle to feature mapping like 
> {code}
> com.example:my-bundle:1.2.3-SNAPSHOT=
> {code}
> will be created in the feature's 
> {{org.apache.sling.feature.apiregions.factory}} configuration. This is 
> because the bundle does not specify any feature-origin(s).
> For those cases the feature it self should be the origin of the bundle. The 
> current version of the api regions runtime will otherwise not find the 
> feature a bundle belongs to and so may not be able to resolve the api regions 
> the bundle belongs to. 
> An example where that can happen is the usage of the 
> slingfeature-maven-plugin without using the aggregation feature. When just 
> building far from a hand-crafted feature model the feature-origin may not be 
> set on the api-region(s).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Reopened] (SLING-10575) Bundles without feature-origin result in empty bundle to feature mapping

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-10575:
--

We should consider fixing this directly in the LaunchProperties - otherwise 
other clients using that code will be suffering from the same problem

> Bundles without feature-origin result in empty bundle to feature mapping
> 
>
> Key: SLING-10575
> URL: https://issues.apache.org/jira/browse/SLING-10575
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Installer Factory Feature Model 0.5.0
>Reporter: Dirk Rudolph
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.6.0
>
>
> When installing a feature archive of a feature similar to the following
> {code:json}
> {
>   "id":"com.exmaple:my-feature-pkg:slingosgifeature:tiera:12345-SNAPSHOT",
>   "bundles":[
> {
>   "id":"com.example:my-bundle:1.2.3-SNAPSHOT",
>   "start-order":"20"
> }
>   ],
>   "api-regions:JSON|false":[
> {
>   "name":"global",
>   "exports":[
> "com.example.my"
>   ]
> }
>   ]
> } {code}
> A bundle to feature mapping like 
> {code}
> com.example:my-bundle:1.2.3-SNAPSHOT=
> {code}
> will be created in the feature's 
> {{org.apache.sling.feature.apiregions.factory}} configuration. This is 
> because the bundle does not specify any feature-origin(s).
> For those cases the feature it self should be the origin of the bundle. The 
> current version of the api regions runtime will otherwise not find the 
> feature a bundle belongs to and so may not be able to resolve the api regions 
> the bundle belongs to. 
> An example where that can happen is the usage of the 
> slingfeature-maven-plugin without using the aggregation feature. When just 
> building far from a hand-crafted feature model the feature-origin may not be 
> set on the api-region(s).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10576) Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-10576.
--
Resolution: Fixed

> Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter
> ---
>
> Key: SLING-10576
> URL: https://issues.apache.org/jira/browse/SLING-10576
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.4
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> fixing a bunch of minor issues in {{VaultPackageAssembler}} and 
> {{ContentPackage2FeatureModelConverter}} spotted while working on SLING-10467
> - potential NPE
> - inconsistent indention and usage of whitespace
> - missing nullability annotations
> - instance fields spread across the class which makes its hard to read



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela merged pull request #93: SLING-10576 : Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter

[GitBox]

anchela merged pull request #93:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/93


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10467) Converted content package referres to paths moved to repo-init

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372500#comment-17372500
 ] 

Angela Schreiber commented on SLING-10467:
--

[~kpauls] thanks a lot for discussions, input and suggestions joint effort 
definitely results in better fixes :)

> Converted content package referres to paths moved to repo-init
> --
>
> Key: SLING-10467
> URL: https://issues.apache.org/jira/browse/SLING-10467
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.4
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
> Attachments: demo-cp-0.0.0-cp2fm-converted.zip, demo-cp.zip
>
>
> [~kpauls], in the light of the _enforce-principal-based-supported-path_ 
> configuration option i had a look at the converted content packages, which 
> probably need to be used instead of the original packages if the 
> modifications applied by converted are not to be reverted by later installing 
> the original content package.
> i therefore created a simple test content package _demo-cp.zip_ that contains:
>  - a regular user in 'demo-cp' subfolder
>  - a regular group in 'demo-cp' subfolder
>  - a bunch of service users both with resource-based and principal-based ac 
> setup
>  - content root at /demo-cp with a ac-policy (entries for user, group and 
> service user)
>  - a serviceusermapping configuration below /apps/demo-cp
>  and had the converter generate _demo-cp-0.0.0-cp2fm-converted.zip_
> when trying to install the converted content package on a repository that 
> content for service users and below /apps installed, i noticed that the 
> converted package will actually remove that content.
>  i suspect that this is caused by _META_INF/vault/filter.xml_ and/or 
> _META-INF/vault/definition/content.xml_ still referring to those parts that 
> got 'moved' to repo-init. in case of the dependency/.content.xml it states 
> that the import mode is _replace_ (same as in original package).
> maybe my test package is not correct but I would have expected that the 
> paths that have been installed by repo-init statements should no longer be 
> covered by the converted package (everything below /apps and 
> /home/users/system) or/and should have the import-mode changed to the 
> deprecated -MERGE- or new MERGE_PROPERTIES. the latter would be needed for 
> any kind of resource-based AC setup for service users at mutable content 
> nodes (NOTE: doesn't apply in case ac-setup for service users is migrated to 
> principal-based authorization which entirely resides below the service user 
> home).
> edge case: if regular users were to be located below _/home/users/system_ 
> excluding that path from the package definition obviously doesn't work 
> changing import mode would be required. alternatively: spotting regular users 
> below _home/users/system_ and abort converter.
> wdyt?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10576) Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-10576:


Assignee: Angela Schreiber

> Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter
> ---
>
> Key: SLING-10576
> URL: https://issues.apache.org/jira/browse/SLING-10576
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.4
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> fixing a bunch of minor issues in {{VaultPackageAssembler}} and 
> {{ContentPackage2FeatureModelConverter}} spotted while working on SLING-10467
> - potential NPE
> - inconsistent indention and usage of whitespace
> - missing nullability annotations
> - instance fields spread across the class which makes its hard to read



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #93: SLING-10576 : Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter

[GitBox]

sonarcloud[bot] commented on pull request #93:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/93#issuecomment-872012171


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&metric=new_coverage&view=list)
 [92.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter&pullRequest=93&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela opened a new pull request #93: SLING-10576 : Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter

[GitBox]

anchela opened a new pull request #93:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/93


   @karlpauls , i would appreciate if you had time to take a quick look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10576) Improvements to VaultPackageAssembler, ContentPackage2FeatureModelConverter

[Angela Schreiber (Jira)]

Angela Schreiber created SLING-10576:


 Summary: Improvements to VaultPackageAssembler, 
ContentPackage2FeatureModelConverter
 Key: SLING-10576
 URL: https://issues.apache.org/jira/browse/SLING-10576
 Project: Sling
  Issue Type: Improvement
  Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.4
Reporter: Angela Schreiber
 Fix For: Content-Package to Feature Model Converter 1.1.6


fixing a bunch of minor issues in {{VaultPackageAssembler}} and 
{{ContentPackage2FeatureModelConverter}} spotted while working on SLING-10467

- potential NPE
- inconsistent indention and usage of whitespace
- missing nullability annotations
- instance fields spread across the class which makes its hard to read



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [CANCELLED] [VOTE] Release Apache Sling Sitemap version 1.0.0

[Dirk Rudolph]

Thanks Robert, I will do that.

As suggested, I separated API and SPI from each other.

I also updated the badges of the module, however I will defer fully
updating the sling aggregator until javadoc and maven central links
are working as well.

Any other feedback, or issues I should address? If not, I will start a
new vote later today.

Thanks,
Dirk

On Wed, 30 Jun 2021 at 11:23, Robert Munteanu  wrote:
>
> On Tue, 2021-06-29 at 15:27 +0200, Dirk Rudolph wrote:
> > One question though, according to
> > https://sling.apache.org/documentation/development/release-management.html#wait-for-the-results
> > I should not reuse the version number. Is that the case for the first
> > version/1.0.0 as well or would it be safe to assume no one copied the
> > binaries around yet?
>
> We should use a new version number for 1.0.0 releases as well. We did
> that several times in the past, especially when we forgot to set proper
> SCM entries in the POM :-)
>
> Thanks,
> Robert
>