[jira] [Resolved] (SLING-10367) Update Karaf to 4.3.3

2021-09-07 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10367.
--
Resolution: Done

{noformat}
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Sling - Karaf Configs 0.2.0-SNAPSHOT  SUCCESS [  3.712 s]
[INFO] Apache Sling - Karaf Features 0.2.0-SNAPSHOT ... SUCCESS [  1.809 s]
[INFO] Apache Sling - Karaf Distribution 0.2.0-SNAPSHOT ... SUCCESS [ 33.921 s]
[INFO] Apache Sling - Karaf Integration Tests 0.2.0-SNAPSHOT SUCCESS [12:24 min]
[INFO] Apache Sling - Karaf Launchpad Integration Tests (Oak Tar) 
0.0.12-SNAPSHOT SUCCESS [02:55 min]
[INFO] Apache Sling - Karaf Builder 1-SNAPSHOT  SUCCESS [ 10.058 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time:  16:11 min
[INFO] Finished at: 2021-09-07T20:51:39+02:00
[INFO] 
{noformat}

> Update Karaf to 4.3.3
> -
>
> Key: SLING-10367
> URL: https://issues.apache.org/jira/browse/SLING-10367
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Affects Versions: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12, 
> Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, Karaf Features 1.0.0
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10367) Update Karaf to 4.3.3

2021-09-07 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-10367:
-
Fix Version/s: Karaf Features 1.0.0
   Karaf Distribution 1.0.0
   Karaf Integration Tests 1.0.0
   Karaf Launchpad Integration Tests (Oak Tar) 0.0.12

> Update Karaf to 4.3.3
> -
>
> Key: SLING-10367
> URL: https://issues.apache.org/jira/browse/SLING-10367
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12, 
> Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, Karaf Features 1.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10367) Update Karaf to 4.3.3

2021-09-07 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-10367:
-
Affects Version/s: (was: Karaf Launchpad Integration Tests (Oak Tar) 
0.0.12)
   (was: Karaf Distribution 1.0.0)
   (was: Karaf Integration Tests 1.0.0)
   (was: Karaf Features 1.0.0)

> Update Karaf to 4.3.3
> -
>
> Key: SLING-10367
> URL: https://issues.apache.org/jira/browse/SLING-10367
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-10792) Update to Sling (Bundle) Parent 45

2021-09-07 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10792.
--
Resolution: Done

> Update to Sling (Bundle) Parent 45
> --
>
> Key: SLING-10792
> URL: https://issues.apache.org/jira/browse/SLING-10792
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12, 
> Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, Karaf Features 
> 1.0.0, Karaf Configs 1.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-10653) Cannot save Importer Endpoints

2021-09-07 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-10653.
--
Resolution: Fixed

> Cannot save Importer Endpoints
> --
>
> Key: SLING-10653
> URL: https://issues.apache.org/jira/browse/SLING-10653
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 1.0.2, App CMS 1.0.4
>Reporter: James Raynor
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 1.0.8
>
>
> Update2021-08-03:
> I have tested version 1.0.4 and found the same problem, steps to reproduce:
> Only steps 1,3 are needed to reproduce the bug without step 2.
> After several tests, I found a temporary way to skip the bug:
> Go to [http://localhost:8080/system/console]
> Find "Apache Sling CMS - Forward Agent Endpoint Sync"
> Agent Target:
> (xxx)
> Save.
> Just fill in the Agent Target with any unrelated value, e.g. "(xxx)".
> Apparently, the "Agent Target" property of the "Forward Agent Endpoint Sync" 
> item is empty, which is the cause of the bug.
>  
> Also, I found two misspellings of the default configuration.
> Find "Apache Sling Distribution Resources - Service Resource Provider Factory"
> Resource kind: exporter
> Resource kind: importer
> Resource kind: importer.
> Property provider.roots:
> /libs/sling/distribution/services/importer
> The "importer" is missing the "s". The correct content should be:
> /libs/sling/distribution/services/importers
> This error causes the following Importer Endpoints (as in most tutorials on 
> the web) to fail to sync:
> [http://localhost:8081/libs/sling/distribution/services/importers/default]
> I checked the configuration in the same place in AEM's OSGI console and it is 
> "importers".
> "Resource kind: exporter" has the same error.
> ——
> I tested Forward Distribution in SlingCMS version 0.16.0 yesterday and it 
> worked, but in version 1.0.2 it failed to save Importer Endpoints.
> Steps to reproduce:
> Run SlingCMS1.0.2, go to [http://localhost:8080/system/console]
> 1.Find "Apache Sling Distribution Agent - Forward Agents Factory"
>  Name:
>  publish
> Allowed roots:
>  /content
> Importer Endpoints:
>  [http://localhost:8081/libs/sling/distribution/services/importers/default]
> Save.
> (If you reboot the system after saving at this step, Importer Endpoints will 
> also be lost)
>  
> 2.Find "Apache Sling Distribution Packaging - Vault Package Builder Factory"
>  Name:
>  default
> Save.
>  
> 3.Check 1 and find that its “Importer Endpoints” are missing and cannot be 
> saved even if they are added again.
> I've tried a workaround by doing step 2 first and then step 1, and the 
> Importer Endpoints are saved.
> 4.Find "Apache Sling Distribution Transport Credentials - User Credentials 
> based DistributionTransportSecretProvider"
>  default, admin, admin
> Save.
>  Check 1,Importer Endpoints are missing and cannot be saved in any way.
>  
> Go to [http://localhost:8080/system/console/components]
> org.apache.sling.distribution.agent.impl.ForwardDistributionAgentFactory
>  It's "unsatisfied" status.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-10653) Cannot save Importer Endpoints

2021-09-07 Thread Dan Klco (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411416#comment-17411416
 ] 

Dan Klco commented on SLING-10653:
--

Thanks for the tip [~James.R] ! Fixed in 
https://github.com/apache/sling-org-apache-sling-app-cms/commit/82febd5900817448b012018f3e9d31bceb5e2088

> Cannot save Importer Endpoints
> --
>
> Key: SLING-10653
> URL: https://issues.apache.org/jira/browse/SLING-10653
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 1.0.2, App CMS 1.0.4
>Reporter: James Raynor
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 1.0.8
>
>
> Update2021-08-03:
> I have tested version 1.0.4 and found the same problem, steps to reproduce:
> Only steps 1,3 are needed to reproduce the bug without step 2.
> After several tests, I found a temporary way to skip the bug:
> Go to [http://localhost:8080/system/console]
> Find "Apache Sling CMS - Forward Agent Endpoint Sync"
> Agent Target:
> (xxx)
> Save.
> Just fill in the Agent Target with any unrelated value, e.g. "(xxx)".
> Apparently, the "Agent Target" property of the "Forward Agent Endpoint Sync" 
> item is empty, which is the cause of the bug.
>  
> Also, I found two misspellings of the default configuration.
> Find "Apache Sling Distribution Resources - Service Resource Provider Factory"
> Resource kind: exporter
> Resource kind: importer
> Resource kind: importer.
> Property provider.roots:
> /libs/sling/distribution/services/importer
> The "importer" is missing the "s". The correct content should be:
> /libs/sling/distribution/services/importers
> This error causes the following Importer Endpoints (as in most tutorials on 
> the web) to fail to sync:
> [http://localhost:8081/libs/sling/distribution/services/importers/default]
> I checked the configuration in the same place in AEM's OSGI console and it is 
> "importers".
> "Resource kind: exporter" has the same error.
> ——
> I tested Forward Distribution in SlingCMS version 0.16.0 yesterday and it 
> worked, but in version 1.0.2 it failed to save Importer Endpoints.
> Steps to reproduce:
> Run SlingCMS1.0.2, go to [http://localhost:8080/system/console]
> 1.Find "Apache Sling Distribution Agent - Forward Agents Factory"
>  Name:
>  publish
> Allowed roots:
>  /content
> Importer Endpoints:
>  [http://localhost:8081/libs/sling/distribution/services/importers/default]
> Save.
> (If you reboot the system after saving at this step, Importer Endpoints will 
> also be lost)
>  
> 2.Find "Apache Sling Distribution Packaging - Vault Package Builder Factory"
>  Name:
>  default
> Save.
>  
> 3.Check 1 and find that its “Importer Endpoints” are missing and cannot be 
> saved even if they are added again.
> I've tried a workaround by doing step 2 first and then step 1, and the 
> Importer Endpoints are saved.
> 4.Find "Apache Sling Distribution Transport Credentials - User Credentials 
> based DistributionTransportSecretProvider"
>  default, admin, admin
> Save.
>  Check 1,Importer Endpoints are missing and cannot be saved in any way.
>  
> Go to [http://localhost:8080/system/console/components]
> org.apache.sling.distribution.agent.impl.ForwardDistributionAgentFactory
>  It's "unsatisfied" status.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-10653) Cannot save Importer Endpoints

2021-09-07 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco reassigned SLING-10653:


Assignee: Dan Klco

> Cannot save Importer Endpoints
> --
>
> Key: SLING-10653
> URL: https://issues.apache.org/jira/browse/SLING-10653
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 1.0.2, App CMS 1.0.4
>Reporter: James Raynor
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 1.0.8
>
>
> Update2021-08-03:
> I have tested version 1.0.4 and found the same problem, steps to reproduce:
> Only steps 1,3 are needed to reproduce the bug without step 2.
> After several tests, I found a temporary way to skip the bug:
> Go to [http://localhost:8080/system/console]
> Find "Apache Sling CMS - Forward Agent Endpoint Sync"
> Agent Target:
> (xxx)
> Save.
> Just fill in the Agent Target with any unrelated value, e.g. "(xxx)".
> Apparently, the "Agent Target" property of the "Forward Agent Endpoint Sync" 
> item is empty, which is the cause of the bug.
>  
> Also, I found two misspellings of the default configuration.
> Find "Apache Sling Distribution Resources - Service Resource Provider Factory"
> Resource kind: exporter
> Resource kind: importer
> Resource kind: importer.
> Property provider.roots:
> /libs/sling/distribution/services/importer
> The "importer" is missing the "s". The correct content should be:
> /libs/sling/distribution/services/importers
> This error causes the following Importer Endpoints (as in most tutorials on 
> the web) to fail to sync:
> [http://localhost:8081/libs/sling/distribution/services/importers/default]
> I checked the configuration in the same place in AEM's OSGI console and it is 
> "importers".
> "Resource kind: exporter" has the same error.
> ——
> I tested Forward Distribution in SlingCMS version 0.16.0 yesterday and it 
> worked, but in version 1.0.2 it failed to save Importer Endpoints.
> Steps to reproduce:
> Run SlingCMS1.0.2, go to [http://localhost:8080/system/console]
> 1.Find "Apache Sling Distribution Agent - Forward Agents Factory"
>  Name:
>  publish
> Allowed roots:
>  /content
> Importer Endpoints:
>  [http://localhost:8081/libs/sling/distribution/services/importers/default]
> Save.
> (If you reboot the system after saving at this step, Importer Endpoints will 
> also be lost)
>  
> 2.Find "Apache Sling Distribution Packaging - Vault Package Builder Factory"
>  Name:
>  default
> Save.
>  
> 3.Check 1 and find that its “Importer Endpoints” are missing and cannot be 
> saved even if they are added again.
> I've tried a workaround by doing step 2 first and then step 1, and the 
> Importer Endpoints are saved.
> 4.Find "Apache Sling Distribution Transport Credentials - User Credentials 
> based DistributionTransportSecretProvider"
>  default, admin, admin
> Save.
>  Check 1,Importer Endpoints are missing and cannot be saved in any way.
>  
> Go to [http://localhost:8080/system/console/components]
> org.apache.sling.distribution.agent.impl.ForwardDistributionAgentFactory
>  It's "unsatisfied" status.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-10653) Cannot save Importer Endpoints

2021-09-07 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-10653:
-
Fix Version/s: App CMS 1.0.8

> Cannot save Importer Endpoints
> --
>
> Key: SLING-10653
> URL: https://issues.apache.org/jira/browse/SLING-10653
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 1.0.2, App CMS 1.0.4
>Reporter: James Raynor
>Priority: Major
> Fix For: App CMS 1.0.8
>
>
> Update2021-08-03:
> I have tested version 1.0.4 and found the same problem, steps to reproduce:
> Only steps 1,3 are needed to reproduce the bug without step 2.
> After several tests, I found a temporary way to skip the bug:
> Go to [http://localhost:8080/system/console]
> Find "Apache Sling CMS - Forward Agent Endpoint Sync"
> Agent Target:
> (xxx)
> Save.
> Just fill in the Agent Target with any unrelated value, e.g. "(xxx)".
> Apparently, the "Agent Target" property of the "Forward Agent Endpoint Sync" 
> item is empty, which is the cause of the bug.
>  
> Also, I found two misspellings of the default configuration.
> Find "Apache Sling Distribution Resources - Service Resource Provider Factory"
> Resource kind: exporter
> Resource kind: importer
> Resource kind: importer.
> Property provider.roots:
> /libs/sling/distribution/services/importer
> The "importer" is missing the "s". The correct content should be:
> /libs/sling/distribution/services/importers
> This error causes the following Importer Endpoints (as in most tutorials on 
> the web) to fail to sync:
> [http://localhost:8081/libs/sling/distribution/services/importers/default]
> I checked the configuration in the same place in AEM's OSGI console and it is 
> "importers".
> "Resource kind: exporter" has the same error.
> ——
> I tested Forward Distribution in SlingCMS version 0.16.0 yesterday and it 
> worked, but in version 1.0.2 it failed to save Importer Endpoints.
> Steps to reproduce:
> Run SlingCMS1.0.2, go to [http://localhost:8080/system/console]
> 1.Find "Apache Sling Distribution Agent - Forward Agents Factory"
>  Name:
>  publish
> Allowed roots:
>  /content
> Importer Endpoints:
>  [http://localhost:8081/libs/sling/distribution/services/importers/default]
> Save.
> (If you reboot the system after saving at this step, Importer Endpoints will 
> also be lost)
>  
> 2.Find "Apache Sling Distribution Packaging - Vault Package Builder Factory"
>  Name:
>  default
> Save.
>  
> 3.Check 1 and find that its “Importer Endpoints” are missing and cannot be 
> saved even if they are added again.
> I've tried a workaround by doing step 2 first and then step 1, and the 
> Importer Endpoints are saved.
> 4.Find "Apache Sling Distribution Transport Credentials - User Credentials 
> based DistributionTransportSecretProvider"
>  default, admin, admin
> Save.
>  Check 1,Importer Endpoints are missing and cannot be saved in any way.
>  
> Go to [http://localhost:8080/system/console/components]
> org.apache.sling.distribution.agent.impl.ForwardDistributionAgentFactory
>  It's "unsatisfied" status.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-10792) Update to Sling (Bundle) Parent 45

2021-09-07 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-10792:


 Summary: Update to Sling (Bundle) Parent 45
 Key: SLING-10792
 URL: https://issues.apache.org/jira/browse/SLING-10792
 Project: Sling
  Issue Type: Task
  Components: Karaf
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12, Karaf 
Integration Tests 1.0.0, Karaf Distribution 1.0.0, Karaf Features 1.0.0, Karaf 
Configs 1.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-10645) Update Sling Resource Merger with handling for multi-valued properties

2021-09-07 Thread Bertrand Delacretaz (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411089#comment-17411089
 ] 

Bertrand Delacretaz commented on SLING-10645:
-

What bugs me with use cases 4 and 5 and for the "somewhere in between" option 
of 1 is that they imply that you know the original values. If that's the case, 
you could argue that replacing the whole set has the same effect. Or "almost" 
the same effect but that "almost" is where things possibly become hard to 
understand and troubleshoot.

Anyway, if you want to implement all cases I am not opposed, as long as the 
whole thing is backed by strong tests and clearly documented.

However I would much prefer having just what's actually required, which IIUC is 
a merge mode, maybe with "add before" or "add after" options which are simple 
to understand.

> Update Sling Resource Merger with handling for multi-valued properties
> --
>
> Key: SLING-10645
> URL: https://issues.apache.org/jira/browse/SLING-10645
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Merger 1.4.0
>Reporter: Henry Kuijpers
>Priority: Major
>
> Sling Resource Merger is able to handle properties, not individual property 
> values.
> When setting up this node structure (with AEM's extraClientlibs property in 
> TouchUI dialogs):
> + /libs/wcm/basicpage/cq:dialog@extraClientlibs=["a", "b", "c"]
> + /apps/website/components/page@sling:resourceSuperType="wcm/basicpage"
> + /apps/website/components/page/cq:dialog@extraClientlibs=["d", "e"]
> We want to make sure that the extraClientlibs property that is being read in 
> website/components/page/cq:dialog will return ["a", "b", "c", "d", "e"]. 
> Currently, it will just return ["d", "e"], since the extraClientlibs-property 
> is *overwritten*. 
> It would be nice to add additional logic to allow more control over the 
> inheritance of the values that are tied to a parent's 
> extraClientlibs-property.
> Maybe we can come up with some additional properties that can function as 
> instructions to the Resource Merger (next to the ones we already have), so 
> that there can be more fine-grained control over the inheritance/removal of 
> property values in multi-valued scenarios.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-10645) Update Sling Resource Merger with handling for multi-valued properties

2021-09-07 Thread Henry Kuijpers (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411049#comment-17411049
 ] 

Henry Kuijpers commented on SLING-10645:


Hi [~bdelacretaz],

Indeed, there is an "overriding" and an "overlaying" way, however, the names of 
the services behind it are quite confusing because they don't correctly explain 
what they do (overriding = Overriding Resource Picker, overlay = Merging 
Resource Picker).

Overriding means *merging* based on the 
sling:resourceType/sling:resourceSuperType properties.
Overlaying means *merging* based on the search path (/libs, /apps, ...)

They both merge. :)

Current set of properties that can be put on nodes (that function as 
instructions to the Resource Merger), already provide a good arsenal of 
functionality.

In terms of controlling properties, it is possible to discard a property, or 
overwrite a property.

That is totally fine for almost all use-cases. With the exception of 
multi-valued properties. 

With multi-valued properties, it could be very nice to have more fine-grained 
control over what happens with the parent's property values.

Some use-cases:
1. Inherit all values, but add a (set of) values at the end, at the beginning, 
or somewhere in-between
2. Inherit no values (can already be done with sling:hideProperties=[x])
3. Inherit no values, but redefine the property (can already be done by just 
specifying the property again, without instructions)
4. Inherit all values, except for 2 specific values
5. Inherit values, exclude some, add some (combination of 1 and 4)

The specific use-case I'm trying to tackle now indeed allows for a simple 
"merge"-mode, where our values can just be appended to the set of values from 
the parent. But I can imagine #5 and #1 could also be desired.

It seems [~JelleBouwmans] also has a requirement for this concept, so at least 
there are 2 use-cases already.

I did notice that my proposal didn't account for inserting a property value 
after a specific value.

> Update Sling Resource Merger with handling for multi-valued properties
> --
>
> Key: SLING-10645
> URL: https://issues.apache.org/jira/browse/SLING-10645
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Merger 1.4.0
>Reporter: Henry Kuijpers
>Priority: Major
>
> Sling Resource Merger is able to handle properties, not individual property 
> values.
> When setting up this node structure (with AEM's extraClientlibs property in 
> TouchUI dialogs):
> + /libs/wcm/basicpage/cq:dialog@extraClientlibs=["a", "b", "c"]
> + /apps/website/components/page@sling:resourceSuperType="wcm/basicpage"
> + /apps/website/components/page/cq:dialog@extraClientlibs=["d", "e"]
> We want to make sure that the extraClientlibs property that is being read in 
> website/components/page/cq:dialog will return ["a", "b", "c", "d", "e"]. 
> Currently, it will just return ["d", "e"], since the extraClientlibs-property 
> is *overwritten*. 
> It would be nice to add additional logic to allow more control over the 
> inheritance of the values that are tied to a parent's 
> extraClientlibs-property.
> Maybe we can come up with some additional properties that can function as 
> instructions to the Resource Merger (next to the ones we already have), so 
> that there can be more fine-grained control over the inheritance/removal of 
> property values in multi-valued scenarios.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-10645) Update Sling Resource Merger with handling for multi-valued properties

2021-09-07 Thread Bertrand Delacretaz (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411026#comment-17411026
 ] 

Bertrand Delacretaz commented on SLING-10645:
-

I don't know much about the resource merger, but looking at the docs at 
[https://sling.apache.org/documentation/bundles/resource-merger.html] the key 
modes seem to be "override" and "merge".

In this case for multi-valued properties the default mode is apparently 
"override", do you need more than a new "merge" option?

IIUC you're going for overriding or hiding individual values, which looks quite 
brittle to me. If just adding a "merge" mode would work for your use cases that 
might be easier to manage.

 

> Update Sling Resource Merger with handling for multi-valued properties
> --
>
> Key: SLING-10645
> URL: https://issues.apache.org/jira/browse/SLING-10645
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Merger 1.4.0
>Reporter: Henry Kuijpers
>Priority: Major
>
> Sling Resource Merger is able to handle properties, not individual property 
> values.
> When setting up this node structure (with AEM's extraClientlibs property in 
> TouchUI dialogs):
> + /libs/wcm/basicpage/cq:dialog@extraClientlibs=["a", "b", "c"]
> + /apps/website/components/page@sling:resourceSuperType="wcm/basicpage"
> + /apps/website/components/page/cq:dialog@extraClientlibs=["d", "e"]
> We want to make sure that the extraClientlibs property that is being read in 
> website/components/page/cq:dialog will return ["a", "b", "c", "d", "e"]. 
> Currently, it will just return ["d", "e"], since the extraClientlibs-property 
> is *overwritten*. 
> It would be nice to add additional logic to allow more control over the 
> inheritance of the values that are tied to a parent's 
> extraClientlibs-property.
> Maybe we can come up with some additional properties that can function as 
> instructions to the Resource Merger (next to the ones we already have), so 
> that there can be more fine-grained control over the inheritance/removal of 
> property values in multi-valued scenarios.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)