[GitHub] [sling-org-apache-sling-engine] cziegeler opened a new pull request, #36: SLING-11898 : Make patterns for access and request log configurable

2023-06-01 Thread via GitHub


cziegeler opened a new pull request, #36:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/36

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (SLING-11898) Make patterns for access and request log configurable

2023-06-01 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-11898:


 Summary: Make patterns for access and request log configurable
 Key: SLING-11898
 URL: https://issues.apache.org/jira/browse/SLING-11898
 Project: Sling
  Issue Type: Improvement
  Components: Engine
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Engine 2.15.2


The patterns for the access and the request log are hard-coded. Some 
applications might have a special requirement to log additional/other 
information, e.g. an additional header, in the access or request log which is 
currently not possible.
We should make the patterns configurable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2023-06-01 Thread via GitHub


sonarcloud[bot] commented on PR #7:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1572633975

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=7)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=7=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=CODE_SMELL)
   
   
[![70.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'70.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
 [70.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=7=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-get] enapps-enorman commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-01 Thread via GitHub


enapps-enorman commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1572561639

   > Base64 is enabled in jcr xml and so far it was okay.
   
   If I am not mistaken, the XMLRenderer streams the xml text to the response.  
I don't believe it loads the whole xml document into memory before writing it 
to the response.  Also, I think it reads the binary property value as an 
InputStream and then writes the base64 text directly to the output writer 
without loading the while file into memory.  In that case, you only need enough 
memory for the small buffer that is consuming the InputStream while 
transforming it to base64.
   
   That may not be possible with the JSON generator apis as it expects the 
whole string so it would likely need much more server side memory (something 
like ~140% the size of the original file) for the base64 conversion to a string.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-get] YegorKozlov commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-01 Thread via GitHub


YegorKozlov commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1572522399

   Base64 is enabled in jcr xml and so far it was okay.
   
   What if we have a configurable max_bytes_to_export osgi parameter ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SLING-11897) Default Get Servlet tests fail on Java 17

2023-06-01 Thread Eric Norman (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728418#comment-17728418
 ] 

Eric Norman commented on SLING-11897:
-

I don't have a java17 enviornment handy to test this, but bumping the 
org.apache.sling.testing.sling-mock-oak dependency to one of the 3.1.x versions 
may be worth a try as the oak version would then be > 1.26.0

> Default Get Servlet tests fail on Java 17
> -
>
> Key: SLING-11897
> URL: https://issues.apache.org/jira/browse/SLING-11897
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Servlets Get 2.1.46
>
>
> {noformat}[ERROR] 
> org.apache.sling.servlets.get.impl.helpers.JsonRendererBinaryDataTest.testExportBinaryDataDisabled
>   Time elapsed: 0.088 s  <<< ERROR!
> java.lang.RuntimeException: Unable to initialize JCR_OAK resource resolver 
> factory: java/security/acl/Group
>   at 
> org.apache.sling.testing.mock.sling.context.ContextResourceResolverFactory.get(ContextResourceResolverFactory.java:68)
>   at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.newResourceResolverFactory(SlingContextImpl.java:145)
>   at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.resourceResolverFactory(SlingContextImpl.java:150)
>   at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.setUp(SlingContextImpl.java:134)
>   at 
> org.apache.sling.testing.mock.sling.junit.SlingContext.access$100(SlingContext.java:42)
>   at 
> org.apache.sling.testing.mock.sling.junit.SlingContext$1.before(SlingContext.java:146)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
>   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
>   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
> Caused by: java.lang.NoClassDefFoundError: java/security/acl/Group
>   at 
> org.apache.jackrabbit.oak.security.user.UserConfigurationImpl.getUserPrincipalProvider(UserConfigurationImpl.java:245)
>   at 
> org.apache.jackrabbit.oak.security.principal.PrincipalConfigurationImpl.getPrincipalProvider(PrincipalConfigurationImpl.java:75)
>   at 
> org.apache.jackrabbit.oak.spi.security.principal.CompositePrincipalConfiguration.getPrincipalProvider(CompositePrincipalConfiguration.java:55)
>   at 
> org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getPrincipalProvider(AbstractLoginModule.java:454)
>   at 
> org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getPrincipals(AbstractLoginModule.java:490)
>   at 
> org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.commit(LoginModuleImpl.java:167)
>   at 
> java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:758)
>   at 
> java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:679)
>   at 
> java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:677)
>   at 
> java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
>   at 
> java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:677)
>   at 

[GitHub] [sling-org-apache-sling-servlets-get] enapps-enorman commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-01 Thread via GitHub


enapps-enorman commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1572335408

   I'm still a bit concerned about this being a vector toward a 
denial-of-service attack.  
   
   For example, consider a scenario with a just a few large files in a folder.  
A swarm of "resource.withBinaries.json" requests to render that folder would 
load the base64 strings for all those files into memory which could exhaust all 
the server side memory.
   
   Perhaps refactoring the JsonRenderer implementation to use 
javax.json.stream.JsonGenerator more directly to write the JSON data in a 
streaming way could mitigate that risk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-get] YegorKozlov commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-01 Thread via GitHub


YegorKozlov commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1572163648

   @rombert @joerghoh I like the selector idea.  It makes this feature dynamic 
per-request. 
   
   There is a related PR 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/22 to 
make sense of the base64 data when importing content via Sling POST servlet, 
and the question is  if it's  okay to use a colon prefixed property to carry 
the data?
   Sling POST Servlet ignores form properties starting with ":" with respect to 
content update. 
   What about importing content from json? If the GET servlet produces a JSON 
with colon-prefixed fields, should they be ignored when importing via Sling 
POST servlet? Or designating binary properties with a leading colon is just a 
naming convention?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-get] joerghoh commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-01 Thread via GitHub


joerghoh commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1572082183

   I agree to @rombert here. But instead of a query parameter I would opt for a 
selector (e.g. "resource.withBinaries.json")


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SLING-11897) Default Get Servlet tests fail on Java 17

2023-06-01 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728358#comment-17728358
 ] 

Stefan Seifert commented on SLING-11897:


probably same root cause as in SLING-11894

> Default Get Servlet tests fail on Java 17
> -
>
> Key: SLING-11897
> URL: https://issues.apache.org/jira/browse/SLING-11897
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Servlets Get 2.1.46
>
>
> {noformat}[ERROR] 
> org.apache.sling.servlets.get.impl.helpers.JsonRendererBinaryDataTest.testExportBinaryDataDisabled
>   Time elapsed: 0.088 s  <<< ERROR!
> java.lang.RuntimeException: Unable to initialize JCR_OAK resource resolver 
> factory: java/security/acl/Group
>   at 
> org.apache.sling.testing.mock.sling.context.ContextResourceResolverFactory.get(ContextResourceResolverFactory.java:68)
>   at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.newResourceResolverFactory(SlingContextImpl.java:145)
>   at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.resourceResolverFactory(SlingContextImpl.java:150)
>   at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.setUp(SlingContextImpl.java:134)
>   at 
> org.apache.sling.testing.mock.sling.junit.SlingContext.access$100(SlingContext.java:42)
>   at 
> org.apache.sling.testing.mock.sling.junit.SlingContext$1.before(SlingContext.java:146)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
>   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
>   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
> Caused by: java.lang.NoClassDefFoundError: java/security/acl/Group
>   at 
> org.apache.jackrabbit.oak.security.user.UserConfigurationImpl.getUserPrincipalProvider(UserConfigurationImpl.java:245)
>   at 
> org.apache.jackrabbit.oak.security.principal.PrincipalConfigurationImpl.getPrincipalProvider(PrincipalConfigurationImpl.java:75)
>   at 
> org.apache.jackrabbit.oak.spi.security.principal.CompositePrincipalConfiguration.getPrincipalProvider(CompositePrincipalConfiguration.java:55)
>   at 
> org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getPrincipalProvider(AbstractLoginModule.java:454)
>   at 
> org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getPrincipals(AbstractLoginModule.java:490)
>   at 
> org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.commit(LoginModuleImpl.java:167)
>   at 
> java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:758)
>   at 
> java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:679)
>   at 
> java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:677)
>   at 
> java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
>   at 
> java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:677)
>   at 
> java.base/javax.security.auth.login.LoginContext.login(LoginContext.java:588)
>   at 
> 

[GitHub] [sling-org-apache-sling-servlets-get] rombert commented on pull request #11: SLING-11892: OSGi flag to enable exporting binary properties in JSON

2023-06-01 Thread via GitHub


rombert commented on PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1571909762

   Note: CI failure is unrelated, filed 
https://issues.apache.org/jira/browse/SLING-11897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (SLING-11897) Default Get Servlet tests fail on Java 17

2023-06-01 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-11897:
---

 Summary: Default Get Servlet tests fail on Java 17
 Key: SLING-11897
 URL: https://issues.apache.org/jira/browse/SLING-11897
 Project: Sling
  Issue Type: Bug
  Components: Servlets
Reporter: Robert Munteanu
 Fix For: Servlets Get 2.1.46


{noformat}[ERROR] 
org.apache.sling.servlets.get.impl.helpers.JsonRendererBinaryDataTest.testExportBinaryDataDisabled
  Time elapsed: 0.088 s  <<< ERROR!
java.lang.RuntimeException: Unable to initialize JCR_OAK resource resolver 
factory: java/security/acl/Group
at 
org.apache.sling.testing.mock.sling.context.ContextResourceResolverFactory.get(ContextResourceResolverFactory.java:68)
at 
org.apache.sling.testing.mock.sling.context.SlingContextImpl.newResourceResolverFactory(SlingContextImpl.java:145)
at 
org.apache.sling.testing.mock.sling.context.SlingContextImpl.resourceResolverFactory(SlingContextImpl.java:150)
at 
org.apache.sling.testing.mock.sling.context.SlingContextImpl.setUp(SlingContextImpl.java:134)
at 
org.apache.sling.testing.mock.sling.junit.SlingContext.access$100(SlingContext.java:42)
at 
org.apache.sling.testing.mock.sling.junit.SlingContext$1.before(SlingContext.java:146)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
at 
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
Caused by: java.lang.NoClassDefFoundError: java/security/acl/Group
at 
org.apache.jackrabbit.oak.security.user.UserConfigurationImpl.getUserPrincipalProvider(UserConfigurationImpl.java:245)
at 
org.apache.jackrabbit.oak.security.principal.PrincipalConfigurationImpl.getPrincipalProvider(PrincipalConfigurationImpl.java:75)
at 
org.apache.jackrabbit.oak.spi.security.principal.CompositePrincipalConfiguration.getPrincipalProvider(CompositePrincipalConfiguration.java:55)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getPrincipalProvider(AbstractLoginModule.java:454)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getPrincipals(AbstractLoginModule.java:490)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.commit(LoginModuleImpl.java:167)
at 
java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:758)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:679)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:677)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
at 
java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:677)
at 
java.base/javax.security.auth.login.LoginContext.login(LoginContext.java:588)
at 
org.apache.jackrabbit.oak.core.ContentRepositoryImpl.login(ContentRepositoryImpl.java:163)
at 
org.apache.jackrabbit.oak.jcr.repository.RepositoryImpl.login(RepositoryImpl.java:288)
at 
org.apache.jackrabbit.oak.jcr.repository.RepositoryImpl.login(RepositoryImpl.java:226)
at 
org.apache.sling.testing.mock.sling.oak.OakMockSlingRepository.login(OakMockSlingRepository.java:123)
at 

Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.7.0

2023-06-01 Thread davidb
+1

Thanks!

David

On Thu, 1 Jun 2023 at 11:57, Stefan Seifert
 wrote:

> +1
>
> stefan
>


RE: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.7.0

2023-06-01 Thread Stefan Seifert
+1

stefan


Re: [VOTE] Release Servlets Resolver 2.9.12

2023-06-01 Thread Robert Munteanu
On Thu, 2023-06-01 at 11:38 +0200, Jörg Hoh wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part


Re: FYI, new "project state" information in Board reports

2023-06-01 Thread Robert Munteanu
On Thu, 2023-06-01 at 11:42 +0200, Bertrand Delacretaz wrote:
> On Fri, May 26, 2023 at 10:23 AM Robert Munteanu 
> wrote:
> > ...I've updated the draft accordingly...
> 
> Thank you! The Sling report is the first one ever to be submitted
> with
> this new project status info, /me proud ;-)

Cool, thanks for setting us up for success :-)

Robert


[VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.7.0

2023-06-01 Thread Robert Munteanu
Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352328

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2755/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2755 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu


Re: FYI, new "project state" information in Board reports

2023-06-01 Thread Bertrand Delacretaz
On Fri, May 26, 2023 at 10:23 AM Robert Munteanu  wrote:
> ...I've updated the draft accordingly...

Thank you! The Sling report is the first one ever to be submitted with
this new project status info, /me proud ;-)

-Bertrand


[jira] [Updated] (SLING-11896) Fix build failures on Windows plattform

2023-06-01 Thread Joerg Hoh (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joerg Hoh updated SLING-11896:
--
Description: 
 

See 
[https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34] and

[https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-servlets-resolver/detail/SLING-11895/1/pipeline/]

Also re-enable the windows builds.

  was:
 

See 
[https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34] and

[https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-servlets-resolver/detail/SLING-11895/1/pipeline/]

 


> Fix build failures on Windows plattform
> ---
>
> Key: SLING-11896
> URL: https://issues.apache.org/jira/browse/SLING-11896
> Project: Sling
>  Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.10
>Reporter: Joerg Hoh
>Priority: Major
> Fix For: Servlets Resolver 2.9.14
>
>
>  
> See 
> [https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34] 
> and
> [https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-servlets-resolver/detail/SLING-11895/1/pipeline/]
> Also re-enable the windows builds.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [VOTE] Release Servlets Resolver 2.9.12

2023-06-01 Thread Jörg Hoh
And my +1

Jörg

Am Do., 1. Juni 2023 um 11:38 Uhr schrieb Jörg Hoh :

> Hi,
>
> We solved 3 issues in this 
> release:https://issues.apache.org/jira/projects/SLING/versions/12352611
>
> Staging 
> repository:https://repository.apache.org/content/repositories/orgapachesling-2754
>
> You can use this UNIX script to download the release and verify the 
> signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> Usage:
> sh check_staged_release.sh 2754 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
>
>
> --
> Cheers,
> Jörg Hoh,
>
> https://cqdump.joerghoh.de
> Twitter: @joerghoh
>


-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh


[VOTE] Release Servlets Resolver 2.9.12

2023-06-01 Thread Jörg Hoh
Hi,

We solved 3 issues in this
release:https://issues.apache.org/jira/projects/SLING/versions/12352611

Staging 
repository:https://repository.apache.org/content/repositories/orgapachesling-2754

You can use this UNIX script to download the release and verify the
signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
Usage:
sh check_staged_release.sh 2754 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.



-- 
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh


[jira] [Updated] (SLING-11796) The ResourceResolverFactory dependency should be dynamic

2023-06-01 Thread Joerg Hoh (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joerg Hoh updated SLING-11796:
--
Fix Version/s: Servlets Resolver 2.9.14
   (was: Servlets Resolver 2.9.12)

> The ResourceResolverFactory dependency should be dynamic
> 
>
> Key: SLING-11796
> URL: https://issues.apache.org/jira/browse/SLING-11796
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.9.4
>Reporter: Radu Cotescu
>Priority: Major
> Fix For: Servlets Resolver 2.9.14
>
>
> The {{BundledScriptTracker}} requires the {{ResourceResolverFactory}} to 
> determine servlets for resource types should be added to the servlets 
> hierarchy. However, in a system with a large number of servlets a restart of 
> the {{ResourceResolverFactory}} forces the servlets' reregistration. This is 
> an expensive operation which should happen if really required. Since the 
> tracker only needs the search path information from the 
> {{ResourceResolverFactory}}, this reference should be made dynamic and the 
> tracker should  reregister the servlets only in the case the search paths 
> array has changed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-11895) Remove SNAPSHOT dependency to sling engine

2023-06-01 Thread Joerg Hoh (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joerg Hoh resolved SLING-11895.
---
Resolution: Fixed

> Remove SNAPSHOT dependency to sling engine
> --
>
> Key: SLING-11895
> URL: https://issues.apache.org/jira/browse/SLING-11895
> Project: Sling
>  Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.10
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Servlets Resolver 2.9.12
>
>
> update to Sling Engine 2.15.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-servlets-resolver] joerghoh merged pull request #34: update sling engine to 2.15.0

2023-06-01 Thread via GitHub


joerghoh merged PR #34:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #34: update sling engine to 2.15.0

2023-06-01 Thread via GitHub


sonarcloud[bot] commented on PR #34:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34#issuecomment-1571673166

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-resolver=34)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=34=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=34=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver=34=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=34=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=34=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=34=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver=34=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (SLING-11896) Fix build failures on Windows plattform

2023-06-01 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-11896:
-

 Summary: Fix build failures on Windows plattform
 Key: SLING-11896
 URL: https://issues.apache.org/jira/browse/SLING-11896
 Project: Sling
  Issue Type: Task
Affects Versions: Servlets Resolver 2.9.10
Reporter: Joerg Hoh
 Fix For: Servlets Resolver 2.9.14


 

See 
[https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34] and

[https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-servlets-resolver/detail/SLING-11895/1/pipeline/]

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-servlets-resolver] joerghoh commented on pull request #34: update sling engine to 2.15.0

2023-06-01 Thread via GitHub


joerghoh commented on PR #34:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34#issuecomment-1571524454

   The new Windows builds fail (mostly because of differences in the newline).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-servlets-resolver] joerghoh opened a new pull request, #34: update sling engine to 2.15.0

2023-06-01 Thread via GitHub


joerghoh opened a new pull request, #34:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/34

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (SLING-11895) Remove SNAPSHOT dependency to sling engine

2023-06-01 Thread Joerg Hoh (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joerg Hoh reassigned SLING-11895:
-

Assignee: Joerg Hoh

> Remove SNAPSHOT dependency to sling engine
> --
>
> Key: SLING-11895
> URL: https://issues.apache.org/jira/browse/SLING-11895
> Project: Sling
>  Issue Type: Task
>Affects Versions: Servlets Resolver 2.9.10
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Servlets Resolver 2.9.12
>
>
> update to Sling Engine 2.15.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SLING-11895) Remove SNAPSHOT dependency to sling engine

2023-06-01 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-11895:
-

 Summary: Remove SNAPSHOT dependency to sling engine
 Key: SLING-11895
 URL: https://issues.apache.org/jira/browse/SLING-11895
 Project: Sling
  Issue Type: Task
Affects Versions: Servlets Resolver 2.9.10
Reporter: Joerg Hoh
 Fix For: Servlets Resolver 2.9.12


update to Sling Engine 2.15.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)