[jira] [Resolved] (SLING-10156) Create access control entries for unknown principals

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-10156.
--
Resolution: Duplicate

this has been addressed by SLING-12115. thanks [~jsedding] :)

> Create access control entries for unknown principals
> 
>
> Key: SLING-10156
> URL: https://issues.apache.org/jira/browse/SLING-10156
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>    Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], today the JCR repo-init implementation limits creation of 
> access control content to principals known to the repository (see also 
> SLING-10134 for a related ticket wrt to removing access control entries):
> {code}
> // first try PrincipalManager.getPrincipal(String)
> Principal principal = AccessControlUtils.getPrincipal(session, name);
> if (principal == null) {
> // backwards compatibility: fallback to original code 
> treating principal name as authorizable ID (see SLING-8604)
> final Authorizable authorizable = 
> UserUtil.getAuthorizable(session, name);
> checkState(authorizable != null, "Authorizable not found:" + 
> name);
> principal = authorizable.getPrincipal();
> }
> checkState(principal != null, "Principal not found: " + name); // 
> <- here it fails if principal does not exist
> {code}
> While JCR access control API mandates that a principal must be known to the 
> repository, it is possible both with Apache Jackrabbit 2.x and in Apache 
> Jackrabbit Oak to relax that contract (see ImportBehavior.BESTEFFORT [0]). 
> The main reason for this is the fact that principals may only be installed at 
> a later stage and packaging them together with (resource-based) access 
> control isn't always feasible/desirable (see for example Jackrabbit vault 
> [1]). 
> In other words: repo-init should delegate the principal validation step (and 
> whether or not the strict JCR contract is enforced) to the repository itself.
> In Sling RepoInit this is relevant under the following circumstances:
> - cleaning up access control content when the principal no longer exists (see 
> SLING-10134)
> - setting up access control content in the initial repository initialization, 
> while principals are not yet available (maybe installed later with content 
> packages). this becomes increasingly relevant with a composite NodeStore 
> setup, where certain trees of the repository are marked as immutable and thus 
> might be initialized independently of the mutable stores (that e.g. would 
> include the group nodes). 
> NOTE: delegating the principal validation step to the repository, may also 
> require the principal-equality test in 
> https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L399
>  to be adjusted (e.g. reducing to comparing names as it is done in [2])
> [~karlpauls], [~cziegeler], fyi
> [0] 
> http://jackrabbit.apache.org/oak/docs/security/accesscontrol/default.html#xml_import
> [1] 
> https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/JackrabbitACLImporter.java
> [2] 
> https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/JackrabbitACLImporter.java#L290



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12115) Repoinit should leave enforcement of importBehaviour for ACL creation to JCR

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-12115:
-
Summary: Repoinit should leave enforcement of importBehaviour for ACL 
creation to JCR  (was: Repoinit should leave importBehaviour for ACL creation 
to JCR)

> Repoinit should leave enforcement of importBehaviour for ACL creation to JCR
> 
>
> Key: SLING-12115
> URL: https://issues.apache.org/jira/browse/SLING-12115
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.44
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Repoinit JCR 1.1.46
>
>
> JCR Repoinit checks the existence of the principal, for which ACLs should be 
> created. In an Oak repository, this check depends on the {{ImportBehaviour}} 
> configured for the {{SecurityProvider}}. JCR Repoinit should not check, but 
> instead rely on the repository's behaviour.
> cc [~angela]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735995#comment-17735995
 ] 

Angela Schreiber commented on SLING-11910:
--

[~madamcin] , yes, that's the oak side of it. the only class you missed to 
mention is 
org.apache.jackrabbit.oak.plugins.nodetype.TypeRegistration
see 
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeRegistration.java]
 for the list of validation it performs.
 
would what you found in oak address your concerns specified in you comment at 
https://issues.apache.org/jira/browse/SLING-11910?focusedCommentId=17735814=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17735814
 ?

then the repoinit implementation in jcr.repoinit could simply rely on the JCR 
repository to prevent troublesome modifications instead of trying to spot them 
itself, which it likely cannot do to the full extend the repository is actually 
able to do it.

in other words: we were back at my original suggestion to either introduce an 
optional flag 'allowUpdate' or introduce a new method. either way the repoinit 
implementation would not perform any validation but would just pass the boolean 
flag with the registration method (either on NodeTypeManagere or on the 
CND-registration from commons which calls the NodeTypeManager)

> Repoinit should support 'allowUpdate' option with node type registration
> 
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with 
> {{NodeTypeManager#registerNodeType}} and 
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that 
> specifies how to handle existing node type definitions upon registration. 
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is 
> no way to update an existing nodetype definition through RepoInit. Consumers 
> of the API need to resort to programmatically update the node type using JCR 
> API in a service.
> Here the extract from the specification (copied from 
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the 
> specified definition and returns the resulting NodeType object. Typically, 
> the object passed to this method will be a NodeTypeTemplate (a subclass of 
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and 
> then filled-in with definition information. If allowUpdate is true then an 
> attempt to change the definition of an already registered node type will be 
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to 
> register a node type with the same name as an already registered one will 
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This 
> method is used to register or update a set of node types with mutual 
> dependencies. It returns an iterator over the resulting NodeType objects. The 
> effect of the method is “all or nothing”; if an error occurs, no changes are 
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node 
> type already in use as the type of an existing node. The extent of any such 
> capability is implementation dependent. For example, some implementations may 
> permit only changes which do not invalidate existing content, while others 
> may allow larger changes. How any resulting incompatibilities are resolved is 
> also implementation dependent. Any changes to the type of an exiting node 
> must take effect in accordance with the _node type assignment behavior_ of 
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or 
> 'reregister') flag the existing {{register nodetypes}} command (default would 
> be 'false' to ensure backwards compatible behavior) or introduce a new 
> command {{{}reregister nodetypes{}}}.
>  
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional prope

[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735814#comment-17735814
 ] 

Angela Schreiber commented on SLING-11910:
--

[~madamcin] , good point. I am not entirely sure though how you would find out 
about the pure 'additive' nature of a node type definition. but as usual: feel 
free to contribute a patch, it will be welcome.

> Repoinit should support 'allowUpdate' option with node type registration
> 
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with 
> {{NodeTypeManager#registerNodeType}} and 
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that 
> specifies how to handle existing node type definitions upon registration. 
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is 
> no way to update an existing nodetype definition through RepoInit. Consumers 
> of the API need to resort to programmatically update the node type using JCR 
> API in a service.
> Here the extract from the specification (copied from 
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the 
> specified definition and returns the resulting NodeType object. Typically, 
> the object passed to this method will be a NodeTypeTemplate (a subclass of 
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and 
> then filled-in with definition information. If allowUpdate is true then an 
> attempt to change the definition of an already registered node type will be 
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to 
> register a node type with the same name as an already registered one will 
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This 
> method is used to register or update a set of node types with mutual 
> dependencies. It returns an iterator over the resulting NodeType objects. The 
> effect of the method is “all or nothing”; if an error occurs, no changes are 
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node 
> type already in use as the type of an existing node. The extent of any such 
> capability is implementation dependent. For example, some implementations may 
> permit only changes which do not invalidate existing content, while others 
> may allow larger changes. How any resulting incompatibilities are resolved is 
> also implementation dependent. Any changes to the type of an exiting node 
> must take effect in accordance with the _node type assignment behavior_ of 
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or 
> 'reregister') flag the existing {{register nodetypes}} command (default would 
> be 'false' to ensure backwards compatible behavior) or introduce a new 
> command {{{}reregister nodetypes{}}}.
>  
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional property. 
> For new repositories this works but for existing repositories the existing 
> mixin is unchanged.
> As my code requires the new property I get errors.
>  
> So I propose that repoinit allows to update existing mixins (and possibly 
> other structures).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11910:
-
Description: 
JCR node type registration as defined with {{NodeTypeManager#registerNodeType}} 
and {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that 
specifies how to handle existing node type definitions upon registration. 
However, Sling RepoInit does not support the 'allowUpdate' flag and there is no 
way to update an existing nodetype definition through RepoInit. Consumers of 
the API need to resort to programmatically update the node type using JCR API 
in a service.

Here the extract from the specification (copied from 
https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
{quote}
h3. 19.2.4 Registering a Node Type

NodeType NodeTypeManager.
registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)

registers a new node type or updates an existing node type using the specified 
definition and returns the resulting NodeType object. Typically, the object 
passed to this method will be a NodeTypeTemplate (a subclass of 
NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and 
then filled-in with definition information. If allowUpdate is true then an 
attempt to change the definition of an already registered node type will be 
made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to 
register a node type with the same name as an already registered one will fail 
immediately.

NodeTypeIterator NodeTypeManager.
registerNodeTypes(NodeTypeDefinition[] ntds,
boolean allowUpdate)

registers or updates the specified array of NodeTypeDefinition objects. This 
method is used to register or update a set of node types with mutual 
dependencies. It returns an iterator over the resulting NodeType objects. The 
effect of the method is “all or nothing”; if an error occurs, no changes are 
made.
h4. 19.2.4.1 Updating Node Types

A repository that supports node type management may support updates to a node 
type already in use as the type of an existing node. The extent of any such 
capability is implementation dependent. For example, some implementations may 
permit only changes which do not invalidate existing content, while others may 
allow larger changes. How any resulting incompatibilities are resolved is also 
implementation dependent. Any changes to the type of an exiting node must take 
effect in accordance with the _node type assignment behavior_ of the repository 
(see §10.10.1 {_}Node Type Assignment Behavior{_}).
{quote}
We would therefore suggestion to either add an optional 'allowUpdate' (or 
'reregister') flag the existing {{register nodetypes}} command (default would 
be 'false' to ensure backwards compatible behavior) or introduce a new command 
{{{}reregister nodetypes{}}}.

 

Original use case from [~cschneider]:

My use case is to extend an existing mixin with an additional property. 
For new repositories this works but for existing repositories the existing 
mixin is unchanged.
As my code requires the new property I get errors.

 

So I propose that repoinit allows to update existing mixins (and possibly other 
structures).

  was:
My use case is to extend an existing mixin with an additional property. 
For new repositories this works but for existing repositories the existing 
mixin is unchanged.
As my code requires the new property I get errors.

 

So I propose that repoinit allows to update existing mixins (and possibly other 
structures).


> Repoinit should support 'allowUpdate' option with node type registration
> 
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with 
> {{NodeTypeManager#registerNodeType}} and 
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that 
> specifies how to handle existing node type definitions upon registration. 
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is 
> no way to update an existing nodetype definition through RepoInit. Consumers 
> of the API need to resort to programmatically update the node type using JCR 
> API in a service.
> Here the extract from the specification (copied from 
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an 

[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735271#comment-17735271
 ] 

Angela Schreiber commented on SLING-11910:
--

hi [~cschneider], i slightly adjusted the summary to capture the generic 
request. your need to have a mixin type definition updated is one example. but 
the same would apply for regular node types.

> Repoinit should support 'allowUpdate' option with node type registration
> 
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> My use case is to extend an existing mixin with an additional property. 
> For new repositories this works but for existing repositories the existing 
> mixin is unchanged.
> As my code requires the new property I get errors.
>  
> So I propose that repoinit allows to update existing mixins (and possibly 
> other structures).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11910:
-
Summary: Repoinit should support 'allowUpdate' option with node type 
registration  (was: Repoinit should apply changes to existing mixins)

> Repoinit should support 'allowUpdate' option with node type registration
> 
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> My use case is to extend an existing mixin with an additional property. 
> For new repositories this works but for existing repositories the existing 
> mixin is unchanged.
> As my code requires the new property I get errors.
>  
> So I propose that repoinit allows to update existing mixins (and possibly 
> other structures).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Servlets Resolver 2.9.12

[Angela Schreiber]

+1

angela


From: Jörg Hoh 
Sent: Thursday, June 1, 2023 11:38
To: Sling Developers List 
Subject: [VOTE] Release Servlets Resolver 2.9.12

Hi,

We solved 3 issues in this
release:https://issues.apache.org/jira/projects/SLING/versions/12352611

Staging 
repository:https://repository.apache.org/content/repositories/orgapachesling-2754

You can use this UNIX script to download the release and verify the
signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
Usage:
sh check_staged_release.sh 2754 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.



--
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh

[jira] [Commented] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719861#comment-17719861
 ] 

Angela Schreiber commented on SLING-11482:
--

see also SLING-11567

> Redundant checks for null
> -
>
> Key: SLING-11482
> URL: https://issues.apache.org/jira/browse/SLING-11482
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>  Labels: regression
> Fix For: JCR Resource 3.2.2
>
>  Time Spent: 2h 32m
>  Remaining Estimate: 0h
>
> https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
>  reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11482:
-
Labels: regression  (was: )

> Redundant checks for null
> -
>
> Key: SLING-11482
> URL: https://issues.apache.org/jira/browse/SLING-11482
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>  Labels: regression
> Fix For: JCR Resource 3.2.2
>
>  Time Spent: 2h 32m
>  Remaining Estimate: 0h
>
> https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
>  reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11750:
-
Affects Version/s: Content-Package to Feature Model Converter 1.3.2

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.2
>Reporter: Konrad Windszus
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.4
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11750:
-
Affects Version/s: (was: Content-Package to Feature Model Converter 
1.3.0)

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.4
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11750:
-
Affects Version/s: Content-Package to Feature Model Converter 1.3.0
   (was: Content-Package to Feature Model Converter 
1.1.20)

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Konrad Windszus
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.4
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11750:
-
Affects Version/s: Content-Package to Feature Model Converter 1.1.20

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.20
>Reporter: Konrad Windszus
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.4
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-11750.
--
Resolution: Fixed

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.4
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719327#comment-17719327
 ] 

Angela Schreiber commented on SLING-11750:
--

also 'addMixin' and 'removeMixin' are new statements and not covered by the 
converter so far.

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719327#comment-17719327
 ] 

Angela Schreiber edited comment on SLING-11750 at 5/4/23 1:32 PM:
--

also 'addMixin' and 'removeMixin' are new statements and not covered by the 
converter so far.
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/167


was (Author: anchela):
also 'addMixin' and 'removeMixin' are new statements and not covered by the 
converter so far.

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11750) Support the new repoinit statements

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11750:
-
Summary: Support the new repoinit statements  (was: Support the new 
repoinit statements "enforce principal ACL" and "enforce nodes")

> Support the new repoinit statements
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-10243) Extract Sling-Initial-Content from bundles and put into dedicated packages

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-10243:
-
Labels: regression  (was: )

> Extract Sling-Initial-Content from bundles and put into dedicated packages
> --
>
> Key: SLING-10243
> URL: https://issues.apache.org/jira/browse/SLING-10243
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Labels: regression
> Fix For: Content-Package to Feature Model Converter 1.1.0
>
>
> As described in 
> https://lists.apache.org/thread.html/r1162d545922381187a0530f838b684b60f2a8ea28a12649ae79372e8%40%3Cdev.sling.apache.org%3E
>  Sling-Initial-Content leads to ERRORs when used with Oak Composite Node 
> Store, as those are evaluated during each bundle start. At times when that 
> part of the repo is read-only an ERROR is logged.
> The following steps are necessary:
> # Check manifest from bundle for header {{Sling-Initial-Content}}
> # For all entry paths in the header split up by mutable/immutable and create 
> a content package for each category
> # Modify manifest to no longer include {{Sling-Initial-Content}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11855) Conversion of old factory config names to new one is not checking for tilde

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11855:
-
Labels:   (was: regression)

> Conversion of old factory config names to new one is not checking for tilde
> ---
>
> Key: SLING-11855
> URL: https://issues.apache.org/jira/browse/SLING-11855
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> The code in 
> AbstractConfigurationEntryHandler#extractId converts an old factory 
> configuration name into a new one (with a tilde). Unfortunately it only 
> checks for a dash but not a tilde, which means in the case of
> factory~a-b this is converted to factory~a~b instead of keeping it as 
> factory~a-b
>  
> A similar bug might lurk in other places dealing with factory configurations



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11855) Conversion of old factory config names to new one is not checking for tilde

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11855:
-
Labels: regression  (was: )

> Conversion of old factory config names to new one is not checking for tilde
> ---
>
> Key: SLING-11855
> URL: https://issues.apache.org/jira/browse/SLING-11855
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
>  Labels: regression
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> The code in 
> AbstractConfigurationEntryHandler#extractId converts an old factory 
> configuration name into a new one (with a tilde). Unfortunately it only 
> checks for a dash but not a tilde, which means in the case of
> factory~a-b this is converted to factory~a~b instead of keeping it as 
> factory~a-b
>  
> A similar bug might lurk in other places dealing with factory configurations



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-10168) Migrate to Bundle Parent 41 and OSGi annotations

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-10168:
-
Labels: regression  (was: )

> Migrate to Bundle Parent 41 and OSGi annotations
> 
>
> Key: SLING-10168
> URL: https://issues.apache.org/jira/browse/SLING-10168
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Resource Merger 1.3.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>  Labels: regression
> Fix For: Resource Merger 1.4.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11112) Regression in content loader : Diffent behaviour when initial content is missing

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-2:
-
Labels: regression  (was: )

> Regression in content loader : Diffent behaviour when initial content is 
> missing
> 
>
> Key: SLING-2
> URL: https://issues.apache.org/jira/browse/SLING-2
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR ContentLoader 2.5.0
>Reporter: Carsten Ziegeler
>Priority: Blocker
>  Labels: regression
> Fix For: JCR ContentLoader 2.6.2
>
>
> With a bundle that does not have SLING-INF and the following initial content 
> instruction:
> SLING-INF/content;path:=/libs/foo/bar;overwrite:=true;
> it seems that prior versions handled this case differently and did not touch 
> /libs/foo/bar while the new behaviour removes all child nodes of /libs/foo/bar



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10

[Angela Schreiber]

+1
angela


From: Daniel Klco 
Sent: Wednesday, May 3, 2023 22:04
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12353195
https://issues.apache.org/jira/projects/SLING/versions/12353051

There are still some outstanding issues:
https://issues.apache.org/jira/projects/SLING/versions/12344634
https://issues.apache.org/jira/projects/SLING/versions/12353196

Staging repositories:
https://repository.apache.org/content/repositories/orgapachesling-2740/
https://repository.apache.org/content/repositories/orgapachesling-2741/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2740 /tmp/sling-staging
sh check_staged_release.sh 2741 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Servlet Helpers 1.4.6, Testing JCR Mock 1.6.8, Testing Sling Mock 3.4.6

[Angela Schreiber]

+1

kind regards
angela


From: Eric Norman 
Sent: Monday, April 24, 2023 02:28
To: Sling Developers List 
Subject: [VOTE] Release Apache Sling Servlet Helpers 1.4.6, Testing JCR Mock 
1.6.8, Testing Sling Mock 3.4.6

Hi,

We solved 1 issues in the "Servlet Helpers" release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352982

We solved 3 issues in the "Testing JCR Mock" release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12353040

We solved 2 issues in the "Testing Sling Mock" release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12353032


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2737/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2737 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Rewriter version 1.3.6

[Angela Schreiber]

+1

kind regards
angela


From: Daniel Klco 
Sent: Monday, April 24, 2023 16:29
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Rewriter version 1.3.6

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12352348

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2738/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2738 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling XSS Protection API 2.3.6

[Angela Schreiber]

+1

kind regards
angela

From: Robert Munteanu 
Sent: Wednesday, April 5, 2023 15:48
To: Sling Developers List 
Subject: [VOTE] Release Apache Sling XSS Protection API 2.3.6

EXTERNAL: Use caution when clicking on links or opening attachments.


Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352855

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2736/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2736 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[RESULT][VOTE] Release Apache Sling JCR Base 3.1.14

[Angela Schreiber]

hi sling devs

the vote received the following +1 and no object and i completed the release 
process as announced in the previous email.

  *   Carsten Ziegeler
  *   Radu Cotescu
  *   Angela Schreiber

kind regards
angela

[jira] [Closed] (SLING-11818) Update to Sling Parent POM 48 broke api generation

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber closed SLING-11818.


> Update to Sling Parent POM 48 broke api generation
> --
>
> Key: SLING-11818
> URL: https://issues.apache.org/jira/browse/SLING-11818
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 3.1.12
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: JCR Base 3.1.14
>
>
> This commit 
> [https://github.com/apache/sling-org-apache-sling-jcr-base/commit/97ea7f527040b1bcb0f7f9888a4c599ca91f58cb]
>  added a buggy dependency management section to the pom without any versions. 
> This confuses other tools like the slingfeature maven plugin.
> The whole dependency management section is not needed and can simply be 
> removed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling JCR Base 3.1.14

[Angela Schreiber]

hi sling devs

so far we got the following +1 votes:

  *   Carsten Ziegeler
  *   Radu Cotescu
  *   Angela Schreiber

since this release only contains a fix in the pom.xml and we need to get a 
functioning release out for CVE-2023-25141, i am going to cut the release vote 
short and push out the release.

kind regards
angela



From: Radu Cotescu 
Sent: Tuesday, April 4, 2023 18:24
To: Sling Dev 
Subject: Re: [VOTE] Release Apache Sling JCR Base 3.1.14

EXTERNAL: Use caution when clicking on links or opening attachments.


+1

> On 4 Apr 2023, at 16:04, Angela Schreiber  wrote:
>
> Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling JCR Base 3.1.14

[Angela Schreiber]

[x] +1 Approve the release

kind regards
angela

From: Angela Schreiber 
Sent: Tuesday, April 4, 2023 16:04
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling JCR Base 3.1.14

Hi

We fixed the following issues in this release:

https://issues.apache.org/jira/projects/SLING/versions/12352926

Staging repository:

https://repository.apache.org/content/repositories/orgapachesling-2735/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2735 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Kind regards
Angela

[VOTE] Release Apache Sling JCR Base 3.1.14

[Angela Schreiber]

Hi

We fixed the following issues in this release:

https://issues.apache.org/jira/projects/SLING/versions/12352926

Staging repository:

https://repository.apache.org/content/repositories/orgapachesling-2735/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2735 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Kind regards
Angela

[jira] [Commented] (SLING-10321) Deprecate service mapping by userID

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705872#comment-17705872
 ] 

Angela Schreiber commented on SLING-10321:
--

hi [~friendlymahi], the service resource resolver/session created from the new 
mapping format 'service:subservice:[servicePrincipal1, ...]' will have a java 
Subject associated that only contains the specified service user principals. no 
group membership is being resolved.

if you have added any of these service users to a group the permissions of 
these groups will no longer be inherited upon repository login. if you 
evaluated group membership manually using user management API you would still 
be able to see it but as i mentioned i would move away from group 
membership for service users and instead replace it with an aggregation of 
service users such that your code can rely on effective permissions not on 
group membership.

> Deprecate service mapping by userID
> ---
>
> Key: SLING-10321
> URL: https://issues.apache.org/jira/browse/SLING-10321
> Project: Sling
>  Issue Type: Improvement
>  Components: Service User Mapper
>Affects Versions: Service User Mapper 1.5.2
>Reporter: Angela Schreiber
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: Service User Mapper 1.5.4
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> [~cziegeler], [~kpauls], for security reasons I would like to deprecate the 
> old service user mapping by a single userID in favor of the new format that 
> takes one or multiple principal names.
> The new format allows to keep service permissions limited to service-users as 
> declared in the mapping and doesn't resolve declare or inherited group 
> permissions. This gives full control over the effective permissions granted 
> to each service and doesn't risk unrelated permission changes (e.g. to a base 
> group like 'everyone') impacting service security.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Resource Collections version 1.0.4

[Angela Schreiber]

+1

kind regards
angela


From: Daniel Klco 
Sent: Saturday, March 11, 2023 18:14
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Resource Collections version 1.0.4



Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12345007

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2724/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2724 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Resource Merger 1.4.2

[Angela Schreiber]

+1

thanks a lot and kind regards
angela


From: Radu Cotescu 
Sent: Monday, March 13, 2023 18:07
To: Sling Developers List 
Subject: [VOTE] Release Apache Sling Resource Merger 1.4.2



Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12350636

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2725/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2725 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Radu Cotescu

[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698235#comment-17698235
 ] 

Angela Schreiber commented on SLING-10110:
--

[~SonglessHill], i don't know but since [~joerghoh] stated above:

{quote}
I will take care of the merge and also trigger a release.
{quote}

maybe a gentle nudge will do the trick ;-). [~joerghoh], wdty?

> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a 
> general problem.
> The issue i am facing is that in my dispatcher configuration there are 
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a 
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match 
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under 
> the ignoreUrlParams it does not see the above parameter from the url as 
> matching for ignoreUrlParams.
>  
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and 
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if 
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was 
> configured to ignore this parameter, the response will be cached with an 
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not 
> clear enough please tell me and i will try to update everything that is needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-10110.
--
Resolution: Fixed

resolving ticket as PR provided by [~SonglessHill] has been merged. thanks for 
the contribution!

> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a 
> general problem.
> The issue i am facing is that in my dispatcher configuration there are 
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a 
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match 
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under 
> the ignoreUrlParams it does not see the above parameter from the url as 
> matching for ignoreUrlParams.
>  
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and 
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if 
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was 
> configured to ignore this parameter, the response will be cached with an 
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not 
> clear enough please tell me and i will try to update everything that is needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698229#comment-17698229
 ] 

Angela Schreiber commented on SLING-10110:
--

[~SonglessHill], what i meant was: I added you to 'contributors' group and you 
should be able to assign tickets to yourself not that the ticket is fixed 
yet. sorry for the confusion.

but i quickly checked: your PR 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26 has 
been merged. i am resolving this ticket as fixed. feel free to verify again 
once the release is out.


> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a 
> general problem.
> The issue i am facing is that in my dispatcher configuration there are 
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a 
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match 
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under 
> the ignoreUrlParams it does not see the above parameter from the url as 
> matching for ignoreUrlParams.
>  
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and 
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if 
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was 
> configured to ignore this parameter, the response will be cached with an 
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not 
> clear enough please tell me and i will try to update everything that is needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Testing JCR Mock version 1.6.4

[Angela Schreiber]

+1

kind regards
angela


From: Eric Norman 
Sent: Friday, March 3, 2023 01:03
To: Sling Developers List 
Subject: [VOTE] Release Apache Sling Testing JCR Mock version 1.6.4


Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352963

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2721/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2721 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[jira] [Commented] (SLING-11782) Document Sling threat model and how to properly secure Sling

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696424#comment-17696424
 ] 

Angela Schreiber commented on SLING-11782:
--

[~rombert], count me in!

as far as methodology is concerned the authorization best practices in the oak 
documentation contain a couple of links: 
https://jackrabbit.apache.org/oak/docs/security/authorization/bestpractices.html#Threat_Model

hope that helps us to get started.

> Document Sling threat model and how to properly secure Sling
> 
>
> Key: SLING-11782
> URL: https://issues.apache.org/jira/browse/SLING-11782
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation, Site
>    Reporter: Angela Schreiber
>Priority: Major
>  Labels: security
>
> The documentation should be more explicit about to run sling in a secure way. 
> In particular we should provide some information about the underlying threat 
> model. 
> For example we should be being explicit about the fact that whoever has 
> access to the OSGi console has file system access with the privileges of the 
> JRE.
> cc: [~rombert], [~cziegeler]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Engine 2.14.0

[Angela Schreiber]

+1

kind regards
angela


From: Carsten Ziegeler 
Sent: Tuesday, February 21, 2023 14:36
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Engine 2.14.0

Hi,

We solved 4 issues in this release
https://issues.apache.org/jira/projects/SLING/versions/12352612

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2719

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2719 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

[jira] [Created] (SLING-11782) Document Sling threat model and how to properly secure Sling

[Angela Schreiber (Jira)]

Angela Schreiber created SLING-11782:


 Summary: Document Sling threat model and how to properly secure 
Sling
 Key: SLING-11782
 URL: https://issues.apache.org/jira/browse/SLING-11782
 Project: Sling
  Issue Type: Improvement
  Components: Documentation, Site
Reporter: Angela Schreiber


The documentation should be more explicit about to run sling in a secure way. 
In particular we should provide some information about the underlying threat 
model. 

For example we should be being explicit about the fact that whoever has access 
to the OSGi console has file system access with the privileges of the JRE.

cc: [~rombert], [~cziegeler]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling i18n 2.6.2

[Angela Schreiber]

+1

kind regards
angela


From: Carsten Ziegeler 
Sent: Wednesday, February 15, 2023 10:04
To: dev@sling.apache.org 
Subject: Re: [VOTE] Release Apache Sling i18n 2.6.2


+1

Carsten

Am 15.02.2023 um 07:54 schrieb Carsten Ziegeler:
> Hi,
>
> We solved 3 issues in this release
> https://issues.apache.org/jira/projects/SLING/versions/12350841
>
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2718
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2718 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten

--
Carsten Ziegeler
Adobe
cziege...@apache.org

CVE-2023-25141: JNDI injection into Apache sling-org-apache-sling-jcr-base

[Angela Schreiber]

Severity: critical

Description:

Apache Sling JCR Base < 3.1.12 has a critical injection vulnerability when 
running on old JDK versions (JDK 1.8.191 or earlier) through utility functions 
in RepositoryAccessor. The functions getRepository and getRepositoryFromURL 
allow an application to access data stored in a remote location via JDNI and 
RMI.




Users of Apache Sling JCR Base are recommended to upgrade to Apache Sling JCR 
Base 3.1.12 or later, or to run on a more recent JDK.

Credit:

Xun Bai from LJQC Open Source Security Institute  (reporter)

References:

https://sling.apache.org/news.html
https://sling.apache.org/
https://www.cve.org/CVERecord?id=CVE-2023-25141

[jira] [Closed] (SLING-11770) Cleanup in sling-jcr-base

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber closed SLING-11770.


> Cleanup in sling-jcr-base
> -
>
> Key: SLING-11770
> URL: https://issues.apache.org/jira/browse/SLING-11770
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Base 3.1.12
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> imo the sling-jcr-base module would benefit from a bit of cleanup.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling JCR Base 3.1.12

[Angela Schreiber]

Hi,

The vote has passed with the following result:

+1 (binding): Carsten Ziegeler, Robert Munteanu, Karl Pauls, Angela Schreiber

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Kind regards
Angela


From: Karl Pauls 
Sent: Thursday, February 9, 2023 12:10
To: dev@sling.apache.org 
Subject: Re: [VOTE] Release Apache Sling JCR Base 3.1.12


+1

regards,

Karl

On Thu, Feb 9, 2023 at 11:42 AM Robert Munteanu  wrote:

> On Thu, 2023-02-09 at 08:36 +0100, ang...@apache.org wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>


--
Karl Pauls
karlpa...@gmail.com

[jira] [Resolved] (SLING-11770) Cleanup in sling-jcr-base

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-11770.
--
Resolution: Fixed

> Cleanup in sling-jcr-base
> -
>
> Key: SLING-11770
> URL: https://issues.apache.org/jira/browse/SLING-11770
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Base 3.1.12
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> imo the sling-jcr-base module would benefit from a bit of cleanup.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Feature Model Diff Tool 0.1.0, Apache Sling Content-Package to Feature Model Converter 1.3.0, Apache Sling JCR ContentLoader 2.6.0, Apache Sling Feature Model 2.0.0, Ap

[Angela Schreiber]

hi robert

[x] +1 Approve the release

kind regards
angela



From: Robert Munteanu 
Sent: Wednesday, February 8, 2023 16:07
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Feature Model Diff Tool 0.1.0, Apache 
Sling Content-Package to Feature Model Converter 1.3.0, Apache Sling JCR 
ContentLoader 2.6.0, Apache Sling Feature Model 2.0.0, Apache Sling Feature 
Model Analyser 2.0.0, Apache Sling Fe...


Hi,

We solved 8 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12346860
https://issues.apache.org/jira/browse/SLING/fixforversion/12352569
https://issues.apache.org/jira/browse/SLING/fixforversion/12351460
https://issues.apache.org/jira/browse/SLING/fixforversion/12352648
https://issues.apache.org/jira/browse/SLING/fixforversion/12352327
https://issues.apache.org/jira/browse/SLING/fixforversion/12352649
https://issues.apache.org/jira/browse/SLING/fixforversion/12352727

Staging repositories
https://repository.apache.org/content/repositories/orgapachesling-2714/
https://repository.apache.org/content/repositories/orgapachesling-2715

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2714 /tmp/sling-staging
sh check_staged_release.sh 2715 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Created] (SLING-11770) Cleanup in sling-jcr-base

[Angela Schreiber (Jira)]

Angela Schreiber created SLING-11770:


 Summary: Cleanup in sling-jcr-base
 Key: SLING-11770
 URL: https://issues.apache.org/jira/browse/SLING-11770
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Reporter: Angela Schreiber
Assignee: Angela Schreiber
 Fix For: JCR Base 3.1.12


imo the sling-jcr-base module would benefit from a bit of cleanup.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11750) Support the new repoinit statements "enforce principal ACL" and "enforce nodes"

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685909#comment-17685909
 ] 

Angela Schreiber commented on SLING-11750:
--

hi [~rombert], the cp-converter comes with it's own visitors that are used to 
converter resource-based to principal-based. so those visitors need to be 
adjusted to cover the new methods otherwise the unsupported-operation-exception 
from the default (i assume exists) will kick in.

we had that in the past and i want to avoid us running in the same issue again.
but other than that i don't believe the new methods require any special 
handling.

hope that helps

> Support the new repoinit statements "enforce principal ACL" and "enforce 
> nodes"
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.0
>
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling App CMS version 1.1.6

[Angela Schreiber]

+1

kind regards
angela


From: Daniel Klco 
Sent: Tuesday, January 31, 2023 16:14
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling App CMS version 1.1.6

Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12352773

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2713/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2713 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Repoinit Parser version 1.9.0, Repoinit JCR 1.1.44 and Repoinit FileVault Validator 1.0.0

[Angela Schreiber]

+1

kind regards
angela


From: Konrad Windszus 
Sent: Wednesday, January 25, 2023 20:47
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Repoinit Parser version 1.9.0, Repoinit 
JCR 1.1.44 and Repoinit FileVault Validator 1.0.0


Hi,

 We solved some issues in these releases:

Repoinit Parser 1.9.0: 
https://issues.apache.org/jira/projects/SLING/versions/12352326
Repoinit JCR 1.1.44: 
https://issues.apache.org/jira/projects/SLING/versions/12352325
Repoinit FileVault Validator 1.0.0: 
https://issues.apache.org/jira/projects/SLING/versions/12352851

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2711/
You can use this UNIX script to download the release and verify the signatures: 
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage: sh check_staged_release.sh 2711 /tmp/sling-staging

Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because …

This majority vote is open for at least 72 hours.

Thanks in advance for voting,
Konrad

[jira] [Assigned] (SLING-11749) resource resolver: document URL patterns in vanity paths and add test coverage

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-11749:


Assignee: Julian Reschke

> resource resolver: document URL patterns in vanity paths and add test coverage
> --
>
> Key: SLING-11749
> URL: https://issues.apache.org/jira/browse/SLING-11749
> Project: Sling
>  Issue Type: Task
>  Components: ResourceResolver
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> MapEntries (in "private String[] getVanityPathDefinition(final String 
> pVanityPath)") currently attempts to detect URL-shaped paths, and rewrite 
> them to a prefix.
> There are several issues here:
> 1. there doesn't seem to be any concrete documentation about this
> 2. apparently there is no test coverage - removing that code causes no test 
> failures
> 3. it's unclear whether not replacing an empty string by "/" is intentional



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11755) resource resolver: add test coverage for URL patterns in vanity paths

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-11755:


Assignee: Julian Reschke

> resource resolver: add test coverage for URL patterns in vanity paths
> -
>
> Key: SLING-11755
> URL: https://issues.apache.org/jira/browse/SLING-11755
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: Resource Resolver 1.10.2
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11757) resource resolver: pathless URL in vanity path causes NPE in ResourceMapperImpl.apply()

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-11757:


Assignee: Julian Reschke

> resource resolver: pathless URL in vanity path causes NPE in 
> ResourceMapperImpl.apply()
> ---
>
> Key: SLING-11757
> URL: https://issues.apache.org/jira/browse/SLING-11757
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> {noformat}
> java.lang.NullPointerException
> at java.lang.String.concat(String.java:2027)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:371)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:345)
> at java.util.ArrayList.replaceAll(ArrayList.java:1452)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:171)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest$ExpectedMappings.verify(ResourceMapperImplTest.java:510)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest.mapResourceWithVanityPathsURLTargetNoPath(ResourceMapperImplTest.java:402)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11756) resource resolver: rewrite getVanityPathDefinition for more clarity

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-11756:


Assignee: Julian Reschke

> resource resolver: rewrite getVanityPathDefinition for more clarity 
> 
>
> Key: SLING-11756
> URL: https://issues.apache.org/jira/browse/SLING-11756
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: Resource Resolver 1.10.2
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11757) resource resolver: pathless URL in vanity path causes NPE in ResourceMapperImpl.apply()

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680691#comment-17680691
 ] 

Angela Schreiber commented on SLING-11757:
--

hi [~reschke] , thanks a lot for the investigation... overall direction makes 
sense to me. may i added one more suggestion? i would strongly recommend to 
consistently add NotNull and Nullable annotations to the code as it really 
helps avoiding this kind of bugs.

> resource resolver: pathless URL in vanity path causes NPE in 
> ResourceMapperImpl.apply()
> ---
>
> Key: SLING-11757
> URL: https://issues.apache.org/jira/browse/SLING-11757
> Project: Sling
>  Issue Type: Sub-task
>  Components: ResourceResolver
>Reporter: Julian Reschke
>Priority: Major
>
> {noformat}
> java.lang.NullPointerException
> at java.lang.String.concat(String.java:2027)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:371)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:345)
> at java.util.ArrayList.replaceAll(ArrayList.java:1452)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:171)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest$ExpectedMappings.verify(ResourceMapperImplTest.java:510)
> at 
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest.mapResourceWithVanityPathsURLTargetNoPath(ResourceMapperImplTest.java:402)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11750) Support the new repoinit statements "enforce principal ACL" and "enforce nodes"

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17675859#comment-17675859
 ] 

Angela Schreiber commented on SLING-11750:
--

[~kwin], thanks for creating the ticket, really appreciated. afaik cp2fm does 
actually parse repoinit statements (not only generates them).

> Support the new repoinit statements "enforce principal ACL" and "enforce 
> nodes"
> ---
>
> Key: SLING-11750
> URL: https://issues.apache.org/jira/browse/SLING-11750
> Project: Sling
>  Issue Type: New Feature
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
>
> With SLING-11736 and SLING-10281 new statements have been introduced. Those 
> should be supported in cp2fm as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Testing Rules 2.0.2

[Angela Schreiber]

+1

kind regards
angela


From: Jörg Hoh 
Sent: Wednesday, January 11, 2023 11:59
To: Sling Developers List 
Subject: Re: [VOTE] Release Apache Sling Testing Rules 2.0.2



my +1

Am Mi., 11. Jan. 2023 um 11:58 Uhr schrieb Jörg Hoh :

>
> Hi,
>
> We solved 2 issues in this 
> release:https://issues.apache.org/jira/projects/SLING/versions/12348059
>
> Staging 
> repository:https://repository.apache.org/content/repositories/orgapachesling-2709/
>
> You can use this UNIX script to download the release and verify the 
> signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2709 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
>
> --
> Cheers,
> Jörg Hoh,
>
> https://cqdump.joerghoh.de
> Twitter: @joerghoh
>


--
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh

[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646580#comment-17646580
 ] 

Angela Schreiber commented on SLING-10110:
--

[~SonglessHill], should be ok now.

> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a 
> general problem.
> The issue i am facing is that in my dispatcher configuration there are 
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a 
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match 
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under 
> the ignoreUrlParams it does not see the above parameter from the url as 
> matching for ignoreUrlParams.
>  
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and 
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if 
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was 
> configured to ignore this parameter, the response will be cached with an 
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not 
> clear enough please tell me and i will try to update everything that is needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-10110:


Assignee: Andreas Bannasch

> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a 
> general problem.
> The issue i am facing is that in my dispatcher configuration there are 
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a 
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match 
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under 
> the ignoreUrlParams it does not see the above parameter from the url as 
> matching for ignoreUrlParams.
>  
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and 
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if 
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was 
> configured to ignore this parameter, the response will be cached with an 
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not 
> clear enough please tell me and i will try to update everything that is needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11723) Expose more authentication information from ResourceResolver

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646528#comment-17646528
 ] 

Angela Schreiber commented on SLING-11723:
--

for the JCR specific pieces i believe it should be possible to adapt the 
resource resolver to a jcr session and use the bound principals attribute that 
you have added lately (see 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java#L287-L289).

> Expose more authentication information from ResourceResolver
> 
>
> Key: SLING-11723
> URL: https://issues.apache.org/jira/browse/SLING-11723
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently ResourceResolver only exposes the {{getUserID()}} for debugging 
> authorization related issues. With the addition of SLING-6963 it would be 
> helpful to additionally expose:
> - if a resource resolver is a service resource resolver (applies to all 
> providers)
> - if it is based on principal names or regular authorizable ids (JCR provider 
> specific, although the configuration format is agnostic)
> This information is crucial to figure out why a particular resource cannot be 
> resolved (due to missing permissions).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Engine 2.13.2

[Angela Schreiber]

+1
angela


From: Radu Cotescu 
Sent: Friday, December 9, 2022 11:15
To: Sling Developers List 
Subject: [VOTE] Release Apache Sling Engine 2.13.2



Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352612

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2705/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2705 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Radu Cotescu

Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2

[Angela Schreiber]

+1
angela

From: Radu Cotescu 
Sent: Friday, December 9, 2022 11:15
To: Sling Developers List 
Subject: [VOTE] Release Apache Sling Scripting JSP 2.6.2

EXTERNAL: Use caution when clicking on links or opening attachments.


Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352657

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2706/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2706 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Radu Cotescu

Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8

[Angela Schreiber]

[x] +1 Approve the release

kind regards
angela


From: Carsten Ziegeler 
Sent: Tuesday, December 6, 2022 15:15
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8



Hi,

We solved 1 issue in this release
https://issues.apache.org/jira/browse/SLING-11620


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2704

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2704 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature Extensions Apiregions 1.6.4

[Angela Schreiber]

[x] +1 Approve the release

kind regards
angela


From: Carsten Ziegeler 
Sent: Tuesday, December 6, 2022 06:33
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature 
Extensions Apiregions 1.6.4


Hi,

we solved 11 issues for the launcher
https://issues.apache.org/jira/projects/SLING/versions/12351353

and 2 issues for the apiregions extension
https://issues.apache.org/jira/projects/SLING/versions/12352068

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2703

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2703 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

Re: Principal names used in org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl and "everyone" group

[Angela Schreiber]

hi konrad,

yes, you are right. when using the format with [], the resulting resource 
resolver / session will get a subject that aggregates the specified principals 
and only those.

adding a group principal name will only work if you disable the 
JcrSystemUserValidator.
but from a security point of view i would not recommend this. system users and 
their permissions should IMHO be considered part of the application, while 
permissions of groups like everyone may change independent of the code that 
delegates tasks to a system-sessions. this opens the door for privilege 
escalations.

hope that helps
angela



From: Konrad Windszus 
Sent: Monday, December 5, 2022 10:58
To: dev@sling.apache.org 
Subject: Re: Principal names used in 
org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl and "everyone" 
group

EXTERNAL: Use caution when clicking on links or opening attachments.


To answer my own question: Even the "everyone" group membership is not 
considered (if not explicitly added as principal name to the config).
Konrad

On 2022/12/02 19:01:57 Konrad Windszus wrote:
> Hi,
> With https://issues.apache.org/jira/browse/SLING-6963 
>  the support for principal 
> names has been added to the Service User Mapper.
> That in general does not consider group memberships.
> What about the special group “everyone” 
> (https://jackrabbit.apache.org/oak/docs/security/user/membership.html#everyone-group-and-everyone-as-member
>  
> ).
>  Are the rights inherited in this case?
>
> I have seen weird effects were the rights are only inherited sometimes…
>
> Thanks for clarification.
> Konrad

[jira] [Commented] (SLING-11467) support to update existing paths via repoinit statement

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643384#comment-17643384
 ] 

Angela Schreiber commented on SLING-11467:
--

if this improvement is adopted i would suggest to use a similar solution than 
exists for user/group creation that allows to make sure the specified 
intermediate path is really used (and not ignored if the user/group already 
exists) with a 'forced' key word (see 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/main/javacc/RepoInitGrammar.jjt#L103).

> support to update existing paths via repoinit statement
> ---
>
> Key: SLING-11467
> URL: https://issues.apache.org/jira/browse/SLING-11467
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Darshan Mahor
>Priority: Major
>
> As of now we can't update the path if it already exists in repository[1] via 
> repoinit statements like update primary type etc. This request is to support 
> the mechanism via which we can modify/update the existing paths with the 
> update/modification provided in repoinit statement. e.g. lets suppose we have 
> a path in repostiory  /content/test/testchild(nt:folder) and we want to 
> modify it to /content/test/testchild(sling:Folder).
>  
> [1]. 
> [https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java#L189]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11467) support to update existing paths via repoinit statement

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642398#comment-17642398
 ] 

Angela Schreiber commented on SLING-11467:
--

[~kwin], no worries, it does work :-). i was about to reply to [~joerghoh] and 
you were just faster there is no need to move around stuff and recreate or 
remove.

[~joerghoh], is right though that this operation may fail if the new node type 
comes with additional/different constraints that are not automatically 
adjusted. so far repo-init doesn't provide any notion of best-effort and if an 
operation fails the whole repo-init fails which leads to abortion of repository 
startup.
on the other hand one might argue that the customer of the repoinit has the 
ability to try it out and eventually fix the script if it doesn't work. i guess 
i most cases the changes wold be simple and doable.

> support to update existing paths via repoinit statement
> ---
>
> Key: SLING-11467
> URL: https://issues.apache.org/jira/browse/SLING-11467
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Darshan Mahor
>Priority: Major
>
> As of now we can't update the path if it already exists in repository[1] via 
> repoinit statements like update primary type etc. This request is to support 
> the mechanism via which we can modify/update the existing paths with the 
> update/modification provided in repoinit statement. e.g. lets suppose we have 
> a path in repostiory  /content/test/testchild(nt:folder) and we want to 
> modify it to /content/test/testchild(sling:Folder).
>  
> [1]. 
> [https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java#L189]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [Vote] Release Sling Models Impl 1.5.4

[Angela Schreiber]

hi joerg

[x] +1 Approve the release

kind regards
angela

From: Jörg Hoh 
Sent: Tuesday, November 22, 2022 10:36
To: Sling Developers List 
Subject: Re: [Vote] Release Sling Models Impl 1.5.4

EXTERNAL: Use caution when clicking on links or opening attachments.


my +1

Am Di., 22. Nov. 2022 um 10:34 Uhr schrieb Jörg Hoh :

> Hi,
>
> We solved 1 issue in this 
> release:https://issues.apache.org/jira/projects/SLING/versions/12351664
>
>
> Staging 
> repository:https://repository.apache.org/content/repositories/orgapachesling-2696/
>
> You can use this UNIX script to download the release and verify the 
> signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2696 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
>
>
> --
> Cheers,
> Jörg Hoh,
>
> https://cqdump.joerghoh.de
> Twitter: @joerghoh
>


--
Cheers,
Jörg Hoh,

https://cqdump.joerghoh.de
Twitter: @joerghoh

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.24

[Angela Schreiber]

Hi,

The vote has passed with the following result :

+1 (binding): Robert Munteanu, Carsten Ziegeler, David Bosschaert, Karl Pauls, 
Dan Klco, Angela Schreiber

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Kind regards
Angela



From: ang...@apache.org 
Sent: Thursday, November 17, 2022 10:44
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 
1.1.24

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12352474

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2693

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2693 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Kind regards
Angela

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.24

[Angela Schreiber]

+1

angela

From: ang...@apache.org 
Sent: Thursday, November 17, 2022 10:44
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 
1.1.24

EXTERNAL: Use caution when clicking on links or opening attachments.


Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12352474

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2693

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2693 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Kind regards
Angela

[jira] [Updated] (SLING-11616) Build and test with Windows

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11616:
-
Fix Version/s: (was: Content-Package to Feature Model Converter 1.1.24)

> Build and test with Windows
> ---
>
> Key: SLING-11616
> URL: https://issues.apache.org/jira/browse/SLING-11616
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
>
> The ASF Jenkins should build and test on Windows as well to prevent issues 
> like SLING-11615.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11663) Create all service users with forced path

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-11663.
--
Resolution: Fixed

> Create all service users with forced path
> -
>
> Key: SLING-11663
> URL: https://issues.apache.org/jira/browse/SLING-11663
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.22
>Reporter: Angela Schreiber
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.24
>
>
> as discussed with [~kpauls] and [~Sc0rpic0m] in private conversation the 
> converter should have the ability to create all service users with a forced 
> path (not just when principal-based access control setup is enforced). 
> with this additional flexibility present we can safely run the converter 
> repeatedly on an existing repository having 
> _--enforce-principal-based-supported-path_ configuration enabled and disabled 
> as it would not only move service users to the supported path but also 
> restore the original path as specified in repoinit and content-package if 
> executed again with the configuration disabled.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630317#comment-17630317
 ] 

Angela Schreiber commented on SLING-11507:
--

[~diru], thanks a lot! your post and me pinging [~sseifert] and [~kwin] have 
just crossed. i am not familiar with sling models but if a review/input from an 
outsider is helpful please ping me.

> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject 
> into static fields. Instead it should throw an exception and an error message 
> indicating the problem (another option would be to refuse the injection with 
> a proper error message).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630313#comment-17630313
 ] 

Angela Schreiber commented on SLING-11507:
--

hi [~sseifert] and [~kwin], it would be awesome if you could provide input or 
help to get this issue fixed. wdyt? 

cc: [~cziegeler], [~chaotic]

> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject 
> into static fields. Instead it should throw an exception and an error message 
> indicating the problem (another option would be to refuse the injection with 
> a proper error message).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11312) Improve test coverage

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11312:
-
Fix Version/s: (was: JCR Resource 3.2.4)

> Improve test coverage
> -
>
> Key: SLING-11312
> URL: https://issues.apache.org/jira/browse/SLING-11312
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 3.2.0
>Reporter: Angela Schreiber
>Priority: Major
>
> today test coverage of the _org-apache-sling-jcr-resource_ module is at 56.2% 
> which IMHO is quite poor for code that is such a fundamental piece of sling.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628946#comment-17628946
 ] 

Angela Schreiber commented on SLING-11507:
--

[~rombert], sounds good to me. 

IMHO having static fields/methods annotated sounds like a terrible idea and I 
can't imagine that this was ever intended to work but rather simply was 
overlooked. 
So, I think we should actually treat this as a bug and not just as a task or 
improvement. Would you know who is the original author or otherwise deeper 
knowledge into this area and could provide additional insight and possible work 
on a fix?

> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject 
> into static fields. Instead it should throw an exception and an error message 
> indicating the problem (another option would be to refuse the injection with 
> a proper error message).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11507) Field injection should not inject static fields

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11507:
-
Issue Type: Bug  (was: Task)

> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Major
> Fix For: Sling Models Implementation 1.5
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject 
> into static fields. Instead it should throw an exception and an error message 
> indicating the problem (another option would be to refuse the injection with 
> a proper error message).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11507) Field injection should not inject static fields

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11507:
-
Priority: Critical  (was: Major)

> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
>  Issue Type: Bug
>  Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject 
> into static fields. Instead it should throw an exception and an error message 
> indicating the problem (another option would be to refuse the injection with 
> a proper error message).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-11663) Create all service users with forced path

[Angela Schreiber (Jira)]

Angela Schreiber created SLING-11663:


 Summary: Create all service users with forced path
 Key: SLING-11663
 URL: https://issues.apache.org/jira/browse/SLING-11663
 Project: Sling
  Issue Type: Improvement
  Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.1.22
Reporter: Angela Schreiber
Assignee: Angela Schreiber
 Fix For: Content-Package to Feature Model Converter 1.1.24


as discussed with [~kpauls] and [~Sc0rpic0m] in private conversation the 
converter should have the ability to create all service users with a forced 
path (not just when principal-based access control setup is enforced). 
with this additional flexibility present we can safely run the converter 
repeatedly on an existing repository having 
_--enforce-principal-based-supported-path_ configuration enabled and disabled 
as it would not only move service users to the supported path but also restore 
the original path as specified in repoinit and content-package if executed 
again with the configuration disabled.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling XSS Protection API 2.3.2

[Angela Schreiber]

hi robert

[x] +1 Approve the release

kind regards
angela


From: Robert Munteanu 
Sent: Wednesday, October 26, 2022 15:27
To: Sling Developers List 
Subject: [VOTE] Release Apache Sling XSS Protection API 2.3.2


Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12352357

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2687/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2687 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Content Package to Feature Model Converter 1.1.22

[Angela Schreiber]

hi Carsten

[x] +1 Approve the release

kind regards and thanks a lot
angela

From: Carsten Ziegeler 
Sent: Friday, October 28, 2022 10:10
To: dev@sling.apache.org 
Subject: [VOTE] Release Apache Sling Content Package to Feature Model Converter 
1.1.22

EXTERNAL: Use caution when clicking on links or opening attachments.


Hi,

We solved 1 issues
https://issues.apache.org/jira/browse/SLING-11653


Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2689/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2689 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
cziege...@apache.org

Failed to release org.apache.sling.feature.cpconverter

[Angela Schreiber]

Hi

Yesterday I aimed to release org.apache.sling.feature.cpconverter 1.1.22. 
However, the release process failed during mvn release:preform due to javadoc 
errors.

Surprisingly, it reported errors for classes I most definitely have released 
before.

Could that be due to the latest parent.pom 49 (it was updated on August 18 2022?

I reverted the commits from the prepare phase in order not to leave a half-way 
done release behind. Carsten Ziegeler, since you 
managed to release the module a few days ago, would you be able to help me out 
and release it again?

In the long run it would be preferrable if everyone could cut releases without 
having to worry about javadoc issues that have been present for years.

Kind regards
Angela

[jira] [Resolved] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-11653.
--
Resolution: Fixed

> DefaultAclManager.calculateEnforcedIntermediatePath fails for supported 
> ancestor
> 
>
> Key: SLING-11653
> URL: https://issues.apache.org/jira/browse/SLING-11653
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.20
>    Reporter: Angela Schreiber
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.22
>
>
> {{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the 
> case where the passed intermediate path is a valid ancestor of the configured 
> {{enforcePrincipalBasedSupportedPath}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11653:
-
Fix Version/s: Content-Package to Feature Model Converter 1.1.22

> DefaultAclManager.calculateEnforcedIntermediatePath fails for supported 
> ancestor
> 
>
> Key: SLING-11653
> URL: https://issues.apache.org/jira/browse/SLING-11653
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.20
>    Reporter: Angela Schreiber
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.22
>
>
> {{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the 
> case where the passed intermediate path is a valid ancestor of the configured 
> {{enforcePrincipalBasedSupportedPath}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11653:
-
Affects Version/s: Content-Package to Feature Model Converter 1.1.20

> DefaultAclManager.calculateEnforcedIntermediatePath fails for supported 
> ancestor
> 
>
> Key: SLING-11653
> URL: https://issues.apache.org/jira/browse/SLING-11653
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.20
>    Reporter: Angela Schreiber
>    Assignee: Angela Schreiber
>Priority: Major
>
> {{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the 
> case where the passed intermediate path is a valid ancestor of the configured 
> {{enforcePrincipalBasedSupportedPath}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor

[Angela Schreiber (Jira)]

Angela Schreiber created SLING-11653:


 Summary: DefaultAclManager.calculateEnforcedIntermediatePath fails 
for supported ancestor
 Key: SLING-11653
 URL: https://issues.apache.org/jira/browse/SLING-11653
 Project: Sling
  Issue Type: Bug
  Components: Content-Package to Feature Model Converter
Reporter: Angela Schreiber
Assignee: Angela Schreiber


{{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the case 
where the passed intermediate path is a valid ancestor of the configured 
{{enforcePrincipalBasedSupportedPath}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612876#comment-17612876
 ] 

Angela Schreiber commented on SLING-11611:
--

[~nscendoni], i tentatively assigned this ticket to you. hope that is ok... 
otherwise feel free to unassign.

> Provide method to retrieve Pid for OSGI Configurations in Sling Testing 
> Clients
> ---
>
> Key: SLING-11611
> URL: https://issues.apache.org/jira/browse/SLING-11611
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
>
> During development of IT Tests it may be needed to search the pid for some 
> OSGI Configuration not created by the test itself.
> I will provide an implementation to search the pid of configurations from 
> serviceType and the value of a property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11609) Provide doGetWithRetry methods in Sling Testing Clients

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612875#comment-17612875
 ] 

Angela Schreiber commented on SLING-11609:
--

[~nscendoni], i am assigning the ticket to you given that you have provided a 
PR. hope that's ok.

> Provide doGetWithRetry methods in Sling Testing Clients
> ---
>
> Key: SLING-11609
> URL: https://issues.apache.org/jira/browse/SLING-11609
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
>
> In several situations during IT Tests development we need to retry doGet 
> method until some assertion are verified.
> I propose in the attached pull request an implementation and test for new 
> methods doGetWithRetry



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-11611:


Assignee: Nicola Scendoni

> Provide method to retrieve Pid for OSGI Configurations in Sling Testing 
> Clients
> ---
>
> Key: SLING-11611
> URL: https://issues.apache.org/jira/browse/SLING-11611
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
>
> During development of IT Tests it may be needed to search the pid for some 
> OSGI Configuration not created by the test itself.
> I will provide an implementation to search the pid of configurations from 
> serviceType and the value of a property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11609) Provide doGetWithRetry methods in Sling Testing Clients

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-11609:


Assignee: Nicola Scendoni

> Provide doGetWithRetry methods in Sling Testing Clients
> ---
>
> Key: SLING-11609
> URL: https://issues.apache.org/jira/browse/SLING-11609
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Affects Versions: Apache Sling Testing Clients 3.0.16
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
>
> In several situations during IT Tests development we need to retry doGet 
> method until some assertion are verified.
> I propose in the attached pull request an implementation and test for new 
> methods doGetWithRetry



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-11482.
--
Resolution: Fixed

> Redundant checks for null
> -
>
> Key: SLING-11482
> URL: https://issues.apache.org/jira/browse/SLING-11482
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
>  reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11482:
-
Fix Version/s: JCR Resource 3.2.2

> Redundant checks for null
> -
>
> Key: SLING-11482
> URL: https://issues.apache.org/jira/browse/SLING-11482
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: JCR Resource 3.2.2
>
>
> https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
>  reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11482:
-
Issue Type: Improvement  (was: Bug)

> Redundant checks for null
> -
>
> Key: SLING-11482
> URL: https://issues.apache.org/jira/browse/SLING-11482
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: JCR Resource 3.2.2
>
>
> https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
>  reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber reassigned SLING-11482:


Assignee: Angela Schreiber

> Redundant checks for null
> -
>
> Key: SLING-11482
> URL: https://issues.apache.org/jira/browse/SLING-11482
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
>
> https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
>  reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

Angela Schreiber created SLING-11482:


 Summary: Redundant checks for null
 Key: SLING-11482
 URL: https://issues.apache.org/jira/browse/SLING-11482
 Project: Sling
  Issue Type: Bug
  Components: JCR
Reporter: Angela Schreiber


https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
 reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-11482) Redundant checks for null

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber updated SLING-11482:
-
Priority: Major  (was: Minor)

> Redundant checks for null
> -
>
> Key: SLING-11482
> URL: https://issues.apache.org/jira/browse/SLING-11482
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
>
> https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource
>  reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11311) Improve org-apache-sling-jcr-resource

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-11311.
--
Resolution: Fixed

> Improve org-apache-sling-jcr-resource
> -
>
> Key: SLING-11311
> URL: https://issues.apache.org/jira/browse/SLING-11311
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 3.2.0
>Reporter: Angela Schreiber
>    Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> while working on SLING-10011 i noticed a considerable amount of issues 
> reported by sonar, which are trivial to fix and would improve overall code 
> quality.
> apart from sonar findings we should fix
> - inconsistent formatting
> - unused imports
> - missing nullable/notnull annotations
> - complexity



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-11468) Simplify JcrPropertyMapCacheEntry.convertToType

[Angela Schreiber (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved SLING-11468.
--
Fix Version/s: JCR Resource 3.2.2
   Resolution: Fixed

> Simplify JcrPropertyMapCacheEntry.convertToType
> ---
>
> Key: SLING-11468
> URL: https://issues.apache.org/jira/browse/SLING-11468
> Project: Sling
>  Issue Type: Sub-task
>  Components: JCR
>    Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)