[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628946#comment-17628946
]
Angela Schreiber commented on SLING-11507:
------------------------------------------
[~rombert], sounds good to me.
IMHO having static fields/methods annotated sounds like a terrible idea and I
can't imagine that this was ever intended to work but rather simply was
overlooked.
So, I think we should actually treat this as a bug and not just as a task or
improvement. Would you know who is the original author or otherwise deeper
knowledge into this area and could provide additional insight and possible work
on a fix?
> Field injection should not inject static fields
> -----------------------------------------------
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
> Affects Versions: Models Impl 1.4.14
> Reporter: Joerg Hoh
> Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
