[jira] [Closed] (SLING-12210) Remove unused startLevel from BundleDescriptorImpl
[ https://issues.apache.org/jira/browse/SLING-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber closed SLING-12210. > Remove unused startLevel from BundleDescriptorImpl > -- > > Key: SLING-12210 > URL: https://issues.apache.org/jira/browse/SLING-12210 > Project: Sling > Issue Type: Improvement > Components: Feature Model Analyser >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12346) Create service-user-mapping analyser
[ https://issues.apache.org/jira/browse/SLING-12346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber closed SLING-12346. > Create service-user-mapping analyser > > > Key: SLING-12346 > URL: https://issues.apache.org/jira/browse/SLING-12346 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: Feature Model Analyser 2.0.2 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Feature Model Analyser 2.0.4 > > > based on a discussion with [~joerghoh], i would like to suggest that we > create a dedicated analyser for service-user-mappings. > This feature would include the following 2 checks: > - validity of service-user-mapping > - usage of deprecated service user mapping format > The second part should be enabled through configuration. > [~cziegeler], [~kpauls], i would give it a try borrowing from existing > analysers but i will likely need input from your side to not spend too much > time on figuring out details i might have missed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12209) Improve logging output
[ https://issues.apache.org/jira/browse/SLING-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber closed SLING-12209. > Improve logging output > -- > > Key: SLING-12209 > URL: https://issues.apache.org/jira/browse/SLING-12209 > Project: Sling > Issue Type: New Feature > Components: Feature Model Analyser >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 2.0.4 > > > The logging output of the analyser could be improved, e.g. by adding the full > time it took to analyse as well as providing an option to surpress task info > output. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12351) Create a default implementation for generating the analyser-metadata extension
[
https://issues.apache.org/jira/browse/SLING-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853199#comment-17853199
]
Angela Schreiber commented on SLING-12351:
--
[~rombert], i didn't spot this ticket and that you intend to put it into the
2.0.4 release, which i just cut today. sorry for that.
> Create a default implementation for generating the analyser-metadata extension
> --
>
> Key: SLING-12351
> URL: https://issues.apache.org/jira/browse/SLING-12351
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.4
>
>
> The feature model analysers contains and use the
> {{AnalyserMetaDataExtension}} -
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/c8518ebd7c8fa245781ad8062f2c2d6b52174345/src/main/java/org/apache/sling/feature/analyser/extensions/AnalyserMetaDataExtension.java
> .
> This class is read and used (error reporting, cached manifests) but there is
> currently no automated way of generating the metadata.
> We should provide a default implementation that simplifies the metadata
> generation. The same implementation should also support generating the
> framework capabilities metadata as discussed in SLING-10288 .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12346) Create service-user-mapping analyser
[ https://issues.apache.org/jira/browse/SLING-12346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-12346: - Affects Version/s: Feature Model Analyser 2.0.2 > Create service-user-mapping analyser > > > Key: SLING-12346 > URL: https://issues.apache.org/jira/browse/SLING-12346 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: Feature Model Analyser 2.0.2 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Feature Model Analyser 2.0.4 > > > based on a discussion with [~joerghoh], i would like to suggest that we > create a dedicated analyser for service-user-mappings. > This feature would include the following 2 checks: > - validity of service-user-mapping > - usage of deprecated service user mapping format > The second part should be enabled through configuration. > [~cziegeler], [~kpauls], i would give it a try borrowing from existing > analysers but i will likely need input from your side to not spend too much > time on figuring out details i might have missed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12346) Create service-user-mapping analyser
[ https://issues.apache.org/jira/browse/SLING-12346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-12346. -- Fix Version/s: Feature Model Analyser 2.0.4 Resolution: Fixed > Create service-user-mapping analyser > > > Key: SLING-12346 > URL: https://issues.apache.org/jira/browse/SLING-12346 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Feature Model Analyser 2.0.4 > > > based on a discussion with [~joerghoh], i would like to suggest that we > create a dedicated analyser for service-user-mappings. > This feature would include the following 2 checks: > - validity of service-user-mapping > - usage of deprecated service user mapping format > The second part should be enabled through configuration. > [~cziegeler], [~kpauls], i would give it a try borrowing from existing > analysers but i will likely need input from your side to not spend too much > time on figuring out details i might have missed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12346) Create service-user-mapping analyser
[ https://issues.apache.org/jira/browse/SLING-12346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-12346: Assignee: Angela Schreiber > Create service-user-mapping analyser > > > Key: SLING-12346 > URL: https://issues.apache.org/jira/browse/SLING-12346 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > > based on a discussion with [~joerghoh], i would like to suggest that we > create a dedicated analyser for service-user-mappings. > This feature would include the following 2 checks: > - validity of service-user-mapping > - usage of deprecated service user mapping format > The second part should be enabled through configuration. > [~cziegeler], [~kpauls], i would give it a try borrowing from existing > analysers but i will likely need input from your side to not spend too much > time on figuring out details i might have missed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12346) Create service-user-mapping analyser
Angela Schreiber created SLING-12346: Summary: Create service-user-mapping analyser Key: SLING-12346 URL: https://issues.apache.org/jira/browse/SLING-12346 Project: Sling Issue Type: New Feature Components: Feature Model, Maven Plugins and Archetypes Reporter: Angela Schreiber based on a discussion with [~joerghoh], i would like to suggest that we create a dedicated analyser for service-user-mappings. This feature would include the following 2 checks: - validity of service-user-mapping - usage of deprecated service user mapping format The second part should be enabled through configuration. [~cziegeler], [~kpauls], i would give it a try borrowing from existing analysers but i will likely need input from your side to not spend too much time on figuring out details i might have missed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-10156) Create access control entries for unknown principals
[
https://issues.apache.org/jira/browse/SLING-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-10156.
--
Resolution: Duplicate
this has been addressed by SLING-12115. thanks [~jsedding] :)
> Create access control entries for unknown principals
>
>
> Key: SLING-10156
> URL: https://issues.apache.org/jira/browse/SLING-10156
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Angela Schreiber
>Priority: Major
>
> [~bdelacretaz], today the JCR repo-init implementation limits creation of
> access control content to principals known to the repository (see also
> SLING-10134 for a related ticket wrt to removing access control entries):
> {code}
> // first try PrincipalManager.getPrincipal(String)
> Principal principal = AccessControlUtils.getPrincipal(session, name);
> if (principal == null) {
> // backwards compatibility: fallback to original code
> treating principal name as authorizable ID (see SLING-8604)
> final Authorizable authorizable =
> UserUtil.getAuthorizable(session, name);
> checkState(authorizable != null, "Authorizable not found:" +
> name);
> principal = authorizable.getPrincipal();
> }
> checkState(principal != null, "Principal not found: " + name); //
> <- here it fails if principal does not exist
> {code}
> While JCR access control API mandates that a principal must be known to the
> repository, it is possible both with Apache Jackrabbit 2.x and in Apache
> Jackrabbit Oak to relax that contract (see ImportBehavior.BESTEFFORT [0]).
> The main reason for this is the fact that principals may only be installed at
> a later stage and packaging them together with (resource-based) access
> control isn't always feasible/desirable (see for example Jackrabbit vault
> [1]).
> In other words: repo-init should delegate the principal validation step (and
> whether or not the strict JCR contract is enforced) to the repository itself.
> In Sling RepoInit this is relevant under the following circumstances:
> - cleaning up access control content when the principal no longer exists (see
> SLING-10134)
> - setting up access control content in the initial repository initialization,
> while principals are not yet available (maybe installed later with content
> packages). this becomes increasingly relevant with a composite NodeStore
> setup, where certain trees of the repository are marked as immutable and thus
> might be initialized independently of the mutable stores (that e.g. would
> include the group nodes).
> NOTE: delegating the principal validation step to the repository, may also
> require the principal-equality test in
> https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L399
> to be adjusted (e.g. reducing to comparing names as it is done in [2])
> [~karlpauls], [~cziegeler], fyi
> [0]
> http://jackrabbit.apache.org/oak/docs/security/accesscontrol/default.html#xml_import
> [1]
> https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/JackrabbitACLImporter.java
> [2]
> https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/JackrabbitACLImporter.java#L290
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12115) Repoinit should leave enforcement of importBehaviour for ACL creation to JCR
[
https://issues.apache.org/jira/browse/SLING-12115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-12115:
-
Summary: Repoinit should leave enforcement of importBehaviour for ACL
creation to JCR (was: Repoinit should leave importBehaviour for ACL creation
to JCR)
> Repoinit should leave enforcement of importBehaviour for ACL creation to JCR
>
>
> Key: SLING-12115
> URL: https://issues.apache.org/jira/browse/SLING-12115
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.44
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Major
> Fix For: Repoinit JCR 1.1.46
>
>
> JCR Repoinit checks the existence of the principal, for which ACLs should be
> created. In an Oak repository, this check depends on the {{ImportBehaviour}}
> configured for the {{SecurityProvider}}. JCR Repoinit should not check, but
> instead rely on the repository's behaviour.
> cc [~angela]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735995#comment-17735995
]
Angela Schreiber commented on SLING-11910:
--
[~madamcin] , yes, that's the oak side of it. the only class you missed to
mention is
org.apache.jackrabbit.oak.plugins.nodetype.TypeRegistration
see
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeRegistration.java]
for the list of validation it performs.
would what you found in oak address your concerns specified in you comment at
https://issues.apache.org/jira/browse/SLING-11910?focusedCommentId=17735814=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17735814
?
then the repoinit implementation in jcr.repoinit could simply rely on the JCR
repository to prevent troublesome modifications instead of trying to spot them
itself, which it likely cannot do to the full extend the repository is actually
able to do it.
in other words: we were back at my original suggestion to either introduce an
optional flag 'allowUpdate' or introduce a new method. either way the repoinit
implementation would not perform any validation but would just pass the boolean
flag with the registration method (either on NodeTypeManagere or on the
CND-registration from commons which calls the NodeTypeManager)
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting NodeType object. Typically,
> the object passed to this method will be a NodeTypeTemplate (a subclass of
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
> then filled-in with definition information. If allowUpdate is true then an
> attempt to change the definition of an already registered node type will be
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
> register a node type with the same name as an already registered one will
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This
> method is used to register or update a set of node types with mutual
> dependencies. It returns an iterator over the resulting NodeType objects. The
> effect of the method is “all or nothing”; if an error occurs, no changes are
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node
> type already in use as the type of an existing node. The extent of any such
> capability is implementation dependent. For example, some implementations may
> permit only changes which do not invalidate existing content, while others
> may allow larger changes. How any resulting incompatibilities are resolved is
> also implementation dependent. Any changes to the type of an exiting node
> must take effect in accordance with the _node type assignment behavior_ of
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or
> 'reregister') flag the existing {{register nodetypes}} command (default would
> be 'false' to ensure backwards compatible behavior) or introduce a new
> command {{{}reregister nodetypes{}}}.
>
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional property.
> For new repositories this works but for existing repositories the existing
> mixin is unchanged.
> As my code requires the new property I get errors.
>
> So I propose that
[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735814#comment-17735814
]
Angela Schreiber commented on SLING-11910:
--
[~madamcin] , good point. I am not entirely sure though how you would find out
about the pure 'additive' nature of a node type definition. but as usual: feel
free to contribute a patch, it will be welcome.
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting NodeType object. Typically,
> the object passed to this method will be a NodeTypeTemplate (a subclass of
> NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
> then filled-in with definition information. If allowUpdate is true then an
> attempt to change the definition of an already registered node type will be
> made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
> register a node type with the same name as an already registered one will
> fail immediately.
> NodeTypeIterator NodeTypeManager.
> registerNodeTypes(NodeTypeDefinition[] ntds,
> boolean allowUpdate)
> registers or updates the specified array of NodeTypeDefinition objects. This
> method is used to register or update a set of node types with mutual
> dependencies. It returns an iterator over the resulting NodeType objects. The
> effect of the method is “all or nothing”; if an error occurs, no changes are
> made.
> h4. 19.2.4.1 Updating Node Types
> A repository that supports node type management may support updates to a node
> type already in use as the type of an existing node. The extent of any such
> capability is implementation dependent. For example, some implementations may
> permit only changes which do not invalidate existing content, while others
> may allow larger changes. How any resulting incompatibilities are resolved is
> also implementation dependent. Any changes to the type of an exiting node
> must take effect in accordance with the _node type assignment behavior_ of
> the repository (see §10.10.1 {_}Node Type Assignment Behavior{_}).
> {quote}
> We would therefore suggestion to either add an optional 'allowUpdate' (or
> 'reregister') flag the existing {{register nodetypes}} command (default would
> be 'false' to ensure backwards compatible behavior) or introduce a new
> command {{{}reregister nodetypes{}}}.
>
> Original use case from [~cschneider]:
> My use case is to extend an existing mixin with an additional property.
> For new repositories this works but for existing repositories the existing
> mixin is unchanged.
> As my code requires the new property I get errors.
>
> So I propose that repoinit allows to update existing mixins (and possibly
> other structures).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[
https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11910:
-
Description:
JCR node type registration as defined with {{NodeTypeManager#registerNodeType}}
and {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
specifies how to handle existing node type definitions upon registration.
However, Sling RepoInit does not support the 'allowUpdate' flag and there is no
way to update an existing nodetype definition through RepoInit. Consumers of
the API need to resort to programmatically update the node type using JCR API
in a service.
Here the extract from the specification (copied from
https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
{quote}
h3. 19.2.4 Registering a Node Type
NodeType NodeTypeManager.
registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
registers a new node type or updates an existing node type using the specified
definition and returns the resulting NodeType object. Typically, the object
passed to this method will be a NodeTypeTemplate (a subclass of
NodeTypeDefinition) acquired from NodeTypeManager.createNodeTypeTemplate and
then filled-in with definition information. If allowUpdate is true then an
attempt to change the definition of an already registered node type will be
made (see §19.2.4.1 {_}Updating Node Types{_}), otherwise an attempt to
register a node type with the same name as an already registered one will fail
immediately.
NodeTypeIterator NodeTypeManager.
registerNodeTypes(NodeTypeDefinition[] ntds,
boolean allowUpdate)
registers or updates the specified array of NodeTypeDefinition objects. This
method is used to register or update a set of node types with mutual
dependencies. It returns an iterator over the resulting NodeType objects. The
effect of the method is “all or nothing”; if an error occurs, no changes are
made.
h4. 19.2.4.1 Updating Node Types
A repository that supports node type management may support updates to a node
type already in use as the type of an existing node. The extent of any such
capability is implementation dependent. For example, some implementations may
permit only changes which do not invalidate existing content, while others may
allow larger changes. How any resulting incompatibilities are resolved is also
implementation dependent. Any changes to the type of an exiting node must take
effect in accordance with the _node type assignment behavior_ of the repository
(see §10.10.1 {_}Node Type Assignment Behavior{_}).
{quote}
We would therefore suggestion to either add an optional 'allowUpdate' (or
'reregister') flag the existing {{register nodetypes}} command (default would
be 'false' to ensure backwards compatible behavior) or introduce a new command
{{{}reregister nodetypes{}}}.
Original use case from [~cschneider]:
My use case is to extend an existing mixin with an additional property.
For new repositories this works but for existing repositories the existing
mixin is unchanged.
As my code requires the new property I get errors.
So I propose that repoinit allows to update existing mixins (and possibly other
structures).
was:
My use case is to extend an existing mixin with an additional property.
For new repositories this works but for existing repositories the existing
mixin is unchanged.
As my code requires the new property I get errors.
So I propose that repoinit allows to update existing mixins (and possibly other
structures).
> Repoinit should support 'allowUpdate' option with node type registration
>
>
> Key: SLING-11910
> URL: https://issues.apache.org/jira/browse/SLING-11910
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: Christian Schneider
>Priority: Major
>
> JCR node type registration as defined with
> {{NodeTypeManager#registerNodeType}} and
> {{NodeTypeManager.registerNodeTypes}} comes with a boolean flag that
> specifies how to handle existing node type definitions upon registration.
> However, Sling RepoInit does not support the 'allowUpdate' flag and there is
> no way to update an existing nodetype definition through RepoInit. Consumers
> of the API need to resort to programmatically update the node type using JCR
> API in a service.
> Here the extract from the specification (copied from
> https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/19_Node_Type_Management.html):
> {quote}
> h3. 19.2.4 Registering a Node Type
> NodeType NodeTypeManager.
> registerNodeType(NodeTypeDefinition ntd, boolean allowUpdate)
> registers a new node type or updates an existing node type using the
> specified definition and returns the resulting
[jira] [Commented] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[ https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735271#comment-17735271 ] Angela Schreiber commented on SLING-11910: -- hi [~cschneider], i slightly adjusted the summary to capture the generic request. your need to have a mixin type definition updated is one example. but the same would apply for regular node types. > Repoinit should support 'allowUpdate' option with node type registration > > > Key: SLING-11910 > URL: https://issues.apache.org/jira/browse/SLING-11910 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Reporter: Christian Schneider >Priority: Major > > My use case is to extend an existing mixin with an additional property. > For new repositories this works but for existing repositories the existing > mixin is unchanged. > As my code requires the new property I get errors. > > So I propose that repoinit allows to update existing mixins (and possibly > other structures). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11910) Repoinit should support 'allowUpdate' option with node type registration
[ https://issues.apache.org/jira/browse/SLING-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11910: - Summary: Repoinit should support 'allowUpdate' option with node type registration (was: Repoinit should apply changes to existing mixins) > Repoinit should support 'allowUpdate' option with node type registration > > > Key: SLING-11910 > URL: https://issues.apache.org/jira/browse/SLING-11910 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Reporter: Christian Schneider >Priority: Major > > My use case is to extend an existing mixin with an additional property. > For new repositories this works but for existing repositories the existing > mixin is unchanged. > As my code requires the new property I get errors. > > So I propose that repoinit allows to update existing mixins (and possibly > other structures). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719861#comment-17719861 ] Angela Schreiber commented on SLING-11482: -- see also SLING-11567 > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Labels: regression > Fix For: JCR Resource 3.2.2 > > Time Spent: 2h 32m > Remaining Estimate: 0h > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Labels: regression (was: ) > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Labels: regression > Fix For: JCR Resource 3.2.2 > > Time Spent: 2h 32m > Remaining Estimate: 0h > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11750: - Affects Version/s: Content-Package to Feature Model Converter 1.3.2 > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.2 >Reporter: Konrad Windszus >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11750: - Affects Version/s: (was: Content-Package to Feature Model Converter 1.3.0) > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11750: - Affects Version/s: Content-Package to Feature Model Converter 1.3.0 (was: Content-Package to Feature Model Converter 1.1.20) > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Konrad Windszus >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11750: - Affects Version/s: Content-Package to Feature Model Converter 1.1.20 > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.20 >Reporter: Konrad Windszus >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11750. -- Resolution: Fixed > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.4 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719327#comment-17719327 ] Angela Schreiber commented on SLING-11750: -- also 'addMixin' and 'removeMixin' are new statements and not covered by the converter so far. > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719327#comment-17719327 ] Angela Schreiber edited comment on SLING-11750 at 5/4/23 1:32 PM: -- also 'addMixin' and 'removeMixin' are new statements and not covered by the converter so far. https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/167 was (Author: anchela): also 'addMixin' and 'removeMixin' are new statements and not covered by the converter so far. > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11750) Support the new repoinit statements
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11750: - Summary: Support the new repoinit statements (was: Support the new repoinit statements "enforce principal ACL" and "enforce nodes") > Support the new repoinit statements > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10243) Extract Sling-Initial-Content from bundles and put into dedicated packages
[
https://issues.apache.org/jira/browse/SLING-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-10243:
-
Labels: regression (was: )
> Extract Sling-Initial-Content from bundles and put into dedicated packages
> --
>
> Key: SLING-10243
> URL: https://issues.apache.org/jira/browse/SLING-10243
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Labels: regression
> Fix For: Content-Package to Feature Model Converter 1.1.0
>
>
> As described in
> https://lists.apache.org/thread.html/r1162d545922381187a0530f838b684b60f2a8ea28a12649ae79372e8%40%3Cdev.sling.apache.org%3E
> Sling-Initial-Content leads to ERRORs when used with Oak Composite Node
> Store, as those are evaluated during each bundle start. At times when that
> part of the repo is read-only an ERROR is logged.
> The following steps are necessary:
> # Check manifest from bundle for header {{Sling-Initial-Content}}
> # For all entry paths in the header split up by mutable/immutable and create
> a content package for each category
> # Modify manifest to no longer include {{Sling-Initial-Content}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11855) Conversion of old factory config names to new one is not checking for tilde
[ https://issues.apache.org/jira/browse/SLING-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11855: - Labels: (was: regression) > Conversion of old factory config names to new one is not checking for tilde > --- > > Key: SLING-11855 > URL: https://issues.apache.org/jira/browse/SLING-11855 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The code in > AbstractConfigurationEntryHandler#extractId converts an old factory > configuration name into a new one (with a tilde). Unfortunately it only > checks for a dash but not a tilde, which means in the case of > factory~a-b this is converted to factory~a~b instead of keeping it as > factory~a-b > > A similar bug might lurk in other places dealing with factory configurations -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11855) Conversion of old factory config names to new one is not checking for tilde
[ https://issues.apache.org/jira/browse/SLING-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11855: - Labels: regression (was: ) > Conversion of old factory config names to new one is not checking for tilde > --- > > Key: SLING-11855 > URL: https://issues.apache.org/jira/browse/SLING-11855 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Labels: regression > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The code in > AbstractConfigurationEntryHandler#extractId converts an old factory > configuration name into a new one (with a tilde). Unfortunately it only > checks for a dash but not a tilde, which means in the case of > factory~a-b this is converted to factory~a~b instead of keeping it as > factory~a-b > > A similar bug might lurk in other places dealing with factory configurations -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10168) Migrate to Bundle Parent 41 and OSGi annotations
[ https://issues.apache.org/jira/browse/SLING-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10168: - Labels: regression (was: ) > Migrate to Bundle Parent 41 and OSGi annotations > > > Key: SLING-10168 > URL: https://issues.apache.org/jira/browse/SLING-10168 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Resource Merger 1.3.10 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Labels: regression > Fix For: Resource Merger 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11112) Regression in content loader : Diffent behaviour when initial content is missing
[ https://issues.apache.org/jira/browse/SLING-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-2: - Labels: regression (was: ) > Regression in content loader : Diffent behaviour when initial content is > missing > > > Key: SLING-2 > URL: https://issues.apache.org/jira/browse/SLING-2 > Project: Sling > Issue Type: Improvement >Affects Versions: JCR ContentLoader 2.5.0 >Reporter: Carsten Ziegeler >Priority: Blocker > Labels: regression > Fix For: JCR ContentLoader 2.6.2 > > > With a bundle that does not have SLING-INF and the following initial content > instruction: > SLING-INF/content;path:=/libs/foo/bar;overwrite:=true; > it seems that prior versions handled this case differently and did not touch > /libs/foo/bar while the new behaviour removes all child nodes of /libs/foo/bar -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11818) Update to Sling Parent POM 48 broke api generation
[ https://issues.apache.org/jira/browse/SLING-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber closed SLING-11818. > Update to Sling Parent POM 48 broke api generation > -- > > Key: SLING-11818 > URL: https://issues.apache.org/jira/browse/SLING-11818 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Base 3.1.12 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: JCR Base 3.1.14 > > > This commit > [https://github.com/apache/sling-org-apache-sling-jcr-base/commit/97ea7f527040b1bcb0f7f9888a4c599ca91f58cb] > added a buggy dependency management section to the pom without any versions. > This confuses other tools like the slingfeature maven plugin. > The whole dependency management section is not needed and can simply be > removed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10321) Deprecate service mapping by userID
[ https://issues.apache.org/jira/browse/SLING-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705872#comment-17705872 ] Angela Schreiber commented on SLING-10321: -- hi [~friendlymahi], the service resource resolver/session created from the new mapping format 'service:subservice:[servicePrincipal1, ...]' will have a java Subject associated that only contains the specified service user principals. no group membership is being resolved. if you have added any of these service users to a group the permissions of these groups will no longer be inherited upon repository login. if you evaluated group membership manually using user management API you would still be able to see it but as i mentioned i would move away from group membership for service users and instead replace it with an aggregation of service users such that your code can rely on effective permissions not on group membership. > Deprecate service mapping by userID > --- > > Key: SLING-10321 > URL: https://issues.apache.org/jira/browse/SLING-10321 > Project: Sling > Issue Type: Improvement > Components: Service User Mapper >Affects Versions: Service User Mapper 1.5.2 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Service User Mapper 1.5.4 > > Time Spent: 40m > Remaining Estimate: 0h > > [~cziegeler], [~kpauls], for security reasons I would like to deprecate the > old service user mapping by a single userID in favor of the new format that > takes one or multiple principal names. > The new format allows to keep service permissions limited to service-users as > declared in the mapping and doesn't resolve declare or inherited group > permissions. This gives full control over the effective permissions granted > to each service and doesn't risk unrelated permission changes (e.g. to a base > group like 'everyone') impacting service security. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698235#comment-17698235
]
Angela Schreiber commented on SLING-10110:
--
[~SonglessHill], i don't know but since [~joerghoh] stated above:
{quote}
I will take care of the merge and also trigger a release.
{quote}
maybe a gentle nudge will do the trick ;-). [~joerghoh], wdty?
> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
> Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a
> general problem.
> The issue i am facing is that in my dispatcher configuration there are
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under
> the ignoreUrlParams it does not see the above parameter from the url as
> matching for ignoreUrlParams.
>
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was
> configured to ignore this parameter, the response will be cached with an
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not
> clear enough please tell me and i will try to update everything that is needed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-10110.
--
Resolution: Fixed
resolving ticket as PR provided by [~SonglessHill] has been merged. thanks for
the contribution!
> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
> Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a
> general problem.
> The issue i am facing is that in my dispatcher configuration there are
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under
> the ignoreUrlParams it does not see the above parameter from the url as
> matching for ignoreUrlParams.
>
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was
> configured to ignore this parameter, the response will be cached with an
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not
> clear enough please tell me and i will try to update everything that is needed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698229#comment-17698229
]
Angela Schreiber commented on SLING-10110:
--
[~SonglessHill], what i meant was: I added you to 'contributors' group and you
should be able to assign tickets to yourself not that the ticket is fixed
yet. sorry for the confusion.
but i quickly checked: your PR
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26 has
been merged. i am resolving this ticket as fixed. feel free to verify again
once the release is out.
> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
> Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a
> general problem.
> The issue i am facing is that in my dispatcher configuration there are
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under
> the ignoreUrlParams it does not see the above parameter from the url as
> matching for ignoreUrlParams.
>
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was
> configured to ignore this parameter, the response will be cached with an
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not
> clear enough please tell me and i will try to update everything that is needed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11782) Document Sling threat model and how to properly secure Sling
[ https://issues.apache.org/jira/browse/SLING-11782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696424#comment-17696424 ] Angela Schreiber commented on SLING-11782: -- [~rombert], count me in! as far as methodology is concerned the authorization best practices in the oak documentation contain a couple of links: https://jackrabbit.apache.org/oak/docs/security/authorization/bestpractices.html#Threat_Model hope that helps us to get started. > Document Sling threat model and how to properly secure Sling > > > Key: SLING-11782 > URL: https://issues.apache.org/jira/browse/SLING-11782 > Project: Sling > Issue Type: Improvement > Components: Documentation, Site >Reporter: Angela Schreiber >Priority: Major > Labels: security > > The documentation should be more explicit about to run sling in a secure way. > In particular we should provide some information about the underlying threat > model. > For example we should be being explicit about the fact that whoever has > access to the OSGi console has file system access with the privileges of the > JRE. > cc: [~rombert], [~cziegeler] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11782) Document Sling threat model and how to properly secure Sling
Angela Schreiber created SLING-11782: Summary: Document Sling threat model and how to properly secure Sling Key: SLING-11782 URL: https://issues.apache.org/jira/browse/SLING-11782 Project: Sling Issue Type: Improvement Components: Documentation, Site Reporter: Angela Schreiber The documentation should be more explicit about to run sling in a secure way. In particular we should provide some information about the underlying threat model. For example we should be being explicit about the fact that whoever has access to the OSGi console has file system access with the privileges of the JRE. cc: [~rombert], [~cziegeler] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11770) Cleanup in sling-jcr-base
[ https://issues.apache.org/jira/browse/SLING-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber closed SLING-11770. > Cleanup in sling-jcr-base > - > > Key: SLING-11770 > URL: https://issues.apache.org/jira/browse/SLING-11770 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Base 3.1.12 > > Time Spent: 0.5h > Remaining Estimate: 0h > > imo the sling-jcr-base module would benefit from a bit of cleanup. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11770) Cleanup in sling-jcr-base
[ https://issues.apache.org/jira/browse/SLING-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11770. -- Resolution: Fixed > Cleanup in sling-jcr-base > - > > Key: SLING-11770 > URL: https://issues.apache.org/jira/browse/SLING-11770 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Base 3.1.12 > > Time Spent: 0.5h > Remaining Estimate: 0h > > imo the sling-jcr-base module would benefit from a bit of cleanup. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11770) Cleanup in sling-jcr-base
Angela Schreiber created SLING-11770: Summary: Cleanup in sling-jcr-base Key: SLING-11770 URL: https://issues.apache.org/jira/browse/SLING-11770 Project: Sling Issue Type: Improvement Components: JCR Reporter: Angela Schreiber Assignee: Angela Schreiber Fix For: JCR Base 3.1.12 imo the sling-jcr-base module would benefit from a bit of cleanup. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11750) Support the new repoinit statements "enforce principal ACL" and "enforce nodes"
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685909#comment-17685909 ] Angela Schreiber commented on SLING-11750: -- hi [~rombert], the cp-converter comes with it's own visitors that are used to converter resource-based to principal-based. so those visitors need to be adjusted to cover the new methods otherwise the unsupported-operation-exception from the default (i assume exists) will kick in. we had that in the past and i want to avoid us running in the same issue again. but other than that i don't believe the new methods require any special handling. hope that helps > Support the new repoinit statements "enforce principal ACL" and "enforce > nodes" > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.0 > > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11749) resource resolver: document URL patterns in vanity paths and add test coverage
[ https://issues.apache.org/jira/browse/SLING-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-11749: Assignee: Julian Reschke > resource resolver: document URL patterns in vanity paths and add test coverage > -- > > Key: SLING-11749 > URL: https://issues.apache.org/jira/browse/SLING-11749 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > > MapEntries (in "private String[] getVanityPathDefinition(final String > pVanityPath)") currently attempts to detect URL-shaped paths, and rewrite > them to a prefix. > There are several issues here: > 1. there doesn't seem to be any concrete documentation about this > 2. apparently there is no test coverage - removing that code causes no test > failures > 3. it's unclear whether not replacing an empty string by "/" is intentional -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11755) resource resolver: add test coverage for URL patterns in vanity paths
[ https://issues.apache.org/jira/browse/SLING-11755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-11755: Assignee: Julian Reschke > resource resolver: add test coverage for URL patterns in vanity paths > - > > Key: SLING-11755 > URL: https://issues.apache.org/jira/browse/SLING-11755 > Project: Sling > Issue Type: Sub-task > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: Resource Resolver 1.10.2 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11757) resource resolver: pathless URL in vanity path causes NPE in ResourceMapperImpl.apply()
[
https://issues.apache.org/jira/browse/SLING-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber reassigned SLING-11757:
Assignee: Julian Reschke
> resource resolver: pathless URL in vanity path causes NPE in
> ResourceMapperImpl.apply()
> ---
>
> Key: SLING-11757
> URL: https://issues.apache.org/jira/browse/SLING-11757
> Project: Sling
> Issue Type: Sub-task
> Components: ResourceResolver
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> {noformat}
> java.lang.NullPointerException
> at java.lang.String.concat(String.java:2027)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:371)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:345)
> at java.util.ArrayList.replaceAll(ArrayList.java:1452)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:171)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest$ExpectedMappings.verify(ResourceMapperImplTest.java:510)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest.mapResourceWithVanityPathsURLTargetNoPath(ResourceMapperImplTest.java:402)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11756) resource resolver: rewrite getVanityPathDefinition for more clarity
[ https://issues.apache.org/jira/browse/SLING-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-11756: Assignee: Julian Reschke > resource resolver: rewrite getVanityPathDefinition for more clarity > > > Key: SLING-11756 > URL: https://issues.apache.org/jira/browse/SLING-11756 > Project: Sling > Issue Type: Sub-task > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: Resource Resolver 1.10.2 > > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11757) resource resolver: pathless URL in vanity path causes NPE in ResourceMapperImpl.apply()
[
https://issues.apache.org/jira/browse/SLING-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680691#comment-17680691
]
Angela Schreiber commented on SLING-11757:
--
hi [~reschke] , thanks a lot for the investigation... overall direction makes
sense to me. may i added one more suggestion? i would strongly recommend to
consistently add NotNull and Nullable annotations to the code as it really
helps avoiding this kind of bugs.
> resource resolver: pathless URL in vanity path causes NPE in
> ResourceMapperImpl.apply()
> ---
>
> Key: SLING-11757
> URL: https://issues.apache.org/jira/browse/SLING-11757
> Project: Sling
> Issue Type: Sub-task
> Components: ResourceResolver
>Reporter: Julian Reschke
>Priority: Major
>
> {noformat}
> java.lang.NullPointerException
> at java.lang.String.concat(String.java:2027)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:371)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl$ApplyContextPath.apply(ResourceMapperImpl.java:345)
> at java.util.ArrayList.replaceAll(ArrayList.java:1452)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getAllMappings(ResourceMapperImpl.java:171)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImpl.getMapping(ResourceMapperImpl.java:73)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest$ExpectedMappings.verify(ResourceMapperImplTest.java:510)
> at
> org.apache.sling.resourceresolver.impl.mapping.ResourceMapperImplTest.mapResourceWithVanityPathsURLTargetNoPath(ResourceMapperImplTest.java:402)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11750) Support the new repoinit statements "enforce principal ACL" and "enforce nodes"
[ https://issues.apache.org/jira/browse/SLING-11750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17675859#comment-17675859 ] Angela Schreiber commented on SLING-11750: -- [~kwin], thanks for creating the ticket, really appreciated. afaik cp2fm does actually parse repoinit statements (not only generates them). > Support the new repoinit statements "enforce principal ACL" and "enforce > nodes" > --- > > Key: SLING-11750 > URL: https://issues.apache.org/jira/browse/SLING-11750 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > > With SLING-11736 and SLING-10281 new statements have been introduced. Those > should be supported in cp2fm as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646580#comment-17646580
]
Angela Schreiber commented on SLING-10110:
--
[~SonglessHill], should be ok now.
> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
> Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a
> general problem.
> The issue i am facing is that in my dispatcher configuration there are
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under
> the ignoreUrlParams it does not see the above parameter from the url as
> matching for ignoreUrlParams.
>
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was
> configured to ignore this parameter, the response will be cached with an
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not
> clear enough please tell me and i will try to update everything that is needed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[
https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber reassigned SLING-10110:
Assignee: Andreas Bannasch
> Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
> -
>
> Key: SLING-10110
> URL: https://issues.apache.org/jira/browse/SLING-10110
> Project: Sling
> Issue Type: Bug
>Affects Versions: Dynamic Include 3.2.0
> Environment: AEM 6.3 - AEM 6.5
>Reporter: Andreas Bannasch
>Assignee: Andreas Bannasch
>Priority: Major
> Fix For: Dynamic Include 3.3.2
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Hello
> i have the following problem in my AEM instance but i think it might be a
> general problem.
> The issue i am facing is that in my dispatcher configuration there are
> several parameters defined with a * as wildcard.
> This is configured for our tracking engine where users might get a link to a
> page with one of these parameters.
> For example:
> {code:html}
> https//www.mypage.com/latest-news?testengine-usergroup=10
> {code}
> In this case my dispatcher is configured to ignore the paramers that match
> the following:
> {code:html}
> testengine-*
> {code}
> When i configured this in my SlingDynamicInclude config on the server under
> the ignoreUrlParams it does not see the above parameter from the url as
> matching for ignoreUrlParams.
>
> {code:config}
> include-filter.config.extension=""
> include-filter.config.enabled=B"true"
> include-filter.config.path="/content"
> include-filter.config.required_header="Server-Agent\=Communique-Dispatcher"
> include-filter.config.include-type="SSI"
> include-filter.config.selector="nocache"
> include-filter.config.add_comment=B"true"
> include-filter.config.appendSuffix=B"true"
> include-filter.config.rewrite=B"false"
> include-filter.config.ttl=""
> # These are the urlParams from the dispatcher that are ignored by as such and
> will load from cache (for tracking etc.)
> # If you do not ignore them then a page with rendered SDI will be cached if
> the call contains these parameters
> include-filter.config.ignoreUrlParams=[
> "gclid",
> "testengine-*"
> ]
> include-filter.config.resource-types=[
> "mypage/components/slingdynamic/dynamicbanner"
> ]
> {code}
> Instead the SDI component will completely render and since my dispatcher was
> configured to ignore this parameter, the response will be cached with an
> already rendered SDI-Component instead of the SDI-Tag.
> I hope this information is enough to understand what my problem is.
> If there are some more informations that you need or if something is not
> clear enough please tell me and i will try to update everything that is needed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11723) Expose more authentication information from ResourceResolver
[
https://issues.apache.org/jira/browse/SLING-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646528#comment-17646528
]
Angela Schreiber commented on SLING-11723:
--
for the JCR specific pieces i believe it should be possible to adapt the
resource resolver to a jcr session and use the bound principals attribute that
you have added lately (see
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java#L287-L289).
> Expose more authentication information from ResourceResolver
>
>
> Key: SLING-11723
> URL: https://issues.apache.org/jira/browse/SLING-11723
> Project: Sling
> Issue Type: Improvement
> Components: API
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently ResourceResolver only exposes the {{getUserID()}} for debugging
> authorization related issues. With the addition of SLING-6963 it would be
> helpful to additionally expose:
> - if a resource resolver is a service resource resolver (applies to all
> providers)
> - if it is based on principal names or regular authorizable ids (JCR provider
> specific, although the configuration format is agnostic)
> This information is crucial to figure out why a particular resource cannot be
> resolved (due to missing permissions).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11467) support to update existing paths via repoinit statement
[ https://issues.apache.org/jira/browse/SLING-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643384#comment-17643384 ] Angela Schreiber commented on SLING-11467: -- if this improvement is adopted i would suggest to use a similar solution than exists for user/group creation that allows to make sure the specified intermediate path is really used (and not ignored if the user/group already exists) with a 'forced' key word (see https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/main/javacc/RepoInitGrammar.jjt#L103). > support to update existing paths via repoinit statement > --- > > Key: SLING-11467 > URL: https://issues.apache.org/jira/browse/SLING-11467 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Reporter: Darshan Mahor >Priority: Major > > As of now we can't update the path if it already exists in repository[1] via > repoinit statements like update primary type etc. This request is to support > the mechanism via which we can modify/update the existing paths with the > update/modification provided in repoinit statement. e.g. lets suppose we have > a path in repostiory /content/test/testchild(nt:folder) and we want to > modify it to /content/test/testchild(sling:Folder). > > [1]. > [https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java#L189] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11467) support to update existing paths via repoinit statement
[ https://issues.apache.org/jira/browse/SLING-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642398#comment-17642398 ] Angela Schreiber commented on SLING-11467: -- [~kwin], no worries, it does work :-). i was about to reply to [~joerghoh] and you were just faster there is no need to move around stuff and recreate or remove. [~joerghoh], is right though that this operation may fail if the new node type comes with additional/different constraints that are not automatically adjusted. so far repo-init doesn't provide any notion of best-effort and if an operation fails the whole repo-init fails which leads to abortion of repository startup. on the other hand one might argue that the customer of the repoinit has the ability to try it out and eventually fix the script if it doesn't work. i guess i most cases the changes wold be simple and doable. > support to update existing paths via repoinit statement > --- > > Key: SLING-11467 > URL: https://issues.apache.org/jira/browse/SLING-11467 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Reporter: Darshan Mahor >Priority: Major > > As of now we can't update the path if it already exists in repository[1] via > repoinit statements like update primary type etc. This request is to support > the mechanism via which we can modify/update the existing paths with the > update/modification provided in repoinit statement. e.g. lets suppose we have > a path in repostiory /content/test/testchild(nt:folder) and we want to > modify it to /content/test/testchild(sling:Folder). > > [1]. > [https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java#L189] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11616) Build and test with Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11616: - Fix Version/s: (was: Content-Package to Feature Model Converter 1.1.24) > Build and test with Windows > --- > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Konrad Windszus >Priority: Major > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11663) Create all service users with forced path
[ https://issues.apache.org/jira/browse/SLING-11663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11663. -- Resolution: Fixed > Create all service users with forced path > - > > Key: SLING-11663 > URL: https://issues.apache.org/jira/browse/SLING-11663 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.22 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.24 > > > as discussed with [~kpauls] and [~Sc0rpic0m] in private conversation the > converter should have the ability to create all service users with a forced > path (not just when principal-based access control setup is enforced). > with this additional flexibility present we can safely run the converter > repeatedly on an existing repository having > _--enforce-principal-based-supported-path_ configuration enabled and disabled > as it would not only move service users to the supported path but also > restore the original path as specified in repoinit and content-package if > executed again with the configuration disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11507) Field injection should not inject static fields
[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630317#comment-17630317
]
Angela Schreiber commented on SLING-11507:
--
[~diru], thanks a lot! your post and me pinging [~sseifert] and [~kwin] have
just crossed. i am not familiar with sling models but if a review/input from an
outsider is helpful please ping me.
> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11507) Field injection should not inject static fields
[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630313#comment-17630313
]
Angela Schreiber commented on SLING-11507:
--
hi [~sseifert] and [~kwin], it would be awesome if you could provide input or
help to get this issue fixed. wdyt?
cc: [~cziegeler], [~chaotic]
> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11312) Improve test coverage
[ https://issues.apache.org/jira/browse/SLING-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11312: - Fix Version/s: (was: JCR Resource 3.2.4) > Improve test coverage > - > > Key: SLING-11312 > URL: https://issues.apache.org/jira/browse/SLING-11312 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.2.0 >Reporter: Angela Schreiber >Priority: Major > > today test coverage of the _org-apache-sling-jcr-resource_ module is at 56.2% > which IMHO is quite poor for code that is such a fundamental piece of sling. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11507) Field injection should not inject static fields
[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628946#comment-17628946
]
Angela Schreiber commented on SLING-11507:
--
[~rombert], sounds good to me.
IMHO having static fields/methods annotated sounds like a terrible idea and I
can't imagine that this was ever intended to work but rather simply was
overlooked.
So, I think we should actually treat this as a bug and not just as a task or
improvement. Would you know who is the original author or otherwise deeper
knowledge into this area and could provide additional insight and possible work
on a fix?
> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11507) Field injection should not inject static fields
[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11507:
-
Issue Type: Bug (was: Task)
> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Major
> Fix For: Sling Models Implementation 1.5
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11507) Field injection should not inject static fields
[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11507:
-
Priority: Critical (was: Major)
> Field injection should not inject static fields
> ---
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Models Impl 1.4.14
>Reporter: Joerg Hoh
>Priority: Critical
> Fix For: Sling Models Implementation 1.5
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11663) Create all service users with forced path
Angela Schreiber created SLING-11663: Summary: Create all service users with forced path Key: SLING-11663 URL: https://issues.apache.org/jira/browse/SLING-11663 Project: Sling Issue Type: Improvement Components: Content-Package to Feature Model Converter Affects Versions: Content-Package to Feature Model Converter 1.1.22 Reporter: Angela Schreiber Assignee: Angela Schreiber Fix For: Content-Package to Feature Model Converter 1.1.24 as discussed with [~kpauls] and [~Sc0rpic0m] in private conversation the converter should have the ability to create all service users with a forced path (not just when principal-based access control setup is enforced). with this additional flexibility present we can safely run the converter repeatedly on an existing repository having _--enforce-principal-based-supported-path_ configuration enabled and disabled as it would not only move service users to the supported path but also restore the original path as specified in repoinit and content-package if executed again with the configuration disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor
[
https://issues.apache.org/jira/browse/SLING-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-11653.
--
Resolution: Fixed
> DefaultAclManager.calculateEnforcedIntermediatePath fails for supported
> ancestor
>
>
> Key: SLING-11653
> URL: https://issues.apache.org/jira/browse/SLING-11653
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.20
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.22
>
>
> {{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the
> case where the passed intermediate path is a valid ancestor of the configured
> {{enforcePrincipalBasedSupportedPath}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor
[
https://issues.apache.org/jira/browse/SLING-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11653:
-
Fix Version/s: Content-Package to Feature Model Converter 1.1.22
> DefaultAclManager.calculateEnforcedIntermediatePath fails for supported
> ancestor
>
>
> Key: SLING-11653
> URL: https://issues.apache.org/jira/browse/SLING-11653
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.20
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.22
>
>
> {{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the
> case where the passed intermediate path is a valid ancestor of the configured
> {{enforcePrincipalBasedSupportedPath}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor
[
https://issues.apache.org/jira/browse/SLING-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11653:
-
Affects Version/s: Content-Package to Feature Model Converter 1.1.20
> DefaultAclManager.calculateEnforcedIntermediatePath fails for supported
> ancestor
>
>
> Key: SLING-11653
> URL: https://issues.apache.org/jira/browse/SLING-11653
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.20
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> {{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the
> case where the passed intermediate path is a valid ancestor of the configured
> {{enforcePrincipalBasedSupportedPath}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11653) DefaultAclManager.calculateEnforcedIntermediatePath fails for supported ancestor
Angela Schreiber created SLING-11653:
Summary: DefaultAclManager.calculateEnforcedIntermediatePath fails
for supported ancestor
Key: SLING-11653
URL: https://issues.apache.org/jira/browse/SLING-11653
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Reporter: Angela Schreiber
Assignee: Angela Schreiber
{{DefaultAclManager.calculateEnforcedIntermediatePath}} does not cover the case
where the passed intermediate path is a valid ancestor of the configured
{{enforcePrincipalBasedSupportedPath}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients
[ https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612876#comment-17612876 ] Angela Schreiber commented on SLING-11611: -- [~nscendoni], i tentatively assigned this ticket to you. hope that is ok... otherwise feel free to unassign. > Provide method to retrieve Pid for OSGI Configurations in Sling Testing > Clients > --- > > Key: SLING-11611 > URL: https://issues.apache.org/jira/browse/SLING-11611 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.16 >Reporter: Nicola Scendoni >Assignee: Nicola Scendoni >Priority: Minor > > During development of IT Tests it may be needed to search the pid for some > OSGI Configuration not created by the test itself. > I will provide an implementation to search the pid of configurations from > serviceType and the value of a property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11609) Provide doGetWithRetry methods in Sling Testing Clients
[ https://issues.apache.org/jira/browse/SLING-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612875#comment-17612875 ] Angela Schreiber commented on SLING-11609: -- [~nscendoni], i am assigning the ticket to you given that you have provided a PR. hope that's ok. > Provide doGetWithRetry methods in Sling Testing Clients > --- > > Key: SLING-11609 > URL: https://issues.apache.org/jira/browse/SLING-11609 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.16 >Reporter: Nicola Scendoni >Assignee: Nicola Scendoni >Priority: Minor > > In several situations during IT Tests development we need to retry doGet > method until some assertion are verified. > I propose in the attached pull request an implementation and test for new > methods doGetWithRetry -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11611) Provide method to retrieve Pid for OSGI Configurations in Sling Testing Clients
[ https://issues.apache.org/jira/browse/SLING-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-11611: Assignee: Nicola Scendoni > Provide method to retrieve Pid for OSGI Configurations in Sling Testing > Clients > --- > > Key: SLING-11611 > URL: https://issues.apache.org/jira/browse/SLING-11611 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.16 >Reporter: Nicola Scendoni >Assignee: Nicola Scendoni >Priority: Minor > > During development of IT Tests it may be needed to search the pid for some > OSGI Configuration not created by the test itself. > I will provide an implementation to search the pid of configurations from > serviceType and the value of a property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11609) Provide doGetWithRetry methods in Sling Testing Clients
[ https://issues.apache.org/jira/browse/SLING-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-11609: Assignee: Nicola Scendoni > Provide doGetWithRetry methods in Sling Testing Clients > --- > > Key: SLING-11609 > URL: https://issues.apache.org/jira/browse/SLING-11609 > Project: Sling > Issue Type: Improvement > Components: Apache Sling Testing Clients >Affects Versions: Apache Sling Testing Clients 3.0.16 >Reporter: Nicola Scendoni >Assignee: Nicola Scendoni >Priority: Minor > > In several situations during IT Tests development we need to retry doGet > method until some assertion are verified. > I propose in the attached pull request an implementation and test for new > methods doGetWithRetry -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11482. -- Resolution: Fixed > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Fix Version/s: JCR Resource 3.2.2 > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Bug > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: JCR Resource 3.2.2 > > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Issue Type: Improvement (was: Bug) > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: JCR Resource 3.2.2 > > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-11482: Assignee: Angela Schreiber > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Bug > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11482) Redundant checks for null
Angela Schreiber created SLING-11482: Summary: Redundant checks for null Key: SLING-11482 URL: https://issues.apache.org/jira/browse/SLING-11482 Project: Sling Issue Type: Bug Components: JCR Reporter: Angela Schreiber https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11482) Redundant checks for null
[ https://issues.apache.org/jira/browse/SLING-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-11482: - Priority: Major (was: Minor) > Redundant checks for null > - > > Key: SLING-11482 > URL: https://issues.apache.org/jira/browse/SLING-11482 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > > https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-resource > reports a couple of redundant null-checks in _sling.org.apache.jcr.resource_. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11311) Improve org-apache-sling-jcr-resource
[ https://issues.apache.org/jira/browse/SLING-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11311. -- Resolution: Fixed > Improve org-apache-sling-jcr-resource > - > > Key: SLING-11311 > URL: https://issues.apache.org/jira/browse/SLING-11311 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.2.0 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > while working on SLING-10011 i noticed a considerable amount of issues > reported by sonar, which are trivial to fix and would improve overall code > quality. > apart from sonar findings we should fix > - inconsistent formatting > - unused imports > - missing nullable/notnull annotations > - complexity -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11468) Simplify JcrPropertyMapCacheEntry.convertToType
[ https://issues.apache.org/jira/browse/SLING-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11468. -- Fix Version/s: JCR Resource 3.2.2 Resolution: Fixed > Simplify JcrPropertyMapCacheEntry.convertToType > --- > > Key: SLING-11468 > URL: https://issues.apache.org/jira/browse/SLING-11468 > Project: Sling > Issue Type: Sub-task > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11468) Simplify JcrPropertyMapCacheEntry.convertToType
Angela Schreiber created SLING-11468: Summary: Simplify JcrPropertyMapCacheEntry.convertToType Key: SLING-11468 URL: https://issues.apache.org/jira/browse/SLING-11468 Project: Sling Issue Type: Sub-task Components: JCR Reporter: Angela Schreiber Assignee: Angela Schreiber -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11465) NPE in JcrPropertyMapCacheEntry when converting from InputStream value to Number
[
https://issues.apache.org/jira/browse/SLING-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-11465.
--
Fix Version/s: JCR Resource 3.2.2
Resolution: Fixed
> NPE in JcrPropertyMapCacheEntry when converting from InputStream value to
> Number
>
>
> Key: SLING-11465
> URL: https://issues.apache.org/jira/browse/SLING-11465
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> while working on SLING-11461 trying to reduce complexity in
> {{JcrPropertyMapCacheEntry}}. i spotted that this class is prone to multiple
> NPEs.
> in case of value being of type {{InputStream}} conversion to a number will
> try to retrieve the length of the {{property}} fields, which however is null
> if {{JcrPropertyMapCacheEntry}} has been created with a value and a node.
> [~cziegeler] fyi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11465) NPE in JcrPropertyMapCacheEntry when converting from InputStream value to Number
[
https://issues.apache.org/jira/browse/SLING-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber reassigned SLING-11465:
Assignee: Angela Schreiber
> NPE in JcrPropertyMapCacheEntry when converting from InputStream value to
> Number
>
>
> Key: SLING-11465
> URL: https://issues.apache.org/jira/browse/SLING-11465
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> while working on SLING-11461 trying to reduce complexity in
> {{JcrPropertyMapCacheEntry}}. i spotted that this class is prone to multiple
> NPEs.
> in case of value being of type {{InputStream}} conversion to a number will
> try to retrieve the length of the {{property}} fields, which however is null
> if {{JcrPropertyMapCacheEntry}} has been created with a value and a node.
> [~cziegeler] fyi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11466) JcrPropertyMapCacheEntry: ValueFormatException when converting value InputStream to number-array
[
https://issues.apache.org/jira/browse/SLING-11466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber reassigned SLING-11466:
Assignee: Angela Schreiber
> JcrPropertyMapCacheEntry: ValueFormatException when converting value
> InputStream to number-array
>
>
> Key: SLING-11466
> URL: https://issues.apache.org/jira/browse/SLING-11466
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
>
> this is related to SLING-11465:
> when creating a {{JcrPropertyMapCacheEntry}} from a single-valued Binary
> Property and convert it to a number-array, the conversion will fail with
> {{ValueFormatException}}.
> the reason is {{convertToArray}} is called with an array constructed from the
> singular property value. looping over the array will call {{convertToType}}
> with an index != -1 which results in
> {{Long.valueOf(this.property.getLengths()[index])}}. however, for a
> single-valued property {{getLengths}} fails with {{ValueFormatException}} ->
> consequently null is returned instead of the length of the property.
> [~cziegeler] fyi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11466) JcrPropertyMapCacheEntry: ValueFormatException when converting value InputStream to number-array
[
https://issues.apache.org/jira/browse/SLING-11466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-11466.
--
Fix Version/s: JCR Resource 3.2.2
Resolution: Fixed
> JcrPropertyMapCacheEntry: ValueFormatException when converting value
> InputStream to number-array
>
>
> Key: SLING-11466
> URL: https://issues.apache.org/jira/browse/SLING-11466
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
>
> this is related to SLING-11465:
> when creating a {{JcrPropertyMapCacheEntry}} from a single-valued Binary
> Property and convert it to a number-array, the conversion will fail with
> {{ValueFormatException}}.
> the reason is {{convertToArray}} is called with an array constructed from the
> singular property value. looping over the array will call {{convertToType}}
> with an index != -1 which results in
> {{Long.valueOf(this.property.getLengths()[index])}}. however, for a
> single-valued property {{getLengths}} fails with {{ValueFormatException}} ->
> consequently null is returned instead of the length of the property.
> [~cziegeler] fyi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11466) JcrPropertyMapCacheEntry: ValueFormatException when converting value InputStream to number-array
[
https://issues.apache.org/jira/browse/SLING-11466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11466:
-
Description:
this is related to SLING-11465:
when creating a {{JcrPropertyMapCacheEntry}} from a single-valued Binary
Property and convert it to a number-array, the conversion will fail with
{{ValueFormatException}}.
the reason is {{convertToArray}} is called with an array constructed from the
singular property value. looping over the array will call {{convertToType}}
with an index != -1 which results in
{{Long.valueOf(this.property.getLengths()[index])}}. however, for a
single-valued property {{getLengths}} fails with {{ValueFormatException}} ->
consequently null is returned instead of the length of the property.
[~cziegeler] fyi
was:
this is related to SLING-11465:
when creating a {{JcrPropertyMapCacheEntry}} from a single-valued Binary
Property and convert it to a number-array, the conversion will fail with
{{ValueFormatException}}.
the reason is {{convertToArray}} is called with an array constructed from the
singular property value. looping over the array will call {{convertToType}}
with an index != -1 which results in
{{Long.valueOf(this.property.getLengths()[index])}}. however, for a
single-valued property {{getLengths}} fails with {{ValueFormatException}} ->
consequently null is returned instead of the length of the property.
> JcrPropertyMapCacheEntry: ValueFormatException when converting value
> InputStream to number-array
>
>
> Key: SLING-11466
> URL: https://issues.apache.org/jira/browse/SLING-11466
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Angela Schreiber
>Priority: Major
>
> this is related to SLING-11465:
> when creating a {{JcrPropertyMapCacheEntry}} from a single-valued Binary
> Property and convert it to a number-array, the conversion will fail with
> {{ValueFormatException}}.
> the reason is {{convertToArray}} is called with an array constructed from the
> singular property value. looping over the array will call {{convertToType}}
> with an index != -1 which results in
> {{Long.valueOf(this.property.getLengths()[index])}}. however, for a
> single-valued property {{getLengths}} fails with {{ValueFormatException}} ->
> consequently null is returned instead of the length of the property.
> [~cziegeler] fyi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11465) NPE in JcrPropertyMapCacheEntry when converting from InputStream value to Number
[
https://issues.apache.org/jira/browse/SLING-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11465:
-
Description:
while working on SLING-11461 trying to reduce complexity in
{{JcrPropertyMapCacheEntry}}. i spotted that this class is prone to multiple
NPEs.
in case of value being of type {{InputStream}} conversion to a number will try
to retrieve the length of the {{property}} fields, which however is null if
{{JcrPropertyMapCacheEntry}} has been created with a value and a node.
[~cziegeler] fyi
was:
while working on SLING-11461 trying to reduce complexity in
{{JcrPropertyMapCacheEntry}}. i spotted that this class is prone to multiple
NPEs.
in case of value being of type {{InputStream}} conversion to a number will try
to retrieve the length of the {{property}} fields, which however is null if
{{JcrPropertyMapCacheEntry}} has been created with a value and a node.
> NPE in JcrPropertyMapCacheEntry when converting from InputStream value to
> Number
>
>
> Key: SLING-11465
> URL: https://issues.apache.org/jira/browse/SLING-11465
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Angela Schreiber
>Priority: Major
>
> while working on SLING-11461 trying to reduce complexity in
> {{JcrPropertyMapCacheEntry}}. i spotted that this class is prone to multiple
> NPEs.
> in case of value being of type {{InputStream}} conversion to a number will
> try to retrieve the length of the {{property}} fields, which however is null
> if {{JcrPropertyMapCacheEntry}} has been created with a value and a node.
> [~cziegeler] fyi
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11466) JcrPropertyMapCacheEntry: ValueFormatException when converting value InputStream to number-array
Angela Schreiber created SLING-11466:
Summary: JcrPropertyMapCacheEntry: ValueFormatException when
converting value InputStream to number-array
Key: SLING-11466
URL: https://issues.apache.org/jira/browse/SLING-11466
Project: Sling
Issue Type: Bug
Components: JCR
Reporter: Angela Schreiber
this is related to SLING-11465:
when creating a {{JcrPropertyMapCacheEntry}} from a single-valued Binary
Property and convert it to a number-array, the conversion will fail with
{{ValueFormatException}}.
the reason is {{convertToArray}} is called with an array constructed from the
singular property value. looping over the array will call {{convertToType}}
with an index != -1 which results in
{{Long.valueOf(this.property.getLengths()[index])}}. however, for a
single-valued property {{getLengths}} fails with {{ValueFormatException}} ->
consequently null is returned instead of the length of the property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11465) NPE in JcrPropertyMapCacheEntry when converting from InputStream value to Number
Angela Schreiber created SLING-11465:
Summary: NPE in JcrPropertyMapCacheEntry when converting from
InputStream value to Number
Key: SLING-11465
URL: https://issues.apache.org/jira/browse/SLING-11465
Project: Sling
Issue Type: Bug
Components: JCR
Reporter: Angela Schreiber
while working on SLING-11461 trying to reduce complexity in
{{JcrPropertyMapCacheEntry}}. i spotted that this class is prone to multiple
NPEs.
in case of value being of type {{InputStream}} conversion to a number will try
to retrieve the length of the {{property}} fields, which however is null if
{{JcrPropertyMapCacheEntry}} has been created with a value and a node.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11461) Reduce complexity
[ https://issues.apache.org/jira/browse/SLING-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11461. -- Fix Version/s: JCR Resource 3.2.2 Resolution: Fixed > Reduce complexity > - > > Key: SLING-11461 > URL: https://issues.apache.org/jira/browse/SLING-11461 > Project: Sling > Issue Type: Sub-task > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11461) Reduce complexity
Angela Schreiber created SLING-11461: Summary: Reduce complexity Key: SLING-11461 URL: https://issues.apache.org/jira/browse/SLING-11461 Project: Sling Issue Type: Sub-task Components: JCR Reporter: Angela Schreiber Assignee: Angela Schreiber -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11454) Add missing notnull/nullable annotations
[ https://issues.apache.org/jira/browse/SLING-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11454. -- Fix Version/s: JCR Resource 3.2.2 Resolution: Fixed > Add missing notnull/nullable annotations > > > Key: SLING-11454 > URL: https://issues.apache.org/jira/browse/SLING-11454 > Project: Sling > Issue Type: Sub-task > Components: JCR >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Minor > Fix For: JCR Resource 3.2.2 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11454) Add missing notnull/nullable annotations
Angela Schreiber created SLING-11454: Summary: Add missing notnull/nullable annotations Key: SLING-11454 URL: https://issues.apache.org/jira/browse/SLING-11454 Project: Sling Issue Type: Sub-task Components: JCR Reporter: Angela Schreiber Assignee: Angela Schreiber -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11384) Repoinitparserservice - create path on root level doesn't parse node type
[
https://issues.apache.org/jira/browse/SLING-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554023#comment-17554023
]
Angela Schreiber commented on SLING-11384:
--
hi [~cziegeler], [~Sc0rpic0m], [~rombert], would it be possible to adjust the
test case a bit as it is quite confusing.
- repoinit "create path xyz" _does not_ allow you to set the sling:resourceType
property as was implied by the original summary
- sling:resourceType property would need to be modified through 'set properties'
- afaik _sling:redirect_ is not a valid primary type but rather a resource type
and an attempt to use it in create path will fail with NoSuchNodeTypeException
- since repoinit tests are used to generate the documentation i would prefer if
there no misleading examples in there.
wdyt?
> Repoinitparserservice - create path on root level doesn't parse node type
> -
>
> Key: SLING-11384
> URL: https://issues.apache.org/jira/browse/SLING-11384
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Niek Raaijmakers
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Repoinit Parser 1.6.16
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When calling the repoinitparserservice as follows:
> {code:java}
> repoInitParserService.parse(new StringReader("create path
> /(sling:redirect)\n")).get(0).asRepoInitString() {code}
> The result is:
> {code:java}
> create path \n {code}
> What we expect is:
> {code:java}
> create path /(sling:redirect)\n {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SLING-11384) Repoinitparserservice - create path on root level doesn't parse node type
[
https://issues.apache.org/jira/browse/SLING-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11384:
-
Summary: Repoinitparserservice - create path on root level doesn't parse
node type (was: Repoinitparserservice - create path on root level doesn't
parse resource type)
> Repoinitparserservice - create path on root level doesn't parse node type
> -
>
> Key: SLING-11384
> URL: https://issues.apache.org/jira/browse/SLING-11384
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Niek Raaijmakers
>Priority: Major
>
> When calling the repoinitparserservice as follows:
> {code:java}
> repoInitParserService.parse(new StringReader("create path
> /(sling:redirect)\n")).get(0).asRepoInitString() {code}
> The result is:
> {code:java}
> create path \n {code}
> What we expect is:
> {code:java}
> create path /(sling:redirect)\n {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-11384) Repoinitparserservice - create path on root level doesn't parse resource type
[
https://issues.apache.org/jira/browse/SLING-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551527#comment-17551527
]
Angela Schreiber commented on SLING-11384:
--
[~bdelacretaz], this issues surfaced during a customer escalation. would you
have time to take a look and fix it? (and yes: sling:redirect is not a valid
primary type... but that's a different story and should not matter because
afaik jcr-repoinit will not validate the primary type information if the node
already exists).
> Repoinitparserservice - create path on root level doesn't parse resource type
> -
>
> Key: SLING-11384
> URL: https://issues.apache.org/jira/browse/SLING-11384
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Niek Raaijmakers
>Priority: Major
>
> When calling the repoinitparserservice as follows:
> {code:java}
> repoInitParserService.parse(new StringReader("create path
> /(sling:redirect)\n")).get(0).asRepoInitString() {code}
> The result is:
> {code:java}
> create path \n {code}
> What we expect is:
> {code:java}
> create path /(sling:redirect)\n {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SLING-11384) Repoinitparserservice - create path on root level doesn't parse resource type
[
https://issues.apache.org/jira/browse/SLING-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11384:
-
Priority: Major (was: Minor)
> Repoinitparserservice - create path on root level doesn't parse resource type
> -
>
> Key: SLING-11384
> URL: https://issues.apache.org/jira/browse/SLING-11384
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Niek Raaijmakers
>Priority: Major
>
> When calling the repoinitparserservice as follows:
> {code:java}
> repoInitParserService.parse(new StringReader("create path
> /(sling:redirect)\n")).get(0).asRepoInitString() {code}
> The result is:
> {code:java}
> create path \n {code}
> What we expect is:
> {code:java}
> create path /(sling:redirect)\n {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (SLING-11367) Potential NPE as ResolveContext.getProviderState() is nullable
[
https://issues.apache.org/jira/browse/SLING-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-11367.
--
Fix Version/s: JCR Resource 3.2.2
Resolution: Fixed
> Potential NPE as ResolveContext.getProviderState() is nullable
> ---
>
> Key: SLING-11367
> URL: https://issues.apache.org/jira/browse/SLING-11367
> Project: Sling
> Issue Type: Sub-task
> Components: JCR
>Affects Versions: JCR Resource 3.2.0
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: JCR Resource 3.2.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> since {{ResolveContext.getProviderState()}} is defined to return a nullable
> provider state code analysis spots this a potential source for NPE. according
> to [~cziegeler] this should never return null as long as the provider is
> active.
> i would suggest to move access to session, resourcefactory and helperdata to
> a utility with comments on why the NPE should not occur.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (SLING-11367) Potential NPE as ResolveContext.getProviderState() is nullable
[
https://issues.apache.org/jira/browse/SLING-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber reassigned SLING-11367:
Assignee: Angela Schreiber
> Potential NPE as ResolveContext.getProviderState() is nullable
> ---
>
> Key: SLING-11367
> URL: https://issues.apache.org/jira/browse/SLING-11367
> Project: Sling
> Issue Type: Sub-task
> Components: JCR
>Affects Versions: JCR Resource 3.2.0
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
>
> since {{ResolveContext.getProviderState()}} is defined to return a nullable
> provider state code analysis spots this a potential source for NPE. according
> to [~cziegeler] this should never return null as long as the provider is
> active.
> i would suggest to move access to session, resourcefactory and helperdata to
> a utility with comments on why the NPE should not occur.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-11367) Potential NPE as ResolveContext.getProviderState() is nullable
[
https://issues.apache.org/jira/browse/SLING-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545355#comment-17545355
]
Angela Schreiber commented on SLING-11367:
--
[~cziegeler], i don't think my fix would make the code more complicated.
instead it would IMHO become more readable and the next developer looking at
this would not be wondering why nobody cared about a potential NPE. i will
create a PR and let you review it.
> Potential NPE as ResolveContext.getProviderState() is nullable
> ---
>
> Key: SLING-11367
> URL: https://issues.apache.org/jira/browse/SLING-11367
> Project: Sling
> Issue Type: Sub-task
> Components: JCR
>Affects Versions: JCR Resource 3.2.0
>Reporter: Angela Schreiber
>Priority: Minor
>
> since {{ResolveContext.getProviderState()}} is defined to return a nullable
> provider state code analysis spots this a potential source for NPE. according
> to [~cziegeler] this should never return null as long as the provider is
> active.
> i would suggest to move access to session, resourcefactory and helperdata to
> a utility with comments on why the NPE should not occur.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (SLING-11367) Potential NPE as ResolveContext.getProviderState() is nullable
Angela Schreiber created SLING-11367:
Summary: Potential NPE as ResolveContext.getProviderState() is
nullable
Key: SLING-11367
URL: https://issues.apache.org/jira/browse/SLING-11367
Project: Sling
Issue Type: Sub-task
Components: JCR
Affects Versions: JCR Resource 3.2.0
Reporter: Angela Schreiber
since {{ResolveContext.getProviderState()}} is defined to return a nullable
provider state code analysis spots this a potential source for NPE. according
to [~cziegeler] this should never return null as long as the provider is active.
i would suggest to move access to session, resourcefactory and helperdata to a
utility with comments on why the NPE should not occur.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-11357) Fix nullable/notnull annotations
[
https://issues.apache.org/jira/browse/SLING-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544474#comment-17544474
]
Angela Schreiber commented on SLING-11357:
--
[~joerghoh], [~cziegeler] fixing some obvious mistakes in the notnull/nullable
annoations will surface a few redundant checks for null in
{{JcrValueMap}} and {{JcrModifiableValueMap}}. i didn't clean those up but it
might we worth taking a second look. wdyt?
> Fix nullable/notnull annotations
>
>
> Key: SLING-11357
> URL: https://issues.apache.org/jira/browse/SLING-11357
> Project: Sling
> Issue Type: Sub-task
> Components: JCR
>Affects Versions: JCR Resource 3.2.0
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: JCR Resource 3.2.2
>
>
> - incompatible notnull annotation in JcrResourceProvider.java
> - missing notnull/nullable in overriding method
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (SLING-11357) Fix nullable/notnull annotations
[ https://issues.apache.org/jira/browse/SLING-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber resolved SLING-11357. -- Fix Version/s: JCR Resource 3.2.2 Resolution: Fixed > Fix nullable/notnull annotations > > > Key: SLING-11357 > URL: https://issues.apache.org/jira/browse/SLING-11357 > Project: Sling > Issue Type: Sub-task > Components: JCR >Affects Versions: JCR Resource 3.2.0 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: JCR Resource 3.2.2 > > > - incompatible notnull annotation in JcrResourceProvider.java > - missing notnull/nullable in overriding method -- This message was sent by Atlassian Jira (v8.20.7#820007)
