[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117202#comment-15117202 ] Robert Munteanu commented on SLING-4585: Applied in [r1726793|https://svn.apache.org/r1726793], thanks for the contribution > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Assignee: Robert Munteanu >Priority: Critical > Labels: performance > Fix For: JCR Resource 2.6.0 > > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044890#comment-15044890 ] Robert Munteanu commented on SLING-4585: [~joelrich] - I'll apply right after commons-testing is released > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Fix For: JCR Resource 2.6.0 > > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968773#comment-14968773 ] Joel Richard commented on SLING-4585: - Unfortunately, I have forgotten to increment the API version of the Jackrabbit API which is why we have to wait another release cycle to get this change in (see JCR-3919). The good news is that this change will likely be more effective than anticipated for non-admin users because of the ACL overhead which can be reduced (especially GlobPattern.WildcardPattern in Oak). > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936570#comment-14936570 ] Carsten Ziegeler commented on SLING-4585: - We should require the latest Jackrabbit api, therefore please no reflection. > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936550#comment-14936550 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936552#comment-14936552 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936555#comment-14936555 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936553#comment-14936553 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936554#comment-14936554 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936556#comment-14936556 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936559#comment-14936559 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936558#comment-14936558 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936557#comment-14936557 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936551#comment-14936551 ] Carsten Ziegeler commented on SLING-4585: - I don't understand this comment, can you please clarify? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936604#comment-14936604 ] Joel Richard commented on SLING-4585: - It has to use the latest version for the tests though. There is a TODO in the patch to figure out how to do this. Is it maybe possible to use the latest version with the test scope? > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936652#comment-14936652 ] Carsten Ziegeler commented on SLING-4585: - :) Which means we can't apply the patch > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936599#comment-14936599 ] Joel Richard commented on SLING-4585: - As long as the changes in the Jackrabbit API/core haven't been released, we cannot commit this change. However, [~tomek.rekawek] wants to proceed with SLING-4750 as quickly as possible and that's why we have decided to reopen this issue. > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936638#comment-14936638 ] Robert Munteanu commented on SLING-4585: You can't do that with Maven 3. You can either: - move the tests to separate module requiring a different version - require a new version in the pom.xml but manually set the Import-Package versions based on the older version > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936600#comment-14936600 ] Carsten Ziegeler commented on SLING-4585: - Yeah, sorry I got confused - let's use reflection, but in that case we should not update the dependencies in the pom. > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[
https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936595#comment-14936595
]
Joel Richard commented on SLING-4585:
-
Sure, I can revert this. I am just a little bit surprised because above you
said:
{quote}We should make sure that the implementation still runs on older
jackrabbit api versions and simply reverts to the old behaviour. Otherwise
updating the jcr resource bundle requires updating the jcr implementation; we
should avoid this{quote}
> Performance: Use JackrabbitSession#getItemOrNull to speed up
> JcrResourceProvider#createResource
> ---
>
> Key: SLING-4585
> URL: https://issues.apache.org/jira/browse/SLING-4585
> Project: Sling
> Issue Type: Improvement
> Components: JCR, ResourceResolver
>Affects Versions: JCR Resource 2.5.0
>Reporter: Joel Richard
>Priority: Critical
> Labels: performance
> Attachments:
> 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch
>
>
> If the current session is a JackrabbitSession, JcrResourceProvider should use
> getItemOrNull (as soon as exported) to save rendering time.
> See referenced issue and the following mail thread for more information:
> http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936629#comment-14936629 ] Carsten Ziegeler commented on SLING-4585: - I think we don't need the test. This is not testing the Sling code, but it's testing whether getItemOrNull is doing the right thing If we have to do some testing here and need the new API, then we have to hand-craft the package import for the packages. Otherwise we're bound to the latest version anyway. And we really should not have SNAPSHOT dependencies to other projects in Sling. This makes building Sling way too hard > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936650#comment-14936650 ] Joel Richard commented on SLING-4585: - [~cziegeler], the tests are intended to ensure that the behaviour between the two ways of retrieving the items is exactly the same. I think they are necessary because the old way, for example, would not have thrown an exception for empty paths while jackrabbitSession.getItemOrNull throws one. Therefore, it needs some special handling to ensure that the behaviour is the same and I think this should have test coverage because otherwise it might happen that somebody will remove the special handling in the future. The snapshot dependencies are not meant to be committed to the Sling code base (which is indicated by the todo above). > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936812#comment-14936812 ] Joel Richard commented on SLING-4585: - Right, we have to wait until Jackrabbit/Oak has been released with the getItemOrNull changes (should be done in 2 weeks if I remember correctly). > Performance: Use JackrabbitSession#getItemOrNull to speed up > JcrResourceProvider#createResource > --- > > Key: SLING-4585 > URL: https://issues.apache.org/jira/browse/SLING-4585 > Project: Sling > Issue Type: Improvement > Components: JCR, ResourceResolver >Affects Versions: JCR Resource 2.5.0 >Reporter: Joel Richard >Priority: Critical > Labels: performance > Attachments: > 0001-SLING-4585-Performance-Use-JackrabbitSession-getItem.patch > > > If the current session is a JackrabbitSession, JcrResourceProvider should use > getItemOrNull (as soon as exported) to save rendering time. > See referenced issue and the following mail thread for more information: > http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14484913#comment-14484913 ] Felix Meschberger commented on SLING-4585: -- As I pointed at in [my comment|https://issues.apache.org/jira/browse/JCR-3870?focusedCommentId=14484909page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14484909] to JCR-3870: New API is not needed and not helpfull. Rather the implementation of the API should be improved to support the API usage pattern as suggested by the API specification. As such, I think there is nothing to be done in Sling. BTW: I once tested replacing the current if-exists-then-access pattern with a try-access-catch pattern. Overall performance of the resource resovler was actually worse and so the existing pattern prevails. Also, using exceptions for flow control is bad programming styl so I prefer keeping the if-exists-then-access pattern -- of course, best would be if the JCR's getItem method would just return null if an item is not existing or not visible... Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource --- Key: SLING-4585 URL: https://issues.apache.org/jira/browse/SLING-4585 Project: Sling Issue Type: Improvement Components: JCR, ResourceResolver Affects Versions: JCR Resource 2.5.0 Reporter: Joel Richard Priority: Critical Labels: performance If the current session is a JackrabbitSession, JcrResourceProvider should use getItemOrNull (as soon as exported) to save rendering time. See referenced issue and the following mail thread for more information: http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/%3CD1495A09.3B670%25anchela%40adobe.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483136#comment-14483136 ] Carsten Ziegeler commented on SLING-4585: - We should make sure that the implementation still runs on older jackrabbit api versions and simply reverts to the old behaviour. Otherwise updating the jcr resource bundle requires updating the jcr implementation; we should avoid this Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource --- Key: SLING-4585 URL: https://issues.apache.org/jira/browse/SLING-4585 Project: Sling Issue Type: Improvement Components: JCR, ResourceResolver Affects Versions: JCR Resource 2.5.0 Reporter: Joel Richard Priority: Critical Labels: performance If the current session is a JackrabbitSession, JcrResourceProvider should use getItemOrNull (as soon as exported) to save rendering time. See referenced issue and the following mail thread for more information: http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/browser -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483150#comment-14483150 ] Joel Richard commented on SLING-4585: - Is there a way to achieve this without using a try/catch to detect whether the method is available or using reflection? Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource --- Key: SLING-4585 URL: https://issues.apache.org/jira/browse/SLING-4585 Project: Sling Issue Type: Improvement Components: JCR, ResourceResolver Affects Versions: JCR Resource 2.5.0 Reporter: Joel Richard Priority: Critical Labels: performance If the current session is a JackrabbitSession, JcrResourceProvider should use getItemOrNull (as soon as exported) to save rendering time. See referenced issue and the following mail thread for more information: http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/browser -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4585) Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource
[ https://issues.apache.org/jira/browse/SLING-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483151#comment-14483151 ] Joel Richard commented on SLING-4585: - Is there a way to achieve this without using a try/catch to detect whether the method is available or using reflection? Performance: Use JackrabbitSession#getItemOrNull to speed up JcrResourceProvider#createResource --- Key: SLING-4585 URL: https://issues.apache.org/jira/browse/SLING-4585 Project: Sling Issue Type: Improvement Components: JCR, ResourceResolver Affects Versions: JCR Resource 2.5.0 Reporter: Joel Richard Priority: Critical Labels: performance If the current session is a JackrabbitSession, JcrResourceProvider should use getItemOrNull (as soon as exported) to save rendering time. See referenced issue and the following mail thread for more information: http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201504.mbox/browser -- This message was sent by Atlassian JIRA (v6.3.4#6332)
