[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334845#comment-16334845 ] Oliver Lietz commented on SLING-7251: - [~npeltier], fine with me. > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1633#comment-1633 ] Nicolas Peltier commented on SLING-7251: [~olli] - integrated your commit, removed service user creation (not used for now, but created SLING-7425) - didn't change maven-bundle-plugin to bnd's could that be discussed more widely as a general best practice for sling's projects? > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334252#comment-16334252 ] Oliver Lietz commented on SLING-7251: - [~npeltier], very close (just waiting for releases under vote and probably new i18n bundle). > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334241#comment-16334241 ] Nicolas Peltier commented on SLING-7251: [~olli] last (hopefully) question, is testing.paxexam 1.0.0 close to be released? pipes 2.0.0 should be, and i guess snapshot deps are bad > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332353#comment-16332353
]
Oliver Lietz commented on SLING-7251:
-
[~npeltier], no. Calls in ITs from test bundle are allowed by whitelisting the
bundle:
{noformat}
newConfiguration("org.apache.sling.jcr.base.internal.LoginAdminWhitelist")
.put("whitelist.bundles.regexp", "^PAXEXAM.*$")
.asOption(),
{noformat}
Now I see service user is configurable. So the current configuration in
{{PipesTestSupport}} is fine (can we restrict write to {{/content}} and
{{/var}} though?), but required. AFAIR tests failed due to NPE when adapting to
{{ModifiableValueMap}} in {{PlumberImpl}}.
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332337#comment-16332337
]
Nicolas Peltier commented on SLING-7251:
[~olli] for the ACLs, are you referring to loginAdministrative in integration
tests?
everything under {{src/main}} is tied to
- either passed in resolver (delegating to caller code the security)
- either service-user's resolver (i hadn't created in test)
if you are referring to {{src/test}}, i'll change that (now i know how to do
:-))
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332324#comment-16332324
]
Oliver Lietz commented on SLING-7251:
-
Pipes is writing to the repository (not using the authenticated request
resource resolver), this should be restricted as much as possible with a
dedicated service user. The current configuration (which I had to add) in
{{PipesTestSupport}} allows full read/write on {{/}}.
The logs in {{target/failsafe-reports}} are in plain text.
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332307#comment-16332307
]
Nicolas Peltier commented on SLING-7251:
wow thanks a lot [~olli]!
* for ACLs i don't see where you'd want some? i was assuming the ones we have
in the parents (/etc, /var) are already good?
* Service user is required for certain tasks (async pipes mostly), but for the
rest, i use the user from the request.
* {{target/failsafe-reports}} is good but i hate the xml format
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332219#comment-16332219
]
Oliver Lietz commented on SLING-7251:
-
[~npeltier], didn't notice I had to activate ITs with profile... after that no
succesful build at all.
The IT has several issues (don't forget: you're testing against real Sling):
* request is not authenticated
* IT uses private Pipes package ({{org.apache.sling.pipes.internal.JsonWriter}}
and {{org.apache.sling.pipes.internal.JsonUtil}})
* there is no service user and ACL for Pipes
I've done some more optimization:
* updated to Parent 33-SNAPSHOT and Testing PaxExam 1.0.0-SNAPSHOT (not
required, for convenience only)
* added [Resource
Presence|https://github.com/apache/sling-org-apache-sling-resource-presence] to
ensure presence of {{/etc/pipes-it}}
* removed {{logging()}} as {{exam.properties}} is missing and log in
{{target/failsafe-reports}} is sufficient
Please have a look at branch
[issue/SLING-7251|https://github.com/apache/sling-org-apache-sling-pipes/tree/issue/SLING-7251].
* ACL should be improved
* {{assertEquals("there should be 2 elements", 2, ((Double)
main.get("size")).intValue());}} is ugly
* use {{bnd-maven-plugin}} instead of {{maven-bundle-plugin}}
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332021#comment-16332021
]
Nicolas Peltier commented on SLING-7251:
[~olli] interesting. How long does the tests take for you (good indicator of
load i guess):
for me
{Code}
---
T E S T S
---
Running org.apache.sling.pipes.it.PipeBuilderIT
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.548 sec - in
org.apache.sling.pipes.it.PipeBuilderIT
Running org.apache.sling.pipes.it.PlumberTestIT
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.367 sec - in
org.apache.sling.pipes.it.PlumberTestIT
Running org.apache.sling.pipes.it.PlumberServletIT
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 14.186 sec - in
org.apache.sling.pipes.it.PlumberServletIT
Running org.apache.sling.pipes.it.PipeModelIT
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 18.167 sec <<<
FAILURE! - in org.apache.sling.pipes.it.PipeModelIT
testListComponent(org.apache.sling.pipes.it.PipeModelIT) Time elapsed: 3.586
sec <<< ERROR!
java.io.FileNotFoundException:
http://localhost:62056/content/list-component.html
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1872)
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474)
at java.net.URL.openStream(URL.java:1045)
at
org.apache.sling.pipes.it.PipeModelIT.testListComponent(PipeModelIT.java:53)
{Code}
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331951#comment-16331951 ] Nicolas Peltier commented on SLING-7251: [~olli] not really, looks more like random failure. Doesn't it fail for you? > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Priority: Major > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327101#comment-16327101 ] Oliver Lietz commented on SLING-7251: - [~npeltier], is your test system under pressure (CPU/IO) when this test fails? > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Priority: Major > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
