Re: [vote] Accept the contribution of Log Tail Plugin tracked in SLING-4897
Hi Bertrand, I have received the acceptance mail from Craig stating that the ICLA has been filed. Please let me know the further steps to take. Thanks. -- Varun On Thu, Aug 6, 2015 at 4:16 PM, Varun Nagpal varun.nag...@gmail.com wrote: Thanks Bertrand, Chetan and Robert for the +1s @Bertrand, I have mailed the iCLA. Awaiting further instructions. Thanks. -- Varun On Tue, Aug 4, 2015 at 7:08 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, On Wed, Jul 22, 2015 at 4:15 PM, Varun Nagpal varun.nag...@gmail.com wrote: This thread is about voting for the acceptance of the Log Tail Plugin tracked in SLING-4897... +1 for the donation - with this we have 3 +1s from PMC members so we can go on. Varun, could you submit an iCLA as per https://www.apache.org/licenses/icla.txt ? Once that's filed we can commit your patch, as it's a fairly small contribution I don't think a software grant is required. -Bertrand
Re: [vote] Accept the contribution of Log Tail Plugin tracked in SLING-4897
Thanks Bertrand, Chetan and Robert for the +1s @Bertrand, I have mailed the iCLA. Awaiting further instructions. Thanks. -- Varun On Tue, Aug 4, 2015 at 7:08 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, On Wed, Jul 22, 2015 at 4:15 PM, Varun Nagpal varun.nag...@gmail.com wrote: This thread is about voting for the acceptance of the Log Tail Plugin tracked in SLING-4897... +1 for the donation - with this we have 3 +1s from PMC members so we can go on. Varun, could you submit an iCLA as per https://www.apache.org/licenses/icla.txt ? Once that's filed we can commit your patch, as it's a fairly small contribution I don't think a software grant is required. -Bertrand
Re: [vote] Accept the contribution of Log Tail Plugin tracked in SLING-4897
Hi, On Wed, Jul 22, 2015 at 4:15 PM, Varun Nagpal varun.nag...@gmail.com wrote: This thread is about voting for the acceptance of the Log Tail Plugin tracked in SLING-4897... +1 for the donation - with this we have 3 +1s from PMC members so we can go on. Varun, could you submit an iCLA as per https://www.apache.org/licenses/icla.txt ? Once that's filed we can commit your patch, as it's a fairly small contribution I don't think a software grant is required. -Bertrand
Re: [vote] Accept the contribution of Log Tail Plugin tracked in SLING-4897
On Wed, 2015-07-29 at 13:34 +0530, Varun Nagpal wrote: Hi Robert, Fixed the issues related to AL headers and reattached the zip archive with new md5sum (69576a5b3155684659c1112eb8923274). Looks good to me, thanks! +1 for accepting the contribution Robert Please have a look. Thanks. -- Varun On Fri, Jul 24, 2015 at 7:08 PM, Robert Munteanu romb...@apache.org wrote: On Wed, 2015-07-22 at 19:45 +0530, Varun Nagpal wrote: Hi, This thread is about voting for the acceptance of the Log Tail Plugin tracked in SLING-4897. An archive (sling-logtail.zip, md5sum 6d14f2ef4748c00e63cbbaeda7224e3c) containing the contribution is attached to SLING-4897 and otherwise available at [0]. With a rat check some files fail due to missing/unapproved licenses: Unapproved licenses: src/main/java/org/apache/sling/tail/impl/LogTailerWebConsolePlugin .jav a src/main/java/org/apache/sling/tail/LogFilter.java src/main/resources/libs/tail/css/tail.css src/main/resources/libs/tail/js/tail.js pom.xml To reproduce, change the parent pom version from 22 to 24 and run mvn verify This should be fixed before accepting the contribution. Thanks, Robert
Re: [vote] Accept the contribution of Log Tail Plugin tracked in SLING-4897
Hi Robert, Fixed the issues related to AL headers and reattached the zip archive with new md5sum (69576a5b3155684659c1112eb8923274). Please have a look. Thanks. -- Varun On Fri, Jul 24, 2015 at 7:08 PM, Robert Munteanu romb...@apache.org wrote: On Wed, 2015-07-22 at 19:45 +0530, Varun Nagpal wrote: Hi, This thread is about voting for the acceptance of the Log Tail Plugin tracked in SLING-4897. An archive (sling-logtail.zip, md5sum 6d14f2ef4748c00e63cbbaeda7224e3c) containing the contribution is attached to SLING-4897 and otherwise available at [0]. With a rat check some files fail due to missing/unapproved licenses: Unapproved licenses: src/main/java/org/apache/sling/tail/impl/LogTailerWebConsolePlugin.jav a src/main/java/org/apache/sling/tail/LogFilter.java src/main/resources/libs/tail/css/tail.css src/main/resources/libs/tail/js/tail.js pom.xml To reproduce, change the parent pom version from 22 to 24 and run mvn verify This should be fixed before accepting the contribution. Thanks, Robert
Re: [vote] Accept the contribution of Log Tail Plugin tracked in SLING-4897
On Wed, 2015-07-22 at 19:45 +0530, Varun Nagpal wrote: Hi, This thread is about voting for the acceptance of the Log Tail Plugin tracked in SLING-4897. An archive (sling-logtail.zip, md5sum 6d14f2ef4748c00e63cbbaeda7224e3c) containing the contribution is attached to SLING-4897 and otherwise available at [0]. With a rat check some files fail due to missing/unapproved licenses: Unapproved licenses: src/main/java/org/apache/sling/tail/impl/LogTailerWebConsolePlugin.jav a src/main/java/org/apache/sling/tail/LogFilter.java src/main/resources/libs/tail/css/tail.css src/main/resources/libs/tail/js/tail.js pom.xml To reproduce, change the parent pom version from 22 to 24 and run mvn verify This should be fixed before accepting the contribution. Thanks, Robert
Re: [vote] Accept the contribution of Log Tail Plugin tracked in SLING-4897
+1 Chetan Mehrotra On Wed, Jul 22, 2015 at 7:45 PM, Varun Nagpal varun.nag...@gmail.com wrote: Hi, This thread is about voting for the acceptance of the Log Tail Plugin tracked in SLING-4897. An archive (sling-logtail.zip, md5sum 6d14f2ef4748c00e63cbbaeda7224e3c) containing the contribution is attached to SLING-4897 and otherwise available at [0]. Please cast your votes. Thanks and Regards, Varun Nagpal [0] https://github.com/vnagpal81/sling-logtail
