Re: [VOTE] Release Apache Sling i18n 2.6.2

2023-02-15 Thread Carsten Ziegeler

+1

Carsten

Am 15.02.2023 um 07:54 schrieb Carsten Ziegeler:

Hi,

We solved 3 issues in this release
https://issues.apache.org/jira/projects/SLING/versions/12350841


Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2718


You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2718 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten


--
Carsten Ziegeler
Adobe
cziege...@apache.org


[jira] [Commented] (SLING-11763) Not all 'style' properties are preserved in the HTML output.

2023-02-15 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689009#comment-17689009
 ] 

Robert Munteanu commented on SLING-11763:
-

All good, thanks for confirming [~kwin]

>  Not all 'style' properties are preserved in the HTML output.
> -
>
> Key: SLING-11763
> URL: https://issues.apache.org/jira/browse/SLING-11763
> Project: Sling
>  Issue Type: Bug
>  Components: XSS Protection API
>Affects Versions: XSS Protection API 2.3.0
>Reporter: Tatyana Vogel
>Assignee: Tatyana Vogel
>Priority: Blocker
> Fix For: XSS Protection API 2.3.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When trying to add the ‘style’ property ‘text-align: right’ (or center) the 
> text will be displayed as left-aligned.
> T{color:#1d1c1d}his is regression compared to the previous version{color}.
> Expected Behavior: Text should be displayed on the right or center like 
> decelerated in the ‘style=“text-align:...“’ property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-resourcemerger] raducotescu merged pull request #10: Fixes for SLING-11774, SLING-11775

2023-02-15 Thread via GitHub


raducotescu merged PR #10:
URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-resourcemerger] kwin commented on a diff in pull request #10: Fixes for SLING-11774, SLING-11775

2023-02-15 Thread via GitHub


kwin commented on code in PR #10:
URL: 
https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/10#discussion_r1106962764


##
src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java:
##
@@ -64,7 +67,11 @@ protected void deactivate() {
 }
 
 @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.MULTIPLE)
-public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, 
Map properties) {
+public void bindMergedResourcePicker(MergedResourcePicker resourcePicker,

Review Comment:
   @raducotescu TBH I don't understand this. Why are the defaults not injected 
in the bind method?
   The spec says
   > An event method can take one or more parameters.An event method can take 
one or more parameters. ...
   > Map - An unmodifiable Map containing the service properties of the bound 
service. This Map must additionally implement Comparable with the compareTo 
method comparing service property maps using the same ordering as 
ServiceReference.compareTo based upon service ranking and service id.
   
(https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-method.injection)



##
src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java:
##
@@ -64,7 +67,11 @@ protected void deactivate() {
 }
 
 @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.MULTIPLE)
-public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, 
Map properties) {
+public void bindMergedResourcePicker(MergedResourcePicker resourcePicker,

Review Comment:
   @raducotescu TBH I don't understand this. Why are the defaults not injected 
in the bind method?
   The spec says
   > An event method can take one or more parameters.An event method can take 
one or more parameters. ...
   > Map - An unmodifiable Map containing the service properties of the bound 
service. This Map must additionally implement Comparable with the compareTo 
method comparing service property maps using the same ordering as 
ServiceReference.compareTo based upon service ranking and service id.
   
   
(https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-method.injection)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-resourcemerger] kwin commented on a diff in pull request #10: Fixes for SLING-11774, SLING-11775

2023-02-15 Thread via GitHub


kwin commented on code in PR #10:
URL: 
https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/10#discussion_r1106962764


##
src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java:
##
@@ -64,7 +67,11 @@ protected void deactivate() {
 }
 
 @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.MULTIPLE)
-public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, 
Map properties) {
+public void bindMergedResourcePicker(MergedResourcePicker resourcePicker,

Review Comment:
   @raducotescu TBH I don't understand this. Why are the defaults not injected 
in the bind method?
   The spec says
   > An event method can take one or more parameters
   > Map - An unmodifiable Map containing the service properties of the bound 
service. This Map must additionally implement Comparable with the compareTo 
method comparing service property maps using the same ordering as 
ServiceReference.compareTo based upon service ranking and service id.
   
   
(https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-method.injection)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [VOTE] Release Apache Sling i18n 2.6.2

2023-02-15 Thread Angela Schreiber
+1

kind regards
angela


From: Carsten Ziegeler 
Sent: Wednesday, February 15, 2023 10:04
To: dev@sling.apache.org 
Subject: Re: [VOTE] Release Apache Sling i18n 2.6.2


+1

Carsten

Am 15.02.2023 um 07:54 schrieb Carsten Ziegeler:
> Hi,
>
> We solved 3 issues in this release
> https://issues.apache.org/jira/projects/SLING/versions/12350841
>
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2718
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2718 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten

--
Carsten Ziegeler
Adobe
cziege...@apache.org


[GitHub] [sling-org-apache-sling-resourcemerger] raducotescu commented on a diff in pull request #10: Fixes for SLING-11774, SLING-11775

2023-02-15 Thread via GitHub


raducotescu commented on code in PR #10:
URL: 
https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/10#discussion_r1106986628


##
src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java:
##
@@ -64,7 +67,11 @@ protected void deactivate() {
 }
 
 @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.MULTIPLE)
-public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, 
Map properties) {
+public void bindMergedResourcePicker(MergedResourcePicker resourcePicker,

Review Comment:
   I think it had something to do with the change from #8 not being implemented 
the same way in my initial set of changes. You're right - if I compare the 
properties map from the service reference with the map parameter of the 
previous signature they are now identical.
   
   I can revert the commit for SLING-11774 without any problems.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-resourcemerger] raducotescu commented on a diff in pull request #10: Fixes for SLING-11774, SLING-11775

2023-02-15 Thread via GitHub


raducotescu commented on code in PR #10:
URL: 
https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/10#discussion_r1106989572


##
src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java:
##
@@ -64,7 +67,11 @@ protected void deactivate() {
 }
 
 @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = 
ReferenceCardinality.MULTIPLE)
-public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, 
Map properties) {
+public void bindMergedResourcePicker(MergedResourcePicker resourcePicker,

Review Comment:
   See 
https://github.com/apache/sling-org-apache-sling-resourcemerger/commit/a04dcc3048cb6c9d719e41a5a04593b6942fdb92.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations

2023-02-15 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-11774.
--
Resolution: Duplicate

> Fix the registration of the MergedResourcePicker2 implementations
> -
>
> Key: SLING-11774
> URL: https://issues.apache.org/jira/browse/SLING-11774
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> It seems the improvement from SLING-10168 introduced a subtle bug, where the 
> components are registered only based on configuration properties, completely 
> ignoring their default configuration (where applicable).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations

2023-02-15 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-11774:
-
Fix Version/s: (was: Resource Merger 1.4.2)

> Fix the registration of the MergedResourcePicker2 implementations
> -
>
> Key: SLING-11774
> URL: https://issues.apache.org/jira/browse/SLING-11774
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> It seems the improvement from SLING-10168 introduced a subtle bug, where the 
> components are registered only based on configuration properties, completely 
> ignoring their default configuration (where applicable).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11774) Fix the registration of the MergedResourcePicker2 implementations

2023-02-15 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-11774.


> Fix the registration of the MergedResourcePicker2 implementations
> -
>
> Key: SLING-11774
> URL: https://issues.apache.org/jira/browse/SLING-11774
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> It seems the improvement from SLING-10168 introduced a subtle bug, where the 
> components are registered only based on configuration properties, completely 
> ignoring their default configuration (where applicable).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (SLING-11506) Streamline and document resource (super) type merging

2023-02-15 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-11506:
--

It seems this change is actually breaking client code. There is client code out 
there expecting the sling:resourceType property to *not* reflect the resource 
type of the resource. The code rather expects it to be the value from the 
merged resources.
While such behaviour is questionable, breaking existing code is not an option

> Streamline and document resource (super) type merging
> -
>
> Key: SLING-11506
> URL: https://issues.apache.org/jira/browse/SLING-11506
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Merger 1.4.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SLING-4340 the merging of resource types has been changed so that it gives 
> the resourceType property precedence over {{Resource.getResourceType()}} 
> (https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/f821f844ba675e3850189debf8e45239026c5709/src/main/java/org/apache/sling/resourcemerger/impl/MergedResource.java#L74-L92).
> This change is questionable and kind of unexpected from the user's side and 
> also leads to undesired side effects like outlined in SLING-11504.
> So in the best case the merging of resource types doesn't rely on properties 
> (which are implementation details of the underlying resolvers) but clearly 
> derives from either the lowest or highest resource without breaking the use 
> cases outlined in SLING-4340.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11506) Streamline and document resource (super) type merging

2023-02-15 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689113#comment-17689113
 ] 

Carsten Ziegeler commented on SLING-11506:
--

Reverted setting the properties for resource and resource super type. 
https://github.com/apache/sling-org-apache-sling-resourcemerger/commit/b58f734bb43ee7a6f173bed12793695af5ee2eba

> Streamline and document resource (super) type merging
> -
>
> Key: SLING-11506
> URL: https://issues.apache.org/jira/browse/SLING-11506
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Merger 1.4.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SLING-4340 the merging of resource types has been changed so that it gives 
> the resourceType property precedence over {{Resource.getResourceType()}} 
> (https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/f821f844ba675e3850189debf8e45239026c5709/src/main/java/org/apache/sling/resourcemerger/impl/MergedResource.java#L74-L92).
> This change is questionable and kind of unexpected from the user's side and 
> also leads to undesired side effects like outlined in SLING-11504.
> So in the best case the merging of resource types doesn't rely on properties 
> (which are implementation details of the underlying resolvers) but clearly 
> derives from either the lowest or highest resource without breaking the use 
> cases outlined in SLING-4340.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-11506) Streamline and document resource (super) type merging

2023-02-15 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-11506.
--
Resolution: Fixed

> Streamline and document resource (super) type merging
> -
>
> Key: SLING-11506
> URL: https://issues.apache.org/jira/browse/SLING-11506
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Merger 1.4.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SLING-4340 the merging of resource types has been changed so that it gives 
> the resourceType property precedence over {{Resource.getResourceType()}} 
> (https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/f821f844ba675e3850189debf8e45239026c5709/src/main/java/org/apache/sling/resourcemerger/impl/MergedResource.java#L74-L92).
> This change is questionable and kind of unexpected from the user's side and 
> also leads to undesired side effects like outlined in SLING-11504.
> So in the best case the merging of resource types doesn't rely on properties 
> (which are implementation details of the underlying resolvers) but clearly 
> derives from either the lowest or highest resource without breaking the use 
> cases outlined in SLING-4340.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-10720) "nt:unstructured" is used in case of overwriting node with no sling:resourceType property defined (JCR Resource Merger)

2023-02-15 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-10720:
-
Fix Version/s: (was: Resource Merger 1.4.2)

> "nt:unstructured" is used in case of overwriting node with no 
> sling:resourceType property defined (JCR Resource Merger)
> ---
>
> Key: SLING-10720
> URL: https://issues.apache.org/jira/browse/SLING-10720
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Merger 1.4.0
>Reporter: Henry Kuijpers
>Priority: Major
>
> https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/c9d742c8080a0976b778c678747d99289c9efbb7/src/main/java/org/apache/sling/resourcemerger/impl/MergedResource.java#L75
> In this constructor, I see the following logic:
> 1. Try to find the sling:resourceType property, set in any of the resources
> 2. If that property could not be found, try using the relative path
> Then, even if a proper sling:resourceType property was found, it will 
> overwrite that value with the result of Resource#getResourceType if it is not 
> null, of the last resource that defines one. This could be entirely right 
> (maybe this done because some people use wrappers, that override the 
> getResourceType-method?).
> However, in the JCR implementation of Resource 
> (JcrNodeResource/JcrItemResource), it is rare for getResourceType to return 
> null, because:
> 1. Try to return the defined sling:resourceType's value
> 2. If not found, try to return the value of jcr:primaryType
> Generally, any node has a jcr:primaryType defined and thus returns it.
> When the overridden resource does not mention a resource type, this 
> effectively makes getResourceType of the merged resource return the node type 
> of the overridden resource (in our case: nt:unstructured).
> Easy case to reproduce:
> /libs/test (@jcr:primaryType: nt:unstructured, 
> @sling:resourceType=website/component, @prop=test)
> /apps/test (@jcr:primaryType: nt:unstructured, @prop=test-overridden)
> ->
> resource.getResourceType(): *nt:unstructured*
> resource.getResourceSuperType(): *website/component*
> resource.getValueMap().get("prop"): test-overridden
> resource.getValueMap().get("sling:resourceType"): *website/component*
> (Marked in the bold, the values I think are not correct in this case.)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (SLING-11506) Streamline and document resource (super) type merging

2023-02-15 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689113#comment-17689113
 ] 

Carsten Ziegeler edited comment on SLING-11506 at 2/15/23 1:10 PM:
---

Reverted setting the properties for resource and resource super type. 
https://github.com/apache/sling-org-apache-sling-resourcemerger/commit/b58f734bb43ee7a6f173bed12793695af5ee2eba

And updated the docs to reflect this.


was (Author: cziegeler):
Reverted setting the properties for resource and resource super type. 
https://github.com/apache/sling-org-apache-sling-resourcemerger/commit/b58f734bb43ee7a6f173bed12793695af5ee2eba

> Streamline and document resource (super) type merging
> -
>
> Key: SLING-11506
> URL: https://issues.apache.org/jira/browse/SLING-11506
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Resource Merger 1.4.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Resource Merger 1.4.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SLING-4340 the merging of resource types has been changed so that it gives 
> the resourceType property precedence over {{Resource.getResourceType()}} 
> (https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/f821f844ba675e3850189debf8e45239026c5709/src/main/java/org/apache/sling/resourcemerger/impl/MergedResource.java#L74-L92).
> This change is questionable and kind of unexpected from the user's side and 
> also leads to undesired side effects like outlined in SLING-11504.
> So in the best case the merging of resource types doesn't rely on properties 
> (which are implementation details of the underlying resolvers) but clearly 
> derives from either the lowest or highest resource without breaking the use 
> cases outlined in SLING-4340.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Pax Error with graphql-java 20.9

2023-02-15 Thread Andreas Schaefer
Hi

I ran into a build issue with Sling Graphql Core when I use graphql-java 20.0 
(the current released version). Even though that release will not be usable in 
an OSGi container the latest code will have the same issue.

The problem is that Pax together with Graphql-java cannot find the 
GenericConnection class. This works in 17.4 though. When I use the code in AEM 
to test graphql I don’t encounter issue with that class.

Error:

java.util.concurrent.CompletionException: java.lang.NoClassDefFoundError: 
org/apache/sling/graphql/helpers/GenericConnection
at 
java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:331)
at 
java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:346)
at 
java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:870)
at 
java.base/java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:883)
…
Caused by: java.lang.NoClassDefFoundError: 
org/apache/sling/graphql/helpers/GenericConnection
at 
graphql.schema.PropertyFetchingImpl.getPropertyValue(PropertyFetchingImpl.java:114)
at 
graphql.schema.PropertyDataFetcherHelper.getPropertyValue(PropertyDataFetcherHelper.java:22)
at 
graphql.schema.PropertyDataFetcher.getImpl(PropertyDataFetcher.java:131)
...
Caused by: java.lang.ClassNotFoundException: 
org.apache.sling.graphql.helpers.GenericConnection not found by graphql-java 
[209]
at 
org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1597)
at 
org.apache.felix.framework.BundleWiringImpl.access$300(BundleWiringImpl.java:79)
at 
org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1982)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
... 91 more

I am not a Pax expert and so I am stuck here.

The failing code can be found in branch: issue/SLING-10900-200 on module 
sling-org-apache-sling-graphql-core

Cheers - Andy

CVE-2023-25141 JNDI injection into Apache sling-org-apache-sling-jcr-base

2023-02-15 Thread Turritopsis Dohrnii Teo En Ming
Subject: CVE-2023-25141 JNDI injection into Apache
sling-org-apache-sling-jcr-base

Good day from Singapore,

Just sharing this CVE.

CVE: CVE-2023-25141 JNDI injection into Apache sling-org-apache-sling-jcr-base
Link: https://www.cve.org/CVERecord?id=CVE-2023-25141

Thank you.

Regards,

Mr. Turritopsis Dohrnii Teo En Ming
Targeted Individual in Singapore
Blogs:
https://tdtemcerts.blogspot.com
https://tdtemcerts.wordpress.com


[GitHub] [sling-org-apache-sling-testing-jcr-mock] catalinadumitruu opened a new pull request, #10: Add implementation for addMixin method

2023-02-15 Thread via GitHub


catalinadumitruu opened a new pull request, #10:
URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10

   Add implementation for method `addMixin()` according to developer 
documentation:
   
   > Adds the mixin node type named mixinName to this node. If this node is 
already of type mixinName (either due to a previously added mixin or due to its 
primary type, through inheritance) then this method has no effect. Otherwise 
mixinName is added to this node's jcr:mixinTypes property.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #10: Add implementation for addMixin method

2023-02-15 Thread via GitHub


sonarcloud[bot] commented on PR #10:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10#issuecomment-1432649853

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&resolved=false&types=CODE_SMELL)
   
   
[![66.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'66.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&metric=new_coverage&view=list)
 [66.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=10&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org