[jira] [Commented] (SLING-3014) Generate SCR descriptors using the maven-scr-plugin
[ https://issues.apache.org/jira/browse/SLING-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736948#comment-13736948 ] Konrad Windszus commented on SLING-3014: why is the m2e integration of maven-scr-plugin not sufficient (FELIX-3358)? > Generate SCR descriptors using the maven-scr-plugin > --- > > Key: SLING-3014 > URL: https://issues.apache.org/jira/browse/SLING-3014 > Project: Sling > Issue Type: Task > Components: IDE >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Minor > Fix For: Sling Eclipse IDE 1.0.0 > > Attachments: SLING-3014-1.patch > > > Since we're starting to use SCR descriptors it would be nice to generate them > using the maven-scr-plugin. I have the build working in the CLI, but not yet > in the IDE ( see > http://dev.eclipse.org/mhonarc/lists/tycho-user/msg04764.html ). Once that is > done I'll commit my changes to trunk. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3079) Move constant for "sling.auth.requirements" to AuthConstants
Konrad Windszus created SLING-3079: -- Summary: Move constant for "sling.auth.requirements" to AuthConstants Key: SLING-3079 URL: https://issues.apache.org/jira/browse/SLING-3079 Project: Sling Issue Type: Improvement Components: Authentication Affects Versions: Auth Core 1.1.2 Reporter: Konrad Windszus As this constant should also be used from Services defining any authentication restriction with an OSGi component property having that name (http://sling.apache.org/documentation/the-sling-engine/authentication/authentication-framework.html), it would be good to make it accessible to other bundles as well, by moving it from http://svn.apache.org/repos/asf/sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java to http://svn.apache.org/repos/asf/sling/trunk/bundles/auth/core/src/main/java/org/apache/sling/auth/core/AuthConstants.java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
Konrad Windszus created SLING-3093: -- Summary: All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic Key: SLING-3093 URL: https://issues.apache.org/jira/browse/SLING-3093 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus It is currently hard to modify any parameters within the Connection area of the "External Sling Launchpad" server overview, because the text cursor is set to the beginning of the field after adding a new character to it. E.g. if you try to enter the port "4502" you actually have to type "2054". For password "admin" you have to type "nimda". I don't know whether this is a property on the the input fields themselves or the cursor gets automatically reset to position 0 after each character (due to some validation). It works fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
[ https://issues.apache.org/jira/browse/SLING-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3093: --- Affects Version/s: Sling Eclipse IDE 1.0.0 > All input fields within the server overview for "External Sling Launchpad" > within the "Connection" section have right-to-left typing logic > -- > > Key: SLING-3093 > URL: https://issues.apache.org/jira/browse/SLING-3093 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Attachments: SlingIDEConnectionFieldsBug.png > > > It is currently hard to modify any parameters within the Connection area of > the "External Sling Launchpad" server overview, because the text cursor is > set to the beginning of the field after adding a new character to it. > E.g. if you try to enter the port "4502" you actually have to type "2054". > For password "admin" you have to type "nimda". I don't know whether this is a > property on the the input fields themselves or the cursor gets automatically > reset to position 0 after each character (due to some validation). It works > fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
[ https://issues.apache.org/jira/browse/SLING-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3093: --- Attachment: SlingIDEConnectionFieldsBug.png > All input fields within the server overview for "External Sling Launchpad" > within the "Connection" section have right-to-left typing logic > -- > > Key: SLING-3093 > URL: https://issues.apache.org/jira/browse/SLING-3093 > Project: Sling > Issue Type: Bug > Components: IDE >Reporter: Konrad Windszus > Attachments: SlingIDEConnectionFieldsBug.png > > > It is currently hard to modify any parameters within the Connection area of > the "External Sling Launchpad" server overview, because the text cursor is > set to the beginning of the field after adding a new character to it. > E.g. if you try to enter the port "4502" you actually have to type "2054". > For password "admin" you have to type "nimda". I don't know whether this is a > property on the the input fields themselves or the cursor gets automatically > reset to position 0 after each character (due to some validation). It works > fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3094) Unresolved compilation exception when opening a JSP file from a sling-content-module
Konrad Windszus created SLING-3094:
--
Summary: Unresolved compilation exception when opening a JSP file
from a sling-content-module
Key: SLING-3094
URL: https://issues.apache.org/jira/browse/SLING-3094
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
I get the following exception when opening a JSP file from a Maven project
being converted to a "sling-content-module"
{code}
java.lang.Error: Unresolved compilation problems:
The import org.apache.jackrabbit cannot be resolved
ISO9075 cannot be resolved
ISO9075 cannot be resolved
ISO9075 cannot be resolved
at
org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.(JcrNode.java:33)
at
org.apache.sling.ide.eclipse.ui.nav.model.SyncDir.(SyncDir.java:29)
at
org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:77)
at
org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
at
org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
at
org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
at
org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
at
org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.findSelection(LinkHelper.java:59)
at
org.eclipse.ui.navigator.LinkHelperService.getSelectionFor(LinkHelperService.java:126)
at
org.eclipse.ui.internal.navigator.actions.LinkEditorAction$4.run(LinkEditorAction.java:106)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at
org.eclipse.ui.internal.navigator.actions.LinkEditorAction$3.runInUIThread(LinkEditorAction.java:97)
at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at
org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3976)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3653)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
at
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
{code}
I compiled the P2 feature from
https://github.com/apache/sling/tree/tooling-ide-vlt/tooling/ide/p2update and
installed it locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3094) Unresolved compilation exception when opening a JSP file from a sling-content-module
[
https://issues.apache.org/jira/browse/SLING-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774439#comment-13774439
]
Konrad Windszus commented on SLING-3094:
The weird thing is that the class ISO9075 is inside the package
"org.apache.jackrabbit.util" and that package is exported by the bundle
"vlt-wrapper" correctly which is also installed correctly within Eclipse. The
error message indicated that obviously Eclipse is looking for the class in the
wrong package.
> Unresolved compilation exception when opening a JSP file from a
> sling-content-module
>
>
> Key: SLING-3094
> URL: https://issues.apache.org/jira/browse/SLING-3094
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Konrad Windszus
>
> I get the following exception when opening a JSP file from a Maven project
> being converted to a "sling-content-module"
> {code}
> java.lang.Error: Unresolved compilation problems:
> The import org.apache.jackrabbit cannot be resolved
> ISO9075 cannot be resolved
> ISO9075 cannot be resolved
> ISO9075 cannot be resolved
> at
> org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.(JcrNode.java:33)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.SyncDir.(SyncDir.java:29)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:77)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.findSelection(LinkHelper.java:59)
> at
> org.eclipse.ui.navigator.LinkHelperService.getSelectionFor(LinkHelperService.java:126)
> at
> org.eclipse.ui.internal.navigator.actions.LinkEditorAction$4.run(LinkEditorAction.java:106)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at
> org.eclipse.ui.internal.navigator.actions.LinkEditorAction$3.runInUIThread(LinkEditorAction.java:97)
> at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at
> org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3976)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3653)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
> at
> org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at
> org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> at
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> {code}
> I compiled the P2 feature from
> https://github.com/apache/sling/tree/tooling-ide-vlt/tooling/ide/p2update and
> installed it locally
[jira] [Commented] (SLING-3094) Unresolved compilation exception when opening a JSP file from a sling-content-module
[
https://issues.apache.org/jira/browse/SLING-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774468#comment-13774468
]
Konrad Windszus commented on SLING-3094:
Nevermind, it was obviously a broken build (colliding Eclipse Incremental
Compilation and CLI Maven Build). After installing a new build, everything went
fine.
> Unresolved compilation exception when opening a JSP file from a
> sling-content-module
>
>
> Key: SLING-3094
> URL: https://issues.apache.org/jira/browse/SLING-3094
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Konrad Windszus
>
> I get the following exception when opening a JSP file from a Maven project
> being converted to a "sling-content-module"
> {code}
> java.lang.Error: Unresolved compilation problems:
> The import org.apache.jackrabbit cannot be resolved
> ISO9075 cannot be resolved
> ISO9075 cannot be resolved
> ISO9075 cannot be resolved
> at
> org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.(JcrNode.java:33)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.SyncDir.(SyncDir.java:29)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:77)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.findSelection(LinkHelper.java:59)
> at
> org.eclipse.ui.navigator.LinkHelperService.getSelectionFor(LinkHelperService.java:126)
> at
> org.eclipse.ui.internal.navigator.actions.LinkEditorAction$4.run(LinkEditorAction.java:106)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at
> org.eclipse.ui.internal.navigator.actions.LinkEditorAction$3.runInUIThread(LinkEditorAction.java:97)
> at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at
> org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3976)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3653)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
> at
> org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at
> org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> at
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> {code}
> I compiled the P2 feature from
> https://github.com/apache/sling/tree/tooling-ide-vlt/tooling/ide/p2update and
> installed it locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more informat
[jira] [Resolved] (SLING-3094) Unresolved compilation exception when opening a JSP file from a sling-content-module
[
https://issues.apache.org/jira/browse/SLING-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-3094.
Resolution: Invalid
> Unresolved compilation exception when opening a JSP file from a
> sling-content-module
>
>
> Key: SLING-3094
> URL: https://issues.apache.org/jira/browse/SLING-3094
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Konrad Windszus
>
> I get the following exception when opening a JSP file from a Maven project
> being converted to a "sling-content-module"
> {code}
> java.lang.Error: Unresolved compilation problems:
> The import org.apache.jackrabbit cannot be resolved
> ISO9075 cannot be resolved
> ISO9075 cannot be resolved
> ISO9075 cannot be resolved
> at
> org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.(JcrNode.java:33)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.SyncDir.(SyncDir.java:29)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:77)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.createSelectionNode(LinkHelper.java:82)
> at
> org.apache.sling.ide.eclipse.ui.nav.model.LinkHelper.findSelection(LinkHelper.java:59)
> at
> org.eclipse.ui.navigator.LinkHelperService.getSelectionFor(LinkHelperService.java:126)
> at
> org.eclipse.ui.internal.navigator.actions.LinkEditorAction$4.run(LinkEditorAction.java:106)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> at
> org.eclipse.ui.internal.navigator.actions.LinkEditorAction$3.runInUIThread(LinkEditorAction.java:97)
> at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at
> org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3976)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3653)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
> at
> org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at
> org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> at
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> {code}
> I compiled the P2 feature from
> https://github.com/apache/sling/tree/tooling-ide-vlt/tooling/ide/p2update and
> installed it locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3095) StringIndexOutOfBoundsException within ContentXmlHandler.java:210
Konrad Windszus created SLING-3095:
--
Summary: StringIndexOutOfBoundsException within
ContentXmlHandler.java:210
Key: SLING-3095
URL: https://issues.apache.org/jira/browse/SLING-3095
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
I get the following exception during opening a JSP file
{code}
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
at java.lang.String.charAt(String.java:658)
at
org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler$TypeHint.parsePossiblyTypedValue(ContentXmlHandler.java:210)
at
org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler.startElement(ContentXmlHandler.java:67)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:506)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:376)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:602)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3065)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:881)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:607)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:116)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:489)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:835)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:123)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1210)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:568)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:302)
at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
at
org.apache.sling.ide.impl.vlt.serialization.VltSerializationManager.readSerializationData(VltSerializationManager.java:212)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.addFileCommand(SlingLaunchpadBehaviour.java:509)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishContentModule(SlingLaunchpadBehaviour.java:331)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishModule(SlingLaunchpadBehaviour.java:196)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModule(ServerBehaviourDelegate.java:1091)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModules(ServerBehaviourDelegate.java:1183)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:987)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774)
at
org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3153)
at
org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:345)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
{code}
To me it seems that the ContentXmlHandler does not deal with attributes having
an empty string as a value. Also for the future it would be great to
encapsulate all those exceptions within the VltSerializationManager to include
the filename in the exception as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3095) StringIndexOutOfBoundsException within ContentXmlHandler.java:210
[
https://issues.apache.org/jira/browse/SLING-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-3095:
---
Description:
I get the following exception during the publication of a sling-content-module:
{code}
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
at java.lang.String.charAt(String.java:658)
at
org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler$TypeHint.parsePossiblyTypedValue(ContentXmlHandler.java:210)
at
org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler.startElement(ContentXmlHandler.java:67)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:506)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:376)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:602)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3065)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:881)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:607)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:116)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:489)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:835)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:123)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1210)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:568)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:302)
at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
at
org.apache.sling.ide.impl.vlt.serialization.VltSerializationManager.readSerializationData(VltSerializationManager.java:212)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.addFileCommand(SlingLaunchpadBehaviour.java:509)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishContentModule(SlingLaunchpadBehaviour.java:331)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishModule(SlingLaunchpadBehaviour.java:196)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModule(ServerBehaviourDelegate.java:1091)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModules(ServerBehaviourDelegate.java:1183)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:987)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774)
at
org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3153)
at
org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:345)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
{code}
To me it seems that the ContentXmlHandler does not deal with attributes having
an empty string as a value. Also for the future it would be great to
encapsulate all those exceptions within the VltSerializationManager to include
the filename in the exception as well.
was:
I get the following exception during opening a JSP file
{code}
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
at java.lang.String.charAt(String.java:658)
at
org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler$TypeHint.parsePossiblyTypedValue(ContentXmlHandler.java:210)
at
org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler.startElement(ContentXmlHandler.java:67)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:506)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:376)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:602)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3065)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDoc
[jira] [Updated] (SLING-3095) StringIndexOutOfBoundsException within ContentXmlHandler.java:210
[
https://issues.apache.org/jira/browse/SLING-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-3095:
---
Attachment: SLING-3095-v1.patch
I have attached a simple patch, which is fixing that and is also extending the
test method to cover the case with an empty attribute value.
> StringIndexOutOfBoundsException within ContentXmlHandler.java:210
> -
>
> Key: SLING-3095
> URL: https://issues.apache.org/jira/browse/SLING-3095
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Konrad Windszus
> Attachments: SLING-3095-v1.patch
>
>
> I get the following exception during the publication of a
> sling-content-module:
> {code}
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:658)
> at
> org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler$TypeHint.parsePossiblyTypedValue(ContentXmlHandler.java:210)
> at
> org.apache.sling.ide.impl.vlt.serialization.ContentXmlHandler.startElement(ContentXmlHandler.java:67)
> at
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:506)
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:376)
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:602)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3065)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:881)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:607)
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:116)
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:489)
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:835)
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
> at
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:123)
> at
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1210)
> at
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:568)
> at
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:302)
> at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
> at
> org.apache.sling.ide.impl.vlt.serialization.VltSerializationManager.readSerializationData(VltSerializationManager.java:212)
> at
> org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.addFileCommand(SlingLaunchpadBehaviour.java:509)
> at
> org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishContentModule(SlingLaunchpadBehaviour.java:331)
> at
> org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishModule(SlingLaunchpadBehaviour.java:196)
> at
> org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModule(ServerBehaviourDelegate.java:1091)
> at
> org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModules(ServerBehaviourDelegate.java:1183)
> at
> org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:987)
> at
> org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774)
> at
> org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3153)
> at
> org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:345)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
> {code}
> To me it seems that the ContentXmlHandler does not deal with attributes
> having an empty string as a value. Also for the future it would be great to
> encapsulate all those exceptions within the VltSerializationManager to
> include the filename in the exception as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
[ https://issues.apache.org/jira/browse/SLING-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774604#comment-13774604 ] Konrad Windszus commented on SLING-3093: I am on Mac OS X 10.8.5 with Eclipse Kepler (4.3.0) running on Java 1.7.0_25 (still). > All input fields within the server overview for "External Sling Launchpad" > within the "Connection" section have right-to-left typing logic > -- > > Key: SLING-3093 > URL: https://issues.apache.org/jira/browse/SLING-3093 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.0 > > Attachments: SlingIDEConnectionFieldsBug.png > > > It is currently hard to modify any parameters within the Connection area of > the "External Sling Launchpad" server overview, because the text cursor is > set to the beginning of the field after adding a new character to it. > E.g. if you try to enter the port "4502" you actually have to type "2054". > For password "admin" you have to type "nimda". I don't know whether this is a > property on the the input fields themselves or the cursor gets automatically > reset to position 0 after each character (due to some validation). It works > fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
[ https://issues.apache.org/jira/browse/SLING-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774613#comment-13774613 ] Konrad Windszus edited comment on SLING-3093 at 9/23/13 3:13 PM: - I think the problem is a loop with the modification listeners. You actually try to store the values whenever they are changed. This itself triggers the PropertyChangeListener, which sets the control value. This resets the cursor position. The key issue is that you try to persist the properties before a "Save" is issued on the ServerEditorSection. was (Author: kwin): I think the problem is a loop with the modification listeners. You actually try to set the values whenever they are changed. This itself triggers the PropertyChangeListener, which sets the control value. This resets the cursor position. The key issue is that you try to persist the properties before a "Save" is issued on the ServerEditorSection. > All input fields within the server overview for "External Sling Launchpad" > within the "Connection" section have right-to-left typing logic > -- > > Key: SLING-3093 > URL: https://issues.apache.org/jira/browse/SLING-3093 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.0 > > Attachments: SlingIDEConnectionFieldsBug.png > > > It is currently hard to modify any parameters within the Connection area of > the "External Sling Launchpad" server overview, because the text cursor is > set to the beginning of the field after adding a new character to it. > E.g. if you try to enter the port "4502" you actually have to type "2054". > For password "admin" you have to type "nimda". I don't know whether this is a > property on the the input fields themselves or the cursor gets automatically > reset to position 0 after each character (due to some validation). It works > fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
[ https://issues.apache.org/jira/browse/SLING-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774613#comment-13774613 ] Konrad Windszus commented on SLING-3093: I think the problem is a loop with the modification listeners. You actually try to set the values whenever they are changed. This itself triggers the PropertyChangeListener, which sets the control value. This resets the cursor position. The key issue is that you try to persist the properties before a "Save" is issued on the ServerEditorSection. > All input fields within the server overview for "External Sling Launchpad" > within the "Connection" section have right-to-left typing logic > -- > > Key: SLING-3093 > URL: https://issues.apache.org/jira/browse/SLING-3093 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.0 > > Attachments: SlingIDEConnectionFieldsBug.png > > > It is currently hard to modify any parameters within the Connection area of > the "External Sling Launchpad" server overview, because the text cursor is > set to the beginning of the field after adding a new character to it. > E.g. if you try to enter the port "4502" you actually have to type "2054". > For password "admin" you have to type "nimda". I don't know whether this is a > property on the the input fields themselves or the cursor gets automatically > reset to position 0 after each character (due to some validation). It works > fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
[ https://issues.apache.org/jira/browse/SLING-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774640#comment-13774640 ] Konrad Windszus commented on SLING-3093: Compare with this code: https://anonsvn.springsource.org/svn/dm-server-tools/main-branches/jersey/com.springsource.server.ide.runtime.ui/src/com/springsource/server/ide/runtime/internal/ui/editor/StartupEditorSection.java. The field "updating" is used as a guard, so that the PropertyChangeListener is not doing anything, if the update was triggered from the GUI itself (in that case updating is true). > All input fields within the server overview for "External Sling Launchpad" > within the "Connection" section have right-to-left typing logic > -- > > Key: SLING-3093 > URL: https://issues.apache.org/jira/browse/SLING-3093 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.0 > > Attachments: SlingIDEConnectionFieldsBug.png > > > It is currently hard to modify any parameters within the Connection area of > the "External Sling Launchpad" server overview, because the text cursor is > set to the beginning of the field after adding a new character to it. > E.g. if you try to enter the port "4502" you actually have to type "2054". > For password "admin" you have to type "nimda". I don't know whether this is a > property on the the input fields themselves or the cursor gets automatically > reset to position 0 after each character (due to some validation). It works > fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3100) Provide a m2e project configurator for packaging "content-type"
Konrad Windszus created SLING-3100: -- Summary: Provide a m2e project configurator for packaging "content-type" Key: SLING-3100 URL: https://issues.apache.org/jira/browse/SLING-3100 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus To set up the appropriate project configuration just from the POM an according m2e project configurator is needed (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) The m2e-war-plugin comes with a project configurator which works also for content-packages pretty well but it is currently hard to reuse for any other packaging than "war" (due to the delegate pattern being used internally, compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if the project is having the dynamic web project facet the following features in Eclipse are supported: - JSP include directives (considered for validation and supports ctrl+click to open linked file) - Tag Library Support (http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F) - probably other features as well. Apart from that a feature like overlays should be supported (https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154), as often content-package projects are referencing JSPs from other projects, and the IDE needs to know those, to complete the validation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3100) Provide a m2e project configurator for packaging "content-type"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3100: --- Description: To set up the appropriate project configuration just from the POM an according m2e project configurator is needed (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) The m2e-war-plugin comes with a project configurator which works also for content-packages pretty well but it is currently hard to reuse for any other packaging than "war" (due to the delegate pattern being used internally, compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if the project is having the dynamic web project facet the following features in Eclipse are supported: - JSP include directives (considered for validation and supports ctrl+click to open linked file) - Tag Library Support ( http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F ) - probably other features as well. Apart from that a feature like overlays should be supported (https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154), as often content-package projects are referencing JSPs from other projects, and the IDE needs to know those, to complete the validation. was: To set up the appropriate project configuration just from the POM an according m2e project configurator is needed (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) The m2e-war-plugin comes with a project configurator which works also for content-packages pretty well but it is currently hard to reuse for any other packaging than "war" (due to the delegate pattern being used internally, compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if the project is having the dynamic web project facet the following features in Eclipse are supported: - JSP include directives (considered for validation and supports ctrl+click to open linked file) - Tag Library Support (http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F) - probably other features as well. Apart from that a feature like overlays should be supported (https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154), as often content-package projects are referencing JSPs from other projects, and the IDE needs to know those, to complete the validation. > Provide a m2e project configurator for packaging "content-type" > --- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported > (https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3100) Provide a m2e project configurator for packaging "content-type"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3100: --- Description: To set up the appropriate project configuration just from the POM an according m2e project configurator is needed (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) The m2e-war-plugin comes with a project configurator which works also for content-packages pretty well but it is currently hard to reuse for any other packaging than "war" (due to the delegate pattern being used internally, compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if the project is having the dynamic web project facet the following features in Eclipse are supported: - JSP include directives (considered for validation and supports ctrl+click to open linked file) - Tag Library Support ( http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F ) - probably other features as well. Apart from that a feature like overlays should be supported ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often content-package projects are referencing JSPs from other projects, and the IDE needs to know those, to complete the validation. was: To set up the appropriate project configuration just from the POM an according m2e project configurator is needed (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) The m2e-war-plugin comes with a project configurator which works also for content-packages pretty well but it is currently hard to reuse for any other packaging than "war" (due to the delegate pattern being used internally, compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if the project is having the dynamic web project facet the following features in Eclipse are supported: - JSP include directives (considered for validation and supports ctrl+click to open linked file) - Tag Library Support ( http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F ) - probably other features as well. Apart from that a feature like overlays should be supported (https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154), as often content-package projects are referencing JSPs from other projects, and the IDE needs to know those, to complete the validation. > Provide a m2e project configurator for packaging "content-type" > --- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported ( > https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3093) All input fields within the server overview for "External Sling Launchpad" within the "Connection" section have right-to-left typing logic
[ https://issues.apache.org/jira/browse/SLING-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776144#comment-13776144 ] Konrad Windszus commented on SLING-3093: Thanks a lot. Just tried it out and now it works. > All input fields within the server overview for "External Sling Launchpad" > within the "Connection" section have right-to-left typing logic > -- > > Key: SLING-3093 > URL: https://issues.apache.org/jira/browse/SLING-3093 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus >Assignee: Stefan Egli > Fix For: Sling Eclipse IDE 1.0.0 > > Attachments: SlingIDEConnectionFieldsBug.png > > > It is currently hard to modify any parameters within the Connection area of > the "External Sling Launchpad" server overview, because the text cursor is > set to the beginning of the field after adding a new character to it. > E.g. if you try to enter the port "4502" you actually have to type "2054". > For password "admin" you have to type "nimda". I don't know whether this is a > property on the the input fields themselves or the cursor gets automatically > reset to position 0 after each character (due to some validation). It works > fine within the "Timeouts" section. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3100) Provide a m2e project configurator for packaging "content-package"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3100: --- Summary: Provide a m2e project configurator for packaging "content-package" (was: Provide a m2e project configurator for packaging "content-type") > Provide a m2e project configurator for packaging "content-package" > -- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported ( > https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3100) Provide a m2e project configurator for packaging "content-package"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776154#comment-13776154 ] Konrad Windszus commented on SLING-3100: Yes, sorry, I just fixed it. > Provide a m2e project configurator for packaging "content-package" > -- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported ( > https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3100) Provide a m2e project configurator for packaging "content-package"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776273#comment-13776273 ] Konrad Windszus commented on SLING-3100: Some thoughts and questions about that: The project configurator should be bound to the content-package-maven-plugin. Currently this plugin is still closed source, but is probably about to be donated to Jackrabbit as well (there are some hints about that in JCR-3612) The configurator should - Create a Dynamic Web Project - Add the facet "sling-content-package" For the Dynamic Web Project part a lot of code could be reused from m2e-wtp (http://www.eclipse.org/m2e-wtp/). Would it be acceptable if the eclipse-m2e-ui plugin would also depend on m2e-wtp for this purpose? > Provide a m2e project configurator for packaging "content-package" > -- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: Bug > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported ( > https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-3118) NPE during invocation of the SlingBundleWizard
[ https://issues.apache.org/jira/browse/SLING-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3118: --- Description: I get a NPE during calling File->New->New Sling Bundle Project. That stacktrace is as following ... Root exception: java.lang.NullPointerException at org.apache.sling.ide.eclipse.m2e.EmbeddedArchetypeInstaller.addResource(EmbeddedArchetypeInstaller.java:81) at org.apache.sling.ide.eclipse.ui.wizards.np.NewSlingBundleWizard.installArchetypes(NewSlingBundleWizard.java:48) at org.apache.sling.ide.eclipse.ui.wizards.np.ChooseArchetypeWizardPage$6.run(ChooseArchetypeWizardPage.java:192) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) This is caused by referring to the archetype artifact with the filename "target/archetypes/sling-bundle-archetype-1.0.1-SNAPSHOT.jar" where in fact the filename (at least in my build) is "/target/archetypes/sling-bundle-archetype-1.0.1-20121112.102907-462.jar" A solution would be to strip the version from the filename after it has been downloaded by the maven-dependency-plugin (http://maven.apache.org/plugins/maven-dependency-plugin/copy-mojo.html) by leveraging the "stripVersion" flag and referring only to the artifactId as filename. was: I get a NPE during calling File->New->New Sling Bundle Project. That stacktrace is as following ... Caused by: java.lang.NullPointerException at org.apache.sling.ide.eclipse.m2e.EmbeddedArchetypeInstaller.addResource(EmbeddedArchetypeInstaller.java:81) at org.apache.sling.ide.eclipse.ui.wizards.np.NewSlingBundleWizard.installArchetypes(NewSlingBundleWizard.java:48) at org.apache.sling.ide.eclipse.ui.wizards.np.ChooseArchetypeWizardPage$6.run(ChooseArchetypeWizardPage.java:192) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) Root exception: java.lang.NullPointerException at org.apache.sling.ide.eclipse.m2e.EmbeddedArchetypeInstaller.addResource(EmbeddedArchetypeInstaller.java:81) at org.apache.sling.ide.eclipse.ui.wizards.np.NewSlingBundleWizard.installArchetypes(NewSlingBundleWizard.java:48) at org.apache.sling.ide.eclipse.ui.wizards.np.ChooseArchetypeWizardPage$6.run(ChooseArchetypeWizardPage.java:192) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) This is caused by referring to the archetype artifact with the filename "target/archetypes/sling-bundle-archetype-1.0.1-SNAPSHOT.jar" where in fact the filename (at least in my build) is "/target/archetypes/sling-bundle-archetype-1.0.1-20121112.102907-462.jar" A solution would be to strip the version from the filename after it has been downloaded by the maven-dependency-plugin (http://maven.apache.org/plugins/maven-dependency-plugin/copy-mojo.html) by leveraging the "stripVersion" flag and referring only to the artifactId as filename. > NPE during invocation of the SlingBundleWizard > -- > > Key: SLING-3118 > URL: https://issues.apache.org/jira/browse/SLING-3118 > Project: Sling > Issue Type: Bug > Components: IDE >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.0 > > > I get a NPE during calling File->New->New Sling Bundle Project. That > stacktrace is as following > ... > Root exception: > java.lang.NullPointerException > at > org.apache.sling.ide.eclipse.m2e.EmbeddedArchetypeInstaller.addResource(EmbeddedArchetypeInstaller.java:81) > at > org.apache.sling.ide.eclipse.ui.wizards.np.NewSlingBundleWizard.installArchetypes(NewSlingBundleWizard.java:48) > at > org.apache.sling.ide.eclipse.ui.wizards.np.ChooseArchetypeWizardPage$6.run(ChooseArchetypeWizardPage.java:192) > at > org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) > This is caused by referring to the archetype artifact with the filename > "target/archetypes/sling-bundle-archetype-1.0.1-SNAPSHOT.jar" where in fact > the filename (at least in my build) is > "/target/archetypes/sling-bundle-archetype-1.0.1-20121112.102907-462.jar" > A solution would be to strip the version from the filename after it has been > downloaded by the maven-dependency-plugin > (http://maven.apache.org/plugins/maven-dependency-plugin/copy-mojo.html) by > leveraging the "stripVersion" flag and referring only to the artifactId as > filename. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3118) NPE during invocation of the SlingBundleWizard
Konrad Windszus created SLING-3118: -- Summary: NPE during invocation of the SlingBundleWizard Key: SLING-3118 URL: https://issues.apache.org/jira/browse/SLING-3118 Project: Sling Issue Type: Bug Components: IDE Reporter: Konrad Windszus Fix For: Sling Eclipse IDE 1.0.0 I get a NPE during calling File->New->New Sling Bundle Project. That stacktrace is as following ... Caused by: java.lang.NullPointerException at org.apache.sling.ide.eclipse.m2e.EmbeddedArchetypeInstaller.addResource(EmbeddedArchetypeInstaller.java:81) at org.apache.sling.ide.eclipse.ui.wizards.np.NewSlingBundleWizard.installArchetypes(NewSlingBundleWizard.java:48) at org.apache.sling.ide.eclipse.ui.wizards.np.ChooseArchetypeWizardPage$6.run(ChooseArchetypeWizardPage.java:192) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) Root exception: java.lang.NullPointerException at org.apache.sling.ide.eclipse.m2e.EmbeddedArchetypeInstaller.addResource(EmbeddedArchetypeInstaller.java:81) at org.apache.sling.ide.eclipse.ui.wizards.np.NewSlingBundleWizard.installArchetypes(NewSlingBundleWizard.java:48) at org.apache.sling.ide.eclipse.ui.wizards.np.ChooseArchetypeWizardPage$6.run(ChooseArchetypeWizardPage.java:192) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) This is caused by referring to the archetype artifact with the filename "target/archetypes/sling-bundle-archetype-1.0.1-SNAPSHOT.jar" where in fact the filename (at least in my build) is "/target/archetypes/sling-bundle-archetype-1.0.1-20121112.102907-462.jar" A solution would be to strip the version from the filename after it has been downloaded by the maven-dependency-plugin (http://maven.apache.org/plugins/maven-dependency-plugin/copy-mojo.html) by leveraging the "stripVersion" flag and referring only to the artifactId as filename. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-3100) Provide a m2e project configurator for packaging "content-package"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798968#comment-13798968 ] Konrad Windszus commented on SLING-3100: @Georg: Are you re-using the code from m2e-wtp or do you have your own configurator? It is a littlebit complicated to set up the appropriate facets and validation settings for a dynamic web project. > Provide a m2e project configurator for packaging "content-package" > -- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: New Feature > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.2 > > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported ( > https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SLING-3100) Provide a m2e project configurator for packaging "content-package"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807848#comment-13807848 ] Konrad Windszus commented on SLING-3100: [~rombert] - do you have any information when the content-package plugin will be Open Source as well? Otherwise we would need to come up with our own custom plugin to configure content-packages correctly. Right now there is already a dependency on "content-package" within the source code (org.apache.sling.ide.eclipse.core.internal.ProjectHelper) .You can only convert to a sling project in case the packaging is "content-package". Therefore I would prefer to have it right now included in the Sling IDE Tooling. As soon as the content-package is open source we could think about moving the configurator to a separate plugin (probably linking it in the m2e marketplace, http://wiki.eclipse.org/Submitting_M2E_marketplace_entries). What do you think? > Provide a m2e project configurator for packaging "content-package" > -- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: New Feature > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.2 > > Attachments: SLING-3100-m2e-integration.patch > > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported ( > https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SLING-3006) SlingServletResolver webconsole plugin uses custom URL decomposition code that can be wrong
[ https://issues.apache.org/jira/browse/SLING-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815781#comment-13815781 ] Konrad Windszus commented on SLING-3006: Another use case is the request URI /home/users/geometrixx-outdoors/emily.andr...@mailinator.com/profile.form.html/content/geometrixx-outdoors/en/user/profile which gets decomposed to Path /home/users/geometrixx-outdoors/emily Selectors [andrews@mailinator, com/profile, form] Extension html whereas it should be Path /home/users/geometrixx-outdoors/emily.andr...@mailinator.com/profile Selectors [form] Extension html Is that fixed with the updated version as well? > SlingServletResolver webconsole plugin uses custom URL decomposition code > that can be wrong > --- > > Key: SLING-3006 > URL: https://issues.apache.org/jira/browse/SLING-3006 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Resolver 2.2.4 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Resolver 2.2.6 > > > Entering > http://localhost:8080/libs/foo/content/something/formitems.json/image/vnd/xnd/knd.xml > in the /system/console/servletresolver webconsole plugin does not produce > the correct results as per the testDotsAroundSuffix() at [1] > This is due to the plugin using its own DecomposedURL class which is a > simplified version of the SlingRequestPathInfo class. > For now, I'll add a warning to the plugin. > [1] > http://svn.apache.org/repos/asf/sling/trunk/bundles/engine/src/test/java/org/apache/sling/engine/impl/request/SlingRequestPathInfoTest.java -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SLING-3006) SlingServletResolver webconsole plugin uses custom URL decomposition code that can be wrong
[ https://issues.apache.org/jira/browse/SLING-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815829#comment-13815829 ] Konrad Windszus commented on SLING-3006: Hi Bertrand, I think the warning should be enough. Maybe you can also mention the workaround in the warning that replacing dots with "_" should work, if the dots should not be considered as separator between path and selectors. Thanks. > SlingServletResolver webconsole plugin uses custom URL decomposition code > that can be wrong > --- > > Key: SLING-3006 > URL: https://issues.apache.org/jira/browse/SLING-3006 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Resolver 2.2.4 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlets Resolver 2.2.6 > > > Entering > http://localhost:8080/libs/foo/content/something/formitems.json/image/vnd/xnd/knd.xml > in the /system/console/servletresolver webconsole plugin does not produce > the correct results as per the testDotsAroundSuffix() at [1] > This is due to the plugin using its own DecomposedURL class which is a > simplified version of the SlingRequestPathInfo class. > For now, I'll add a warning to the plugin. > [1] > http://svn.apache.org/repos/asf/sling/trunk/bundles/engine/src/test/java/org/apache/sling/engine/impl/request/SlingRequestPathInfoTest.java -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SLING-2897) [LOG] Enhance web console plugin with edit feature
[ https://issues.apache.org/jira/browse/SLING-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835427#comment-13835427 ] Konrad Windszus commented on SLING-2897: [~chetanm] Would it be possible to consider that patch for Commons Log 4.0? I think it greatly enhances the configuration capabilities within the OSGi web console without too many code changes. > [LOG] Enhance web console plugin with edit feature > -- > > Key: SLING-2897 > URL: https://issues.apache.org/jira/browse/SLING-2897 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 3.0.0 >Reporter: Bjoern Weide >Priority: Minor > Attachments: org.apache.sling.commons.log.patch, > org.apache.sling.commons.log.patch > > > The current web console plugin only lists the configured loggers but links > for the actual configuration to the OSGi Configuration Manager. > It should be improved so the logging configuration can be edited in the web > console plugin directly. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties
Konrad Windszus created SLING-3282: -- Summary: JobManagerConfiguration refers to undefined OSGi properties Key: SLING-3282 URL: https://issues.apache.org/jira/browse/SLING-3282 Project: Sling Issue Type: Bug Reporter: Konrad Windszus Currently the JobManagerImpl does not expose the properties in the web console. Also the properties being used by JobManagerConfiguration like job.consumermanager.disableDistribution are not even defined. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (SLING-3283) Table on http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html broken
Konrad Windszus created SLING-3283: -- Summary: Table on http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html broken Key: SLING-3283 URL: https://issues.apache.org/jira/browse/SLING-3283 Project: Sling Issue Type: Bug Reporter: Konrad Windszus Priority: Minor The table for Queue Configurations seems to be broken at http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html. Probably related to the wiki migration. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (SLING-3284) Remove deprecated documentation of Sling Jobs
Konrad Windszus created SLING-3284: -- Summary: Remove deprecated documentation of Sling Jobs Key: SLING-3284 URL: https://issues.apache.org/jira/browse/SLING-3284 Project: Sling Issue Type: Bug Reporter: Konrad Windszus Currently there is documentation about Sling Jobs available at 1) http://sling.apache.org/documentation/the-sling-engine/eventing-and-jobs.html and 2) http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html They do overlap but 2) seems to be the more recent documentation. Can you either crosslink between those 2 or just remove 1)? -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing
[ https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865235#comment-13865235 ] Konrad Windszus commented on SLING-3285: Why is creating a very short-living session so expensive? Within the ResourceResolver.getParentResourceType() the session is almost immediately closed within the finally. Probably it is related to the session having a finalize method (JCR-2768). Since one request is dealt within a single thread there should never be multiple sessions active at the same time for that specific method. I think by just getting rid of the finalize method within the JCR session one would achieve a much better performance (very similar to using a resource resolver cache). > ResourceResolver.isResourceType() creates admin session for every call with > super type, slowing down processing > --- > > Key: SLING-3285 > URL: https://issues.apache.org/jira/browse/SLING-3285 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.0.6 >Reporter: Alexander Klimetschek >Assignee: Carsten Ziegeler >Priority: Critical > Labels: Performance > Fix For: Resource Resolver 1.1.0 > > > SLING-2457 fixed the ACL issue with super type lookups, but at the cost of > creating a new admin resource resolver for every super type lookup. If an > inheritance chain contains multiple super types (N), a single call can > trigger the creation of N admin sessions. Often this also happens for a > number of resources per request, depending on the application, so you might > end up creating many Jackrabbit JCR sessions per request. While creating a > resource resolver / session is cheap, having too many at the same time has a > big performance impact on the read performance due to increased concurrency > in the JCR repository layer. > This affects: > * ResourceUtil.isA() > * Resource.isResourceType() > * ResourceResolver.isResourceType() > * implementation in ResourceResolverImpl.isResourceType() and > getParentResourceType() [1] > A simple fix could be to cache a single admin resolver for the duration of > the resource resolver containing it and reusing it for subsequent > isResourceType() calls. > Another improvement could also be to cache the isResourceType() lookups - if > this is a typical short-lived request resource resolver. Within a request > resource type hierarchies are unlikely to change and should probably be > stable (and with Jackrabbit Oak the session won't refresh anyway). The cache > would simply be a map of "resource type" => "is also this resource type", so > that the super lookups don't have to be done again and again. Often an > application might iterate over a tree of data and looking for the same > resource type again and again, so the hit rate for the cache will be high. > [1] > https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing
[ https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866419#comment-13866419 ] Konrad Windszus commented on SLING-3285: Hi Alex, thanks for your answer but how does the cache help then? If we only talk about one request, there should never be parallel access in any case, since the session was closed immediately afterwards (before the cache was implemented). If we talk about multiple requests the cache will not help, because the cache is per request (it means for n requests there might be n parallel sessions, which is the same behaviour as before!). Even without the cache we would have no more than n parallel sessions for n requests. Am I wrong here? > ResourceResolver.isResourceType() creates admin session for every call with > super type, slowing down processing > --- > > Key: SLING-3285 > URL: https://issues.apache.org/jira/browse/SLING-3285 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.0.6 >Reporter: Alexander Klimetschek >Assignee: Carsten Ziegeler >Priority: Critical > Labels: Performance > Fix For: Resource Resolver 1.1.0 > > > SLING-2457 fixed the ACL issue with super type lookups, but at the cost of > creating a new admin resource resolver for every super type lookup. If an > inheritance chain contains multiple super types (N), a single call can > trigger the creation of N admin sessions. Often this also happens for a > number of resources per request, depending on the application, so you might > end up creating many Jackrabbit JCR sessions per request. While creating a > resource resolver / session is cheap, having too many at the same time has a > big performance impact on the read performance due to increased concurrency > in the JCR repository layer. > This affects: > * ResourceUtil.isA() > * Resource.isResourceType() > * ResourceResolver.isResourceType() > * implementation in ResourceResolverImpl.isResourceType() and > getParentResourceType() [1] > A simple fix could be to cache a single admin resolver for the duration of > the resource resolver containing it and reusing it for subsequent > isResourceType() calls. > Another improvement could also be to cache the isResourceType() lookups - if > this is a typical short-lived request resource resolver. Within a request > resource type hierarchies are unlikely to change and should probably be > stable (and with Jackrabbit Oak the session won't refresh anyway). The cache > would simply be a map of "resource type" => "is also this resource type", so > that the super lookups don't have to be done again and again. Often an > application might iterate over a tree of data and looking for the same > resource type again and again, so the hit rate for the cache will be high. > [1] > https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing
[ https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866419#comment-13866419 ] Konrad Windszus edited comment on SLING-3285 at 1/9/14 7:48 AM: Hi Alex, thanks for your answer but how does the cache help then? If we only talk about one request, there should never be parallel access in any case, since the session was closed immediately afterwards (before the cache was implemented), so there should be no overlap of open sessions (at least for the case of isResourceType()) If we talk about multiple requests the cache will not help, because the cache is per request (it means for n requests there might be n parallel sessions, which is the same behaviour as before!). Even without the cache we would have no more than n parallel sessions for n requests. Am I wrong here? was (Author: kwin): Hi Alex, thanks for your answer but how does the cache help then? If we only talk about one request, there should never be parallel access in any case, since the session was closed immediately afterwards (before the cache was implemented). If we talk about multiple requests the cache will not help, because the cache is per request (it means for n requests there might be n parallel sessions, which is the same behaviour as before!). Even without the cache we would have no more than n parallel sessions for n requests. Am I wrong here? > ResourceResolver.isResourceType() creates admin session for every call with > super type, slowing down processing > --- > > Key: SLING-3285 > URL: https://issues.apache.org/jira/browse/SLING-3285 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.0.6 >Reporter: Alexander Klimetschek >Assignee: Carsten Ziegeler >Priority: Critical > Labels: Performance > Fix For: Resource Resolver 1.1.0 > > > SLING-2457 fixed the ACL issue with super type lookups, but at the cost of > creating a new admin resource resolver for every super type lookup. If an > inheritance chain contains multiple super types (N), a single call can > trigger the creation of N admin sessions. Often this also happens for a > number of resources per request, depending on the application, so you might > end up creating many Jackrabbit JCR sessions per request. While creating a > resource resolver / session is cheap, having too many at the same time has a > big performance impact on the read performance due to increased concurrency > in the JCR repository layer. > This affects: > * ResourceUtil.isA() > * Resource.isResourceType() > * ResourceResolver.isResourceType() > * implementation in ResourceResolverImpl.isResourceType() and > getParentResourceType() [1] > A simple fix could be to cache a single admin resolver for the duration of > the resource resolver containing it and reusing it for subsequent > isResourceType() calls. > Another improvement could also be to cache the isResourceType() lookups - if > this is a typical short-lived request resource resolver. Within a request > resource type hierarchies are unlikely to change and should probably be > stable (and with Jackrabbit Oak the session won't refresh anyway). The cache > would simply be a map of "resource type" => "is also this resource type", so > that the super lookups don't have to be done again and again. Often an > application might iterate over a tree of data and looking for the same > resource type again and again, so the hit rate for the cache will be high. > [1] > https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing
[ https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867583#comment-13867583 ] Konrad Windszus commented on SLING-3285: If we assume that the sessions which are closed but not yet finalized have an effect on synchronisation that should clearly be fixed in the code. But I am rather assuming that the GC is the culprit there (see http://www.fasterj.com/articles/finalizer1.shtml), meaning the closed sessions survive too long in the heap, due to the finalizer. Don't you think that getting rid of the finalize (JCR-2768) would have a bigger impact than the implemented cache? Another question is, why does Oak behave even worse than Jackrabbit here? > ResourceResolver.isResourceType() creates admin session for every call with > super type, slowing down processing > --- > > Key: SLING-3285 > URL: https://issues.apache.org/jira/browse/SLING-3285 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.0.6 >Reporter: Alexander Klimetschek >Assignee: Carsten Ziegeler >Priority: Critical > Labels: Performance > Fix For: Resource Resolver 1.1.0 > > > SLING-2457 fixed the ACL issue with super type lookups, but at the cost of > creating a new admin resource resolver for every super type lookup. If an > inheritance chain contains multiple super types (N), a single call can > trigger the creation of N admin sessions. Often this also happens for a > number of resources per request, depending on the application, so you might > end up creating many Jackrabbit JCR sessions per request. While creating a > resource resolver / session is cheap, having too many at the same time has a > big performance impact on the read performance due to increased concurrency > in the JCR repository layer. > This affects: > * ResourceUtil.isA() > * Resource.isResourceType() > * ResourceResolver.isResourceType() > * implementation in ResourceResolverImpl.isResourceType() and > getParentResourceType() [1] > A simple fix could be to cache a single admin resolver for the duration of > the resource resolver containing it and reusing it for subsequent > isResourceType() calls. > Another improvement could also be to cache the isResourceType() lookups - if > this is a typical short-lived request resource resolver. Within a request > resource type hierarchies are unlikely to change and should probably be > stable (and with Jackrabbit Oak the session won't refresh anyway). The cache > would simply be a map of "resource type" => "is also this resource type", so > that the super lookups don't have to be done again and again. Often an > application might iterate over a tree of data and looking for the same > resource type again and again, so the hit rate for the cache will be high. > [1] > https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3320) Execution order of BindingsValuesProvider
[
https://issues.apache.org/jira/browse/SLING-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873298#comment-13873298
]
Konrad Windszus commented on SLING-3320:
Probably one has to leverage the PolicyOption greedy (OSGi Compendium 4.3,
$112.3.5), otherwise it depends on the when a specific ValuesProvider becomes
available.
> Execution order of BindingsValuesProvider
> --
>
> Key: SLING-3320
> URL: https://issues.apache.org/jira/browse/SLING-3320
> Project: Sling
> Issue Type: Bug
>Reporter: Feike Visser
>
> I have implemented two basic BindingsValuesProviders like this.
> {code}
> @Service
> @Component(immediate=true)
> public class MyBindings implements BindingsValuesProvider {
> }
> {code}
> What I want to make sure is that they are *always* executed in the same
> order, first A, then B.
> Because I want to re-use objects that were set in the first
> BindingsValuesProvider.
> Currently I don't have a way to do this.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878657#comment-13878657
]
Konrad Windszus commented on SLING-2938:
Why isn't this a pure build time annotation (similar to @SlingServlet)?
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878882#comment-13878882
]
Konrad Windszus commented on SLING-2938:
I see, thanks for the explanation. When is that gonna be integrated?
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (SLING-3293) Make HC compatible to CQ 5.5/5.6/5.6.1
[ https://issues.apache.org/jira/browse/SLING-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882868#comment-13882868 ] Konrad Windszus commented on SLING-3293: The problem in the referenced felix-metatype service is described in https://issues.apache.org/jira/browse/FELIX-4214 > Make HC compatible to CQ 5.5/5.6/5.6.1 > -- > > Key: SLING-3293 > URL: https://issues.apache.org/jira/browse/SLING-3293 > Project: Sling > Issue Type: Improvement > Components: Health Check >Reporter: Georg Henzler > Attachments: missing-meta-data.PNG > > > When testing the health check with CQ 5.5 and 5.6, the configuration meta > data (labels and descriptions) do not show up correctly due to the new layout > of the OSGI-INF folder (see attachment). This can easily be fixed by using an > older version of the scr plugin: > > org.apache.felix > maven-scr-plugin > 1.8.0 > > Obviously there is reasons to use the latest version, but because everthing > else works completely fine with CQ 5.5 it would be nice to stay on the old > version descriptors (serviceComponents.xml) for some releases to be able to > use the HC in CQ 5.5 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3342) Do not use SlingBindings in Java code
[ https://issues.apache.org/jira/browse/SLING-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884198#comment-13884198 ] Konrad Windszus commented on SLING-3342: In my regard using the SlingBindings is the preferred way of getting a service if a) the service should only be used during the lifetime of the request (otherwise one has to remember releasing the service correctly) and b) the java object itself is not a OSGi component > Do not use SlingBindings in Java code > - > > Key: SLING-3342 > URL: https://issues.apache.org/jira/browse/SLING-3342 > Project: Sling > Issue Type: Task > Components: Best practices >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > > **DRAFT** - to be reviewed, and we need to update the SlingBindings javadocs > as well. > SlingBindings is meant to be used in Sling scripts. > It might be available as a Request attribute in some cases, as Sling sets > that before running scripts, but one cannot rely on that in java code. > There’s usually no reason to use it in Java code anyway, all the services > that it provides are available directly, for example via an @Reference > annotation. > Here’s a typical counter-example which should use an @Reference to the FooBar > service instead: > // Do NOT do that! > SlingBindings bindings = > (SlingBindings)request.getAttribute(SlingBindings.class.getName()); > SlingScriptHelper scriptHelper = bindings.getSling(); > FooBar fb = scriptHelper.getService(FoorBar.class); -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (SLING-3100) Provide a m2e project configurator for packaging "content-package"
[ https://issues.apache.org/jira/browse/SLING-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886765#comment-13886765 ] Konrad Windszus commented on SLING-3100: The discussion in mailing list is at http://www.mail-archive.com/dev@sling.apache.org/msg24616.html. Basically the content-package-maven-plugin is about to become open-source as well. > Provide a m2e project configurator for packaging "content-package" > -- > > Key: SLING-3100 > URL: https://issues.apache.org/jira/browse/SLING-3100 > Project: Sling > Issue Type: New Feature > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.2 > > Attachments: SLING-3100-m2e-integration.patch > > > To set up the appropriate project configuration just from the POM an > according m2e project configurator is needed > (http://wiki.eclipse.org/M2E_plugin_execution_not_covered#delegate_to_a_project_configurator_.28recommended.29) > The m2e-war-plugin comes with a project configurator which works also for > content-packages pretty well but it is currently hard to reuse for any other > packaging than "war" (due to the delegate pattern being used internally, > compare with https://bugs.eclipse.org/bugs/show_bug.cgi?id=412213). Only if > the project is having the dynamic web project facet the following features in > Eclipse are supported: > - JSP include directives (considered for validation and supports ctrl+click > to open linked file) > - Tag Library Support ( > http://wiki.eclipse.org/WTP_FAQ#Why_isn.27t_the_JSP_editor.2Fvalidator_finding_my_custom_tag_libraries.3F > ) > - probably other features as well. > Apart from that a feature like overlays should be supported ( > https://bugs.eclipse.org/bugs/show_bug.cgi?id=384154 ), as often > content-package projects are referencing JSPs from other projects, and the > IDE needs to know those, to complete the validation. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-3358) Add support for running scheduled tasks only on instances with a specific runmode set
Konrad Windszus created SLING-3358: -- Summary: Add support for running scheduled tasks only on instances with a specific runmode set Key: SLING-3358 URL: https://issues.apache.org/jira/browse/SLING-3358 Project: Sling Issue Type: New Feature Components: Commons Affects Versions: Commons Scheduler 2.4.0 Reporter: Konrad Windszus Sometimes scheduled tasks should only be executed on instances having a dedicated run mode set. Similar to the scheduler.runOn (SLING-2979), there should be an additional property to restrict execution only to the given run mode (e.g. scheduler.runOnRunMode). -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (SLING-2562) Add a test for servlet resolver as Web Console Tab
Konrad Windszus created SLING-2562: -- Summary: Add a test for servlet resolver as Web Console Tab Key: SLING-2562 URL: https://issues.apache.org/jira/browse/SLING-2562 Project: Sling Issue Type: Improvement Components: JCR Reporter: Konrad Windszus Sometimes it is hard to tell which script/servlet answered a specific request. Therefore a tab which provides a test similar to "Configuration Test" in the "Sling Resource Resolver" Tab of the Felix Web Console would be very useful, which would provide the information which script/servlet was used for rendering a response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2562) Add a test for servlet resolver as Web Console Tab
[ https://issues.apache.org/jira/browse/SLING-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-2562: --- Attachment: servletresolverplugin.png This screenshot shows an implementation of this feature. I can provide a patch, but since the Servlet Resolver Interface doesn't provide a good API method for that, I had to rely on the two internal implementations org.apache.sling.engine.impl.request.SlingRequestPathInfo and SlingRequestProgressTracker. If that's acceptable tell me, and I will try to attach a patch. Even better would be an additional method in the Sling Servlet Resolver interface like Servlet SlingServletResolver.resolveServlet(String url, String method /*POST or GET*/) > Add a test for servlet resolver as Web Console Tab > -- > > Key: SLING-2562 > URL: https://issues.apache.org/jira/browse/SLING-2562 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus > Attachments: servletresolverplugin.png > > > Sometimes it is hard to tell which script/servlet answered a specific > request. Therefore a tab which provides a test similar to "Configuration > Test" in the "Sling Resource Resolver" Tab of the Felix Web Console would be > very useful, which would provide the information which script/servlet was > used for rendering a response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2562) Add a test for servlet resolver as Web Console Tab
[ https://issues.apache.org/jira/browse/SLING-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-2562: --- Attachment: SLING-2562-v1.patch I attached a patch for the Sling Servlet Resolver bundle, but this will not work out of the box, since it would still require access to impl packages in org.apache.sling.engine which are not exposed through OSGi. I could also attach a bundle fragment, which would make the engine bundle export those impl packages as well, but I don"t think you would like that solution. But maybe someone has a better idea on how to do that based on this code. > Add a test for servlet resolver as Web Console Tab > -- > > Key: SLING-2562 > URL: https://issues.apache.org/jira/browse/SLING-2562 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus > Attachments: servletresolverplugin.png, SLING-2562-v1.patch > > > Sometimes it is hard to tell which script/servlet answered a specific > request. Therefore a tab which provides a test similar to "Configuration > Test" in the "Sling Resource Resolver" Tab of the Felix Web Console would be > very useful, which would provide the information which script/servlet was > used for rendering a response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2579) ResourceResolverFactory should only be available if specific ResourceProvider/Factories are registered
[
https://issues.apache.org/jira/browse/SLING-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442385#comment-13442385
]
Konrad Windszus commented on SLING-2579:
Isn't it easier to leverage the target attribute for that (OSGi Compendium
112.3.4)? That way you could annotate one ResourceResolverFactory field with
the reference annotation carrying a target attribute and dedicate that field a
special bind method. If you make that reference use the static reference
policy, that component will not be activated, until this factory is available.
To me that looks much simpler, than to extract everything into a separate
Activator component.
> ResourceResolverFactory should only be available if specific
> ResourceProvider/Factories are registered
> --
>
> Key: SLING-2579
> URL: https://issues.apache.org/jira/browse/SLING-2579
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Resource Resolver 1.0.0
>
>
> The ResourceResolverFactory should only be available if a configurable set of
> providers is available-
> We should add a string array property whose value can either be a pid or a
> filter expression (starting with a '(')
> Only if for all configured values a matching provder/factory is available a
> RRFactory will be registered
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2562) Add a test for servlet resolver as Web Console Tab
[ https://issues.apache.org/jira/browse/SLING-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463815#comment-13463815 ] Konrad Windszus commented on SLING-2562: I like the new patch from Justin, but I clearly want to be able to resolve requests without an extension as well. So this web console plugin should also be able to resolve a URL like "/cf", which does not have an extension. > Add a test for servlet resolver as Web Console Tab > -- > > Key: SLING-2562 > URL: https://issues.apache.org/jira/browse/SLING-2562 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus > Attachments: servletresolverplugin.png, SLING-2562-alt.patch, > SLING-2562-v1.patch > > > Sometimes it is hard to tell which script/servlet answered a specific > request. Therefore a tab which provides a test similar to "Configuration > Test" in the "Sling Resource Resolver" Tab of the Felix Web Console would be > very useful, which would provide the information which script/servlet was > used for rendering a response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2562) Add a test for servlet resolver as Web Console Tab
[ https://issues.apache.org/jira/browse/SLING-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463905#comment-13463905 ] Konrad Windszus commented on SLING-2562: I want to find servlets which are registered to a path with that test as well, therefore I would really like an interface, where I can just enter the URL (which may include suffix, selectors and extension) like it is displayed in the browsers address bar (or Firebug). Therefore we would need to leverage the SlingRequestPathInfo, which in my mind shouldn't be contained within an impl package. > Add a test for servlet resolver as Web Console Tab > -- > > Key: SLING-2562 > URL: https://issues.apache.org/jira/browse/SLING-2562 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus > Attachments: servletresolverplugin.png, SLING-2562-alt.patch, > SLING-2562-v1.patch > > > Sometimes it is hard to tell which script/servlet answered a specific > request. Therefore a tab which provides a test similar to "Configuration > Test" in the "Sling Resource Resolver" Tab of the Felix Web Console would be > very useful, which would provide the information which script/servlet was > used for rendering a response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2562) Add a test for servlet resolver as Web Console Tab
[ https://issues.apache.org/jira/browse/SLING-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464187#comment-13464187 ] Konrad Windszus commented on SLING-2562: Even with the second patch I have to provide an extension in the URL. Consider the case I have a servlet registered to path /bin/myservlet, then actually typing that path should be enough, i.e. all the following URLs should give out this servlet: - /bin/myservlet.selector1.html/suffix - /bin/myservlet.selector1.html - /bin/myservlet.html - /bin/myservlet > Add a test for servlet resolver as Web Console Tab > -- > > Key: SLING-2562 > URL: https://issues.apache.org/jira/browse/SLING-2562 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus > Attachments: servletresolverplugin.png, SLING-2562-alt2.patch, > SLING-2562-alt.patch, SLING-2562-v1.patch > > > Sometimes it is hard to tell which script/servlet answered a specific > request. Therefore a tab which provides a test similar to "Configuration > Test" in the "Sling Resource Resolver" Tab of the Felix Web Console would be > very useful, which would provide the information which script/servlet was > used for rendering a response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2973) [Tooling] Align Eclipse tooling to proposed structure
[ https://issues.apache.org/jira/browse/SLING-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716458#comment-13716458 ] Konrad Windszus commented on SLING-2973: Do you provide a p2 repository already containing the most recent version? I would like to try it out. > [Tooling] Align Eclipse tooling to proposed structure > - > > Key: SLING-2973 > URL: https://issues.apache.org/jira/browse/SLING-2973 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Robert Munteanu >Assignee: Robert Munteanu > > The current IDE tooling needs to be aligned to the structure defined at [1] . > We should be careful to preserve existing behaviour, but regressions in the > short run are acceptable since we will move to the WST framework, which is a > different beast altogether. > [1]: https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2973) [Tooling] Align Eclipse tooling to proposed structure
[ https://issues.apache.org/jira/browse/SLING-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720938#comment-13720938 ] Konrad Windszus commented on SLING-2973: [~rombert] Thanks a lot for the p2 site. Unfortunately I always get an error when I try to publish something. The error message is saying: FAIL Repository has returned status code 404. Maybe you can extend the error message a littlebit more (e.g. with the URL being requested there). Connecting to the CQ Server worked fine and I really like the integration in WTP. > [Tooling] Align Eclipse tooling to proposed structure > - > > Key: SLING-2973 > URL: https://issues.apache.org/jira/browse/SLING-2973 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Reporter: Robert Munteanu >Assignee: Robert Munteanu > > The current IDE tooling needs to be aligned to the structure defined at [1] . > We should be careful to preserve existing behaviour, but regressions in the > short run are acceptable since we will move to the WST framework, which is a > different beast altogether. > [1]: https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2988) Support primitive types for ValueMap.get()
Konrad Windszus created SLING-2988: -- Summary: Support primitive types for ValueMap.get() Key: SLING-2988 URL: https://issues.apache.org/jira/browse/SLING-2988 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Resource 2.1.0 Reporter: Konrad Windszus Currently the call for ValueMap.get(, boolean.class) returns false while ValueMap.get(, Boolean.class) returns true for a JCR property with type String having the value "true". Please either throw an exception if primitive classes are given as second argument or support them as well. Currently the Javadoc states that this call either returns null or the value. Assigning null to a primitive would lead to an NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2988) Support primitive types for ValueMap.get()
[ https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-2988: --- Description: Currently the call for ValueMap.get(, boolean.class) returns null while ValueMap.get(, Boolean.class) returns true for a JCR property with type String having the value "true". Please either throw an exception if primitive classes are given as second argument or support them as well. Just returning null is confusing, because it is not obvious from the Javadoc that no JCR attribute can be converted into a primitive. Currently the Javadoc states that this call either returns null or the value. Assigning null to a primitive would lead to an NPE. was: Currently the call for ValueMap.get(, boolean.class) returns false while ValueMap.get(, Boolean.class) returns true for a JCR property with type String having the value "true". Please either throw an exception if primitive classes are given as second argument or support them as well. Currently the Javadoc states that this call either returns null or the value. Assigning null to a primitive would lead to an NPE. > Support primitive types for ValueMap.get() > -- > > Key: SLING-2988 > URL: https://issues.apache.org/jira/browse/SLING-2988 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 2.1.0 >Reporter: Konrad Windszus > > Currently the call for ValueMap.get(, boolean.class) returns null while > ValueMap.get(, Boolean.class) returns true for a JCR property with type > String having the value "true". > Please either throw an exception if primitive classes are given as second > argument or support them as well. Just returning null is confusing, because > it is not obvious from the Javadoc that no JCR attribute can be converted > into a primitive. > Currently the Javadoc states that this call either returns null or the value. > Assigning null to a primitive would lead to an NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2988) Support primitive types for ValueMap.get()
[ https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725065#comment-13725065 ] Konrad Windszus commented on SLING-2988: Sorry, didn't notice that the Javadoc has been clarified. Only had a look in http://dev.day.com/docs/en/cq/current/javadoc/org/apache/sling/api/resource/ValueMap.html#get%28java.lang.String,%20java.lang.Class%29 and in http://sling.apache.org/apidocs/sling6/org/apache/sling/api/resource/ValueMap.html. But indeed you clarified the javadoc with https://fisheye6.atlassian.com/changelog/sling?cs=1438373. Although I would like it even better if in such a case you would throw an IllegalArgumentException, because not all developers are looking at the javadocs that carefully ;-) Do you think that would break too many implementations relying on ValueMap returning null if a primitive was provided as a parameter? > Support primitive types for ValueMap.get() > -- > > Key: SLING-2988 > URL: https://issues.apache.org/jira/browse/SLING-2988 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 2.1.0 >Reporter: Konrad Windszus > > Currently the call for ValueMap.get(, boolean.class) returns null while > ValueMap.get(, Boolean.class) returns true for a JCR property with type > String having the value "true". > Please either throw an exception if primitive classes are given as second > argument or support them as well. Just returning null is confusing, because > it is not obvious from the Javadoc that no JCR attribute can be converted > into a primitive. > Currently the Javadoc states that this call either returns null or the value. > Assigning null to a primitive would lead to an NPE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-3440) Clarify script resolution documentation with regard to selectors
Konrad Windszus created SLING-3440: -- Summary: Clarify script resolution documentation with regard to selectors Key: SLING-3440 URL: https://issues.apache.org/jira/browse/SLING-3440 Project: Sling Issue Type: Improvement Components: Documentation Reporter: Konrad Windszus The documentation around URL to Script Resolution [1] is very good, except for three points. a) The resourceType given in the example is confusing. Rather than sling:sample, please make that sling/sample. Maybe you could add a hint, that if no resourceType is given, the fallback is to use the primary node type. b) You should explicitly mention that the order of selectors is relevant. c) You should mention that if less selectors are given in the script name than are given in the request, the selectors given in the script name must be the first selectors from the request (to be a potential match). Maybe an example would be good i.e. script name is print/a4.esp and the request is 1) .print.a4.unspecifiedselector.html (matches) 2) .unspecifiedselector.print.a4.html (does not match) [1] - http://sling.apache.org/documentation/the-sling-engine/url-to-script-resolution.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3441) Avoid shared resource resolver usage
[ https://issues.apache.org/jira/browse/SLING-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923774#comment-13923774 ] Konrad Windszus commented on SLING-3441: Wouldn't we run into the same problems which are described in SLING-3285. Currently the old resolvers are not removed quickly enough from the heap due to JCR-2768. Therefore there is a drawback when creating a lot of resource resolvers on demand. > Avoid shared resource resolver usage > > > Key: SLING-3441 > URL: https://issues.apache.org/jira/browse/SLING-3441 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: Servlets Resolver 2.3.2 > > > The servlet resolver uses a single shared rsource resolver to resolve > scripts. Resource resolvers are not thread safe and therefore should not be > used at the same time from different threads. > Apart from that, this creates a bottleneck as the repository implementations > (Jackrabbit, Oak) synchronize all access in this case - which then ultimately > synchronises all requests. This is even more problematic as the servlet > resolver is hit alot during a single request -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3441) Avoid shared resource resolver usage
[ https://issues.apache.org/jira/browse/SLING-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923774#comment-13923774 ] Konrad Windszus edited comment on SLING-3441 at 3/7/14 10:52 AM: - Wouldn't we run into the same problems which are described in SLING-3285? Currently the old resolvers are not removed quickly enough from the heap due to JCR-2768. Therefore there is a drawback when creating a lot of resource resolvers on demand. was (Author: kwin): Wouldn't we run into the same problems which are described in SLING-3285. Currently the old resolvers are not removed quickly enough from the heap due to JCR-2768. Therefore there is a drawback when creating a lot of resource resolvers on demand. > Avoid shared resource resolver usage > > > Key: SLING-3441 > URL: https://issues.apache.org/jira/browse/SLING-3441 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Resolver 2.3.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: Servlets Resolver 2.3.2 > > > The servlet resolver uses a single shared rsource resolver to resolve > scripts. Resource resolvers are not thread safe and therefore should not be > used at the same time from different threads. > Apart from that, this creates a bottleneck as the repository implementations > (Jackrabbit, Oak) synchronize all access in this case - which then ultimately > synchronises all requests. This is even more problematic as the servlet > resolver is hit alot during a single request -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-585) New functionality to resolve scripts by name
[ https://issues.apache.org/jira/browse/SLING-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939073#comment-13939073 ] Konrad Windszus commented on SLING-585: --- The original request was about including another script from within a JSP. I see that the servlet resolver was extended, but it is still not possible to use it directly from the sling:include tag. In my regard, this issue is only partly solved. > New functionality to resolve scripts by name > > > Key: SLING-585 > URL: https://issues.apache.org/jira/browse/SLING-585 > Project: Sling > Issue Type: New Feature > Components: API, Servlets >Affects Versions: Servlets Resolver 2.0.8, API 2.0.8 >Reporter: Tobias Bocanegra >Assignee: Carsten Ziegeler > Fix For: Servlets Resolver 2.1.0, API 2.1.0 > > Attachments: SLING585.patch > > > I'm looking for a way to include a jsp script from within another but > respecting the resource type hierarchy. so for example: > + myapp > + A > + A.jsp > + content.jsp > + B > - sling:resourceSuperType = "A" > + B.jsp > and in my B.jsp i want to include the "content.jsp" but respecting the > resource type hierarchy. > suggest to add: that internally > overwrites the request selector during the script selection phase. > see http://markmail.org/message/la4rvmcdd6whpvhl -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3459) sling:call should not log exceptions with the full stacktrace
Konrad Windszus created SLING-3459: -- Summary: sling:call should not log exceptions with the full stacktrace Key: SLING-3459 URL: https://issues.apache.org/jira/browse/SLING-3459 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting JSP-Taglib 2.1.8 Reporter: Konrad Windszus Currently within the sling:call tag all exceptions are both logged on error level and rethrown (https://fisheye6.atlassian.com/browse/~br=trunk/sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/CallTag.java?r=1398589&r=1520554&r=1398589#to139). That is not a good practice, because the same stack traces would appear twice in the log (once for the generic exception, logged by the CallTag and once for the wrapped JspException). Rather do not log the exception within the CallTag and leave that to other handlers. Just rewrapping the exception into the JspException should be enough. No information would be lost that way, and stack traces only logged once in the log (by the code responsible to catch the JspException). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3459) sling:call should not log exceptions with the full stacktrace
[ https://issues.apache.org/jira/browse/SLING-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3459: --- Description: Currently within the sling:call tag all exceptions are both logged on error level and rethrown (https://fisheye6.atlassian.com/browse/~br=trunk/sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/CallTag.java?r=1398589&r=1520554&r=1398589#to139). That is not a good practice, because the same stack traces would appear twice in the log (once for the generic exception, logged by the CallTag and once for the wrapped JspException). Rather do not log the exception within the CallTag and leave that to other handlers. Just rewrapping the exception into the JspException should be enough. No information would be lost that way, and stack traces would only be logged once (by the code responsible to catch the JspException). was: Currently within the sling:call tag all exceptions are both logged on error level and rethrown (https://fisheye6.atlassian.com/browse/~br=trunk/sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/CallTag.java?r=1398589&r=1520554&r=1398589#to139). That is not a good practice, because the same stack traces would appear twice in the log (once for the generic exception, logged by the CallTag and once for the wrapped JspException). Rather do not log the exception within the CallTag and leave that to other handlers. Just rewrapping the exception into the JspException should be enough. No information would be lost that way, and stack traces only logged once in the log (by the code responsible to catch the JspException). > sling:call should not log exceptions with the full stacktrace > - > > Key: SLING-3459 > URL: https://issues.apache.org/jira/browse/SLING-3459 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.1.8 >Reporter: Konrad Windszus > > Currently within the sling:call tag all exceptions are both logged on error > level and rethrown > (https://fisheye6.atlassian.com/browse/~br=trunk/sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/CallTag.java?r=1398589&r=1520554&r=1398589#to139). > That is not a good practice, because the same stack traces would appear > twice in the log (once for the generic exception, logged by the CallTag and > once for the wrapped JspException). > Rather do not log the exception within the CallTag and leave that to other > handlers. Just rewrapping the exception into the JspException should be > enough. No information would be lost that way, and stack traces would only be > logged once (by the code responsible to catch the JspException). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3499) Support custom annotations with Sling Models
Konrad Windszus created SLING-3499: -- Summary: Support custom annotations with Sling Models Key: SLING-3499 URL: https://issues.apache.org/jira/browse/SLING-3499 Project: Sling Issue Type: New Feature Components: Extensions Affects Versions: Sling Models Implementation 1.0.2, Sling Models API 1.0.0 Reporter: Konrad Windszus To support custom annotations the API needs to be extended. The reasons for custom annotations are listed in http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is much more comfortable for developers, since they can use code completion in the IDE to see which options are available for each injector-specific annotation, apart from that it is less code to write (instead of multiple annotations on one field/method I would only have to write one annotation with some attributes). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3499) Support custom annotations with Sling Models
[ https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976566#comment-13976566 ] Konrad Windszus edited comment on SLING-3499 at 4/22/14 9:00 AM: - The pull request listed above adds the following annotations (with the optional attributes listed in brackets) - OSGiService (optional, filter) - ChildResource (optional, name, via) - ScriptVariable (optional, name) - Value (optional, name, via) - RequestAttribute (optional, name) Those annotations make Sling Models inject the field/method only from the mentioned injector. Also there are two interfaces added to the API bundle (ModelAnnotationProcessor and ModelAnnotationProcessorFactory) to make it possible to add more custom annotations in the future. was (Author: kwin): The pull request listed above adds the following annotations (with the optional attributes listed in brackets) - OSGiService (optional, filter) - ChildResource (optional, name, via) - ScriptVariable (optional, name) - Value (optional, name, via) - RequestAttribute (optional, name) Those annotations make Sling Models inject the field/method only from the mentioned injector. Also there are two interfaces added to the API bundle (ModelAnnotationProcessor and ModelAnnotationProcessorFactory) for adding more custom annotations in the future. > Support custom annotations with Sling Models > > > Key: SLING-3499 > URL: https://issues.apache.org/jira/browse/SLING-3499 > Project: Sling > Issue Type: New Feature > Components: Extensions >Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > To support custom annotations the API needs to be extended. > The reasons for custom annotations are listed in > http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is > much more comfortable for developers, since they can use code completion in > the IDE to see which options are available for each injector-specific > annotation, apart from that it is less code to write (instead of multiple > annotations on one field/method I would only have to write one annotation > with some attributes). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3499) Support custom annotations with Sling Models
[ https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976566#comment-13976566 ] Konrad Windszus commented on SLING-3499: The pull request listed above adds the following annotations (with the optional attributes listed in brackets) - OSGiService (optional, filter) - ChildResource (optional, name, via) - ScriptVariable (optional, name) - Value (optional, name, via) - RequestAttribute (optional, name) Those annotations make Sling Models inject the field/method only from the mentioned injector. Also there are two interfaces added to the API bundle (ModelAnnotationProcessor and ModelAnnotationProcessorFactory) for adding more custom annotations in the future. > Support custom annotations with Sling Models > > > Key: SLING-3499 > URL: https://issues.apache.org/jira/browse/SLING-3499 > Project: Sling > Issue Type: New Feature > Components: Extensions >Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > To support custom annotations the API needs to be extended. > The reasons for custom annotations are listed in > http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is > much more comfortable for developers, since they can use code completion in > the IDE to see which options are available for each injector-specific > annotation, apart from that it is less code to write (instead of multiple > annotations on one field/method I would only have to write one annotation > with some attributes). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3512) All dependencies referenced from TEI classes should have "compile" scope
[ https://issues.apache.org/jira/browse/SLING-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-3512: --- Description: Currently some classes which are referenced from TEI classes (e.g. DefineObjectsTEI) cannot be resolved within an IDE, because the according dependency is given with scope "provided". Since provided dependencies are not evaluated if given in a transitive way [0], the classpath of the referencing JSP does not necessarily contain those transitive dependencies, but they are necessary for the TEI to be instanciated within the IDE. For example the DefineObjectsTEI references classes from org.apache.sling.api and slf4j-api. Therefore both dependencies should have the "compile" scope. [0] - http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope was: Currently some classes which are referenced from TEI classes (e.g. DefineObjectTEI) cannot be resolved within an IDE, because the according dependency is given with scope "provided". Since provided dependencies are not evaluated if given in a transitive way [0], the classpath of the referencing JSP does not necessarily contain those transitive dependencies, but they are necessary for the TEI to be instanciated within the IDE. For example the DefineObjectTEI references classes from org.apache.sling.api and slf4j-api. Therefore both dependencies should have the "compile" scope. [0] - http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope > All dependencies referenced from TEI classes should have "compile" scope > > > Key: SLING-3512 > URL: https://issues.apache.org/jira/browse/SLING-3512 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.2.0 >Reporter: Konrad Windszus > > Currently some classes which are referenced from TEI classes (e.g. > DefineObjectsTEI) cannot be resolved within an IDE, because the according > dependency is given with scope "provided". Since provided dependencies are > not evaluated if given in a transitive way [0], the classpath of the > referencing JSP does not necessarily contain those transitive dependencies, > but they are necessary for the TEI to be instanciated within the IDE. > For example the DefineObjectsTEI references classes from org.apache.sling.api > and slf4j-api. Therefore both dependencies should have the "compile" scope. > [0] - > http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3512) All dependencies referenced from TEI classes should have "compile" scope
Konrad Windszus created SLING-3512: -- Summary: All dependencies referenced from TEI classes should have "compile" scope Key: SLING-3512 URL: https://issues.apache.org/jira/browse/SLING-3512 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting JSP-Taglib 2.2.0 Reporter: Konrad Windszus Currently some classes which are referenced from TEI classes (e.g. DefineObjectTEI) cannot be resolved within an IDE, because the according dependency is given with scope "provided". Since provided dependencies are not evaluated if given in a transitive way [0], the classpath of the referencing JSP does not necessarily contain those transitive dependencies, but they are necessary for the TEI to be instanciated within the IDE. For example the DefineObjectTEI references classes from org.apache.sling.api and slf4j-api. Therefore both dependencies should have the "compile" scope. [0] - http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3512) All dependencies referenced from TEI classes should have "compile" scope
[ https://issues.apache.org/jira/browse/SLING-3512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979490#comment-13979490 ] Konrad Windszus commented on SLING-3512: In Eclipse the TEI cannot be instanciated if the referenced classes are not in the Maven classpath. The according warning message is not very descriptive though: "The TagExtraInfo class for "sling:defineObjects" (org.apache.sling.scripting.jsp.taglib.DefineObjectsTEI) could not be instantiated". It is hard to derive from that message, which class is missing from the classpath. In my regard all necessary classes should be loaded by Maven (even the transitive ones). It is very cumbersome to add dependencies manually to the project, just for the IDE to be able to instanciate the TEI class. > All dependencies referenced from TEI classes should have "compile" scope > > > Key: SLING-3512 > URL: https://issues.apache.org/jira/browse/SLING-3512 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP-Taglib 2.2.0 >Reporter: Konrad Windszus > > Currently some classes which are referenced from TEI classes (e.g. > DefineObjectsTEI) cannot be resolved within an IDE, because the according > dependency is given with scope "provided". Since provided dependencies are > not evaluated if given in a transitive way [0], the classpath of the > referencing JSP does not necessarily contain those transitive dependencies, > but they are necessary for the TEI to be instanciated within the IDE. > For example the DefineObjectsTEI references classes from org.apache.sling.api > and slf4j-api. Therefore both dependencies should have the "compile" scope. > [0] - > http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3523) ResourceResolverImpl.mangleNamespace and unmangleNamespaces behave differently
Konrad Windszus created SLING-3523: -- Summary: ResourceResolverImpl.mangleNamespace and unmangleNamespaces behave differently Key: SLING-3523 URL: https://issues.apache.org/jira/browse/SLING-3523 Project: Sling Issue Type: Bug Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Konrad Windszus Currently everything which smells like a namespace is automatically mangled during the call of ResourceResolver.map. But only registered namespaces are unmangled automatically during ResourceResolver.resolve. This should be fixed, so that mangling an arbitrary string and afterwards unmangling that, should always return the original string. You can see the according code in https://fisheye6.atlassian.com/browse/~br=trunk/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?r=1590034#to1010. There is no namespace check during mangling. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3486) Configuration changes like jasper.trimSpaces only work after cleaning /var/classes and bundle restart
[ https://issues.apache.org/jira/browse/SLING-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985427#comment-13985427 ] Konrad Windszus commented on SLING-3486: To be honest, I don't see any good reason, why you want to retain the old compiled JSPs in case you have changed something about the configuration. > Configuration changes like jasper.trimSpaces only work after cleaning > /var/classes and bundle restart > - > > Key: SLING-3486 > URL: https://issues.apache.org/jira/browse/SLING-3486 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting JSP 2.0.28 >Reporter: Markus Haack > Labels: jsp, scripting > > Enabling jasper.trimSpaces of org.apache.sling.scripting.jsp has not > immediately effect and therefor does not work. > "Fix" is to clean /var/classes and restart the instance, then it works. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3540) JCR Install bundle plugin can not be installed on an out-of-the-box launchpad
[
https://issues.apache.org/jira/browse/SLING-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987707#comment-13987707
]
Konrad Windszus commented on SLING-3540:
http://apache-sling.73963.n3.nabble.com/Issue-using-PUT-with-maven-sling-plugin-and-non-existent-path-td3885587.html
> JCR Install bundle plugin can not be installed on an out-of-the-box launchpad
> -
>
> Key: SLING-3540
> URL: https://issues.apache.org/jira/browse/SLING-3540
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JCRInstall Bundle Archetype 1.0.0
>Reporter: Robert Munteanu
>
> {code}[INFO] Installing Bundle
> com.example.jcrbundle(/home/rmuntean/tmp/jcrbundle/target/jcrbundle-1.0-SNAPSHOT.jar)
> to http://localhost:8080/libs/sling/install via PUT
> [ERROR] Installation failed, cause: Conflict{code}
> The reason is that the default Sling launchpad does not have a
> /libs/sling/install directory structure out of the box. The workaround is to
> create it, e.g. with curl
> {code}
> curl -u admin:admin -X MKCOL http://localhost:8080/libs
> curl -u admin:admin -X MKCOL http://localhost:8080/libs/sling
> curl -u admin:admin -X MKCOL http://localhost:8080/libs/sling/install
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (SLING-3543) Provide a Felix Web Console Tab exposing the available Scripting Variables
Konrad Windszus created SLING-3543: -- Summary: Provide a Felix Web Console Tab exposing the available Scripting Variables Key: SLING-3543 URL: https://issues.apache.org/jira/browse/SLING-3543 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting Core 2.0.26 Reporter: Konrad Windszus Currently you can very dynamically define the scripting variables (https://cwiki.apache.org/confluence/display/SLING/Adding+New+Scripting+Variables). Therefore it would be very good to expose which variables are exposed within each script provider in a dedicated web console tab. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3543) Provide a Felix Web Console Tab exposing the available Scripting Variables
[ https://issues.apache.org/jira/browse/SLING-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989444#comment-13989444 ] Konrad Windszus commented on SLING-3543: I agree, that the script engines tab should be fine for that. It should expose which variables (name and type) are exposed through which service (if possible). This is especially useful in the context of Sling Models, as there you have to know what can be injected from the BindingsInjector. > Provide a Felix Web Console Tab exposing the available Scripting Variables > -- > > Key: SLING-3543 > URL: https://issues.apache.org/jira/browse/SLING-3543 > Project: Sling > Issue Type: Bug > Components: Scripting >Affects Versions: Scripting Core 2.0.26 >Reporter: Konrad Windszus > > Currently you can very dynamically define the scripting variables > (https://cwiki.apache.org/confluence/display/SLING/Adding+New+Scripting+Variables). > Therefore it would be very good to expose which variables are exposed within > each script provider in a dedicated web console tab. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3543) Provide a Felix Web Console Tab exposing the available Scripting Variables
[ https://issues.apache.org/jira/browse/SLING-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989470#comment-13989470 ] Konrad Windszus commented on SLING-3543: Why can't we leverage https://fisheye6.atlassian.com/browse/~br=trunk/sling/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/BindingsValuesProvidersByContextImpl.java?r=1565659#to126? That should expose all BindingValuesProviders by Script Engine. On those you could just call addBinding with a regular HashMap as parameter. That should in the end contain all custom Bindings being available (probably the default ones need to be added there as well). > Provide a Felix Web Console Tab exposing the available Scripting Variables > -- > > Key: SLING-3543 > URL: https://issues.apache.org/jira/browse/SLING-3543 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Core 2.0.26 >Reporter: Konrad Windszus > > Currently you can very dynamically define the scripting variables > (https://cwiki.apache.org/confluence/display/SLING/Adding+New+Scripting+Variables). > Therefore it would be very good to expose which variables are exposed within > each script provider in a dedicated web console tab. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3543) Provide a Felix Web Console Tab exposing the available Scripting Variables
[ https://issues.apache.org/jira/browse/SLING-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990406#comment-13990406 ] Konrad Windszus commented on SLING-3543: I see that this is more complicated than initially thought. I think that for the beginning just exposing the bindings for the default context (request) should be fine. But the problem really is, that we need to mock a lot of Sling API objects (basically all the ones being defined by DefaultSlingScript.verifySlingBindings which is SlingScriptHelper, SlingHttpServletResponse, SlingHttpServletRequest, Resource, PrintWriter and BufferedReader). That would be a lot of code. Any other ideas, how to prevent to force all BindingsValuesProvider's to just expose the bindings via Properties? I thought about calling DefaultSlingScript.verifySlingBindings but that would still require a real SlingHttpServletRequest. > Provide a Felix Web Console Tab exposing the available Scripting Variables > -- > > Key: SLING-3543 > URL: https://issues.apache.org/jira/browse/SLING-3543 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Core 2.0.26 >Reporter: Konrad Windszus > > Currently you can very dynamically define the scripting variables > (https://cwiki.apache.org/confluence/display/SLING/Adding+New+Scripting+Variables). > Therefore it would be very good to expose which variables are exposed within > each script provider in a dedicated web console tab. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3546) SLING2617Test fails, JasperException not found
[
https://issues.apache.org/jira/browse/SLING-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990408#comment-13990408
]
Konrad Windszus commented on SLING-3546:
The problem is that the generated servlet used to contain a reference to
JasperException whenever the directive jsp:setProperty was used. If the
classloader, which loads the Jasper-generated servlet has no access to that
class, there is an exception thrown. Does the new Jasper no longer require
access to that exception class?
> SLING2617Test fails, JasperException not found
> ---
>
> Key: SLING-3546
> URL: https://issues.apache.org/jira/browse/SLING-3546
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Bertrand Delacretaz
>Assignee: Carsten Ziegeler
> Fix For: Launchpad Testing 7
>
>
> The SLING2617Test (from launchpad/integration-tests) fails, probably due to
> the recent JSP compiler changes, due to not finding the
> org.apache.sling.scripting.jsp.jasper.JasperException class.
> The failing script is bean-set-get.jsp [1].
> {code}
> An error occurred at line: 23 in the jsp file: /apps/nt/unstructured/html.jsp
> The type org.apache.sling.scripting.jsp.jasper.JasperException cannot be
> resolved. It is indirectly referenced from required .class files
> ...
> An error occurred at line: 25 in the jsp file: /apps/nt/unstructured/html.jsp
> org.apache.sling.scripting.jsp.jasper.JasperException cannot be resolved to a
> type
> {code}
> [1]
> https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/resources/integration-test/issues/sling2617/bean-set-get.jsp
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (SLING-3547) Default handling for numerical types on Sling Models broken
[ https://issues.apache.org/jira/browse/SLING-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992732#comment-13992732 ] Konrad Windszus edited comment on SLING-3547 at 5/8/14 12:46 PM: - The referenced pull request shows the issue here. I am not sure how to fix because obviously just changing the comparison to the according object wrapper class leads to another error during setting the field (because arrays are not automatically boxed)! was (Author: kwin): The referenced pull request shows the issue here. I am not sure how to fix because obviously just changing the comparison to the according object wrapper class leads to another error during setting the field (reflection does not support autoboxing)! > Default handling for numerical types on Sling Models broken > --- > > Key: SLING-3547 > URL: https://issues.apache.org/jira/browse/SLING-3547 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > Currently all default annotations on numeric types lead to the following > warning: > org.apache.sling.models.impl.ModelAdapterFactory Default values for class > java.lang.Boolean are not supported and the default is not used. > This is due to the fact that first all types are converted from Primitives to > Object Wrapper Classes (in mapPrimitiveClasses). Then the comparison against > that type only considers Primitives (in getDefaultValue, except for Strings), > which obviously failed, because either those were Object Wrapper Classes > right from the beginning, or they were converted to those. > In my regard you should compare the Type against e.g. Integer.class instead > of Integer.TYPE (ModelAdapterFactory, line 428ff). Otherwise defaults for > numerical types will not work. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3547) Default handling for numerical types on Sling Models broken
[ https://issues.apache.org/jira/browse/SLING-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992732#comment-13992732 ] Konrad Windszus edited comment on SLING-3547 at 5/8/14 1:41 PM: The pull requests adds a test around that and provides the fix for it as well. was (Author: kwin): The above pull requests add a test around that and provides the fix for it as well. > Default handling for numerical types on Sling Models broken > --- > > Key: SLING-3547 > URL: https://issues.apache.org/jira/browse/SLING-3547 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > Currently all default annotations on numeric types lead to the following > warning: > org.apache.sling.models.impl.ModelAdapterFactory Default values for class > java.lang.Boolean are not supported and the default is not used. > This is due to the fact that first all types are converted from Primitives to > Object Wrapper Classes (in mapPrimitiveClasses). Then the comparison against > that type only considers Primitives (in getDefaultValue, except for Strings), > which obviously failed, because either those were Object Wrapper Classes > right from the beginning, or they were converted to those. > In my regard you should compare the Type against e.g. Integer.class instead > of Integer.TYPE (ModelAdapterFactory, line 428ff). Otherwise defaults for > numerical types will not work. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3547) Default handling for numerical types on Sling Models broken
[ https://issues.apache.org/jira/browse/SLING-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992732#comment-13992732 ] Konrad Windszus edited comment on SLING-3547 at 5/8/14 1:41 PM: The above pull requests add a test around that and provides the fix for it as well. was (Author: kwin): The referenced pull request shows the issue here. I am not sure how to fix because obviously just changing the comparison to the according object wrapper class leads to another error during setting the field (because arrays are not automatically boxed)! > Default handling for numerical types on Sling Models broken > --- > > Key: SLING-3547 > URL: https://issues.apache.org/jira/browse/SLING-3547 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > Currently all default annotations on numeric types lead to the following > warning: > org.apache.sling.models.impl.ModelAdapterFactory Default values for class > java.lang.Boolean are not supported and the default is not used. > This is due to the fact that first all types are converted from Primitives to > Object Wrapper Classes (in mapPrimitiveClasses). Then the comparison against > that type only considers Primitives (in getDefaultValue, except for Strings), > which obviously failed, because either those were Object Wrapper Classes > right from the beginning, or they were converted to those. > In my regard you should compare the Type against e.g. Integer.class instead > of Integer.TYPE (ModelAdapterFactory, line 428ff). Otherwise defaults for > numerical types will not work. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3547) Default handling for numerical types on Sling Models broken
Konrad Windszus created SLING-3547: -- Summary: Default handling for numerical types on Sling Models broken Key: SLING-3547 URL: https://issues.apache.org/jira/browse/SLING-3547 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Sling Models Implementation 1.0.2 Reporter: Konrad Windszus Currently all default annotations on numeric types lead to the following warning: org.apache.sling.models.impl.ModelAdapterFactory Default values for class java.lang.Boolean are not supported and the default is not used. This is due to the fact that first all types are converted from Primitives to Object Wrapper Classes (in mapPrimitiveClasses). Then the comparison against that type only considers Primitives (in getDefaultValue, except for Strings), which obviously failed, because either those were Object Wrapper Classes right from the beginning, or they were converted to those. In my regard you should compare the Type against e.g. Integer.class instead of Integer.TYPE (ModelAdapterFactory, line 428ff). Otherwise defaults for numerical types will not work. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3516) Sling Models Resource Child List Injector
[
https://issues.apache.org/jira/browse/SLING-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993695#comment-13993695
]
Konrad Windszus commented on SLING-3516:
I would rather go for a separate injector, which also supports some kind of
filtering expression (a regexp) against the child node names, to only adapt
some of the children (and leave out others).
Your approach is different from the regular ResourceChild injector, because it
does not consider the name at all. I think using a separate injector is the
cleaner approach here.
> Sling Models Resource Child List Injector
> -
>
> Key: SLING-3516
> URL: https://issues.apache.org/jira/browse/SLING-3516
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: Sling Models Implementation 1.0.2
>Reporter: Igor Sechyn
>Priority: Minor
> Attachments: ChildResourceInjectorPatch.txt
>
>
> Hi All,
> We have decided to use the sling models to process some hierarchical data in
> our project and are facing the following issue right now.
> Our content structure looks as follows:
> {code}
> +- dealer
> |
> +- addresses
> |
> + -address1
> |
> +- address2
> {code}
> Dealer and address nodes have attributes, that can be injected through the
> ValueMapInjector, so everything works fine here. Our goal however is also to
> inject the List of AddressModel objects into the DealerModel object,
> something like this:
> {code}
> @Inject
> List addresses
> {code}
> The desired behavior would be:
> - the injector resolves addresses as a child resource of the adaptable object
> - iterates over the children of this resource (in this case „addresses")
> - adapts each child to the actual type argument of the parameterized list type
> - returns the list of adapted model objects
> I have tried to play around with @Named but could not get it to work. The
> only way of making it work, was to write a custom injector, which worked out
> pretty fine.
> But I was still wondering, if there might be an OOTB functionality, which can
> be used for this use case
> Cheers, Igor.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3499) Support custom annotations with Sling Models
[ https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998721#comment-13998721 ] Konrad Windszus commented on SLING-3499: Hi Justin, the patch looks fine to me, but please make sure that the changed handling of default values is not overwritten (SLING-3547). I definitely appreciate your changes. There is only one thing which should be changed which is the Javadoc for InjectAnnotationProcessor.isOptional(). There is some copy paste mistake in there. It should rather state that three values are supported as return values: true, means the injection can be left out, false means it is mandatory and null means the value from the Optional annotation is taken. > Support custom annotations with Sling Models > > > Key: SLING-3499 > URL: https://issues.apache.org/jira/browse/SLING-3499 > Project: Sling > Issue Type: New Feature > Components: Extensions >Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > To support custom annotations the API needs to be extended. > The reasons for custom annotations are listed in > http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is > much more comfortable for developers, since they can use code completion in > the IDE to see which options are available for each injector-specific > annotation, apart from that it is less code to write (instead of multiple > annotations on one field/method I would only have to write one annotation > with some attributes). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
Konrad Windszus created SLING-3570:
--
Summary: Assertion failed when trying to create new Sling Bundle
project
Key: SLING-3570
URL: https://issues.apache.org/jira/browse/SLING-3570
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Konrad Windszus
When I try to create a new Sling Bundle project with the wizard I get the
following exception:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
!MESSAGE assertion failed:
!STACK 0
org.eclipse.core.runtime.AssertionFailedException: assertion failed:
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
at
org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
at
org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
at
org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
at
org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
at org.eclipse.core.internal.resources.Project.build(Project.java:114)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
at
org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
{code}
I tested with SVN revision 1595036.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server
[
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999239#comment-13999239
]
Konrad Windszus commented on SLING-3567:
The fix worked for me. Thanks.
> Cannot add null entries, when creating a new bundle and adding it to an
> existing server
> ---
>
> Key: SLING-3567
> URL: https://issues.apache.org/jira/browse/SLING-3567
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.0.0
>
>
> With the most recent version of Sling IDE Tooling I get the following
> exception when adding a new Sling bundle project and adding it to an existing
> server:
> {code}
> !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
> !MESSAGE Cannot add null entries
> !STACK 0
> java.lang.IllegalArgumentException: Cannot add null entries
> at
> org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
> at
> org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
> at
> org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
> at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
> at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
> at
> org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
> at
> org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
> at
> org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
> at org.eclipse.jface.window.Window.open(Window.java:802)
> at
> org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
> at
> org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
> at
> org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
> at
> org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
> at
> org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
> at
> org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
> at
> org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
> at
> org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
> at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
> at
> org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
> at
> org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
> at
> org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
> at
> org.eclipse.ui.internal.actions.CommandAction.
[jira] [Commented] (SLING-3547) Default handling for numerical types on Sling Models broken
[ https://issues.apache.org/jira/browse/SLING-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992732#comment-13992732 ] Konrad Windszus commented on SLING-3547: The referenced pull request shows the issue here. I am not sure how to fix because obviously just changing the comparison to the according object wrapper class leads to another error during setting the field (reflection does not support autoboxing)! > Default handling for numerical types on Sling Models broken > --- > > Key: SLING-3547 > URL: https://issues.apache.org/jira/browse/SLING-3547 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > Currently all default annotations on numeric types lead to the following > warning: > org.apache.sling.models.impl.ModelAdapterFactory Default values for class > java.lang.Boolean are not supported and the default is not used. > This is due to the fact that first all types are converted from Primitives to > Object Wrapper Classes (in mapPrimitiveClasses). Then the comparison against > that type only considers Primitives (in getDefaultValue, except for Strings), > which obviously failed, because either those were Object Wrapper Classes > right from the beginning, or they were converted to those. > In my regard you should compare the Type against e.g. Integer.class instead > of Integer.TYPE (ModelAdapterFactory, line 428ff). Otherwise defaults for > numerical types will not work. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[
https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-3570:
---
Affects Version/s: Sling Eclipse IDE 1.0.0
> Assertion failed when trying to create new Sling Bundle project
> ---
>
> Key: SLING-3570
> URL: https://issues.apache.org/jira/browse/SLING-3570
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.0.0
>
>
> When I try to create a new Sling Bundle project with the wizard I get the
> following exception:
> {code}
> !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
> !MESSAGE assertion failed:
> !STACK 0
> org.eclipse.core.runtime.AssertionFailedException: assertion failed:
> at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
> at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
> at
> org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
> at
> org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
> at
> org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
> at
> org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
> at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
> at
> org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
> at
> org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
> at org.eclipse.core.internal.resources.Project.build(Project.java:114)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
> at
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
> at
> org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
> at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
> {code}
> I tested with SVN revision 1595036.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server
Konrad Windszus created SLING-3567:
--
Summary: Cannot add null entries, when creating a new bundle and
adding it to an existing server
Key: SLING-3567
URL: https://issues.apache.org/jira/browse/SLING-3567
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
With the most recent version of Sling IDE Tooling I get the following exception
when adding a new Sling bundle project and adding it to an existing server:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
!MESSAGE Cannot add null entries
!STACK 0
java.lang.IllegalArgumentException: Cannot add null entries
at
org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
at
org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
at
org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
at
org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
at
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
at org.eclipse.jface.window.Window.open(Window.java:802)
at
org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
at
org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
at
org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
at
org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
at
org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at
org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at
org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at
org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
at
org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
at
org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
at
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at or
[jira] [Commented] (SLING-3499) Support custom annotations with Sling Models
[ https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003052#comment-14003052 ] Konrad Windszus commented on SLING-3499: Hi [~justinedelson], my intent was to make it possible to define defaults also within the custom annotations. I didn't leverage that for my custom annotations, because it is just a lot of effort due to type limitations on annotation attributes (http://stackoverflow.com/questions/1458535/which-types-can-be-used-for-java-annotation-members). Therefore I decided to still leverage the default annotation for that. Otherwise a lot of boilerplate code would be necessary, which wouldn't add too much value IMHO. I still would leave it within the annotation processor, because I can image that there might be use cases for that (in other annotations). > Support custom annotations with Sling Models > > > Key: SLING-3499 > URL: https://issues.apache.org/jira/browse/SLING-3499 > Project: Sling > Issue Type: New Feature > Components: Extensions >Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > To support custom annotations the API needs to be extended. > The reasons for custom annotations are listed in > http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is > much more comfortable for developers, since they can use code completion in > the IDE to see which options are available for each injector-specific > annotation, apart from that it is less code to write (instead of multiple > annotations on one field/method I would only have to write one annotation > with some attributes). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[
https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003542#comment-14003542
]
Konrad Windszus commented on SLING-3570:
[~rombert] - Thanks a lot. Works perfectly now for me as well and indeed a lot
faster.
> Assertion failed when trying to create new Sling Bundle project
> ---
>
> Key: SLING-3570
> URL: https://issues.apache.org/jira/browse/SLING-3570
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.0.0
>
>
> When I try to create a new Sling Bundle project with the wizard I get the
> following exception:
> {code}
> !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
> !MESSAGE assertion failed:
> !STACK 0
> org.eclipse.core.runtime.AssertionFailedException: assertion failed:
> at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
> at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
> at
> org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
> at
> org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
> at
> org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
> at
> org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
> at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
> at
> org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
> at
> org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
> at org.eclipse.core.internal.resources.Project.build(Project.java:114)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
> at
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
> at
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
> at
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
> at
> org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
> at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
> {code}
> I tested with SVN revision 1595036.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
Konrad Windszus created SLING-3589:
--
Summary: Creating new nodes within a new Sling Content Project
leads to NPE
Key: SLING-3589
URL: https://issues.apache.org/jira/browse/SLING-3589
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Konrad Windszus
{code}
!ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
at
org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938)
at
org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49)
at
org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
at
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
at
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}
I just created a new Sling Content Project with the Wizard and tried to add a
new node via right click on jcr_root/apps/example/item -> New -> New JCR Node.
The project is connected to a running server. I tested with SVN rev. 1596303
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[
https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003581#comment-14003581
]
Konrad Windszus commented on SLING-3589:
This is due to the fact, that the ProjectUtil.findFilterPath(IProject) does
return null for a newly created Sling Content Project.
BTW: How do I set the filter appropriately, didn't find anything in
https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide
nor in the project properties?
> Creating new nodes within a new Sling Content Project leads to NPE
> --
>
> Key: SLING-3589
> URL: https://issues.apache.org/jira/browse/SLING-3589
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Reporter: Konrad Windszus
>
> {code}
> !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830
> !MESSAGE Unhandled event loop exception
> !STACK 0
> java.lang.NullPointerException
> at
> org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938)
> at
> org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49)
> at
> org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
> at
> org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
> at
> org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
> at
> org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
> at
> org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at
> org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> at
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
> {code}
> I just created a new Sling Content Project with the Wizard and tried to add a
> new node via right click on jcr_root/apps/example/item -> New -> New JCR Node.
> The project is connected to a running server. I tested with SVN rev. 1596303
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[
https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003589#comment-14003589
]
Konrad Windszus commented on SLING-3589:
Would it be possible to create a project with a preconfigured filter, when
using the wizard? At least the error message should be improved.
> Creating new nodes within a new Sling Content Project leads to NPE
> --
>
> Key: SLING-3589
> URL: https://issues.apache.org/jira/browse/SLING-3589
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Reporter: Konrad Windszus
>
> {code}
> !ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830
> !MESSAGE Unhandled event loop exception
> !STACK 0
> java.lang.NullPointerException
> at
> org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938)
> at
> org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49)
> at
> org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
> at
> org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
> at
> org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
> at
> org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
> at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
> at
> org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611)
> at
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> at
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> at
> org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> at
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
> {code}
> I just created a new Sling Content Project with the Wizard and tried to add a
> new node via right click on jcr_root/apps/example/item -> New -> New JCR Node.
> The project is connected to a running server. I tested with SVN rev. 1596303
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3136) Configure -> Convert to Bundle/Content Package project should not assume the project is Maven-based
[ https://issues.apache.org/jira/browse/SLING-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004550#comment-14004550 ] Konrad Windszus commented on SLING-3136: Why do you require the filter.xml? Is looking just for jcr_root not enough? The more candidates we have for conversion to a content-package the better :-) > Configure -> Convert to Bundle/Content Package project should not assume the > project is Maven-based > --- > > Key: SLING-3136 > URL: https://issues.apache.org/jira/browse/SLING-3136 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Robert Munteanu >Assignee: Robert Munteanu > Fix For: Sling Eclipse IDE 1.0.0 > > > There are a couple of issues with the way the current configuration actions > are done: > - it is only enabled for Maven projects ; this does not apply to all projects > and is confusing > - for the Content Package action, it only enables itself for projects of type > 'content-package' . This should not be checked against since this packaging > does not exist from a Sling point of view > - for the Content package action, it assumes that the content sync root is > src/main/content/jcr_root, even though it may not exist. > Instead, I propose the following: > 1. Use only the WST facets definition to decide if we can convert a project > to a facet ; I guess for now we can simply disallow projects from having both > facets ( content + bundle ) > 2. Do not make Maven a hard requirement > 3. Use the following heuristic to detect the content sync root: > - look for the following ( can be made configurable later ) directories > - jcr_root > - src/main/content/jcr_root > Whenever such a project is found, make it the default jcr_root directory. If > none is found, ask the user for input. > More specific actions can be done as part of the m2e configurator for content > packages tracked under SLING-3100 . -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3592) Remove embedded bundle archetype in favour of released version
[ https://issues.apache.org/jira/browse/SLING-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009829#comment-14009829 ] Konrad Windszus commented on SLING-3592: Would it be possible to allow other (custom) archetypes as well? Please make that configurable via the workspace properties. > Remove embedded bundle archetype in favour of released version > -- > > Key: SLING-3592 > URL: https://issues.apache.org/jira/browse/SLING-3592 > Project: Sling > Issue Type: Task > Components: IDE >Reporter: Robert Munteanu > Fix For: Sling Eclipse IDE 1.0.0 > > > The vote for the sling-bundle-archetype 1.0.2 is complete, and we should: > * remove the embedded archetype we package > * allow usage of versions >= 1.0.2 in our wizard > I think we can safely assume that the user has access to Maven Central, usage > of the archetype won't work otherwise. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3612) Provide a m2e project configurator for packaging "bundle"
Konrad Windszus created SLING-3612: -- Summary: Provide a m2e project configurator for packaging "bundle" Key: SLING-3612 URL: https://issues.apache.org/jira/browse/SLING-3612 Project: Sling Issue Type: Improvement Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus That configurator should automatically setup the project with the correct facets (to make it possible to deploy via Sling IDE Tools). That configurator would e.g. be triggered, when a new project is imported into the IDE (e.g. from an existing local Maven project, or via Subclipe/Subversive/eGit) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3612) Provide a m2e project configurator for packaging "bundle"
[ https://issues.apache.org/jira/browse/SLING-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010106#comment-14010106 ] Konrad Windszus commented on SLING-3612: This is supported: http://dev.eclipse.org/mhonarc/lists/m2e-dev/msg00177.html > Provide a m2e project configurator for packaging "bundle" > - > > Key: SLING-3612 > URL: https://issues.apache.org/jira/browse/SLING-3612 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > > That configurator should automatically setup the project with the correct > facets (to make it possible to deploy via Sling IDE Tools). That configurator > would e.g. be triggered, when a new project is imported into the IDE (e.g. > from an existing local Maven project, or via Subclipe/Subversive/eGit) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3612) Provide a m2e project configurator for packaging "bundle"
[ https://issues.apache.org/jira/browse/SLING-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010106#comment-14010106 ] Konrad Windszus edited comment on SLING-3612 at 5/27/14 7:05 PM: - This is supported: http://dev.eclipse.org/mhonarc/lists/m2e-dev/msg00177.html. The primary lifecycle mapping should be the one from https://github.com/tesla/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/lifecycle-mapping-metadata.xml was (Author: kwin): This is supported: http://dev.eclipse.org/mhonarc/lists/m2e-dev/msg00177.html > Provide a m2e project configurator for packaging "bundle" > - > > Key: SLING-3612 > URL: https://issues.apache.org/jira/browse/SLING-3612 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > > That configurator should automatically setup the project with the correct > facets (to make it possible to deploy via Sling IDE Tools). That configurator > would e.g. be triggered, when a new project is imported into the IDE (e.g. > from an existing local Maven project, or via Subclipe/Subversive/eGit) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3132) [Tooling] provide a filter.xml editor separate and/or as part of the import-content wizard
[ https://issues.apache.org/jira/browse/SLING-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010873#comment-14010873 ] Konrad Windszus commented on SLING-3132: Since filter rules are sometimes a littlebit tricky to evaluate, it would be great to have an Eclipse View which tests a path against a filter.xml and shows what happens to that node (in case it is existing in the repo and in case it is part of the installed content). > [Tooling] provide a filter.xml editor separate and/or as part of the > import-content wizard > -- > > Key: SLING-3132 > URL: https://issues.apache.org/jira/browse/SLING-3132 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Stefan Egli > Fix For: Sling Eclipse IDE 1.0.2 > > > As a follow-up of SLING-2984: provide an editor of the filter.xml either > separate and/or as part of the import-content-wizard. That would allow to > import multiple paths in one go in the import-content-wizard. (This > filter.xml-editing would also go hand-in-hand with the "re-import" > button/action.) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3499) Support custom annotations with Sling Models
[ https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017759#comment-14017759 ] Konrad Windszus commented on SLING-3499: Hi [~justinedelson], any progress on this? Do you need more information from me? > Support custom annotations with Sling Models > > > Key: SLING-3499 > URL: https://issues.apache.org/jira/browse/SLING-3499 > Project: Sling > Issue Type: New Feature > Components: Extensions >Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2 >Reporter: Konrad Windszus > > To support custom annotations the API needs to be extended. > The reasons for custom annotations are listed in > http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is > much more comfortable for developers, since they can use code completion in > the IDE to see which options are available for each injector-specific > annotation, apart from that it is less code to write (instead of multiple > annotations on one field/method I would only have to write one annotation > with some attributes). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3612) Provide a m2e project configurator for packaging "bundle"
[ https://issues.apache.org/jira/browse/SLING-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018021#comment-14018021 ] Konrad Windszus commented on SLING-3612: You are right, that if now the plugin is installed all bundle projects would end up with the sling facet. I am not sure, how to check for the maven-sling-plugin, but probably I can figure out something. Does the Sling Facet do any harm? > Provide a m2e project configurator for packaging "bundle" > - > > Key: SLING-3612 > URL: https://issues.apache.org/jira/browse/SLING-3612 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.0 >Reporter: Konrad Windszus > Fix For: Sling Eclipse IDE 1.0.2 > > > That configurator should automatically setup the project with the correct > facets (to make it possible to deploy via Sling IDE Tools). That configurator > would e.g. be triggered, when a new project is imported into the IDE (e.g. > from an existing local Maven project, or via Subclipe/Subversive/eGit) -- This message was sent by Atlassian JIRA (v6.2#6252)
