[Bug 5258] meta SOMERULE (/__SOMERULE_/) > 5
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=5258 Henrik Krohns changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #22 from Henrik Krohns --- Committed to 3.4, so someone might actually use it in the future. SendingMANIFEST SendingUPGRADE Sendinglib/Mail/SpamAssassin/Conf/Parser.pm Sendinglib/Mail/SpamAssassin/Conf.pm Sendinglib/Mail/SpamAssassin/Constants.pm Sendinglib/Mail/SpamAssassin/Plugin/Check.pm Adding t/basic_meta2.t Transmitting file data ...done Committing transaction... Committed revision 1861377. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) > 5
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Comment #21 from Henrik Krohns --- (In reply to RW from comment #20) > I don't have trunk, but looking at the patch I don't see any brackets being > added around the sum. In which case > > 2*rules_matching(__FOO_*) > > would expand to > > 2*FOO_1 + FOO_2 ... It will expand to 2* (FOO_1+FOO_2) as per return " ($expanded) "; -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) > 5
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=5258 RW changed: What|Removed |Added CC||rwmailli...@googlemail.com --- Comment #20 from RW --- I don't have trunk, but looking at the patch I don't see any brackets being added around the sum. In which case 2*rules_matching(__FOO_*) would expand to 2*FOO_1 + FOO_2 ... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) > 5
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=5258 Henrik Krohns changed: What|Removed |Added CC||h...@hege.li --- Comment #19 from Henrik Krohns --- Try out in trunk. if (can(Mail::SpamAssassin::Conf::feature_meta_rules_matching)) meta FOO __BAR + rules_matching(__BAZ_*) > 2 endif SendingMANIFEST SendingUPGRADE Sendinglib/Mail/SpamAssassin/Conf/Parser.pm Sendinglib/Mail/SpamAssassin/Conf.pm Sendinglib/Mail/SpamAssassin/Constants.pm Sendinglib/Mail/SpamAssassin/Plugin/Check.pm Adding t/basic_meta2.t Transmitting file data ...done Committing transaction... Committed revision 1860912. If seems nice, commit to 3.4.. not a big change.. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) > 5
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=5258 Kevin A. McGrail changed: What|Removed |Added Severity|enhancement |blocker Target Milestone|3.4.2 |3.4.3 --- Comment #18 from Kevin A. McGrail --- Moving this up to a blocker so it is looked at for 3.4.3. It did not get reviewed for 3.4.2. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Comment #17 from Kevin A. McGrail kmcgr...@pccc.com --- CLA received from Karl. We can look at this as soon as 3.4.1 is done! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 Kevin A. McGrail kmcgr...@pccc.com changed: What|Removed |Added CC||kmcgr...@pccc.com Target Milestone|3.4.0 |3.4.1 --- Comment #14 from Kevin A. McGrail kmcgr...@pccc.com --- Moving all open bugs where target is defined and 3.4.0 or lower to 3.4.1 target -- You are receiving this mail because: You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 Mark Martinec mark.marti...@ijs.si changed: What|Removed |Added Target Milestone|3.3.2 |3.4.0 -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 Karsten Bräckelmann guent...@rudersport.de changed: What|Removed |Added Group|security| Component|Security|Libraries AssignedTo|secur...@spamassassin.apach |dev@spamassassin.apache.org |e.org | --- Comment #13 from Karsten Bräckelmann guent...@rudersport.de 2010-03-23 17:42:55 UTC --- Moving back off of Security, which got changed by accident during the mass Target Milestone move. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 Justin Mason j...@jmason.org changed: What|Removed |Added Group|security| Component|Security|Libraries AssignedTo|secur...@spamassassin.apach |dev@spamassassin.apache.org |e.org | --- Comment #11 from Justin Mason j...@jmason.org 2010-01-27 03:16:38 UTC --- reassigning, too -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Additional Comments From [EMAIL PROTECTED] 2007-04-28 06:19 --- None of the choices look very happy, do they? :-( Maybe could use a doubled asterisk for the glob(*): FOO_**_BAR. As long as exponentiation doesn't use this the syntax should be clear. I'm not sure that trick works nearly as well if you are using a glob(?) also, since it can become inobvious how many characters you are talking about: FOO??_BAR. Or use Justin's 'fake function' syntax, but perlize it: g(FOO_*_BAR). --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Additional Comments From [EMAIL PROTECTED] 2007-04-28 14:48 --- (In reply to comment #8) Maybe could use a doubled asterisk for the glob(*): FOO_**_BAR. As long as exponentiation doesn't use this the syntax should be clear. I'm not sure that trick works nearly as well if you are using a glob(?) also, since it can become inobvious how many characters you are talking about: FOO??_BAR. Interesting idea. I still prefer rules_matching(FOO_*_BAR) to FOO_**_BAR, though. --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Additional Comments From [EMAIL PROTECTED] 2007-04-27 03:08 --- Okay. What do you suggest for syntax, since currently meta RULE FOO_*_BAR would be (FOO_) * (_BAR). Alternatives might be to use a character other than *, such as FOO_%_BAR, or some delimeter syntax such as %FOO_*_BAR%. agreed, that's an issue. how's about a faux function-style UI? meta AA_MULTI_2 (rules_matching(AA_*) = 2) hmm, I'm not sure about that. anyone else got ideas here? --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Additional Comments From [EMAIL PROTECTED] 2007-04-27 12:39 --- (In reply to comment #5) how's about a faux function-style UI? meta AA_MULTI_2 (rules_matching(AA_*) = 2) What I like about this is that it allows for future expansion of other functionality and it is clear. And it allows using * for glob and as delimeters. The downside is the length. It would be longer to type than the % alternatives. But any syntax for this feature is light years above having an unmaintainable string of additions. (I've been creating extra empty rules meta AA_123 0 ahead of time just to avoid having to update the AA_MULTI_ rules as often.) Lexing will be slightly more complex but that shouldn't be a big concern. --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Additional Comments From [EMAIL PROTECTED] 2007-04-27 13:19 --- yeah -- re lexing, it'd be great to get a comment from Theo, who I think wrote the current rev of that lexer... ping Theo ;) --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|Undefined |3.3.0 --- Additional Comments From [EMAIL PROTECTED] 2007-04-26 04:10 --- let's consider this for 3.3.0. btw, I think it may be better to stick with a glob, I'm afraid, since regexps can be tricky to keep secure. any chance you could redo the patch against 3.2.0, using globs (again)? thanks ;) --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Additional Comments From [EMAIL PROTECTED] 2007-04-26 20:04 --- (In reply to comment #3) btw, I think it may be better to stick with a glob, I'm afraid, since regexps can be tricky to keep secure. any chance you could redo the patch against 3.2.0, using globs (again)? thanks ;) Okay. What do you suggest for syntax, since currently meta RULE FOO_*_BAR would be (FOO_) * (_BAR). Alternatives might be to use a character other than *, such as FOO_%_BAR, or some delimeter syntax such as %FOO_*_BAR%. --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (__SOMERULE_* 5)
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 03:52 --- Created an attachment (id=3887) -- (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3887action=view) Patch to implement regular expressions in meta rules --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 5258] meta SOMERULE (/__SOMERULE_/) 5
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5258 [EMAIL PROTECTED] changed: What|Removed |Added Summary|meta SOMERULE (__SOMERULE_* |meta SOMERULE | 5)|(/__SOMERULE_/) 5 --- Additional Comments From [EMAIL PROTECTED] 2007-03-26 04:06 --- Since SpamAssassin is all about regexps, I decided to implement it using regexpes rather than globbing, for more expressiveness. I'm proposing the patch attached as meta_regexp.patch, which allows the following: body AA_1 /aa/ body AA_2 /bb/ meta AA_MULTI_2 (/AA_[0-9]+/) = 2 meta AA_MULTI_3 (/AA_[0-9]+/) = 3 body AA_3 /cc/ body AA_4 /dd/ Notes: - Regular expressions have to be enclosed in (/.../), including the parentheses. This makes it easy to lex, otherwise arithmetic operators might confuse things. - Flags would have to be specified like (/(?i).../) instead of (/.../i), though I don't see any regexp flags being useful at the moment. - Regexp expansion is done at check time, so that more rules can be added after the meta test is defined. - Meta rules without (/.../) are unaffected, and this used to be undefined/illegal behavior Regards, Karl --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
