[GitHub] storm issue #2414: Fixing Java unit tests in storm-core to run under Windows...

[srdo]

Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2414
  
Sounds good.


---

[GitHub] storm issue #2307: STORM-2546: Fix storm-kafka-client spout getting stuck wh...

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2307
  
@srdo 
I found same suggestion as my 2 cents is already discussed from JIRA issue. 
Is it already addressed?


---

[GitHub] storm pull request #2412: STORM-2535: Replace test-reset-timeout (1.x)

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2412


---

[GitHub] storm pull request #2409: STORM-2796: Flux: Provide means for invoking stati...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2409#discussion_r150422396
  
--- Diff: 
flux/flux-core/src/test/resources/configs/config-methods-test.yaml ---
@@ -70,8 +70,17 @@ bolts:
 - "foo"
 - "bar"
 - "baz"
+  - id: "bolt-2"
+className: "org.apache.storm.flux.test.TestBolt"
+factory: "newInstance"
+parallelism: 1
 
-
+  - id: "bolt-3"
+className: "org.apache.storm.flux.test.TestBolt"
+factory: "newInstance"
+#factoryArgs:
--- End diff --

What if we don't comment this two lines? If it just works, I think this two 
lines should not be commented out. If it doesn't work, we may need to make it 
work, cause it is not actual tested.


---