Re: [GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements
Andrew, Thanks for bringing the private conversation back to the dev@ list so everyone has more context. That being said, I’d encourage the use of the public mailing lists as much as possible. Private conversations exclude the larger community from participating in potentially fruitful discussions. Don’t get me wrong, I applaud you doing the right thing in bringing this back to the community. I just wish it could have happened sooner. All good. We just do better next time. :) -Taylor > On Sep 26, 2018, at 5:58 PM, amontalenti wrote: > > Github user amontalenti commented on the issue: > >https://github.com/apache/storm/pull/1136 > >Was chatting with @roshannaik and @dan-blanchard today, and this PR came > up. > >Someone on Storm team may benefit from taking a look at this as part of > the performance revisions being done for Storm 2.0. As mentioned in [#428 in > streamparse](https://github.com/Parsely/streamparse/issues/428#issuecomment-380135343) > -- the community project for running Python multi-lang topologies with Storm > -- getting this merged somewhere in the Storm codebase would open up the > possibility to switch serializer from Kryo & JSON to msgpack throughout, > which would speed up multi-lang use cases considerably. This PR includes a > pure Java implementation of a msgpack serializer, as well as pointers to the > right msgpack library in the Java community; it just needs to be reviewed, > tested, and merged. > > > ---
[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements
Github user amontalenti commented on the issue: https://github.com/apache/storm/pull/1136 Was chatting with @roshannaik and @dan-blanchard today, and this PR came up. Someone on Storm team may benefit from taking a look at this as part of the performance revisions being done for Storm 2.0. As mentioned in [#428 in streamparse](https://github.com/Parsely/streamparse/issues/428#issuecomment-380135343) -- the community project for running Python multi-lang topologies with Storm -- getting this merged somewhere in the Storm codebase would open up the possibility to switch serializer from Kryo & JSON to msgpack throughout, which would speed up multi-lang use cases considerably. This PR includes a pure Java implementation of a msgpack serializer, as well as pointers to the right msgpack library in the Java community; it just needs to be reviewed, tested, and merged. ---
[GitHub] storm pull request #2851: STORM-3236 mark shutdown meters before stopping me...
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2851 STORM-3236 mark shutdown meters before stopping metric reporting You can merge this pull request into a Git repository by running: $ git pull https://github.com/agresch/storm agresch_storm-3236 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2851.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2851 commit 2b9f404cc29f1b46008cdf7ae0d2337dc905a47b Author: Aaron Gresch Date: 2018-09-26T21:37:03Z STORM-3236 mark shutdown meters before stopping metric reporting ---
Re: [VOTE] Release Apache Storm 2.0.0 (rc1)
I have patch up for WorkerToken Auto renewal fix. I think this should be added to 2.x RC. https://issues.apache.org/jira/browse/STORM-3235 https://github.com/apache/storm/pull/2850 -Kishor On Tue, Sep 25, 2018 at 8:04 PM P. Taylor Goetz wrote: > Jungtaek, can you elaborate on the issues you ran into when testing the rc > and/or file JIRAs? > > -Taylor > > > On Sep 25, 2018, at 4:02 PM, Bobby Evans wrote: > > > > Nope. I plan to start looking into them, unless someone else is already > > doing so. > > > > Thanks, > > > > Bobby > > > > On Tue, Sep 25, 2018 at 2:48 PM P. Taylor Goetz > wrote: > > > >> Thanks for the update. I will cancel the vote. > >> > >> Do the fixes you merged cover the bugs that Jungtaek pointed out? > >> > >> -Taylor > >> > >>> On Sep 25, 2018, at 1:56 PM, Bobby Evans wrote: > >>> > >>> Just FYI Taylor I just merged in 3 JIRA to the master branch and will > >>> probably merge in the fix for the UI that Govind mentioned, but all of > >> them > >>> would be okay to go into 2.0.0 as well. Since this RC looks like it is > >> not > >>> going to pass if you want to move the tag up on the master branch, that > >>> would be fine, once we have the fixes in. > >>> > >>> Thanks, > >>> > >>> Bobby > >>> > >>> On Tue, Sep 25, 2018 at 9:31 AM Govind Menon > >>> wrote: > >>> > Hi all, > > I introduced a bug with the visualization as part of the UI migration > >> with > the following fix - https://github.com/apache/storm/pull/2849. It's > >> not a > show stopper by any means and there's a workaround (specifically > hiding > system stats on the UI). I think we should include this in the RC. > > Thanks, > Govind. > > > On Mon, Sep 24, 2018 at 3:09 PM Alexandre Vermeerbergen < > avermeerber...@gmail.com> wrote: > > > Hello All, > > > > I will need a little bit time to test this new release with our 15+ > > topologies, but it's definitely worth and exiting ! > > "stay tuned" :) > > > > Best regards, > > Alexandre Vermeerbergen > > > > Le ven. 21 sept. 2018 à 20:23, P. Taylor Goetz > a > > écrit : > >> > >> This is a call to vote on releasing Apache Storm 2.0.0 (rc1) > >> > >> Full list of changes in this release: > >> > >> > > > > >> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc1/RELEASE_NOTES.html > >> > >> The tag/commit to be voted upon is v2.0.0: > >> > >> > > > > >> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=062bb2f158a66b802a3ad7bdda14fb8f70cf9b88;hb=062bb2f158a66b802a3ad7bdda14fb8f70cf9b88 > >> > >> The source archive being voted upon can be found here: > >> > >> > > > > >> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc1/apache-storm-2.0.0-src.tar.gz > >> > >> Other release files, signatures and digests can be found here: > >> > >> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc1/ > >> > >> The release artifacts are signed with the following key: > >> > >> > > > > >> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > >> > >> The Nexus staging repository for this release is: > >> > >> > >> https://repository.apache.org/content/repositories/orgapachestorm-1070 > >> > >> Please vote on releasing this package as Apache Storm 2.0.0. > >> > >> When voting, please list the actions taken to verify the release. > >> > >> This vote will be open for at least 72 hours. > >> > >> [ ] +1 Release this package as Apache Storm 2.0.0 > >> [ ] 0 No opinion > >> [ ] -1 Do not release this package because... > >> > >> Thanks to everyone who contributed to this release. > >> > >> -Taylor > > > > >> > >> > >
[GitHub] storm pull request #2850: [STORM-3235] Fix WorkerToken renewal criteria and ...
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/2850 [STORM-3235] Fix WorkerToken renewal criteria and refactor - Fix broken condition to validate if new `WorkerToken` should be added. - Refactor code out of `Nimbus` into `WorkerTokenManager` - Updated `WorkerTokenTest` to ensure `WorkerTokenManager` recognizes token ready for renewal. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishorvpatil/incubator-storm storm3235 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2850.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2850 commit 24a28eaadd17d2594eb88e098455d68aa74380a7 Author: Kishor Patil Date: 2018-09-26T11:26:54Z Fix WorkerToken renewal criteria and refactor ---
