[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418329#comment-15418329
 ] 

ASF GitHub Bot commented on STORM-2023:
---

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1610


> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414643#comment-15414643
 ] 

ASF GitHub Bot commented on STORM-2023:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1610
  
Build failure is not related to this.

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-remote-resources-plugin:1.2.1:process (default) 
on project storm-hive: Error resolving project artifact: Could not transfer 
artifact net.hydromatic:linq4j:pom:0.4 from/to sonatype-apache 
(https://repository.apache.org/releases/): Connect to repository.apache.org:443 
[repository.apache.org/207.244.88.143] failed: Connection timed out for project 
net.hydromatic:linq4j:jar:0.4 -> [Help 1]
```

I requested Travis support team to take a look at recent often time out for 
repository.apache.org. I'll update the news once I get one.


> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412774#comment-15412774
 ] 

ASF GitHub Bot commented on STORM-2023:
---

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1610#discussion_r73984110
  
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -305,12 +305,13 @@
 
 
 
-
${project.basedir}/../../external/sql/storm-sql-runtime/target
+
${project.basedir}/../../external/sql/storm-sql-runtime/target/appassembler/repo
--- End diff --

OK. Addressed.


> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411989#comment-15411989
 ] 

ASF GitHub Bot commented on STORM-2023:
---

Github user harshach commented on a diff in the pull request:

https://github.com/apache/storm/pull/1610#discussion_r73901017
  
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -305,12 +305,13 @@
 
 
 
-
${project.basedir}/../../external/sql/storm-sql-runtime/target
+
${project.basedir}/../../external/sql/storm-sql-runtime/target/appassembler/repo
--- End diff --

can we call appassembler to app-assembler. single word making it confusing.


> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411364#comment-15411364
 ] 

ASF GitHub Bot commented on STORM-2023:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1610
  
This is needed with/without STORM-2016 since calcite-core is needed at 
runtime of compiled topology. Please review this.


> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-07 Thread Jungtaek Lim (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411344#comment-15411344
 ] 

Jungtaek Lim commented on STORM-2023:
-

FYI: I'm talking with Julian Hyde to minimize the dependencies for SqlFunctions 
so that we can copy it to Storm and get rid of calcite-core dependency.
This is tracked from https://issues.apache.org/jira/browse/CALCITE-1349

> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409216#comment-15409216
 ] 

ASF GitHub Bot commented on STORM-2023:
---

GitHub user HeartSaVioR opened a pull request:

https://github.com/apache/storm/pull/1610

STORM-2023 Add calcite-core to dependency of storm-sql-runtime

* also copy (transitive) dependencies to binary distribute, as 
storm-sql-core did

It can be easily applied to 1.x-branch.
We can apply this to 1.0.x-branch but without STORM-2016 users still need 
to copy them to extlib directory which is bad.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HeartSaVioR/storm STORM-2023

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1610


commit 34d9bf2d87667669d45c5166f8827f23369124ca
Author: Jungtaek Lim 
Date:   2016-08-05T09:16:13Z

STORM-2023 Add calcite-core to dependency of storm-sql-runtime

* also copy (transitive) dependencies to binary distribute, as 
storm-sql-core did




> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-2023) Add calcite-core to dependency of storm-sql-runtime

2016-08-05 Thread Jungtaek Lim (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409210#comment-15409210
 ] 

Jungtaek Lim commented on STORM-2023:
-

It also needs to copy dependencies (sure transitive too) to dist vs assembly 
(and shade).
Since there's no clear decision made for shading non-storm-core modules, I'll 
follow storm-sql-core (copy dependencies) and revisit when we're clear on that.


> Add calcite-core to dependency of storm-sql-runtime
> ---
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-sql
>Affects Versions: 1.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is 
> for compiling sql to trident topology, and latter is for running compiled 
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite 
> so calcite-core is needed at runtime. 
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for 
> now we can add calcite-core to storm-sql-runtime so that it can be available 
> on transitive dependencies for storm-sql-runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)