[GitHub] struts pull request: WW-4346 - Nested visitor validator returns wr...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/13 WW-4346 - Nested visitor validator returns wrong full field name get correct full field name in visitor field validator You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/visitor-validator-full-field-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 2b8a805eb0794abd5c804c0bc9059e56b72c985f Author: Aleksandr Mashchenko Date: 2014-05-14T17:22:29Z get correct full field name in visitor field validator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/14 WW-4355 - Remove HTML5 deprecated attributes from templates Changed HTML5 deprecated attributes to CSS in templates. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/remove-html5-deprecations Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 1de0e779f2be090e75f613ad9c87228ac92183ab Author: Aleksandr Mashchenko Date: 2014-05-30T06:27:43Z converted align and valign to css text-align and vertical-align commit d0a6d6e895187422547d7e4a3e16d1276ba2e948 Author: Aleksandr Mashchenko Date: 2014-06-03T16:38:43Z js align and valign to style commit 8953ae3f24849b8f2db1ac3b45e846cc5f27c7a9 Author: Aleksandr Mashchenko Date: 2014-06-03T17:15:03Z bgcolor, cellpadding, cellspacing converted to css style in debug.ftl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45139719 In most cases it doesn't really matter, but yes it isn't a perfect solution. Do you think adding classes to elements and including a CSS file to `simple` theme is better? Then users can decide whether they are going to use default CSS (by using ``), style those elements with custom CSS (elements will have specific classes) or leave theme w/o any style. BTW what is `table.ftl` and where it is used? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4355 - Remove HTML5 deprecated attributes ...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-45186957 OK. Pushed that changes for future use. There are some places where align is used directly because of `align` attribute in tags. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4387 - preselect multiple options not work...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/22 WW-4387 - preselect multiple options not working in when key is not a string. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/preselect-optgroup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit 0c63de2fa91a76e989848d66afc40c4e50d18622 Author: Aleksandr Mashchenko Date: 2014-08-18T16:17:13Z WW-4387 - using original key type for contains method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4355 - Replace deprecated HTML attributes ...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/14#issuecomment-53779898 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4399 - struts2-archetype-angularjs uses ab...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/24 WW-4399 - struts2-archetype-angularjs uses absolute paths You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/angularjs-relative-paths Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit bfff8b17ea9e983e0cea76609c6b9189dbba0e7c Author: Aleksandr Mashchenko Date: 2014-08-30T12:28:59Z use relative path in templateUrl-s and in $http --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4406 - TextTagTest fails under JDK7 with d...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/27 WW-4406 - TextTagTest fails under JDK7 with different default locales for formatting and displaying You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/text-tag-test-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit 6e95cf5bf79f433f17bdb33a58787c97bf371c7e Author: Aleksandr Mashchenko Date: 2014-09-27T14:50:19Z use locale from action context --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: improved interceptor that accepts and maps JS...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/28 improved interceptor that accepts and maps JSON array You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/map-json-array Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 61cffe68feda8a4c527d085647e9567b2f689fc7 Author: Aleksandr Mashchenko Date: 2014-10-13T17:07:07Z improved interceptor that accepts and maps JSON array --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4399 - struts2-archetype-angularjs uses ab...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/24#issuecomment-68294819 @lukaszlenart Looking at the source code changes from this PR are implemented, but this request is not merged. How that happened? Anyway closing it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4399 - struts2-archetype-angularjs uses ab...
Github user aleksandr-m closed the pull request at: https://github.com/apache/struts/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4458 - Handle default (unnamed) package se...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/34 WW-4458 - Handle default (unnamed) package security check You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/WW-4458 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit 76ea79f38a5e9efbebdf9e7a966795e2deb5bc9f Author: Aleksandr Mashchenko Date: 2015-02-04T20:57:55Z Handle default (unnamed) package security check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts-site pull request: WW-4502 - File listing for dtd-s
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts-site/pull/2 WW-4502 - File listing for dtd-s You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts-site WW-4502 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts-site/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit f5ad648e7b21709ecb20431669724a7e28292fee Author: Aleksandr Mashchenko Date: 2015-05-21T19:25:53Z Create .htaccess --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Feature/remove html5 deprecations
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/38 Feature/remove html5 deprecations You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/remove-html5-deprecations Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 1de0e779f2be090e75f613ad9c87228ac92183ab Author: Aleksandr Mashchenko Date: 2014-05-30T06:27:43Z converted align and valign to css text-align and vertical-align commit d0a6d6e895187422547d7e4a3e16d1276ba2e948 Author: Aleksandr Mashchenko Date: 2014-06-03T16:38:43Z js align and valign to style commit 8953ae3f24849b8f2db1ac3b45e846cc5f27c7a9 Author: Aleksandr Mashchenko Date: 2014-06-03T17:15:03Z bgcolor, cellpadding, cellspacing converted to css style in debug.ftl commit af0f3cf1d1ba589ae7654ef9408d8f35c342b333 Author: Aleksandr Mashchenko Date: 2014-06-05T06:47:07Z replaced inline styles with classes commit a0b34806b0f700a1fd240b698c4cec474711bbd0 Author: Aleksandr Mashchenko Date: 2014-06-16T20:09:02Z removed FormButton align attribute commit 94f8be90a81d54ec40748d6a02e292a5d46a3293 Author: Aleksandr Mashchenko Date: 2014-06-16T20:12:19Z removed border from transferselects tables --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts-site pull request: WW-4502 - File listing for dtd-s
Github user aleksandr-m closed the pull request at: https://github.com/apache/struts-site/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4499 - Removed readonly attribute from rad...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/41 WW-4499 - Removed readonly attribute from radio, checkbox and checkboxlist tags. Readonly attribute is ignored in radio and checkbox inputs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/WW-4499 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit d587a687a85edb771d8d6421e45f7e699f116a94 Author: Aleksandr Mashchenko Date: 2015-05-30T15:35:25Z WW-4499 - Removed readonly attribute from radio, checkbox and checkboxlist tags. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4520 - Add prefix for CSS classes.
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/44 WW-4520 - Add prefix for CSS classes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/css-class-prefix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit cc6bf9bf18d46309fa6c405bb90232888348c477 Author: Aleksandr Mashchenko Date: 2015-06-30T15:53:36Z Added prefix for css classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [GitHub] struts pull request: WW-4520 - Add prefix for CSS classes.
Hi, Where exactly, besides CSS files, are you using S2 CSS classes that makes it so hard to migrate to a new ones? I agree with Lukasz that "struts-" isn't the best prefix and it should be changed to something else. But not sure we need yet another theme. With resolution of https://issues.apache.org/jira/browse/WW-4355 current themes are more html5 friendlier than before. best regards, Aleksandr
[GitHub] struts pull request: WW-4523 - Add more log statements to RolesInt...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/45 WW-4523 - Add more log statements to RolesInterceptor You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/roles_interceptor_logs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/45.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #45 commit 72e8b109b5b1da013678b2910fb28e20a6c1db1a Author: Aleksandr Mashchenko Date: 2015-07-10T18:40:30Z WW-4523 - Add more log statements to RolesInterceptor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4523 - Add more log statements to RolesInt...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/45#issuecomment-120607949 You're right. In that case there is no need for check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4527 - Show property class in debug tag
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/46 WW-4527 - Show property class in debug tag You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/debug_tag_class Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 commit f85c60ea477530872f7b0ab2d16f16a375cd4ab2 Author: Aleksandr Mashchenko Date: 2015-07-14T19:24:08Z WW-4527 - Show property class in debug tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4523 - Add more log statements to RolesInt...
Github user aleksandr-m closed the pull request at: https://github.com/apache/struts/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4539 Support list of tokens to prevent CSR...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/49#issuecomment-139461467 Do we really need a list of tokens? Currently if you use different names for tokens they all will be [stored into session](https://github.com/apache/struts/blob/master/core/src/main/java/org/apache/struts2/util/TokenHelper.java#L91). Does using token tag with a name solve you problem? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: Upgrade tiles plugin
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/59#issuecomment-160195199 Tested with own app and it is running fine. Looking forward to see the same approach with `StrutsTilesContainerFactory` in tiles3 plugin. BTW what is accessible through `OGNL:` expression? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4584: Upgrade tiles plugin
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171035814 Same thing here. Getting `NoSuchDefinitionException` exception in my app when trying to use tiles result. Note: there is still reference to tiles3-plugin in bom pom.xml. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4584: Upgrade tiles plugin
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/73#issuecomment-171590254 :+1: It works. Thank you for your great work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/75
WW-4590 - Allow to use multiple names in result
Allow to use multiple values in `result` tag `name` attribute and in
`Result` annotation `name`.
So this typical configuration:
```
success.jsp
input-form.jsp
input-form.jsp
```
Can be shorten to that:
```
success.jsp
input-form.jsp
```
And this annotations:
```
@Action(results = {
@Result(name="error", location="input-form.jsp"),
@Result(name="input", location="input-form.jsp"),
@Result(name="success", location="success.jsp")
})
```
To that:
```
@Action(results = {
@Result(name="error, input", location="input-form.jsp"),
@Result(name="success", location="success.jsp")
})
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleksandr-m/struts
feature/multiple_result_names
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
commit 087cf610abcd262980a41c30a2f9360aa3f416e1
Author: Aleksandr Mashchenko
Date: 2016-01-18T19:23:46Z
WW-4590 - Allow to use multiple names in result
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50079358
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResultType(String className,
Location loc) {
}
params.putAll(resultParams);
-ResultConfig resultConfig = new
ResultConfig.Builder(resultName, resultClass)
-.addParams(params)
-.location(DomHelper.getLocationObject(element))
-.build();
-results.put(resultConfig.getName(), resultConfig);
+Set resultNamesSet;
+if (",".equals(resultName.trim())) {
+resultNamesSet = new HashSet<>(1);
+resultNamesSet.add(resultName);
--- End diff --
Currently it is allowed to have a result name as a `,`. And
`TextParseUtil.commaDelimitedStringToSet` will produce empty set in that case.
Note that it is trimmed so the result name can be something like
" ," also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50153311
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResultType(String className,
Location loc) {
}
params.putAll(resultParams);
-ResultConfig resultConfig = new
ResultConfig.Builder(resultName, resultClass)
-.addParams(params)
-.location(DomHelper.getLocationObject(element))
-.build();
-results.put(resultConfig.getName(), resultConfig);
+Set resultNamesSet;
+if (",".equals(resultName.trim())) {
+resultNamesSet = new HashSet<>(1);
+resultNamesSet.add(resultName);
--- End diff --
You mean like this?
Set resultNamesSet =
TextParseUtil.commaDelimitedStringToSet(resultName);
if (resultNamesSet.isEmpty()) {
resultNamesSet.add(resultName);
}
Yeah, looks a bit cleaner to me. I'll change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-172947410 @swiftelan I was thinking about that too, BUT: * It will break backward compatibility * I kind of like that annotation attributes looks the same as in xml configuration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-172982203 @swiftelan So you are proposing to change only type? The name of the attribute will stay the same i.e `name`, right? There is still some chance that something going to break, note that `ResultInfo` depends on `Result`'s `name`. But it is better than changing the name. @lukaszlenart WDYT about changing `Result`'s `name` to `String[] name() default com.opensymphony.xwork2.Action.SUCCESS;` and probably removing `public ResultInfo(Result, PackageConfig, String, Class, Map)` constructor? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50173826
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResultType(String className,
Location loc) {
}
params.putAll(resultParams);
-ResultConfig resultConfig = new
ResultConfig.Builder(resultName, resultClass)
-.addParams(params)
-.location(DomHelper.getLocationObject(element))
-.build();
-results.put(resultConfig.getName(), resultConfig);
+Set resultNamesSet;
+if (",".equals(resultName.trim())) {
+resultNamesSet = new HashSet<>(1);
+resultNamesSet.add(resultName);
--- End diff --
It looks a bit odd, agree. :) But it is supported right now and it is
better than mapping `,` to `success` or not creating result at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/75#issuecomment-173253337 Done. We should add notice in the release notes about breaking change in `ResultInfo` / `@Result` for those who use `Result.name()` or extend `ResultInfo`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4622 [struts2-tiles-plugin] [StrutsWildcar...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/93#issuecomment-204510571 Resources still need to be loaded, NPE check is not enough. BTW recently portlet-webapp test fails in my environment too (Oracle JDK). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4622 [struts2-tiles-plugin] [StrutsWildcar...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/93#issuecomment-205042373 This alone is not enough to solve [WW-4622](https://issues.apache.org/jira/browse/WW-4622). The `ResourceFinder` won't handle that case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4622 [struts2-tiles-plugin] [StrutsWildcar...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/93#issuecomment-205349984 And this will break working stuff also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/94#issuecomment-205352470 Not working for 2.3.x and doubt it will work in 2.5. Take a look at `ResourceFinder`. Please try to write a unit tests along with code changes, and if it is somehow complicated then at least test things manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/94#issuecomment-205429031 In 2.3.28 `StrutsWildcardServletTilesApplicationContext` produces something like that: > org.apache.struts2.tiles.StrutsTilesListener - Starting Struts Tiles 2 integration ... > org.apache.struts2.tiles.StrutsTilesInitializer - Initializing Tiles wildcard support ... > org.apache.struts2.tiles.StrutsWildcardServletTilesApplicationContext: > > url= file:/path/to/webapps/app/img/ > url= file:/path/to/webapps/app/js/ > url= file:/path/to/webapps/app/META-INF/ > url= file:/path/to/webapps/app/index.jsp > url= file:/path/to/webapps/app/WEB-INF/ > url= file:/path/to/webapps/app/css/ > url= file:/path/to/webapps/app/favicon.ico And `ResourceFinder#getResourcesMap` won't look into sub-folders, meaning that `**/tiles` pattern is irrelevant in such case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219809968 Why not just add some CSS class to this table cell? Then end-users can style it as they want and align parameter will not be needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219820070 Issue is about Velocity tags, not FreeMarker. Are we still supporting Velocity tags? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219823160 How the Velocity templating is working? The only Velocity templates I see are in the [archive](https://github.com/apache/struts/tree/master/core/src/main/resources/template/archive). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219824169 Yep, the aforementioned commit misses css class for that cell in the `controlheader.ftl`. It should be the same way as for the buttons. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219829978 @lukaszlenart Ahh ok. Thanks for clarifying that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-220522532
@victorsosa I mean something like `` in
controlheader.ftl and `.tdInput {text-align:left;}` in styles.css. <-- This is
for 2.5.
And if alignment doesn't work in 2.3 and your solution fixes it, then this
PR should target `support-2-3` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-220795005 @victorsosa You see, this commit already *broke* backward compatibility, but it was incomplete in the way it didn't introduce css class for the input cell. It is 2.5 so some breaking changes are expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221056549
I would prefer to follow html5 and drop align attribute completely from S2
tags, BUT @victorsosa can you at least add some css class to input cell along
with your solution.
Something like:
```
if align then class="tdInput align-${parameters.align?html}" else
class="tdInput"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221326208
@victorsosa IMO it would be great. BUT if we really really want it to be
backward compatible then we can do both. Add a class for future **and** use
align attribute with `class="align-${parameters.align?html}"` like you propose
in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4636 File upload error message always in d...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/97#issuecomment-221628543 First of all, there is [some chance](https://github.com/apache/struts/blob/master/core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java#L71) that `defaultLocale` isn't set to English. Can we get locale from the action context instead of request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221976394 Looks fine. Good job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #105: [WW-4620] Improve XWorkListPropertyAccessor to aga...
Github user aleksandr-m commented on a diff in the pull request: https://github.com/apache/struts/pull/105#discussion_r68796281 --- Diff: core/src/main/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessor.java --- @@ -36,6 +36,7 @@ * this class will create the necessary blank JavaBeans. * * @author Gabriel Zimmerman + * @author Yanming Zhou --- End diff -- Please remove author tag. In general you [should refrain from doing so](http://struts.apache.org/releases.html#clarifications). Why? [Because](http://directory.apache.org/apacheds/coding-standards.html#classinterface-headers). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #113: WW-4636 - File upload error message always in defa...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/113 WW-4636 - File upload error message always in default language Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/WW-4636 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #113 commit 835cc7cd096ba274ffd71e54115dbefc63cadffd Author: Aleksandr Mashchenko Date: 2016-10-15T12:25:14Z WW-4636 - File upload error message always in default language --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #113: WW-4636 - File upload error message always in default lan...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/113 Yep, we can close #97. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #97: WW-4636 File upload error message always in default langua...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/97 @victorsosa, @lukaszlenart Please close this one. WW-4636 is fixed in https://github.com/apache/struts/pull/113. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/118 @yasserzamani *in case of when action are beans inside user's object factory, we do not have any way except force user to change config and specify real class* Can you elaborate? It really looks weird to specify both bean and the class name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/118 Let's break it down: **chain** First of all using `chain` is discouraged. Proxying the action itself is not the best practice too. If the only viable solution to know target class is to declare a real class of the bean then it should be done in the chain interceptor not in the action configuration. **json result** What is the problem with generating proxy data into json? What if this is what is really needed? **excluding `ActionSupport`** If `ActionSupport` is excluded then its methods cannot be used in the JSP (e.g. `getText`). In case of `chain` action errors / messages won't be moved to the next action. Etc. **overall** *someone may successfully change proxy information of the action by an HTTP request with named parameters* Are you sure? Can you provide some example? *there is no any clean way to check if it's a proxy and unwrap it to target class* How knowing the name of the real class helps in that case? What are you going to do with it? If it is spring proxy then there are helper methods to get target class from the instance (e.g. `AopUtils`). If there is no *clean* way to do this in the Struts core utility class then it can be delegated to current object factory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/124 Do we need custom annotation utility at all? Can't we just use existing libraries e.g. Apache Commons [MethodUtils](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/reflect/MethodUtils.html)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #133: WW-4105 Considers config time class in actions chain
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/133 I'm still against adding `bean` attribute to action configuration. It is not intuitive. Chain configuration options belong to `chain` interceptor, json to `json` result, etc. In fact `json` result already allows to control what is serialized. About security, I think we can and **should** do something better than that. I.e. automatically detect proxied class and disallow to change it internals. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #133: WW-4105 Considers config time class in actions chain
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/133 You're mixing two very different topics together, security and `chain` configuration. > But I think using attribute class for both class name and bean name is not intuitive too. What do you mean by that? There is no *bean* name. > But by continuing includes/excludes approach, user has to manually concern about run time of the action. But it the same or maybe even much more tedious manual work for defining `bean` in **every** action you want to *protect*. > I've done #118 before. It does not have fewer changes that adding bean attribute. It is not about the amount of changes, it is about separation of concerns. Configuration for `chain` interceptor belongs to `chain` configuration. > Yes, but so we will have to add dependency of any possible java proxy creators like Spring, cglib or etc to S2 core. Not necessarily. For example, it can be just delegated to the object factory at hand. Another possibility is to search for `getTarget` methods. Yet another is to compare action configuration `class` with the current instance `toString` / `getClass().toString`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #133: WW-4105 Considers config time class in actions chain
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/133 > Not every. Remember that issue that you've submitted to security list? All actions are affected. With this proposal `bean` attribute must be added to every action configuration in the application. > No, I think about S2 borders. I'm trying to discuss that S2 should or should not know the config time class of the action and then do not operate outside of that border. Mostly it is job of the application developer to protect sensitive data (e.g. not writing setter for `secretToken` property :), excluding some parameters, etc.). The real problem is that for proxied stuff it is somehow obscure. > As I mentioned, when user uses class attribute as a bean name, S2 cannot know the action configuration class in any clean way. Even if it is not a spring bean name then it can still be affected. They are good enough to handle most of the cases and they can be combined to achieve better results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #133: WW-4105 Considers config time class in actions chain
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/133 Maybe I'm doing something wrong but in my app `method.getDeclaringClass()` return proxied class as well. :( We can use something ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #133: WW-4105 Considers config time class in actions chain
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/133
Maybe I'm doing something wrong but in my app `method.getDeclaringClass()`
returns proxied class as well. :(
We can use something like below. Basically same thing that `AopUtil` is
doing but w/o spring classes.
```
private Class getTarget(Object candidate) {
Class result = null;
try {
Method method = candidate.getClass().getMethod("getTargetClass");
Object obj = method.invoke(candidate);
if (result instanceof Class) {
result = (Class) obj;
}
} catch (Exception e) {
}
if (result == null) {
if (candidate.getClass().getName().contains("$$")) {
result = candidate.getClass().getSuperclass();
} else {
result = candidate.getClass();
}
}
return result;
}
```
And to replace `instanceof`.
```
private boolean implementsInterfeace(Class clazz, final String
interfaceName) {
List> list =
org.apache.commons.lang3.ClassUtils.getAllInterfaces(clazz);
if (list != null) {
for (Class cl : list) {
if (interfaceName.equals(cl.getName())) {
return true;
}
}
}
return false;
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #71: patch ww-3266 getFieldValue() method of ValueStackDataSour...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/71 @DenizR https://issues.apache.org/jira/browse/WW/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #135: WW-4105 Unwraps Spring proxy in actions chain
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109147
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.opensymphony.xwork2.spring;
+
+import com.opensymphony.xwork2.util.ClassLoaderUtil;
+import org.apache.commons.lang3.reflect.MethodUtils;
+
+import java.lang.reflect.Proxy;
+
+/**
+ * SpringUtils
+ *
+ * Various utility methods dealing with spring framework
+ *
+ *
+ */
+public class SpringUtils {
--- End diff --
Maybe name it `ProxyUtil` or something like that. This class can be used to
deal with known proxies and not only spring proxies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #135: WW-4105 Unwraps Spring proxy in actions chain
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109235
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.opensymphony.xwork2.spring;
+
+import com.opensymphony.xwork2.util.ClassLoaderUtil;
+import org.apache.commons.lang3.reflect.MethodUtils;
+
+import java.lang.reflect.Proxy;
+
+/**
+ * SpringUtils
+ *
+ * Various utility methods dealing with spring framework
+ *
+ *
+ */
+public class SpringUtils {
+/**
+ * Get the ultimate target object of the supplied {@code
candidate}
+ * object, unwrapping not only a top-level proxy but also any number of
+ * nested proxies.
+ * If the supplied {@code candidate} is a Spring proxy, the
ultimate target of all
+ * nested proxies will be returned; otherwise, the {@code candidate}
+ * will be returned as is.
+ * @param candidate the instance to check (potentially a Spring AOP
proxy;
+ * never {@code null})
+ * @return the target object or the {@code candidate} (never {@code
null})
+ * @throws IllegalStateException if an error occurs while unwrapping a
proxy
+ */
+public static T getUltimateTargetObject(Object candidate) {
+try {
+if (isAopProxy(candidate) &&
+implementsInterface(candidate.getClass(),
"org.springframework.aop.framework.Advised")) {
+Object targetSource = MethodUtils.invokeMethod(candidate,
"getTargetSource");
--- End diff --
What is `targetSource` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #135: WW-4105 Unwraps Spring proxy in actions chain
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109357
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.opensymphony.xwork2.spring;
+
+import com.opensymphony.xwork2.util.ClassLoaderUtil;
+import org.apache.commons.lang3.reflect.MethodUtils;
+
+import java.lang.reflect.Proxy;
+
+/**
+ * SpringUtils
+ *
+ * Various utility methods dealing with spring framework
+ *
+ *
+ */
+public class SpringUtils {
+/**
+ * Get the ultimate target object of the supplied {@code
candidate}
+ * object, unwrapping not only a top-level proxy but also any number of
+ * nested proxies.
+ * If the supplied {@code candidate} is a Spring proxy, the
ultimate target of all
+ * nested proxies will be returned; otherwise, the {@code candidate}
+ * will be returned as is.
+ * @param candidate the instance to check (potentially a Spring AOP
proxy;
+ * never {@code null})
+ * @return the target object or the {@code candidate} (never {@code
null})
+ * @throws IllegalStateException if an error occurs while unwrapping a
proxy
+ */
+public static T getUltimateTargetObject(Object candidate) {
+try {
+if (isAopProxy(candidate) &&
+implementsInterface(candidate.getClass(),
"org.springframework.aop.framework.Advised")) {
+Object targetSource = MethodUtils.invokeMethod(candidate,
"getTargetSource");
+Object target = MethodUtils.invokeMethod(targetSource,
"getTarget");
+return getUltimateTargetObject(target);
+}
+}
+catch (Throwable ex) {
+throw new IllegalStateException("Failed to unwrap proxied
object", ex);
+}
+return (T) candidate;
+}
+
+/**
+ * Check whether the given object is a Spring proxy.
+ * @param object the object to check
+ */
+public static boolean isAopProxy(Object object) {
+Class clazz = object.getClass();
+return (implementsInterface(clazz,
"org.springframework.aop.SpringProxy") &&
--- End diff --
Extract strings to constants.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #135: WW-4105 Unwraps Spring proxy in actions chain
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114109604
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.opensymphony.xwork2.spring;
+
+import com.opensymphony.xwork2.util.ClassLoaderUtil;
+import org.apache.commons.lang3.reflect.MethodUtils;
+
+import java.lang.reflect.Proxy;
+
+/**
+ * SpringUtils
+ *
+ * Various utility methods dealing with spring framework
+ *
+ *
+ */
+public class SpringUtils {
--- End diff --
Another maybe. This can be turned to injectable bean so it can be easily
overridable if needed. Wdyt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #135: WW-4105 Unwraps Spring proxy in actions chain
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114148402
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.opensymphony.xwork2.spring;
+
+import com.opensymphony.xwork2.util.ClassLoaderUtil;
+import org.apache.commons.lang3.reflect.MethodUtils;
+
+import java.lang.reflect.Proxy;
+
+/**
+ * SpringUtils
+ *
+ * Various utility methods dealing with spring framework
+ *
+ *
+ */
+public class SpringUtils {
+/**
+ * Get the ultimate target object of the supplied {@code
candidate}
+ * object, unwrapping not only a top-level proxy but also any number of
+ * nested proxies.
+ * If the supplied {@code candidate} is a Spring proxy, the
ultimate target of all
+ * nested proxies will be returned; otherwise, the {@code candidate}
+ * will be returned as is.
+ * @param candidate the instance to check (potentially a Spring AOP
proxy;
+ * never {@code null})
+ * @return the target object or the {@code candidate} (never {@code
null})
+ * @throws IllegalStateException if an error occurs while unwrapping a
proxy
+ */
+public static T getUltimateTargetObject(Object candidate) {
+try {
+if (isAopProxy(candidate) &&
+implementsInterface(candidate.getClass(),
"org.springframework.aop.framework.Advised")) {
+Object targetSource = MethodUtils.invokeMethod(candidate,
"getTargetSource");
--- End diff --
Hmm... Never used `AopTestUtils`. But `Advised` extends `TargetClassAware`.
Can `getTargetClass` just be invoked instead of two method calls? See
[`AopUtils`](https://github.com/spring-projects/spring-framework/blob/master/spring-aop/src/main/java/org/springframework/aop/support/AopUtils.java).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #135: WW-4105 Unwraps Spring proxy in actions chain
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r114148973
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.opensymphony.xwork2.spring;
+
+import com.opensymphony.xwork2.util.ClassLoaderUtil;
+import org.apache.commons.lang3.reflect.MethodUtils;
+
+import java.lang.reflect.Proxy;
+
+/**
+ * SpringUtils
+ *
+ * Various utility methods dealing with spring framework
+ *
+ *
+ */
+public class SpringUtils {
--- End diff --
To support other possible proxies. Or in case something changes in
spring-aop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #136: WW-4793 only add JBossFileManager when supported
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/136#discussion_r114149826
--- Diff:
core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java ---
@@ -210,4 +187,33 @@ private void addIfAbsent(List urls, URL fileUrl) {
}
}
+public static class JBossFileManagerSupportUtil {
--- End diff --
Why inner class? Why not just static methods in `JBossFileManager`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #138: WW-3171 WW-3650 WW-4581: Locale aware converters
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/138 Will this break apps with locales which are using different decimal separator? E.g. in db `123.456` with locale which uses `,` as a decimal separator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #138: WW-3171 WW-3650 WW-4581: Locale aware converters
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/138 What about `Float` and `float`? I remember writing custom converter for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #135: WW-4105 Unwraps Spring proxy in actions chain
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/135 @lukaszlenart I think it is ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #125: Immutable context
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/125 Spoted same `#context['com.opensymphony.xwork2.dispatcher.HttpServletRequest']` expression [here](https://stackoverflow.com/q/44291034/1700321). @yasserzamani What do you use it for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #142: Blocks ognl access to class members of Spring proxy
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/142 What about performance? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #142: Blocks ognl access to class members of Spring proxy
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/142 But `isAccessible` is called quite often even for rather simple actions. Also it would be nice to have some property which allows to access proxy members. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #142: WW-4805 Blocks ognl access to class members of Spring pro...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/142 @lukaszlenart Sounds good. Still, it would be nice to allow to turn this checking completely off even when spring plugin is presented. The issue then can be avoided with addition of a simple pattern which should be faster. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #142: WW-4805 Blocks ognl access to class members of Spring pro...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/142 @lukaszlenart > The simplest solution is to add a flag, a constant that by default should turn off this check, but the Spring Plugin should have this flag set on to enable additional scanning. I'll create a PR implementing this in a few days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #146: add constant to control proxy member access
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/146 add constant to control proxy member access See discussion in #142. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/disallow_proxy_members Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/146.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #146 commit 0d6442bab5b44d93c4c2e63c5335f0a331333b92 Author: Aleksandr Mashchenko Date: 2017-06-21T21:58:41Z add constant to control proxy member access --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #153: WW-4827 Not fully initialized ObjectFactory tries ...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/153 WW-4827 Not fully initialized ObjectFactory tries to create beans Inject `Container` in constructor of the `ObjectFactory`. Can someone test `cdi`, `osgi` and `plexus` plugins. Better ideas how to fix the issue are welcome. :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/container_injection Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #153 commit 6f91d0776a545c911ca4f2875ed9976614711ef9 Author: Aleksandr Mashchenko Date: 2017-07-27T19:22:33Z Inject Container in constructor of the ObjectFactory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
Nope, #155 doesn't seem have any effect.
Add following files to project, run under *nix, execute some action which
lead to the JSP, `localizedTextProvider` should not be `null` in system outs.
xwork-conversion.properties;
java.util.Date=com.DateConverter
JSP:
DateConverter:
```
public class DateConverter extends StrutsTypeConverter {
private LocalizedTextProvider localizedTextProvider;
@Inject
public void setLocalizedTextProvider(LocalizedTextProvider
localizedTextProvider) {
this.localizedTextProvider = localizedTextProvider;
}
@Override
public Object convertFromString(Map context, String[] values, Class
toClass) {
System.out.println("DateConverter.convertFromString()
localizedTextProvider=" +
localizedTextProvider);
return null;
}
@Override
public String convertToString(Map context, Object obj) {
System.out.println("DateConverter.convertToString()
localizedTextProvider=" +
localizedTextProvider);
return "";
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/153
Ubuntu, oracle jdk8.
If following code prints `setContainer` before other setters (especially
before `setInterceptorFactory`) it will work. On Ubuntu using oracle jdk8
`setContainer` is printed way below other setters and injection fails.
Method[] methods = ObjectFactory.class.getDeclaredMethods();
for (Method m : methods) {
System.out.println(m);
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 It isn't about `XWorkConverter` per se. In #155 the injection of `ConversionPropertiesProcessor` still happens and `TypeConverterCreator` is injected next and `ObjectFactory#buildBean` is called and `container` is `null` in `ObjectFactory`. BTW `ObjectFactory.class.getDeclaredMethods()` on Ubuntu, openJDK 7 prints `setContainer` as the last method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 With the new code in #155 the custom type converter isn't initialized at all. :( Call trace of previous code in #155 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 Sure. No problem. Test project - https://github.com/aleksandr-m/struts2-objectfactory-container/ This commit adds custom date converter - https://github.com/aleksandr-m/struts2-objectfactory-container/commit/49406c1d8e816acd1f227d55db6729cd92a5de99. This commit adds local copy of `ContainerImpl` in order to reproduce the issue in various environments - https://github.com/aleksandr-m/struts2-objectfactory-container/commit/e3fb324c56c8517491ea336f8682601ae33a5f0b --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 @yasserzamani Looks like a hack :) I would rather leave as it is, then to introduce that. If container is needed then it **should** be injected in the constructor. Take a look at spring object factory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request #163: WW-4843 DefaultUrlHelper().buildUrl() not outputti...
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/163 WW-4843 DefaultUrlHelper().buildUrl() not outputting port when used as parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/WW-4843 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #163 commit 0b9e68ed16341c585d48d301ceacfb9e74438552 Author: Aleksandr Mashchenko Date: 2017-08-23T20:05:29Z WW-4843 DefaultUrlHelper().buildUrl() not outputting port when used as parameter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
