Re: svn commit: r1864256 - /subversion/site/tools/upcoming.py

[Greg Stein]

On Tue, Aug 6, 2019 at 9:41 AM Daniel Shahaf  wrote:

> Greg Stein wrote on Tue, 06 Aug 2019 07:58 +00:00:
> > On Fri, Aug 2, 2019 at 12:53 PM  wrote:
> > >...
> > > +++ subversion/site/tools/upcoming.py Fri Aug 2 17:53:38 2019
> > >...
> > > +def get_reference_version():
> > >  + "Return the version to use as the oldest end of the 'svn log'
> output to generate."
> > >  + def _is_working_copy():
> > >  + return os.path.exists('subversion/include/svn_version.h')
> > >  + if _is_working_copy():
> >
> > Why a local func instead of just using os.path.exists() in the 'if'
> > statement? If for doc purposes, then I think a comment would suffice.
>
> Yes, for doc purposes.  How would a comment be better than a one-line
> helper function?
>

For me, it was the complexity. "Oh! A local function. What is this gonna be
used for? ... oh." Local functions are a pretty high-level Python Fu. It
kinda stood out to me.

It is a rather complicated commentary. I'd think a simpler approach:
# are we looking at a local working copy?

Cheers,
-g

Re: patch on files with svn:keywords ends up with 0600 perms

[Doug Robinson]

Stefan:

Thank you!

Cheers!

Doug

On Mon, Aug 5, 2019 at 10:38 AM Stefan Sperling  wrote:

> On Mon, Aug 05, 2019 at 08:40:48AM -0400, Doug Robinson wrote:
> > Gentle reminder.
> >
> > On Fri, Jul 26, 2019 at 5:43 PM Doug Robinson <
> doug.robin...@wandisco.com>
> > wrote:
>
> Hi Doug,
>
> The problem should be fixed with this commit:
> https://svn.apache.org/r1864440
> It's a simple matter of creating temporary files in the working copy's temp
> directory instead of the system-wide one.
>
> Regards,
> Stefan
>
> > > Committers, et. al.:
> > >
> > > This was just sent to us by a customer.  We've verified on at 1.10.4.
> I
> > > checked in JIRA and didn't find a matching bug.  Should I create a new
> JIRA?
> > > 
> > >
> > > $ svnadmin create test_repo
> > >
> > > $ svn co file:///tmp/test_repo accnt
> > > Checked out revision 0.
> > >
> > > $ cd accnt/
> > > $ touch a.c b.c
> > > $ svn add a.c b.c
> > > A a.c
> > > A b.c
> > >
> > > # Adding property only on a.c
> > > $ svn propset svn:keywords "Id Revision Date URL Author Header" a.c
> > > property 'svn:keywords' set on 'a.c'
> > > $ ls -l
> > > total 0
> > > -rw-r--r-- 1 accnt qa-others 0 Jul 25 13:47 a.c
> > > -rw-r--r-- 1 accnt qa-others 0 Jul 25 13:47 b.c
> > > $ svn commit -m "test commit"
> > > Adding a.c
> > > Adding b.c
> > > Transmitting file data ..done
> > > Committing transaction...
> > > Committed revision 1.
> > > $ svn patch /tmp/patch
> > > U a.c
> > > > applied hunk @@ -0,0 +1,1 @@ with offset 0
> > > U b.c
> > > > applied hunk @@ -0,0 +1,1 @@ with offset 0
> > >
> > > # After applying patch the permission on the file with property
> > > svn:keywords has changed.
> > > $ ls -l
> > > total 8
> > > -rw--- 1 accnt qa-others 11 Jul 25 13:49 a.c
> > > -rw-r--r-- 1 accnt qa-others 28 Jul 25 13:49 b.c
> > >
> > > $ umask
> > > 0022
> > >
> > > # The patch applied:
> > > $ cat /tmp/patch
> > > Index: a.c
> > > ===
> > > --- a.c (revision 1)
> > > +++ a.c (working copy)
> > > @@ -0,0 +1 @@
> > > +test patch
> > > Index: b.c
> > > ===
> > > --- b.c (revision 1)
> > > +++ b.c (working copy)
> > > @@ -0,0 +1 @@
> > > +test patch without keywords
> > >
> > > --
> > > *DOUGLAS B ROBINSON* SENIOR PRODUCT MANAGER
> > >
> > > T +1 925 396 1125
> > > *E* doug.robin...@wandisco.com
> > >
> >
> >
> > --
> > *DOUGLAS B ROBINSON* SENIOR PRODUCT MANAGER
> >
> > T +1 925 396 1125
> > *E* doug.robin...@wandisco.com
> >
> > --
> >
> >
> > * *
> >
> > **The LIVE DATA Company
> > *Find out more
> > *wandisco.com *
> >
> >
> >
> >
> > 
> > *
> >
> >
> > THIS MESSAGE
> > AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY AND MAY BE PRIVILEGED
> >
> > If
> > this message was misdirected, WANdisco, Inc. and its subsidiaries,
> > ("WANdisco") does not waive any confidentiality or privilege. If you are
> > not the intended recipient, please notify us immediately and destroy the
> > message without disclosing its contents to anyone. Any distribution, use
> or
> > copying of this email or the information it contains by other than an
> > intended recipient is unauthorized. The views and opinions expressed in
> > this email message are the author's own and may not reflect the views
> and
> > opinions of WANdisco, unless the author is authorized by WANdisco to
> > express such views or opinions on its behalf. All email sent to or from
> > this address is subject to electronic storage and review by WANdisco.
> > Although WANdisco operates anti-virus programs, it does not accept
> > responsibility for any damage whatsoever caused by viruses being passed.
>


-- 
*DOUGLAS B ROBINSON* SENIOR PRODUCT MANAGER

T +1 925 396 1125
*E* doug.robin...@wandisco.com

-- 


* *

**The LIVE DATA Company
*Find out more 
*wandisco.com *



 

*


THIS MESSAGE 
AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY AND MAY BE PRIVILEGED

If 
this message was misdirected, WANdisco, Inc. and its subsidiaries, 
("WANdisco") does not waive any confidentiality or privilege. If you are 
not the intended recipient, please notify us immediately and destroy the 
message without disclosing its contents to anyone. Any distribution, use or 
copying of this email or the information it contains by other than an 
intended recipient is unauthorized. The views and opinions expressed in 
this email message are the author's own and may not reflect the views and 
opinions of WANdisco, unless the author is authorized by WANdisco to 
express such views or opinions on its behalf. All email sent to or from 
this address is subject to electronic storage and review by WANdisco. 
Although WANdisco operates anti-virus programs, it does not accept 
responsibility for any damage whatsoever caused by 

Advertise latest version number in the sidebar?

[Daniel Shahaf]

I wonder if we should have the sidebar indicate the latest releases' version
numbers.  I'm thinking of something along the lines of this:

[[[
Index: site-nav.html
===
--- site-nav.html   (revision 1864399)
+++ site-nav.html   (working copy)
@@ -43,6 +43,7 @@
 
   
 
+Latest releases: 1.10.4, 1.12.2
  
 
 
]]]

(Not going to commit that; just putting it here to illustrate what I have in 
mind)

Re: svn commit: r1864256 - /subversion/site/tools/upcoming.py

[Daniel Shahaf]

Greg Stein wrote on Tue, 06 Aug 2019 07:58 +00:00:
> On Fri, Aug 2, 2019 at 12:53 PM  wrote:
> >...
> > +++ subversion/site/tools/upcoming.py Fri Aug 2 17:53:38 2019
> >... 
> > +def get_reference_version():
> >  + "Return the version to use as the oldest end of the 'svn log' output to 
> > generate."
> >  + def _is_working_copy():
> >  + return os.path.exists('subversion/include/svn_version.h')
> >  + if _is_working_copy():
> 
> Why a local func instead of just using os.path.exists() in the 'if' 
> statement? If for doc purposes, then I think a comment would suffice.

Yes, for doc purposes.  How would a comment be better than a one-line
helper function?

Cheers,

Daniel

Re: patch on files with svn:keywords ends up with 0600 perms

[Daniel Shahaf]

Stefan Sperling wrote on Mon, 05 Aug 2019 14:38 +00:00:
> The problem should be fixed with this commit: https://svn.apache.org/r1864440

/me solicits patches adding a regression test

Re: officially retire 1.9?

[Branko Čibej]

On 05.08.2019 20:27, Stefan Sperling wrote:
> Subversion 1.9.0 is 4 years old today (release on August 5 2015).
> http://subversion.apache.org/roadmap.html#release-planning says that
> each LTS release is supported for 4 years.
>
> Julian said on IRC that perhaps we decided to support 2 LTS releases
> for either 4 years or until another LTS release appears.
> Which means 1.9 would still be supported until 1.14 is released.
>
> But do we really want to continue supporting 1.9?

You probably noticed that this question arose on users@. I promised
we'll announce what we decide.

For the record, I agree we can stop supporting 1.9.

-- Brane

Re: svn commit: r1864256 - /subversion/site/tools/upcoming.py

[Greg Stein]

On Fri, Aug 2, 2019 at 12:53 PM  wrote:
>...

> +++ subversion/site/tools/upcoming.py Fri Aug  2 17:53:38 2019
>
>...

> +def get_reference_version():
> +"Return the version to use as the oldest end of the 'svn log' output
> to generate."
> +def _is_working_copy():
> +return os.path.exists('subversion/include/svn_version.h')
> +if _is_working_copy():
>

Why a local func instead of just using os.path.exists() in the 'if'
statement? If for doc purposes, then I think a comment would suffice.

Cheers,
-g