date:20170928

[GitHub] mistercrunch commented on issue #3546: A bug in table view sorting in version 0.20.0?

2017-09-28 Thread git

mistercrunch commented on issue #3546: A bug in table view sorting in version 
0.20.0? 
URL: 
https://github.com/apache/incubator-superset/issues/3546#issuecomment-333037879
 
 
   Looks like something around `0` or NULL getting processed as epoch 0.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3548: add time granularity to redshift

2017-09-28 Thread git

mistercrunch commented on issue #3548: add time granularity to redshift
URL: 
https://github.com/apache/incubator-superset/pull/3548#issuecomment-333036971
 
 
   Did your patch here fix the "bug"? What are the symptoms, is the dropdown 
empty? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rpwils opened a new issue #3549: forward to original url after loggin in

2017-09-28 Thread git

rpwils opened a new issue #3549: forward to original url after loggin in
URL: https://github.com/apache/incubator-superset/issues/3549
 
 
currently when a user who is not singed in who clicks a link to a dashboard 
is then redirected to login. After they login it goes to the list of dashboards 
vs the original dashboard link. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3280: [dashboard] add link to export CSV from dashboard

2017-09-28 Thread git

mistercrunch commented on issue #3280: [dashboard] add link to export CSV from 
dashboard
URL: 
https://github.com/apache/incubator-superset/pull/3280#issuecomment-333002618
 
 
   @annusri did you restart your web server?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Unable to reflect css changes from custom less files on Superset UI

2017-09-28 Thread Maxime Beauchemin

Are you sure you did `pip install -e .` ? You can check in ipython that
you're actually running off of the dev env folder (as opposed to
site-packages). To do this (when troubleshooting other people's dev env) I
would run, in ipython `import superset` and then `superset?` which will
print the location of the package. This should be your dev environment
where the files you are modifying are located.

You can also `pip uninstall superset` until you get an error message, and
rerun `pip install -e .`

On Thu, Sep 28, 2017 at 9:05 AM, Mohini Srivastava 
wrote:

> Yes, I am running the webserver in debug mode. I tried using npm run
> dev-fast also, however, I experienced the same behaviour.
>
> -Mohini
>
> On Thu, Sep 28, 2017 at 8:46 PM, Maxime Beauchemin <
> maximebeauche...@gmail.com> wrote:
>
> > Also note the new `npm run dev-fast` command that builds subsequent
> builds
> > much faster (but the small downside is that it has sightly less precise
> > source maps).
> >
> > Max
> >
> > On Thu, Sep 28, 2017 at 8:15 AM, Maxime Beauchemin <
> > maximebeauche...@gmail.com> wrote:
> >
> > > Are you running the web server in debug mode? `superset runserver -d`
> > >
> > > Max
> > >
> > > On Thu, Sep 28, 2017 at 3:47 AM, Mohini Srivastava <
> > moh...@datatorrent.com
> > > > wrote:
> > >
> > >> Hi,
> > >>
> > >>   I am facing issues while making changes/additions to the less files
> > and
> > >> getting that reflected on the Superset UI.
> > >>
> > >> 1. I am running npm run dev (to watch the source file changes). The
> > script
> > >> correctly detects and rebuilds the source files. I can see the changes
> > in
> > >> the /dist folder. However, when running 'superset runserver -d', the
> > >> changes are not getting reflected on the UI.
> > >>
> > >>  Am i missing any step?
> > >>
> > >> 2. Also, I tried using wepback-dev-server with Superset and it keep
> > giving
> > >> Cannot get/ error on browser. Config in webpack.config.js is below.
> > >>
> > >>   output: {
> > >> path: BUILD_DIR,
> > >> filename: '[name].[chunkhash].entry.js',
> > >> chunkFilename: '[name].[chunkhash].entry.js',
> > >>   },
> > >>   devServer: {
> > >> contentBase: BUILD_DIR
> > >>   },
> > >>
> > >>
> > >> Would appreciate any help on this.
> > >>
> > >> Thanks,
> > >> Mohini
> > >>
> > >
> > >
> >
>

[GitHub] mistercrunch closed pull request #3534: Explore update button labels

2017-09-28 Thread git

mistercrunch closed pull request #3534: Explore  update button labels
URL: https://github.com/apache/incubator-superset/pull/3534
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3534: Explore update button labels

2017-09-28 Thread git

mistercrunch commented on issue #3534: Explore  update button labels
URL: 
https://github.com/apache/incubator-superset/pull/3534#issuecomment-332971633
 
 
   Our designer approves of these minor changes, mergin'
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3548: add time granularity to redshift

2017-09-28 Thread git

mistercrunch commented on a change in pull request #3548: add time granularity 
to redshift
URL: 
https://github.com/apache/incubator-superset/pull/3548#discussion_r141743874
 
 

 ##
 File path: superset/db_engine_specs.py
 ##
 @@ -866,6 +866,18 @@ def convert_dttm(cls, target_type, dttm):
 
 class RedshiftEngineSpec(PostgresEngineSpec):
 engine = 'redshift'
+
+time_grains = (
 
 Review comment:
   isn't this inherited from `PostgresEngineSpec`? Looks like a copy-paste of 
exactly what is inherited...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3545: CHANGELOG for 0.20.0

2017-09-28 Thread git

mistercrunch closed pull request #3545: CHANGELOG for 0.20.0
URL: https://github.com/apache/incubator-superset/pull/3545
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] CyrilLeMat commented on issue #3548: add time granularity to redshift

2017-09-28 Thread git

CyrilLeMat commented on issue #3548: add time granularity to redshift
URL: 
https://github.com/apache/incubator-superset/pull/3548#issuecomment-332963011
 
 
   yes it's exactly like the postgresql time grains. I added it because on the 
0.20, I'm not able anymore to use time grains on redshift. If it's supposed to 
inherit from postgresl, then it's a bug. is it supposed to do so?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] CyrilLeMat opened a new pull request #3548: add time granularity to redshift

2017-09-28 Thread git

CyrilLeMat opened a new pull request #3548: add time granularity to redshift
URL: https://github.com/apache/incubator-superset/pull/3548
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141714654
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   In my opinion we should keep the pandas data source only for the simple 
cases: excel, csv, html and json. For more complex scenarios i think an apache 
arrow backend as suggested by @mistercrunch is the way to go.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhunwicks commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

rhunwicks commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141713559
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   @xrmx - you are correct - we are specifically supporting html in `FORMATS` 
so I need to add those dependencies to `setup.py` or whatever requirements file 
we ship with PandasConnector if it lives outside core.
   
   I wonder if there are any other formats we should support by default? JSON 
should work by default. Excel might be useful for many people and would need 
`xlrd`? Given the normal Superset audience do we want to support HDF5 and/or 
Feather? What about SAS or Stata?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3547: Fixing missing messages.json file

2017-09-28 Thread git

coveralls commented on issue #3547: Fixing missing messages.json file
URL: 
https://github.com/apache/incubator-superset/pull/3547#issuecomment-332936389
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13483150/badge)](https://coveralls.io/builds/13483150)
   
   Coverage remained the same at 70.161% when pulling 
**afc51cd24fb9b86a8acfb88f6decd9d801a4e4b0 on mistercrunch:fix_translations** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3547: Fixing missing messages.json file

2017-09-28 Thread git

coveralls commented on issue #3547: Fixing missing messages.json file
URL: 
https://github.com/apache/incubator-superset/pull/3547#issuecomment-332936391
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13483150/badge)](https://coveralls.io/builds/13483150)
   
   Coverage remained the same at 70.161% when pulling 
**afc51cd24fb9b86a8acfb88f6decd9d801a4e4b0 on mistercrunch:fix_translations** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3534: Explore update button labels

2017-09-28 Thread git

coveralls commented on issue #3534: Explore  update button labels
URL: 
https://github.com/apache/incubator-superset/pull/3534#issuecomment-332930176
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13482592/badge)](https://coveralls.io/builds/13482592)
   
   Coverage increased (+0.1%) to 70.161% when pulling 
**7c61f1bac38e529b1fb514f8120eb09526cf94f1 on 
timifasubaa:explore--update_button_labels** into 
**f829b486d1cbd6283158988c62d3882772e2a667 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat commented on issue #3547: Fixing missing messages.json file

2017-09-28 Thread git

graceguo-supercat commented on issue #3547: Fixing missing messages.json file
URL: 
https://github.com/apache/incubator-superset/pull/3547#issuecomment-332929323
 
 
   LGTM!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #3547: Fixing missing messages.json file

2017-09-28 Thread git

mistercrunch opened a new pull request #3547: Fixing missing messages.json file
URL: https://github.com/apache/incubator-superset/pull/3547
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] annusri commented on issue #3280: [dashboard] add link to export CSV from dashboard

2017-09-28 Thread git

annusri commented on issue #3280: [dashboard] add link to export CSV from 
dashboard
URL: 
https://github.com/apache/incubator-superset/pull/3280#issuecomment-332883425
 
 
   @mistercrunch 
   
   I'm trying to get the latest changes/version related to "Export CSV from 
Dashboard".
   when I did pip superset upgrade, I don't see any changes on the Dashboard 
view.
   am' I missing any steps to bring in the latest changes.
   
   pip install superset --upgrade
   superset db upgrade
   superset init
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332890612
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13479167/badge)](https://coveralls.io/builds/13479167)
   
   Coverage increased (+0.7%) to 70.83% when pulling 
**0e50319c75933cbe88b1c750e2cafc75c650198e on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141667380
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   If html is a format supported, wouldn't parse_html be used then?
   
https://github.com/apache/incubator-superset/pull/3492/files#diff-e0528883c8ff7ba985be0482adcc33f5R18
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141667380
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   If html is a format supported, wouldn't parse_html used then?
   
https://github.com/apache/incubator-superset/pull/3492/files#diff-e0528883c8ff7ba985be0482adcc33f5R18
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141667380
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   If html is a format supported, wouldn't parse_html used then?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pajachiet commented on issue #3059: Cannot create sankey diagrams with more than two source/target dimensions

2017-09-28 Thread git

pajachiet commented on issue #3059: Cannot create sankey diagrams with more 
than two source/target dimensions
URL: 
https://github.com/apache/incubator-superset/issues/3059#issuecomment-332448830
 
 
   And to give a better example, here is a dashboard based on superset backend. 
   
[superset_dashboard_role-datasource-dashboard_relations.pickle.zip](https://github.com/apache/incubator-superset/files/1336261/superset_dashboard_role-datasource-dashboard_relations.pickle.zip)
   
   https://user-images.githubusercontent.com/4091226/30903272-7f829842-a36e-11e7-94e2-339bdbd07542.png;>
   
   It shows with a Sankey diagram the relationships between role and datasource 
(access rights), then between datasource and dashboards (through slices). 
   
   This is great for us to see who has access to which datasource, and in the 
same glance to which dashboards.
   But the underlying [sql 
request](https://gist.github.com/pajachiet/cc1ec2d06ebb9060ee4d8d17a9c2) 
has to do the UNION. 
   (the table in the dashboard does not use views, which makes it more 
difficult to read).
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhunwicks commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

rhunwicks commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141663500
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   > The original comment was because you added lxml twice
   
   Thanks - I've fixed it now.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Unable to reflect css changes from custom less files on Superset UI

2017-09-28 Thread Mohini Srivastava

Yes, I am running the webserver in debug mode. I tried using npm run
dev-fast also, however, I experienced the same behaviour.

-Mohini

On Thu, Sep 28, 2017 at 8:46 PM, Maxime Beauchemin <
maximebeauche...@gmail.com> wrote:

> Also note the new `npm run dev-fast` command that builds subsequent builds
> much faster (but the small downside is that it has sightly less precise
> source maps).
>
> Max
>
> On Thu, Sep 28, 2017 at 8:15 AM, Maxime Beauchemin <
> maximebeauche...@gmail.com> wrote:
>
> > Are you running the web server in debug mode? `superset runserver -d`
> >
> > Max
> >
> > On Thu, Sep 28, 2017 at 3:47 AM, Mohini Srivastava <
> moh...@datatorrent.com
> > > wrote:
> >
> >> Hi,
> >>
> >>   I am facing issues while making changes/additions to the less files
> and
> >> getting that reflected on the Superset UI.
> >>
> >> 1. I am running npm run dev (to watch the source file changes). The
> script
> >> correctly detects and rebuilds the source files. I can see the changes
> in
> >> the /dist folder. However, when running 'superset runserver -d', the
> >> changes are not getting reflected on the UI.
> >>
> >>  Am i missing any step?
> >>
> >> 2. Also, I tried using wepback-dev-server with Superset and it keep
> giving
> >> Cannot get/ error on browser. Config in webpack.config.js is below.
> >>
> >>   output: {
> >> path: BUILD_DIR,
> >> filename: '[name].[chunkhash].entry.js',
> >> chunkFilename: '[name].[chunkhash].entry.js',
> >>   },
> >>   devServer: {
> >> contentBase: BUILD_DIR
> >>   },
> >>
> >>
> >> Would appreciate any help on this.
> >>
> >> Thanks,
> >> Mohini
> >>
> >
> >
>

[GitHub] annusri commented on issue #3280: [dashboard] add link to export CSV from dashboard

2017-09-28 Thread git

annusri commented on issue #3280: [dashboard] add link to export CSV from 
dashboard
URL: 
https://github.com/apache/incubator-superset/pull/3280#issuecomment-332883425
 
 
   I'm trying to get the latest changes/version related to "Export CSV from 
Dashboard".
   when I did pip superset upgrade, I don't see any changes on the Dashboard 
view.
   am' I missing any steps to bring in the latest changes.
   
   pip install superset --upgrade
   superset db upgrade
   superset init
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] annusri commented on issue #3280: [dashboard] add link to export CSV from dashboard

2017-09-28 Thread git

annusri commented on issue #3280: [dashboard] add link to export CSV from 
dashboard
URL: 
https://github.com/apache/incubator-superset/pull/3280#issuecomment-332883425
 
 
   I'm trying to get the latest changes/version related to "Export CSV from 
Download".
   when I did pip superset upgrade, I don't see any changes on the Dashboard 
view.
   am' I missing any steps to bring in the latest changes.
   
   pip install superset --upgrade
   superset db upgrade
   superset init
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new issue #3503: Feature: Dashboard filters: datepicker and time granularity

2017-09-28 Thread git

Mogball opened a new issue #3503: Feature: Dashboard filters: datepicker and 
time granularity
URL: https://github.com/apache/incubator-superset/issues/3503
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [x] I have reproduced the issue with at least the latest released version 
of superset
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   When checking "Date" under options in the dashboard filter explore view, 
only the default time options for `since` and `until` are available, with no 
ability to set time granularity.
   https://user-images.githubusercontent.com/15016832/30620809-70bd251a-9d5c-11e7-802a-4fe1d8ab2b99.png;>
   
   The time granularity option and datepicker should be available for dashboard 
filters.
   
   ### Superset version
   0.19.3
   
   ### Expected results
   Dashboard date filters should have time granularity and datepicker.
   
   ### Actual results
   Dashboard date filters only allow the default time options
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141656739
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   The original comment was because you added lxml twice not because you added 
two different libraries :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhunwicks commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

rhunwicks commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141656438
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   https://pandas.pydata.org/pandas-docs/stable/io.html#io-html-gotchas 
explains that `read_html` uses bs4 as a wrapper for lxml. We could use 
`html5lib` instead of `lxml`.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhunwicks commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

rhunwicks commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141652942
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   They are required by `pandas.read_html()`, which I use in `connector_tests` 
to make it easy to set up test data as a Markdown table and then push it into 
whatever Datasource is being tested.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141649750
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   actually i can't find where you are using lxml and beautifulsoup
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141648151
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   once should be enough
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Unable to reflect css changes from custom less files on Superset UI

2017-09-28 Thread Maxime Beauchemin

Also note the new `npm run dev-fast` command that builds subsequent builds
much faster (but the small downside is that it has sightly less precise
source maps).

Max

On Thu, Sep 28, 2017 at 8:15 AM, Maxime Beauchemin <
maximebeauche...@gmail.com> wrote:

> Are you running the web server in debug mode? `superset runserver -d`
>
> Max
>
> On Thu, Sep 28, 2017 at 3:47 AM, Mohini Srivastava  > wrote:
>
>> Hi,
>>
>>   I am facing issues while making changes/additions to the less files and
>> getting that reflected on the Superset UI.
>>
>> 1. I am running npm run dev (to watch the source file changes). The script
>> correctly detects and rebuilds the source files. I can see the changes in
>> the /dist folder. However, when running 'superset runserver -d', the
>> changes are not getting reflected on the UI.
>>
>>  Am i missing any step?
>>
>> 2. Also, I tried using wepback-dev-server with Superset and it keep giving
>> Cannot get/ error on browser. Config in webpack.config.js is below.
>>
>>   output: {
>> path: BUILD_DIR,
>> filename: '[name].[chunkhash].entry.js',
>> chunkFilename: '[name].[chunkhash].entry.js',
>>   },
>>   devServer: {
>> contentBase: BUILD_DIR
>>   },
>>
>>
>> Would appreciate any help on this.
>>
>> Thanks,
>> Mohini
>>
>
>

Re: Unable to reflect css changes from custom less files on Superset UI

2017-09-28 Thread Maxime Beauchemin

Are you running the web server in debug mode? `superset runserver -d`

Max

On Thu, Sep 28, 2017 at 3:47 AM, Mohini Srivastava 
wrote:

> Hi,
>
>   I am facing issues while making changes/additions to the less files and
> getting that reflected on the Superset UI.
>
> 1. I am running npm run dev (to watch the source file changes). The script
> correctly detects and rebuilds the source files. I can see the changes in
> the /dist folder. However, when running 'superset runserver -d', the
> changes are not getting reflected on the UI.
>
>  Am i missing any step?
>
> 2. Also, I tried using wepback-dev-server with Superset and it keep giving
> Cannot get/ error on browser. Config in webpack.config.js is below.
>
>   output: {
> path: BUILD_DIR,
> filename: '[name].[chunkhash].entry.js',
> chunkFilename: '[name].[chunkhash].entry.js',
>   },
>   devServer: {
> contentBase: BUILD_DIR
>   },
>
>
> Would appreciate any help on this.
>
> Thanks,
> Mohini
>

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

2017-09-28 Thread git

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r141648151
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   one should be enough
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhunwicks commented on issue #3492: PandasConnector

2017-09-28 Thread git

rhunwicks commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332864586
 
 
   @mistercrunch I have moved the migration into `superset/migrations/versions` 
in order to get Travis to run. I can move it back out if you decide you want to 
keep it in a `contrib` directory.
   
   I have also added `lxml` and `beautifulsoup4` to `dev-reqs.txt` because 
`contrib.tests.connector_tests` uses them to prepare test data. 
`connector_tests` is probably useful for other people writing connectors as 
well as providing increased test coverage for 
`superset/connectors/sqla/models.py` so you might want to adopt some of it into 
core.
   
   Please let me know what you would like me to do next?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332862050
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13477212/badge)](https://coveralls.io/builds/13477212)
   
   Coverage increased (+0.7%) to 70.83% when pulling 
**fa3825631ec62f24ea94d69edb7b508913f25cda on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332862045
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13477212/badge)](https://coveralls.io/builds/13477212)
   
   Coverage increased (+0.7%) to 70.83% when pulling 
**fa3825631ec62f24ea94d69edb7b508913f25cda on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332842648
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13476101/badge)](https://coveralls.io/builds/13476101)
   
   Coverage increased (+0.5%) to 70.612% when pulling 
**d156430dc4f5ee88bb5a6f7885b60312dad16fab on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332818727
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13474610/badge)](https://coveralls.io/builds/13474610)
   
   Coverage increased (+0.5%) to 70.612% when pulling 
**4b47b7539128fb979dd4115a33d86b5b0cb2ee93 on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Unable to reflect css changes from custom less files on Superset UI

2017-09-28 Thread Mohini Srivastava

Hi,

  I am facing issues while making changes/additions to the less files and
getting that reflected on the Superset UI.

1. I am running npm run dev (to watch the source file changes). The script
correctly detects and rebuilds the source files. I can see the changes in
the /dist folder. However, when running 'superset runserver -d', the
changes are not getting reflected on the UI.

 Am i missing any step?

2. Also, I tried using wepback-dev-server with Superset and it keep giving
Cannot get/ error on browser. Config in webpack.config.js is below.

  output: {
path: BUILD_DIR,
filename: '[name].[chunkhash].entry.js',
chunkFilename: '[name].[chunkhash].entry.js',
  },
  devServer: {
contentBase: BUILD_DIR
  },


Would appreciate any help on this.

Thanks,
Mohini

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332798900
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13473437/badge)](https://coveralls.io/builds/13473437)
   
   Coverage remained the same at 70.161% when pulling 
**9df1786470f77b43c9a2fbd5e2ac5fc35c12360b on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332798896
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13473437/badge)](https://coveralls.io/builds/13473437)
   
   Coverage remained the same at 70.161% when pulling 
**9df1786470f77b43c9a2fbd5e2ac5fc35c12360b on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

2017-09-28 Thread git

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-332798895
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13473437/badge)](https://coveralls.io/builds/13473437)
   
   Coverage remained the same at 70.161% when pulling 
**9df1786470f77b43c9a2fbd5e2ac5fc35c12360b on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asdf2014 commented on issue #2196: some problems in run_tests.sh

2017-09-28 Thread git

asdf2014 commented on issue #2196: some problems in run_tests.sh
URL: 
https://github.com/apache/incubator-superset/issues/2196#issuecomment-332789116
 
 
   @rhunwicks Thanks a lot! :smile: 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tristix commented on issue #920: Add a bottom row that aggregates each metric column for table viz

2017-09-28 Thread git

tristix commented on issue #920: Add a bottom row that aggregates each metric 
column for table viz
URL: 
https://github.com/apache/incubator-superset/pull/920#issuecomment-332775958
 
 
   +1 for anyone knowledgeable enough to get this in!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] gsemyonov commented on issue #3503: Feature: Dashboard filters: datepicker and time granularity

2017-09-28 Thread git

gsemyonov commented on issue #3503: Feature: Dashboard filters: datepicker and 
time granularity
URL: 
https://github.com/apache/incubator-superset/issues/3503#issuecomment-332769130
 
 
   Why did you close this item? I have the same problem.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhunwicks commented on issue #2196: some problems in run_tests.sh

2017-09-28 Thread git

rhunwicks commented on issue #2196: some problems in run_tests.sh
URL: 
https://github.com/apache/incubator-superset/issues/2196#issuecomment-332767475
 
 
   On a fresh install I get the same as @asdf2014 originally reported: when I 
run `./run_tests.sh` I get:
   
   ```
   ImportError: module 'tests' has no attribute 'superset_test_config'
   ```
   
   
   In my case the problem was that the application source directory isn't on 
the Python path so when you run `run_tests.sh` it can't locate module `tests`. 
It works for me if I do
   
   ```
   export PYTHONPATH=.
   ./run_tests.sh
   ```
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #3545: CHANGELOG for 0.20.0

2017-09-28 Thread git

timifasubaa commented on issue #3545: CHANGELOG for 0.20.0
URL: 
https://github.com/apache/incubator-superset/pull/3545#issuecomment-332761266
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vnnw opened a new issue #3546: A bug in table view sorting in version 0.20.0?

2017-09-28 Thread git

vnnw opened a new issue #3546: A bug in table view sorting in version 0.20.0? 
URL: https://github.com/apache/incubator-superset/issues/3546
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version 
of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.20.0 from pypi
   
   ### Expected results
   Order by time column exactly.
   
   ### Actual results
   Ordering is wrong when I choose the format of "%Y-%m-%d | 2019-01-14" using 
the sample database of "birth names".  
   The first line of "1970-01-01" comes the first place. 
   Using other datetime formats seems good as far as I tested.
   
   See the screenshot as below:
   
   
![image](https://user-images.githubusercontent.com/4979571/30953832-3caff192-a3f3-11e7-9506-bc94f68a442c.png)
   
   ### Steps to reproduce
   Create a table view, select "Include Time", then click Sort icon on the 
table's header.
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vnnw commented on issue #3516: How to make Table View/ Pivot Table order by time?

2017-09-28 Thread git

vnnw commented on issue #3516: How to make Table View/ Pivot Table order by 
time?
URL: 
https://github.com/apache/incubator-superset/issues/3516#issuecomment-332746320
 
 
   @gangh Seems V 0.20 has already provided the options you want.
   But I can't still find a way to sort the table by __timestamp.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

53 matches

Mail list logo