[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492919#comment-14492919
]
ASF GitHub Bot commented on THRIFT-2441:
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28270114
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
}
-#if defined __FreeBSD__ || defined __MACH__
if (errno_copy == THRIFT_ECONNRESET) {
- /* shigin: freebsd doesn't follow POSIX semantic of recv and fails
with
- * THRIFT_ECONNRESET if peer performed shutdown
- * edhall: eliminated close() since we do that in the destructor.
- */
return 0;
}
-#endif
-
-#ifdef _WIN32
--- End diff --
Thanks Jim, I'm fine with your explanations, CMake build on appveyor
currently fails and I try to get it up and runnning again. I think Windows
platform users shall use Visual Studio instead of cygwin and MinGW or as a
better choice clang;-)
Cannot shutdown TThreadedServer when clients are still connected
Key: THRIFT-2441
URL: https://issues.apache.org/jira/browse/THRIFT-2441
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9.1
Reporter: Chris Stylianou
Assignee: Ben Craig
Attachments: THRIFT-2441-prelim.patch
When calling stop() on the TThreadedServer no interrupts are sent to the
client threads. This means the stop() call blocks on tasksMonitor.wait()
until all client naturally disconnect.
How can we tell the client thread connections to close/exit during the
TThreadedServer::stop() call?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28270114
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
}
-#if defined __FreeBSD__ || defined __MACH__
if (errno_copy == THRIFT_ECONNRESET) {
- /* shigin: freebsd doesn't follow POSIX semantic of recv and fails
with
- * THRIFT_ECONNRESET if peer performed shutdown
- * edhall: eliminated close() since we do that in the destructor.
- */
return 0;
}
-#endif
-
-#ifdef _WIN32
--- End diff --
Thanks Jim, I'm fine with your explanations, CMake build on appveyor
currently fails and I try to get it up and runnning again. I think Windows
platform users shall use Visual Studio instead of cygwin and MinGW or as a
better choice clang;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492972#comment-14492972 ] Hudson commented on THRIFT-3094: SUCCESS: Integrated in Thrift #1506 (See [https://builds.apache.org/job/Thrift/1506/]) THRIFT-3094 fix broken cmake build of C++ library with alternate threading (roger: rev 1673adf94a381d66db2f0a062c636b24937473f7) * lib/cpp/CMakeLists.txt * build/cmake/DefinePlatformSpecifc.cmake master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3094. - Resolution: Fixed Thanks Jim travis-ci ;-) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492893#comment-14492893 ] Roger Meier commented on THRIFT-3090: - [~codesf] What do you think as a CentOS user? according to [~nsuke] CentOS 7 is stuck at 2.8.11 and CentOS 6.6 / Ubuntu 14.04 LTS uses 2.8.12. I have the feeling that Centos 7 will change to 2.8.12 as well and I still believe we should go for 2.8.12. cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28269576
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
}
-#if defined __FreeBSD__ || defined __MACH__
if (errno_copy == THRIFT_ECONNRESET) {
- /* shigin: freebsd doesn't follow POSIX semantic of recv and fails
with
- * THRIFT_ECONNRESET if peer performed shutdown
- * edhall: eliminated close() since we do that in the destructor.
- */
return 0;
}
-#endif
-
-#ifdef _WIN32
--- End diff --
I spent a few hours trying to get a MinGW environment set up, but I wasn't
able to so I am switching to Cygwin instead. Is there a MinGW 64-bit
environment out there that has everything you need for Thrift? MinGW-w64
seemed like it had promise but it was missing the autotool chain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492894#comment-14492894
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28269576
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
}
-#if defined __FreeBSD__ || defined __MACH__
if (errno_copy == THRIFT_ECONNRESET) {
- /* shigin: freebsd doesn't follow POSIX semantic of recv and fails
with
- * THRIFT_ECONNRESET if peer performed shutdown
- * edhall: eliminated close() since we do that in the destructor.
- */
return 0;
}
-#endif
-
-#ifdef _WIN32
--- End diff --
I spent a few hours trying to get a MinGW environment set up, but I wasn't
able to so I am switching to Cygwin instead. Is there a MinGW 64-bit
environment out there that has everything you need for Thrift? MinGW-w64
seemed like it had promise but it was missing the autotool chain.
Cannot shutdown TThreadedServer when clients are still connected
Key: THRIFT-2441
URL: https://issues.apache.org/jira/browse/THRIFT-2441
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9.1
Reporter: Chris Stylianou
Assignee: Ben Craig
Attachments: THRIFT-2441-prelim.patch
When calling stop() on the TThreadedServer no interrupts are sent to the
client threads. This means the stop() call blocks on tasksMonitor.wait()
until all client naturally disconnect.
How can we tell the client thread connections to close/exit during the
TThreadedServer::stop() call?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3062) C++ TServerSocket invalid port number (over 999999) causes stack corruption
[
https://issues.apache.org/jira/browse/THRIFT-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492907#comment-14492907
]
James E. King, III commented on THRIFT-3062:
This is ready to be merged.
C++ TServerSocket invalid port number (over 99) causes stack corruption
---
Key: THRIFT-3062
URL: https://issues.apache.org/jira/browse/THRIFT-3062
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9.2
Reporter: James E. King, III
Labels: security
Attachments: THRIFT-3062.patch
In {{TServerSocket::listen()}} a buffer of size 7 is allocated for the string
to numeric translation of the port number, defined as {{int}}:
{noformat} char port[sizeof(65536) + 1];
...
sprintf(port, %d, port_);{noformat}
An input of 100 or more will cause stack corruption. Recommend changing
sprintf to something safer, or making a larger buffer. In this case, one can
safely allocate a fixed size buffer on the stack to accomodate the largest
result possible, avoiding the problem. Alternatively, ensure the input is
bound, which is what {{TSocket::localOpen()}} does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492985#comment-14492985 ] Randy Abernethy commented on THRIFT-3090: - I can confirm that base packages for Centos 7 install cmake 2.8.11 while Centos 6.5 installs 2.8.12.2. A curious state of affairs and as you suggest, probably temporary. I just built 2.8.12 from source on a centos 7 box and it seems to work fine at first blush. +1 for 2.8.12 if we need it. cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: Replace deprecated , with as in python ex...
GitHub user gwax opened a pull request: https://github.com/apache/thrift/pull/440 Replace deprecated , with as in python exception generation code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/CloverHealth/thrift py3_fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/440.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #440 commit a704277d7df19463bbad7c2339cd9c194f44f9a8 Author: George Leslie-Waksman geo...@cloverhealth.com Date: 2015-04-13T18:16:59Z Replace deprecated , with as in python except generation code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3069) C++ TServerSocket leaks socket on fcntl get or set flags error
[
https://issues.apache.org/jira/browse/THRIFT-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492908#comment-14492908
]
James E. King, III commented on THRIFT-3069:
This is ready to be merged.
C++ TServerSocket leaks socket on fcntl get or set flags error
--
Key: THRIFT-3069
URL: https://issues.apache.org/jira/browse/THRIFT-3069
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9.2
Reporter: James E. King, III
Priority: Minor
Walking through the C++ TServerSocket code, there are opportunities for the
newly accepted client socket to leak:
{noformat} THRIFT_SOCKET clientSocket = ::accept(serverSocket_,
(struct sockaddr *) clientAddress,
(socklen_t *) size);
if (clientSocket == -1) {
int errno_copy = THRIFT_GET_SOCKET_ERROR;
GlobalOutput.perror(TServerSocket::acceptImpl() ::accept() ,
errno_copy);
throw TTransportException(TTransportException::UNKNOWN, accept(),
errno_copy);
}
// Make sure client socket is blocking
int flags = THRIFT_FCNTL(clientSocket, THRIFT_F_GETFL, 0);
if (flags == -1) {
int errno_copy = THRIFT_GET_SOCKET_ERROR;
GlobalOutput.perror(TServerSocket::acceptImpl() THRIFT_FCNTL()
THRIFT_F_GETFL , errno_copy);
throw TTransportException(TTransportException::UNKNOWN,
THRIFT_FCNTL(THRIFT_F_GETFL), errno_copy);
}
if (-1 == THRIFT_FCNTL(clientSocket, THRIFT_F_SETFL, flags
~THRIFT_O_NONBLOCK)) {
int errno_copy = THRIFT_GET_SOCKET_ERROR;
GlobalOutput.perror(TServerSocket::acceptImpl() THRIFT_FCNTL()
THRIFT_F_SETFL ~THRIFT_O_NONBLOCK , errno_copy);
throw TTransportException(TTransportException::UNKNOWN,
THRIFT_FCNTL(THRIFT_F_SETFL), errno_copy);
}
{noformat}
Specifically in both of the latter error handling cases, {{clientSocket}} is
not cleaned up. Given this is highly unlikely to occur, I set the priority
of this issue to Minor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493140#comment-14493140 ] ASF GitHub Bot commented on THRIFT-3094: Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92507745 https://thrift.apache.org/docs/committers/HowToCommit master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92507745 https://thrift.apache.org/docs/committers/HowToCommit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92508143 Thanks - the manual steps in this process are less than ideal, and Apache should consider tighter integration to resolve. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92498933 I guess this was merged through Hudson, as a result I am closing this. Sometimes they close automatically, and sometimes they do not, and I have no idea why... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493087#comment-14493087 ] ASF GitHub Bot commented on THRIFT-3094: Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92498933 I guess this was merged through Hudson, as a result I am closing this. Sometimes they close automatically, and sometimes they do not, and I have no idea why... master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493129#comment-14493129 ] ASF GitHub Bot commented on THRIFT-3094: Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92505688 . Sometimes they close automatically, and sometimes they do not, and I have no idea why... They are closed when the magic line This closes number is in the commit message. If the committer does not add this (or forgets it) then nothing happens. master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92506605 Are we using the github merge pull request mechanism that appears in each pull request here, or are we forced to use some other means to commit changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-1857) Python 3.X Support
[ https://issues.apache.org/jira/browse/THRIFT-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493067#comment-14493067 ] ASF GitHub Bot commented on THRIFT-1857: Github user gwax commented on the pull request: https://github.com/apache/thrift/pull/440#issuecomment-92496624 I have added the relevant (existing) Jira issue to the description. Is that sufficient or should I do something further? Python 3.X Support -- Key: THRIFT-1857 URL: https://issues.apache.org/jira/browse/THRIFT-1857 Project: Thrift Issue Type: Improvement Components: Python - Compiler Affects Versions: 0.9 Reporter: Avi Saranga Assignee: Roger Meier Fix For: 0.9.3 add support for python 3.x -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493088#comment-14493088 ] ASF GitHub Bot commented on THRIFT-3094: Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/439 master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-1857) Python 3.X Support
[ https://issues.apache.org/jira/browse/THRIFT-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493086#comment-14493086 ] ASF GitHub Bot commented on THRIFT-1857: Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/440#issuecomment-92498770 perfect, thanks Python 3.X Support -- Key: THRIFT-1857 URL: https://issues.apache.org/jira/browse/THRIFT-1857 Project: Thrift Issue Type: Improvement Components: Python - Compiler Affects Versions: 0.9 Reporter: Avi Saranga Assignee: Roger Meier Fix For: 0.9.3 add support for python 3.x -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-1857 Replace deprecated , with as ...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/440#issuecomment-92498770 perfect, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493135#comment-14493135 ] ASF GitHub Bot commented on THRIFT-3094: Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92506605 Are we using the github merge pull request mechanism that appears in each pull request here, or are we forced to use some other means to commit changes? master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493143#comment-14493143 ] ASF GitHub Bot commented on THRIFT-3094: Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92508143 Thanks - the manual steps in this process are less than ideal, and Apache should consider tighter integration to resolve. master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: How to comiple https://github.com/eyjian/thrift?
Hi, no idea, works fine for me (setup below). Can we get something like a full log or is this the only output you got? JensG bison 2.7 autoconf 2.69 automake 1.13.4 libtool 2.4.2 OpenSSL 1.0.1k-fips 8 Jan 2015 boost 1.54.0 libevent 2.0.5 m4 1.4.17 gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064] -Ursprüngliche Nachricht- From: 易剑 Sent: Monday, April 13, 2015 10:36 AM To: dev@thrift.apache.org Subject: How to comiple https://github.com/eyjian/thrift? I forked branches to https://github.com/eyjian/thrift, but failed to compile it with errors: *./bootstrap.sh * *.ibtoolize: AC_CONFIG_MACRO_DIR([./aclocal]) conflicts with ACLOCAL_AMFLAGS=-I ./aclocal* i had updated deps as the followings: bison-3.0 autoconf-2.69 automake-1.15 libtool-2.4 openssl-1.0.2a boost_1_57_0 libevent-2.0.22-stable m4-1.4.17 # gcc --version gcc (GCC) 4.1.2 20070115 (prerelease) (SUSE Linux) Copyright (C) 2006 Free Software Foundation, Inc.
[GitHub] thrift pull request: THRIFT-1857 Replace deprecated , with as ...
Github user gwax commented on the pull request: https://github.com/apache/thrift/pull/440#issuecomment-92496624 I have added the relevant (existing) Jira issue to the description. Is that sufficient or should I do something further? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3093) mingw compile fixes for c++ library 0.9.2
[ https://issues.apache.org/jira/browse/THRIFT-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493100#comment-14493100 ] Jens Geyer commented on THRIFT-3093: Could you do the same for trunk? That would be awesome. Or are these problems no longer existent there? mingw compile fixes for c++ library 0.9.2 - Key: THRIFT-3093 URL: https://issues.apache.org/jira/browse/THRIFT-3093 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: mingw/cygwin Reporter: Eion Robb Priority: Minor Attachments: mingw-compile.diff I've spent the morning trying to get the C++ library compiled using mingw/cygwin. I had to make a few changes to get things to compile. Some places didn't include sys/time.h when they needed to (for the timeval struct) and I needed to make the timeval struct in the global namespace, else the compiler would try to look for it in the thrift namespace. There was also a minor issue with the syntax for the #ifdef HAVE_STRERROR_R check in Thrift.cpp; the config.h file says to set the parameter to 0 if strerror_r is not available - rather than undefine it. Last of all, I had to add in an implementation of vsnprintf() as my version of mingw did not provide it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2119) Compiling the Thrift C++ Library with Visual Studio 2005
[ https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493113#comment-14493113 ] Jens Geyer commented on THRIFT-2119: Is VS2005 still relevant? Or can we close that ticket? Compiling the Thrift C++ Library with Visual Studio 2005 Key: THRIFT-2119 URL: https://issues.apache.org/jira/browse/THRIFT-2119 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.9.1, 1.0 Environment: Microsoft Visual Studio 2005. Reporter: Jonas Labels: patch Attachments: CMakeLists.txt, thrift_patch.patch Original Estimate: 24h Remaining Estimate: 24h Hi, I created a patch (for the current trunk revision) to compile the Thrift C++ Library with Visual Studio 2005 (only libthrift, not libthriftnb for asynchronous calls). The patch essentially adds a few (forgotten?) #ifdef HAVE_STDINT_H and contains a workaround for a problem with SFINAE with the VS8 compiler. An additional problem appears with tr1::function when compiling TAsyncChannel.cpp. I excluded this source file from the build (it is required?). Could these changes be integrated in the trunk? Many thanks for your considerations, Best, Jonas -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92505688 . Sometimes they close automatically, and sometimes they do not, and I have no idea why... They are closed when the magic line This closes number is in the commit message. If the committer does not add this (or forgets it) then nothing happens. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3094: --- Component/s: (was: C++ - Library) Build Process master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3095) Enable CI Build for Coverity Scan integration
James E. King, III created THRIFT-3095: -- Summary: Enable CI Build for Coverity Scan integration Key: THRIFT-3095 URL: https://issues.apache.org/jira/browse/THRIFT-3095 Project: Thrift Issue Type: Improvement Components: C# - Compiler, C# - Library, C++ - Compiler, C++ - Library, Java - Compiler, Java - Library Environment: Travis CI and Coverity Scan Reporter: James E. King, III Coverity offers a wonderful free static code analysis tool for C++, C# and Java open source projects. It is very easy to automate submissions to Coverity Scan for code analysis - I just spent about 15 minutes today (not including build time) setting up the GNU C Library (glibc) in Coverity Scan. We should create a CI job that submits results to Coverity Scan to improve the overall quality of the codebase. This is a low-effort, high-reward improvement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3096) Consolidate TSimpleServer, TThreadedServer, TThreadPoolServer into one
James E. King, III created THRIFT-3096: -- Summary: Consolidate TSimpleServer, TThreadedServer, TThreadPoolServer into one Key: THRIFT-3096 URL: https://issues.apache.org/jira/browse/THRIFT-3096 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.9.2, 0.9.3 Reporter: James E. King, III Priority: Minor It was suggested in discussions inside THRIFT-3083, THRIFT-3084 that the difference between the refactored servers was so slight that we might want to start thinking about them as one server. We have IO Completion servers, Non Blocking servers, and threaded servers with concurrency control (1 = Simple, 1 = Threaded/ThreadPool). Each one brings a substantially different mechanism to the table and are valid to stand on their own, but maybe it is time to consolidate into a single TThreadedServer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3095) Enable CI Build for Coverity Scan integration
[ https://issues.apache.org/jira/browse/THRIFT-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3095: --- Description: Coverity offers a wonderful free static code analysis tool for C++, C# and Java open source projects. It is very easy to automate submissions to Coverity Scan for code analysis - I just spent about 15 minutes today (not including build time) setting up the GNU C Library (glibc) in Coverity Scan. We should create a CI job that submits results to Coverity Scan to improve the overall quality of the codebase. This is a low-effort, high-reward improvement. If you want to see why this is so powerful please review the Coverity Scan project for the GNU C Library (glibc), something we all use every day: https://scan.coverity.com/projects/4826?tab=overview was:Coverity offers a wonderful free static code analysis tool for C++, C# and Java open source projects. It is very easy to automate submissions to Coverity Scan for code analysis - I just spent about 15 minutes today (not including build time) setting up the GNU C Library (glibc) in Coverity Scan. We should create a CI job that submits results to Coverity Scan to improve the overall quality of the codebase. This is a low-effort, high-reward improvement. Enable CI Build for Coverity Scan integration - Key: THRIFT-3095 URL: https://issues.apache.org/jira/browse/THRIFT-3095 Project: Thrift Issue Type: Improvement Components: C# - Compiler, C# - Library, C++ - Compiler, C++ - Library, Java - Compiler, Java - Library Environment: Travis CI and Coverity Scan Reporter: James E. King, III Labels: Coverity, StaticCodeAnalysis Coverity offers a wonderful free static code analysis tool for C++, C# and Java open source projects. It is very easy to automate submissions to Coverity Scan for code analysis - I just spent about 15 minutes today (not including build time) setting up the GNU C Library (glibc) in Coverity Scan. We should create a CI job that submits results to Coverity Scan to improve the overall quality of the codebase. This is a low-effort, high-reward improvement. If you want to see why this is so powerful please review the Coverity Scan project for the GNU C Library (glibc), something we all use every day: https://scan.coverity.com/projects/4826?tab=overview -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92574982 hey @jeking3, Github is only a mirror of the actual Apache repos which are located at [1]. There is a requirement that the canonical source for Apache repos must reside on ASF controlled servers and that they be the authority for commits. We have all the available Github integrations enabled for our project, but the merge button is not an option. [1]: git-wip-us.apache.org/repos/asf?p=thrift.git --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493491#comment-14493491 ] ASF GitHub Bot commented on THRIFT-3094: Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/439#issuecomment-92574982 hey @jeking3, Github is only a mirror of the actual Apache repos which are located at [1]. There is a requirement that the canonical source for Apache repos must reside on ASF controlled servers and that they be the authority for commits. We have all the available Github integrations enabled for our project, but the merge button is not an option. [1]: git-wip-us.apache.org/repos/asf?p=thrift.git master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-227) Byte[] in collections aren't pretty printed like regular binary fields
[ https://issues.apache.org/jira/browse/THRIFT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493614#comment-14493614 ] ASF GitHub Bot commented on THRIFT-227: --- GitHub user roshan opened a pull request: https://github.com/apache/thrift/pull/441 THRIFT-227 Pretty print binary collections in Java `setbinary` and `listbinary` don't have pretty printers corresponding to `binary`. This adds them. You can merge this pull request into a Git repository by running: $ git pull https://github.com/roshan/thrift THRIFT-227_pretty_print_byte_collections Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/441.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #441 commit 5da68694fec6a51e97f5a75823babb1074e32eb2 Author: Roshan George ros...@arjie.com Date: 2015-04-13T03:40:26Z THRIFT-227 Pretty print binary collections Byte[] in collections aren't pretty printed like regular binary fields -- Key: THRIFT-227 URL: https://issues.apache.org/jira/browse/THRIFT-227 Project: Thrift Issue Type: Improvement Components: Java - Compiler Reporter: Bryan Duxbury Assignee: Bryan Duxbury Priority: Trivial In toString, we just delegate to the toString method of our embedded collection objects, which in turn call the toString of the byte[] collection elements. This results in [B@12fa2134 instead of 01 a3 17. It'd be nice if we could figure out a way to print the collection elements the same as regular fields. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-227 Pretty print binary collections in...
GitHub user roshan opened a pull request: https://github.com/apache/thrift/pull/441 THRIFT-227 Pretty print binary collections in Java `setbinary` and `listbinary` don't have pretty printers corresponding to `binary`. This adds them. You can merge this pull request into a Git repository by running: $ git pull https://github.com/roshan/thrift THRIFT-227_pretty_print_byte_collections Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/441.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #441 commit 5da68694fec6a51e97f5a75823babb1074e32eb2 Author: Roshan George ros...@arjie.com Date: 2015-04-13T03:40:26Z THRIFT-227 Pretty print binary collections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
How to comiple https://github.com/eyjian/thrift?
I forked branches to https://github.com/eyjian/thrift, but failed to compile it with errors: *./bootstrap.sh * *.ibtoolize: AC_CONFIG_MACRO_DIR([./aclocal]) conflicts with ACLOCAL_AMFLAGS=-I ./aclocal* i had updated deps as the followings: bison-3.0 autoconf-2.69 automake-1.15 libtool-2.4 openssl-1.0.2a boost_1_57_0 libevent-2.0.22-stable m4-1.4.17 # gcc --version gcc (GCC) 4.1.2 20070115 (prerelease) (SUSE Linux) Copyright (C) 2006 Free Software Foundation, Inc.
[jira] [Reopened] (THRIFT-3071) bootstrap.sh on Ubuntu 12.04 (Precise) automake error
[
https://issues.apache.org/jira/browse/THRIFT-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reopened THRIFT-3071:
bootstrap.sh on Ubuntu 12.04 (Precise) automake error
-
Key: THRIFT-3071
URL: https://issues.apache.org/jira/browse/THRIFT-3071
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.9.3
Environment: Ubuntu 12.04.1 LTS
Reporter: James E. King, III
Assignee: Jens Geyer
Priority: Minor
Fix For: 0.9.3
Ubuntu 12.04 contains automake-1.11, and the bootstrap.sh script requires
1.13 or later:
{code}
~/dev/thrift$ ./bootstrap.sh
configure.ac:103: warning: macro `AM_EXTRA_RECURSIVE_TARGETS' not found in
library
configure.ac:103: error: possibly undefined macro: AM_EXTRA_RECURSIVE_TARGETS
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.{code}
A workaround for this issue is to install automake-1.14 via community PPA:
{noformat}
# add-apt-repository ppa:dns/gnu
# apt-get update
# apt-get install automake
{noformat}
bootstrap.sh should check the version of automake and emit a nicer error
message when 1.13 or later is not available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3071 fix bootstrap.sh on MinGW
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/438 THRIFT-3071 fix bootstrap.sh on MinGW Fixes an issue I introduced in bootstrap.sh that depended on rev, an executable not normally available in MinGW or MSYS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3071-on-mingw Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/438.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #438 commit f46bcd894019e2e893133f8f0c7509f6a93aa300 Author: James E. King, III jim.k...@simplivity.com Date: 2015-04-13T14:35:19Z THRIFT-3071 fix bootstrap.sh on MinGW --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3071) bootstrap.sh on Ubuntu 12.04 (Precise) automake error
[
https://issues.apache.org/jira/browse/THRIFT-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492459#comment-14492459
]
ASF GitHub Bot commented on THRIFT-3071:
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/438
THRIFT-3071 fix bootstrap.sh on MinGW
Fixes an issue I introduced in bootstrap.sh that depended on rev, an
executable not normally available in MinGW or MSYS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3071-on-mingw
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
commit f46bcd894019e2e893133f8f0c7509f6a93aa300
Author: James E. King, III jim.k...@simplivity.com
Date: 2015-04-13T14:35:19Z
THRIFT-3071 fix bootstrap.sh on MinGW
bootstrap.sh on Ubuntu 12.04 (Precise) automake error
-
Key: THRIFT-3071
URL: https://issues.apache.org/jira/browse/THRIFT-3071
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.9.3
Environment: Ubuntu 12.04.1 LTS
Reporter: James E. King, III
Assignee: Jens Geyer
Priority: Minor
Fix For: 0.9.3
Ubuntu 12.04 contains automake-1.11, and the bootstrap.sh script requires
1.13 or later:
{code}
~/dev/thrift$ ./bootstrap.sh
configure.ac:103: warning: macro `AM_EXTRA_RECURSIVE_TARGETS' not found in
library
configure.ac:103: error: possibly undefined macro: AM_EXTRA_RECURSIVE_TARGETS
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.{code}
A workaround for this issue is to install automake-1.14 via community PPA:
{noformat}
# add-apt-repository ppa:dns/gnu
# apt-get update
# apt-get install automake
{noformat}
bootstrap.sh should check the version of automake and emit a nicer error
message when 1.13 or later is not available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3071) bootstrap.sh on Ubuntu 12.04 (Precise) automake error
[
https://issues.apache.org/jira/browse/THRIFT-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492406#comment-14492406
]
James E. King, III commented on THRIFT-3071:
Please reject/re-open this issue. After testing on Windows with MINGW/MSYS and
MSYSGIT I have found that the command rev does not exist there, and the fix I
put in depends on rev. Thanks.
bootstrap.sh on Ubuntu 12.04 (Precise) automake error
-
Key: THRIFT-3071
URL: https://issues.apache.org/jira/browse/THRIFT-3071
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.9.3
Environment: Ubuntu 12.04.1 LTS
Reporter: James E. King, III
Assignee: Jens Geyer
Priority: Minor
Fix For: 0.9.3
Ubuntu 12.04 contains automake-1.11, and the bootstrap.sh script requires
1.13 or later:
{code}
~/dev/thrift$ ./bootstrap.sh
configure.ac:103: warning: macro `AM_EXTRA_RECURSIVE_TARGETS' not found in
library
configure.ac:103: error: possibly undefined macro: AM_EXTRA_RECURSIVE_TARGETS
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.{code}
A workaround for this issue is to install automake-1.14 via community PPA:
{noformat}
# add-apt-repository ppa:dns/gnu
# apt-get update
# apt-get install automake
{noformat}
bootstrap.sh should check the version of automake and emit a nicer error
message when 1.13 or later is not available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3094: --- Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. was: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3094: --- Root cause appears to be: commit 2659381e7f94b825c0b1ff6e80a119035a4a0de5 Author: Roger Meier ro...@apache.org Date: Sun Apr 12 16:10:35 2015 +0200 THRIFT-2850 CMake for Apache Thrift add test/cpp and lib/py This change added test/cpp at the top level of the CMakeLists.txt chain and the definition for -DUSE_BOOST_THREAD=1 is set inside the CMakeLists.txt inside lib/cpp. It looks like those thread type definitions need to come up to the top level CMakeLists.txt so that everything built will share it. Working on a patch. master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3094 fix broken cmake build of C++ lib...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/439 THRIFT-3094 fix broken cmake build of C++ library with alternate threading You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3094-cmake-build-alt-threading Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #439 commit f231b4450cdac437aaf3324503d85cb8325f8d6a Author: Jim King jim.k...@simplivity.com Date: 2015-04-13T16:25:35Z THRIFT-3094 fix broken cmake build of C++ library with alternate threading --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
[ https://issues.apache.org/jira/browse/THRIFT-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492588#comment-14492588 ] ASF GitHub Bot commented on THRIFT-3094: GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/439 THRIFT-3094 fix broken cmake build of C++ library with alternate threading You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3094-cmake-build-alt-threading Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #439 commit f231b4450cdac437aaf3324503d85cb8325f8d6a Author: Jim King jim.k...@simplivity.com Date: 2015-04-13T16:25:35Z THRIFT-3094 fix broken cmake build of C++ library with alternate threading master as of 2015-APR-13 fails -DBOOST_THREADS cmake build -- Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Also fails on Ubuntu 12.04.1 LTS. Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3094) master as of 2015-APR-13 fails -DBOOST_THREADS cmake build
James E. King, III created THRIFT-3094: -- Summary: master as of 2015-APR-13 fails -DBOOST_THREADS cmake build Key: THRIFT-3094 URL: https://issues.apache.org/jira/browse/THRIFT-3094 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.3 Environment: Travis CI cmake build with the options: export CMAKE_CONFIG=-DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_BOOSTTHREADS=ON export CMAKE_CONFIG=-DCMAKE_CXX_FLAGS=-std=c++0x -DWITH_C_GLIB=OFF -DWITH_JAVA=OFF -DWITH_STDTHREADS=ON Reporter: James E. King, III Priority: Blocker As seen in Build 1196 (https://travis-ci.org/apache/thrift/builds/58288894) two cmake builds are failing and I was able to reproduce it locally: Linking CXX executable ../../bin/StressTest Linking CXX executable ../../bin/StressTestNonBlocking CMakeFiles/StressTest.dir/src/StressTest.cpp.o:StressTest.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTest] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 85%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/OptionalRequiredTest_types.cpp.o [ 86%] Building CXX object lib/cpp/test/CMakeFiles/testgencpp.dir/gen-cpp/Recursive_types.cpp.o CMakeFiles/StressTestNonBlocking.dir/src/StressTestNonBlocking.cpp.o:StressTestNonBlocking.cpp:function main: error: undefined reference to 'apache::thrift::concurrency::PosixThreadFactory::PosixThreadFactory(apache::thrift::concurrency::PosixThreadFactory::POLICY, apache::thrift::concurrency::PosixThreadFactory::PRIORITY, int, bool)' collect2: ld returned 1 exit status make[2]: *** [bin/StressTestNonBlocking] Error 1 make[1]: *** [test/cpp/CMakeFiles/StressTestNonBlocking.dir/all] Error 2 Was Travis CI recently changed to make these mandatory build jobs when they were optional before? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3071) bootstrap.sh on Ubuntu 12.04 (Precise) automake error
[
https://issues.apache.org/jira/browse/THRIFT-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492510#comment-14492510
]
ASF GitHub Bot commented on THRIFT-3071:
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/438
THRIFT-3071 fix bootstrap.sh on MinGW
Fixes an issue I introduced in bootstrap.sh that depended on rev, an
executable not normally available in MinGW or MSYS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3071-on-mingw
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
commit f46bcd894019e2e893133f8f0c7509f6a93aa300
Author: James E. King, III jim.k...@simplivity.com
Date: 2015-04-13T14:35:19Z
THRIFT-3071 fix bootstrap.sh on MinGW
bootstrap.sh on Ubuntu 12.04 (Precise) automake error
-
Key: THRIFT-3071
URL: https://issues.apache.org/jira/browse/THRIFT-3071
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.9.3
Environment: Ubuntu 12.04.1 LTS
Reporter: James E. King, III
Assignee: Jens Geyer
Priority: Minor
Fix For: 0.9.3
Ubuntu 12.04 contains automake-1.11, and the bootstrap.sh script requires
1.13 or later:
{code}
~/dev/thrift$ ./bootstrap.sh
configure.ac:103: warning: macro `AM_EXTRA_RECURSIVE_TARGETS' not found in
library
configure.ac:103: error: possibly undefined macro: AM_EXTRA_RECURSIVE_TARGETS
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.{code}
A workaround for this issue is to install automake-1.14 via community PPA:
{noformat}
# add-apt-repository ppa:dns/gnu
# apt-get update
# apt-get install automake
{noformat}
bootstrap.sh should check the version of automake and emit a nicer error
message when 1.13 or later is not available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3071 fix bootstrap.sh on MinGW
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/438 THRIFT-3071 fix bootstrap.sh on MinGW Fixes an issue I introduced in bootstrap.sh that depended on rev, an executable not normally available in MinGW or MSYS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3071-on-mingw Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/438.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #438 commit f46bcd894019e2e893133f8f0c7509f6a93aa300 Author: James E. King, III jim.k...@simplivity.com Date: 2015-04-13T14:35:19Z THRIFT-3071 fix bootstrap.sh on MinGW --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3071) bootstrap.sh on Ubuntu 12.04 (Precise) automake error
[
https://issues.apache.org/jira/browse/THRIFT-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492509#comment-14492509
]
ASF GitHub Bot commented on THRIFT-3071:
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/438
bootstrap.sh on Ubuntu 12.04 (Precise) automake error
-
Key: THRIFT-3071
URL: https://issues.apache.org/jira/browse/THRIFT-3071
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.9.3
Environment: Ubuntu 12.04.1 LTS
Reporter: James E. King, III
Assignee: Jens Geyer
Priority: Minor
Fix For: 0.9.3
Ubuntu 12.04 contains automake-1.11, and the bootstrap.sh script requires
1.13 or later:
{code}
~/dev/thrift$ ./bootstrap.sh
configure.ac:103: warning: macro `AM_EXTRA_RECURSIVE_TARGETS' not found in
library
configure.ac:103: error: possibly undefined macro: AM_EXTRA_RECURSIVE_TARGETS
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.{code}
A workaround for this issue is to install automake-1.14 via community PPA:
{noformat}
# add-apt-repository ppa:dns/gnu
# apt-get update
# apt-get install automake
{noformat}
bootstrap.sh should check the version of automake and emit a nicer error
message when 1.13 or later is not available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
