[jira] [Commented] (THRIFT-3787) Node.js Connection object doesn't handle errors correctly

2016-05-05 Thread Randy Abernethy (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273565#comment-15273565
 ] 

Randy Abernethy commented on THRIFT-3787:
-

Hey James,

Regarding this particular hunk, from the Node docs:

"For all EventEmitter objects, if an 'error' event handler is not provided, the 
error will be thrown, causing the Node.js process to report an unhandled 
exception and crash unless either: The domain module is used appropriately or a 
handler has been registered for the process.on('uncaughtException') event."

So while this code predates me I think it was trying to protect user code from 
spurious exceptions. Unless you have a different view I'd rather leave this 
hunk in place (until we get your deep refactor!). 

The other changes look good (particularly the ssl test below). Let me know if 
you want to commit the other hunks. 

-Randy 


> Node.js Connection object doesn't handle errors correctly
> -
>
> Key: THRIFT-3787
> URL: https://issues.apache.org/jira/browse/THRIFT-3787
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Reporter: James Reggio
>Assignee: Randy Abernethy
>Priority: Minor
>
> There are a handful of operation-ordering problems in the 
> Connection.prototype.connection_gone() method and its friends.
> See the pull request for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-3814) Fix contention in TNonblockingServerTest

2016-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273558#comment-15273558
 ] 

ASF GitHub Bot commented on THRIFT-3814:


Github user nsuke commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1005#discussion_r62283672
  
--- Diff: lib/cpp/test/TNonblockingServerTest.cpp ---
@@ -47,14 +47,32 @@ struct Handler : public test::ParentServiceIf {
 class Fixture {
 private:
   struct Runner : public apache::thrift::concurrency::Runnable {
+int port;
+boost::shared_ptr userEventBase;
+boost::shared_ptr processor;
 boost::shared_ptr server;
-bool error;
+
 virtual void run() {
-  error = false;
+  // When binding to explicit port, allow retrying to workaround bind 
failures on ports in use
+  int retryCount = port ? 10 : 0;
+  startServer(retryCount);
+}
+
+  private:
+void startServer(int retry_count) {
   try {
+server.reset(new server::TNonblockingServer(processor, port));
+if (userEventBase) {
+  server->registerEvents(userEventBase.get());
+}
 server->serve();
-  } catch (const TException&) {
-error = true;
+  } catch (const transport::TTransportException&) {
+if (retry_count > 0) {
+  ++port;
+  startServer(retry_count - 1);
+} else {
+  throw;
--- End diff --

It's a test failure so my intention here was "no need to catch" and let it 
die with std::terminate with exception log.
The original `error` flag was needed for retrying from the main thread.


> Fix contention in TNonblockingServerTest
> 
>
> Key: THRIFT-3814
> URL: https://issues.apache.org/jira/browse/THRIFT-3814
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library, Test Suite
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>  Labels: test-stability
>
> User provided event_base could possibly be deleted before the server.
> Hopefully this fixes the occasional failure on Travis-CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift pull request: THRIFT-3814 Fix contention in TNonblockingSer...

2016-05-05 Thread nsuke
Github user nsuke commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1005#discussion_r62283672
  
--- Diff: lib/cpp/test/TNonblockingServerTest.cpp ---
@@ -47,14 +47,32 @@ struct Handler : public test::ParentServiceIf {
 class Fixture {
 private:
   struct Runner : public apache::thrift::concurrency::Runnable {
+int port;
+boost::shared_ptr userEventBase;
+boost::shared_ptr processor;
 boost::shared_ptr server;
-bool error;
+
 virtual void run() {
-  error = false;
+  // When binding to explicit port, allow retrying to workaround bind 
failures on ports in use
+  int retryCount = port ? 10 : 0;
+  startServer(retryCount);
+}
+
+  private:
+void startServer(int retry_count) {
   try {
+server.reset(new server::TNonblockingServer(processor, port));
+if (userEventBase) {
+  server->registerEvents(userEventBase.get());
+}
 server->serve();
-  } catch (const TException&) {
-error = true;
+  } catch (const transport::TTransportException&) {
+if (retry_count > 0) {
+  ++port;
+  startServer(retry_count - 1);
+} else {
+  throw;
--- End diff --

It's a test failure so my intention here was "no need to catch" and let it 
die with std::terminate with exception log.
The original `error` flag was needed for retrying from the main thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (THRIFT-3789) Node.js lacks ability to destroy connection

2016-05-05 Thread Randy Abernethy (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Randy Abernethy resolved THRIFT-3789.
-
   Resolution: Fixed
Fix Version/s: 0.10.0

committed

> Node.js lacks ability to destroy connection
> ---
>
> Key: THRIFT-3789
> URL: https://issues.apache.org/jira/browse/THRIFT-3789
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Reporter: James Reggio
>Assignee: Randy Abernethy
>Priority: Trivial
> Fix For: 0.10.0
>
>
> At present, there is no means for destroying the socket underlying a Node.js 
> Thrift Connection. When using TLS, If the socket fails to connect, calling 
> end() is insufficient to release its resources. (end() sends a FIN packet, 
> which is never acknowledged, holding the socket open.) This unreleased socket 
> will prevent Node.js from exiting cleanly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-3789) Node.js lacks ability to destroy connection

2016-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273511#comment-15273511
 ] 

ASF GitHub Bot commented on THRIFT-3789:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/989


> Node.js lacks ability to destroy connection
> ---
>
> Key: THRIFT-3789
> URL: https://issues.apache.org/jira/browse/THRIFT-3789
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Reporter: James Reggio
>Assignee: Randy Abernethy
>Priority: Trivial
> Fix For: 0.10.0
>
>
> At present, there is no means for destroying the socket underlying a Node.js 
> Thrift Connection. When using TLS, If the socket fails to connect, calling 
> end() is insufficient to release its resources. (end() sends a FIN packet, 
> which is never acknowledged, holding the socket open.) This unreleased socket 
> will prevent Node.js from exiting cleanly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift pull request: THRIFT-3789 Add `destroy` to Connection insta...

2016-05-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/989


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3814) Fix contention in TNonblockingServerTest

2016-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273433#comment-15273433
 ] 

ASF GitHub Bot commented on THRIFT-3814:


Github user tpcwang commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1005#discussion_r62278341
  
--- Diff: lib/cpp/test/TNonblockingServerTest.cpp ---
@@ -47,14 +47,32 @@ struct Handler : public test::ParentServiceIf {
 class Fixture {
 private:
   struct Runner : public apache::thrift::concurrency::Runnable {
+int port;
+boost::shared_ptr userEventBase;
+boost::shared_ptr processor;
 boost::shared_ptr server;
-bool error;
+
 virtual void run() {
-  error = false;
+  // When binding to explicit port, allow retrying to workaround bind 
failures on ports in use
+  int retryCount = port ? 10 : 0;
+  startServer(retryCount);
+}
+
+  private:
+void startServer(int retry_count) {
   try {
+server.reset(new server::TNonblockingServer(processor, port));
+if (userEventBase) {
+  server->registerEvents(userEventBase.get());
+}
 server->serve();
-  } catch (const TException&) {
-error = true;
+  } catch (const transport::TTransportException&) {
+if (retry_count > 0) {
+  ++port;
+  startServer(retry_count - 1);
+} else {
+  throw;
--- End diff --

Seems bad to throw an unhandled exception from a thread, but maybe this is 
catastrophic and rare enough that this is fine? The rest of the change looks 
good to me.


> Fix contention in TNonblockingServerTest
> 
>
> Key: THRIFT-3814
> URL: https://issues.apache.org/jira/browse/THRIFT-3814
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library, Test Suite
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>  Labels: test-stability
>
> User provided event_base could possibly be deleted before the server.
> Hopefully this fixes the occasional failure on Travis-CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift pull request: THRIFT-3814 Fix contention in TNonblockingSer...

2016-05-05 Thread tpcwang
Github user tpcwang commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1005#discussion_r62278341
  
--- Diff: lib/cpp/test/TNonblockingServerTest.cpp ---
@@ -47,14 +47,32 @@ struct Handler : public test::ParentServiceIf {
 class Fixture {
 private:
   struct Runner : public apache::thrift::concurrency::Runnable {
+int port;
+boost::shared_ptr userEventBase;
+boost::shared_ptr processor;
 boost::shared_ptr server;
-bool error;
+
 virtual void run() {
-  error = false;
+  // When binding to explicit port, allow retrying to workaround bind 
failures on ports in use
+  int retryCount = port ? 10 : 0;
+  startServer(retryCount);
+}
+
+  private:
+void startServer(int retry_count) {
   try {
+server.reset(new server::TNonblockingServer(processor, port));
+if (userEventBase) {
+  server->registerEvents(userEventBase.get());
+}
 server->serve();
-  } catch (const TException&) {
-error = true;
+  } catch (const transport::TTransportException&) {
+if (retry_count > 0) {
+  ++port;
+  startServer(retry_count - 1);
+} else {
+  throw;
--- End diff --

Seems bad to throw an unhandled exception from a thread, but maybe this is 
catastrophic and rare enough that this is fine? The rest of the change looks 
good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Which openssl revision from GIT repo?

2016-05-05 Thread David Wright
I have downloaded thrift-0.9.3.exe and generated from a thrift file - I
would now like to compile the dependant C++ library to get my C++ client
talking to my Erlang server.

 

I have obtained openssl and am having trouble working out which revision
to use - there are many and the two I have tried against thrift (0.9.3)
fails to compile - "CRYPTO_LOCK undefined"?

 

Can anyone point me to which version of openssl is supposed to work with
thrift 0.9.3 release?

 

I am attempting this on Ubuntu 14.04 LTS and Windows 10.

 

David Gray Wright



[jira] [Assigned] (THRIFT-3789) Node.js lacks ability to destroy connection

2016-05-05 Thread Randy Abernethy (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Randy Abernethy reassigned THRIFT-3789:
---

Assignee: Randy Abernethy

> Node.js lacks ability to destroy connection
> ---
>
> Key: THRIFT-3789
> URL: https://issues.apache.org/jira/browse/THRIFT-3789
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Reporter: James Reggio
>Assignee: Randy Abernethy
>Priority: Trivial
>
> At present, there is no means for destroying the socket underlying a Node.js 
> Thrift Connection. When using TLS, If the socket fails to connect, calling 
> end() is insufficient to release its resources. (end() sends a FIN packet, 
> which is never acknowledged, holding the socket open.) This unreleased socket 
> will prevent Node.js from exiting cleanly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (THRIFT-3787) Node.js Connection object doesn't handle errors correctly

2016-05-05 Thread Randy Abernethy (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Randy Abernethy reassigned THRIFT-3787:
---

Assignee: Randy Abernethy

> Node.js Connection object doesn't handle errors correctly
> -
>
> Key: THRIFT-3787
> URL: https://issues.apache.org/jira/browse/THRIFT-3787
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Reporter: James Reggio
>Assignee: Randy Abernethy
>Priority: Minor
>
> There are a handful of operation-ordering problems in the 
> Connection.prototype.connection_gone() method and its friends.
> See the pull request for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-3817) Redeclaration of std::tuple

2016-05-05 Thread Kyle Johnson (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272628#comment-15272628
 ] 

Kyle Johnson commented on THRIFT-3817:
--

The easiest way is generate a pull request from a fork of the thrift project on 
Github.  That process and the patch upload method to contributing fixes can be 
found here: https://github.com/apache/thrift/blob/master/doc/committers.md.

> Redeclaration of std::tuple 
> 
>
> Key: THRIFT-3817
> URL: https://issues.apache.org/jira/browse/THRIFT-3817
> Project: Thrift
>  Issue Type: Bug
>Affects Versions: 0.9.3
>Reporter: Kurt Johnson
>
> In /lib/cpp/src/thrift/cxxfunctional.h, the version of the functional header 
> is picked based on the compiler. Gcc defaults to . This 
> includes the  which causes a redeclaration error if the c++11 
>  has been used anywhere else.
> Thrift should default to using c++11 version of functional if the compiler 
> supports it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-3817) Redeclaration of std::tuple

2016-05-05 Thread Kurt Johnson (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272492#comment-15272492
 ] 

Kurt Johnson commented on THRIFT-3817:
--

I have a patch file available but I'm unable to find a way of uploading it.

> Redeclaration of std::tuple 
> 
>
> Key: THRIFT-3817
> URL: https://issues.apache.org/jira/browse/THRIFT-3817
> Project: Thrift
>  Issue Type: Bug
>Affects Versions: 0.9.3
>Reporter: Kurt Johnson
>
> In /lib/cpp/src/thrift/cxxfunctional.h, the version of the functional header 
> is picked based on the compiler. Gcc defaults to . This 
> includes the  which causes a redeclaration error if the c++11 
>  has been used anywhere else.
> Thrift should default to using c++11 version of functional if the compiler 
> supports it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (THRIFT-3817) Redeclaration of std::tuple

2016-05-05 Thread Kurt Johnson (JIRA)
Kurt Johnson created THRIFT-3817:


 Summary: Redeclaration of std::tuple 
 Key: THRIFT-3817
 URL: https://issues.apache.org/jira/browse/THRIFT-3817
 Project: Thrift
  Issue Type: Bug
Affects Versions: 0.9.3
Reporter: Kurt Johnson


In /lib/cpp/src/thrift/cxxfunctional.h, the version of the functional header is 
picked based on the compiler. Gcc defaults to . This includes 
the  which causes a redeclaration error if the c++11  has 
been used anywhere else.

Thrift should default to using c++11 version of functional if the compiler 
supports it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


FW: Build failed in Jenkins: Thrift-precommit #460

2016-05-05 Thread Jim King
It looks like we're trying to be too fancy with the apache Jenkins build job 
with rev-parse, reset, tags, or whatever we're doing there.
Is the Jenkins job script in the project or does one need access to the Jenkins 
environment to make a change like this?
Can we try this for the build job?

1. Blow away everything there.
2. Clone the repo.
3. Check out master (should be the default).
4. Check out to a new branch merge/thrift-precommit-460 (use the build number) 
- this will never get pushed
5. git fetch (the incoming branch)
6. git merge FETCH_HEAD, and assuming it succeeds:
7. Build the project and run tests.

This will bypass any rev-parse and reset and tagging, and simply apply the 
incoming change to master and ensure it passes a build.

The next build will, at step 1, eliminate whatever was there from the last 
build.
What would be even better than item #1 is that if the build slave is a VM, you 
would take a snap of the VM before you start and roll back to the snap when you 
are done.
That, or have the apache Jenkins build use a docker environment to run the 
build.

- Jim

-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] 
Sent: Thursday, May 05, 2016 4:12 AM
To: dev@thrift.apache.org
Subject: Build failed in Jenkins: Thrift-precommit #460

See 

--
GitHub pull request #1,007 to apache/thrift [EnvInject] - Loading node 
environment variables.
Building remotely on H11 (docker Ubuntu ubuntu yahoo-not-h2) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/apache/thrift.git
 > git init  # 
 > timeout=10 Fetching upstream changes from 
 > https://github.com/apache/thrift.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10  > git config --add remote.origin.fetch 
 > +refs/heads/*:refs/remotes/origin/* # timeout=10  > git config 
 > remote.origin.url https://github.com/apache/thrift.git # timeout=10 Fetching 
 > upstream changes from https://github.com/apache/thrift.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10  > git checkout -f origin/master 
 > # timeout=10  > git branch -a # timeout=10  > git rev-parse 
 > remotes/origin/0.1.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.2.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.3.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.4.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.5.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.6.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.7.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.8.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.9.1^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.9.2^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.9.3^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/0.9.x^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/master^{commit} # timeout=10  > git rev-parse 
 > remotes/origin/py-compiler^{commit} # timeout=10  > git checkout -b master 
 > origin/master
  Opening connection
Done: 0
  Counting objects
Done: 23
  Finding sources
Done: 23
  Getting sizes
Done: 18
  Compressing objects
Done: 10202
  Writing objects
Done: 23
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/460
 > git rev-parse refs/tags/changes/460^{commit} # timeout=10
FATAL: Command "git rev-parse refs/tags/changes/460^{commit}" returned status 
code 128:
stdout: refs/tags/changes/460^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/460^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

hudson.plugins.git.GitException: Command "git rev-parse 
refs/tags/changes/460^{commit}" returned status code 128:
stdout: refs/tags/changes/460^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/460^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1693)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 

Build failed in Jenkins: Thrift-precommit #463

2016-05-05 Thread Apache Jenkins Server
See 

--
GitHub pull request #1,005 to apache/thrift
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-4 (docker Ubuntu ubuntu4 ubuntu yahoo-not-h2) in 
workspace 
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/apache/thrift.git
 > git init  # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10
 > git checkout -f origin/master # timeout=10
 > git branch -a # timeout=10
 > git rev-parse remotes/origin/0.1.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.2.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.3.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.4.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.5.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.6.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.7.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.8.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.1^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.2^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.3^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.x^{commit} # timeout=10
 > git rev-parse remotes/origin/master^{commit} # timeout=10
 > git rev-parse remotes/origin/py-compiler^{commit} # timeout=10
 > git checkout -b master origin/master
  Opening connection
Done: 0
  Counting objects
Done: 10
  Finding sources
Done: 10
  Getting sizes
Done: 9
  Compressing objects
Done: 0
  Writing objects
Done: 10
  remote: Updating references
Merging refs/tags/changes/463
 > git rev-parse refs/tags/changes/463^{commit} # timeout=10
FATAL: Command "git rev-parse refs/tags/changes/463^{commit}" returned status 
code 128:
stdout: refs/tags/changes/463^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/463^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

hudson.plugins.git.GitException: Command "git rev-parse 
refs/tags/changes/463^{commit}" returned status code 128:
stdout: refs/tags/changes/463^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/463^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1693)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1319)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.revParse(GitAPI.java:316)
at sun.reflect.GeneratedMethodAccessor84.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:608)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:583)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:542)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at 

[jira] [Updated] (THRIFT-3816) Reduce docker build duration on Travis-CI

2016-05-05 Thread Aki Sukegawa (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa updated THRIFT-3816:
-
Description: 
cross test jobs on Travis-CI are frequently hitting 50 min limit.
For now, reducing docker build time by several minutes should fix it.

Dockerfile changes:

* buildpack-deps base image for fewer apt packages
  https://hub.docker.com/_/buildpack-deps

* fewer apt-get packages
  It would cause problem for retrying. in that case we can split them again

.travis.yml changes:

* remove "docker pull" because cache can no longer be reused because of docker 
change

  was:
cross test jobs on Travis-CI are frequently hitting 50 min limit.
For now, reducing docker build time by several minutes should fix it.

Dockerfile changes:

* buildpack-deps base image for fewer apt packages
  https://hub.docker.com/_/buildpack-deps

* one-off apt-get/yum
  It would cause problem for retrying. in that case we can split them again

.travis.yml changes:

* remove "docker pull" because cache can no longer be reused because of docker 
change


> Reduce docker build duration on Travis-CI
> -
>
> Key: THRIFT-3816
> URL: https://issues.apache.org/jira/browse/THRIFT-3816
> Project: Thrift
>  Issue Type: Improvement
>  Components: Build Process
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> cross test jobs on Travis-CI are frequently hitting 50 min limit.
> For now, reducing docker build time by several minutes should fix it.
> Dockerfile changes:
> * buildpack-deps base image for fewer apt packages
>   https://hub.docker.com/_/buildpack-deps
> * fewer apt-get packages
>   It would cause problem for retrying. in that case we can split them again
> .travis.yml changes:
> * remove "docker pull" because cache can no longer be reused because of 
> docker change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: Thrift-precommit #462

2016-05-05 Thread Apache Jenkins Server
See 

--
GitHub pull request #1,007 to apache/thrift
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-4 (docker Ubuntu ubuntu4 ubuntu yahoo-not-h2) in 
workspace 
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/apache/thrift.git
 > git init  # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10
 > git checkout -f origin/master # timeout=10
 > git branch -a # timeout=10
 > git rev-parse remotes/origin/0.1.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.2.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.3.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.4.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.5.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.6.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.7.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.8.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.1^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.2^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.3^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.x^{commit} # timeout=10
 > git rev-parse remotes/origin/master^{commit} # timeout=10
 > git rev-parse remotes/origin/py-compiler^{commit} # timeout=10
 > git checkout -b master origin/master
  Opening connection
Done: 0
  Counting objects
Done: 23
  Finding sources
Done: 23
  Getting sizes
Done: 17
  Compressing objects
Done: 0
  Writing objects
Done: 23
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/462
 > git rev-parse refs/tags/changes/462^{commit} # timeout=10
FATAL: Command "git rev-parse refs/tags/changes/462^{commit}" returned status 
code 128:
stdout: refs/tags/changes/462^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/462^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

hudson.plugins.git.GitException: Command "git rev-parse 
refs/tags/changes/462^{commit}" returned status code 128:
stdout: refs/tags/changes/462^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/462^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1693)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1319)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.revParse(GitAPI.java:316)
at sun.reflect.GeneratedMethodAccessor84.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:608)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:583)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:542)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at 

Build failed in Jenkins: Thrift-precommit #461

2016-05-05 Thread Apache Jenkins Server
See 

--
GitHub pull request #1,007 to apache/thrift
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-1 (docker Ubuntu ubuntu yahoo-not-h2 ubuntu1) in 
workspace 
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/apache/thrift.git
 > git init  # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10
 > git checkout -f origin/master # timeout=10
 > git branch -a # timeout=10
 > git rev-parse remotes/origin/0.1.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.2.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.3.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.4.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.5.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.6.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.7.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.8.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.1^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.2^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.3^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.x^{commit} # timeout=10
 > git rev-parse remotes/origin/master^{commit} # timeout=10
 > git rev-parse remotes/origin/py-compiler^{commit} # timeout=10
 > git checkout -b master origin/master
  Opening connection
Done: 0
  Counting objects
Done: 11
  Finding sources
Done: 11
  Getting sizes
Done: 9
  Compressing objects
Done: 7207
  Writing objects
Done: 11
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/461
 > git rev-parse refs/tags/changes/461^{commit} # timeout=10
FATAL: Command "git rev-parse refs/tags/changes/461^{commit}" returned status 
code 128:
stdout: refs/tags/changes/461^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/461^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

hudson.plugins.git.GitException: Command "git rev-parse 
refs/tags/changes/461^{commit}" returned status code 128:
stdout: refs/tags/changes/461^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/461^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1693)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1319)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.revParse(GitAPI.java:316)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:608)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:583)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:542)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 

Build failed in Jenkins: Thrift-precommit #460

2016-05-05 Thread Apache Jenkins Server
See 

--
GitHub pull request #1,007 to apache/thrift
[EnvInject] - Loading node environment variables.
Building remotely on H11 (docker Ubuntu ubuntu yahoo-not-h2) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/apache/thrift.git
 > git init  # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10
 > git checkout -f origin/master # timeout=10
 > git branch -a # timeout=10
 > git rev-parse remotes/origin/0.1.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.2.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.3.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.4.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.5.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.6.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.7.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.8.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.1^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.2^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.3^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.x^{commit} # timeout=10
 > git rev-parse remotes/origin/master^{commit} # timeout=10
 > git rev-parse remotes/origin/py-compiler^{commit} # timeout=10
 > git checkout -b master origin/master
  Opening connection
Done: 0
  Counting objects
Done: 23
  Finding sources
Done: 23
  Getting sizes
Done: 18
  Compressing objects
Done: 10202
  Writing objects
Done: 23
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/460
 > git rev-parse refs/tags/changes/460^{commit} # timeout=10
FATAL: Command "git rev-parse refs/tags/changes/460^{commit}" returned status 
code 128:
stdout: refs/tags/changes/460^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/460^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

hudson.plugins.git.GitException: Command "git rev-parse 
refs/tags/changes/460^{commit}" returned status code 128:
stdout: refs/tags/changes/460^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/460^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1693)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1319)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.revParse(GitAPI.java:316)
at sun.reflect.GeneratedMethodAccessor200.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:608)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:583)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:542)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at 

Build failed in Jenkins: Thrift-precommit #458

2016-05-05 Thread Apache Jenkins Server
See 

--
GitHub pull request #1,005 to apache/thrift
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-6 (docker Ubuntu ubuntu yahoo-not-h2) in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/apache/thrift.git
 > git init  # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10
 > git checkout -f origin/master # timeout=10
 > git branch -a # timeout=10
 > git rev-parse remotes/origin/0.1.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.2.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.3.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.4.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.5.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.6.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.7.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.8.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.1^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.2^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.3^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.x^{commit} # timeout=10
 > git rev-parse remotes/origin/master^{commit} # timeout=10
 > git rev-parse remotes/origin/py-compiler^{commit} # timeout=10
 > git checkout -b master origin/master
  Opening connection
Done: 0
  Counting objects
Done: 9
  Finding sources
Done: 9
  Getting sizes
Done: 7
  Compressing objects
Done: 0
  Writing objects
Done: 9
  remote: Updating references
Merging refs/tags/changes/458
 > git rev-parse refs/tags/changes/458^{commit} # timeout=10
FATAL: Command "git rev-parse refs/tags/changes/458^{commit}" returned status 
code 128:
stdout: refs/tags/changes/458^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/458^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

hudson.plugins.git.GitException: Command "git rev-parse 
refs/tags/changes/458^{commit}" returned status code 128:
stdout: refs/tags/changes/458^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/458^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1693)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1319)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.revParse(GitAPI.java:316)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:608)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:583)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:542)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 

[jira] [Commented] (THRIFT-3816) Reduce docker build duration on Travis-CI

2016-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272053#comment-15272053
 ] 

ASF GitHub Bot commented on THRIFT-3816:


GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/1007

THRIFT-3816 Reduce docker build duration on Travis-CI



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3816

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1007


commit a49eddaf36a99dc86929c5181c0e128492ca61d4
Author: Nobuaki Sukegawa 
Date:   2016-05-05T06:38:15Z

THRIFT-3816 Reduce docker build duration on Travis-CI




> Reduce docker build duration on Travis-CI
> -
>
> Key: THRIFT-3816
> URL: https://issues.apache.org/jira/browse/THRIFT-3816
> Project: Thrift
>  Issue Type: Improvement
>  Components: Build Process
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> cross test jobs on Travis-CI are frequently hitting 50 min limit.
> For now, reducing docker build time by several minutes should fix it.
> Dockerfile changes:
> * buildpack-deps base image for fewer apt packages
>   https://hub.docker.com/_/buildpack-deps
> * one-off apt-get/yum
>   It would cause problem for retrying. in that case we can split them again
> .travis.yml changes:
> * remove "docker pull" because cache can no longer be reused because of 
> docker change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: Thrift-precommit #459

2016-05-05 Thread Apache Jenkins Server
See 

--
GitHub pull request #1,006 to apache/thrift
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-1 (docker Ubuntu ubuntu yahoo-not-h2 ubuntu1) in 
workspace 
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/apache/thrift.git
 > git init  # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url https://github.com/apache/thrift.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/thrift.git
 > git -c core.askpass=true fetch --tags --progress 
 > https://github.com/apache/thrift.git +refs/heads/*:refs/remotes/origin/*
 > git config core.sparsecheckout # timeout=10
 > git checkout -f origin/master # timeout=10
 > git branch -a # timeout=10
 > git rev-parse remotes/origin/0.1.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.2.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.3.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.4.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.5.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.6.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.7.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.8.x^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.1^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.2^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.3^{commit} # timeout=10
 > git rev-parse remotes/origin/0.9.x^{commit} # timeout=10
 > git rev-parse remotes/origin/master^{commit} # timeout=10
 > git rev-parse remotes/origin/py-compiler^{commit} # timeout=10
 > git checkout -b master origin/master
  Opening connection
Done: 0
  Counting objects
Done: 13
  Finding sources
Done: 13
  Getting sizes
Done: 8
  Compressing objects
Done: 0
  Writing objects
Done: 13
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/459
 > git rev-parse refs/tags/changes/459^{commit} # timeout=10
FATAL: Command "git rev-parse refs/tags/changes/459^{commit}" returned status 
code 128:
stdout: refs/tags/changes/459^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/459^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

hudson.plugins.git.GitException: Command "git rev-parse 
refs/tags/changes/459^{commit}" returned status code 128:
stdout: refs/tags/changes/459^{commit}

stderr: fatal: ambiguous argument 'refs/tags/changes/459^{commit}': unknown 
revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1693)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1669)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1665)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1307)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1319)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.revParse(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.revParse(GitAPI.java:316)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:608)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:583)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:542)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 

[GitHub] thrift pull request: THRIFT-3816 Reduce docker build duration on T...

2016-05-05 Thread nsuke
GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/1007

THRIFT-3816 Reduce docker build duration on Travis-CI



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3816

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1007


commit a49eddaf36a99dc86929c5181c0e128492ca61d4
Author: Nobuaki Sukegawa 
Date:   2016-05-05T06:38:15Z

THRIFT-3816 Reduce docker build duration on Travis-CI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3815) Put appveyor dependency versions to one place

2016-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272051#comment-15272051
 ] 

ASF GitHub Bot commented on THRIFT-3815:


GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/1006

THRIFT-3815 Put appveyor dependency versions to one place



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1006


commit fec03f8484d8bd7b871f9d394021537ea478ba38
Author: Nobuaki Sukegawa 
Date:   2016-04-18T00:42:23Z

THRIFT-3815 Put appveyor dependency versions to one place




> Put appveyor dependency versions to one place
> -
>
> Key: THRIFT-3815
> URL: https://issues.apache.org/jira/browse/THRIFT-3815
> Project: Thrift
>  Issue Type: Improvement
>  Components: Build Process
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>Priority: Trivial
>
> Putting library versions that are known to require manual updates to 
> environment variable, to make it slightly easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-3814) Fix contention in TNonblockingServerTest

2016-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272050#comment-15272050
 ] 

ASF GitHub Bot commented on THRIFT-3814:


GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/1005

THRIFT-3814 Fix contention in TNonblockingServerTest



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1005


commit b465de4a3f0bd89ce7e151ebc382b7f0d46af167
Author: Nobuaki Sukegawa 
Date:   2016-05-05T07:29:13Z

THRIFT-3814 Fix contention in TNonblockingServerTest




> Fix contention in TNonblockingServerTest
> 
>
> Key: THRIFT-3814
> URL: https://issues.apache.org/jira/browse/THRIFT-3814
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library, Test Suite
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>  Labels: test-stability
>
> User provided event_base could possibly be deleted before the server.
> Hopefully this fixes the occasional failure on Travis-CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift pull request: THRIFT-3815 Put appveyor dependency versions ...

2016-05-05 Thread nsuke
GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/1006

THRIFT-3815 Put appveyor dependency versions to one place



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1006


commit fec03f8484d8bd7b871f9d394021537ea478ba38
Author: Nobuaki Sukegawa 
Date:   2016-04-18T00:42:23Z

THRIFT-3815 Put appveyor dependency versions to one place




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (THRIFT-3816) Reduce docker build duration on Travis-CI

2016-05-05 Thread Aki Sukegawa (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa updated THRIFT-3816:
-
Description: 
cross test jobs on Travis-CI are frequently hitting 50 min limit.
For now, reducing docker build time by several minutes should fix it.

Dockerfile changes:

* buildpack-deps base image for fewer apt packages
  https://hub.docker.com/_/buildpack-deps

* one-off apt-get/yum
  It would cause problem for retrying. in that case we can split them again

.travis.yml changes:

* remove "docker pull" because cache can no longer be reused because of docker 
change

  was:
cross test jobs on Travis-CI are frequently hitting 50 min limit.
For now, reducing docker build time by several minutes should fix it.


> Reduce docker build duration on Travis-CI
> -
>
> Key: THRIFT-3816
> URL: https://issues.apache.org/jira/browse/THRIFT-3816
> Project: Thrift
>  Issue Type: Improvement
>  Components: Build Process
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> cross test jobs on Travis-CI are frequently hitting 50 min limit.
> For now, reducing docker build time by several minutes should fix it.
> Dockerfile changes:
> * buildpack-deps base image for fewer apt packages
>   https://hub.docker.com/_/buildpack-deps
> * one-off apt-get/yum
>   It would cause problem for retrying. in that case we can split them again
> .travis.yml changes:
> * remove "docker pull" because cache can no longer be reused because of 
> docker change



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift pull request: THRIFT-3814 Fix contention in TNonblockingSer...

2016-05-05 Thread nsuke
GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/1005

THRIFT-3814 Fix contention in TNonblockingServerTest



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1005


commit b465de4a3f0bd89ce7e151ebc382b7f0d46af167
Author: Nobuaki Sukegawa 
Date:   2016-05-05T07:29:13Z

THRIFT-3814 Fix contention in TNonblockingServerTest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (THRIFT-3816) Reduce docker build duration on Travis-CI

2016-05-05 Thread Aki Sukegawa (JIRA)
Aki Sukegawa created THRIFT-3816:


 Summary: Reduce docker build duration on Travis-CI
 Key: THRIFT-3816
 URL: https://issues.apache.org/jira/browse/THRIFT-3816
 Project: Thrift
  Issue Type: Improvement
  Components: Build Process
Reporter: Aki Sukegawa
Assignee: Aki Sukegawa


cross test jobs on Travis-CI are frequently hitting 50 min limit.
For now, reducing docker build time by several minutes should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (THRIFT-3815) Put appveyor dependency versions to one place

2016-05-05 Thread Aki Sukegawa (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa updated THRIFT-3815:
-
Issue Type: Improvement  (was: Bug)

> Put appveyor dependency versions to one place
> -
>
> Key: THRIFT-3815
> URL: https://issues.apache.org/jira/browse/THRIFT-3815
> Project: Thrift
>  Issue Type: Improvement
>  Components: Build Process
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>Priority: Trivial
>
> Putting library versions that are known to require manual updates to 
> environment variable, to make it slightly easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (THRIFT-3815) Put appveyor dependency versions to one place

2016-05-05 Thread Aki Sukegawa (JIRA)
Aki Sukegawa created THRIFT-3815:


 Summary: Put appveyor dependency versions to one place
 Key: THRIFT-3815
 URL: https://issues.apache.org/jira/browse/THRIFT-3815
 Project: Thrift
  Issue Type: Bug
  Components: Build Process
Reporter: Aki Sukegawa
Assignee: Aki Sukegawa
Priority: Trivial


Putting library versions that are known to require manual updates to 
environment variable, to make it slightly easier.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (THRIFT-3814) Fix contention in TNonblockingServerTest

2016-05-05 Thread Aki Sukegawa (JIRA)
Aki Sukegawa created THRIFT-3814:


 Summary: Fix contention in TNonblockingServerTest
 Key: THRIFT-3814
 URL: https://issues.apache.org/jira/browse/THRIFT-3814
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Library, Test Suite
Reporter: Aki Sukegawa
Assignee: Aki Sukegawa


User provided event_base could possibly be deleted before the server.
Hopefully this fixes the occasional failure on Travis-CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (THRIFT-3813) Appveyor builds reference an openssl version that is no longer there

2016-05-05 Thread Aki Sukegawa (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa resolved THRIFT-3813.
--
   Resolution: Fixed
Fix Version/s: 0.10.0

committed, thanks.

> Appveyor builds reference an openssl version that is no longer there
> 
>
> Key: THRIFT-3813
> URL: https://issues.apache.org/jira/browse/THRIFT-3813
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.10.0
> Environment: Appveyor CI
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Blocker
> Fix For: 0.10.0
>
>
> It looks like we download openssl 1.0.2g from an external site; the external 
> site has revved to 1.0.2h so we need to update our URL.  As a general 
> comment, our build should not depend on any external downloads or it will be 
> continue to be fragile in this way (also see THRIFT-3793).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-3813) Appveyor builds reference an openssl version that is no longer there

2016-05-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271969#comment-15271969
 ] 

ASF GitHub Bot commented on THRIFT-3813:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1004


> Appveyor builds reference an openssl version that is no longer there
> 
>
> Key: THRIFT-3813
> URL: https://issues.apache.org/jira/browse/THRIFT-3813
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.10.0
> Environment: Appveyor CI
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Blocker
>
> It looks like we download openssl 1.0.2g from an external site; the external 
> site has revved to 1.0.2h so we need to update our URL.  As a general 
> comment, our build should not depend on any external downloads or it will be 
> continue to be fragile in this way (also see THRIFT-3793).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift pull request: THRIFT-3813: fix appveyor dependency on exter...

2016-05-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1004


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---