[jira] [Commented] (THRIFT-4263) Fix use after free bug for thrown exceptions

2017-08-11 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123842#comment-16123842
 ] 

James E. King, III commented on THRIFT-4263:


Updating the distro used in the build process is a good idea.  We want coverage 
for some older environments however so we'll have to use a mixture of both.  
That deserves a separate story, however.  For this one, I was looking for 
documentation on zend_throw_exception_object and its requirements to verify 
your ownership assertions in the description however I could not find it?


> Fix use after free bug for thrown exceptions
> 
>
> Key: THRIFT-4263
> URL: https://issues.apache.org/jira/browse/THRIFT-4263
> Project: Thrift
>  Issue Type: Bug
>  Components: PHP - Library
>Affects Versions: 0.10.0, 0.11.0
> Environment: Verified both on Debian unstable and Centos 7 under 
> valgrind
>Reporter: Roy Sindre Norangshol
>Priority: Critical
>
> Fix use after free bug for thrown exceptions
> Exceptions thrown through PHPExceptionWrapper are prematurely freed at
> the end of the catch block, even though zend_throw_exception_object
> expects to take ownership of the value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4284) File contains a NBSP: lib/nodejs/lib/thrift/web_server.js

2017-08-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123806#comment-16123806
 ] 

ASF GitHub Bot commented on THRIFT-4284:


GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1330

THRIFT-4284: remove extraneous character



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4284

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1330


commit a6c075e38366b982dd2bbdae14fc38cb3b6a2845
Author: James E. King, III 
Date:   2017-08-11T18:30:41Z

THRIFT-4284: remove extraneous character




> File contains a NBSP: lib/nodejs/lib/thrift/web_server.js
> -
>
> Key: THRIFT-4284
> URL: https://issues.apache.org/jira/browse/THRIFT-4284
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.9.2, 0.9.3, 0.10.0
>Reporter: Claudio Procida
>Assignee: James E. King, III
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This file contains a non-breaking space ({{\u00a0}}): 
> {{lib/nodejs/lib/thrift/web_server.js}}
> We found the issue while bundling the npm module [thrift|https://npm.im] with 
> {{browserify}}, resulting into a syntax error in the browser.
> If you look at line 287 in [the raw 
> file|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD],
>  there is an {{'Â'}} character between a value and the next key. 
> Interestingly, the [web 
> UI|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD#l287]
>  doesn't show the issue.
> The [raw file on the GitHub 
> mirror|https://raw.githubusercontent.com/apache/thrift/master/lib/nodejs/lib/thrift/web_server.js]
>  is not garbled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (THRIFT-4284) File contains a NBSP: lib/nodejs/lib/thrift/web_server.js

2017-08-11 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4284:
--

Assignee: James E. King, III

> File contains a NBSP: lib/nodejs/lib/thrift/web_server.js
> -
>
> Key: THRIFT-4284
> URL: https://issues.apache.org/jira/browse/THRIFT-4284
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.9.2, 0.9.3, 0.10.0
>Reporter: Claudio Procida
>Assignee: James E. King, III
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This file contains a non-breaking space ({{\u00a0}}): 
> {{lib/nodejs/lib/thrift/web_server.js}}
> We found the issue while bundling the npm module [thrift|https://npm.im] with 
> {{browserify}}, resulting into a syntax error in the browser.
> If you look at line 287 in [the raw 
> file|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD],
>  there is an {{'Â'}} character between a value and the next key. 
> Interestingly, the [web 
> UI|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD#l287]
>  doesn't show the issue.
> The [raw file on the GitHub 
> mirror|https://raw.githubusercontent.com/apache/thrift/master/lib/nodejs/lib/thrift/web_server.js]
>  is not garbled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1330: THRIFT-4284: remove extraneous character

2017-08-11 Thread jeking3 
GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1330

THRIFT-4284: remove extraneous character



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4284

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1330


commit a6c075e38366b982dd2bbdae14fc38cb3b6a2845
Author: James E. King, III 
Date:   2017-08-11T18:30:41Z

THRIFT-4284: remove extraneous character




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4284) File contains a NBSP: lib/nodejs/lib/thrift/web_server.js

2017-08-11 Thread Jens Geyer (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123426#comment-16123426
 ] 

Jens Geyer commented on THRIFT-4284:


Hi, thanks for catching this. 

If you are able to provide a pull request, someone will take care of it.

http://thrift.apache.org/docs/HowToContribute



> File contains a NBSP: lib/nodejs/lib/thrift/web_server.js
> -
>
> Key: THRIFT-4284
> URL: https://issues.apache.org/jira/browse/THRIFT-4284
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.9.2, 0.9.3, 0.10.0
>Reporter: Claudio Procida
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This file contains a non-breaking space ({{\u00a0}}): 
> {{lib/nodejs/lib/thrift/web_server.js}}
> We found the issue while bundling the npm module [thrift|https://npm.im] with 
> {{browserify}}, resulting into a syntax error in the browser.
> If you look at line 287 in [the raw 
> file|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD],
>  there is an {{'Â'}} character between a value and the next key. 
> Interestingly, the [web 
> UI|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD#l287]
>  doesn't show the issue.
> The [raw file on the GitHub 
> mirror|https://raw.githubusercontent.com/apache/thrift/master/lib/nodejs/lib/thrift/web_server.js]
>  is not garbled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-3859) Unix Domain Socket Support in Objective-C

2017-08-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123324#comment-16123324
 ] 

ASF GitHub Bot commented on THRIFT-3859:


Github user gaoshanyu commented on the issue:

https://github.com/apache/thrift/pull/1031
  
Who can tell me why the cocoa lib has Swift2.3 codes? Where I can download 
full Objective-C lib? Or is there a way to make the lib to support Swift 3 +?


> Unix Domain Socket Support in Objective-C
> -
>
> Key: THRIFT-3859
> URL: https://issues.apache.org/jira/browse/THRIFT-3859
> Project: Thrift
>  Issue Type: Improvement
>  Components: Cocoa - Library
>Affects Versions: 0.10.0
>Reporter: Chris Vasselli
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> I would like to be able to use Unix Domain Sockets as the transport to 
> communicate between different processes on a single machine. There seems to 
> be support in the C++ and Python libraries (the two other languages used in 
> my project), but no support in Objective-C.
> Proposed server interface:
> {{TSocketServer *server = [[TSocketServer alloc] 
> initWithPath:@"/path/to/pipe" protocolFactory:protocolFactory 
> processorFactory:processorFactory];}}
> Proposed client interface:
> {{TSocketTransport *socket = [[TSocketTransport alloc] 
> initWithPath:@"/path/to/pipe"];}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

2017-08-11 Thread gaoshanyu 
Github user gaoshanyu commented on the issue:

https://github.com/apache/thrift/pull/1031
  
Who can tell me why the cocoa lib has Swift2.3 codes? Where I can download 
full Objective-C lib? Or is there a way to make the lib to support Swift 3 +?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---