[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.
[
https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654359#comment-16654359
]
ASF GitHub Bot commented on THRIFT-4207:
jeking3 commented on issue #1274: THRIFT-4207: Make sure Python Accelerated
protocol does not allow invalid UTF-8
URL: https://github.com/apache/thrift/pull/1274#issuecomment-430822209
Many projects are struggling with this. StackStorm and Ansible are good
examples. We need to continue to support 2.7 for a while longer. Until we can
drop 2.7 support and fully change everything over, we should either close this
out or change it so it works. From what I've seen in the description, it
sounds like even six wouldn't be able to fix this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Accelerated version of TBinaryProtocol allows invalid input to string fields.
> -
>
> Key: THRIFT-4207
> URL: https://issues.apache.org/jira/browse/THRIFT-4207
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
>Assignee: Aki Sukegawa
>Priority: Major
>
> {{TBinaryProtocolAccelerated}} and {{TCompactProtocolAccelerated}} currently
> accept arbitrary bytes as input to string fields even when {{py:utf8strings}}
> is on.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4382. --- Resolution: Fixed Fix Version/s: 1.0 This did not make it into 0.12.0 so I have marked it as being in 1.0 instead. > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Assignee: James E. King III >Priority: Minor > Fix For: 1.0 > > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[
https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654351#comment-16654351
]
ASF GitHub Bot commented on THRIFT-4382:
jeking3 closed pull request #1613: THRIFT-4382: Replace the use of Indirect
Object Syntax calls to new()
URL: https://github.com/apache/thrift/pull/1613
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/compiler/cpp/src/thrift/generate/t_perl_generator.cc
b/compiler/cpp/src/thrift/generate/t_perl_generator.cc
index 5a308cfea1..8924a76001 100644
--- a/compiler/cpp/src/thrift/generate/t_perl_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_perl_generator.cc
@@ -354,7 +354,7 @@ string t_perl_generator::render_const_value(t_type* type,
t_const_value* value)
} else if (type->is_enum()) {
out << value->get_integer();
} else if (type->is_struct() || type->is_xception()) {
-out << "new " << perl_namespace(type->get_program()) << type->get_name()
<< "({" << endl;
+out << perl_namespace(type->get_program()) << type->get_name() <<
"->new({" << endl;
indent_up();
const vector& fields = ((t_struct*)type)->get_members();
@@ -546,7 +546,7 @@ void t_perl_generator::generate_perl_struct_reader(ostream&
out, t_struct* tstru
indent(out) << "$xfer += $input->readStructBegin(\\$fname);" << endl;
// Loop over reading in fields
- indent(out) << "while (1) " << endl;
+ indent(out) << "while (1)" << endl;
scope_up(out);
@@ -758,7 +758,7 @@ void
t_perl_generator::generate_service_processor(t_service* tservice) {
f_service_ << indent() << "$input->skip(Thrift::TType::STRUCT);" << endl <<
indent()
<< "$input->readMessageEnd();" << endl << indent()
- << "my $x = new Thrift::TApplicationException('Function
'.$fname.' not implemented.', "
+ << "my $x = Thrift::TApplicationException->new('Function
'.$fname.' not implemented.', "
"Thrift::TApplicationException::UNKNOWN_METHOD);" << endl <<
indent()
<< "$output->writeMessageBegin($fname,
Thrift::TMessageType::EXCEPTION, $rseqid);" << endl
<< indent() << "$x->write($output);" << endl << indent()
@@ -798,7 +798,7 @@ void t_perl_generator::generate_process_function(t_service*
tservice, t_function
string resultname = perl_namespace(tservice->get_program()) + service_name_
+ "_"
+ tfunction->get_name() + "_result";
- f_service_ << indent() << "my $args = new " << argsname << "();" << endl <<
indent()
+ f_service_ << indent() << "my $args = " << argsname << "->new();" << endl <<
indent()
<< "$args->read($input);" << endl;
f_service_ << indent() << "$input->readMessageEnd();" << endl;
@@ -809,7 +809,7 @@ void t_perl_generator::generate_process_function(t_service*
tservice, t_function
// Declare result for non oneway function
if (!tfunction->is_oneway()) {
-f_service_ << indent() << "my $result = new " << resultname << "();" <<
endl;
+f_service_ << indent() << "my $result = " << resultname << "->new();" <<
endl;
}
// Try block for a function with exceptions
@@ -858,7 +858,7 @@ void t_perl_generator::generate_process_function(t_service*
tservice, t_function
f_service_ << indent() << "if ($@) {" << endl;
indent_up();
f_service_ << indent() << "$@ =~ s/^\\s+|\\s+$//g;" << endl
- << indent() << "my $err = new
Thrift::TApplicationException(\"Unexpected Exception: \" . $@,
Thrift::TApplicationException::INTERNAL_ERROR);" << endl
+ << indent() << "my $err =
Thrift::TApplicationException->new(\"Unexpected Exception: \" . $@,
Thrift::TApplicationException::INTERNAL_ERROR);" << endl
<< indent() << "$output->writeMessageBegin('" <<
tfunction->get_name() << "', Thrift::TMessageType::EXCEPTION, $seqid);" << endl
<< indent() << "$err->write($output);" << endl
<< indent() << "$output->writeMessageEnd();" << endl
@@ -1106,7 +1106,7 @@ void t_perl_generator::generate_service_client(t_service*
tservice) {
<< "', " << ((*f_iter)->is_oneway() ?
"Thrift::TMessageType::ONEWAY" : "Thrift::TMessageType::CALL")
<< ", $self->{seqid});" << endl;
-f_service_ << indent() << "my $args = new " << argsname << "();" << endl;
+f_service_ << indent() << "my $args = " << argsname << "->new();" << endl;
for (fld_iter = fields.begin(); fld_iter != fields.end(); ++fld_iter) {
f_service_ << indent() << "$args->{" << (*fld_iter)->get_name() << "} =
$"
@@ -1140,12 +1140,12 @@ void
t_perl_generator::generate_service_client(t_service* tservice) {
f_service_ << indent() <<
[jira] [Commented] (THRIFT-4652) Some go documentation on the website needs to be updated
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654189#comment-16654189
]
Can Celasun commented on THRIFT-4652:
-
Tried [updating the
tutorial|http://svn.apache.org/viewvc?view=revision=1844173], ran into
the same issue I [had the last
time|https://ci.apache.org/builders/thrift-site-staging/builds/58].
> Some go documentation on the website needs to be updated
>
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Documentation
> Components: Go - Library, Website
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Assignee: James E. King III
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654175#comment-16654175 ] ASF GitHub Bot commented on THRIFT-4382: djzort commented on issue #1613: THRIFT-4382: Replace the use of Indirect Object Syntax calls to new() URL: https://github.com/apache/thrift/pull/1613#issuecomment-430788089 From appveyor: ``` Downloading JDK from http://download.oracle.com/otn-pub/java/jdk/8u181-b13/96a7b8442fe848ef90c96a2fad6ed6d1/jdk-8u181-windows-x64.exe ERROR: Exception calling "DownloadFile" with "2" argument(s): "The remote server returned an error: (404) Not Found." The install of jdk8 was NOT successful. Error while running 'C:\ProgramData\chocolatey\lib\jdk8\tools\chocolateyInstall.ps1'. See log for details. Chocolatey installed 0/1 packages. 1 packages failed. See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log). ``` Nothing to do with perl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Assignee: James E. King III >Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654172#comment-16654172 ] ASF GitHub Bot commented on THRIFT-4382: djzort commented on issue #1613: THRIFT-4382: Replace the use of Indirect Object Syntax calls to new() URL: https://github.com/apache/thrift/pull/1613#issuecomment-430787717 i havent introduced anything that would break perl 5.10 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Assignee: James E. King III >Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653990#comment-16653990 ] ASF GitHub Bot commented on THRIFT-4382: jeking3 commented on issue #1613: THRIFT-4382: Replace the use of Indirect Object Syntax calls to new() URL: https://github.com/apache/thrift/pull/1613#issuecomment-430734501 One final question - what perl versions will this syntax be compatible with? We currently support 5.10.0 or later. Does this PR change that? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Assignee: James E. King III >Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III reassigned THRIFT-4382: - Assignee: James E. King III > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Assignee: James E. King III >Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4653) ES6 Classes
[ https://issues.apache.org/jira/browse/THRIFT-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653726#comment-16653726 ] ASF GitHub Bot commented on THRIFT-4653: bforbis opened a new pull request #1615: THRIFT-4653: ES6 classes support URL: https://github.com/apache/thrift/pull/1615 Adding ES6 class generation behind the new `es6` generation flag. This should be a drop-in replacement for ES5 style prototype inheritance when run in an es6 environment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ES6 Classes > --- > > Key: THRIFT-4653 > URL: https://issues.apache.org/jira/browse/THRIFT-4653 > Project: Thrift > Issue Type: Improvement > Components: JavaScript - Compiler, Node.js - Compiler >Reporter: Brian Forbis >Priority: Minor > > Updating the generated code to generate ES6 classes when using the es6 > compiler option. ES6 classes should be a drop in replacement for manual ES5 > prototypical inheritance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (THRIFT-4653) ES6 Classes
Brian Forbis created THRIFT-4653: Summary: ES6 Classes Key: THRIFT-4653 URL: https://issues.apache.org/jira/browse/THRIFT-4653 Project: Thrift Issue Type: Improvement Components: JavaScript - Compiler, Node.js - Compiler Reporter: Brian Forbis Updating the generated code to generate ES6 classes when using the es6 compiler option. ES6 classes should be a drop in replacement for manual ES5 prototypical inheritance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (THRIFT-4652) Some go documentation on the website needs to be updated
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III reassigned THRIFT-4652:
-
Assignee: James E. King III
> Some go documentation on the website needs to be updated
>
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Documentation
> Components: Go - Library, Website
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Assignee: James E. King III
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-4652) Some go documentation on the website needs to be updated
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-4652:
--
Summary: Some go documentation on the website needs to be updated (was:
Invalid Go source for Services)
> Some go documentation on the website needs to be updated
>
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Documentation
> Components: Go - Library, Website
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-4652:
--
Issue Type: Documentation (was: Wish)
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Documentation
> Components: Go - Library, Website
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-4652:
--
Component/s: (was: Go - Compiler)
Website
Go - Library
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Documentation
> Components: Go - Library, Website
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653555#comment-16653555
]
Can Celasun commented on THRIFT-4652:
-
I tried to make changes via the CMS a while ago, but there were build failures
and I didn't investigate further. Few issues I'm aware of:
* Language links on the left hand side are all 404s
[http://thrift.apache.org/docs/Languages]
* Tutorial pages for many (all?) languages still link to git.a.o and therefore
404 [http://thrift.apache.org/tutorial/]
* The Go tutorial has git.a.o imports, it should be Github
[http://thrift.apache.org/tutorial/go]
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Wish
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653545#comment-16653545
]
James E. King III commented on THRIFT-4652:
---
You'll have to point me to the page that is wrong. The web site content is in
the Apache CMS, I believe only project committers can make changes.
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Wish
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653537#comment-16653537 ] ASF GitHub Bot commented on THRIFT-4382: jeking3 commented on issue #1613: THRIFT-4382: Replace the use of Indirect Object Syntax calls to new() URL: https://github.com/apache/thrift/pull/1613#issuecomment-430625536 Thanks for resubmitting. Looks like appveyor is having problems... I am looking into it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653533#comment-16653533
]
ASF GitHub Bot commented on THRIFT-4652:
dcelasun commented on issue #1612: THRIFT-4652: Replace git.apache.org imports
with github.com
URL: https://github.com/apache/thrift/pull/1612#issuecomment-430624966
No worries, reverting title. I could use your input on THRIFT-4652 by the
way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Wish
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653528#comment-16653528
]
ASF GitHub Bot commented on THRIFT-4652:
jeking3 commented on issue #1612: THRIFT-4652: Replace git.apache.org imports
with github.com
URL: https://github.com/apache/thrift/pull/1612#issuecomment-430624283
Apologies!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Wish
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653526#comment-16653526
]
ASF GitHub Bot commented on THRIFT-4652:
dcelasun commented on issue #1612: THRIFT-4652: Replace git.apache.org imports
with github.com
URL: https://github.com/apache/thrift/pull/1612#issuecomment-430623956
@jeking3 I don't think this is related to THRIFT-4652?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Wish
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653367#comment-16653367 ] ASF GitHub Bot commented on THRIFT-4382: djzort commented on issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax calls to new() URL: https://github.com/apache/thrift/pull/1261#issuecomment-430585658 Fixed and sent on https://github.com/apache/thrift/pull/1613 The issue was print and printf both have lists as arguments - but mixing them up goes poorly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
[ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653365#comment-16653365 ] ASF GitHub Bot commented on THRIFT-4382: djzort opened a new pull request #1613: THRIFT-4382: Replace the use of Indirect Object Syntax calls to new() URL: https://github.com/apache/thrift/pull/1613 Some helpful tips for a successful Apache Thrift PR: * Did you test your changes locally or using CI in your fork? * Is the Apache Jira THRIFT ticket identifier in the PR title? * Is the Apache Jira THRIFT ticket identifier in the commit message? * Did you squash your changes to a single commit? * Are these changes backwards compatible? (please say so in PR description) * Do you need to update the language-specific README? Example ideal pull request title: THRIFT-: an example pull request title Example ideal commit message: THRIFT-: [summary of fix, one line if possible] Client: [language(s) affected, comma separated, use lib/ directory names please] For more information about committing, see CONTRIBUTING.md Using Indirect Object Syntax to instantiate objects is not recommended as per https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods I have update the output to follow the recommended Class->new() syntax See also https://github.com/apache/thrift/pull/1261 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace the use of Perl Indirect Object Syntax calls to new() > -- > > Key: THRIFT-4382 > URL: https://issues.apache.org/jira/browse/THRIFT-4382 > Project: Thrift > Issue Type: Improvement > Components: Perl - Compiler >Reporter: Dean Hamstead >Priority: Minor > > Using Indirect Object Syntax to instantiate objects is not recommended as per > https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Can Celasun updated THRIFT-4652:
Issue Type: Wish (was: Bug)
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Wish
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653156#comment-16653156
]
Can Celasun commented on THRIFT-4652:
-
I had issues updating the website in the past, so let's ask someone else. cc
[~jking3] [~jfarrell]
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Major
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Can Celasun updated THRIFT-4652:
Priority: Minor (was: Major)
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653152#comment-16653152
]
Tristian Azura commented on THRIFT-4652:
Thank you!, that worked!
I think the Go documentation is a bit outdate and the links to source code are
mostly dead.
I'd be happy to help update the Go tutorial docs, do you happen to know where
the source for the website documentation is?
Best, Tristian
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Major
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653059#comment-16653059
]
Can Celasun commented on THRIFT-4652:
-
> Do I have to build Apache Thrift from source to get this fix?
That commit is not a fix, you are just using incompatible versions of the
compiler and library. You are installing the compiler using brew, which
correctly gives you the latest stable version (0.11) but you got the _library_
from "go get" (or similar) which grabbed the latest master. You have two
options:
* Build the compiler from master yourself (not recommended)
* Use the 0.11 version of the library. If you are using {{dep}} for package
management, the command would be "dep ensure -add
github.com/apache/thrift/lib/go/thrift@^0.11"
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Major
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653026#comment-16653026
]
Tristian Azura edited comment on THRIFT-4652 at 10/17/18 6:20 AM:
--
Hi, thank you for the quick reply.
True I was inspecting the [compiler
source|https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_go_generator.cc#L2650]
to see if I could fix it quickly and I noticed that the proper source strings
are there.
I'm using the Thrift version installed via homebrew:
{code:bash}
brew install thrift
{code}
And
{code:bash}
λ thrift ~> brew info thrift
thrift: stable 0.11.0 (bottled), HEAD
Framework for scalable cross-language services development
https://thrift.apache.org/
/usr/local/Cellar/thrift/0.11.0 (102 files, 7MB) *
Poured from bottle on 2018-10-13 at 17:18:01
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/thrift.rb
{code}
Do I have to build Apache Thrift from source to get this fix?
was (Author: aztristian):
Hi, thank you for the quick reply.
True I was inspecting the [compiler
source|https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_go_generator.cc#L2650]
to see if I could fix it quickly and I noticed that the proper source strings
are there.
I'm using the Thrift version installed via homebrew:
{code:terminal}
brew install thrift
{code}
And
{code:terminal}
λ thrift ~> brew info thrift
thrift: stable 0.11.0 (bottled), HEAD
Framework for scalable cross-language services development
https://thrift.apache.org/
/usr/local/Cellar/thrift/0.11.0 (102 files, 7MB) *
Poured from bottle on 2018-10-13 at 17:18:01
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/thrift.rb
{code}
Do I have to build Apache Thrift from source to get this fix?
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Major
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653026#comment-16653026
]
Tristian Azura commented on THRIFT-4652:
Hi, thank you for the quick reply.
True I was inspecting the [compiler
source|https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_go_generator.cc#L2650]
to see if I could fix it quickly and I noticed that the proper source strings
are there.
I'm using the Thrift version installed via homebrew:
{code:terminal}
brew install thrift
{code}
And
{code:terminal}
λ thrift ~> brew info thrift
thrift: stable 0.11.0 (bottled), HEAD
Framework for scalable cross-language services development
https://thrift.apache.org/
/usr/local/Cellar/thrift/0.11.0 (102 files, 7MB) *
Poured from bottle on 2018-10-13 at 17:18:01
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/thrift.rb
{code}
Do I have to build Apache Thrift from source to get this fix?
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Major
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4652) Invalid Go source for Services
[
https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653019#comment-16653019
]
Can Celasun commented on THRIFT-4652:
-
It looks like you are using the library from master, but the compiler from
0.11. This is not supported. [This
commit|https://github.com/apache/thrift/commit/5785279e2e809f6c56dbbe0eb41d13fb17c88bdd]
added {{context}} to {{Flush()}} and you need it for both the compiler and the
library.
> Invalid Go source for Services
> --
>
> Key: THRIFT-4652
> URL: https://issues.apache.org/jira/browse/THRIFT-4652
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
> Environment: macOS 10.14
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>
>
>Reporter: Tristian Azura
>Priority: Major
>
> The Go compiler generates invalid code for Thrift services, more
> specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing
> the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>
> I used the following models:
> * [https://github.com/evernote/evernote-thrift]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
