[GitHub] thrift pull request #1449: THRIFT-4434. Update .NET Core components, add tes...
Github user vgotra commented on a diff in the pull request: https://github.com/apache/thrift/pull/1449#discussion_r161375270 --- Diff: test/tests.json --- @@ -1,689 +1,686 @@ -[ --- End diff -- As usually - some settings of different editors. Maybe you can provide some settings for VSCode in future - this should help to use this standard for Thrift. Can be useful for everyone and for you too. ---
[GitHub] thrift pull request #1449: THRIFT-4434. Update .NET Core components, add tes...
Github user vgotra commented on a diff in the pull request: https://github.com/apache/thrift/pull/1449#discussion_r161375244 --- Diff: lib/netcore/Makefile.am --- @@ -19,86 +19,25 @@ SUBDIRS = . -THRIFT = $(top_builddir)/compiler/cpp/thrift - -TESTDIR = Tests/Thrift.PublicInterfaces.Compile.Tests -GENDIR = $(TESTDIR)/gen-netcore - THRIFTCODE = \ - Thrift/Thrift.csproj \ - Thrift/ITAsyncProcessor.cs \ - Thrift/ITProcessorFactory.cs \ - Thrift/SingletonTProcessorFactory.cs \ - Thrift/TApplicationException.cs \ - Thrift/TBaseClient.cs \ - Thrift/TException.cs \ - Thrift/TMultiplexedProcessor.cs \ - Thrift/Collections/TCollections.cs \ - Thrift/Collections/THashSet.cs \ - Thrift/Properties/AssemblyInfo.cs \ - Thrift/Protocols/ITProtocolFactory.cs \ - Thrift/Protocols/TAbstractBase.cs \ - Thrift/Protocols/TBase.cs \ - Thrift/Protocols/TBinaryProtocol.cs \ - Thrift/Protocols/TCompactProtocol.cs \ - Thrift/Protocols/TJSONProtocol.cs \ - Thrift/Protocols/TMultiplexedProtocol.cs \ - Thrift/Protocols/TProtocol.cs \ - Thrift/Protocols/TProtocolDecorator.cs \ - Thrift/Protocols/TProtocolException.cs \ - Thrift/Protocols/Entities/TField.cs \ - Thrift/Protocols/Entities/TList.cs \ - Thrift/Protocols/Entities/TMap.cs \ - Thrift/Protocols/Entities/TMessage.cs \ - Thrift/Protocols/Entities/TMessageType.cs \ - Thrift/Protocols/Entities/TSet.cs \ - Thrift/Protocols/Entities/TStruct.cs \ - Thrift/Protocols/Entities/TType.cs \ - Thrift/Protocols/Utilities/TBase64Utils.cs \ - Thrift/Protocols/Utilities/TProtocolUtil.cs \ - Thrift/Server/AsyncBaseServer.cs \ - Thrift/Server/TBaseServer.cs \ - Thrift/Server/TServerEventHandler.cs \ - Thrift/Transports/TClientTransport.cs \ - Thrift/Transports/TServerTransport.cs \ - Thrift/Transports/TTransportException.cs \ - Thrift/Transports/TTransportFactory.cs \ - Thrift/Transports/Client/TBufferedClientTransport.cs \ - Thrift/Transports/Client/TFramedClientTransport.cs \ - Thrift/Transports/Client/THttpClientTransport.cs \ - Thrift/Transports/Client/TMemoryBufferClientTransport.cs \ - Thrift/Transports/Client/TNamedPipeClientTransport.cs \ - Thrift/Transports/Client/TSocketClientTransport.cs \ - Thrift/Transports/Client/TStreamClientTransport.cs \ - Thrift/Transports/Client/TTlsSocketClientTransport.cs \ - Thrift/Transports/Server/THttpServerTransport.cs \ - Thrift/Transports/Server/TNamedPipeServerTransport.cs \ - Thrift/Transports/Server/TServerFramedTransport.cs \ - Thrift/Transports/Server/TServerSocketTransport.cs \ - Thrift/Transports/Server/TTlsServerSocketTransport.cs + Thrift/Thrift.csproj all-local: \ Thrift.dll Thrift.dll: $(THRIFTCODE) - $(MKDIR_P) $(GENDIR) - $(THRIFT) -gen netcore:wcf -r -out $(GENDIR) $(TESTDIR)/CassandraTest.thrift - $(THRIFT) -gen netcore:wcf -r -out $(GENDIR) $(top_srcdir)/test/ThriftTest.thrift - $(THRIFT) -gen netcore:wcf -r -out $(GENDIR) $(top_srcdir)/contrib/fb303/if/fb303.thrift - $(DOTNETCORE) --info - $(DOTNETCORE) restore +# $(MKDIR_P) $(GENDIR) +# $(THRIFT) -gen netcore:wcf -r -out $(GENDIR) $(TESTDIR)/CassandraTest.thrift +# $(THRIFT) -gen netcore:wcf -r -out $(GENDIR) $(top_srcdir)/test/ThriftTest.thrift +# $(THRIFT) -gen netcore:wcf -r -out $(GENDIR) $(top_srcdir)/contrib/fb303/if/fb303.thrift $(DOTNETCORE) build clean-local: - $(RM) Thrift.dll --- End diff -- Nice comment - maybe we should remove auto-generated files ---
[GitHub] thrift pull request #1449: THRIFT-4434. Update .NET Core components, add tes...
Github user vgotra commented on a diff in the pull request: https://github.com/apache/thrift/pull/1449#discussion_r161375224 --- Diff: lib/netcore/Makefile.am --- @@ -19,86 +19,25 @@ SUBDIRS = . -THRIFT = $(top_builddir)/compiler/cpp/thrift - -TESTDIR = Tests/Thrift.PublicInterfaces.Compile.Tests -GENDIR = $(TESTDIR)/gen-netcore - THRIFTCODE = \ - Thrift/Thrift.csproj \ - Thrift/ITAsyncProcessor.cs \ - Thrift/ITProcessorFactory.cs \ - Thrift/SingletonTProcessorFactory.cs \ - Thrift/TApplicationException.cs \ - Thrift/TBaseClient.cs \ - Thrift/TException.cs \ - Thrift/TMultiplexedProcessor.cs \ - Thrift/Collections/TCollections.cs \ - Thrift/Collections/THashSet.cs \ - Thrift/Properties/AssemblyInfo.cs \ - Thrift/Protocols/ITProtocolFactory.cs \ - Thrift/Protocols/TAbstractBase.cs \ - Thrift/Protocols/TBase.cs \ - Thrift/Protocols/TBinaryProtocol.cs \ - Thrift/Protocols/TCompactProtocol.cs \ - Thrift/Protocols/TJSONProtocol.cs \ - Thrift/Protocols/TMultiplexedProtocol.cs \ - Thrift/Protocols/TProtocol.cs \ - Thrift/Protocols/TProtocolDecorator.cs \ - Thrift/Protocols/TProtocolException.cs \ - Thrift/Protocols/Entities/TField.cs \ - Thrift/Protocols/Entities/TList.cs \ - Thrift/Protocols/Entities/TMap.cs \ - Thrift/Protocols/Entities/TMessage.cs \ - Thrift/Protocols/Entities/TMessageType.cs \ - Thrift/Protocols/Entities/TSet.cs \ - Thrift/Protocols/Entities/TStruct.cs \ - Thrift/Protocols/Entities/TType.cs \ - Thrift/Protocols/Utilities/TBase64Utils.cs \ - Thrift/Protocols/Utilities/TProtocolUtil.cs \ - Thrift/Server/AsyncBaseServer.cs \ - Thrift/Server/TBaseServer.cs \ - Thrift/Server/TServerEventHandler.cs \ - Thrift/Transports/TClientTransport.cs \ - Thrift/Transports/TServerTransport.cs \ - Thrift/Transports/TTransportException.cs \ - Thrift/Transports/TTransportFactory.cs \ - Thrift/Transports/Client/TBufferedClientTransport.cs \ - Thrift/Transports/Client/TFramedClientTransport.cs \ - Thrift/Transports/Client/THttpClientTransport.cs \ - Thrift/Transports/Client/TMemoryBufferClientTransport.cs \ - Thrift/Transports/Client/TNamedPipeClientTransport.cs \ - Thrift/Transports/Client/TSocketClientTransport.cs \ - Thrift/Transports/Client/TStreamClientTransport.cs \ - Thrift/Transports/Client/TTlsSocketClientTransport.cs \ - Thrift/Transports/Server/THttpServerTransport.cs \ - Thrift/Transports/Server/TNamedPipeServerTransport.cs \ - Thrift/Transports/Server/TServerFramedTransport.cs \ - Thrift/Transports/Server/TServerSocketTransport.cs \ - Thrift/Transports/Server/TTlsServerSocketTransport.cs + Thrift/Thrift.csproj all-local: \ --- End diff -- Sure ---
[GitHub] thrift pull request #1449: THRIFT-4434. Update .NET Core components, add tes...
Github user vgotra commented on a diff in the pull request: https://github.com/apache/thrift/pull/1449#discussion_r161375213 --- Diff: lib/netcore/Makefile.am --- @@ -19,86 +19,25 @@ SUBDIRS = . -THRIFT = $(top_builddir)/compiler/cpp/thrift - -TESTDIR = Tests/Thrift.PublicInterfaces.Compile.Tests -GENDIR = $(TESTDIR)/gen-netcore - THRIFTCODE = \ - Thrift/Thrift.csproj \ --- End diff -- .Net Core cli should automatically handle that - if file didn't change - it will not trigger the build - hope this will help you to spend less time on adding every file to list (autotools as I understand doesn't support wildcards) ---
[GitHub] thrift pull request #1449: THRIFT-4434. Update .NET Core components, add tes...
Github user vgotra commented on a diff in the pull request: https://github.com/apache/thrift/pull/1449#discussion_r161375191 --- Diff: test/features/known_failures_Linux.json --- @@ -1,46 +1,48 @@ [ - "c_glib-limit_container_length_binary_buffered-ip", --- End diff -- It's auto-formatting in vscode maybe ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Thanks - as I remember - I already merged (not re-based) some changes from master to pull request branch (in one or few previous commits) - not sure that this will correctly work with squash. ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hard to say - this can cause some time to make a single commit in manual way - if you know how I can make it fast and in simple way - then I can try to do it. Or we can simply re-run CI tests and make cherry-pick. Previously, it took half of day to understand where are problems during merge and what should be fixed - don't want to spend another day on resolving issues of merge in manual way (we can get some stupid errors and then spend some time to fix them). ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Yes - it can be (if such self-signed certs are not trusted and if it not possible to build and validate the chain - but we cannot change that, because this will cause security problems at productions) I'm waiting for the results of cross tests - if they will be successful - then we can say that everything is good. Locally, I cannot reproduce any problem with set of few languages (cpp, c, csharp, rust, netcore, ...) for cross tests. And you can approve current pull request :) Will be a good gift for people which want to reuse .Net Core Thrift and migrate their infrastructures to the latest stable stack for .Net ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hm - for csharp for tests I enabled validation of any certificate to be successful ``` csharp ((sender, certificate, chain, errors) => true, ) ``` in server tests code Do you think I should revert it to check ? ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Something at https://travis-ci.org/apache/thrift/jobs/328143179 - but locally I cannot reproduce this problem - also no logs at Travis CI. ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 It's already enabled - I removed disabled for netcore from tests.json ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - It seems that fix for csharp lib tests with Tls1.2 can take more time and investigation because of possible situation that mono implements Tls1 - 1.2 in very specific way. Few issues related to that: - https://bugzilla.xamarin.com/show_bug.cgi?id=42805 - https://forums.xamarin.com/discussion/57683/tls-1-2-support - http://www.mono-project.com/docs/about-mono/releases/4.8.0/#tls-12-support - https://boringssl.googlesource.com/boringssl/ So, the simplest fix - I just reused Tls1 for .Net Core tests (by default for .Net Core implementation uses Tls 1.2). At least, .Net Core client will be able to connect to old csharp server. But to fix a csharp client, a lot of checks should be done, also maybe some specific modification of build process (building of boringssl, etc.) should be done too. Updated known_failures_Linux.json with issues related to described problem. I think checking fix for this bug in csharp/mono is for another task and time. ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Will try to quickly find the problem with old .Net tests - maybe version of Tls in implementation of tests and will update pull request if this is possible to do that quickly ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Thank you - updated :) ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Yes, please - I tried almost everything to make it compiling (it seem that it doesn't support modern styles of initialization and instead of warning generates an error). It's hard to reproduce this locally - I need to create a lot of environments to check all compilations locally - maybe we can improve it later :) Just want to merge working changes to main repo - a lot of improvements in this pull request for .Net Core version and still a lot of things to do (integration and unit tests, improvement of CMake scripts, etc.) ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 How we can trigger checks? Is it possible to trigger them manually? ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - https://blogs.msdn.microsoft.com/vcblog/2017/11/02/visual-studio-build-tools-now-include-the-vs2017-and-vs2015-msvc-toolsets/ - hope this will help to move easier to VS2017 and with builds ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 No it cannot. Few different tries - it seems that we will have few fixes and few more builds for only MSVC2010 ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Didn't imagine that we still support MSVC2010 - almost every compiler was able to build the source code but MSVC2010 cannot - hope people will move from this to something more modern and improved. Let check results of build for MSVC2010. ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - updated header file to fix warnings, also reverted Autotools files to check builds ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - It seems that CLang doesn't recognize "-Wno-error=maybe-uninitialized". Do you know how to add some switches for different compilers ? - Error mostly because of one struct in header file (but to normally fix it it will take some time - unit tests for IDL much more important - already fixed few important bugs because of unit tetst for .Net Core generator) - easier to add suppression correctly and then fix it correctly. ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Updated tests, fixed some problems (added framed correct support at server side, updated tests and test known failures, etc.), reverted one line in netcore*.h file (instead added suppression of one warning to automake files). It seems, that at Ubuntu 17.10, it can build and run all tests for .net core (for server side and client side) for all pre-configured languages with automake (make cross). ---
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 What do you mean - pass as client but hang as a server - do you mean - client can be like Python and server as .Net Core ? ---
[GitHub] thrift pull request #1449: THRIFT-4434. Update .NET Core components, add tes...
GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1449 THRIFT-4434. Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process This pull request should: - highly improve the current version of .Net Core library and .Net Core compiler and quality of code - improve and simplify build process - improve documentation related to .Net Core library and compiler - fix found bugs (some of bugs can be clarified like major - they are related to porting of protocols from Java version and can be present in C# library) - add important unit tests for .Net Core library and .Net Core compiler - add possibility to easy add unit tests for compiler for other languages You can merge this pull request into a Git repository by running: $ git pull https://github.com/vgotra/thrift netcore-standard2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1449.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1449 commit e3c255ff30d7aa6bcfc3fbaa5e3127698998a3d7 Author: Volodymyr Gotra <volodymyr.gotra@...> Date: 2017-12-18T00:08:09Z Initial merge of changes without fixes of builds commit f6ced18b7021b72679af04b54da3019b34208a90 Author: Volodymyr Gotra <vgotra@...> Date: 2017-12-25T03:58:12Z Fixed code generation from thrift files (for CLI and VS), fixed other issues commit 3ad1dd065e6b71d69d583884c441f3a9e550dc0a Author: Volodymyr Gotra <vgotra@...> Date: 2017-12-25T16:48:21Z Updated build, readme, cmake files for tests commit abc788df104ba6818fe5b9aaf13e2e5714fe791c Author: Volodymyr Gotra <vgotra@...> Date: 2017-12-25T17:07:38Z Updated copyrights commit 2cf70c58d3f3081b026a852e2ab4a391297ed06d Author: Volodymyr Gotra <volodymyr.gotra@...> Date: 2017-12-25T21:52:40Z Fixes for header file, updated project files, updated Makefiles commit f55e4d9bd085fb5a8ecbc9b228d9a233bb9c4931 Author: Volodymyr Gotra <vgotra@...> Date: 2017-12-25T23:06:48Z Added public interfaces generation for testing, updated readme commit a8ad6ec61c9b6c4c56476e2bcd2aa484b4f0e298 Author: Volodymyr Gotra <vgotra@...> Date: 2017-12-25T23:24:03Z Updated readme commit d1d96857a72f26f840707807393260f5fc1face5 Author: Volodymyr Gotra <volodymyr.gotra@...> Date: 2017-12-25T23:36:50Z Added detection of Windows platform ---
[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1163 Hi @Jens-G It seems that we have first less-more stable version of .Net Core SDK/CLI and .NET Core runtime. Also it is possible to create and run unit and integration tests with .Net Core now. So, I want to start work on unit tests (maybe also on integration tests) and upgrade library to current stable version of .Net Core. The only question for me - how do you build libraries on build server and also how I can find some basic help about how to do that. It will be good to know to avoid issues with changes. Also it will be great to understand how do you include some new frameworks into Thrift.exe generator to easy include generation of .Net Core generator into official Thrift.exe generator - some people asked me recently how to build it because .Net Core generator still not included into Thrift.exe. P.S. As always I will create task in Apache Jira for new pull request ) Thanks Volodymyr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1163 Hi @Jens-G Added pull request with changes described in Jira task and in pull request. Later after stabilizing and release of .NET Standard 2.0 I will create new request with migration to latest stable .NET Core SDK. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1163: Update of Apache Thrift .Net Core lib
GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1163 Update of Apache Thrift .Net Core lib Changes to library: - Updated tutorial (added samples of usage of multiplexed protocol to server and client side and other) - Added framed transport to client side and implementation of framed transport to server - Updated information related to build of thrift application with CMake, Visual Studio 2017, XCode - Updated information related to build and usage of Thrift .Net Core library - Added SDK versions to project for easy usage of different versions of .NET Core SDK You can merge this pull request into a Git repository by running: $ git pull https://github.com/vgotra/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1163 commit 078c88e407bc1273ff9336373e7e29b3c87e808a Author: Volodymyr Gotra <vgo...@gmail.com> Date: 2017-01-16T00:34:28Z Added framed transport, updated docs, updated global.json with SDKversion commit 9dfef2c263c16b603cb15f81eb7acb2262598c8d Author: Volodymyr Gotra <vgo...@gmail.com> Date: 2017-01-16T01:59:28Z Added usage to multiplexer to tutorial commit d4b6f44fb3497d2cdc934a4cebb98c4d971bbc49 Author: Volodymyr Gotra <vgo...@gmail.com> Date: 2017-01-16T02:03:15Z Changed sdk to current sdk 1.0.0-preview2-1-003177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 Hi @Jens-G Done - you can check master in https://github.com/vgotra/thrift. Added framed transport and added sample of usage of MultiplexedProtocol. Also updated docs for library. I matched that last time you used 1.0.0-preview2-1-003177 version of .Net Core SDK - you can also experiment with different SDK of .Net Core (just change version of SDK in solution global.json - I added samples). The only thing - in 1.0.0-preview2-1-003177 version of .NET Core CLI, dotnet doesn't support simple passing of arguments. So, for correct work of tutorial, arguments should be passed to cmd for server and client in full form like a (dotnet run -t:tcp -p:multiplexed, dotnet run -help). In latest SDK of .NET Core CLI added possibility to use passing arguments in more easy way - like: dotnet run -- -p:multiplexed, dotnet run -- -h Pls, ping me when you will be ready to merge pull request and I will create it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 Hi @Jens-G You can use .NET Core SDK 1.0 Preview 4 build 004233 (https://github.com/dotnet/core/blob/master/release-notes/preview4-download.md) - this package supports new csproj format for building apps. That's why I still waiting before creation of pull request. I updated https://github.com/vgotra/thrift/blob/master/lib/netcore/README.md for new csproj format. But not updated build scripts fully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 @Jens-G - Hi Jens. I added changes for netcore implementation in the latest fork of Thrift repo (https://github.com/vgotra/thrift): - migration to csproj from project.json (https://blogs.msdn.microsoft.com/dotnet/2016/11/16/announcing-net-core-tools-msbuild-alpha/) - update to latest .NET Core framework (netcoreapp1.1) - added implementation of framed transport - added info how to build Thrift IDL with VS2017 RC - other minor changes There is still problems with .NET Core CLI tools - they fixed problem with restore, but console build of solution with library based on .NET standard 1.6 and console app based on netcoreapp1.1 can cause problems. MS planned to release NET Standard 2.0 in Q1 2017 (https://blogs.msdn.microsoft.com/dotnet/2016/07/15/net-core-roadmap/). I can wait for official release and then update everything to official stable version and create create pull request - or update docs and create new pull request with current changes to include them into the next release of Apache Thrift. Please, let me know your thoughts about that. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 @Jens-G - Updated (added tests). Not sure how to run tests with test.py (just updated tests.json) - it seems that you have custom configuration for running tests. Manually executed tests (server and client) - http://prntscr.com/crl5km. There is still an issue with including of generated files on prebuild action (it's related to cli tools - dotnet cli ). It can be easily fixed after merging netcore changes to thrift generator and adding additional cmd line for generation code from idl before building tests and running them with test.py. You can run them in easy way for check - install dotnet sdk (https://www.microsoft.com/net/core#windows) for your platform and then run "dotnet restore && dotnet run server" and "dotnet run client" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 @Jens-G - about your comments: > General > > All code files etc. need an ASF header on top. Please have a look at the existing code if you are unsure, what, where and how to apply. Done in the latest commit > using Serilog; > > We don't like external dependencies that much. Thrift supports about 20+ languages and dialects, each additional dependency has the potential to quickly become a PITA. So we avoid them wherever possible. Removed in the latest commit > lib/netcore/src/Samples > > If that is the Thrift Test Suite client/server pair, that part should be move to /test/netcore. All other tests should remain under /lib/netcore. In addition to that, we have a standardized set of arguments and exit codes. I haven't checked how close these program(s) already adhere to them, but from a first quick glance it may not 100%. Moved it to tutorial/netcore folder > Compatibility I > > Did you test the code against at least one other language, preferably C++, Java or C#? Yes, I tried to do that with Python (you can check README.md for Samples in tutorial/netcore folder). Tests completed without problems. > Compatibility II > > Can at least the Thrift Test Suite .NET Core Application code be built on Linux and/or Mac? Without any problems - main library (Thrift for .Net Core automatically will be crossplatform) You can build Samples for different platforms (I added 3 main platforms for Samples) and tested them on different OS (Win/MacOs/Ubuntu) Example: dotnet restore dotnet build **/*/project.json -r win10-x64 dotnet build **/*/project.json -r osx.10.11-x64 dotnet build **/*/project.json -r ubuntu.16.04-x64 > AssemblyInfo.cs > > Should be set up according to the existing C# code. Done > /lib/netcore/src/Samples/.../Calculator.cs > > The Tutorial code belongs under /tutorial/netcore. The code is later to be included on the web site automagically from that folder. Done > Next, generated code should generally not be put into the source tree. Part of the tutorial is to create these files from the IDL file. It can be complex part - because this IDL should be created with new Thrift generator (which should include functionality for .NET Core generation) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1088: Microsoft .Net Core library port and generator fo...
GitHub user vgotra reopened a pull request: https://github.com/apache/thrift/pull/1088 Microsoft .Net Core library port and generator for this library Here is port of csharp library to .Net core and also generator for it (t_netcore_generator.cc) All information in README.md files in subfolders with source code and samples. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vgotra/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1088.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1088 commit 0cf8fc3c5793a3553172745579082e9cd36e Author: Volodymyr Gotra <vgo...@gmail.com> Date: 2016-09-15T00:18:48Z Initial commit of changes commit e184a9a2f3c3b93e6221f4ee097598e5b5875460 Author: Volodymyr Gotra <vgo...@gmail.com> Date: 2016-09-15T00:29:43Z Added changes to thriftl.ll for netcore lib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1088: Microsoft .Net Core library port and generator fo...
Github user vgotra closed the pull request at: https://github.com/apache/thrift/pull/1088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1088 Hi - here is Jira Ticket for this new feature https://issues.apache.org/jira/browse/THRIFT-3933 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1088: Microsoft .Net Core library port and generator fo...
GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1088 Microsoft .Net Core library port and generator for this library Here is port of csharp library to .Net core and also generator for it (t_netcore_generator.cc) All information in README.md files in subfolders with source code and samples. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vgotra/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1088.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1088 commit 0cf8fc3c5793a3553172745579082e9cd36e Author: Volodymyr Gotra <vgo...@gmail.com> Date: 2016-09-15T00:18:48Z Initial commit of changes commit e184a9a2f3c3b93e6221f4ee097598e5b5875460 Author: Volodymyr Gotra <vgo...@gmail.com> Date: 2016-09-15T00:29:43Z Added changes to thriftl.ll for netcore lib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
