[jira] [Closed] (THRIFT-2990) CMake build for all target languages
[ https://issues.apache.org/jira/browse/THRIFT-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça closed THRIFT-2990. - Resolution: Duplicate Please see THRIFT-2850 CMake build for all target languages Key: THRIFT-2990 URL: https://issues.apache.org/jira/browse/THRIFT-2990 Project: Thrift Issue Type: Improvement Components: Build Process Reporter: Henrique Mendonça -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491798#comment-14491798 ] Jake Farrell commented on THRIFT-3090: -- Ubuntu 14.04 LTS and CentOS 7 should be what we look to for min package versions, would set the min required version to 2.8.11 cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3093) mingw compile fixes for c++ library 0.9.2
[ https://issues.apache.org/jira/browse/THRIFT-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eion Robb updated THRIFT-3093: -- Attachment: mingw-compile.diff mingw compile fixes for c++ library 0.9.2 - Key: THRIFT-3093 URL: https://issues.apache.org/jira/browse/THRIFT-3093 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: mingw/cygwin Reporter: Eion Robb Priority: Minor Attachments: mingw-compile.diff I've spent the morning trying to get the C++ library compiled using mingw/cygwin. I had to make a few changes to get things to compile. Some places didn't include sys/time.h when they needed to (for the timeval struct) and I needed to make the timeval struct in the global namespace, else the compiler would try to look for it in the thrift namespace. There was also a minor issue with the syntax for the #ifdef HAVE_STRERROR_R check in Thrift.cpp; the config.h file says to set the parameter to 0 if strerror_r is not available - rather than undefine it. Last of all, I had to add in an implementation of vsnprintf() as my version of mingw did not provide it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3093) mingw compile fixes for c++ library 0.9.2
Eion Robb created THRIFT-3093: - Summary: mingw compile fixes for c++ library 0.9.2 Key: THRIFT-3093 URL: https://issues.apache.org/jira/browse/THRIFT-3093 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: mingw/cygwin Reporter: Eion Robb Priority: Minor Attachments: mingw-compile.diff I've spent the morning trying to get the C++ library compiled using mingw/cygwin. I had to make a few changes to get things to compile. Some places didn't include sys/time.h when they needed to (for the timeval struct) and I needed to make the timeval struct in the global namespace, else the compiler would try to look for it in the thrift namespace. There was also a minor issue with the syntax for the #ifdef HAVE_STRERROR_R check in Thrift.cpp; the config.h file says to set the parameter to 0 if strerror_r is not available - rather than undefine it. Last of all, I had to add in an implementation of vsnprintf() as my version of mingw did not provide it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491731#comment-14491731 ] James E. King, III commented on THRIFT-3090: I don't mind going to 3.0.2 - I love upgrading things. : cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2992) CMake build for tutorial and tests
[ https://issues.apache.org/jira/browse/THRIFT-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça closed THRIFT-2992. - Resolution: Fixed Please see THRIFT-2850 CMake build for tutorial and tests -- Key: THRIFT-2992 URL: https://issues.apache.org/jira/browse/THRIFT-2992 Project: Thrift Issue Type: Improvement Components: Build Process Reporter: Henrique Mendonça -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2991) customizable CMake build
[ https://issues.apache.org/jira/browse/THRIFT-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça closed THRIFT-2991. - Resolution: Duplicate Please see THRIFT-2850 customizable CMake build Key: THRIFT-2991 URL: https://issues.apache.org/jira/browse/THRIFT-2991 Project: Thrift Issue Type: Improvement Components: Build Process Reporter: Henrique Mendonça The user should be able choose which libraries to build if any. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2993) CPack support
[ https://issues.apache.org/jira/browse/THRIFT-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça closed THRIFT-2993. - Resolution: Duplicate Please see THRIFT-2850 CPack support - Key: THRIFT-2993 URL: https://issues.apache.org/jira/browse/THRIFT-2993 Project: Thrift Issue Type: Improvement Components: Build Process Reporter: Henrique Mendonça -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-3091) c_glib service method should return result from handler method
[ https://issues.apache.org/jira/browse/THRIFT-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3091. - Resolution: Fixed Assignee: Nobuaki Sukegawa committed c_glib service method should return result from handler method -- Key: THRIFT-3091 URL: https://issues.apache.org/jira/browse/THRIFT-3091 Project: Thrift Issue Type: Bug Components: C glib - Compiler Reporter: Nobuaki Sukegawa Assignee: Nobuaki Sukegawa Fix For: 0.9.3 Generated c_glib service method has *gboolean* return type but actually returned nothing at all. It seems that while gcc 4.9.2 treats it as if returning non-zero, clang 3.6.0 treats it as if returning zero. The patch adds missing return to implementation(handler) method call in the last line of service method. Note that it also includes style fix (0 - FALSE) in the same line which is not essential. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491418#comment-14491418 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92033000 Nevermind, it is my fault - fixing it.. Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92033000 Nevermind, it is my fault - fixing it.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92034746 Wow, this really isn't my morning... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491422#comment-14491422 ] ASF GitHub Bot commented on THRIFT-2441: GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET commit 49153dd33b63d054c72d6e28e5048b2ee80e5cf6 Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T11:12:46Z THRIFT-2441 fix cmake error with new integration test using EmptyService Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET commit 49153dd33b63d054c72d6e28e5048b2ee80e5cf6 Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T11:12:46Z THRIFT-2441 fix cmake error with new integration test using EmptyService --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Jenkins build is back to normal : Thrift-Compiler-Windows #1605
See https://builds.apache.org/job/Thrift-Compiler-Windows/1605/changes
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET commit 49153dd33b63d054c72d6e28e5048b2ee80e5cf6 Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T11:12:46Z THRIFT-2441 fix cmake error with new integration test using EmptyService commit e9997d921b7d864bee19ba0b9cf5bb27eb817594 Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T11:45:49Z THRIFT-2441 fix cmake build and enhance TServerIntegrationTest to test more code paths --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491435#comment-14491435 ] ASF GitHub Bot commented on THRIFT-2441: GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET commit 49153dd33b63d054c72d6e28e5048b2ee80e5cf6 Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T11:12:46Z THRIFT-2441 fix cmake error with new integration test using EmptyService commit e9997d921b7d864bee19ba0b9cf5bb27eb817594 Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T11:45:49Z THRIFT-2441 fix cmake build and enhance TServerIntegrationTest to test more code paths Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user marco-m commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203820
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
-include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
--- End diff --
I don't need to remove SYSTEM to fix the cmake build on Mac OS X. On the
other hand, I don't see why SYSTEM is needed :-) In any case, this change can
be reverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-3090) cmake build is broken
[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491479#comment-14491479
]
ASF GitHub Bot commented on THRIFT-3090:
Github user marco-m commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203820
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
-include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
--- End diff --
I don't need to remove SYSTEM to fix the cmake build on Mac OS X. On the
other hand, I don't see why SYSTEM is needed :-) In any case, this change can
be reverted.
cmake build is broken
-
Key: THRIFT-3090
URL: https://issues.apache.org/jira/browse/THRIFT-3090
Project: Thrift
Issue Type: Bug
Environment: Mac OS X 10.10.3
C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0
(clang-600.0.57) (based on LLVM 3.5svn)
boost 1.57
cmake 3.2.1
Reporter: Marco Molteni
A current version of apache/thrift on github as of 2015-04-10 doesn't build
with cmake due to multiple errors:
- some C++ targets fail to link with missing symbols, because they do not
link against the `thrift` library
- the c_glib test targets fail to build because the reference to `shared_ptr`
is considered ambiguous by the compiler (it resolves to both boost and stdlib
shared_ptr)
See pull request https://github.com/apache/thrift/pull/434
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user marco-m commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203837 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific -if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX) +# GCC or Clang specific +if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES Clang) --- End diff -- Unfortunately CMAKE_COMPILER_IS_CLANG doesn't exist (or at least didn't exist last time I researched the topic). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3090) cmake build is broken
[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491487#comment-14491487
]
Marco Molteni commented on THRIFT-3090:
---
Now I think that the linking problem might be related to the fact that I am
using a cmake version = 3.0 on Mac OS X.
When running cmake, I get:
{noformat}
CMake Warning (dev):
Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run cmake
--help-policy CMP0042 for policy details. Use the cmake_policy command to
set the policy and suppress this warning.
MACOSX_RPATH is not specified for the following targets:
thrift
thrift_c_glib
thriftqt
thriftz
{noformat}
and looking at http://www.cmake.org/cmake/help/v3.0/policy/CMP0042.html it says:
{quote}
MACOSX_RPATH is enabled by default.
CMake 2.8.12 and newer has support for using @rpath in a target’s install name.
This was enabled by setting the target property MACOSX_RPATH. The @rpath in an
install name is a more flexible and powerful mechanism than @executable_path or
@loader_path for locating shared libraries.
CMake 3.0 and later prefer this property to be ON by default. Projects wanting
@rpath in a target’s install name may remove any setting of the
INSTALL_NAME_DIR and CMAKE_INSTALL_NAME_DIR variables.
This policy was introduced in CMake version 3.0. CMake version 3.0.2 warns when
the policy is not set and uses OLD behavior. Use the cmake_policy command to
set it to OLD or NEW explicitly.
{quote}
Is bumping the minimum required cmake version for Thrift to 3.0 OK (what I
would suggest) or do we have to explicitly set the old policy?
cmake build is broken
-
Key: THRIFT-3090
URL: https://issues.apache.org/jira/browse/THRIFT-3090
Project: Thrift
Issue Type: Bug
Environment: Mac OS X 10.10.3
C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0
(clang-600.0.57) (based on LLVM 3.5svn)
boost 1.57
cmake 3.2.1
Reporter: Marco Molteni
A current version of apache/thrift on github as of 2015-04-10 doesn't build
with cmake due to multiple errors:
- some C++ targets fail to link with missing symbols, because they do not
link against the `thrift` library
- the c_glib test targets fail to build because the reference to `shared_ptr`
is considered ambiguous by the compiler (it resolves to both boost and stdlib
shared_ptr)
See pull request https://github.com/apache/thrift/pull/434
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3091) c_glib service method should return result from handler method
[ https://issues.apache.org/jira/browse/THRIFT-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491407#comment-14491407 ] Hudson commented on THRIFT-3091: SUCCESS: Integrated in Thrift #1500 (See [https://builds.apache.org/job/Thrift/1500/]) THRIFT-3091 c_glib service method should return result from handler method (roger: rev 6d71dc868873691a62b3cb28bf48dcb0e225fa95) * compiler/cpp/src/generate/t_c_glib_generator.cc c_glib service method should return result from handler method -- Key: THRIFT-3091 URL: https://issues.apache.org/jira/browse/THRIFT-3091 Project: Thrift Issue Type: Bug Components: C glib - Compiler Reporter: Nobuaki Sukegawa Assignee: Nobuaki Sukegawa Fix For: 0.9.3 Generated c_glib service method has *gboolean* return type but actually returned nothing at all. It seems that while gcc 4.9.2 treats it as if returning non-zero, clang 3.6.0 treats it as if returning zero. The patch adds missing return to implementation(handler) method call in the last line of service method. Note that it also includes style fix (0 - FALSE) in the same line which is not essential. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491475#comment-14491475 ] James E. King, III commented on THRIFT-2441: Okay, THRIFT-2441 is ready to re-review based on a couple changes I made as a result of additional testing. In addition, THRIFT-3081, THRIFT-3083, and THRIFT-3084 are now ready and need to go in that order so I will submit each one as the dependency is resolved. Sorry for the build/CI thrashing this morning. Thanks! Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92032827 Closing and reopening because three builds failed with build.ninja not found. Seems unrelated to changes made. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491416#comment-14491416 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92032827 Closing and reopening because three builds failed with build.ninja not found. Seems unrelated to changes made. Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203488 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific -if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX) +# GCC or Clang specific +if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES Clang) --- End diff -- does CMAKE_COMPILER_IS_CLANG work as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491467#comment-14491467 ] ASF GitHub Bot commented on THRIFT-3090: Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203488 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific -if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX) +# GCC or Clang specific +if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES Clang) --- End diff -- does CMAKE_COMPILER_IS_CLANG work as well? cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491486#comment-14491486
]
ASF GitHub Bot commented on THRIFT-2441:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28203871
--- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp ---
@@ -88,7 +88,7 @@ void TSimpleServer::serve() {
string errStr = string(Some kind of accept exception: ) +
tx.what();
GlobalOutput(errStr.c_str());
continue;
-} catch (string s) {
+} catch (const string s) {
--- End diff --
I removed this logic in THRIFT-3083.
Cannot shutdown TThreadedServer when clients are still connected
Key: THRIFT-2441
URL: https://issues.apache.org/jira/browse/THRIFT-2441
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9.1
Reporter: Chris Stylianou
Assignee: Ben Craig
Attachments: THRIFT-2441-prelim.patch
When calling stop() on the TThreadedServer no interrupts are sent to the
client threads. This means the stop() call blocks on tasksMonitor.wait()
until all client naturally disconnect.
How can we tell the client thread connections to close/exit during the
TThreadedServer::stop() call?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28203871
--- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp ---
@@ -88,7 +88,7 @@ void TSimpleServer::serve() {
string errStr = string(Some kind of accept exception: ) +
tx.what();
GlobalOutput(errStr.c_str());
continue;
-} catch (string s) {
+} catch (const string s) {
--- End diff --
I removed this logic in THRIFT-3083.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Build failed in Jenkins: Thrift-Compiler-Windows #1604
See https://builds.apache.org/job/Thrift-Compiler-Windows/1604/changes Changes: [roger] THRIFT-3091 c_glib service method should return result from handler method [roger] THRIFT-2946 Enhance usability of cross test framework [roger] make cross: update test/known_failures_Linux.json -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu ubuntu legacy-ubuntu) in workspace https://builds.apache.org/job/Thrift-Compiler-Windows/ws/ git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url https://git-wip-us.apache.org/repos/asf/thrift.git # timeout=10 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/thrift.git git --version # timeout=10 git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/thrift.git +refs/heads/*:refs/remotes/origin/* Seen branch in repository origin/0.1.x Seen branch in repository origin/0.2.x Seen branch in repository origin/0.3.x Seen branch in repository origin/0.4.x Seen branch in repository origin/0.5.x Seen branch in repository origin/0.6.x Seen branch in repository origin/0.7.x Seen branch in repository origin/0.8.x Seen branch in repository origin/0.9.1 Seen branch in repository origin/0.9.2 Seen branch in repository origin/0.9.x Seen branch in repository origin/master Seen branch in repository origin/py-compiler Seen 13 remote branches Checking out Revision 5af3b8abf7df61e0fd7f92f65721ab593c920e34 (origin/master) git config core.sparsecheckout # timeout=10 git checkout -f 5af3b8abf7df61e0fd7f92f65721ab593c920e34 git rev-list bb23eadca16f18afaee8e7f69c02f3456358cc6b # timeout=10 [Thrift-Compiler-Windows] $ /bin/bash -xe /tmp/hudson7789598845201822919.sh + sh bootstrap.sh Configuring for: PHP Api Version: 20090626 Zend Module Api No: 20090626 Zend Extension Api No: 220090626 automake version 1.11.3 is too old (need 1.13 or later) Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Archiving artifacts
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491419#comment-14491419 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2850) CMake for Apache Thrift
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier updated THRIFT-2850: Attachment: 0001-THRIFT-2850-CMake-for-Apache-Thrift.patch CMake for Apache Thrift --- Key: THRIFT-2850 URL: https://issues.apache.org/jira/browse/THRIFT-2850 Project: Thrift Issue Type: Improvement Components: Build Process Environment: all platforms Reporter: Roger Meier Assignee: Roger Meier Attachments: 0001-THRIFT-2850-CMake-for-Apache-Thrift.patch Goal: Extend Apache Thrift's *make cross* approach to the build system. Due to growing the field of operating system support, a proper executable and library detection mechanism running on as much platforms as possible becomes required. The other aspect is simplify the release process and package generation process. As nice side benefit of CMake is the generation of development environment specific solution files(VisualStudio, Eclipse, Xcode, etc. ). = No solution files within source tree. We are already building Apache Thrift with CMake for Linux-ARM, Linux-x86, Windows CE and Windows. We are in preparation phase for a pull request here: https://github.com/siemens/thrift/commits/cmake-master -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491481#comment-14491481 ] ASF GitHub Bot commented on THRIFT-3090: Github user marco-m commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203837 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific -if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX) +# GCC or Clang specific +if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES Clang) --- End diff -- Unfortunately CMAKE_COMPILER_IS_CLANG doesn't exist (or at least didn't exist last time I researched the topic). cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491412#comment-14491412 ] ASF GitHub Bot commented on THRIFT-2441: GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92031586 Added an integration test to prove behavior is correct; re-opening for CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491411#comment-14491411 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92031586 Added an integration test to prove behavior is correct; re-opening for CI build. Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491417#comment-14491417 ] ASF GitHub Bot commented on THRIFT-2441: GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King jim.k...@simplivity.com Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King jim.k...@simplivity.com Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King jim.k...@simplivity.com Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491415#comment-14491415 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491423#comment-14491423 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-92034746 Wow, this really isn't my morning... Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491424#comment-14491424 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/424 Cannot shutdown TThreadedServer when clients are still connected Key: THRIFT-2441 URL: https://issues.apache.org/jira/browse/THRIFT-2441 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.1 Reporter: Chris Stylianou Assignee: Ben Craig Attachments: THRIFT-2441-prelim.patch When calling stop() on the TThreadedServer no interrupts are sent to the client threads. This means the stop() call blocks on tasksMonitor.wait() until all client naturally disconnect. How can we tell the client thread connections to close/exit during the TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28204494
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
}
-#if defined __FreeBSD__ || defined __MACH__
if (errno_copy == THRIFT_ECONNRESET) {
- /* shigin: freebsd doesn't follow POSIX semantic of recv and fails
with
- * THRIFT_ECONNRESET if peer performed shutdown
- * edhall: eliminated close() since we do that in the destructor.
- */
return 0;
}
-#endif
-
-#ifdef _WIN32
--- End diff --
This sequence is needed for some platforms, did you some tests on windows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491614#comment-14491614 ] James E. King, III commented on THRIFT-3090: It works just fine on Ubuntu 12.04 LTS and gcc-4.6.3 which uses cmake-2.8.7. cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491520#comment-14491520 ] Roger Meier commented on THRIFT-3090: - CMake is anyway new within Apache Thrift so setting the required Version to 3.0.2 should be ok. I can bump the version after committing latest patch on THRIFT-2850 cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491560#comment-14491560 ] Hudson commented on THRIFT-2850: SUCCESS: Integrated in Thrift #1502 (See [https://builds.apache.org/job/Thrift/1502/]) THRIFT-2850 CMake for Apache Thrift (roger: rev 2659381e7f94b825c0b1ff6e80a119035a4a0de5) * build/cmake/FindLibevent.cmake * build/cmake/README.md * test/cpp/CMakeLists.txt * build/cmake/DefineOptions.cmake * CMakeLists.txt CMake for Apache Thrift --- Key: THRIFT-2850 URL: https://issues.apache.org/jira/browse/THRIFT-2850 Project: Thrift Issue Type: Improvement Components: Build Process Environment: all platforms Reporter: Roger Meier Assignee: Roger Meier Attachments: 0001-THRIFT-2850-CMake-for-Apache-Thrift.patch Goal: Extend Apache Thrift's *make cross* approach to the build system. Due to growing the field of operating system support, a proper executable and library detection mechanism running on as much platforms as possible becomes required. The other aspect is simplify the release process and package generation process. As nice side benefit of CMake is the generation of development environment specific solution files(VisualStudio, Eclipse, Xcode, etc. ). = No solution files within source tree. We are already building Apache Thrift with CMake for Linux-ARM, Linux-x86, Windows CE and Windows. We are in preparation phase for a pull request here: https://github.com/siemens/thrift/commits/cmake-master -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491561#comment-14491561 ] Hudson commented on THRIFT-3088: SUCCESS: Integrated in Thrift #1502 (See [https://builds.apache.org/job/Thrift/1502/]) THRIFT-3088 TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket (roger: rev b1a35da9168cca5a7524ab9814161f024da145df) * lib/java/src/org/apache/thrift/server/TThreadPoolServer.java TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket --- Key: THRIFT-3088 URL: https://issues.apache.org/jira/browse/THRIFT-3088 Project: Thrift Issue Type: Bug Components: Java - Library Affects Versions: 0.9 Reporter: Winger Pun Start TThreadPoolServer to server with TSaslServerTransport.Factory as transportFactory. While using nc to test the specified port whether reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket at once while successful connect TThreadPoolServer, but the server still try using sasl protocol to build an inputTransport which of course failed at once. However inputTransport is null which makes it can't close socket properly which lead to CLOSE_WAIT socket. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3084) C++ add concurrent client limit to threaded servers
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3084: --- Attachment: THRIFT-3084-on-3083.v2.patch Updated the patch for reference, added more testing for simple and thread pool servers. C++ add concurrent client limit to threaded servers --- Key: THRIFT-3084 URL: https://issues.apache.org/jira/browse/THRIFT-3084 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2 Reporter: James E. King, III Attachments: THRIFT-3084-on-3083.v2.patch The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. 1. Add a barrier to TServerTransport that will be checked before accept(). 2. In the onClientConnected override (see THRIFT-3083) if the server reaches the limit of the number of accepted clients, enable the barrier. 3. In the onClientDisconnected override if the count of connected clients falls below the maximum concurrent limit, clear the barrier. This will allow the limit to be changed dynamically at runtime (lowered) with drain off clients until more can be accepted. Alternate proposal: Implement a Semaphore and have the servers block the serve() thread if the client that arrived puts the server at the concurrent client limit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3084) C++ add concurrent client limit to threaded servers
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3084: --- Attachment: (was: THRIFT-3084-on-3083.patch) C++ add concurrent client limit to threaded servers --- Key: THRIFT-3084 URL: https://issues.apache.org/jira/browse/THRIFT-3084 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2 Reporter: James E. King, III Attachments: THRIFT-3084-on-3083.v2.patch The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. 1. Add a barrier to TServerTransport that will be checked before accept(). 2. In the onClientConnected override (see THRIFT-3083) if the server reaches the limit of the number of accepted clients, enable the barrier. 3. In the onClientDisconnected override if the count of connected clients falls below the maximum concurrent limit, clear the barrier. This will allow the limit to be changed dynamically at runtime (lowered) with drain off clients until more can be accepted. Alternate proposal: Implement a Semaphore and have the servers block the serve() thread if the client that arrived puts the server at the concurrent client limit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3084) C++ add concurrent client limit to threaded servers
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3084: --- Description: The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. With TThreadPoolServer one can set the limit on the number of threads, however the server will use one additional file descriptor because the serve() routine does not block until after accepting the threadManager size + 1 sockets. With TThreadedServer there was no built-in way to throttle. Give the serve() loop is the only code capable of adding a client, the solution is to add a Monitor to the TServerFramework and check the number of concurrent clients immediately before calling TServerTransport::accept() to get another client, and to track the number of clients that are still alive (their smart pointer hasn't been destroyed). was: The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. With TThreadPoolServer one can set the limit on the number of threads, however the server will use one additional file descriptor because the serve() routine does not block until after accepting the threadManager size + 1 sockets. With TThreadedServer there was no built-in way to throttle. The solution is to add a Monitor to the TServerFramework and check the number of concurrent clients immediately before calling TServerTransport::accept() to get another client, and to track the number of clients that are still alive (their smart pointer hasn't been destroyed). C++ add concurrent client limit to threaded servers --- Key: THRIFT-3084 URL: https://issues.apache.org/jira/browse/THRIFT-3084 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2 Reporter: James E. King, III Attachments: THRIFT-3084-on-3083.v2.patch The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. With TThreadPoolServer one can set the limit on the number of threads, however the server will use one additional file descriptor because the serve() routine does not block until after accepting the threadManager size + 1 sockets. With TThreadedServer there was no built-in way to throttle. Give the serve() loop is the only code capable of adding a client, the solution is to add a Monitor to the TServerFramework and check the number of concurrent clients immediately before calling TServerTransport::accept() to get another client, and to track the number of clients that are still alive (their smart pointer hasn't been destroyed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491536#comment-14491536
]
ASF GitHub Bot commented on THRIFT-2441:
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28204494
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
}
-#if defined __FreeBSD__ || defined __MACH__
if (errno_copy == THRIFT_ECONNRESET) {
- /* shigin: freebsd doesn't follow POSIX semantic of recv and fails
with
- * THRIFT_ECONNRESET if peer performed shutdown
- * edhall: eliminated close() since we do that in the destructor.
- */
return 0;
}
-#endif
-
-#ifdef _WIN32
--- End diff --
This sequence is needed for some platforms, did you some tests on windows?
Cannot shutdown TThreadedServer when clients are still connected
Key: THRIFT-2441
URL: https://issues.apache.org/jira/browse/THRIFT-2441
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9.1
Reporter: Chris Stylianou
Assignee: Ben Craig
Attachments: THRIFT-2441-prelim.patch
When calling stop() on the TThreadedServer no interrupts are sent to the
client threads. This means the stop() call blocks on tasksMonitor.wait()
until all client naturally disconnect.
How can we tell the client thread connections to close/exit during the
TThreadedServer::stop() call?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3088. - Resolution: Fixed committed TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket --- Key: THRIFT-3088 URL: https://issues.apache.org/jira/browse/THRIFT-3088 Project: Thrift Issue Type: Bug Components: Java - Library Affects Versions: 0.9 Reporter: Winger Pun Start TThreadPoolServer to server with TSaslServerTransport.Factory as transportFactory. While using nc to test the specified port whether reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket at once while successful connect TThreadPoolServer, but the server still try using sasl protocol to build an inputTransport which of course failed at once. However inputTransport is null which makes it can't close socket properly which lead to CLOSE_WAIT socket. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3084) C++ add concurrent client limit to threaded servers
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3084: --- Description: The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. With TThreadPoolServer one can set the limit on the number of threads, however the server will use one additional file descriptor because the serve() routine does not block until after accepting the threadManager size + 1 sockets. With TThreadedServer there was no built-in way to throttle. The solution is to add a Monitor to the TServerFramework and check the number of concurrent clients immediately before calling TServerTransport::accept() to get another client, and to track the number of clients that are still alive (their smart pointer hasn't been destroyed). was: The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. 1. Add a barrier to TServerTransport that will be checked before accept(). 2. In the onClientConnected override (see THRIFT-3083) if the server reaches the limit of the number of accepted clients, enable the barrier. 3. In the onClientDisconnected override if the count of connected clients falls below the maximum concurrent limit, clear the barrier. This will allow the limit to be changed dynamically at runtime (lowered) with drain off clients until more can be accepted. Alternate proposal: Implement a Semaphore and have the servers block the serve() thread if the client that arrived puts the server at the concurrent client limit. C++ add concurrent client limit to threaded servers --- Key: THRIFT-3084 URL: https://issues.apache.org/jira/browse/THRIFT-3084 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2 Reporter: James E. King, III Attachments: THRIFT-3084-on-3083.v2.patch The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. With TThreadPoolServer one can set the limit on the number of threads, however the server will use one additional file descriptor because the serve() routine does not block until after accepting the threadManager size + 1 sockets. With TThreadedServer there was no built-in way to throttle. The solution is to add a Monitor to the TServerFramework and check the number of concurrent clients immediately before calling TServerTransport::accept() to get another client, and to track the number of clients that are still alive (their smart pointer hasn't been destroyed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491619#comment-14491619
]
ASF GitHub Bot commented on THRIFT-3090:
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28205720
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
-include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
--- End diff --
SYSTEM implies -isystem for gcc/clang thus can avoid polluting log with
warnings from boost.
cmake build is broken
-
Key: THRIFT-3090
URL: https://issues.apache.org/jira/browse/THRIFT-3090
Project: Thrift
Issue Type: Bug
Environment: Mac OS X 10.10.3
C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0
(clang-600.0.57) (based on LLVM 3.5svn)
boost 1.57
cmake 3.2.1
Reporter: Marco Molteni
A current version of apache/thrift on github as of 2015-04-10 doesn't build
with cmake due to multiple errors:
- some C++ targets fail to link with missing symbols, because they do not
link against the `thrift` library
- the c_glib test targets fail to build because the reference to `shared_ptr`
is considered ambiguous by the compiler (it resolves to both boost and stdlib
shared_ptr)
See pull request https://github.com/apache/thrift/pull/434
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28205720
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
-include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
--- End diff --
SYSTEM implies -isystem for gcc/clang thus can avoid polluting log with
warnings from boost.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491624#comment-14491624 ] Randy Abernethy commented on THRIFT-3084: - Hey James, Thanks for the thorough response, I +1 your implementation, a big improvement over what we have now, so take this as what it is, just a collegial chat. My real focus here is that we do not want many servers that do the same or very similar things. It adds little value, confuses users and creates an additional maintenance burden on the maintainers (close to my heart). Some of the Apache Thrift languages have a crazy number of (more or less redundant) servers. People write blog post trying to compare them. Your patch was a lightning rod for removing code (TThreadedServer) which is the best thing you can do to a code base. Thanks for that! If you subscribe to the above minimum server axiom (which perhaps not all do), then a server should be in the code base because it brings something particularly unique to the table. The nonblocking server is event driven, the thread pool server is thread per client, an IOCompletion Port server is based on completion ports, an async server returns packets out of order, etc. So do we really want another synchronous, blocking, thread per client server? Shouldn’t we just have one good one? If we want just one good one, then is there a need for a shared framework base with implementation in it with a view on the processing model? The last thing I want to see is additional micro variations on the thread per client server theme. I also don’t want people to think they have to derive from TServerFramework (sounds pretty official). A server should implement TServer and that is really the only requirement. So what about simple server. I see SimpleServer as a special case. Its one goal is to be simple. At the end of the day, if it is only marginally different from TThreadPoolServer, maybe we should delete it too. Seems like it would be silly to implement SimpleServer in terms of TThreadPool. Yet we sort of are with the proposed framework classes. It is not adding unique value anymore, it isn’t any simpler than TThreadPool. This leaves us with a Framework class with one derivative TThreadPool and takes me back to wanting to just implement it in TThreadPool. I won’t bug you anymore on this, as I mentioned I am +1 on the patch. It is great work and though I am lobbying to package it a little differently, diverse views on things are a natural part of a vibrant community and it is your patch. Best, Randy C++ add concurrent client limit to threaded servers --- Key: THRIFT-3084 URL: https://issues.apache.org/jira/browse/THRIFT-3084 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2 Reporter: James E. King, III Attachments: THRIFT-3084-on-3083.v2.patch The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. With TThreadPoolServer one can set the limit on the number of threads, however the server will use one additional file descriptor because the serve() routine does not block until after accepting the threadManager size + 1 sockets. With TThreadedServer there was no built-in way to throttle. Give the serve() loop is the only code capable of adding a client, the solution is to add a Monitor to the TServerFramework and check the number of concurrent clients immediately before calling TServerTransport::accept() to get another client, and to track the number of clients that are still alive (their smart pointer hasn't been destroyed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28205714
--- Diff: lib/cpp/src/thrift/transport/TSocket.cpp ---
@@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
goto try_again;
}
-#if defined __FreeBSD__ || defined __MACH__
if (errno_copy == THRIFT_ECONNRESET) {
- /* shigin: freebsd doesn't follow POSIX semantic of recv and fails
with
- * THRIFT_ECONNRESET if peer performed shutdown
- * edhall: eliminated close() since we do that in the destructor.
- */
return 0;
}
-#endif
-
-#ifdef _WIN32
--- End diff --
Hi Roger, thanks for inspecting this closely. I determined that if one
called read() on a closed socket, it was not returning 0 like it should. It
turns out that the block seen above which was limiting the logic for handling
ECONNRESET to __FreeBSD__ and __MACH__ should be ubiquitous. If a read()
errors with ECONNRESET the proper response is to return 0 indicating EOF.
The WIN32 block is the same, given THRIFT_ECONNRESET == WSAECONNRESET when
_WIN32 is enabled. As such, now all platforms respond to connection reset
during read with 0, meaning EOF.
Does the CI build test framework test Windows and run the CMake tests? If
so, then the TServerIntegrationTest will test your concern. I did not run this
code on Windows to make sure it builds or passes tests, but I can do that on
Monday if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-3084) C++ add concurrent client limit to threaded servers
[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491675#comment-14491675 ] James E. King, III commented on THRIFT-3084: I agree, the difference between the ThreadedServer and the ThreadPoolServer is negligible. The ThreadedServer could simply vanish, and technically if one can live with the fact that the ThreadPoolServer accepts() one more connection than the thread pool can hold then THRIFT-3084 may not be necessary, however I like that with the change, we will not accept() more clients than we can handle, and let the OS handle the overflow with the listen backlog. A TThreadPoolServer with a pool size of 1 is quite similar to a simple server except it is using a separate thread for processing. In the end, we probably only need one threaded server that can admit [1..n] simultaneous clients. If that is the case, I agree with you, TServerFramework would simply roll into a single server that would be able to replace all three and provide the same functionality. I would be happy to turn the crank to that one more time as a follow-on to the current pipeline of changes. Consolidating the serve loop and extracting the essence of onClientConnected and onClientDisconnected made it much more clear that the similarities between these servers is quite high. As pointed out elsewhere, consolidating the servers into one would break backwards compatibility for the other two unless adapters were provided and that was seen as the only negative I can think of. C++ add concurrent client limit to threaded servers --- Key: THRIFT-3084 URL: https://issues.apache.org/jira/browse/THRIFT-3084 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2 Reporter: James E. King, III Attachments: THRIFT-3084-on-3083.v2.patch The TThreadedServer and TThreadPoolServer do not impose limits on the number of simultaneous connections, which is not useful in production as bad clients can drive a server to consume too many file descriptors or have too many threads. With TThreadPoolServer one can set the limit on the number of threads, however the server will use one additional file descriptor because the serve() routine does not block until after accepting the threadManager size + 1 sockets. With TThreadedServer there was no built-in way to throttle. Give the serve() loop is the only code capable of adding a client, the solution is to add a Monitor to the TServerFramework and check the number of concurrent clients immediately before calling TServerTransport::accept() to get another client, and to track the number of clients that are still alive (their smart pointer hasn't been destroyed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3014) AppVeyor support
[ https://issues.apache.org/jira/browse/THRIFT-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491679#comment-14491679 ] Hudson commented on THRIFT-3014: SUCCESS: Integrated in Thrift #1503 (See [https://builds.apache.org/job/Thrift/1503/]) THRIFT-3014 AppVeyor support - fix format (roger: rev 81b3c440c64a372b6e47f9cb50804bd60f83e83f) * lib/cpp/src/thrift/qt/CMakeLists.txt * lib/cpp/test/CMakeLists.txt * lib/cpp/test/qt/CMakeLists.txt * lib/c_glib/CMakeLists.txt * lib/cpp/CMakeLists.txt * CMakeLists.txt * appveyor.yml * lib/java/CMakeLists.txt * compiler/cpp/CMakeLists.txt AppVeyor support Key: THRIFT-3014 URL: https://issues.apache.org/jira/browse/THRIFT-3014 Project: Thrift Issue Type: Bug Components: Build Process Environment: Windows Reporter: Roger Meier Assignee: Roger Meier Attachments: appveyor.yml same as travis on linux is appveyor for WIndows see it in action here: https://ci.appveyor.com/project/bufferoverflow/thrift/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3061) C++ TSSLSocket shutdown delay/vulnerability
[
https://issues.apache.org/jira/browse/THRIFT-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier closed THRIFT-3061.
---
committed
C++ TSSLSocket shutdown delay/vulnerability
---
Key: THRIFT-3061
URL: https://issues.apache.org/jira/browse/THRIFT-3061
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2
Reporter: James E. King, III
Assignee: Roger Meier
Labels: OpenSSL, SSL
Attachments: THRIFT-3061.patch
In the C++ implementation of TSSLSocket, during close() the following code
sequence is found:
{noformat}
void TSSLSocket::close() {
if (ssl_ != NULL) {
int rc = SSL_shutdown(ssl_);
if (rc == 0) {
rc = SSL_shutdown(ssl_);
}
{noformat}
According to the OpenSSL documentation, while it is nice to attempt to
shutdown SSL in this way, it is not required when the code is performing a
unilateral shutdown (meaning the underlying connection will be closed). It
is only necessary to call SSL_Shutdown twice like this if the socket (and
configured SSL therein) is going to be reused.
It is possible to have a misbehaving client that does not handle this part of
the shutdown process properly and fail to reply, and also fail to close. The
most likely embodiment would be a program designed specifically to fail to
reply to the close notify and hold the socket open in order to produce a
denial-of-service attack. Another possibility is a poorly written client.
Given the OpenSSL documentation states that calling SSL_Shutdown once is
sufficient when the socket is going to be closed, I recommend that we remove
the second SSL_Shutdown call and prevent something that can block the close()
call. We have seen this happen, and it interacts with THRIFT-2441.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-3061 eliminate potential for client to...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-3092) Generated Haskell types should derive Generic
[ https://issues.apache.org/jira/browse/THRIFT-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3092. - Resolution: Fixed Fix Version/s: 0.9.3 committed Generated Haskell types should derive Generic - Key: THRIFT-3092 URL: https://issues.apache.org/jira/browse/THRIFT-3092 Project: Thrift Issue Type: Improvement Components: Haskell - Compiler Reporter: Abhinav Gupta Fix For: 0.9.3 Generated Haskell types should have derived instances of the Generic typeclass. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is back to normal : Thrift-Compiler-Windows #1608
See https://builds.apache.org/job/Thrift-Compiler-Windows/1608/changes
[jira] [Commented] (THRIFT-3092) Generated Haskell types should derive Generic
[ https://issues.apache.org/jira/browse/THRIFT-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491689#comment-14491689 ] ASF GitHub Bot commented on THRIFT-3092: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/437 Generated Haskell types should derive Generic - Key: THRIFT-3092 URL: https://issues.apache.org/jira/browse/THRIFT-3092 Project: Thrift Issue Type: Improvement Components: Haskell - Compiler Reporter: Abhinav Gupta Fix For: 0.9.3 Generated Haskell types should have derived instances of the Generic typeclass. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3092) Generated Haskell types should derive Generic
[ https://issues.apache.org/jira/browse/THRIFT-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491710#comment-14491710 ] Hudson commented on THRIFT-3092: SUCCESS: Integrated in Thrift #1505 (See [https://builds.apache.org/job/Thrift/1505/]) THRIFT-3092 Generated Haskell types should derive Generic (roger: rev b1783a5722e7ab1669f5926c233ea40af0f3c924) * compiler/cpp/src/generate/t_hs_generator.cc Generated Haskell types should derive Generic - Key: THRIFT-3092 URL: https://issues.apache.org/jira/browse/THRIFT-3092 Project: Thrift Issue Type: Improvement Components: Haskell - Compiler Reporter: Abhinav Gupta Fix For: 0.9.3 Generated Haskell types should have derived instances of the Generic typeclass. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Build failed in Jenkins: Thrift-Compiler-Windows #1607
See https://builds.apache.org/job/Thrift-Compiler-Windows/1607/changes Changes: [roger] THRIFT-3014 AppVeyor support - fix format -- Started by an SCM change Building remotely on H11 (Ubuntu ubuntu) in workspace https://builds.apache.org/job/Thrift-Compiler-Windows/ws/ git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url https://git-wip-us.apache.org/repos/asf/thrift.git # timeout=10 Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/thrift.git git --version # timeout=10 git fetch --tags --progress https://git-wip-us.apache.org/repos/asf/thrift.git +refs/heads/*:refs/remotes/origin/* Seen branch in repository origin/0.1.x Seen branch in repository origin/0.2.x Seen branch in repository origin/0.3.x Seen branch in repository origin/0.4.x Seen branch in repository origin/0.5.x Seen branch in repository origin/0.6.x Seen branch in repository origin/0.7.x Seen branch in repository origin/0.8.x Seen branch in repository origin/0.9.1 Seen branch in repository origin/0.9.2 Seen branch in repository origin/0.9.x Seen branch in repository origin/master Seen branch in repository origin/py-compiler Seen 13 remote branches Checking out Revision 81b3c440c64a372b6e47f9cb50804bd60f83e83f (origin/master) git config core.sparsecheckout # timeout=10 git checkout -f 81b3c440c64a372b6e47f9cb50804bd60f83e83f git rev-list b1a35da9168cca5a7524ab9814161f024da145df # timeout=10 [Thrift-Compiler-Windows] $ /bin/bash -xe /tmp/hudson5358551138176960996.sh + sh bootstrap.sh Configuring for: PHP Api Version: 20121113 Zend Module Api No: 20121212 Zend Extension Api No: 220121212 configure.ac:90: installing './config.guess' configure.ac:90: installing './config.sub' configure.ac:27: installing './install-sh' configure.ac:27: installing './missing' compiler/cpp/Makefile.am:103: warning: source file 'src/thrifty.yy' is in a subdirectory, compiler/cpp/Makefile.am:103: but option 'subdir-objects' is disabled automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. compiler/cpp/Makefile.am:103: warning: source file 'src/thriftl.ll' is in a subdirectory, compiler/cpp/Makefile.am:103: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/main.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/md5.c' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/parse/t_typedef.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/parse/parse.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_c_glib_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_cpp_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_java_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_json_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_as3_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_haxe_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_csharp_generator.cc' is in a subdirectory, compiler/cpp/Makefile.am:34: but option 'subdir-objects' is disabled compiler/cpp/Makefile.am:34: warning: source file
[GitHub] thrift pull request: [haskell] Derive Generic in generated types
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491719#comment-14491719 ] Roger Meier commented on THRIFT-3090: - Ubuntu 14.04 LTS uses 2.8.12, see https://launchpad.net/ubuntu/+source/cmake so I guess we can go for 2.8.12 as the minimum required: cmake_minimum_required(VERSION 2.8.12) any concerns? cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3090) cmake build is broken
[ https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491760#comment-14491760 ] Nobuaki Sukegawa commented on THRIFT-3090: -- It seems CentOS 7 is stuck at 2.8.11 [1]. Interestingly CentOS 6.6 has 2.8.12 [2]. Seeing compatibility matrix[3], 2.8.12 is significantly better than 2.8.11, but we need to stop at 2.8.11 for now ? Older version results in somewhat reduced readability and productivity but surely not fatal. [1] http://mirror.centos.org/centos/7/os/x86_64/Packages/ [2] http://mirror.centos.org/centos/6/os/x86_64/Packages/ [3] http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix/Commands cmake build is broken - Key: THRIFT-3090 URL: https://issues.apache.org/jira/browse/THRIFT-3090 Project: Thrift Issue Type: Bug Environment: Mac OS X 10.10.3 C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) boost 1.57 cmake 3.2.1 Reporter: Marco Molteni A current version of apache/thrift on github as of 2015-04-10 doesn't build with cmake due to multiple errors: - some C++ targets fail to link with missing symbols, because they do not link against the `thrift` library - the c_glib test targets fail to build because the reference to `shared_ptr` is considered ambiguous by the compiler (it resolves to both boost and stdlib shared_ptr) See pull request https://github.com/apache/thrift/pull/434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
