[GitHub] tinkerpop issue #382: TINKERPOP-989 Add a landing page for documentation.

2016-08-16 Thread twilmes
Github user twilmes commented on the issue:

https://github.com/apache/tinkerpop/pull/382
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-989) Default documentation should be reference/index.html

2016-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423127#comment-15423127
 ] 

ASF GitHub Bot commented on TINKERPOP-989:
--

Github user PommeVerte commented on the issue:

https://github.com/apache/tinkerpop/pull/382
  
+1


> Default documentation should be reference/index.html
> 
>
> Key: TINKERPOP-989
> URL: https://issues.apache.org/jira/browse/TINKERPOP-989
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.1.0-incubating
>Reporter: Marko A. Rodriguez
>Priority: Minor
>
> Now that we put the docs into folders, the base URL is a directory structure: 
> http://tinkerpop.incubator.apache.org/docs/3.1.1-SNAPSHOT/ ...  should we 
> have this default to reference/index.html? I think so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (TINKERPOP-1405) profile() doesn't like withPath()

2016-08-16 Thread Ted Wilmes (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Wilmes closed TINKERPOP-1405.
-

> profile() doesn't like withPath()
> -
>
> Key: TINKERPOP-1405
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1405
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Ted Wilmes
> Fix For: 3.2.2
>
>
> {{profile()}} fails when used in conjunction with {{withPath()}}:
> {code}
> gremlin> g.withPath().V().profile()
> When specified, the profile()-Step must be the last step or followed only by 
> the cap()-step.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #381: TINKERPOP-1405 - profile() doesn't like withPat...

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1405) profile() doesn't like withPath()

2016-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422874#comment-15422874
 ] 

ASF GitHub Bot commented on TINKERPOP-1405:
---

Github user twilmes commented on the issue:

https://github.com/apache/tinkerpop/pull/381
  
Good suggestions Daniel.  I pushed the cleaned up code.  Tests were good on 
my side but I'll wait for Travis to finish up and merge if all is good.


> profile() doesn't like withPath()
> -
>
> Key: TINKERPOP-1405
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1405
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Ted Wilmes
> Fix For: 3.2.2
>
>
> {{profile()}} fails when used in conjunction with {{withPath()}}:
> {code}
> gremlin> g.withPath().V().profile()
> When specified, the profile()-Step must be the last step or followed only by 
> the cap()-step.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [DISCUSS] driver for gremlin-python

2016-08-16 Thread Dylan Millikin
Here are a couple ideas :

Simple : If we go the docker way, generate a test result recap file with
testIds that correspond to TinkerPop enforced tests. That way the test suit
can determine if a test was not performed or if a test failed. The testIds
would work something along the lines of  :
#1 : establish connection
#2 : test text/script for g.V()
#3 : test bytecode for g.V()
#4 : etc..

So your resulting recap file could be as simple as the above with
true/false markers next to the IDs. This means we still need to code the
tests in each language but at least there's good quality control.

Complexe: Allow GLVs to reverse Bytecode into their language.
[
[V, 1]
[outE, 'created']
[inV]
[repeat, [
[out, 'created']
[in, 'created']
]
[times, 5]
[valueMap, 'name', 'age']
]

would become

graph.traversal().V(1).outE('created').inV().repeat(out('created').in('created')).times(5).valueMap('name',
'age') in gremlin-groovy

$graph->traversal()->
V(1)->outE('created')->inV()->repeat($graph->traversal()->out('created')->in('created'))->times(5)->valueMap('name',
'age') in gremlin-php

etc...

This would have the advantage of allowing users to seamlessly translate
gremlin-x to their own language or any other (imagine documentation where
you can let users switch to their language dynamically or generate Cypher
from your glv, etc.). So long as lambdas aren't involved of course.

This could also allow us to make some TestProcessor for gremlin-server that
would submit code to exec to the clients and then test the request
messages. In which case all GLV test cases would be covered in one spot and
submitted to the GLVs. This has the downside of not really allowing lower
level driver testing though.

Crazy/impossible : Do the above but turn Bytecode into a language agnostic
language. Run any code you want in any language ;p  just sayin'





On Tue, Aug 16, 2016 at 9:45 AM, Stephen Mallette 
wrote:

> Yeah - (1) is stinky. The more I think about it the more I don't think
> there is value in validating gremlin-python over Jython, if Jython is not
> up to date and, perhaps more importantly, not the environment users will
> run their code in. Doesn't seem to have much value in that case. Perhaps
> for 3.2.2 we don't have to try to tackle this testing issue completely.
>
> On Tue, Aug 16, 2016 at 9:31 AM, Dylan Millikin 
> wrote:
>
> > For 1) maybe now is a good time to look into using docker for testing?
> That
> > would have it's own issues in the fact that testing would have to be
> > written directly in python so you would loose reusability for future GLVs
> > though.
> >
> > I'm not sure how to build a test suit that would either work across all
> > languages or enforce behaviors in all GLVs. I know this came up before I
> > just can't seem to find those issues. Might not be searching properly.
> >
> >
> > On Mon, Aug 15, 2016 at 4:29 PM, Stephen Mallette 
> > wrote:
> >
> > > After some review and tweaks, this PR from David just merged which got
> > the
> > > Python RemoteConnection going on TINKERPOP-1278:
> > >
> > > https://github.com/apache/tinkerpop/pull/379
> > >
> > > Still some work to do here:
> > >
> > > 1. Proper testing for Python's RemoteConnection implementation - ran
> into
> > > problems getting everything running under jython which is sorta out of
> > date
> > > with the latest python stuff. still trying to figure out what we want
> to
> > do
> > > there with respect to testing. basically we get some dependency errors
> > > around Python's fcntl, possibly related to: http://bugs.jython.org/
> > > issue1943
> > > - not completely sure what to do about that. On one hand we're using
> > Jython
> > > to test client side operations in the JVM environment so that we can
> get
> > > some re-use out of the full gremlin test suite (that's the good side).
> On
> > > the downside, no one will likely execute their gremlin-python code in
> > > Jython, we get bound to python 2.x where Jython appears largely stuck
> and
> > > we can't really work our way out of that bug anyway.  Anyway, Jython
> > still
> > > remains useful on the server where it will let us process python
> lambdas
> > > embedded in traversals - so even though you'd be bound to jython and
> > python
> > > 2.x for those lambdas that's still pretty neat. Solving this testing
> > issue
> > > is a top priority I think.
> > >
> > > 2. Making an actual "driver". Dave's PR focused on getting a Python
> > > RemoteConnection built, but it would be nice if the code that sent the
> > > request to the server was extracted a bit so that users could
> > instantiate a
> > > low-level driver to submit raw scripts and custom request messages. In
> > that
> > > way it would be in line with how gremlin-driver works for Java and we'd
> > > have some consistency for our first two languages in this department.
> > >
> > > 3. Returning side-effects. I documented the new TraversalOpProcessor in
> > the
> > > 

[jira] [Commented] (TINKERPOP-1405) profile() doesn't like withPath()

2016-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422773#comment-15422773
 ] 

ASF GitHub Bot commented on TINKERPOP-1405:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/381
  
Nice find. I really do hate `RequirementsStep`.

VOTE +1.


> profile() doesn't like withPath()
> -
>
> Key: TINKERPOP-1405
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1405
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Ted Wilmes
> Fix For: 3.2.2
>
>
> {{profile()}} fails when used in conjunction with {{withPath()}}:
> {code}
> gremlin> g.withPath().V().profile()
> When specified, the profile()-Step must be the last step or followed only by 
> the cap()-step.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #381: TINKERPOP-1405 - profile() doesn't like withPath()

2016-08-16 Thread okram
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/381
  
Nice find. I really do hate `RequirementsStep`.

VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop pull request #381: TINKERPOP-1405 - profile() doesn't like withPat...

2016-08-16 Thread twilmes
GitHub user twilmes opened a pull request:

https://github.com/apache/tinkerpop/pull/381

TINKERPOP-1405 - profile() doesn't like withPath()

Fixed a small bug in `StandardVerificationStrategy` that caused 
verification to fail when `withPath` was used in conjunction with 
`ProfileStep`.  Updated `StandardVerificationStrategyTest` to test traversals 
with `ProfileStep` and added a test to confirm verification failed on a 
reducing barrier nested within a repeat while I was at it.

This issue did not arise in TP31 so I took a look and the TP31 
`StandardVerificationStrategy` does not have the `ProfileStep` and some other 
verification verification logic in it that is in master.  Because of this, I 
pointed this PR only at master but can re-point to TP31 and add the profile 
step verification in if you guys think that makes sense.

The Travis build appears to have stalled out while downloading artifacts.  
Tests passed local with `mvn clean install`

```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 24:25 min
[INFO] Finished at: 2016-08-16T08:43:01-05:00
[INFO] Final Memory: 140M/843M
[INFO] 

```

VOTE: +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1405

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #381


commit 226d83e903dc16f5d6da644d7069bb1b54c3878b
Author: Ted Wilmes 
Date:   2016-08-16T13:04:28Z

TINKERPOP-1405 Fixed a small bug in StandardVerificationStrategy that 
caused verification to fail when withPath was used in conjunction with 
ProfileStep.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1405) profile() doesn't like withPath()

2016-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422761#comment-15422761
 ] 

ASF GitHub Bot commented on TINKERPOP-1405:
---

GitHub user twilmes opened a pull request:

https://github.com/apache/tinkerpop/pull/381

TINKERPOP-1405 - profile() doesn't like withPath()

Fixed a small bug in `StandardVerificationStrategy` that caused 
verification to fail when `withPath` was used in conjunction with 
`ProfileStep`.  Updated `StandardVerificationStrategyTest` to test traversals 
with `ProfileStep` and added a test to confirm verification failed on a 
reducing barrier nested within a repeat while I was at it.

This issue did not arise in TP31 so I took a look and the TP31 
`StandardVerificationStrategy` does not have the `ProfileStep` and some other 
verification verification logic in it that is in master.  Because of this, I 
pointed this PR only at master but can re-point to TP31 and add the profile 
step verification in if you guys think that makes sense.

The Travis build appears to have stalled out while downloading artifacts.  
Tests passed local with `mvn clean install`

```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 24:25 min
[INFO] Finished at: 2016-08-16T08:43:01-05:00
[INFO] Final Memory: 140M/843M
[INFO] 

```

VOTE: +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1405

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #381


commit 226d83e903dc16f5d6da644d7069bb1b54c3878b
Author: Ted Wilmes 
Date:   2016-08-16T13:04:28Z

TINKERPOP-1405 Fixed a small bug in StandardVerificationStrategy that 
caused verification to fail when withPath was used in conjunction with 
ProfileStep.




> profile() doesn't like withPath()
> -
>
> Key: TINKERPOP-1405
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1405
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Daniel Kuppitz
>Assignee: Ted Wilmes
> Fix For: 3.2.2
>
>
> {{profile()}} fails when used in conjunction with {{withPath()}}:
> {code}
> gremlin> g.withPath().V().profile()
> When specified, the profile()-Step must be the last step or followed only by 
> the cap()-step.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Adding IBM Graph to the providers list

2016-08-16 Thread Marko Rodriguez
Hello,

I updated the TinkerPop providers page this morning.

http://tinkerpop.apache.org/providers.html 


In order to make IBM Graph’s listing consistent with the other listings, I did 
a few changes.

1. I made the product description a bit more concise so the blurb sat 
nicely formatted on the page.
2. I added “IBM Graph” to Alaa’s provided logo as all logos need a 
graphic+text.
3. I href’d to a “cleaner” (less documentation oriented) IBM Graph 
product page.

Alaa, please review what I did and if there are any updates/changes you would 
like, please advise and I will handle them immediately.

Thank you very much for having Apache TinkerPop be apart of IBM’s product.

Take care,
Marko.

http://markorodriguez.com



> On Aug 15, 2016, at 2:37 PM, Alaa Mahmoud  wrote:
> 
> Thanks Marko!
> 
> Please let me know when the page is updated.
> 
> Thanks
> Alaa
> 
> On Fri, Aug 12, 2016 at 10:03 AM, Marko Rodriguez 
> wrote:
> 
>> Hello,
>> 
>> Assuming no one has any objections, I will update the homepage on Monday
>> 8am (lazy consensus) with IBMGraph’s logo and “bio."
>> 
>> Thanks,
>> Marko.
>> 
>> http://markorodriguez.com
>> 
>> 
>> 
>>> On Aug 11, 2016, at 12:58 PM, Alaa Mahmoud  wrote:
>>> 
>>> Here a link to the logo that I looked up pretty quickly. it'll do the job
>>> :-)
>>> http://cdn.geekwire.com/wp-content/uploads/2016/07/
>> GraphDB-FA-big-hero-300x295.png
>>> 
>>> Alaa
>>> 
>>> On Thu, Aug 11, 2016 at 2:04 PM, Stephen Mallette 
>>> wrote:
>>> 
 might need to ship it some other way - dev list doesn't like
>> attachments i
 don't think.
 
 On Thu, Aug 11, 2016 at 1:52 PM, Marko Rodriguez 
 wrote:
 
> Hi Alaa,
> 
> I don’t think the logo came through, can you please reattach?
> 
> Thank you,
> Marko.
> 
> http://markorodriguez.com
> 
> 
> 
>> On Aug 11, 2016, at 10:57 AM, Alaa Mahmoud 
 wrote:
>> 
>> Can someone help add IBM Graph to the list of providers
> http://tinkerpop.apache.org/providers.html <
>> http://tinkerpop.apache.org/
> providers.html>.
>> 
>> Product info
>> IBM Graph >> 
> – is an easy-to-use, fully-managed graph database-as-a-service.
> Administered through the cloud platform Bluemix, it is easy to start
 small
> and scale seamlessly as user data grows.  IBM Graph is available 24/7
>> and
> managed by a team of experts so developers can focus on building their
> application. Based on the Apache TinkerPop stack for building
> high-performance graph applications, IBM Graph provides users with a
>> set
 of
> simplified HTTP API calls, a TinkerPop v3 compatible API, and the
>> Gremlin
> graph traversal language.
>> 
>> Here's the link
>> https://console.ng.bluemix.net/catalog/services/ibm-graph/ <
> https://console.ng.bluemix.net/catalog/services/ibm-graph/>
>> 
>> Logo
>> Is attached
>> 
>> Regrads
>> Alaa
> 
> 
 
>> 
>> 



[jira] [Closed] (TINKERPOP-1402) Impossible for graph implementations to provide a class resolver for Gryo IO

2016-08-16 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1402.
---
Resolution: Done
  Assignee: stephen mallette

> Impossible for graph implementations to provide a class resolver for Gryo IO
> 
>
> Key: TINKERPOP-1402
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1402
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.2.2
>
>
> As far as I can tell there is no way for a graph implementation to specify a 
> classresolver for the following code:
> {noformat}g.io(IoCore.gryo()).writer().create(){noformat}
> The problem is that inside the graph implementation we need to be able to do 
> this:
> {noformat}
> public  I io(final Io.Builder builder) {
>   Io io = 
> builder.graph(this).registry(MyRegistry.INSTANCE).classResolver(MyClassReolver.INSTANCE).create();
> {noformat}
> but only supplying a registry is supported.
> Other solutions could be to design GryoIo for extension so that it can be 
> wrapped or to change the signature of Graph#io to:
> {noformat}
> public default Io io(final Io.Builder builder)
> {noformat}
> I would probably go for the signature change, so the graph is responsible for 
> deciding the implementation that is returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop pull request #380: TINKERPOP-1402 Added IoBuilder.onMapper() metho...

2016-08-16 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/380


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1407) Default serializers for Gremlin Server

2016-08-16 Thread Dylan Millikin (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422724#comment-15422724
 ] 

Dylan Millikin commented on TINKERPOP-1407:
---

+1 on this 

> Default serializers for Gremlin Server
> --
>
> Key: TINKERPOP-1407
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1407
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.2.1
>Reporter: stephen mallette
>Priority: Minor
>
> If no serializers are configured then Gremlin Server is basically inoperable. 
> It probably shouldn't work that way. Would be better if some default 
> serializers were configured in that case - maybe gryo and the base graphson.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1402) Impossible for graph implementations to provide a class resolver for Gryo IO

2016-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422683#comment-15422683
 ] 

ASF GitHub Bot commented on TINKERPOP-1402:
---

Github user twilmes commented on the issue:

https://github.com/apache/tinkerpop/pull/380
  
VOTE: +1


> Impossible for graph implementations to provide a class resolver for Gryo IO
> 
>
> Key: TINKERPOP-1402
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1402
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Priority: Critical
> Fix For: 3.2.2
>
>
> As far as I can tell there is no way for a graph implementation to specify a 
> classresolver for the following code:
> {noformat}g.io(IoCore.gryo()).writer().create(){noformat}
> The problem is that inside the graph implementation we need to be able to do 
> this:
> {noformat}
> public  I io(final Io.Builder builder) {
>   Io io = 
> builder.graph(this).registry(MyRegistry.INSTANCE).classResolver(MyClassReolver.INSTANCE).create();
> {noformat}
> but only supplying a registry is supported.
> Other solutions could be to design GryoIo for extension so that it can be 
> wrapped or to change the signature of Graph#io to:
> {noformat}
> public default Io io(final Io.Builder builder)
> {noformat}
> I would probably go for the signature change, so the graph is responsible for 
> deciding the implementation that is returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] tinkerpop issue #380: TINKERPOP-1402 Added IoBuilder.onMapper() method.

2016-08-16 Thread twilmes
Github user twilmes commented on the issue:

https://github.com/apache/tinkerpop/pull/380
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (TINKERPOP-1402) Impossible for graph implementations to provide a class resolver for Gryo IO

2016-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422657#comment-15422657
 ] 

ASF GitHub Bot commented on TINKERPOP-1402:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/380
  
VOTE: +1


> Impossible for graph implementations to provide a class resolver for Gryo IO
> 
>
> Key: TINKERPOP-1402
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1402
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Priority: Critical
> Fix For: 3.2.2
>
>
> As far as I can tell there is no way for a graph implementation to specify a 
> classresolver for the following code:
> {noformat}g.io(IoCore.gryo()).writer().create(){noformat}
> The problem is that inside the graph implementation we need to be able to do 
> this:
> {noformat}
> public  I io(final Io.Builder builder) {
>   Io io = 
> builder.graph(this).registry(MyRegistry.INSTANCE).classResolver(MyClassReolver.INSTANCE).create();
> {noformat}
> but only supplying a registry is supported.
> Other solutions could be to design GryoIo for extension so that it can be 
> wrapped or to change the signature of Graph#io to:
> {noformat}
> public default Io io(final Io.Builder builder)
> {noformat}
> I would probably go for the signature change, so the graph is responsible for 
> deciding the implementation that is returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (TINKERPOP-1408) Remove Deprecated Io.Builder.registry()

2016-08-16 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-1408:
---

 Summary: Remove Deprecated Io.Builder.registry()
 Key: TINKERPOP-1408
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1408
 Project: TinkerPop
  Issue Type: Improvement
  Components: io
Affects Versions: 3.2.1
Reporter: stephen mallette
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (TINKERPOP-1407) Default serializers for Gremlin Server

2016-08-16 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-1407:
---

 Summary: Default serializers for Gremlin Server
 Key: TINKERPOP-1407
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1407
 Project: TinkerPop
  Issue Type: Improvement
  Components: server
Affects Versions: 3.2.1
Reporter: stephen mallette
Priority: Minor


If no serializers are configured then Gremlin Server is basically inoperable. 
It probably shouldn't work that way. Would be better if some default 
serializers were configured in that case - maybe gryo and the base graphson.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)