[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/386 I think I agree with @newkek to push that off until we can get his massive PR reviewed/merged. Let's see if we can solve that separately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429055#comment-15429055 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/386 I think I agree with @newkek to push that off until we can get his massive PR reviewed/merged. Let's see if we can solve that separately. > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.2 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]
Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/386 A remark: @okram requested `TraversalExplanation` to be included in the list of Graph objects. I've noticed that the current `TraversalExplanation` Graphson serializer serializes a `Traversal`. In order to follow the requirement of this GraphSON2.0 type system, we would have to write a deserializer for the `TraversalExplanation` (there isn't currently). However, the current 1.0 serializer serializes the Traversal as the `toString()` of the Traversal's step list, which means that it is not possible to deserialize to a Traversal with only such info. So I believe it would be more appropriate to wait for TP1278 before implementing the `TraversalExplanation` ser/de and leave it out of the scope of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428950#comment-15428950
]
ASF GitHub Bot commented on TINKERPOP-1037:
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/384#discussion_r75560386
--- Diff:
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/GremlinGroovysh.groovy
---
@@ -45,12 +46,13 @@ class GremlinGroovysh extends Groovysh {
Command findCommand(final String line, final List parsedArgs =
null) {
def l = line ?: ""
-final List args = parseLine(l)
-if (args.size() == 0) return null
+final List linetokens = parseLine(l)
+if (linetokens.size() == 0) return null
-def cmd = registry.find(args[0])
+def cmd = registry.find(linetokens[0])
-if (cmd != null && args.size() > 1 && parsedArgs != null) {
+if (cmd != null && linetokens.size() > 1 && parsedArgs != null) {
+List args = CommandArgumentParser.parseLine(line,
parsedArgs == null ? 1 : -1)
--- End diff --
groovysh added this line 1 month after this code was written.
> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it
> would be nice to have some coloring in the output. For example coloring the
> edges in the textual output.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/384#discussion_r75560386
--- Diff:
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/GremlinGroovysh.groovy
---
@@ -45,12 +46,13 @@ class GremlinGroovysh extends Groovysh {
Command findCommand(final String line, final List parsedArgs =
null) {
def l = line ?: ""
-final List args = parseLine(l)
-if (args.size() == 0) return null
+final List linetokens = parseLine(l)
+if (linetokens.size() == 0) return null
-def cmd = registry.find(args[0])
+def cmd = registry.find(linetokens[0])
-if (cmd != null && args.size() > 1 && parsedArgs != null) {
+if (cmd != null && linetokens.size() > 1 && parsedArgs != null) {
+List args = CommandArgumentParser.parseLine(line,
parsedArgs == null ? 1 : -1)
--- End diff --
groovysh added this line 1 month after this code was written.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/384 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428886#comment-15428886 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/384 The colorization stuff looks good. One small problem I've run into is that you can't set a prompt string that contains spaces. For example, I tried `:set result.prompt 'result => '` and got this error message: ```Command ':set' requires arguments: []``` Setting the preference containing spaces from `groovysh` works fine. It appears to be specific to Gremlin Console, and it is reproducible in 3.2.1 without this PR. Would be fine to handle this bug as a separate JIRA. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428875#comment-15428875 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/386 *NB: the conflicts for merge are caused by the CHANGELOG* > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.2 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]
Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/386 *NB: the conflicts for merge are caused by the CHANGELOG* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428820#comment-15428820
]
ASF GitHub Bot commented on TINKERPOP-1274:
---
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/386
Hey @okram ,
> 1. The term is "namespace" not "domain." In case that terminology is used
in the documentation and not just in the PR notes.
Ok, it's some places here and there in the code, I'll correct it.
> 2. Why do we have `@class` and `@type`.
`@class` shouldn't be anywhere near GraphSON 2.0 anymore, everything is
`@type`, if you've seen it somewhere, that should be corrected. While writing
that I realise I might have forgotten to update the "the-graph.asciidoc" doc...
so I'll correct it. But in the actual code it shouldn't be there anymore.
> 3. I read your notes, but its still not clear to me. Why do we have
`@value`? I think we [...]
So, taking a step back and I'm going to use the exampleof ByteCode. As you
can see in the `GraphSONSerializersV2d0`, serializers don't have to care
anymore about types, serializer are put into the context of "You're in a place
where you can write whatever you want, type is handled somewhere else for you".
For the ByteCode serializer it means it would open a Map, put a field
"language" and its value, put a field "argument" and its value, put a field
"value" (or call it "bytecode") and its value, close the map. When
deserializing, read the map, get the fields values, create the ByteCode object.
Let's admit for whatever reason the ByteCode serializer in the future needs
to change and instead of writing a Map, it needs to start by an Array where the
first element of the array is 'something', the rest is the Map described
before, and close the array. Doing this is currently possible with the current
format `{"@type":"typename", "@value":value}`, because the serializer is in a
place where it can write whatever it wants to.
Now let's consider another format: `{"@type":"typename", value}`. There,
the serializer is put in the context "You are currently in a **Map**, whatever
you write, it must be in the form of a key/value pair". The "potential future"
evolution of the ByteCode serializer (writing an array) *wouldn't* be possible.
For the sake of consistency, I think it is important to keep the format as is
> 4. I think we can save some bytes and still be readable if we make our
namespace g
Totally fine with `g`, again for the sake of consistency, I think it'd be
valuable to have a 'name space' all the time.
> GraphSON Version 2.0
>
>
> Key: TINKERPOP-1274
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Priority: Minor
> Fix For: 3.2.2
>
>
> Develop a revised version of GraphSON that provides better support for
> non-JVM languages that consume it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428781#comment-15428781 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/384 awesome!! VOTE: +1 from me as well > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/384 awesome!! VOTE: +1 from me as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[
https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428775#comment-15428775
]
ASF GitHub Bot commented on TINKERPOP-1037:
---
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/384#discussion_r75548087
--- Diff:
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
---
@@ -66,12 +72,48 @@ class Console {
public static final String PREFERENCE_ITERATION_MAX = "max-iteration"
private static final int DEFAULT_ITERATION_MAX = 100
private static int maxIteration = DEFAULT_ITERATION_MAX
+
+ public static final String PREF_GREMLIN_COLOR = "gremlin.color"
+def gremlinColor = { Preferences.get(PREF_GREMLIN_COLOR, "reset") }
+
--- End diff --
Got a mix of tab and space indenting going on here. The [dev
docs](http://tinkerpop.apache.org/docs/current/dev/developer/#_code_style)
don't call for one over the other, but most Java/Groovy files in the repo use
spaces only.
> Gremlin shell output coloring
> -
>
> Key: TINKERPOP-1037
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1037
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.1.0-incubating
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> In order to increase the readability of the output from the gremlin shell, it
> would be nice to have some coloring in the output. For example coloring the
> edges in the textual output.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/384#discussion_r75548087
--- Diff:
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
---
@@ -66,12 +72,48 @@ class Console {
public static final String PREFERENCE_ITERATION_MAX = "max-iteration"
private static final int DEFAULT_ITERATION_MAX = 100
private static int maxIteration = DEFAULT_ITERATION_MAX
+
+ public static final String PREF_GREMLIN_COLOR = "gremlin.color"
+def gremlinColor = { Preferences.get(PREF_GREMLIN_COLOR, "reset") }
+
--- End diff --
Got a mix of tab and space indenting going on here. The [dev
docs](http://tinkerpop.apache.org/docs/current/dev/developer/#_code_style)
don't call for one over the other, but most Java/Groovy files in the repo use
spaces only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TINKERPOP-709) Consider Bounding Gremlin Pool Queue Size
[
https://issues.apache.org/jira/browse/TINKERPOP-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428760#comment-15428760
]
stephen mallette commented on TINKERPOP-709:
After next bump of netty (4.0.40) might be able to make use of this:
https://github.com/netty/netty/pull/5440
> Consider Bounding Gremlin Pool Queue Size
> -
>
> Key: TINKERPOP-709
> URL: https://issues.apache.org/jira/browse/TINKERPOP-709
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.0.2-incubating
>Reporter: stephen mallette
>
> Wonder if it's a good idea to make the queue size to the "gremlinPool"
> configurable and thus bounded.
> {code}
> final BlockingQueue queue = new ArrayBlockingQueue<>(queueSize);
> gremlinExecutorService = new ThreadPoolExecutor(n, n,
> 0L, TimeUnit.MILLISECONDS,
> queue);
> {code}
> If the queue exceeded {{queueSize}} it would throw:
> {{RejectedExecutionException}}. This approach would also provide another
> metric to capture/report: {{queue.size()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428759#comment-15428759 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/384 Good news, it works on Windows. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428739#comment-15428739 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/384 _hoping I don't have to fire up that old machine_ :) > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428736#comment-15428736 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/384 @pluradj sucks the wind out of the PR - hahaha > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/384 _hoping I don't have to fire up that old machine_ :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/384 @pluradj sucks the wind out of the PR - hahaha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/384 @robertdale did you test this on Windows? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428732#comment-15428732 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/384 @robertdale did you test this on Windows? > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428712#comment-15428712 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/384 VOTE +1. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428702#comment-15428702 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I'm done with changes. Carry on. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I'm done with changes. Carry on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428672#comment-15428672 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I think I'll leave templating for another jira ticket. :satisfied: Currently, themes (really any `:set` commands) can be saved into files and loaded with `:load my-gremlin.theme`. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I think I'll leave templating for another jira ticket. :satisfied: Currently, themes (really any `:set` commands) can be saved into files and loaded with `:load my-gremlin.theme`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/384 Great. What do you think about `:set color.template=black-background`, `:set color.template=white-background`, etc. And then from there, those "MACRO" command will trigger a series of set error, message, gremlin, etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428658#comment-15428658 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/384 Great. What do you think about `:set color.template=black-background`, `:set color.template=white-background`, etc. And then from there, those "MACRO" command will trigger a series of set error, message, gremlin, etc. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428652#comment-15428652 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/386 First off. Thank you for doing this. Here are some notes. 1. The term is "namespace" not "domain." In case that terminology is used in the documentation and not just in the PR notes. 2. Why do we have `@class` and `@type`. Seems we should just pick one. And if the answer is cause `@class` is for Java object mapping infrastructure, that isn't good and we will also use GraphSON to create `Vertex` objects in Python and it might use UUID for its ID as well. Thus, `@class=UUID` is perhaps `@type=UUID`. That is, if an object is "typed" its `@type` and the resolver (for that language) will have to map the correct class. 3. I read your notes, but its still not clear to me. Why do we have `@value`? I think we only need `@type` (or `@class`) and then the rest of the JSON object data is up to the type serializer/deserializer. For instance, in `Bytecode` (TINKEROP-1278) we have `@type=Lambda` and then `value`, `language`, `arguments`. That is, there are 3 "values" we need to make the object and thus `@value` shouldn't be special with a `@`. Plus, we save a char. 4. I think we can save some bytes and still be readable if we make our namespace `g` instead of `gremlin`. Moreover, we should be consistent in our naming convention and either use some standard JSON naming or default to Java naming -- e.g. `g:vertexProperty`. Or better yet, if its NOT namespaced, its assumed to be "Gremlin". That is, TinkerPop owns `vertex`, `vertexProperty`, `edge`. You want to do something else -- its `myapp:vertex`. This also means we own `uuid`, `int64`, etc. etc. Thanks again for the extensive work. > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.2 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 Disco disco! ANSI is enabled by default. This is actually not a change. It was this way before this PR. No color scheme by default. If you want colors, you have to set them yourself. Added colorizing for String, Number, and values within Iterables. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428614#comment-15428614 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 Disco disco! ANSI is enabled by default. This is actually not a change. It was this way before this PR. No color scheme by default. If you want colors, you have to set them yourself. Added colorizing for String, Number, and values within Iterables. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428465#comment-15428465 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/351 Closing this in favor of #386. > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.2 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/351 Closing this in favor of #386. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #351: TINKERPOP-1274: GraphSON 2.0.
Github user newkek closed the pull request at: https://github.com/apache/tinkerpop/pull/351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0
[
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428462#comment-15428462
]
ASF GitHub Bot commented on TINKERPOP-1274:
---
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/386
TINKERPOP-1274: GraphSON 2.0 [revised]
For context, a precise description is provided in the PR for the first
version of the fix: #351. Please see this first for initial context.
This PR provides initial set of features defined in #351, plus the
following:
- Types for Graph objects.
- Types for **all** numeric values.
- New type IDs format.
- Avoid serializing empty properties field.
As a reminder the format for types is the following:
- A value not typed : `value`
- A value typed : `{"@type":"typeName", "@value":value}`
## New type IDs format
A type ID is now composed of 2 parts, the "domain" and the type name. A
"domain" can be used by any implementor to implement their own data type,
avoiding collisions with the existing TinkerPop type IDs. The default domain
for Graph object is "gremlin".
## Types for all numeric values
A type is now present for every numeric value, the types have been renamed
to be more understandable with regards to their memory sizes or kinds. As a
reference, here is a description of all currently existing types and their
corresponding Java implementation:
- Java `Integer`: "gremlin:int32"
- Java `Long`: "gremlin:int64"
- Java `Short`: "gremlin:int16"
- Java `Float`: "gremlin:float"
- Java `Double`: "gremlin:double"
## Types for all Graph objects.
New typeIDs introduced in #351 (time types, UUIDs, etc..) now follow the
type format defined here: "domain:typename".
Types have now been included for Graph-specific objects, here is an
exhaustive list of the existing types handled so far and their corresponding
IDs:
- `Vertex` -> "gremlin:vertex"
- `Edge` -> "gremlin:edge"
- `VertexPropery` -> "gremlin:vertexproperty"
- `Property` -> "gremlin:property"
- `Path` -> "gremlin:path"
- `Tree` -> "gremlin:tree"
- `Graph` -> "gremlin:graph"
- `Metrics` -> "gremlin:metrics"
- `TraversalMetrics` -> `gremlin:traversalmetrics"
This improvement defines a requirement to the serialization format which is
that every type *must* have a Jackson serializer and deserializer defined on
the source `ObjectMapper`. Previous not defined serializers and deserializers
have been added in this PR.
Code-wise, it's pretty much the same than for #351, the big intake in code
here is the addition of the deserializers for all Graph objects, a big
simplification to the serializers (`GraphSONSerializersV2d0`), the addition of
the "domain" to the type system, and making that new typeID format configurable
to users through the `TinkerPopJacksonModule`.
`mvn clean install` test suite passes, and it's rebased on top of current
`master`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/newkek/incubator-tinkerpop TINKERPOP-1274-rev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/386.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #386
commit 635be59cf6505a47a1ca1d27519d07e918fdc1ef
Author: Stephen Mallette
Date: 2016-05-18T12:41:26Z
TINKERPOP-1274: GraphSON 2.0.
> GraphSON Version 2.0
>
>
> Key: TINKERPOP-1274
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Priority: Minor
> Fix For: 3.2.2
>
>
> Develop a revised version of GraphSON that provides better support for
> non-JVM languages that consume it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/385 I agree with @dkuppitz . Lets make another ticket about deprecating and removing `IdentityRemovalStrategy`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1285) Gremline console does not differentiate between multi-line and single-line input
[
https://issues.apache.org/jira/browse/TINKERPOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428357#comment-15428357
]
ASF GitHub Bot commented on TINKERPOP-1285:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/385
I agree with @dkuppitz . Lets make another ticket about deprecating and
removing `IdentityRemovalStrategy`.
> Gremline console does not differentiate between multi-line and single-line
> input
>
>
> Key: TINKERPOP-1285
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1285
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.2.0-incubating
>Reporter: Rocco Varela
>Priority: Minor
>
> When entering input, say into a script variable, that extends over multiple
> lines the gremlin console does not provide the user with any indication that
> they are in a multi-line input mode. Here is an example.
> Notice the 'gremline>' prompts are presented within the triple-quotes.
> {code}
> gremlin> script = '''
> gremlin> line1_command
> gremlin> line2_command
> gremlin> '''
> {code}
> Ideally we would like something like this, showing the user that they are
> still in multi-line input mode.
> {code}
> gremlin> script = '''
> ... line1_command
> ... line2_command
> ... '''
> gremlin>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428354#comment-15428354 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/384 Thoughts: 1. I think there is a bit of an overdose of options here. Keep it simple. 2. We have to realize that not everyone has a black background as their terminal. I use a light brown. Some people use white. Thus, I don't think the default should be to use color. You can `:set` colors if you want and perhaps we even have "standard themes" -- `:set black-background-standard` (or whatever the naming convention that we are using for other `:set` commands so we are consistent in our naming of parameters. If you guys want to go with edge/vertex/etc. being able to be colored, please don't have that be part of the "standard templates." Keep things clean and simple and not a "disco club" coming at you. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/384 Thoughts: 1. I think there is a bit of an overdose of options here. Keep it simple. 2. We have to realize that not everyone has a black background as their terminal. I use a light brown. Some people use white. Thus, I don't think the default should be to use color. You can `:set` colors if you want and perhaps we even have "standard themes" -- `:set black-background-standard` (or whatever the naming convention that we are using for other `:set` commands so we are consistent in our naming of parameters. If you guys want to go with edge/vertex/etc. being able to be colored, please don't have that be part of the "standard templates." Keep things clean and simple and not a "disco club" coming at you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user alaam commented on the issue: https://github.com/apache/tinkerpop/pull/384 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428201#comment-15428201 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user alaam commented on the issue: https://github.com/apache/tinkerpop/pull/384 +1 > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428192#comment-15428192 ] Jeremy Hanna edited comment on TINKERPOP-1037 at 8/19/16 1:37 PM: -- Great to see all of this come together. Thanks [~rdale] [~spmallette] [~dkuppitz] [~okram]! was (Author: jeromatron): Great to see all of this come together. Thanks all! > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428192#comment-15428192 ] Jeremy Hanna commented on TINKERPOP-1037: - Great to see all of this come together. Thanks all! > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428159#comment-15428159 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 Attached groovy script that prints the color palette. usage: groovy jansi-colors.txt [jansi-colors.txt](https://github.com/apache/tinkerpop/files/427016/jansi-colors.txt) > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Request for graphic usage permission (Gremlin-Illustrations)
Dear Apache TinkerPop community,
my name is Thomas Efer and I am a researcher in the field of Natural
Language Processing at the University of Leipzig, Germany. A while ago, (in
the pre-Apache days of TinkerPop) I wrote an internal research prototype /
educational tool for graph data analysis ("Gremlin's Property Graph Lab")
in which I included two of the Gremlin illustrations. The software is not
public (and probably never will be, mainly for the lack of time to fix
REPL-related security issues - and eventually there will be newer and
better tools for teaching property graph & traversal basics anyway, like
Gremlin-Bin...)
With this message I would like to ask for your permission to reproduce a
screenshot of said program within my dissertation thesis about "Graph
Databases for Text Representation in the e-Humanities" (German language).
The document will be available free of charge and I would include the
needed copyright information for the image, in a way that does not suggest
any endorsement of Apache Tinkerpop.
The images in question are:
https://svn.apache.org/repos/asf/tinkerpop/site/docs/3.0.0-i
ncubating/images/gremlin-running.png (non-dressed-up)
https://svn.apache.org/repos/asf/tinkerpop/site/docs/3.0.0-i
ncubating/images/gremlin-lab-coat.png (whole character scene)
Thank you for considering my request! Please let me know if you need more
details.
Best Regards
Thomas Efer
--
Thomas Efer M.Sc
Abteilung Automatische Sprachverarbeitung
Institut für Informatik | Universität Leipzig
Augustusplatz 10 | 04109 Leipzig
phone: 0049 - 341 - 97 - 32298
fax: 0049 - 341 - 97 - 32299
mail: e...@informatik.uni-leipzig.de
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/385 We should ask ourselves if `IdentityRemovalStrategy` is really as great as it should be. We need to chain dozens of `identity()`s to prove that `IdentityRemovalStrategy` makes the traversal execution faster. This looks way too artificial to me. Why would anybody end up with dozens of `identity()`s? IMHO we should either: * deprecate the strategy and remove it completely in a later release or * remove it from the default strategies and only run performance tests for more than 5 chained `identity()`s I think I'd prefer the former as I really can't see any real use cases where this strategy would be advantageous. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1285) Gremline console does not differentiate between multi-line and single-line input
[
https://issues.apache.org/jira/browse/TINKERPOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428148#comment-15428148
]
ASF GitHub Bot commented on TINKERPOP-1285:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/385
We should ask ourselves if `IdentityRemovalStrategy` is really as great as
it should be. We need to chain dozens of `identity()`s to prove that
`IdentityRemovalStrategy` makes the traversal execution faster. This looks way
too artificial to me. Why would anybody end up with dozens of `identity()`s?
IMHO we should either:
* deprecate the strategy and remove it completely in a later release or
* remove it from the default strategies and only run performance tests for
more than 5 chained `identity()`s
I think I'd prefer the former as I really can't see any real use cases
where this strategy would be advantageous.
> Gremline console does not differentiate between multi-line and single-line
> input
>
>
> Key: TINKERPOP-1285
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1285
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.2.0-incubating
>Reporter: Rocco Varela
>Priority: Minor
>
> When entering input, say into a script variable, that extends over multiple
> lines the gremlin console does not provide the user with any indication that
> they are in a multi-line input mode. Here is an example.
> Notice the 'gremline>' prompts are presented within the triple-quotes.
> {code}
> gremlin> script = '''
> gremlin> line1_command
> gremlin> line2_command
> gremlin> '''
> {code}
> Ideally we would like something like this, showing the user that they are
> still in multi-line input mode.
> {code}
> gremlin> script = '''
> ... line1_command
> ... line2_command
> ... '''
> gremlin>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/385 I lowered the threshold for passing on that test even lower in master yesterday after i saw travis has been failing over it lately. hopefully it is low enough now - if not @dkuppitz we may need to do something else with: ```text IdentityRemovalStrategyTest$PerformanceTest>TraversalStrategyPerformanceTest.shouldBeFaster:118 null ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1285) Gremline console does not differentiate between multi-line and single-line input
[
https://issues.apache.org/jira/browse/TINKERPOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428122#comment-15428122
]
ASF GitHub Bot commented on TINKERPOP-1285:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/385
I lowered the threshold for passing on that test even lower in master
yesterday after i saw travis has been failing over it lately. hopefully it is
low enough now - if not @dkuppitz we may need to do something else with:
```text
IdentityRemovalStrategyTest$PerformanceTest>TraversalStrategyPerformanceTest.shouldBeFaster:118
null
```
> Gremline console does not differentiate between multi-line and single-line
> input
>
>
> Key: TINKERPOP-1285
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1285
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.2.0-incubating
>Reporter: Rocco Varela
>Priority: Minor
>
> When entering input, say into a script variable, that extends over multiple
> lines the gremlin console does not provide the user with any indication that
> they are in a multi-line input mode. Here is an example.
> Notice the 'gremline>' prompts are presented within the triple-quotes.
> {code}
> gremlin> script = '''
> gremlin> line1_command
> gremlin> line2_command
> gremlin> '''
> {code}
> Ideally we would like something like this, showing the user that they are
> still in multi-line input mode.
> {code}
> gremlin> script = '''
> ... line1_command
> ... line2_command
> ... '''
> gremlin>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1285) Gremline console does not differentiate between multi-line and single-line input
[
https://issues.apache.org/jira/browse/TINKERPOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428086#comment-15428086
]
ASF GitHub Bot commented on TINKERPOP-1285:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/385
This is failing due to some random error, not the code change.
> Gremline console does not differentiate between multi-line and single-line
> input
>
>
> Key: TINKERPOP-1285
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1285
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.2.0-incubating
>Reporter: Rocco Varela
>Priority: Minor
>
> When entering input, say into a script variable, that extends over multiple
> lines the gremlin console does not provide the user with any indication that
> they are in a multi-line input mode. Here is an example.
> Notice the 'gremline>' prompts are presented within the triple-quotes.
> {code}
> gremlin> script = '''
> gremlin> line1_command
> gremlin> line2_command
> gremlin> '''
> {code}
> Ideally we would like something like this, showing the user that they are
> still in multi-line input mode.
> {code}
> gremlin> script = '''
> ... line1_command
> ... line2_command
> ... '''
> gremlin>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #385: TINKERPOP-1285 added multi-line line number support
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/385 This is failing due to some random error, not the code change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (TINKERPOP-1373) Default gremlinPool to number of cores
[
https://issues.apache.org/jira/browse/TINKERPOP-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1373.
---
Resolution: Done
Fix Version/s: 3.2.2
Implemented via CTR on
https://github.com/apache/tinkerpop/commit/848e367e24a4c046b3abaf34a95ec42f6b9af628
> Default gremlinPool to number of cores
> --
>
> Key: TINKERPOP-1373
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1373
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.0-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.2
>
>
> There doesn't seem to be a ton of benefit for setting the {{gremlinPool}} to
> something greater than the number of cores. This is a better default setting
> than is currently provided. Implement so as to make it that a {{gremlinPool}}
> of zero will use {{runtime.availableProcessors()}}. Update documentation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1037) Gremlin shell output coloring
[ https://issues.apache.org/jira/browse/TINKERPOP-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427958#comment-15427958 ] ASF GitHub Bot commented on TINKERPOP-1037: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I'm definitely not the right person to pick a color scheme. Open for suggestions or we can figure it out later. Committed the vertex, edge, path coloring so you can see. > Gremlin shell output coloring > - > > Key: TINKERPOP-1037 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1037 > Project: TinkerPop > Issue Type: Improvement > Components: console >Affects Versions: 3.1.0-incubating >Reporter: Jeremy Hanna >Priority: Trivial > > In order to increase the readability of the output from the gremlin shell, it > would be nice to have some coloring in the output. For example coloring the > edges in the textual output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/384 I'm definitely not the right person to pick a color scheme. Open for suggestions or we can figure it out later. Committed the vertex, edge, path coloring so you can see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/384 Awesome! I don't like the color choice, but it's good to see that it works. How did you do it? Did you overwrite the respective `toString()` methods? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
