[jira] [Created] (TINKERPOP-1885) Various Gremlin.Net documentation updates
Florian Hockmann created TINKERPOP-1885:
---
Summary: Various Gremlin.Net documentation updates
Key: TINKERPOP-1885
URL: https://issues.apache.org/jira/browse/TINKERPOP-1885
Project: TinkerPop
Issue Type: Improvement
Components: documentation, dotnet
Affects Versions: 3.3.1, 3.2.7
Reporter: Florian Hockmann
We have some parts of the documentation regarding Gremlin.Net that should be
updated now that we have a stable release:
* Homepage: _Query Languages_ misses a reference to Gremlin.Net
* Homepage: _Language Drivers_ section still links to the repository on my
private account. It should probably link to the Gremlin.Net section in the
reference docs or to a {{README}} (see below).
* Reference docs still contain a warning that _Gremlin.Net does not yet have
an official release._
* Add a {{README}} that explains Gremlin.Net, similar to the documents we have
for the Python and Javascript GLVs.
* The {{csproj}} file contains a pretty extensive {{summary}} element, but
{{summary}} isn't part of the {{csproj}} standard. So it isn't used for
anything. It should be merged into the {{description}} element instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1882) Apply range and limit steps as early as possible
[
https://issues.apache.org/jira/browse/TINKERPOP-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357176#comment-16357176
]
stephen mallette commented on TINKERPOP-1882:
-
Strategies are really tricky. They need a lot of thought. Perhaps rather than
{{g.V(a).out().limit(123).barrier(2500).valueMap()}} we could alter the barrier
size to be like: {{g.V(a).out().barrier(123).limit(123).valueMap()}} - seems
less invasive in my mind.
> Apply range and limit steps as early as possible
>
>
> Key: TINKERPOP-1882
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1882
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Florian Hockmann
>Priority: Minor
>
> For a traversal like
> {{g.V(a).out().valueMap().limit(123)}}
> we can simply move the {{limit()}} to the left so we get:
> {{g.V(a).out().limit(123).valueMap()}}
> This avoids unnecessary database lookups.
> We should create a strategy that moves the {{limit}} and the {{range}} step
> like this to _the left_ for all {{map}} steps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1880) Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045)
[ https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357173#comment-16357173 ] stephen mallette commented on TINKERPOP-1880: - Decided to do the discussion for commiter deploys in public - no need for it to be done behind closed doors i don't think: https://lists.apache.org/thread.html/8d66d44aeb6e2ab86673277a5a6b189dcda5f648141cfe84d1042e70@%3Cdev.tinkerpop.apache.org%3E > Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045) > -- > > Key: TINKERPOP-1880 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1880 > Project: TinkerPop > Issue Type: Bug > Components: dotnet >Affects Versions: 3.2.7, 3.3.1 > Environment: Windows 10, IIS Express 10, .Net Framework 4.7.1 >Reporter: Klaus Stephan >Priority: Major > Attachments: 31-01-_2018_14-50-15.png > > > I am trying to use the Gremlin.NET nuget package in a web application (.NET > Framework 4.7.1). > The project builds successfully, but when starting it in IIS Express, I get > an error > "Strong name signature could not be verified. (HRESULT: 0x80131045)" > I tried different versions, but always get the same error. > Please fix the nuget packages so that they become usable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[DISCUSS] convenience deployments
This is generally a question for PMC members but anyone is really free to offer thoughts if they have any. Are there any concerns about committers (who are not on the PMC as of yet) handling convenience deployments? By convenience deployments, i mean deployments to nuget, npm, pypi, etc. I ask because we've run into an issue with: https://issues.apache.org/jira/browse/TINKERPOP-1880 and face a situation where the .NET tool chain currently doesn't properly strong sign artifacts on linux/macos, leaving us to deploy from windows where it does work right. As it stands, no one on the PMC really has a windows system to deploy from, but we do have committers who do and would be content to do the deployment. Personally, I don't see a problem with this arrangement especially as we have more and more specialized GLV environments to consider. Anyway, if there are no objections in the next 72 hours, we'll proceed with allowing committers to do these type of deployments. Thanks
[jira] [Commented] (TINKERPOP-1882) Apply range and limit steps as early as possible
[
https://issues.apache.org/jira/browse/TINKERPOP-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357159#comment-16357159
]
Florian Hockmann commented on TINKERPOP-1882:
-
To be honest, I didn't think about the {{LazyBarrierStrategy}} but that makes
queries like {{g.V(a).out().valueMap().limit(123)}} of course a much smaller
problem.
{quote}Without the {{barrier(2500)}} the traversal wouldn't add any extra
processing that wasn't necessary, correct?
{quote}
Yes, that was exactly my intention with this ticket.
However, shouldn't the end result be
{{g.V(a).out().limit(123).barrier(2500).valueMap()}}? So, I guess this new
strategy should ideally be applied prior to the {{LazyBarrierStrategy}}.
> Apply range and limit steps as early as possible
>
>
> Key: TINKERPOP-1882
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1882
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Florian Hockmann
>Priority: Minor
>
> For a traversal like
> {{g.V(a).out().valueMap().limit(123)}}
> we can simply move the {{limit()}} to the left so we get:
> {{g.V(a).out().limit(123).valueMap()}}
> This avoids unnecessary database lookups.
> We should create a strategy that moves the {{limit}} and the {{range}} step
> like this to _the left_ for all {{map}} steps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357143#comment-16357143 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 Great, thanks. I haven't been able to work on this recently but having that merged will help. I'll check it out and update my test as well as fix the git history of the branch for this and #772. > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #777: TINKERPOP-1862 TinkerMessenger proper handling of Dire...
Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 Great, thanks. I haven't been able to work on this recently but having that merged will help. I'll check it out and update my test as well as fix the git history of the branch for this and #772. ---
[jira] [Commented] (TINKERPOP-1880) Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045)
[ https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357140#comment-16357140 ] stephen mallette commented on TINKERPOP-1880: - I'm pretty sure I know what [~pluradj] is voting for when this gets discussion in the PMC. He surely wants to spin up his dusty old windows vm to figure out how to do this deployment. I'll start a quick discussion on the PMC mailing list about this so that he can voice his full support for his taking the reins on this. When that settles, I'll start the discussion for doing a release candidate. > Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045) > -- > > Key: TINKERPOP-1880 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1880 > Project: TinkerPop > Issue Type: Bug > Components: dotnet >Affects Versions: 3.2.7, 3.3.1 > Environment: Windows 10, IIS Express 10, .Net Framework 4.7.1 >Reporter: Klaus Stephan >Priority: Major > Attachments: 31-01-_2018_14-50-15.png > > > I am trying to use the Gremlin.NET nuget package in a web application (.NET > Framework 4.7.1). > The project builds successfully, but when starting it in IIS Express, I get > an error > "Strong name signature could not be verified. (HRESULT: 0x80131045)" > I tried different versions, but always get the same error. > Please fix the nuget packages so that they become usable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1880) Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045)
[ https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357131#comment-16357131 ] Florian Hockmann commented on TINKERPOP-1880: - Ok, so if I understand it correctly now, then we have basically three options to deploy Nuget packages until we resolved the strong-name signing problem: # [~pluradj] _volunteers_ to do it. # The PMC decides to give a committer with the necessary environment the authorization for NuGet deployments. # I use the fact that I still am registered as an owner of the package and do the deployment. (Should probably also be decided by the PMC, so basically the same as option 2. Since we decided to remove me as an owner, this would really only be a very temporary solution.) > Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045) > -- > > Key: TINKERPOP-1880 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1880 > Project: TinkerPop > Issue Type: Bug > Components: dotnet >Affects Versions: 3.2.7, 3.3.1 > Environment: Windows 10, IIS Express 10, .Net Framework 4.7.1 >Reporter: Klaus Stephan >Priority: Major > Attachments: 31-01-_2018_14-50-15.png > > > I am trying to use the Gremlin.NET nuget package in a web application (.NET > Framework 4.7.1). > The project builds successfully, but when starting it in IIS Express, I get > an error > "Strong name signature could not be verified. (HRESULT: 0x80131045)" > I tried different versions, but always get the same error. > Please fix the nuget packages so that they become usable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357120#comment-16357120 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 #794 and #795 have both merged now. @PBGraff you now have a test graph with a single simple self-loop subgraph that you can use (and obviously add other test subgraphs as needed). hope that helps move this PR forward. please let me know if you have any questions > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > - > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #777: TINKERPOP-1862 TinkerMessenger proper handling of Dire...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/777 #794 and #795 have both merged now. @PBGraff you now have a test graph with a single simple self-loop subgraph that you can use (and obviously add other test subgraphs as needed). hope that helps move this PR forward. please let me know if you have any questions ---
[jira] [Commented] (TINKERPOP-1877) Add new graph data for specialized testing scenarios
[ https://issues.apache.org/jira/browse/TINKERPOP-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357114#comment-16357114 ] ASF GitHub Bot commented on TINKERPOP-1877: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/794 > Add new graph data for specialized testing scenarios > > > Key: TINKERPOP-1877 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1877 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Fix For: 3.2.8, 3.3.2 > > > This specialized graph will contain different types of subgraphs that can be > used with one or more specific test cases. Each subgraph will be disconnected > and test cases will need to take care to restrict their traversals to just > those subgraphs that matter for their particular scenario. Initially, we need > a subgraph that has a self-loop for TINKERPOP-1862 but other subgraphs might > become useful - like a tree structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (TINKERPOP-1877) Add new graph data for specialized testing scenarios
[ https://issues.apache.org/jira/browse/TINKERPOP-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1877. --- Resolution: Done Fix Version/s: 3.3.2 3.2.8 > Add new graph data for specialized testing scenarios > > > Key: TINKERPOP-1877 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1877 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Fix For: 3.2.8, 3.3.2 > > > This specialized graph will contain different types of subgraphs that can be > used with one or more specific test cases. Each subgraph will be disconnected > and test cases will need to take care to restrict their traversals to just > those subgraphs that matter for their particular scenario. Initially, we need > a subgraph that has a self-loop for TINKERPOP-1862 but other subgraphs might > become useful - like a tree structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1877) Add new graph data for specialized testing scenarios
[ https://issues.apache.org/jira/browse/TINKERPOP-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357115#comment-16357115 ] ASF GitHub Bot commented on TINKERPOP-1877: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/795 > Add new graph data for specialized testing scenarios > > > Key: TINKERPOP-1877 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1877 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > Fix For: 3.2.8, 3.3.2 > > > This specialized graph will contain different types of subgraphs that can be > used with one or more specific test cases. Each subgraph will be disconnected > and test cases will need to take care to restrict their traversals to just > those subgraphs that matter for their particular scenario. Initially, we need > a subgraph that has a self-loop for TINKERPOP-1862 but other subgraphs might > become useful - like a tree structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #794: TINKERPOP-1877 Added the "kitchen sink" toy gra...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/794 ---
[GitHub] tinkerpop pull request #795: TINKERPOP-1877 Added the "kitchen sink" toy gra...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/795 ---
[jira] [Commented] (TINKERPOP-1880) Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045)
[ https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357104#comment-16357104 ] stephen mallette commented on TINKERPOP-1880: - I think you misread that section. They don't need a VOTE, just lazy consensus. And, no, I'm not aware of anyone on the PMC who has a windows machine, other than maybe [~pluradj] (he should have never let anyone know he had that - haha). I guess it is misleading (in that same doc) to say than only a PMC member can deploy. That probably isn't true for nuget as the PMC controls who has access to that and could give a committer the necessary authorization to do so. As that has not come up before, I guess that would need to be discussed internally if we want to allow that.. > Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045) > -- > > Key: TINKERPOP-1880 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1880 > Project: TinkerPop > Issue Type: Bug > Components: dotnet >Affects Versions: 3.2.7, 3.3.1 > Environment: Windows 10, IIS Express 10, .Net Framework 4.7.1 >Reporter: Klaus Stephan >Priority: Major > Attachments: 31-01-_2018_14-50-15.png > > > I am trying to use the Gremlin.NET nuget package in a web application (.NET > Framework 4.7.1). > The project builds successfully, but when starting it in IIS Express, I get > an error > "Strong name signature could not be verified. (HRESULT: 0x80131045)" > I tried different versions, but always get the same error. > Please fix the nuget packages so that they become usable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1880) Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045)
[ https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357092#comment-16357092 ] Florian Hockmann commented on TINKERPOP-1880: - bq. I'm not against doing that. It could be proposed on the dev list. Of course, I don't have a windows system to deploy from, so someone else would have to volunteer to do it. It still needs to be a PMC member, right? At least the Developer Documentation mentions that under [_Development Versions_|http://tinkerpop.apache.org/docs/3.3.1/dev/developer/#_development_versions]: bq. These releases do not require a VOTE and do not require a "release manager". *Any PMC member* can deploy them. So has any PMC member a Windows environment with .NET Core installed? > Gremlin.NET Strong name signature could not be verified. (HRESULT: 0x80131045) > -- > > Key: TINKERPOP-1880 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1880 > Project: TinkerPop > Issue Type: Bug > Components: dotnet >Affects Versions: 3.2.7, 3.3.1 > Environment: Windows 10, IIS Express 10, .Net Framework 4.7.1 >Reporter: Klaus Stephan >Priority: Major > Attachments: 31-01-_2018_14-50-15.png > > > I am trying to use the Gremlin.NET nuget package in a web application (.NET > Framework 4.7.1). > The project builds successfully, but when starting it in IIS Express, I get > an error > "Strong name signature could not be verified. (HRESULT: 0x80131045)" > I tried different versions, but always get the same error. > Please fix the nuget packages so that they become usable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1877) Add new graph data for specialized testing scenarios
[ https://issues.apache.org/jira/browse/TINKERPOP-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357005#comment-16357005 ] ASF GitHub Bot commented on TINKERPOP-1877: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/795 VOTE +1 > Add new graph data for specialized testing scenarios > > > Key: TINKERPOP-1877 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1877 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > > This specialized graph will contain different types of subgraphs that can be > used with one or more specific test cases. Each subgraph will be disconnected > and test cases will need to take care to restrict their traversals to just > those subgraphs that matter for their particular scenario. Initially, we need > a subgraph that has a self-loop for TINKERPOP-1862 but other subgraphs might > become useful - like a tree structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1877) Add new graph data for specialized testing scenarios
[ https://issues.apache.org/jira/browse/TINKERPOP-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357004#comment-16357004 ] ASF GitHub Bot commented on TINKERPOP-1877: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/794 VOTE +1 > Add new graph data for specialized testing scenarios > > > Key: TINKERPOP-1877 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1877 > Project: TinkerPop > Issue Type: Improvement > Components: test-suite >Affects Versions: 3.2.7 >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Major > > This specialized graph will contain different types of subgraphs that can be > used with one or more specific test cases. Each subgraph will be disconnected > and test cases will need to take care to restrict their traversals to just > those subgraphs that matter for their particular scenario. Initially, we need > a subgraph that has a self-loop for TINKERPOP-1862 but other subgraphs might > become useful - like a tree structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #795: TINKERPOP-1877 Added the "kitchen sink" toy graph (mas...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/795 VOTE +1 ---
[GitHub] tinkerpop issue #794: TINKERPOP-1877 Added the "kitchen sink" toy graph
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/794 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net
[
https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356760#comment-16356760
]
ASF GitHub Bot commented on TINKERPOP-1854:
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/792
The discussion on
[TINKERPOP-1857](https://issues.apache.org/jira/browse/TINKERPOP-1857) shows
that we actually still need the functionality to ignore tests. So I'll have to
update this PR to keep that functionality in.
> Support lambdas in Gremlin.Net
> --
>
> Key: TINKERPOP-1854
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1854
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
>Affects Versions: 3.3.0, 3.2.6
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Major
>
> Gremlin.Net should support lambdas. We already discussed this in [the pull
> request for TINKERPOP-1752|https://github.com/apache/tinkerpop/pull/712].
> Here is what [~spmallette] said over there:
> {quote}
> Any reason we don't support lambdas? Even if .NET can't support them natively
> for some reason wouldn't we minimally support the ability to pass a
> python/groovy/etc lambda? it's kinda weird that way, but i think back to the
> point that kuppitz made on the dev list the other day where he stated that he
> doesn't always find a way out of using lambdas in production systems he works
> on - so ultimately users will need that kind of capability i think.
> {quote}
> C# lambdas would require some kind of C# parser on the server side, so at
> least in the beginning a way to send lambdas from already supported languages
> in Gremlin.Net should be enough.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #792: TINKERPOP-1854 Add Lambdas for Gremlin.Net
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/792 The discussion on [TINKERPOP-1857](https://issues.apache.org/jira/browse/TINKERPOP-1857) shows that we actually still need the functionality to ignore tests. So I'll have to update this PR to keep that functionality in. ---
[jira] [Commented] (TINKERPOP-1857) GLV test suite consistency and completeness
[
https://issues.apache.org/jira/browse/TINKERPOP-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356648#comment-16356648
]
Jorge Bay commented on TINKERPOP-1857:
--
We can ignore tests on .NET GLV:
{code:java}
IgnoredScenarios = new Dictionary
{
{ "g_V_branchXlabel_eq_person", IgnoreReason.NeedsFurtherInvestigation },
{ "scenario name", IgnoreReason.AnotherReason },
};
{code}
https://github.com/apache/tinkerpop/blob/tp32/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L62
and on the JavaScript GLV:
{code:javascript}
const ignoredScenarios = {
// An associative array containing the scenario name as key and the error as
value:
'g_V_branchXlabel_eq_person': new
IgnoreError(ignoreReason.lambdaNotSupported),
};
{code}
https://github.com/apache/tinkerpop/blob/tp32/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L62
> GLV test suite consistency and completeness
> ---
>
> Key: TINKERPOP-1857
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1857
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.2.8, 3.3.2
>
>
> While the GLV test suite was largely completed in 3.2.7/3.3.1 there were a
> number of tests that weren't fully migrated and minor naming inconsistencies
> that needed to be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
