[jira] [Updated] (TINKERPOP-2126) toString() methods not thread-safe

2019-01-22 Thread Daniel Kuppitz (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz updated TINKERPOP-2126:
--
Summary: toString() methods not thread-safe  (was: TraverserSet's 
toString() is not thread-safe)

> toString() methods not thread-safe
> --
>
> Key: TINKERPOP-2126
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2126
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
> Fix For: 3.3.6, 3.4.1
>
>
> {{TraverserSet::toString()}} is not thread-safe as it uses an iterator on the 
> internal map, which could concurrently be modified (most likely in OLAP 
> environments).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (TINKERPOP-2126) TraverserSet's toString() is not thread-safe

2019-01-22 Thread Daniel Kuppitz (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz reopened TINKERPOP-2126:
---

Reopening as the same issue occurred in {{ObjectWritable}}'s {{toString()}} 
method.

> TraverserSet's toString() is not thread-safe
> 
>
> Key: TINKERPOP-2126
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2126
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
> Fix For: 3.3.6, 3.4.1
>
>
> {{TraverserSet::toString()}} is not thread-safe as it uses an iterator on the 
> internal map, which could concurrently be modified (most likely in OLAP 
> environments).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (TINKERPOP-2138) Provide a configuration to disable the global closure cache

2019-01-22 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-2138:
---

 Summary: Provide a configuration to disable the global closure 
cache
 Key: TINKERPOP-2138
 URL: https://issues.apache.org/jira/browse/TINKERPOP-2138
 Project: TinkerPop
  Issue Type: Improvement
  Components: groovy
Affects Versions: 3.3.5
Reporter: stephen mallette
Assignee: stephen mallette


There are situations where users and/or providers might want to disable the 
global closure cache in the {{GremlinGroovyScriptEngine}} - provide a 
{{Customizer}} to do that (or modify an existing one if possible to carry the 
configuration option). By default, the cache would remain enabled for now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (TINKERPOP-2136) Inside lower bound inclusion (documentation)

2019-01-22 Thread Daniel Kuppitz (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz closed TINKERPOP-2136.
-
   Resolution: Fixed
Fix Version/s: 3.4.1
   3.3.6

> Inside lower bound inclusion (documentation)
> 
>
> Key: TINKERPOP-2136
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2136
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.5
>Reporter: Martijn Dwars
>Assignee: Daniel Kuppitz
>Priority: Minor
> Fix For: 3.3.6, 3.4.1
>
>
> On [http://tinkerpop.apache.org/docs/current/reference/#has-step] there is an 
> example:
> {code:java}
> g.V().has('age',inside(20,30)).values('age') // 1
> {code}
> with the comment:
> {code:java}
> Find all vertices whose ages are between 20 (inclusive) and 30 (exclusive).
> {code}
> But if I run this in the Gremlin Groovy shell I see:
> {code:java}
> gremlin> g.V().has('age', inside(10, 30)).toString()
> ==>[GraphStep(vertex,[]), HasStep([age.and(gt(10), lt(30))])]
> {code}
> which means the lower bound and upper bound are both exclusive. In 
> particular, the lower bound is exclusive, _not_ inclusive. Right?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-2136) Inside lower bound inclusion (documentation)

2019-01-22 Thread Daniel Kuppitz (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748807#comment-16748807
 ] 

Daniel Kuppitz commented on TINKERPOP-2136:
---

I just go ahead and merge the changes into {{tp33}} and {{master}}. Not worth a 
PR as it's just a minor fix in the user docs.

> Inside lower bound inclusion (documentation)
> 
>
> Key: TINKERPOP-2136
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2136
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.5
>Reporter: Martijn Dwars
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> On [http://tinkerpop.apache.org/docs/current/reference/#has-step] there is an 
> example:
> {code:java}
> g.V().has('age',inside(20,30)).values('age') // 1
> {code}
> with the comment:
> {code:java}
> Find all vertices whose ages are between 20 (inclusive) and 30 (exclusive).
> {code}
> But if I run this in the Gremlin Groovy shell I see:
> {code:java}
> gremlin> g.V().has('age', inside(10, 30)).toString()
> ==>[GraphStep(vertex,[]), HasStep([age.and(gt(10), lt(30))])]
> {code}
> which means the lower bound and upper bound are both exclusive. In 
> particular, the lower bound is exclusive, _not_ inclusive. Right?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] jorgebay commented on issue #1031: TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers

2019-01-22 Thread GitHub
VOTE +1 :shipit: 

[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Closed] (TINKERPOP-2131) NoConnectionAvailableException doesn't reveal the reason

2019-01-22 Thread Florian Hockmann (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Florian Hockmann closed TINKERPOP-2131.
---
   Resolution: Fixed
Fix Version/s: 3.4.1

> NoConnectionAvailableException doesn't reveal the reason
> 
>
> Key: TINKERPOP-2131
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2131
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Affects Versions: 3.4.0
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
> Fix For: 3.4.1
>
>
> The Gremlin.Net driver throws a {{NoConnectionAvailableException}} if it 
> can't get a connection from the pool. This can happen in two cases:
>  # All connections are busy (reached their max requests in flight limit)
>  # The pool is empty, e.g., because the server isn't reachable
> Unfortunately, it's currently impossible to tell from the exception which of 
> these cases caused the exception. The exception message should contain this 
> information as the first case means that users should probably increase the 
> limits whereas the second case just means that there is a general 
> connectivity problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (TINKERPOP-2088) Enable SourceLink for Gremlin.Net

2019-01-22 Thread Florian Hockmann (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Florian Hockmann closed TINKERPOP-2088.
---
   Resolution: Fixed
Fix Version/s: 3.4.1
   3.3.6

> Enable SourceLink for Gremlin.Net
> -
>
> Key: TINKERPOP-2088
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2088
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
> Fix For: 3.3.6, 3.4.1
>
>
> SourceLink allows users to step into the sources of a library during 
> debugging. Description [from the dotnet 
> docs|https://docs.microsoft.com/dotnet/standard/library-guidance/sourcelink]:
> {quote}SourceLink is a technology that enables source code debugging of .NET 
> assemblies from NuGet by developers. SourceLink executes when creating the 
> NuGet package and embeds source control metadata inside assemblies and the 
> package. Developers who download the package and have SourceLink enabled in 
> Visual Studio can step into its source code. SourceLink provides source 
> control metadata to create a great debugging experience.
> {quote}
> While the quote only mentions Visual Studio, it should also work with Rider 
> and VS Code.
> The sources are fetched from GitHub. The NuGet package includes information 
> about which commit was used to build the package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-2088) Enable SourceLink for Gremlin.Net

2019-01-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748704#comment-16748704
 ] 

ASF GitHub Bot commented on TINKERPOP-2088:
---

FlorianHockmann commented on pull request #1026: TINKERPOP-2088 Enable 
SourceLink for Gremlin.Net
URL: https://github.com/apache/tinkerpop/pull/1026
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable SourceLink for Gremlin.Net
> -
>
> Key: TINKERPOP-2088
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2088
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
>
> SourceLink allows users to step into the sources of a library during 
> debugging. Description [from the dotnet 
> docs|https://docs.microsoft.com/dotnet/standard/library-guidance/sourcelink]:
> {quote}SourceLink is a technology that enables source code debugging of .NET 
> assemblies from NuGet by developers. SourceLink executes when creating the 
> NuGet package and embeds source control metadata inside assemblies and the 
> package. Developers who download the package and have SourceLink enabled in 
> Visual Studio can step into its source code. SourceLink provides source 
> control metadata to create a great debugging experience.
> {quote}
> While the quote only mentions Visual Studio, it should also work with Rider 
> and VS Code.
> The sources are fetched from GitHub. The NuGet package includes information 
> about which commit was used to build the package.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] FlorianHockmann closed pull request #1026: TINKERPOP-2088 Enable SourceLink for Gremlin.Net

2019-01-22 Thread GitHub
[ pull request closed by FlorianHockmann ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Commented] (TINKERPOP-2131) NoConnectionAvailableException doesn't reveal the reason

2019-01-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748699#comment-16748699
 ] 

ASF GitHub Bot commented on TINKERPOP-2131:
---

FlorianHockmann commented on pull request #1039: TINKERPOP-2131 Gremlin.Net: 
Better explain connection pool exceptions
URL: https://github.com/apache/tinkerpop/pull/1039
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> NoConnectionAvailableException doesn't reveal the reason
> 
>
> Key: TINKERPOP-2131
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2131
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Affects Versions: 3.4.0
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
>
> The Gremlin.Net driver throws a {{NoConnectionAvailableException}} if it 
> can't get a connection from the pool. This can happen in two cases:
>  # All connections are busy (reached their max requests in flight limit)
>  # The pool is empty, e.g., because the server isn't reachable
> Unfortunately, it's currently impossible to tell from the exception which of 
> these cases caused the exception. The exception message should contain this 
> information as the first case means that users should probably increase the 
> limits whereas the second case just means that there is a general 
> connectivity problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] FlorianHockmann closed pull request #1039: TINKERPOP-2131 Gremlin.Net: Better explain connection pool exceptions

2019-01-22 Thread GitHub
[ pull request closed by FlorianHockmann ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1039 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Assigned] (TINKERPOP-2136) Inside lower bound inclusion (documentation)

2019-01-22 Thread stephen mallette (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette reassigned TINKERPOP-2136:
---

 Assignee: Daniel Kuppitz
Affects Version/s: 3.3.5
 Priority: Minor  (was: Trivial)
  Component/s: process

> Inside lower bound inclusion (documentation)
> 
>
> Key: TINKERPOP-2136
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2136
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.5
>Reporter: Martijn Dwars
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> On [http://tinkerpop.apache.org/docs/current/reference/#has-step] there is an 
> example:
> {code:java}
> g.V().has('age',inside(20,30)).values('age') // 1
> {code}
> with the comment:
> {code:java}
> Find all vertices whose ages are between 20 (inclusive) and 30 (exclusive).
> {code}
> But if I run this in the Gremlin Groovy shell I see:
> {code:java}
> gremlin> g.V().has('age', inside(10, 30)).toString()
> ==>[GraphStep(vertex,[]), HasStep([age.and(gt(10), lt(30))])]
> {code}
> which means the lower bound and upper bound are both exclusive. In 
> particular, the lower bound is exclusive, _not_ inclusive. Right?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] spmallette commented on issue #1031: TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers

2019-01-22 Thread GitHub
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] spmallette commented on issue #1040: TINKERPOP-1882 Apply range and limit steps as early as possible

2019-01-22 Thread GitHub
please give me a little extra time to review this one - i had my head in other 
things last week.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] spmallette commented on issue #1041: TINKERPOP-2125 Extend release validation script

2019-01-22 Thread GitHub
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org