[jira] [Commented] (TINKERPOP-3060) Dependency inconsistency between modules.
[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853752#comment-17853752
]
ASF GitHub Bot commented on TINKERPOP-3060:
---
xiazcy closed pull request #2546: [TINKERPOP-3060] Manage the versions of
snappy-java and jackson-* centrally to avoid version conflict.
URL: https://github.com/apache/tinkerpop/pull/2546
> Dependency inconsistency between modules.
> -
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Reporter: Wei Zhao
>Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> -
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> -
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3060) Dependency inconsistency between modules.
[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852154#comment-17852154
]
ASF GitHub Bot commented on TINKERPOP-3060:
---
xiazcy commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2148166240
Hi @HappyHacker123, much apologies for the late reply. I gave it some more
thoughts, and while this will be a great improvement, I don't think we are
quite ready to centralize these dependencies yet. The complexity is mainly due
to the way dependencies are currently managed that’s leading to conflicts and
may require module-specific versions, especially in hadoop and spark modules
(as you may see some of the code comments in the poms). We are looking to
improve this systemically, but before a decision is reached I think we’ll hold
off on this PR and close it for now.
If you are still interested and have thoughts or recommendations related to
dependency management, chime into our discussions for [removing
gremlin-shaded](https://lists.apache.org/thread/m7yvvz9zc69nzn0nr6vz0tdo3ggffoy6)
and [JPMS](https://lists.apache.org/thread/vkvqcxn6t2lsgpfym7v3g3qvksrh3cwc).
We'd love to see more opinions on these topics. Again, thank you for taking the
time submitting this PR!
> Dependency inconsistency between modules.
> -
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Reporter: Wei Zhao
>Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> -
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> -
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3060) Dependency inconsistency between modules.
[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835417#comment-17835417
]
ASF GitHub Bot commented on TINKERPOP-3060:
---
HappyHacker123 commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2045162964
Thanks for your response :) @xiazcy .
> Note that we are in the middle of a release so we'll hold off on any
merging and I'll revisit this PR once the release is done.
Sure, I'm fully supportive of holding off the pr until after the release is
completed :).
> I do want to take a closer look into other pom files that might be able to
take advantage of this.
Actually i ran a check on the whole Tinkerpop project and found many other
situation like this. If you need it, i'm happy to provide the whole list :).
> Dependency inconsistency between modules.
> -
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
>Reporter: Wei Zhao
>Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> -
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> -
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3060) Dependency inconsistency between modules.
[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835014#comment-17835014
]
ASF GitHub Bot commented on TINKERPOP-3060:
---
xiazcy commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2043393487
Thanks for the PR @HappyHacker123! I like the improvement for the dependency
version management. I do want to take a closer look into other pom files that
might be able to take advantage of this. Note that we are in the middle of a
release so we'll hold off on any merging and I'll revisit once this PR the
release is done.
> Dependency inconsistency between modules.
> -
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
>Reporter: Wei Zhao
>Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> -
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> -
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3060) Dependency inconsistency between modules.
[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834901#comment-17834901
]
ASF GitHub Bot commented on TINKERPOP-3060:
---
codecov-commenter commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2042581374
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 76.49%. Comparing base
[(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
to head
[(`8b1e8bd`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
> Report is 54 commits behind head on 3.7-dev.
Additional details and impacted files
```diff
@@ Coverage Diff @@
## 3.7-dev#2546 +/- ##
=
+ Coverage 76.14% 76.49% +0.34%
- Complexity 1315213174 +22
=
Files 1084 1059 -25
Lines 6516061282-3878
Branches7285 7297 +12
=
- Hits 4961646876-2740
+ Misses 1283911892 -947
+ Partials2705 2514 -191
```
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2546?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
> Dependency inconsistency between modules.
> -
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
>Reporter: Wei Zhao
>Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> -
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> -
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3060) Dependency inconsistency between modules.
[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834894#comment-17834894
]
ASF GitHub Bot commented on TINKERPOP-3060:
---
HappyHacker123 commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2042543921
@xiazcy @Cole-Greer Could you please help me review this pr? Many thanks :)
> Dependency inconsistency between modules.
> -
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
>Reporter: Wei Zhao
>Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> -
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> -
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3060) Dependency inconsistency between modules.
[
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834890#comment-17834890
]
ASF GitHub Bot commented on TINKERPOP-3060:
---
HappyHacker123 opened a new pull request, #2546:
URL: https://github.com/apache/tinkerpop/pull/2546
Currently some modules of Tinkerpop are using the same dependency. However,
some of these dependencies' versions are not centrally managed and therefore
cause discrepancy. This pr defines version in parent pom.xml centrally to avoid
version conflict.
> Dependency inconsistency between modules.
> -
>
> Key: TINKERPOP-3060
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
> Project: TinkerPop
> Issue Type: Improvement
>Reporter: Wei Zhao
>Priority: Major
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However,
> some of these dependencies' versions are not centrally managed and therefore
> cause discrepancy.
> I found the following dependencies with different versions in different
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.4}
> /spark-gremlin
> Dependency {groupId=org.xerial.snappy, artifactId=snappy-java,
> version=1.1.8.2}
> /hadoop-gremlin
> -
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent
> versions.
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.15.2}
> /gremlin-shaded
> Dependency {groupId=com.fasterxml.jackson.core,
> artifactId=jackson-databind, version=2.13.5}
> /spark-gremlin
> /hadoop-gremlin
> -
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict
> for downstream projects. So it's better to align the versions of the
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid
> possible conflicts. And if it's possible, manage the versions of the
> dependencies centrally.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
