Re: [DISCUSS] Proposing 3.6.4 Patch Release
Hi all, The .NET memory leak fix for the 3.5.x line is now released as 3.5.7-rc1. https://www.nuget.org/packages/Gremlin.Net/3.5.7-rc1 https://www.nuget.org/packages/Gremlin.Net.Template/3.5.7-rc1 Cheers, Yang On Wed, May 17, 2023 at 7:46 PM Yang Xia wrote: > Hi all, > > The code freeze is now lifted with TinkerPop 3.6.4 released. > > The release branches are now back in SNAPSHOT mode and development can > recommence on the 3.5-dev and 3.6-dev lines. > > Cheers, > > Yang > > On Thu, May 11, 2023 at 5:09 PM Yang Xia wrote: > >> Hi Florian, >> >> Yup, it makes sense to include it. I think we can also do a .NET 3.5.7 RC >> release for the fix without adding burden to the patch release process. >> >> In any case, let's try merging everything by Friday noon PT, including >> the LICENSE/NOTICE updates. Then I will begin preparing for the 3.6.4 VOTE >> thread. >> >> Regards, >> >> Yang >> >> On Thu, May 11, 2023 at 7:57 AM Florian Hockmann >> wrote: >> >>> Hi, >>> >>> Would be great if we could include my PR for the memory leak fix. I just >>> had to modify the commit again as my fix apparently wasn't complete, but >>> now it should be in a good state. >>> But I agree that a 3.5.7 isn't necessary for this. Most .NET users >>> directly use the latest releases and don't stay on 3.5. We had for example >>> 8,600 downloads for 3.6.2, but only 1,400 for 3.5.5 and even 75,000 for >>> 3.6.1, but only 8,600 for 3.5.4 according to nuget.org. >>> >>> Regards, >>> Florian >>> >>> -Ursprüngliche Nachricht- >>> Von: Yang Xia >>> Gesendet: Mittwoch, 10. Mai 2023 22:28 >>> An: dev@tinkerpop.apache.org >>> Betreff: [DISCUSS] Proposing 3.6.4 Patch Release >>> >>> Hi all, >>> >>> In light of a recently discovered critical bug in TextP.regex() >>> serialization in 3.6.x ( >>> https://issues.apache.org/jira/browse/TINKERPOP-2945), >>> which unfortunately missed the 3.6.3 release, I'd like to propose a >>> patch release as 3.6.4 to bring this fix to the users as soon as possible. >>> >>> Given we just had a release and no new changes have been merged, I >>> propose we can skip the code freeze week and begin the preparation for the >>> release VOTE on 3.6.4 once the fix is merged ( >>> https://github.com/apache/tinkerpop/pull/2059). We will essentially be >>> performing a full release on the 3.6.4 branch only. >>> >>> The 3.5-dev and 3.6-dev branches will need to be frozen to any changes >>> which would fall outside of this 3.6.4 patch release. I do want to point >>> out a .NET memory leak fix in 3.5 ( >>> https://issues.apache.org/jira/browse/TINKERPOP-2944), with PR ( >>> https://github.com/apache/tinkerpop/pull/2058) by Florian may warrant >>> inclusion in this patch release. I would welcome any feedback regarding the >>> inclusion of this change in a 3.6.4 patch release, as well as if it would >>> also justify a 3.5.7 patch release. If there are no responses, I will >>> assume a lazy consensus supporting a 3.6.4 patch release only, with the >>> only significant change being TINKERPOP-2945. I would also look to include >>> a few trivial changes such as >>> https://github.com/apache/tinkerpop/pull/2052 >>> and fixes to the console and server NOTICE files. >>> >>> Feel free to comment on this thread if you have any questions or >>> concerns. >>> >>> Regards, >>> >>> Yang >>> *--* >>> *Yang Xia* >>> >>>
Re: [DISCUSS] Proposing 3.6.4 Patch Release
Hi all, The code freeze is now lifted with TinkerPop 3.6.4 released. The release branches are now back in SNAPSHOT mode and development can recommence on the 3.5-dev and 3.6-dev lines. Cheers, Yang On Thu, May 11, 2023 at 5:09 PM Yang Xia wrote: > Hi Florian, > > Yup, it makes sense to include it. I think we can also do a .NET 3.5.7 RC > release for the fix without adding burden to the patch release process. > > In any case, let's try merging everything by Friday noon PT, including the > LICENSE/NOTICE updates. Then I will begin preparing for the 3.6.4 VOTE > thread. > > Regards, > > Yang > > On Thu, May 11, 2023 at 7:57 AM Florian Hockmann > wrote: > >> Hi, >> >> Would be great if we could include my PR for the memory leak fix. I just >> had to modify the commit again as my fix apparently wasn't complete, but >> now it should be in a good state. >> But I agree that a 3.5.7 isn't necessary for this. Most .NET users >> directly use the latest releases and don't stay on 3.5. We had for example >> 8,600 downloads for 3.6.2, but only 1,400 for 3.5.5 and even 75,000 for >> 3.6.1, but only 8,600 for 3.5.4 according to nuget.org. >> >> Regards, >> Florian >> >> -Ursprüngliche Nachricht- >> Von: Yang Xia >> Gesendet: Mittwoch, 10. Mai 2023 22:28 >> An: dev@tinkerpop.apache.org >> Betreff: [DISCUSS] Proposing 3.6.4 Patch Release >> >> Hi all, >> >> In light of a recently discovered critical bug in TextP.regex() >> serialization in 3.6.x ( >> https://issues.apache.org/jira/browse/TINKERPOP-2945), >> which unfortunately missed the 3.6.3 release, I'd like to propose a patch >> release as 3.6.4 to bring this fix to the users as soon as possible. >> >> Given we just had a release and no new changes have been merged, I >> propose we can skip the code freeze week and begin the preparation for the >> release VOTE on 3.6.4 once the fix is merged ( >> https://github.com/apache/tinkerpop/pull/2059). We will essentially be >> performing a full release on the 3.6.4 branch only. >> >> The 3.5-dev and 3.6-dev branches will need to be frozen to any changes >> which would fall outside of this 3.6.4 patch release. I do want to point >> out a .NET memory leak fix in 3.5 ( >> https://issues.apache.org/jira/browse/TINKERPOP-2944), with PR ( >> https://github.com/apache/tinkerpop/pull/2058) by Florian may warrant >> inclusion in this patch release. I would welcome any feedback regarding the >> inclusion of this change in a 3.6.4 patch release, as well as if it would >> also justify a 3.5.7 patch release. If there are no responses, I will >> assume a lazy consensus supporting a 3.6.4 patch release only, with the >> only significant change being TINKERPOP-2945. I would also look to include >> a few trivial changes such as >> https://github.com/apache/tinkerpop/pull/2052 >> and fixes to the console and server NOTICE files. >> >> Feel free to comment on this thread if you have any questions or concerns. >> >> Regards, >> >> Yang >> *--* >> *Yang Xia* >> >>
Re: [DISCUSS] Proposing 3.6.4 Patch Release
Hi Florian, Yup, it makes sense to include it. I think we can also do a .NET 3.5.7 RC release for the fix without adding burden to the patch release process. In any case, let's try merging everything by Friday noon PT, including the LICENSE/NOTICE updates. Then I will begin preparing for the 3.6.4 VOTE thread. Regards, Yang On Thu, May 11, 2023 at 7:57 AM Florian Hockmann wrote: > Hi, > > Would be great if we could include my PR for the memory leak fix. I just > had to modify the commit again as my fix apparently wasn't complete, but > now it should be in a good state. > But I agree that a 3.5.7 isn't necessary for this. Most .NET users > directly use the latest releases and don't stay on 3.5. We had for example > 8,600 downloads for 3.6.2, but only 1,400 for 3.5.5 and even 75,000 for > 3.6.1, but only 8,600 for 3.5.4 according to nuget.org. > > Regards, > Florian > > -Ursprüngliche Nachricht- > Von: Yang Xia > Gesendet: Mittwoch, 10. Mai 2023 22:28 > An: dev@tinkerpop.apache.org > Betreff: [DISCUSS] Proposing 3.6.4 Patch Release > > Hi all, > > In light of a recently discovered critical bug in TextP.regex() > serialization in 3.6.x ( > https://issues.apache.org/jira/browse/TINKERPOP-2945), > which unfortunately missed the 3.6.3 release, I'd like to propose a patch > release as 3.6.4 to bring this fix to the users as soon as possible. > > Given we just had a release and no new changes have been merged, I propose > we can skip the code freeze week and begin the preparation for the release > VOTE on 3.6.4 once the fix is merged ( > https://github.com/apache/tinkerpop/pull/2059). We will essentially be > performing a full release on the 3.6.4 branch only. > > The 3.5-dev and 3.6-dev branches will need to be frozen to any changes > which would fall outside of this 3.6.4 patch release. I do want to point > out a .NET memory leak fix in 3.5 ( > https://issues.apache.org/jira/browse/TINKERPOP-2944), with PR ( > https://github.com/apache/tinkerpop/pull/2058) by Florian may warrant > inclusion in this patch release. I would welcome any feedback regarding the > inclusion of this change in a 3.6.4 patch release, as well as if it would > also justify a 3.5.7 patch release. If there are no responses, I will > assume a lazy consensus supporting a 3.6.4 patch release only, with the > only significant change being TINKERPOP-2945. I would also look to include > a few trivial changes such as > https://github.com/apache/tinkerpop/pull/2052 > and fixes to the console and server NOTICE files. > > Feel free to comment on this thread if you have any questions or concerns. > > Regards, > > Yang > *--* > *Yang Xia* > >
